lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.
Thank you for the review!
Comment at: lib/Sema/SemaCast.cpp:94-101
+void updatePartOfExplicitCastFlags(CastExpr *CE) {
+ // Walk down from the CE to the OrigSrcExpr, and mark all immediate
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337811: For x86_64, gcc 7.2 under Amazon Linux AMI sets its
path to x86_64-amazon-linux. (authored by jiadinggai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:
ahatanak added a comment.
Note that in order to destruct C++ objects, I'm using pushDestroy which pushes
a NormalCleanup when exception handling isn't enabled. This is different from
PushDestructorCleanup which always pushes a NormalAndEHCleanup, but I think
using pushDestroy is more correct si
ahatanak created this revision.
ahatanak added a reviewer: rjmccall.
Herald added a subscriber: dexonsmith.
Block copy/dispose helper functions currently aren’t exception-safe. When an
exception is thrown in a copy function, the function exits without destroying
or releasing C++ objects, ObjC ob
Author: marshall
Date: Mon Jul 23 20:56:38 2018
New Revision: 337809
URL: http://llvm.org/viewvc/llvm-project?rev=337809&view=rev
Log:
fix nesting of namespace and standard-version check. Also include <__config>
Modified:
libcxx/trunk/include/span
Modified: libcxx/trunk/include/span
URL:
ht
ldionne added a comment.
LGTM. FWIW, I'm really not a huge fan of all these different ways of building
libc++. There should be one canonical way of doing it, and it should be simple.
However, it seems like this patch is the right thing to do given the changes
that have already been made to acco
Author: marshall
Date: Mon Jul 23 20:41:36 2018
New Revision: 337808
URL: http://llvm.org/viewvc/llvm-project?rev=337808&view=rev
Log:
Disable 'suggest braces' warnings for std::array in tests
Modified:
libcxx/trunk/test/std/containers/views/span.cons/deduct.pass.cpp
libcxx/trunk/test/std
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware.
These methods allow reasoning about the stack frame that will be (or was) used
when the function will b
Author: yaxunl
Date: Mon Jul 23 19:12:24 2018
New Revision: 337797
URL: http://llvm.org/viewvc/llvm-project?rev=337797&view=rev
Log:
Attempt to fix regression due to r337791
Modified:
cfe/trunk/test/Driver/hip-toolchain.hip
Modified: cfe/trunk/test/Driver/hip-toolchain.hip
URL:
http://llvm.
Author: gbiv
Date: Mon Jul 23 19:10:53 2018
New Revision: 337796
URL: http://llvm.org/viewvc/llvm-project?rev=337796&view=rev
Log:
Fix unused variable warnings; NFC
Looks like MTE was previously used for its SourceLoc, but we're now
using a seperate SourceLocation here.
Modified:
cfe/trunk/l
phosek added a comment.
I've tested this on macOS and everything seems to be working,
Repository:
rCXX libc++
https://reviews.llvm.org/D49711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: thomasanderson
Date: Mon Jul 23 17:43:47 2018
New Revision: 337788
URL: http://llvm.org/viewvc/llvm-project?rev=337788&view=rev
Log:
Borrow visibility from __fundamental_type_info for generated fundamental type
infos
This is necessary so the clang gives hidden visibility to fundamental t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337793: [HIP] pass -target-cpu when running the device-mode
compiler (authored by yaxunl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49643?vs=156699&id=156953#toc
Repository:
Author: yaxunl
Date: Mon Jul 23 18:40:44 2018
New Revision: 337793
URL: http://llvm.org/viewvc/llvm-project?rev=337793&view=rev
Log:
[HIP] pass -target-cpu when running the device-mode compiler
Differential Revision: https://reviews.llvm.org/D49643
Modified:
cfe/trunk/lib/Driver/ToolChains/H
Sorry, and thanks!
On Mon, Jul 23, 2018 at 5:32 PM Alex L wrote:
> The revert commit is r337782.
>
> On 23 July 2018 at 17:32, Alex L wrote:
>
>> Hi,
>>
>> I had to revert your commit as it caused a number of failures in our
>> public and internal CI.
>> When building compiler-rt on Darwin (sta
aheejin added a comment.
This fixes our local waterfall build failure. Thank you!
Repository:
rCXX libc++
https://reviews.llvm.org/D49711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
0x8000- updated this revision to Diff 156950.
0x8000- added a comment.
Ignore literals implicitly added by the compiler, such as when using a
range-for loop over a constant array.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/cppcoreguideline
phosek created this revision.
phosek added reviewers: EricWF, ldionne, aheejin, arphaman.
Herald added subscribers: cfe-commits, christof, mgorny.
This is an alternative approach to r337727 which broke the build
because libc++ headers were copied into the location outside of
directories used by Cl
Author: rsmith
Date: Mon Jul 23 18:23:36 2018
New Revision: 337792
URL: http://llvm.org/viewvc/llvm-project?rev=337792&view=rev
Log:
Add missing testcase update for r337790.
Modified:
cfe/trunk/test/SemaCXX/constant-expression-cxx11.cpp
Modified: cfe/trunk/test/SemaCXX/constant-expression-cx
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:207-208
+
+for (unsigned I = 0, E = FD->getNumParams(); I != E; ++I) {
+ QualType ParamTy = FD->getParamDecl(I)->getType();
+ if (!ParamTy->isReferenceType() ||
--
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:207-208
+
+for (unsigned I = 0, E = FD->getNumParams(); I != E; ++I) {
+ QualType ParamTy = FD->getParamDecl(I)->getType();
+ if (!ParamTy->isReferenceType() ||
--
Author: yaxunl
Date: Mon Jul 23 18:03:44 2018
New Revision: 337791
URL: http://llvm.org/viewvc/llvm-project?rev=337791&view=rev
Log:
Enable .hip files for test/Driver
Partially revert r334128 due to regressions.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
cfe/trunk/test/Driver/lit.local.cf
NoQ added inline comments.
Comment at: test/Analysis/inner-pointer.cpp:41-42
+template< class T >
+void func_ref(T& a);
+
Without a definition for this thing, we won't be able to test much. I suggest
you to take a pointer to a function directly, i.e. define a
Author: rsmith
Date: Mon Jul 23 17:55:08 2018
New Revision: 337790
URL: http://llvm.org/viewvc/llvm-project?rev=337790&view=rev
Log:
Warn if a local variable's initializer retains a pointer/reference to a
non-lifetime-extended temporary object.
Added:
cfe/trunk/test/SemaCXX/warn-dangling-loca
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaCast.cpp:94-101
+void updatePartOfExplicitCastFlags(CastExpr *CE) {
+ // Walk down from the CE to the OrigSrcExpr, and mark all immediat
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337788: Borrow visibility from __fundamental_type_info for
generated fundamental type… (authored by thomasanderson, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49109
Files:
lib/Co
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D49109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dtarditi abandoned this revision.
dtarditi added a comment.
This is not needed after https://reviews.llvm.org/D42762 was committed. The
approach there of using a VSIX package is better than the script-based
approach here.
Repository:
rL LLVM
https://reviews.llvm.org/D48886
thomasanderson updated this revision to Diff 156943.
thomasanderson added a comment.
Added test. Also verified that all tests in llvm/tools/clang/test pass.
https://reviews.llvm.org/D49109
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/rtti-fundamental.cpp
Index: test/CodeGenCXX/rtt
Hi,
I had to revert your commit as it caused a number of failures in our public
and internal CI.
When building compiler-rt on Darwin (stage1), after this commit the build
failed to build X-ray and libfuzzer because the libc++ headers were no
longer found. The compiler-rt libraries were built using
The revert commit is r337782.
On 23 July 2018 at 17:32, Alex L wrote:
> Hi,
>
> I had to revert your commit as it caused a number of failures in our
> public and internal CI.
> When building compiler-rt on Darwin (stage1), after this commit the build
> failed to build X-ray and libfuzzer because
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2934
+} else if (const auto *CallE = dyn_cast(S)) {
+ OS << CallE->getDirectCallee()->getNameAsString();
}
rnkovacs wrote:
> xazax.hun wrote
Author: djg
Date: Mon Jul 23 17:29:58 2018
New Revision: 337783
URL: http://llvm.org/viewvc/llvm-project?rev=337783&view=rev
Log:
[WebAssembly] Change size_t to `unsigned long`.
Changing it to unsigned long (which is 32-bit on wasm32) makes it the same
type as wasm64 (where unsigned long is 64-bi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337783: [WebAssembly] Change size_t to `unsigned long`.
(authored by djg, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D40526
Files:
lib/Basi
rnkovacs added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:213
+ if (const auto *FC = dyn_cast(&Call)) {
+const FunctionDecl *FD = FC->getDecl();
+for (unsigned I = 0, E = FD->getNumParams(); I != E; ++I) {
xazax.hun
rnkovacs updated this revision to Diff 156938.
rnkovacs marked 11 inline comments as done.
rnkovacs added a comment.
Addressed comments & added two test cases for function pointers.
https://reviews.llvm.org/D49656
Files:
lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp
lib/StaticAnalyzer
mclow.lists accepted this revision.
mclow.lists added inline comments.
This revision is now accepted and ready to land.
Comment at: include/__config:153
+#ifndef __has_include
+#define __has_include(...) 0
#endif
rsmith wrote:
> arichardson wrote:
> > EricWF wro
Author: arphaman
Date: Mon Jul 23 17:27:31 2018
New Revision: 337782
URL: http://llvm.org/viewvc/llvm-project?rev=337782&view=rev
Log:
Revert r337727 as it caused Darwin bot failures
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm
rsmith added inline comments.
Comment at: include/__config:153
+#ifndef __has_include
+#define __has_include(...) 0
#endif
arichardson wrote:
> EricWF wrote:
> > I do prefer not hijacking this name, but if it's needed to make things
> > work, then it's OK with
jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D49628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: epilk
Date: Mon Jul 23 17:07:49 2018
New Revision: 337780
URL: http://llvm.org/viewvc/llvm-project?rev=337780&view=rev
Log:
NFC: Add the emacs c++ mode hint "-*- C++ -*-" to the headers that don't have it
https://llvm.org/docs/CodingStandards.html#file-headers
Modified:
cfe/trunk/inc
efriedma added inline comments.
Comment at: lib/AST/ASTContext.cpp:2088
+ default:
+UnadjustedAlign = getTypeAlign(T);
+ }
This "default" isn't right; there are a lot of non-canonical types which need
to be handled here (which getTypeAlign handles, but thi
Author: dergachev
Date: Mon Jul 23 16:48:13 2018
New Revision: 337776
URL: http://llvm.org/viewvc/llvm-project?rev=337776&view=rev
Log:
[analyzer] Add a no-crash to a recently added test.
No functional change intended.
Modified:
cfe/trunk/test/Analysis/casts.c
Modified: cfe/trunk/test/Analy
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM, with a suggestion for adding one test.
Comment at: include/span:189
+struct __is_span_compatible_container<_Tp, _ElementType,
+void_t<
+// is not a sp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337771: Fix typo in test/CodeGen/Mips/dins.ll (authored by
thomasanderson, committed by ).
Herald added subscribers: llvm-commits, jrtc27.
Changed prior to commit:
https://reviews.llvm.org/D49704?vs=156
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337769: [analyzer] pr38273: Legalize Loc<>NonLoc
comparison symbols. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49703
Files:
lib/StaticAnalyzer/Core/Range
erik.pilkington updated this revision to Diff 156912.
erik.pilkington added a comment.
In this new patch:
- Rebase on top of changes in https://reviews.llvm.org/D46845
- Move in some forward decls that I accidentally left in
https://reviews.llvm.org/D46845
- Add some missing visibility attribute
Author: dergachev
Date: Mon Jul 23 16:09:44 2018
New Revision: 337769
URL: http://llvm.org/viewvc/llvm-project?rev=337769&view=rev
Log:
[analyzer] pr38273: Legalize Loc<>NonLoc comparison symbols.
Remove an assertion in RangeConstraintManager that expects such symbols to never
appear, while admit
vsapsai updated this revision to Diff 156911.
vsapsai added a comment.
- Tweak the comment according to review comments.
Undiscussed changes: we don't stop preprocessing entirely, only in included
files; not using better-sounding "skip" deliberately as it might be confused
with `FileSkipped` API.
Sorry for the repeated emails. I did more digging and we were indeed
handling DT_UNKNOWN incorrectly.
I've fixed that in r337768.
/Eric
On Mon, Jul 23, 2018 at 4:43 PM Eric Fiselier wrote:
> Hi Jonas,
>
> I believe I fixed the issue, and I've recommitted the change as r337765.
> Please let me k
Author: ericwf
Date: Mon Jul 23 15:58:46 2018
New Revision: 337768
URL: http://llvm.org/viewvc/llvm-project?rev=337768&view=rev
Log:
Handle DT_UNKNOWN correctly during directory iteration.
Unlike stat and lstat, where unknown really means we know it's something weird,
during directory iteration D
Author: rsmith
Date: Mon Jul 23 15:56:45 2018
New Revision: 337767
URL: http://llvm.org/viewvc/llvm-project?rev=337767&view=rev
Log:
Support lifetime-extension of conditional temporaries.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/CodeGen/CGCleanup.cpp
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D49704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thomasanderson added a comment.
pcc ptal
I've been granted commit-after-approval, and this is my test CL.
https://reviews.llvm.org/D49704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
thomasanderson created this revision.
thomasanderson added a reviewer: pcc.
Herald added subscribers: atanasyan, arichardson, sdardis.
https://reviews.llvm.org/D49704
Files:
test/CodeGen/Mips/dins.ll
Index: test/CodeGen/Mips/dins.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337766: [Sema] Fix crash on BlockExprs in a default member
initializers (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49688?vs=156848&id=156906#toc
Repository:
Author: epilk
Date: Mon Jul 23 15:47:37 2018
New Revision: 337766
URL: http://llvm.org/viewvc/llvm-project?rev=337766&view=rev
Log:
[Sema] Fix crash on BlockExprs in a default member initializers
Clang would crash when instantiating a BlockDecl that appeared in a
default-member-initializer of a c
Hi Jonas,
I believe I fixed the issue, and I've recommitted the change as r337765.
Please let me know if you still see the failures. I think there might be a
lingering issues with how we handle DT_UNKNOWN.
/Eric
On Mon, Jul 23, 2018 at 3:53 PM Eric Fiselier wrote:
> I think I've found the bug,
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs, mikhail.ramalho.
Herald added subscribers: cfe-commits, baloghadamsoftware.
This patch fixes the crash caused by https://reviews.llvm.org/D48650 and
reported as https://bugs.llvm.
Author: ericwf
Date: Mon Jul 23 15:40:41 2018
New Revision: 337765
URL: http://llvm.org/viewvc/llvm-project?rev=337765&view=rev
Log:
Recommit "Use possibly cached directory entry values when performing recursive
directory iteration."
The initial patch didn't correctly handle systems when the dir
Author: ericwf
Date: Mon Jul 23 15:39:56 2018
New Revision: 337764
URL: http://llvm.org/viewvc/llvm-project?rev=337764&view=rev
Log:
Fix accidentally removed test.
When adding the new tests for the filesystem_error::what method,
I incorrectly removed a test case and replaced it with something els
vsapsai added inline comments.
Comment at: clang/lib/Lex/PPDirectives.cpp:1875
+ // Stop further preprocessing if a fatal error has occurred. Any diagnostics
+ // we might have raised will not be visible.
+ if (ShouldEnter && Diags->hasFatalErrorOccurred())
jk
arichardson added a comment.
In https://reviews.llvm.org/D49067#1172500, @EricWF wrote:
> Where are the special lexing rules specified?
In https://bugs.llvm.org/show_bug.cgi?id=37990#c1 @rsmith wrote:
> The C++ standard appears to be missing a rule that says that a __has_include
> token pr
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337761: [ASTMatchers] Add an isMain() matcher (authored by
george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D49615?vs=156599&id
Author: george.karpenkov
Date: Mon Jul 23 15:29:35 2018
New Revision: 337761
URL: http://llvm.org/viewvc/llvm-project?rev=337761&view=rev
Log:
[ASTMatchers] Add an isMain() matcher
Differential Revision: https://reviews.llvm.org/D49615
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Author: george.karpenkov
Date: Mon Jul 23 15:29:10 2018
New Revision: 337760
URL: http://llvm.org/viewvc/llvm-project?rev=337760&view=rev
Log:
[ASTMatchers] [NFC] Regenerate HTML docs.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMatchersReference.html
Author: epilk
Date: Mon Jul 23 15:23:04 2018
New Revision: 337759
URL: http://llvm.org/viewvc/llvm-project?rev=337759&view=rev
Log:
[demangler] call terminate() if allocation failed
We really should set *status to memory_alloc_failure, but we need to refactor
the demangler a bit to properly propa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337754: Implement a GCC compatible SEH unwinding
personality, __gxx_personality_seh0 (authored by mstorsjo, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
htt
Author: mstorsjo
Date: Mon Jul 23 15:09:23 2018
New Revision: 337754
URL: http://llvm.org/viewvc/llvm-project?rev=337754&view=rev
Log:
Implement a GCC compatible SEH unwinding personality, __gxx_personality_seh0
This allows handling SEH based exceptions, with unwind functions
provided by libgcc.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: mclow.lists.
EricWF added a comment.
Where are the special lexing rules specified?
Comment at: include/__config:153
+#ifndef __has_include
+#define __has_include(...) 0
#endif
I do prefer not hij
alxu added a comment.
my general theory is that it's better to have tests that test everything at
once if possible, but I guess it's unlikely enough that the debug info path
will be correct in the IR and then not correct in the generated file and that
that won't be caught by LLVM tests.
Repos
arichardson added a comment.
Ping?
Repository:
rC Clang
https://reviews.llvm.org/D49091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arichardson added a comment.
Ping?
Repository:
rCXX libc++
https://reviews.llvm.org/D49067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: asmith
Date: Mon Jul 23 13:49:07 2018
New Revision: 337736
URL: http://llvm.org/viewvc/llvm-project?rev=337736&view=rev
Log:
[CodeGen] Record if a C++ record is a trivial type
Summary: This has a dependence on D45122
Reviewers: rnk, zturner, llvm-commits, aleksandr.urakov
Reviewed By: r
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Ah, so you mean you need it for libc++abi because you want to build them but
not install them (so they're linked into libc++)? Then LGTM as-is. I'd like to
see what Eric has to say though.
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
It makes sense that the BlockDecl's parent DC is the class, although I think it
would be even better if we took a page from Swift and make a special DC for
initializer expressions. I don'
I think I've found the bug, but I need to spend some more time on it.
I've reverted in for now in r337749.
/Eric
On Mon, Jul 23, 2018 at 1:25 PM Eric Fiselier wrote:
> Thanks. I'm looking into this.
>
> /Eric
>
> On Mon, Jul 23, 2018 at 12:58 PM Jonas Hahnfeld wrote:
>
>> Hi Eric,
>>
>> this
Author: ericwf
Date: Mon Jul 23 14:52:29 2018
New Revision: 337749
URL: http://llvm.org/viewvc/llvm-project?rev=337749&view=rev
Log:
Revert "Use possibly cached directory entry values when performing recursive
directory iteration."
This reverts commit 04ce4aef00d3ee508327f6cf7bf1b1d200ab6238.
M
erik.pilkington added a comment.
In https://reviews.llvm.org/D49688#1172269, @rjmccall wrote:
> I honestly don't know why the `BlockDecl` is in the members list in the first
> place; that seems wrong, for the same reason that we wouldn't (I assume?)
> consider a lambda's implicit record to be a
ldionne added inline comments.
Comment at: include/span:217
+using pointer= _Tp *;
+using const_pointer = const _Tp *; // not in standard
+using reference = _Tp &;
mclow.lists wrote:
> ldionne wrote:
> > Why are w
Author: rnk
Date: Mon Jul 23 14:29:43 2018
New Revision: 337746
URL: http://llvm.org/viewvc/llvm-project?rev=337746&view=rev
Log:
[clang-cl] Expose -fblocks and -fno-builtin as driver flags
Users have requested them.
Helps with PR36427.
Modified:
cfe/trunk/include/clang/Driver/Options.td
mclow.lists marked an inline comment as done.
mclow.lists added a comment.
> I missed the container constructors being `noexcept`
Never mind; they're not `noexcept` (and they should not be)
https://reviews.llvm.org/D49338
___
cfe-commits mailing li
Author: rsmith
Date: Mon Jul 23 14:21:22 2018
New Revision: 337743
URL: http://llvm.org/viewvc/llvm-project?rev=337743&view=rev
Log:
Fold -Wreturn-stack-address into general initialization lifetime
checking.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/Sema
Author: rsmith
Date: Mon Jul 23 14:21:24 2018
New Revision: 337744
URL: http://llvm.org/viewvc/llvm-project?rev=337744&view=rev
Log:
Do not try to perform lifetime-extension through conditional
expressions.
CodeGen can't cope with that yet. Instead, produce a "not supported"
warning for now and d
Thanks, fixed and re-committed in r337726.
On Sun, 22 Jul 2018 at 23:33, Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Reverted in r337671
>
> On Mon, Jul 23, 2018 at 8:24 AM Ilya Biryukov
> wrote:
>
>> Hi Richard,
>>
>> this commit seems to cause invalid warning in the fo
mclow.lists marked 13 inline comments as done.
mclow.lists added a comment.
I missed the container constructors being `noexcept`, and the asserts on
`operator[]` and `operator()` are half done (stupid signed indicies).
I'll wait for other feedback before doing those bits.
Com
phosek added a comment.
You're right that we don't need these flags for libc++, we only need them for
libc++abi and libunwind for the cases when one of these is linked into libc++
or libc++abi respectively. I added them for consistency, but I'm fine dropping
them from libc++, would that be more
probinson added a comment.
In https://reviews.llvm.org/D49652#1172352, @alxu wrote:
> I was just going to run llvm-dwarfdump.
Well, that's one of those quirks I mentioned. This is a Clang change, and
Clang tests should exercise as little of LLVM as possible. That means you
don't generate as
alxu added a comment.
FYI, gcc uses the stupid and bad string prefix matching approach. if clang
supports the same option, it should have the same behavior. you could decide
that it's a bad idea, but then the option should be called something else,
otherwise people will have to go back to testi
Author: erichkeane
Date: Mon Jul 23 14:08:13 2018
New Revision: 337738
URL: http://llvm.org/viewvc/llvm-project?rev=337738&view=rev
Log:
Update to -r337585, allow scoped enum inits in -pedantic
Modified:
cfe/trunk/include/clang/AST/Type.h
cfe/trunk/lib/AST/Type.cpp
cfe/trunk/lib/Sema/
rjmccall added a comment.
Are you sure you shouldn't do it based on some sort of actual annotation based
on the frontend's knowledge of types instead of adding semantics for LLVM IR
types that were never intended?
https://reviews.llvm.org/D49403
_
alxu added a comment.
I was just going to run llvm-dwarfdump.
Repository:
rC Clang
https://reviews.llvm.org/D49652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Test?
On Mon, Jul 23, 2018 at 11:49 PM, Aaron Smith via Phabricator via
llvm-commits wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rC337736: [CodeGen] Record if a C++ record is a trivial type
> (authored by asmith, committed by ).
>
> Repos
olga.chupina added a comment.
Yes, correct.
https://reviews.llvm.org/D49403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337736: [CodeGen] Record if a C++ record is a trivial type
(authored by asmith, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45124
Files:
lib/CodeGen/CGDebugInfo.cpp
Index: lib/C
emmettneyman updated this revision to Diff 156862.
emmettneyman added a comment.
Made fixes to patch, rebased CMake file
Repository:
rC Clang
https://reviews.llvm.org/D49526
Files:
clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt
clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp
I
mclow.lists marked 5 inline comments as done.
mclow.lists added a comment.
I think I've answered all of Louis' questions that don't require code changes.
New patch will be coming soon.
Comment at: include/span:217
+using pointer= _Tp *;
+using const_poin
probinson added a comment.
Re. SmallVector versus std::vector, they are functionally similar but have
different memory-allocation behaviors. SmallVector includes a vector of N
elements (where N is the template parameter) so does no dynamic allocation
until you have more than N elements; but it
rjmccall added a comment.
I honestly don't know why the `BlockDecl` is in the members list in the first
place; that seems wrong, for the same reason that we wouldn't (I assume?)
consider a lambda's implicit record to be a member.
Repository:
rC Clang
https://reviews.llvm.org/D49688
_
Agree,
will try to add separate testcase soon.
Thanks,
Manoj
On Mon, Jul 23, 2018 at 12:39 PM Richard Smith
wrote:
> Hi Manoj,
>
> Please can you add better test coverage that we don't emit 'nonnull'
> annotations for reference parameters / return values? At the moment, the
> only such test cov
1 - 100 of 246 matches
Mail list logo
