[PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type when emitting Codeview

asmith updated this revision to Diff 156664. https://reviews.llvm.org/D45124 Files: lib/CodeGen/CGDebugInfo.cpp Index: lib/CodeGen/CGDebugInfo.cpp === --- lib/CodeGen/CGDebugInfo.cpp +++ lib/CodeGen/CGDebugInfo.cpp @@ -2847,6 +28

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

aheejin added a comment. This line was added in https://reviews.llvm.org/rL335809, and after https://reviews.llvm.org/rL337630 `dst` in this line is set to NULL in our

[PATCH] D49629: [CMake] Fix the setting of LIBCXX_HEADER_DIR

aheejin created this revision. aheejin added a reviewer: phosek. Herald added subscribers: cfe-commits, ldionne, christof, mgorny. Repository: rCXX libc++ https://reviews.llvm.org/D49629 Files: CMakeLists.txt Index: CMakeLists.txt ===

[PATCH] D48287: [HIP] Support -fcuda-flush-denormals-to-zero for amdgcn

This revision was automatically updated to reflect the committed changes. Closed by commit rC337639: [HIP] Support -fcuda-flush-denormals-to-zero for amdgcn (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D48287 Files: include/clang/Basic/LangOptions.def

r337639 - [HIP] Support -fcuda-flush-denormals-to-zero for amdgcn

Author: yaxunl Date: Fri Jul 20 19:02:22 2018 New Revision: 337639 URL: http://llvm.org/viewvc/llvm-project?rev=337639&view=rev Log: [HIP] Support -fcuda-flush-denormals-to-zero for amdgcn Differential Revision: https://reviews.llvm.org/D48287 Modified: cfe/trunk/include/clang/Basic/LangOpti

[PATCH] D49628: [CMake] Link static libunwind and libc++abi into libc++ in Fuchsia toolchain

phosek created this revision. phosek added reviewers: mcgrathr, juliehockett, jakehehrlich. Herald added subscribers: cfe-commits, chrib, mgorny. Herald added a reviewer: EricWF. When building libc++ for Fuchsia, we want to distribute shared libc++, libc++abi and libunwind as separate libraries, b

[PATCH] D46140: [coroutines] std::task type (WIP)

lewissbaker updated this revision to Diff 156641. lewissbaker edited the summary of this revision. lewissbaker added a comment. - Make `task` constructor from `coroutine_handle` private. - Run clang-format over . https://reviews.llvm.org/D46140 Files: include/CMakeLists.txt include/experime

[PATCH] D49627: [CFG] [analyzer] Constructors of member CXXOperatorCallExpr's argument 0 are not argument constructors.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, mikhail.ramalho. Because `CXXOperatorCallExpr`'s argument 0 is the `this`-argument of the operator if the operator is a

r337636 - [NFC] CodeGen: rename memset to bzero

Author: jfb Date: Fri Jul 20 16:37:12 2018 New Revision: 337636 URL: http://llvm.org/viewvc/llvm-project?rev=337636&view=rev Log: [NFC] CodeGen: rename memset to bzero The optimization looks for opportunities to emit bzero, not memset. Rename the functions accordingly (and clang-format the diff)

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

This revision was automatically updated to reflect the committed changes. Closed by commit rL337635: [Driver] Sanitizer support based on runtime library presence (authored by george.karpenkov, committed by ). Changed prior to commit: https://reviews.llvm.org/D15225?vs=156603&id=156639#toc Repo

r337635 - [Driver] Sanitizer support based on runtime library presence

Author: george.karpenkov Date: Fri Jul 20 16:34:39 2018 New Revision: 337635 URL: http://llvm.org/viewvc/llvm-project?rev=337635&view=rev Log: [Driver] Sanitizer support based on runtime library presence The runtime libraries of sanitizers are built in compiler-rt, and Clang can be built without

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan added a comment. In https://reviews.llvm.org/D49511#1168692, @rsmith wrote: > The way in which you're checking for the problematic cases is unnecessarily > expensive. Instead of performing a separate AST traversal, please detect > whether you should be producing the warning directly

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan updated this revision to Diff 156634. leonardchan marked 2 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D49511 Files: include/clang/AST/Type.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticGroups.td inc

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

tra added a comment. In https://reviews.llvm.org/D47849#1126925, @gtbercea wrote: > I just stumbled upon a very interesting situation. > > I noticed that, for OpenMP, the use of device math functions happens as I > expected for -O0. For -O1 or higher math functions such as "sqrt" resolve to > l

[PATCH] D48742: Set _LIBCPP_TLS_DESTRUCTOR_CC convention to run_dtors

pirama added a comment. Ping... Repository: rCXXA libc++abi https://reviews.llvm.org/D48742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48743: Make pthread's __libcpp_get_tls declaration consistent

pirama added a comment. Ping... Repository: rCXX libc++ https://reviews.llvm.org/D48743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r337631 - [HIP] Register/unregister device fat binary only once

Author: yaxunl Date: Fri Jul 20 15:45:24 2018 New Revision: 337631 URL: http://llvm.org/viewvc/llvm-project?rev=337631&view=rev Log: [HIP] Register/unregister device fat binary only once HIP generates one fat binary for all devices after linking. However, for each compilation unit a ctor functio

[PATCH] D49083: [HIP] Register/unregister device fat binary only once

This revision was automatically updated to reflect the committed changes. Closed by commit rC337631: [HIP] Register/unregister device fat binary only once (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D49083 Files: lib/CodeGen/CGCUDANV.cpp test/CodeGen

[PATCH] D49584: [CMake] Install C++ ABI headers into the right location

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL337630: [CMake] Install C++ ABI headers into the right location (authored by phosek, committed by ). Herald added a subscr

[libcxx] r337630 - [CMake] Install C++ ABI headers into the right location

Author: phosek Date: Fri Jul 20 15:45:24 2018 New Revision: 337630 URL: http://llvm.org/viewvc/llvm-project?rev=337630&view=rev Log: [CMake] Install C++ ABI headers into the right location This is a follow-up to r335809 and r337118. While libc++ headers are now installed into the right location i

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny updated this revision to Diff 156620. jdenny added a comment. Ping. Rebased. https://reviews.llvm.org/D46919 Files: clang/include/clang-c/Index.h clang/include/clang/AST/PrettyPrinter.h clang/lib/AST/DeclPrinter.cpp clang/lib/AST/TypePrinter.cpp clang/tools/c-index-test/c-inde

r337629 - Disable clang crash-report-modules.m test on Windows again

Author: rnk Date: Fri Jul 20 15:36:33 2018 New Revision: 337629 URL: http://llvm.org/viewvc/llvm-project?rev=337629&view=rev Log: Disable clang crash-report-modules.m test on Windows again It still appears to be failing: http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12825 $

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

delcypher added a comment. @george.karpenkov Other than the comment that probably needs updating, LGTM. https://reviews.llvm.org/D15225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

delcypher added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.h:425 + /// \return Relative path to the filename for the library + /// containing the sanitizer {@code SanitizerName}. You might want to update that comment to not mention "Relat

r337627 - Fold dangling-field warning into general initialization lifetime checks.

Author: rsmith Date: Fri Jul 20 15:25:55 2018 New Revision: 337627 URL: http://llvm.org/viewvc/llvm-project?rev=337627&view=rev Log: Fold dangling-field warning into general initialization lifetime checks. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/S

[PATCH] D48287: [HIP] Support -fcuda-flush-denormals-to-zero for amdgcn

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Thank you. That should work. https://reviews.llvm.org/D48287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D48559: [clangd] refactoring for XPC transport layer [NFCI]

arphaman added a comment. In https://reviews.llvm.org/D48559#1169975, @sammccall wrote: > Sorry for the delay here, and I'm sorry I haven't been into the patches in > detail again yet - crazy week. After experiments, I am convinced the > Transport abstraction patch can turn into something nice

[PATCH] D49618: [clang-tidy] remove private decltypeType in TrailingReturnType

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun. This patch removes a private matcher in fuchsia/TrailingReturnType check because the matcher is now in ASTMatchers Repository: rCTE Clang Tools Extra ht

[PATCH] D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

JonasToth added a comment. > I don't think we want to modify `hasType()` -- that would strip off too much > type information if it automatically reached through to the underlying type. > However, we may want to consider adding something like `hasUnderlyingType()` > that checks the matcher again

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191 +void templated_thrower() { throw T{}(); } +// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type 'int' is not derived from 'std::exception' + a

[PATCH] D48759: [ASTMatchers] add matcher for decltypeType and its underlyingType

JonasToth updated this revision to Diff 156609. JonasToth marked an inline comment as done. JonasToth added a comment. - [Misc] add test and more doc - Merge branch 'master' into matcher_decltypetype Repository: rC Clang https://reviews.llvm.org/D48759 Files: include/clang/ASTMatchers/ASTM

[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

phosek added a comment. In https://reviews.llvm.org/D49573#1169615, @ldionne wrote: > I don't like the fact that we're adding options like crazy, thus making the > build more complicated. If you don't want to have some libraries that were > built, why not just remove them afterwards? The moti

RE: r337540 - Sema: Fix explicit address space cast in C++

From: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Friday, July 20, 2018 3:29 PM To: Liu, Yaxun (Sam) Cc: cfe-commits Subject: Re: r337540 - Sema: Fix explicit address space cast in C++ On Fri, 20 Jul 2018 at 12:00, Richard Smith mailto:rich...@metafoo.co.uk>> wrote: On Fri, 20 Jul 2018

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. In https://reviews.llvm.org/D49523#1169621, @jkorous wrote: > Alex, I am just wondering if we shouldn't rather create another > implementation of GlobalCompilationDatabase interface (something like > InMemoryGlobalCompilationDatabase), add it to ClangdServer and use it

Re: r337381 - Mention clang-cl improvements from r335466 and r336379 in ReleaseNotes.rst

Fixed in 337620, thanks! On Wed, Jul 18, 2018 at 3:55 PM Kim Gräsman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This is lovely! Found a bit inline... > > On Wed, Jul 18, 2018, 14:00 Nico Weber via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: nico >> Date: Wed Jul 18

r337620 - fix typo

Author: nico Date: Fri Jul 20 14:06:41 2018 New Revision: 337620 URL: http://llvm.org/viewvc/llvm-project?rev=337620&view=rev Log: fix typo Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/ReleaseNote

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

thakis closed this revision. thakis added a comment. r337619, thanks! The hoisting point is a good one; will rewrite using funnelshift once that's possible :-) https://reviews.llvm.org/D49606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45124: [CodeGen] Record if a C++ record is a trivial type when emitting Codeview

rnk added inline comments. Comment at: CodeGen/CGDebugInfo.cpp:2842-2843 + +// When emitting codeview, record if a C++ record is trivial type. +if (CGM.getCodeGenOpts().EmitCodeView) { + if (CXXRD->isTrivial()) I think we might as well set it when em

r337619 - [ms] Add __shiftleft128 / __shiftright128 intrinsics

Author: nico Date: Fri Jul 20 14:02:09 2018 New Revision: 337619 URL: http://llvm.org/viewvc/llvm-project?rev=337619&view=rev Log: [ms] Add __shiftleft128 / __shiftright128 intrinsics Carefully match the pattern matched by ISel so that this produces shld / shrd (unless Subtarget->isSHLDSlow() is

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

spatel added a comment. In https://reviews.llvm.org/D49606#1170448, @thakis wrote: > Isn't implementing this in plain old C the nicest approach anyhow, even once > funnel shift exists? No, the primary reason for creating the intrinsic is that we can’t guarantee that we’ll recognize the patter

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM. I'm inclined to let this go in now since we have a requested use for it. We can change it to funnel shift once we're confident in the backend. https://reviews.llvm.org/D4960

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. In https://reviews.llvm.org/D49523#1169728, @malaperle wrote: > In https://reviews.llvm.org/D49523#1169000, @arphaman wrote: > > > In https://reviews.llvm.org/D49523#1167553, @malaperle wrote: > > > > > Interesting! We also have a need for passing compilation commands in

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

craig.topper added a comment. The only weird thing that I can really think of with the C version is that the 'and' on the shift amount might get hoisted out of a loop and not get dropped during isel. https://reviews.llvm.org/D49606 ___ cfe-commits

r337616 - [codeview] Don't emit variable templates as class members

Author: rnk Date: Fri Jul 20 13:55:00 2018 New Revision: 337616 URL: http://llvm.org/viewvc/llvm-project?rev=337616&view=rev Log: [codeview] Don't emit variable templates as class members MSVC doesn't, so neither should we. Fixes PR38004, which is a crash that happens when we try to emit debug i

[PATCH] D49508: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

rsmith added inline comments. Comment at: include/clang/AST/Stmt.h:206 +bool PartOfExplicitCast : 1; +unsigned BasePathSize : 32 - 6 - 1 - NumExprBits; }; lebedev.ri wrote: > rjmccall wrote: > > lebedev.ri wrote: > > > rjmccall wrote: > > > > This need

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

george.karpenkov updated this revision to Diff 156603. https://reviews.llvm.org/D15225 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/lib/Driver/ToolChains/Darwin.h clang/test/Driver/Inputs/resource_dir/lib/darwin/libclang_rt.asan_ios_dynamic.dylib clang/test/Driver/Inputs/resource

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

thakis added a comment. Isn't implementing this in plain old C the nicest approach anyhow, even once funnel shift exists? https://reviews.llvm.org/D49606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

craig.topper added a comment. @spatel, yes its exactly funnel shift. I wasn't sure if we were ready for clang to create it yet or not. Can we let this go as is and change it to funnel shift once we have the variable case fixed in the backend? https://reviews.llvm.org/D49606

r337612 - AMDGPU: Switch default dwarf version to 2

Author: kzhuravl Date: Fri Jul 20 13:46:25 2018 New Revision: 337612 URL: http://llvm.org/viewvc/llvm-project?rev=337612&view=rev Log: AMDGPU: Switch default dwarf version to 2 There were some problems unearthed with version 5, which I am going to look at. Differential Revision: https://reviews.

r337611 - [CStringSyntaxChecker] Fix build bot builds != x86 archs

Author: devnexen Date: Fri Jul 20 13:39:49 2018 New Revision: 337611 URL: http://llvm.org/viewvc/llvm-project?rev=337611&view=rev Log: [CStringSyntaxChecker] Fix build bot builds != x86 archs Reviewers: NoQ,george.karpenkov Reviewed By: NoQ Differential Revision: https://reviews.llvm.org/D49588

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

thakis added a comment. Now with C builtins which get nicely optimized. https://reviews.llvm.org/D49606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

thakis updated this revision to Diff 156596. thakis edited the summary of this revision. https://reviews.llvm.org/D49606 Files: clang/lib/Headers/intrin.h clang/test/Headers/ms-intrin.cpp Index: clang/test/Headers/ms-intrin.cpp ===

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

spatel added a comment. In https://reviews.llvm.org/D49606#1170278, @craig.topper wrote: > Here are the IR patterns for this that work. Not sure if we can do this > directly in C, we need a 128 bit type, but maybe we can emit it from > CGBuiltin.cpp? > > define i64 @__shiftleft128(i64 %x, i64

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

craig.topper added a comment. I'd prefer the pattern over inline assembly. It'll give us more flexibility in the backend if we should be using some other instruction on different targets. https://reviews.llvm.org/D49606 ___ cfe-commits mailing list

[PATCH] D49302: [AST] Various micro-optimizations in CXXInheritance

This revision was automatically updated to reflect the committed changes. Closed by commit rL337607: [AST] Various micro-optimizations in CXXInheritance (authored by d0k, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49302?vs=155392&

r337607 - [AST] Various micro-optimizations in CXXInheritance

Author: d0k Date: Fri Jul 20 13:13:08 2018 New Revision: 337607 URL: http://llvm.org/viewvc/llvm-project?rev=337607&view=rev Log: [AST] Various micro-optimizations in CXXInheritance 1. Pack std::pair in CXXBasePaths::ClassSubobjects. 2. Use a SmallPtrSet instead of a SmallDenseSet for CXXBasePat

[PATCH] D49148: [DEBUGINFO] Disable unsupported debug info options for NVPTX target.

ABataev updated this revision to Diff 156575. ABataev added a comment. Added checks for all possible debug options. Repository: rC Clang https://reviews.llvm.org/D49148 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/DiagnosticGroups.td include/clang/Driver/Tool

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

thakis added a comment. We have __int128. If you think hitting the pattern is preferable to inline asm, I can try to give that a try, either via C or via CGBuiltin.cpp. https://reviews.llvm.org/D49606 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D49580: [clang-format] Adding style option for absolute formatting

acoomans updated this revision to Diff 156571. acoomans retitled this revision from "[WIP] Change clang-format to absolute indentation" to "[clang-format] Adding style option for absolute formatting". acoomans edited the summary of this revision. https://reviews.llvm.org/D49580 Files: docs/Cla

[PATCH] D49302: [AST] Various micro-optimizations in CXXInheritance

bricci added a comment. @bkramer Thanks for the review! Can you commit it for my since I can not do it myself? Repository: rC Clang https://reviews.llvm.org/D49302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D49508: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

lebedev.ri added inline comments. Comment at: include/clang/AST/Stmt.h:206 +bool PartOfExplicitCast : 1; +unsigned BasePathSize : 32 - 6 - 1 - NumExprBits; }; rjmccall wrote: > lebedev.ri wrote: > > rjmccall wrote: > > > This needs to be serialized. >

[PATCH] D49508: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

lebedev.ri updated this revision to Diff 156568. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. - Use `unsigned`, not bool. - Serialization, although without tests, and likely incompatible with previous versions. Repository: rC Clang https://reviews.llvm.org/D49508

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

craig.topper added a comment. Here are the IR patterns for this that work. Not sure if we can do this directly in C, we need a 128 bit type, but maybe we can emit it from CGBuiltin.cpp? define i64 @__shiftleft128(i64 %x, i64 %y, i8 %amt) { %a = zext i64 %x to i128 %b = zext i64 %y to

Re: r337540 - Sema: Fix explicit address space cast in C++

On Fri, 20 Jul 2018 at 12:00, Richard Smith wrote: > On Fri, 20 Jul 2018 at 04:38, Yaxun Liu via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: yaxunl >> Date: Fri Jul 20 04:32:51 2018 >> New Revision: 337540 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=337540&view=rev >> L

[PATCH] D46140: [coroutines] std::task type (WIP)

lewissbaker updated this revision to Diff 156565. lewissbaker added a comment. Herald added subscribers: cfe-commits, ldionne, mgorny. Many improvements: - Remove move-assignment operator - `task::operator co_await()` now returns by value when awaiting `task` rvalue. - Explicitly scope calls to

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

delcypher added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2298 SanitizerMask Res = ToolChain::getSupportedSanitizers(); - Res |= SanitizerKind::Address; - Res |= SanitizerKind::Leak; - Res |= SanitizerKind::Fuzzer; - Res |= SanitizerKind::FuzzerNo

[PATCH] D49584: [CMake] Install C++ ABI headers into the right location

phosek added a subscriber: beanz. phosek added a comment. We currently support two different layouts: 1. The standard layout (for a lack of a better name) which is used when libc++ is built standalone as well as being built as part of LLVM without any other options which is `$DESTDIR/include/c+

Re: r337540 - Sema: Fix explicit address space cast in C++

On Fri, 20 Jul 2018 at 04:38, Yaxun Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: yaxunl > Date: Fri Jul 20 04:32:51 2018 > New Revision: 337540 > > URL: http://llvm.org/viewvc/llvm-project?rev=337540&view=rev > Log: > Sema: Fix explicit address space cast in C++ > > Currently

[PATCH] D48395: Added PublicOnly flag

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE337602: [clang-doc] Adding PublicOnly flag (authored by juliehockett, committed by ). Herald added a subscriber: arphaman. Changed prior to commit: https://reviews.llvm.org/D48395?vs=154470&id=156562#

[clang-tools-extra] r337602 - [clang-doc] Adding PublicOnly flag

Author: juliehockett Date: Fri Jul 20 11:49:55 2018 New Revision: 337602 URL: http://llvm.org/viewvc/llvm-project?rev=337602&view=rev Log: [clang-doc] Adding PublicOnly flag Submitted on behalf of Annie Cherkaev (@anniecherk) Added a flag which, when enabled, documents only those methods and fie

[clang-tools-extra] r337601 - [clangd] Fix racy use-after-scope in unittest

Author: d0k Date: Fri Jul 20 11:45:25 2018 New Revision: 337601 URL: http://llvm.org/viewvc/llvm-project?rev=337601&view=rev Log: [clangd] Fix racy use-after-scope in unittest This only shows up with asan when the stars align in a bad way. Modified: clang-tools-extra/trunk/unittests/clangd/T

[PATCH] D49508: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

rjmccall added inline comments. Comment at: include/clang/AST/Stmt.h:206 +bool PartOfExplicitCast : 1; +unsigned BasePathSize : 32 - 6 - 1 - NumExprBits; }; lebedev.ri wrote: > rjmccall wrote: > > This needs to be serialized. > Uhm, could you please ex

[PATCH] D49508: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

lebedev.ri added inline comments. Comment at: include/clang/AST/Stmt.h:206 +bool PartOfExplicitCast : 1; +unsigned BasePathSize : 32 - 6 - 1 - NumExprBits; }; rjmccall wrote: > This needs to be serialized. Uhm, could you please explain what do you mean

[PATCH] D49523: [clangd] Add support for per-file override compilation command

arphaman added a comment. In https://reviews.llvm.org/D49523#1169743, @jkorous wrote: > BTW it looks like we already had kind of support for compilation command > before (extra flags). > > commit 5ec1f7ca32eb85077a22ce81d41aa02a017d4852 > Author: Krasimir Georgiev > Date: Thu Jul 6 08:44:54

[PATCH] D49508: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

rjmccall added inline comments. Comment at: include/clang/AST/Stmt.h:205 unsigned Kind : 6; -unsigned BasePathSize : 32 - 6 - NumExprBits; +bool PartOfExplicitCast : 1; +unsigned BasePathSize : 32 - 6 - 1 - NumExprBits; This needs to be `unsigned

[PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

george.karpenkov added a comment. @delcypher sorry i don't agree with the change requests. @mracek any comments? Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2298 SanitizerMask Res = ToolChain::getSupportedSanitizers(); - Res |= SanitizerKind::Address; - Res |= Sanit

[PATCH] D46845: [libcxx][c++17] P0083R5: Splicing Maps and Sets

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D46845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49274: [CUDA] Provide integer SIMD functions for CUDA-9.2

This revision was automatically updated to reflect the committed changes. tra marked 2 inline comments as done. Closed by commit rC337587: [CUDA] Provide integer SIMD functions for CUDA-9.2 (authored by tra, committed by ). Changed prior to commit: https://reviews.llvm.org/D49274?vs=156397&id=1

r337587 - [CUDA] Provide integer SIMD functions for CUDA-9.2

Author: tra Date: Fri Jul 20 10:44:34 2018 New Revision: 337587 URL: http://llvm.org/viewvc/llvm-project?rev=337587&view=rev Log: [CUDA] Provide integer SIMD functions for CUDA-9.2 CUDA-9.2 made all integer SIMD functions into compiler builtins, so clang no longer has access to the implementation

r337585 - Prevent Scoped Enums from being Integral constant expressions:

Author: erichkeane Date: Fri Jul 20 10:42:09 2018 New Revision: 337585 URL: http://llvm.org/viewvc/llvm-project?rev=337585&view=rev Log: Prevent Scoped Enums from being Integral constant expressions: Discovered because of: https://bugs.llvm.org/show_bug.cgi?id=38235 It seems to me that a scoped

[libcxxabi] r337582 - Merge changes to ItaniumDemangle over to libcxxabi.

Author: zturner Date: Fri Jul 20 10:16:49 2018 New Revision: 337582 URL: http://llvm.org/viewvc/llvm-project?rev=337582&view=rev Log: Merge changes to ItaniumDemangle over to libcxxabi. ItaniumDemangle had a small NFC refactor to make some of its code reusable by the newly added Microsoft demangl

[PATCH] D49594: [DebugInfo] Emit diagnostics when enabling -fdebug-types-section on non-linux target.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. If the plan is for this to be relatively temporary then LGTM. https://reviews.llvm.org/D49594 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D49303: [CodeGen][ObjC] Treat non-escaping blocks as global blocks to make copy/dispose a no-op

This revision was automatically updated to reflect the committed changes. ahatanak marked an inline comment as done. Closed by commit rL337580: [CodeGen][ObjC] Make copying and disposing of a non-escaping block (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Change

r337580 - [CodeGen][ObjC] Make copying and disposing of a non-escaping block

Author: ahatanak Date: Fri Jul 20 10:10:32 2018 New Revision: 337580 URL: http://llvm.org/viewvc/llvm-project?rev=337580&view=rev Log: [CodeGen][ObjC] Make copying and disposing of a non-escaping block no-ops. A non-escaping block on the stack will never be called after its lifetime ends, so it d

[PATCH] D48559: [clangd] refactoring for XPC transport layer [NFCI]

sammccall added a comment. Sorry for the delay here, and I'm sorry I haven't been into the patches in detail again yet - crazy week. After experiments, I am convinced the Transport abstraction patch can turn into something nice **if** we want XPC vs JSON to be a pure transport-level difference

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

craig.topper added a comment. @spatel, should this ultimately use funnel shift? https://reviews.llvm.org/D49606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42762: Rewrite the VS Integration Scripts

This revision was automatically updated to reflect the committed changes. Closed by commit rC337572: Rewrite the VS integration scripts. (authored by zturner, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D42762?vs=156387&id=156520#toc

r337572 - Rewrite the VS integration scripts.

Author: zturner Date: Fri Jul 20 09:30:02 2018 New Revision: 337572 URL: http://llvm.org/viewvc/llvm-project?rev=337572&view=rev Log: Rewrite the VS integration scripts. This is a new modernized VS integration installer. It adds a Visual Studio .sln file which, when built, outputs a VSIX that ca

[PATCH] D49606: [ms] Add __shiftleft128 / __shiftright128 intrinsics

thakis created this revision. thakis added a reviewer: craig.topper. cl.exe maps these to shld / shrd, so let's do the same. ISel has `Subtarget->isSHLDSlow()` to prevent use of these intrinsics on some machines, but honoring them feels a bit like trying to outsmart the intrinsics user, and the

[PATCH] D49594: [DebugInfo] Emit diagnostics when enabling -fdebug-types-section on non-linux target.

JDevlieghere added a comment. In https://reviews.llvm.org/D49594#1169809, @probinson wrote: > Is this because type units depend on COMDAT support? I had a vague idea that > COFF also supports COMDAT. It's more that I want to reflect the current situation and prevent MC from crashing while we

[PATCH] D49543: [clangd] Penalize non-instance members when accessed via class instances.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/CodeComplete.h:148 bool HasMore = false; + CodeCompletionContext::Kind SemaContext = CodeCompletionContext::CCC_Other; }; n

[PATCH] D49594: [DebugInfo] Emit diagnostics when enabling -fdebug-types-section on non-linux target.

probinson added a comment. Is this because type units depend on COMDAT support? I had a vague idea that COFF also supports COMDAT. https://reviews.llvm.org/D49594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D49553: [analyzer] Rename DanglingInternalBufferChecker to InnerPointerChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL337559: [analyzer] Rename DanglingInternalBufferChecker to InnerPointerChecker. (authored by rkovacs, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

r337559 - [analyzer] Rename DanglingInternalBufferChecker to InnerPointerChecker.

Author: rkovacs Date: Fri Jul 20 08:14:49 2018 New Revision: 337559 URL: http://llvm.org/viewvc/llvm-project?rev=337559&view=rev Log: [analyzer] Rename DanglingInternalBufferChecker to InnerPointerChecker. Differential Revision: https://reviews.llvm.org/D49553 Added: cfe/trunk/lib/StaticAnal

r337555 - [www] Add CodeCompass and CodeChecker to Clang Related Projects page

Author: bruno Date: Fri Jul 20 07:46:10 2018 New Revision: 337555 URL: http://llvm.org/viewvc/llvm-project?rev=337555&view=rev Log: [www] Add CodeCompass and CodeChecker to Clang Related Projects page Modified: cfe/trunk/www/related.html Modified: cfe/trunk/www/related.html URL: http://llvm

[PATCH] D49523: [clangd] Add support for per-file override compilation command

jkorous added a comment. BTW it looks like we already had kind of support for compilation command before (extra flags). commit 5ec1f7ca32eb85077a22ce81d41aa02a017d4852 Author: Krasimir Georgiev Date: Thu Jul 6 08:44:54 2017 + [clangd] Add support for per-file extra flags There is even

[PATCH] D49523: [clangd] Add support for per-file override compilation command

malaperle added a comment. In https://reviews.llvm.org/D49523#1169000, @arphaman wrote: > In https://reviews.llvm.org/D49523#1167553, @malaperle wrote: > > > Interesting! We also have a need for passing compilation commands in a > > context where there is no compile_commands.json, but we were th

[PATCH] D49546: [clangd] Implement query iterators for Dex symbol index

kbobyrev planned changes to this revision. kbobyrev added a comment. Upcoming changes: - Improve debugging experience by providing `llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, std::unique_ptr Iterator` to recursively pretty print queries in human-readable format: e.g. `(& [0, 1, 2, 3]

[PATCH] D49546: [clangd] Implement query iterators for Dex symbol index

kbobyrev updated this revision to Diff 156483. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. - Switched from `std::shared_ptr` to `std::unique_ptr` for iterator's children: iterators own their subtrees, the lifetime should depend on the root - Store `PostingListRef`in `Docu

[PATCH] D47474: Implement cpu_dispatch/cpu_specific Multiversioning

This revision was automatically updated to reflect the committed changes. Closed by commit rC337552: Implement cpu_dispatch/cpu_specific Multiversioning (authored by erichkeane, committed by ). Repository: rC Clang https://reviews.llvm.org/D47474 Files: include/clang/AST/Decl.h include/cl

  1   2   >