Author: vvassilev
Date: Tue Jul 17 23:49:33 2018
New Revision: 337353
URL: http://llvm.org/viewvc/llvm-project?rev=337353&view=rev
Log:
[modules] Print input files when -module-file-info file switch is passed.
This patch improves traceability of duplicated header files which end
up in multiple pc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337353: [modules] Print input files when -module-file-info
file switch is passed. (authored by vvassilev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
Author: mstorsjo
Date: Tue Jul 17 23:15:09 2018
New Revision: 337352
URL: http://llvm.org/viewvc/llvm-project?rev=337352&view=rev
Log:
[AArch64] Define TARGET_HEADER_BUILTIN
Without it, the new intrinsics became available for all language
variants. This was missed in SVN r337327.
Modified:
c
gaijiading updated this revision to Diff 156018.
gaijiading removed reviewers: mcrosier, fedor.sergeev.
gaijiading added a comment.
Add a test case to cover this.
Repository:
rC Clang
https://reviews.llvm.org/D46230
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/Inputs/ami_linux_tree/u
dankm created this revision.
Herald added a subscriber: cfe-commits.
GCC 8 implements -fmacro-prefix-map. Like -fdebug-prefix-map
it replaces a string prefix for the __FILE__ macro.
-ffile-prefix-map is the union of -fdebug-prefix-map and
-fmacro-prefix-map
Repository:
rC Clang
https://review
rjmccall added inline comments.
Comment at: lib/Sema/SemaCast.cpp:535
+T1 = Unwrap(T1);
+T2 = Unwrap(T2).withCVRQualifiers(T2.getCVRQualifiers());
+ }
rsmith wrote:
> rjmccall wrote:
> > Hmm. Just CVR? I understand that we can have problems here with t
rsmith added inline comments.
Comment at: lib/Sema/SemaCast.cpp:535
+T1 = Unwrap(T1);
+T2 = Unwrap(T2).withCVRQualifiers(T2.getCVRQualifiers());
+ }
rjmccall wrote:
> Hmm. Just CVR? I understand that we can have problems here with the
> enumerated qua
rjmccall added a comment.
Hmm. I think this is a reasonable change to make to the language. Have you
investigated to see if this causes source-compatibility problems?
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:849
+def err_atprotocol_protocol : Error<
+ "@protoc
rjmccall added inline comments.
Comment at: lib/Sema/SemaCast.cpp:535
+T1 = Unwrap(T1);
+T2 = Unwrap(T2).withCVRQualifiers(T2.getCVRQualifiers());
+ }
Hmm. Just CVR? I understand that we can have problems here with the
enumerated qualifiers, so maybe
sfertile added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10781
// endian platforms (i.e. index is complemented and source vector
reversed).
-unsigned ElemIdx0;
-unsigned ElemIdx1;
-if (getTarget().isLittleEndian()) {
- ElemIdx0 = (~Index & 1) +
0x8000- marked an inline comment as done.
0x8000- added a comment.
florin@helios:~/tools/llvm$ find . -name .clang-format | sort
./.clang-format
./projects/compiler-rt/lib/asan/.clang-format
./projects/compiler-rt/lib/dfsan/.clang-format
./projects/compiler-rt/lib/hwasan/.clang-format
./pr
0x8000- marked an inline comment as done.
0x8000- added inline comments.
Comment at: test/clang-tidy/readability-magic-numbers.cpp:124
+
+ explicit Point(T xval, T yval) noexcept : x{xval}, y{yval} {
+ }
Eugene.Zelenko wrote:
> 0x8000- wrote:
> > Eu
arphaman created this revision.
arphaman added reviewers: rjmccall, ahatanak, erik.pilkington, jfb.
Herald added a subscriber: dexonsmith.
Clang emits invalid protocol metadata when a `@protocol` expression is used
with a forward-declared protocol. The protocol metadata is missing protocol
confo
Author: pcc
Date: Tue Jul 17 17:27:07 2018
New Revision: 337339
URL: http://llvm.org/viewvc/llvm-project?rev=337339&view=rev
Log:
Re-land r337333, "Teach Clang to emit address-significance tables.",
which was reverted in r337336.
The problem that required a revert was fixed in r337338.
Also adde
Hello everyone,
Below are some buildbot numbers for the last week of 7/08/2018 - 7/14/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
Hello everyone,
Below are some buildbot numbers for the week of 7/01/2018 - 7/07/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to r
0x8000- updated this revision to Diff 155994.
0x8000- added a comment.
Address several review comments. Create alias for
cppcoreguidelines-avoid-magic-numbers .
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/readability/CMakeLists.txt
clang-
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaTemplate.cpp:1899-1907
// Canonicalize the type. This (for instance) replaces references to
// typedef members of the current instantiations with the definitions of
// those typedefs, avoiding triggering
Author: pcc
Date: Tue Jul 17 16:56:30 2018
New Revision: 337336
URL: http://llvm.org/viewvc/llvm-project?rev=337336&view=rev
Log:
Revert r337333, "Teach Clang to emit address-significance tables."
Causing multiple failures on sanitizer bots due to TLS symbol errors,
e.g.
/usr/bin/ld: __msan_orig
jfb added a comment.
In https://reviews.llvm.org/D46112#1113557, @aaron.ballman wrote:
> In https://reviews.llvm.org/D46112#1098243, @rsmith wrote:
>
> > In https://reviews.llvm.org/D46112#1096893, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D46112#1091981, @efriedma wrote:
> > >
jfb created this revision.
jfb added a reviewer: dexonsmith.
Herald added a subscriber: cfe-commits.
Using _Atomic to do implicit load / store is just a seq_cst atomic_load /
atomic_store. Stores currently assert in Sema::ImpCastExprToType with 'can't
implicitly cast lvalue to rvalue with this c
rsmith created this revision.
rsmith added a reviewer: rjmccall.
DR330: when determining whether a cast casts away constness, consider
qualifiers from all levels matching a multidimensional array.
For example, this allows casting from
pointer to array ofarray of const volat
Eugene.Zelenko added inline comments.
Comment at: test/clang-tidy/readability-magic-numbers.cpp:124
+
+ explicit Point(T xval, T yval) noexcept : x{xval}, y{yval} {
+ }
0x8000- wrote:
> Eugene.Zelenko wrote:
> > Please run Clang-format over test case.
> I d
rjmccall added a comment.
Please test that we still copy captures correctly into the block object and
destroy them when the block object is destroyed.
For the sorts of ephemeral blocks that we currently mark non-escaping, we can
think about optimizing that away, too, but for now please test tha
nemanjai added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10780
// endian order so the shuffle mask must be adjusted for this on little
// endian platforms (i.e. index is complemented and source vector
reversed).
+unsigned ElemIdx0 = (Index & 2) >> 1;;
0x8000- marked 4 inline comments as done.
0x8000- added a comment.
@Eugene.Zelenko thank you for suggesting the alias - I didn't know it is that
easy, but a grep on "alias" led me to the right place.
Comment at: clang-tidy/readability/MagicNumbersCheck.h:55
+ const s
Author: pcc
Date: Tue Jul 17 16:17:16 2018
New Revision: 337333
URL: http://llvm.org/viewvc/llvm-project?rev=337333&view=rev
Log:
Teach Clang to emit address-significance tables.
By default, we emit an address-significance table on all ELF
targets when the integrated assembler is enabled. The emi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337333: Teach Clang to emit address-significance tables.
(authored by pcc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48155?vs=151282&id=155984#toc
Repository:
rC Clang
https
rjmccall added a comment.
This is the right basic approach. I think it would be better if the diagnostic
text was more like `err_function_template_spec_no_match`, maybe "no candidate
function template was found for dependent friend function template
specialization". And it would be good to em
juliehockett added a comment.
ping
Comment at: clang-tools-extra/test/clang-doc/yaml-comments.cpp:30
+// CHECK: ---
+// CHECK-NEXT: USR:
'{{[0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-9A-Z][0-
efriedma added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D45712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added inline comments.
Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460
CGObjCNonFragileABIMac::GetEHType(QualType T) {
// There's a particular fixed type info for 'id'.
if (T->isObjCIdType() || T->isObjCQualifiedIdType()) {
+if (CGM.getTriple().isWindowsMSVCEn
Meinersbur added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D48808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
Can you explain why this is important for the optimizer?
https://reviews.llvm.org/D49403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added inline comments.
Comment at: include/clang/AST/ASTContext.h:1953
unsigned char getFixedPointIBits(QualType Ty) const;
+ FixedPointSemantics getFixedPointSema(QualType Ty) const;
+ APFixedPoint getFixedPointMax(QualType Ty) const;
rjmccall wrot
Author: rsmith
Date: Tue Jul 17 15:24:11 2018
New Revision: 337330
URL: http://llvm.org/viewvc/llvm-project?rev=337330&view=rev
Log:
Replace LLVM_ALIGNAS with just alignas.
Various places in Clang and LLVM are already using alignas; it seems
our minimum host configuration now requires it.
Modifi
Author: rsmith
Date: Tue Jul 17 15:24:09 2018
New Revision: 337329
URL: http://llvm.org/viewvc/llvm-project?rev=337329&view=rev
Log:
Restructure checking for, and warning on, lifetime extension.
This change implements C++ DR1696, which makes initialization of a
reference member of a class from a
rjmccall added inline comments.
Comment at: lib/Sema/SemaCast.cpp:2171
+ ->getPointeeType()
+ .getAddressSpace()) {
+Kind = CK_AddressSpaceConversion;
Please extract t
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:444
+auto HandleValue =
+CtorBuilder.CreateAlignedLoad(GpuBinaryHandle, CGM.getPointerAlign());
+llvm::Constant *Zero =
llvm::Constant::getNullValue(HandleValue->getType());
Do
echristo added a comment.
I think you should break it out on an option by option basis. Just warning on
"non-standard" options doesn't really make sense.
Repository:
rC Clang
https://reviews.llvm.org/D49148
___
cfe-commits mailing list
cfe-commi
Author: mgrang
Date: Tue Jul 17 15:03:24 2018
New Revision: 337327
URL: http://llvm.org/viewvc/llvm-project?rev=337327&view=rev
Log:
[COFF] Add more missing MSVC ARM64 intrinsics
Summary:
Added the following intrinsics:
_BitScanForward, _BitScanReverse, _BitScanForward64, _BitScanReverse64
_Inter
delcypher added inline comments.
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2298
SanitizerMask Res = ToolChain::getSupportedSanitizers();
- Res |= SanitizerKind::Address;
- Res |= SanitizerKind::Leak;
- Res |= SanitizerKind::Fuzzer;
- Res |= SanitizerKind::FuzzerNo
delcypher requested changes to this revision.
delcypher added a comment.
This revision now requires changes to proceed.
Seems mostly fine apart from some minor nits.
If I'm honest I don't see any reason why this should be Darwin specific. Sure
the naming convention and location of the runtime li
NoQ added a comment.
I showed the bug mentioned in https://reviews.llvm.org/D49058 to a friend who
didn't do much C++ recently, for a fresh look, and he provided a bunch of
interesting feedback by explaining the way he didn't understand what the
analyzer was trying to say.
1. When we call `c_s
Quuxplusone added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6425
+ "available on %2 %3 or newer">;
def note_silence_unligned_allocation_unavailable : Note<
"if you supply your own aligned allocation functions, use "
I observe th
aheejin updated this revision to Diff 155958.
aheejin added a comment.
- Type fix
Repository:
rC Clang
https://reviews.llvm.org/D49396
Files:
include/clang/Basic/BuiltinsWebAssembly.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-wasm.c
Index: test/CodeGen/builtins-wasm.c
===
Author: echristo
Date: Tue Jul 17 13:22:17 2018
New Revision: 337321
URL: http://llvm.org/viewvc/llvm-project?rev=337321&view=rev
Log:
Remove unnecessary trailing ; in macro intrinsic definition.
Modified:
cfe/trunk/lib/Headers/avx512dqintrin.h
Modified: cfe/trunk/lib/Headers/avx512dqintrin.
EricWF added a reviewer: dexonsmith.
EricWF added a comment.
Ping.
Are there any more reviewers I should add to this?
https://reviews.llvm.org/D45015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
sammccall added a comment.
In https://reviews.llvm.org/D48559#1165172, @jkorous wrote:
> Hi Sam, thanks for your feedback!
>
> In general I agree that explicitly factoring out the transport layer and
> improving layering would be a good thing. Unfortunately it's highly probable
> that we'd like
rnkovacs updated this revision to Diff 155944.
rnkovacs marked 2 inline comments as done.
rnkovacs added a reviewer: dcoughlin.
rnkovacs added a comment.
Note messages updated.
https://reviews.llvm.org/D49360
Files:
lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp
lib/StaticAna
rnkovacs added inline comments.
Comment at: test/Analysis/dangling-internal-buffer.cpp:175
std::string s;
- {
-c = s.c_str();
- }
- consume(c); // no-warning
+ c = s.c_str(); // expected-note {{Pointer to dangling buffer was obtained
here}}
+ s.clear(); // expect
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337312: The semantics of DW_CFA_GNU_args_size have changed
subtile over the (authored by joerg, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://reviews
Author: joerg
Date: Tue Jul 17 12:00:51 2018
New Revision: 337312
URL: http://llvm.org/viewvc/llvm-project?rev=337312&view=rev
Log:
The semantics of DW_CFA_GNU_args_size have changed subtile over the
years. Adopt the new convention that it is call-site specific and that
it should be applied before
efriedma added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10780
// endian order so the shuffle mask must be adjusted for this on little
// endian platforms (i.e. index is complemented and source vector
reversed).
+unsigned ElemIdx0 = (Index & 2) >> 1;;
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
Herald added a reviewer: javed.absar.
Herald added subscribers: dexonsmith, kristof.beyls.
The problem was with constructors that have parameters that refer to previous
ones, such as `D` below:
template struct A
george.karpenkov added a comment.
@delcypher Could you take a look?
@kcc Any objections?
https://reviews.llvm.org/D15225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
Comment at: test/Analysis/temporaries.cpp:472
+ for (int i = 0;;)
+F j(i ? j : h);
+}
// no-crash?
Repository:
george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:715
void ento::registerUninitializedObjectChecker(CheckerManager &Mg
Szelethus added a comment.
I left a comment on this issue already:
https://reviews.llvm.org/D49437#1165462. But in short, definitely yes! It's
been very painful to work around pointer/reference objects, too bad I didn't
come up with this idea sooner :)
Repository:
rC Clang
https://reviews.
george.karpenkov added a comment.
@Szelethus false positives are a single biggest problem of the analyzer.
By a *huge* margin, most projects would prefer to err on the side of less, more
precise, warnings.
Given that currently in my understanding no actual bugs we are sure about were
found by th
vsapsai added inline comments.
Comment at: include/vector:300
+{
+using _Alloc_traits = allocator_traits<_Alloc>;
+for (; __begin1 != __end1; ++__begin1, (void)++__begin2)
Quuxplusone wrote:
> vsapsai wrote:
> > Have you checked why `using` is accepted in
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, rnkovacs, xazax.hun.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
The idea came from both @george.karpenkov
(https://reviews.llvm.org/D45532#1145592) and from bugzilla
(h
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Cf. my comments to https://reviews.llvm.org/D49437: is it possible to separate
pointer-chasing from the rest of the checker?
https://reviews.llvm.org/D49199
_
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Cf. my comments to https://reviews.llvm.org/D49437: while this change looks
great, is it possible to separate the pointer chasing from the rest of the
checker?
Author: mramalho
Date: Tue Jul 17 10:40:34 2018
New Revision: 337304
URL: http://llvm.org/viewvc/llvm-project?rev=337304&view=rev
Log:
[analyzer] Fix Z3 backend after D48205
Summary:
An assertion was added in D48205 to catch places where a `nonloc::SymbolVal`
was wrapping a `loc` object.
This p
Quuxplusone added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:7984
+ if (isa(ThirdArg) &&
+ cast(ThirdArg)->getValue() == 0) {
+WarningKind = 0;
> Suppress the diagnostic in cases like `memset(ptr, 0xff, PADDING)`, when
> `PADDING` is
Szelethus updated this revision to Diff 155915.
Szelethus added a comment.
Rebased to the latest trunk.
https://reviews.llvm.org/D49228
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cxx-uninitialized-object-ptr-ref.cpp
Index: test/Analysis/cxx-uninitialize
Szelethus updated this revision to Diff 155913.
Szelethus added a comment.
Rebased to the latest trunk.
https://reviews.llvm.org/D49199
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cxx-uninitialized-object-inheritance.cpp
test/Analysis/cxx-uninitialized-
jkorous added a reviewer: sammccall.
jkorous added a comment.
Hi Sam, I am definitely open to discussion about the right abstraction.
I will push patches rebased on TOT and changes based on your comments today or
tomorrow and I am trying to figure out how could we use your Transport
abstraction
Eugene.Zelenko added a comment.
Adding C++ Core Guidelines alias is definitely low-hanging fruit which could be
implemented within this patch.
Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:14
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+
+#include
--
erik.pilkington planned changes to this revision.
erik.pilkington added a comment.
In https://reviews.llvm.org/D49112#1158793, @thakis wrote:
> lgtm assuming you ran this on some large code base to make sure it doesn't
> have false positives.
Sorry for the delay here, I was running this on som
Eugene.Zelenko added a comment.
> But you could also take a look at the enforcement of some coding
> guidelines (my personal todolists:
> https://github.com/JonasToth/CppCoreGuidelinesTooling
> https://github.com/JonasToth/HighIntegrityTooling). There are always low
> hanging fruit checks. Im
greened added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zturner added a comment.
Why do we only want this for CodeView?
Repository:
rC Clang
https://reviews.llvm.org/D45124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added inline comments.
Herald added subscribers: bixia, jlebar.
Comment at: libcxx/include/experimental/simd:994
+
+// NOTE: _Abis... is the extension proposed by P0820, allowing the APIs to
+// propagate _StorageKind during transforming input type(s) to the output ty
jkorous added a comment.
Hi Sam, thanks for your feedback!
In general I agree that explicitly factoring out the transport layer and
improving layering would be a good thing. Unfortunately it's highly probable
that we'd like to drop JSON completely from XPC dispatch (XPC -> JSON ->
ProtocolCall
jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.
Please refer to the commit for the LLVM half of the change in the commit
message for this.
LGTM, other than some minor suggestions for the help texts.
Comment at: docs/
Author: nico
Date: Tue Jul 17 08:07:40 2018
New Revision: 337290
URL: http://llvm.org/viewvc/llvm-project?rev=337290&view=rev
Log:
clang-cl: Postpone Wmsvc-not-found emission until link.exe gets used.
Wmsvc-not-found was added in r297851 to help diagnose why link.exe can't be
executed. However, i
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
r337290, thanks!
https://reviews.llvm.org/D49398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
manojgupta updated this revision to Diff 155891.
manojgupta added a comment.
Added helper text, updated tests.
Repository:
rC Clang
https://reviews.llvm.org/D47894
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337289: [Fixed Point Arithmetic] Fix for bug where integer
literals could be treated as… (authored by leonardchan, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49327?vs=155519&id=1
Author: leonardchan
Date: Tue Jul 17 07:58:49 2018
New Revision: 337289
URL: http://llvm.org/viewvc/llvm-project?rev=337289&view=rev
Log:
[Fixed Point Arithmetic] Fix for bug where integer literals could be treated as
fixed point literals
This addresses a bug brought up in https://bugs.llvm.org/
zturner added a comment.
Lgtm. I also have a hard time saying which is best, we’re basically trying
to help people who have already strayed from the path, so there’s probably
no objectively correct answer
https://reviews.llvm.org/D49398
___
cfe-comm
Lgtm. I also have a hard time saying which is best, we’re basically trying
to help people who have already strayed from the path, so there’s probably
no objectively correct answer
On Tue, Jul 17, 2018 at 7:26 AM Nico Weber via Phabricator <
revi...@reviews.llvm.org> wrote:
> thakis updated this re
Author: idrissrio
Date: Tue Jul 17 07:35:15 2018
New Revision: 337286
URL: http://llvm.org/viewvc/llvm-project?rev=337286&view=rev
Log:
[clang-tidy: modernize] Fix modernize-use-equals-default with {} brackets list
initialization: patch
Summary:
Hello, i would like to suggest a fix for one of th
This revision was automatically updated to reflect the committed changes.
IdrissRio marked an inline comment as done.
Closed by commit rCTE337286: [clang-tidy: modernize] Fix
modernize-use-equals-default with {} brackets list… (authored by IdrissRio,
committed by ).
Changed prior to commit:
ht
JonasToth added a comment.
In https://reviews.llvm.org/D49114#1164788, @0x8000- wrote:
> @aaron.ballman , @JonasToth , @Eugene.Zelenko Is there anything missing from
> this patch? What do I need to do to get it merged? This is my first
> contribution to LLVM so I'm not quite sure. Thank you
thakis updated this revision to Diff 155885.
thakis added a comment.
address comment
https://reviews.llvm.org/D49398
Files:
lib/Driver/ToolChains/MSVC.cpp
lib/Driver/ToolChains/MSVC.h
Index: lib/Driver/ToolChains/MSVC.h
===
-
Author: nico
Date: Tue Jul 17 07:20:02 2018
New Revision: 337285
URL: http://llvm.org/viewvc/llvm-project?rev=337285&view=rev
Log:
Remove superfluous ; to fix -Wpedantic warning from gcc
Modified:
cfe/trunk/unittests/AST/ASTImporterTest.cpp
Modified: cfe/trunk/unittests/AST/ASTImporterTest.c
thakis added inline comments.
Comment at: lib/Driver/ToolChains/MSVC.cpp:467-468
if (Linker.equals_lower("link")) {
+if (!TC.FoundMSVCInstall())
+ C.getDriver().Diag(clang::diag::warn_drv_msvc_not_found);
+
zturner wrote:
> It looks like it's possible
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337284: [Tooling] Add operator== to CompileCommand (authored
by simark, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49265?vs=155773&id=155883#toc
Repository:
rL LLVM
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337284: [Tooling] Add operator== to CompileCommand (authored
by simark, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49265
Files:
cfe/trunk/
Author: simark
Date: Tue Jul 17 07:13:05 2018
New Revision: 337284
URL: http://llvm.org/viewvc/llvm-project?rev=337284&view=rev
Log:
[Tooling] Add operator== to CompileCommand
Summary:
It does the obvious thing of comparing all fields. This will be needed
for a clangd patch I have in the pipelin
JonasToth added a comment.
What do you mean by "The code is a bit more intimidating", the check
itself or the amount of tests?
In general the utility piece that was commited before this check should
already analyze the constness good, given that this check builds upon it
the functionality should
lu-zero accepted this revision.
lu-zero added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
Repository:
rC Clang
https://reviews.llvm.org/D49424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Thanks for noticing. Reverted for now in r337278. The wording is still bad,
but talking about ODR uses in there feels worse.
On Tue, Jul 17, 2018 at 1:02 PM Malcolm Parsons
wrote:
> On Mon, 16 Jul 2018 at 10:57, Benjamin Kramer via cfe-commits
> wrote:
> > - auto explicit_by_value_unused_sizeo
nemanjai created this revision.
nemanjai added reviewers: lu-zero, hfinkel.
Herald added a subscriber: kbarton.
The codegen for this builtin was initially implemented to match GCC. However,
due to interest from users GCC changed behaviour to account for the big endian
bias of the instruction and
Author: d0k
Date: Tue Jul 17 06:17:01 2018
New Revision: 337278
URL: http://llvm.org/viewvc/llvm-project?rev=337278&view=rev
Log:
Revert "[Sema] Reword warning for constant captures that are not required"
This reverts commit r337152. This applies to non-constants too. The real
explanation is that
Author: joerg
Date: Tue Jul 17 06:13:34 2018
New Revision: 337277
URL: http://llvm.org/viewvc/llvm-project?rev=337277&view=rev
Log:
Always use __mcount on NetBSD. Some platforms don't provide _mcount.
Modified:
cfe/trunk/lib/Basic/Targets/OSTargets.h
cfe/trunk/test/CodeGen/mcount.c
cf
ioeric created this revision.
ioeric added reviewers: aaron.ballman, sammccall.
Herald added a subscriber: cfe-commits.
Currently, protected members from base classes are marked as
inaccessible when completing in derived class. This patch fixes the problem by
setting the naming class correctly whe
1 - 100 of 131 matches
Mail list logo
