mclow.lists added inline comments.
Comment at: include/span:236
+_LIBCPP_INLINE_VISIBILITY constexpr span(pointer __ptr, index_type
__count) : __data{__ptr}
+{ assert(_Extent == __count); }
+_LIBCPP_INLINE_VISIBILITY constexpr span(pointer __f, pointer __l) :
__
0x8000- updated this revision to Diff 155549.
0x8000- added a comment.
Accept magic values arbitrarily deep in a constant initialization
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/MagicNum
Author: marshall
Date: Fri Jul 13 21:15:19 2018
New Revision: 337087
URL: http://llvm.org/viewvc/llvm-project?rev=337087&view=rev
Log:
Mark __equal_to 's operations as constexpr.
Modified:
libcxx/trunk/include/algorithm
Modified: libcxx/trunk/include/algorithm
URL:
http://llvm.org/viewvc/ll
Author: marshall
Date: Fri Jul 13 20:06:11 2018
New Revision: 337085
URL: http://llvm.org/viewvc/llvm-project?rev=337085&view=rev
Log:
Mark one more __wrap_iter operation as constexpr.
Modified:
libcxx/trunk/include/iterator
Modified: libcxx/trunk/include/iterator
URL:
http://llvm.org/view
aleksandr.urakov added a comment.
Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D49227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
In https://reviews.llvm.org/D48287#1138262, @tra wrote:
> Using OpenCL's flag for the purpose adds a *third* way we handle denormals
> flushing in clang. Now it would be HIP (which is CUDA-like) using OpenCL's
> flag for denormals instead of CUDA's one.
> You could chan
Author: tejohnson
Date: Fri Jul 13 18:50:14 2018
New Revision: 337082
URL: http://llvm.org/viewvc/llvm-project?rev=337082&view=rev
Log:
Revert "[ThinLTO] Ensure we always select the same function copy to import"
This reverts commit r337051.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Mo
rupprecht created this revision.
rupprecht added a reviewer: saugustine.
Herald added subscribers: cfe-commits, aheejin, sbc100, dberris, srhines.
Some methods in compiler-rt builtins have dependencies on libm. Therefore
building with -rtlib=compiler-rt is completely broken if those symbols are u
Author: eugenezelenko
Date: Fri Jul 13 15:53:05 2018
New Revision: 337069
URL: http://llvm.org/viewvc/llvm-project?rev=337069&view=rev
Log:
[Documentation] Add missing description for bugprone-exception-escape in
Release Notes.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modifie
leonardchan added a comment.
@ebevhan Any followup on the patch/my previous comments?
Repository:
rC Clang
https://reviews.llvm.org/D48661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
leonardchan added a comment.
@erichkeane I created a patch at https://reviews.llvm.org/D49327 with the fix
for this and added you as a reviewer.
Repository:
rC Clang
https://reviews.llvm.org/D46915
___
cfe-commits mailing list
cfe-commits@lists.
leonardchan created this revision.
leonardchan added reviewers: erichkeane, ebevhan, rjmccall, rsmith,
jakehehrlich, mcgrathr, phosek.
leonardchan added a project: clang.
This addresses a bug brought up in https://bugs.llvm.org/show_bug.cgi?id=38161
where integer literals could be treated as fix
efriedma added a comment.
Adding startFrontendTimer/stopFrontendTimer helps a little, but it's still
difficult to match a given startFrontendTimer to the corresponding
stopFrontendTimer because they're in completely different functions in some
cases. Do they really need to be scattered like th
Author: tejohnson
Date: Fri Jul 13 14:35:58 2018
New Revision: 337051
URL: http://llvm.org/viewvc/llvm-project?rev=337051&view=rev
Log:
[ThinLTO] Ensure we always select the same function copy to import
Clang change to reflect the FunctionsToImportTy type change
in the llvm changes for D48670.
M
alexshap accepted this revision.
alexshap added a comment.
This revision is now accepted and ready to land.
to me LG
Repository:
rC Clang
https://reviews.llvm.org/D48845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: kparzysz
Date: Fri Jul 13 14:32:33 2018
New Revision: 337049
URL: http://llvm.org/viewvc/llvm-project?rev=337049&view=rev
Log:
[Hexagon] Fix hvx-length feature name in testcases
Modified:
cfe/trunk/test/CodeGen/builtins-hvx128.c
cfe/trunk/test/CodeGen/builtins-hvx64.c
Modified: c
Author: rsmith
Date: Fri Jul 13 14:29:31 2018
New Revision: 337048
URL: http://llvm.org/viewvc/llvm-project?rev=337048&view=rev
Log:
Make BuiltinType constructor private, and befriend ASTContext.
This reflects the fact that only ASTContext should ever create an
instance of BuiltinType, and matche
arphaman added inline comments.
Herald added a subscriber: dexonsmith.
Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51
+ dlHandle, "clangd_xpc_get_bundle_identifier");
+ xpc_connection_t conn =
+ xpc_connection_create(clangd_xpc_get_bundle_identifier(), NULL
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337047: Use external layout information to layout bit-fields
for MS ABI. (authored by rsmith, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D49227
Files:
lib/AST/RecordLayoutBuilder.c
Author: rsmith
Date: Fri Jul 13 14:07:42 2018
New Revision: 337047
URL: http://llvm.org/viewvc/llvm-project?rev=337047&view=rev
Log:
Use external layout information to layout bit-fields for MS ABI.
Patch by Aleksandr Urakov!
Differential Revision: https://reviews.llvm.org/D49227
Added:
cfe/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337047: Use external layout information to layout bit-fields
for MS ABI. (authored by rsmith, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
aaronpuchert added a comment.
Thanks for the review. Could you commit this as `Aaron Puchert
https://reviews.llvm.org/D49275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337041: CodeGen: specify alignment + inbounds for automatic
variable initialization (authored by jfb, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.o
Author: jfb
Date: Fri Jul 13 13:33:23 2018
New Revision: 337041
URL: http://llvm.org/viewvc/llvm-project?rev=337041&view=rev
Log:
CodeGen: specify alignment + inbounds for automatic variable initialization
Summary: Automatic variable initialization was generating default-aligned
stores (which ar
manojgupta added a comment.
Ping!
Repository:
rC Clang
https://reviews.llvm.org/D47894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Quuxplusone updated this revision to Diff 155473.
Quuxplusone added a comment.
Move the functions from `` to ``, since that's their only
caller.
Uniform treatment of the pointer/iterator parameters; discover that the
difference between "copy_forward" and "copy_range_forward" was that the former
acomminos updated this revision to Diff 155472.
acomminos marked an inline comment as done.
acomminos added a comment.
Use source ranges instead of a pair of source locations for explicit lambda
captures.
Repository:
rC Clang
https://reviews.llvm.org/D48845
Files:
include/clang/Sema/DeclS
Author: ctopper
Date: Fri Jul 13 13:16:38 2018
New Revision: 337040
URL: http://llvm.org/viewvc/llvm-project?rev=337040&view=rev
Log:
[X86] Change the rounding mode used when testing the sqrt_round intrinsics.
Using CUR_DIRECTION is not a realistic scenario. That is equivalent to the
intrinsic w
acomminos marked an inline comment as done.
acomminos added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:2552-2553
ParsedType InitCaptureType;
+SourceLocation LocStart;
+SourceLocation LocEnd;
+
aaron.ballman wrote:
> aaron.ballman wrot
Quuxplusone created this revision.
Quuxplusone added reviewers: EricWF, mclow.lists, erik.pilkington, vsapsai.
Herald added subscribers: cfe-commits, ldionne, christof.
Inspired by Volodymyr's work on https://reviews.llvm.org/D48753, I've taken it
upon myself to refactor the static member functio
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM -- great! Just make sure the commit message does not pretend the change
includes `merge`.
This may be obvious, but my LGTM alone should probably not be enough to submit.
https://revie
Author: vlad.tsyrklevich
Date: Fri Jul 13 12:48:35 2018
New Revision: 337037
URL: http://llvm.org/viewvc/llvm-project?rev=337037&view=rev
Log:
SafeStack: Add builtins to read unsafe stack top/bottom
Summary:
Introduce built-ins to read the unsafe stack top and bottom. The unsafe
stack top is requ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337036: PR15730/PR16986 Allow dependently typed vector_size
types. (authored by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49
Author: erichkeane
Date: Fri Jul 13 12:46:04 2018
New Revision: 337036
URL: http://llvm.org/viewvc/llvm-project?rev=337036&view=rev
Log:
PR15730/PR16986 Allow dependently typed vector_size types.
As listed in the above PRs, vector_size doesn't allow
dependent types/values. This patch introduces a
erichkeane added a comment.
In https://reviews.llvm.org/D46915#1162095, @leonardchan wrote:
> In https://reviews.llvm.org/D46915#1162038, @erichkeane wrote:
>
> > See this bug here: https://bugs.llvm.org/show_bug.cgi?id=38161
> >
> > This patch doesn't seem to properly consider integers, and igno
leonardchan added a comment.
In https://reviews.llvm.org/D46915#1162038, @erichkeane wrote:
> See this bug here: https://bugs.llvm.org/show_bug.cgi?id=38161
>
> This patch doesn't seem to properly consider integers, and ignores octals,
> which I suspect shouldn't be the case.
I just requested
aaron.ballman added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:2552-2553
ParsedType InitCaptureType;
+SourceLocation LocStart;
+SourceLocation LocEnd;
+
aaron.ballman wrote:
> How does `LocStart` relate to the existing source location
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, though it's your call on the const_cast stuff whether you want to revert
or keep it.
Comment at: include/clang/AST/Type.h:3105
+public:
+ Expr *getSizeE
erichkeane added a comment.
See this bug here: https://bugs.llvm.org/show_bug.cgi?id=38161
This patch doesn't seem to properly consider integers, and ignores octals,
which I suspect shouldn't be the case.
Repository:
rC Clang
https://reviews.llvm.org/D46915
__
acomminos updated this revision to Diff 155446.
acomminos marked 2 inline comments as done.
acomminos added a comment.
Add test for stateful initializer expressions not being removed, propagate
whether or not a diagnostic actually get emitted.
Repository:
rC Clang
https://reviews.llvm.org/D4
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/CodeGen/CGBuilder.h:260
+CharUnits::fromQuantity(Offset.getSExtValue(;
+ }
+
jfb wrote:
> efriedma
Author: marshall
Date: Fri Jul 13 10:31:36 2018
New Revision: 337028
URL: http://llvm.org/viewvc/llvm-project?rev=337028&view=rev
Log:
wrap _LIBCPP_HAS_NO_CXX14_CONSTEXPR in defined(...)
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/vi
acomminos updated this revision to Diff 155430.
acomminos marked 2 inline comments as done.
acomminos added a comment.
Elide braces in single-line conditional.
Repository:
rC Clang
https://reviews.llvm.org/D48845
Files:
include/clang/Sema/DeclSpec.h
include/clang/Sema/ScopeInfo.h
inclu
acomminos updated this revision to Diff 155428.
acomminos marked 2 inline comments as done.
acomminos added a comment.
Thanks! Updated to be more explicit about location names, add more tests for
VLA and *this captures, and fix an issue with VLA range captures invalidating
the capture range trac
Author: marshall
Date: Fri Jul 13 10:24:59 2018
New Revision: 337027
URL: http://llvm.org/viewvc/llvm-project?rev=337027&view=rev
Log:
Shot in the dark to fix gcc 4.9 / c++11 build
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/l
jfb marked an inline comment as done.
jfb added inline comments.
Comment at: lib/CodeGen/CGBuilder.h:260
+CharUnits::fromQuantity(Offset.getSExtValue(;
+ }
+
efriedma wrote:
> Not sure about the new helper. We already have Create
tks2103 added a comment.
ping @modocache @GorNishanov
Repository:
rC Clang
https://reviews.llvm.org/D48981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jfb updated this revision to Diff 155424.
jfb added a comment.
- Simplify CreateStore.
Repository:
rC Clang
https://reviews.llvm.org/D49209
Files:
lib/CodeGen/CGBuilder.h
lib/CodeGen/CGDecl.cpp
test/CodeGen/init.c
test/CodeGenOpenCL/partial_initializer.cl
Index: test/CodeGenOpenCL/p
erichkeane added inline comments.
Comment at: include/clang/AST/ASTContext.h:1327-1329
+ QualType getDependentVectorType(QualType VectorType, Expr *SizeExpr,
+ SourceLocation AttrLoc,
+ VectorType::Vecto
erichkeane updated this revision to Diff 155419.
erichkeane marked 12 inline comments as done.
https://reviews.llvm.org/D49045
Files:
include/clang/AST/ASTContext.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/Type.h
include/clang/AST/TypeLoc.h
include/clang/AST/TypeNodes.d
Quuxplusone added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:662
+def note_suspicious_sizeof_memset_silence : Note<
+ "%select{parenthesize the third argument|cast the second argument to 'int'}0
to silence">;
+
aaron.ballman w
Author: marshall
Date: Fri Jul 13 09:35:26 2018
New Revision: 337019
URL: http://llvm.org/viewvc/llvm-project?rev=337019&view=rev
Log:
Make internal class __wrap_iter constexpr when not using libc++'s debugging
mode. Introduce a new macro _LIBCPP_CONSTEXPR_IF_NODEBUG to mark this.
Modified:
ahatanak created this revision.
ahatanak added a reviewer: rjmccall.
Herald added a subscriber: dexonsmith.
Copying or disposing of a non-escaping block can be a no-op. A non-escaping
block on the stack doesn't have to be copied to the heap as we know it won't be
called after its lifetime ends.
ldionne added inline comments.
Comment at: libcxx/include/map:43
typedef std::reverse_iteratorconst_reverse_iterator;
+typedef unspecified node_type;
+typedef INSERT_RETURN_TYPE insert_return_type;
You are missing `/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337017: Fix PR34668 - P0704R1 implementation is too
permissive (authored by Rakete, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D38075?vs=155410&id=155412#toc
Repository:
rC
Author: rakete
Date: Fri Jul 13 09:27:45 2018
New Revision: 337017
URL: http://llvm.org/viewvc/llvm-project?rev=337017&view=rev
Log:
Fix PR34668 - P0704R1 implementation is too permissive
Summary:
https://bugs.llvm.org/show_bug.cgi?id=34668
Pretty straightforward.
Reviewers: rsmith, Rakete1
Rakete updated this revision to Diff 155410.
Rakete added a comment.
Change error message to reflect the new update error message since the last
revision.
Repository:
rC Clang
https://reviews.llvm.org/D38075
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/cxx2a-pointer-to-const-ref
Author: marshall
Date: Fri Jul 13 09:26:16 2018
New Revision: 337016
URL: http://llvm.org/viewvc/llvm-project?rev=337016&view=rev
Log:
Fix a couple of 'unused variable' warnings in a vector test. NFC.
Modified:
libcxx/trunk/test/std/containers/sequences/vector/iterators.pass.cpp
Modified: l
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
I have no further comments here.
I assume this works as intended; if not, since it is mainly a developer-only
tool, further issues could be addressed later on.
Maybe wait a bit just in
bricci created this revision.
bricci added reviewers: arphaman, bkramer, rsmith.
bricci added a project: clang.
Herald added a subscriber: cfe-commits.
1. Pack std::pair in CXXBasePaths::ClassSubobjects.
2. Use a SmallPtrSet instead of a SmallDenseSet for
CXXBasePaths::VisitedDependentRecords.
3.
Author: gbercea
Date: Fri Jul 13 09:18:24 2018
New Revision: 337015
URL: http://llvm.org/viewvc/llvm-project?rev=337015&view=rev
Log:
[OpenMP] Initialize data sharing stack for SPMD case
Summary: In the SPMD case, we need to initialize the data sharing and
globalization infrastructure. This cove
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337015: [OpenMP] Initialize data sharing stack for SPMD case
(authored by gbercea, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49188
Files:
juliehockett added a comment.
In https://reviews.llvm.org/D49268#1161268, @lebedev.ri wrote:
> Did you meant to commit `clang-tools-extra/clang-doc/test_cases/` ?
> I can't tell whether it is a temporary directory or not.
It is, it's the code for the actual test cases that are generated (so th
tcanens added a comment.
In https://reviews.llvm.org/D38075#1161325, @Rakete wrote:
> Do you need someone to commit it?
Yes, please.
https://reviews.llvm.org/D38075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
martong created this revision.
martong added reviewers: a.sidorin, a_sidorin, r.stahl.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Implementation functions call into the member functions of
ASTStructuralEquivalence, thus they can falsely alter the DeclsToCheck state
(they add decls).
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D49188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
gtbercea updated this revision to Diff 155391.
gtbercea added a comment.
Fix tests.
Repository:
rC Clang
https://reviews.llvm.org/D49188
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
test/OpenMP/nvptx_data_sharing.cpp
test/OpenMP/nvptx_target_parallel_codegen.cpp
test/OpenMP/nvptx_targ
martong created this revision.
martong added reviewers: a.sidorin, a_sidorin, balazske, gerazo.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
https://reviews.llvm.org/D48773 simplified ASTImporter nicely, but it
introduced a new error: Unnamed
structs are not imported correctly, if the
lebedev.ri added a comment.
Well, that's just great, with `isCastPartOfExplictCast()`, the
`ASTContext::getParents()`
also does not return `CXXStaticCastExpr` as parent for such cases.
I don't know how to proceed.
Repository:
rC Clang
https://reviews.llvm.org/D48958
__
yaxunl created this revision.
yaxunl added a reviewer: rjmccall.
Currently clang does not allow implicit cast of a pointer to a pointer type in
different address space but allows C-style cast of a pointer to a pointer type
in different address space. However, there is a bug in Sema causing incor
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D49293
Files:
lib/AST/ASTImporter.cpp
test/Import/inherited-ctor-init-expr/Inputs/A.cpp
test/Import/inherited-ctor-init-expr/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337000: [Analyzer] alpha.unix.cstring.OutOfBounds checker
enable/disable fix (authored by baloghadamsoftware, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48831
Files:
lib/StaticAn
Author: baloghadamsoftware
Date: Fri Jul 13 06:44:44 2018
New Revision: 337000
URL: http://llvm.org/viewvc/llvm-project?rev=337000&view=rev
Log:
[Analyzer] alpha.unix.cstring.OutOfBounds checker enable/disable fix
It was not possible to disable alpha.unix.cstring.OutOfBounds checker's reports
sin
NoQ accepted this revision.
NoQ added a comment.
Whoops, sry, yeah, looks good, please commit!
https://reviews.llvm.org/D48831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus added a comment.
> I'll think about that a bit more; it might be worth it to track such deferred
> subregions in a state trait and drain it whenever we pop back to an explicit
> constructor.
There are so many things to consider, like the following case:
struct DynTBase {};
struct
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336997: [clang-tidy] Exception Escape Checker (authored by
baloghadamsoftware, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D33537?vs=151876
Author: baloghadamsoftware
Date: Fri Jul 13 06:09:40 2018
New Revision: 336997
URL: http://llvm.org/viewvc/llvm-project?rev=336997&view=rev
Log:
[clang-tidy] Exception Escape Checker
Finds functions which may throw an exception directly or indirectly, but they
should not: Destructors, move constr
lebedev.ri updated this revision to Diff 155363.
lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.
Address @vsk review notes, although this will be revered by the next update
dropping the faulty 'stack' optimization.
Repository:
rC Clang
https://reviews.llvm.org/D48958
lebedev.ri marked 5 inline comments as done.
lebedev.ri added a comment.
@vsk so yeah, no wonder that doesn't work.
Somehow in that test case `ScalarExprEmitter::VisitExplicitCastExpr()`
**never** gets called.
(I'm pretty sure this worked with the naive implementation, so worst case i'll
just re
aaron.ballman added inline comments.
Comment at: include/clang/AST/ASTContext.h:1327-1329
+ QualType getDependentVectorType(QualType VectorType, Expr *SizeExpr,
+ SourceLocation AttrLoc,
+ VectorType::Ve
dkrupp marked an inline comment as done.
dkrupp added a comment.
@NoQ do we need any more update to this patch? Thanks.
https://reviews.llvm.org/D48831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336995: [analyzer][UninitializedObjectChecker] Fixed
captured lambda variable name (authored by Szelethus, committed by ).
Author: szelethus
Date: Fri Jul 13 05:54:47 2018
New Revision: 336995
URL: http://llvm.org/viewvc/llvm-project?rev=336995&view=rev
Log:
[analyzer][UninitializedObjectChecker] Fixed captured lambda variable name
Differential Revision: https://reviews.llvm.org/D48291
Modified:
cfe/trunk/lib/St
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks good otherwise, please commit.
https://reviews.llvm.org/D48764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Szelethus updated this revision to Diff 155361.
Szelethus marked an inline comment as done.
Szelethus added a comment.
Thanks! :)
Rebased to https://reviews.llvm.org/rC336994.
https://reviews.llvm.org/D48291
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cx
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Thank you for this!
Repository:
rC Clang
https://reviews.llvm.org/D49275
___
cfe-commits mailing list
cfe-commits@lists.ll
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336994: [analyzer][UninitializedObjectChecker] Support for
MemberPointerTypes (authored by Szelethus, committed by ).
Hera
Author: szelethus
Date: Fri Jul 13 05:21:38 2018
New Revision: 336994
URL: http://llvm.org/viewvc/llvm-project?rev=336994&view=rev
Log:
[analyzer][UninitializedObjectChecker] Support for MemberPointerTypes
Differential Revision: https://reviews.llvm.org/D48325
Modified:
cfe/trunk/lib/StaticA
Szelethus updated this revision to Diff 155356.
Szelethus added a comment.
Thank you! ^-^
Rebased to https://reviews.llvm.org/rC336901.
https://reviews.llvm.org/D48325
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cxx-uninitialized-object-ptr-ref.cpp
Inde
martong added a comment.
> I apologize for the delay in reviewing patches.
There is no need to apologize. On the contrary, we (me and my colleges at
Ericsson) would like to thank you for the effort you had put into reviewing
these patches. This period was hard, we provided so many patches latel
smaksimovic created this revision.
smaksimovic added a reviewer: atanasyan.
Herald added subscribers: arichardson, sdardis.
Patch for the backend part of the problem here: https://reviews.llvm.org/D48374
https://reviews.llvm.org/D49289
Files:
lib/CodeGen/TargetInfo.cpp
Index: lib/CodeGen/Ta
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:662
+def note_suspicious_sizeof_memset_silence : Note<
+ "%select{parenthesize the third argument|cast the second argument to 'int'}0
to silence">;
+
erik.pilkingt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336992: [clang-tidy]
readability-inconsistent-declaration-parameter-name: accept… (authored by
sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.l
Author: sammccall
Date: Fri Jul 13 04:41:56 2018
New Revision: 336992
URL: http://llvm.org/viewvc/llvm-project?rev=336992&view=rev
Log:
[clang-tidy] readability-inconsistent-declaration-parameter-name: accept
approximate name matches.
Summary:
The goal is to reduce false positives when the diffe
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
vsk added a comment.
In https://reviews.llvm.org/D48958#1160494, @lebedev.ri wrote:
> In https://reviews.llvm.org/D48958#1160479, @vsk wrote:
>
> > In https://reviews.llvm.org/D48958#1160435, @lebedev.ri wrote:
> >
> > > Thank you for taking a look!
> > >
> > > In https://reviews.llvm.org/D48958#
lebedev.ri added a comment.
In https://reviews.llvm.org/D48958#1160848, @vsk wrote:
> In https://reviews.llvm.org/D48958#1160494, @lebedev.ri wrote:
>
> > In https://reviews.llvm.org/D48958#1160479, @vsk wrote:
> >
> > > In https://reviews.llvm.org/D48958#1160435, @lebedev.ri wrote:
> > >
> > > >
lebedev.ri added a comment.
In https://reviews.llvm.org/D48958#1160853, @lebedev.ri wrote:
> In https://reviews.llvm.org/D48958#1160848, @vsk wrote:
>
> > <...>
> > The stage2 build traps before it finishes:
> >
> > FAILED: lib/IR/AttributesCompatFunc.inc.tmp
> > cd
> > /Users/vsk/src/build
sammccall updated this revision to Diff 155343.
sammccall added a comment.
Restrict matches to prefix/suffix, not substring.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49285
Files:
clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
clang-tidy/readabili
hokein added inline comments.
Comment at:
clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp:96
+bool nameMatch(StringRef L, StringRef R) {
+ return L.contains_lower(R) || R.contains_lower(L);
+}
I have a concern that this is too general -- it
1 - 100 of 108 matches
Mail list logo
