tzik added a comment.
rsmith: Could you PTAL to this?
Repository:
rC Clang
https://reviews.llvm.org/D46820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tzik created this revision.
tzik added reviewers: majnemer, rnk.
Herald added a subscriber: cfe-commits.
MethodVFTableLocations in MigrosoftVTableContext contains canonicalized
decl. But, it's sometimes asked to lookup for non-canonicalized decl,
and that causes assertion failure, and compilation
bruno updated this revision to Diff 146992.
bruno added a comment.
Update after Jan review.
https://reviews.llvm.org/D46485
Files:
CMakeLists.txt
test/CMakeLists.txt
test/Preprocessor/Inputs/headermap-rel/foo.hmap
test/Preprocessor/Inputs/headermap-rel/foo.hmap.json
test/Preprocessor/
bruno marked an inline comment as done.
bruno added inline comments.
Comment at: utils/hmaptool/hmaptool:55
+# The number of buckets must be a power of two.
+if num_buckets == 0 or (num_buckets & num_buckets - 1) != 0:
+raise SystemExit("er
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
This patch contains the changes and tests for augmented assignments for primary
fixed point types.
s_accum = 7.5hk;
s_accum2 = 2.0hk;
s_accum += s_accum2;
a
yaxunl updated this revision to Diff 146987.
yaxunl edited the summary of this revision.
yaxunl added a comment.
Add optional argument to CreateMemTemp and CreateTempAlloca to get the original
alloca and use it for lifetime intrinsic.
https://reviews.llvm.org/D45900
Files:
lib/CodeGen/CGCall
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
This patch has the implementation and tests for converting between fixed point
and floating point numbers.
The conversion process is simply dividing the fixed point
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
This patch implements the remaining arithmetic and logical operations on the
primary fixed point types.
The operations are `+`, `-`, `*`, `/`, `<<`, and `>>`.
//
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D46881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
stephanemoore created this revision.
Herald added a subscriber: cfe-commits.
The comment incorrectly claims that the listed acronyms are all extracted from
the linked Apple documentation.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46922
Files:
clang-tidy/objc/PropertyDec
rsmith added a comment.
The deprecated enumerator is also referenced by
`tools/c-index-test/c-index-test.c`
This looks fine to me, but let's leave this review thread open for a week or
so, to give people a bit more time to object in case they're using the flag for
something.
===
dexonsmith added a comment.
Did this eventually go in?
Repository:
rC Clang
https://reviews.llvm.org/D40864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Should be fixed in r332425. Apologies for the delay addressing this.
On 15 May 2018 at 18:10, Richard Smith wrote:
> Sorry for the delay, looking now.
>
> On 15 May 2018 at 02:24, Maxim Kuvyrkov wrote:
>
>> Hi Richard,
>>
>> The for-range-examples.cpp test fails on 32-bit arm buildbots, e.g.:
>
Author: rsmith
Date: Tue May 15 18:08:07 2018
New Revision: 332425
URL: http://llvm.org/viewvc/llvm-project?rev=332425&view=rev
Log:
Fix 32-bit buildbots.
Modified:
cfe/trunk/test/SemaCXX/for-range-examples.cpp
Modified: cfe/trunk/test/SemaCXX/for-range-examples.cpp
URL:
http://llvm.org/vie
Sorry for the delay, looking now.
On 15 May 2018 at 02:24, Maxim Kuvyrkov wrote:
> Hi Richard,
>
> The for-range-examples.cpp test fails on 32-bit arm buildbots, e.g.:
> http://lab.llvm.org:8011/builders/clang-cmake-armv7-full/builds/840 .
> Would you please investigate?
>
> You didn't get a not
trixirt updated this revision to Diff 146970.
trixirt added a comment.
Improve comment in CLANG_DEFAULT_OBJCOPY to specify what is required of objcopy.
Remove the llvm- prefix from testing to allow for override of default value.
https://reviews.llvm.org/D46791
Files:
CMakeLists.txt
lib/Driv
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:732
+ const SubRegion *Super) const {
+ const auto Base = BaseSpec.getType()->getAsCXXRecordDecl();
+ return loc::MemRegionVal(
--
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks good, thanks! Yeah, seems that these were accidentally omitted.
You may want to add the `const CXXRecordDecl *` variant as well.
Repository:
rC Clang
https://reviews.llvm.org/D46891
___
Author: george.karpenkov
Date: Tue May 15 17:29:13 2018
New Revision: 332422
URL: http://llvm.org/viewvc/llvm-project?rev=332422&view=rev
Log:
[analyzer] Do not crash on callback for call_once passed by value
https://bugs.llvm.org/show_bug.cgi?id=37312
rdar://40270582
Differential Revision: http
george.karpenkov added a comment.
I see four separate changes: s/.sys/mem one (can be committed without review),
exposing printJSONValues and consequent adding of a lock, adding a constructor
accepting a map, and fixing formatting in `printJSONValue`. All four look good
to me, but probably shou
Author: dyung
Date: Tue May 15 17:27:43 2018
New Revision: 332421
URL: http://llvm.org/viewvc/llvm-project?rev=332421&view=rev
Log:
Revert commits r332160, r332164, r332236.
It was decided this is the wrong approach to fix this issue.
Removed:
cfe/trunk/test/Driver/clang-abi-compat.cpp
Modif
jdenny created this revision.
jdenny added a reviewer: rsmith.
And make it have no effect. Suggested at:
https://reviews.llvm.org/D45463#1096629
I'm not sure of the proper way to deprecate something in libclang.
Let me know if something else is needed.
https://reviews.llvm.org/D46919
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332417: [analyzer] Make plist-html diagnostic consumer
produce multi-file reports. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
Author: dergachev
Date: Tue May 15 17:11:24 2018
New Revision: 332417
URL: http://llvm.org/viewvc/llvm-project?rev=332417&view=rev
Log:
[analyzer] Make plist-html diagnostic consumer produce multi-file reports.
Previously plist-html output produced multi-file HTML reports
but only single-file Pli
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM! with stable-filename option we could even avoid the regexp.
Repository:
rC Clang
https://reviews.llvm.org/D46902
___
vsk created this revision.
vsk added a reviewer: arphaman.
Discard the last uncompleted deferred region in a decl, if one exists.
This prevents lines at the end of a function containing only whitespace
or closing braces from being marked as uncovered, if they follow a
region terminator (return/bre
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr.
leonardchan added a project: clang.
This patch contains logic and tests for different unary and comparison
operations on fixed point types, and casting between integers and fixed point
types.
The operations are `=
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr, jakehehrlich.
leonardchan added a project: clang.
Herald added a subscriber: mgorny.
This diff includes the logic for setting the precision bits for each primary
fixed point type when building clang and logic for in
raj.khem created this revision.
Herald added a subscriber: cfe-commits.
Linux Distros e.g. archlinux have started to use python3 as default python
interpreter, therefore we need to be specific if we need python2
Repository:
rC Clang
https://reviews.llvm.org/D46914
Files:
tools/scan-view/b
leonardchan created this revision.
leonardchan added a project: clang.
This diff includes changes for the remaining _Fract and _Sat fixed point types.
signed short _Fract s_short_fract;
signed _Fract s_fract;
signed long _Fract s_long_fract;
unsigned short _Fract u_short_fract;
unsigned
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good. It might be beneficial to do the lookup twice in this case and then
issue a diagnostic if the results differ, but given how rarely this is
happening, it doesn't really seem worthwh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332414: [libunwind][MIPS] Support MIPS floating-point
registers for hard-float ABIs. (authored by jhb, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
Author: jhb
Date: Tue May 15 15:44:56 2018
New Revision: 332414
URL: http://llvm.org/viewvc/llvm-project?rev=332414&view=rev
Log:
[libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs.
Summary:
For MIPS ABIs with 64-bit floating point registers including newabi
and O32 with
vsapsai added a comment.
Thanks for review.
Repository:
rL LLVM
https://reviews.llvm.org/D45470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vsapsai
Date: Tue May 15 15:38:31 2018
New Revision: 332413
URL: http://llvm.org/viewvc/llvm-project?rev=332413&view=rev
Log:
Emit an error when include after
C11 defines `kill_dependency` as a macro in . When you
include after , the macro clashes with
`std::kill_dependency` and causes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332413: Emit an error when include after
(authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45470?vs
vsapsai updated this revision to Diff 146944.
vsapsai added a comment.
Potentially, VarTemplateDecl is susceptible to the same bug as
ClassTemplateSpecializationDecl. But I wasn't able to trigger it. And based on
code I've convinced myself that the mentioned early exit in
Sema::CheckVarTemplateId
vsapsai added inline comments.
Comment at: clang/lib/Sema/SemaTemplate.cpp:3873-3881
// Find the variable template specialization declaration that
// corresponds to these arguments.
void *InsertPos = nullptr;
if (VarTemplateSpecializationDecl *Spec = Template->findSpe
vsapsai created this revision.
vsapsai added reviewers: rsmith, arphaman.
The added test case was triggering assertion
> Assertion failed:
> (!SpecializedTemplate.is() && "Already set
> to a class template partial specialization!"), function setInstantiationOf,
> file clang/include/clang/AST/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332411: [Attr] Don't print implicit attributes
(authored by jdenny, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46894
Files:
lib/AST/DeclPrinter.cpp
test/Misc/ast-print-record-d
Author: jdenny
Date: Tue May 15 15:16:47 2018
New Revision: 332411
URL: http://llvm.org/viewvc/llvm-project?rev=332411&view=rev
Log:
[Attr] Don't print implicit attributes
Fixes bug reported at:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180514/228390.html
Reviewed by: aaron.ball
aheejin created this revision.
aheejin added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov,
mgorny, klimek.
aheejin edited the summary of this revision.
https://reviews.llvm.org/D46524 (https://reviews.llvm.org/rL332378) introduced
a link f
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Thanks! This looks great now.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1055
+std::tie(StateNullChar, StateNonNullChar) =
+assumeZero(C, State, CharVal
alekseyshl added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:706
// to be dynamic to be sure we export sanitizer interface functions.
- if (AddExportDynamic)
+ if (AddExportDynamic && TC.getTriple().getVendor() != llvm::Triple::Myriad)
CmdArg
jdenny created this revision.
jdenny added reviewers: aaron.ballman, rsmith, hfinkel.
This was discovered at:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180514/228390.html
https://reviews.llvm.org/D46905
Files:
include/clang/Basic/Attr.td
test/SemaCXX/attr-print.cpp
Index:
jdenny abandoned this revision.
jdenny added a comment.
After further thought, this patch doesn't seem worthwhile. Sorry for all the
noise.
https://reviews.llvm.org/D46903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Author: eugenezelenko
Date: Tue May 15 14:45:01 2018
New Revision: 332405
URL: http://llvm.org/viewvc/llvm-project?rev=332405&view=rev
Log:
[Documentation] Fix Release Notes format issues.
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.o
Author: rsmith
Date: Tue May 15 14:27:30 2018
New Revision: 332401
URL: http://llvm.org/viewvc/llvm-project?rev=332401&view=rev
Log:
Don't produce a redundant "auto type is incompatible with C++98" on every
lambda with no explicit return type.
We already warned about the lambda, and we don't hav
Author: d0k
Date: Tue May 15 14:26:47 2018
New Revision: 332400
URL: http://llvm.org/viewvc/llvm-project?rev=332400&view=rev
Log:
Move helper classes into anonymous namespaces. NFCI.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/trunk/lib/Serialization/ASTReaderDecl.cpp
Modifie
efriedma added a comment.
Just a brief comment in the code explaining that would be fine.
Repository:
rC Clang
https://reviews.llvm.org/D46822
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
jdenny added a comment.
I occurs to me now that I could have fixed __single_inheritance by declaring
its argument "fake". However, I still prefer the above solution because (1) it
should help with any other attributes where arguments should have been declared
fake (but no, I haven't identified
Author: ahatanak
Date: Tue May 15 14:00:30 2018
New Revision: 332397
URL: http://llvm.org/viewvc/llvm-project?rev=332397&view=rev
Log:
Address post-commit review comments after r328731. NFC.
- Define a function (canPassInRegisters) that determines whether a
record can be passed in registers based
asb added a comment.
In https://reviews.llvm.org/D46822#1098764, @efriedma wrote:
> Could you include some documentation for how to construct a baremetal
> environment like the one this code expects? It's not clear what exactly you
> expect to be installed where.
Thanks for taking a look Eli
bruno added a comment.
@jkorous, thanks for taking a look. This is an old python script which I
haven't touched before, maybe there were answers to your questions but they are
now lost in time. I'll address the review though and upload a new version.
Repository:
rC Clang
https://reviews.llv
jdenny created this revision.
jdenny added reviewers: aaron.ballman, rsmith, hfinkel.
For example, given:
class __single_inheritance T;
-ast-print -fms-extensions used to print:
class __single_inheritance(1) T;
Clang fails to parse that because the "(1)" is not valid syntax.
This was disc
NoQ added inline comments.
Comment at: test/Analysis/diagnostics/plist-multi-file.c:202
+// CHECK-NEXT:
+// CHECK-NEXT: report-{{([0-9a-f]{6})}}.html
+// CHECK-NEXT:
Yay we have regular expressions.
`()` are needed so that not to confuse `}``}}` with `}}``}
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, baloghadamsoftware.
Plist diagnostics support multi-file reports since forever. HTML diagnostics
support multi-file reports since
https://r
dexonsmith added a reviewer: vsapsai.
dexonsmith added a comment.
In https://reviews.llvm.org/D17741#1067816, @weimingz wrote:
> split the original into two parts. This one supports
> -ffile-macro-prefix-to-remove function.
>
> I locally verified it. To add a test case, do we need to use VFS?
rjmccall added a comment.
In https://reviews.llvm.org/D46489#1099979, @yaxunl wrote:
> In https://reviews.llvm.org/D46489#1088940, @rjmccall wrote:
>
> > I think the right solution here is to make a CompileJobAction with type
> > TY_LLVM_BC in the first place. You should get the advice of a dri
yaxunl added a comment.
In https://reviews.llvm.org/D46489#1088940, @rjmccall wrote:
> I think the right solution here is to make a CompileJobAction with type
> TY_LLVM_BC in the first place. You should get the advice of a driver expert,
> though.
There is already JobAction for TY_LLVM_BC. I
efriedma added a comment.
> I'm concerned about constant folding not taking into account runtime rounding
> mode
Changing the rounding mode is UB without FENV_ACCESS. And with FENV_ACCESS,
__builtin_convertvector should lower to @llvm.experimental.constrained.sitofp
etc., which won't constant
craig.topper added a comment.
Ping @echristo
https://reviews.llvm.org/D46541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332384: Fixed some rtti-options tests. (authored by
ssrivastava, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46836?vs=146632&id=146893#toc
Repository:
rC Clang
https://reviews
Author: ssrivastava
Date: Tue May 15 11:28:42 2018
New Revision: 332384
URL: http://llvm.org/viewvc/llvm-project?rev=332384&view=rev
Log:
Fixed some rtti-options tests.
Certain tests in rtti-options.cpp are not really testing anything because they
are testing for the absence of -frtti option to
Author: kparzysz
Date: Tue May 15 11:15:59 2018
New Revision: 332383
URL: http://llvm.org/viewvc/llvm-project?rev=332383&view=rev
Log:
[Hexagon] Add driver options for subtarget features
Added:
cfe/trunk/test/Driver/hexagon-memops.c
cfe/trunk/test/Driver/hexagon-nvj.c
cfe/trunk/test/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE332382: add AR to acronyms of clang-tidy property check
(authored by Wizard, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46895?vs=146874&id=146886#toc
Repository:
rCTE Clang
Author: wizard
Date: Tue May 15 11:13:51 2018
New Revision: 332382
URL: http://llvm.org/viewvc/llvm-project?rev=332382&view=rev
Log:
add AR to acronyms of clang-tidy property check
Reviewers: hokein, benhamilton
Reviewed By: benhamilton
Subscribers: klimek, cfe-commits
Differential Revision: h
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D46894
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: abataev
Date: Tue May 15 11:01:01 2018
New Revision: 332380
URL: http://llvm.org/viewvc/llvm-project?rev=332380&view=rev
Log:
[OPENMP, NVPTX] Do not globalize variables with reference/pointer types.
In generic data-sharing mode we do not need to globalize
variables/parameters of reference
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332378: [clangd] Extract scoring/ranking logic, and shave
yaks. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46524?
Author: sammccall
Date: Tue May 15 10:43:27 2018
New Revision: 332378
URL: http://llvm.org/viewvc/llvm-project?rev=332378&view=rev
Log:
[clangd] Extract scoring/ranking logic, and shave yaks.
Summary:
Code completion scoring was embedded in CodeComplete.cpp, which is bad:
- awkward to test. The
rsmith added a comment.
In https://reviews.llvm.org/D46845#1099732, @mclow.lists wrote:
> >> One way we could deal with this is by adding an attribute to the compiler
> >> to indicate "the const is a lie", that we can apply to std::pair::first,
> >> with the semantics being that a top-level con
erik.pilkington added a comment.
> I am now thinking about just switching to dot format in
> ParseAvailabilityAttribute() because it's much simpler to maintain
> consistency that way.
Okay, but if we're going to treat underscores as dots while printing
diagnostics and fixits (which I think we
mclow.lists added inline comments.
Comment at: include/charconv:89
+_LIBCPP_BEGIN_NAMESPACE_STD
+
+enum class _LIBCPP_ENUM_VIS chars_format
lichray wrote:
> EricWF wrote:
> > We need to hide these names when `_LIBCPP_STD_VER < 17`, since we're not
> > allowed to
mclow.lists added a comment.
Herald added subscribers: bixia, christof.
What we need to do here is to here is to add a new macro
`_LIBCPP_ABI_REGEX_MEMORY` in `<__config>` (around line 89) and then make these
changes available only when this macro is defined.
By default - we get no change.
If `
rjmccall added a comment.
That would work. I think it would be reasonable for AutoVarEmission to store
that pointer if it makes things easier.
https://reviews.llvm.org/D45900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Hi Hans,
On Tue, May 15, 2018 at 6:23 AM, Hans Wennborg wrote:
> This broke the ast-print-record-decl.c test on Windows, see for
> example http://lab.llvm.org:8011/builders/clang-with-thin-lto-
> windows/builds/9066
>
> One way to reproduce the failure on Linux is to pass a Windows triple
> to t
Wizard created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46895
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
Index: clang-tidy/objc/PropertyDeclarationCheck.cpp
==
jdenny created this revision.
jdenny added reviewers: aaron.ballman, rsmith, hfinkel.
Fixes bug reported at:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180514/228390.html
https://reviews.llvm.org/D46894
Files:
lib/AST/DeclPrinter.cpp
test/Misc/ast-print-record-decl.c
Index
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Sorry this took so long. Please update `test/libcxx/double_include.sh.cpp` and
commit.
Repository:
rCXX libc++
https://reviews.llvm.org/D41347
jkorous planned changes to this revision.
jkorous added a comment.
Sorry for me being dense here - since the output format is determined by input
source code there's more work to do.
I tried to change format of introduced version in couple of tests and the
output mirrors the change. That basica
malaperle added a comment.
In https://reviews.llvm.org/D46751#1099786, @sammccall wrote:
> In https://reviews.llvm.org/D46751#1099633, @malaperle wrote:
>
> > In https://reviews.llvm.org/D46751#1099235, @sammccall wrote:
> >
> > > @malaperle to expand on what Eric said, adding proto hacks with fa
tkrupa created this revision.
Herald added a subscriber: cfe-commits.
tkrupa added reviewers: craig.topper, RKSimon, spatel.
This is the patch that lowers x86 intrinsics to native IR
in order to enable optimizations.
Corresponding LLVM part: https://reviews.llvm.org/D46179
Previous https://revie
sammccall added a comment.
In https://reviews.llvm.org/D46751#1099633, @malaperle wrote:
> In https://reviews.llvm.org/D46751#1099235, @sammccall wrote:
>
> > @malaperle to expand on what Eric said, adding proto hacks with false
> > positives and no way to turn them off is indeed not the way to
Szelethus created this revision.
Szelethus added reviewers: xazax.hun, NoQ.
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet, whisperity.
Herald added a reviewer: george.karpenkov.
Repository:
rC Clang
https://reviews.llvm.org/D46891
Files:
include/clang/StaticAnalyzer/Core
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332371: [clang-tools-extra] Update uses of DEBUG macro to
LLVM_DEBUG. (authored by nzaghen, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
https://reviews.llvm.
Author: nzaghen
Date: Tue May 15 09:37:45 2018
New Revision: 332371
URL: http://llvm.org/viewvc/llvm-project?rev=332371&view=rev
Log:
[clang-tools-extra] Update uses of DEBUG macro to LLVM_DEBUG.
The DEBUG() macro is very generic so it might clash with other projects.
The renaming was done as fol
Author: nico
Date: Tue May 15 09:37:00 2018
New Revision: 332370
URL: http://llvm.org/viewvc/llvm-project?rev=332370&view=rev
Log:
update two comments as suggested on https://reviews.llvm.org/D46843
Modified:
cfe/trunk/tools/clang-fuzzer/CMakeLists.txt
cfe/trunk/tools/clang-fuzzer/proto-t
mclow.lists added a comment.
>> One way we could deal with this is by adding an attribute to the compiler to
>> indicate "the const is a lie", that we can apply to std::pair::first, with
>> the semantics being that a top-level const is ignored when determining the
>> "real" type of the member (
Author: ioeric
Date: Tue May 15 09:22:43 2018
New Revision: 332366
URL: http://llvm.org/viewvc/llvm-project?rev=332366&view=rev
Log:
[clangd] Log error message instead write to errs(). NFC
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp
Modified: clang-tools-extra/trunk/cl
martong updated this revision to Diff 146847.
martong added a comment.
- Remove unrelated CXX14 changes
Repository:
rC Clang
https://reviews.llvm.org/D46835
Files:
lib/AST/DeclBase.cpp
unittests/AST/ASTImporterTest.cpp
unittests/AST/MatchVerifier.h
Index: unittests/AST/MatchVerifier.
martong updated this revision to Diff 146845.
martong marked 4 inline comments as done.
martong added a comment.
- Add test for removeDecl, remove unrelated tests
Repository:
rC Clang
https://reviews.llvm.org/D46835
Files:
lib/AST/DeclBase.cpp
unittests/AST/ASTImporterTest.cpp
unittest
martong added a comment.
Hi Aleksei,
Thanks for reviewing this.
I could synthesize a test which exercises only the `DeclContext::removeDecl`
function. This test causes an assertion without the fix.
Removed the rest of the testcases, which are not strictly connected to this
change.
==
dexonsmith added a comment.
(Somehow I missed Richard's comment when I replied last night, even though it
preceded mine by 5 hours...)
In https://reviews.llvm.org/D46834#1098727, @rsmith wrote:
> This would violate our guidelines for diagnostic messages; see
> https://clang.llvm.org/docs/Inter
Author: ioeric
Date: Tue May 15 08:29:32 2018
New Revision: 332363
URL: http://llvm.org/viewvc/llvm-project?rev=332363&view=rev
Log:
[clangd] Populate #include insertions as additional edits in completion items.
Summary:
o Remove IncludeInsertion LSP command.
o Populate include insertion edits sy
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE332363: [clangd] Populate #include insertions as
additional edits in completion items. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46497?vs=146843&id=146844
malaperle added a comment.
In https://reviews.llvm.org/D46751#1099235, @sammccall wrote:
> @malaperle to expand on what Eric said, adding proto hacks with false
> positives and no way to turn them off is indeed not the way to go here!
> There's probably going to be other places we want to filte
ioeric updated this revision to Diff 146843.
ioeric added a comment.
- Merged with origin/master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdServer.cpp
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Headers.cpp
clangd/Headers.h
cla
This revision was automatically updated to reflect the committed changes.
ioeric marked an inline comment as done.
Closed by commit rL332362: [clangd] Remove LSP command-based #include
insertion. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
Author: ioeric
Date: Tue May 15 08:23:53 2018
New Revision: 332362
URL: http://llvm.org/viewvc/llvm-project?rev=332362&view=rev
Log:
[clangd] Remove LSP command-based #include insertion.
Summary:
clangd will populate #include insertions as addtionalEdits in completion items.
The code completion
1 - 100 of 158 matches
Mail list logo
