[PATCH] D45174: non-zero-length bit-fields should make a class non-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rL331620: Non-zero-length bit-fields make a class non-empty. (authored by rsmith, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45174?vs=14065

r331621 - Remove now-unnecessary check for non-zero nvsize in addition to

Author: rsmith Date: Sun May 6 23:43:31 2018 New Revision: 331621 URL: http://llvm.org/viewvc/llvm-project?rev=331621&view=rev Log: Remove now-unnecessary check for non-zero nvsize in addition to emptyness in MS record layout. Modified: cfe/trunk/lib/AST/RecordLayoutBuilder.cpp Modified: cf

r331620 - Non-zero-length bit-fields make a class non-empty.

Author: rsmith Date: Sun May 6 23:43:30 2018 New Revision: 331620 URL: http://llvm.org/viewvc/llvm-project?rev=331620&view=rev Log: Non-zero-length bit-fields make a class non-empty. This implements the rule intended by the standard (see LWG 2358) and the rule intended by the Itanium C++ ABI (se

[PATCH] D46504: [clang-tidy] Profile is a per-AST (per-TU) data.

Eugene.Zelenko added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:181 std::unique_ptr OptionsProvider) -: DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)), - Profile(nullptr) { +: DiagEngine(nullptr), OptionsProvider(st

[PATCH] D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types

rsmith added inline comments. Comment at: modernize/UseAutoCheck.cpp:40 +? Alpha +: (std::isspace(C) || (!RemoveStars && C == '*')) ? Space + : Punctuation; `isspace` here is wro

[PATCH] D45680: [C++2a] Add operator<=> Rewriting - Early Attempt

EricWF updated this revision to Diff 145419. EricWF added a comment. - Further generalize `CXXRewrittenExpr` and get it working with `TreeTransform.h`. https://reviews.llvm.org/D45680 Files: include/clang/AST/Expr.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h in

[PATCH] D46382: [OpenCL] Factor out language version printing

rivanvx accepted this revision. rivanvx added a comment. This revision is now accepted and ready to land. Nice cleanup. Repository: rC Clang https://reviews.llvm.org/D46382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types

zinovy.nis added inline comments. Comment at: clang-tidy/modernize-use-auto-min-type-name-length.cpp:61-83 +long int li = static_cast(foo()); +// CHECK-FIXES-0-0: auto li = {{.*}} +// CHECK-FIXES-0-5: auto li = {{.*}} +// CHECK-FIXES-1-0: auto li = {{.*}} +//

[PATCH] D46112: Allow _Atomic to be specified on incomplete types

aaron.ballman added inline comments. Comment at: lib/Sema/SemaType.cpp:8022 +else if (LangOpts.CPlusPlus && isCompleteType(Loc, T) && + !T.isTriviallyCopyableType(Context)) // Some other non-trivially-copyable type (probably a C++ class) rs

[PATCH] D46112: Allow _Atomic to be specified on incomplete types

aaron.ballman updated this revision to Diff 145409. aaron.ballman added a comment. Hopefully address the review comments. https://reviews.llvm.org/D46112 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp lib/Sema/SemaType.cpp test/CodeGen/c11atomics.c test/Se

[PATCH] D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types

zinovy.nis added inline comments. Comment at: clang-tidy/modernize-use-auto-min-type-name-length.cpp:61-83 +long int li = static_cast(foo()); +// CHECK-FIXES-0-0: auto li = {{.*}} +// CHECK-FIXES-0-5: auto li = {{.*}} +// CHECK-FIXES-1-0: auto li = {{.*}} +//

[PATCH] D46504: [clang-tidy] Profile is a per-AST (per-TU) data.

lebedev.ri created this revision. lebedev.ri added reviewers: alexfh, sbenza. lebedev.ri added a project: clang-tools-extra. Herald added subscribers: mgrang, xazax.hun, mgorny. As discussed in https://reviews.llvm.org/D45931, currently, profiling output of clang-tidy is somewhat not great. It ou

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

brooks added a reviewer: arichardson. brooks added a comment. Herald added a subscriber: krytarowski. Adding Alex as he made some related changes to CHERI Clang recently https://github.com/CTSRD-CHERI/clang/commit/3a648766deabb4ff7f95862213c3c99e7223363c. https://reviews.llvm.org/D24867

Re: If I want to disable certain attributes, such as"swiftcall", isthere any way to do it now?

On Sun, May 6, 2018 at 10:01 AM, 朴素 <772847...@qq.com> wrote: > hi, Aaron > >Can I ask you some questions?Is there such a demand for me in the > community? Does my code need to be submitted to the community? >Thanks. Generally speaking, the community will accept production-quality patches

?????? If I want to disable certain attributes, such as"swiftcall",isthere any way to do it now?

hi, Aaron Can I ask you some questions?Is there such a demand for me in the community? Does my code need to be submitted to the community? Thanks. -- -- ??: "Aaron Ballman"; : 2018??5??3??(??) 7:40 ??: ""<772847...@qq.c

[PATCH] D45680: [C++2a] Add operator<=> Rewriting - Early Attempt

EricWF updated this revision to Diff 145398. EricWF added a comment. Generalize `CXXRewrittenExpr` to contain only a "representation" of the original expression, and the fully checked rewritten expression. By "representation" i mean to imply that we can't actually build and check a full represe

[PATCH] D46501: OpenCL Header: Guard all half float usage based on cl_khr_fp16 extension

jerryct created this revision. Herald added subscribers: cfe-commits, Anastasia, yaxunl. Hi, this patch guards all missed half float functions based on the availabiltiy of the OpenCL extension cl_khr_fp16. Best regards, Jerry Repository: rC Clang https://reviews.llvm.org/D46501 Files: