I see Alex already got it, but in the future, that kind of trivial test fix
for a failing test is fine to just land, and it is more important to get
the bots healthy. =]
On Fri, Apr 20, 2018, 22:14 Yan Zhang via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> https://reviews.llvm.org/D45912 ne
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
https://reviews.llvm.org/D45912 need someone to accept
Best regards
Yan Zhang
> On Apr 20, 2018, at 19:08, Chandler Carruth wrote:
>
> This has broken most of the build bots. Are you working on a fix or revert?
>
> Might be useful to get on the IRC channel to help coordinate this kind of
> t
This has broken most of the build bots. Are you working on a fix or revert?
Might be useful to get on the IRC channel to help coordinate this kind of
thing.
On Fri, Apr 20, 2018 at 4:45 PM Yan Zhang via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: wizard
> Date: Fri Apr 20 16:18:09
apazos added a comment.
Hi Alex, it seems the table expects these extensions in a canonical order too:
all x extensions, followed by all s extensions, and then all sx extensions.
I can make the change, no problem. I have also coded other error situations
described below.
But f I cannot push a
Wizard created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45912
Files:
test/clang-tidy/readability-identifier-naming-objc.m
Index: test/clang-tidy/readability-identifier-naming-objc.m
==
NoQ added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:145-147
+ if (Name.endswith_lower(".c") || Name.endswith_lower(".cpp") ||
+ Name.endswith_lower(".cc") || Name.endswith_lower(".cxx") ||
+ Name.endswit
NoQ updated this revision to Diff 143416.
NoQ marked an inline comment as done.
NoQ added a comment.
A more accurate extension check.
https://reviews.llvm.org/D45839
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h
lib/StaticAnalyzer/Core/CallEvent.cpp
lib/StaticAn
alexfh added a comment.
A few style-related comments.
Comment at: docs/clang-tidy/index.rst:677
+To check more than one scenario in the same test file use
+``-check-suffix=SUFFIX_NAME`` on ``check_clang_tidy.py`` command line.
+With ``-check-suffix=SUFFIX_NAME`` you need to re
Author: miyuki
Date: Fri Apr 20 10:14:39 2018
New Revision: 330451
URL: http://llvm.org/viewvc/llvm-project?rev=330451&view=rev
Log:
Revert r330442, CodeGen/no-ident-version.c is failing on PPC
Removed:
cfe/trunk/test/CodeGen/no-ident-version.c
Modified:
cfe/trunk/include/clang/Driver/Opt
Author: gbuella
Date: Fri Apr 20 11:44:33 2018
New Revision: 330463
URL: http://llvm.org/viewvc/llvm-project?rev=330463&view=rev
Log:
[X86] WaitPKG intrinsics
Reviewers: craig.topper, zvi
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D45254
Added:
cfe/trunk/lib/
Author: wizard
Date: Fri Apr 20 16:18:09 2018
New Revision: 330492
URL: http://llvm.org/viewvc/llvm-project?rev=330492&view=rev
Log:
[clang-tidy] add new check to find out objc ivars which do not have prefix '_'
Summary:
For code of ivar declaration:
int barWithoutPrefix;
The fix will be:
Author: miyuki
Date: Fri Apr 20 09:29:03 2018
New Revision: 330442
URL: http://llvm.org/viewvc/llvm-project?rev=330442&view=rev
Log:
[CodeGen] Add an option to suppress output of llvm.ident
Summary:
By default Clang outputs its version (including git commit hash, in
case of trunk builds) into obj
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE330492: [clang-tidy] add new check to find out objc ivars
which do not have prefix '_' (authored by Wizard, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45392?vs=142057&id=143408
majnemer added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:145-147
+ if (Name.endswith_lower(".c") || Name.endswith_lower(".cpp") ||
+ Name.endswith_lower(".cc") || Name.endswith_lower(".cxx") ||
+ Name.en
NoQ added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144
+// includes the full path.
+if (SM.getFilename(IL).contains("UnifiedSource")) {
+ StringRef Name = SM.getFilename(SL);
george.karpenkov wro
NoQ updated this revision to Diff 143396.
NoQ marked 3 inline comments as done.
NoQ added a comment.
Address most comments.
https://reviews.llvm.org/D45839
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h
lib/StaticAnalyzer/Core/CallEvent.cpp
lib/StaticAnalyzer/Cor
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Checked this out, seems to be safely ignored for now. The `.plist` format is
pretty resistant to this sort of stuff because most APIs to handle it are
almost treating it as native arrays/dictionarie
zinovy.nis updated this revision to Diff 143384.
zinovy.nis edited the summary of this revision.
zinovy.nis added a comment.
- Minor cosmetic fixes.
https://reviews.llvm.org/D45776
Files:
docs/clang-tidy/index.rst
test/clang-tidy/check_clang_tidy.cpp
test/clang-tidy/check_clang_tidy.py
I
NoQ added a comment.
> The visitor currently checks states appearing as block edges in the exploded
> graph. The first idea was to filter states based on the shape of the exploded
> graph, by checking the number of successors of the parent node, but
> surprisingly, both `succ_size()` and `pred_
sas updated this revision to Diff 143376.
sas added a comment.
Review comments from @alexshap.
Repository:
rC Clang
https://reviews.llvm.org/D45897
Files:
examples/clang-interpreter/CMakeLists.txt
examples/clang-interpreter/Invoke.cpp
examples/clang-interpreter/Invoke.h
examples/clan
sas added inline comments.
Comment at: examples/clang-interpreter/main.cpp:52
+class SimpleJIT {
+private:
+ ExecutionSession ES;
alexshap wrote:
> not needed
Seems cleaner to me to have these explicit, and avoids potentiel code churn if
there are changes above
alexshap added inline comments.
Comment at: examples/clang-interpreter/main.cpp:52
+class SimpleJIT {
+private:
+ ExecutionSession ES;
not needed
Comment at: examples/clang-interpreter/main.cpp:84
+
+ TargetMachine &getTargetMachine() { retur
yaxunl created this revision.
yaxunl added a reviewer: rjmccall.
lifetime.start/end expects pointer argument in alloca address space.
However in C++ a temporary variable is in default address space.
This patch casts the pointer argument of lifetime.start/end to
alloca address space if necessary.
ahatanak created this revision.
ahatanak added reviewers: rsmith, rjmccall.
If an initializer in a braced-init-list is a C++ class that has a non-trivial
destructor, mark the destructor as referenced. This fixes a crash in
CodeGenFunction::destroyCXXObject that occurs when it tries to emit a cal
sas created this revision.
sas added reviewers: ddunbar, lhames.
Herald added a subscriber: mgorny.
This mostly re-uses code from the KaleidoscopeJIT example.
Repository:
rC Clang
https://reviews.llvm.org/D45897
Files:
examples/clang-interpreter/CMakeLists.txt
examples/clang-interpreter/
mgrang added a comment.
Here is a test case which improves with this patch (for RISCV target). It is
able to detect load/store halfword for size 16 bitfields.
struct st {
int a:1;
int b:8;
int c:11;
int d:12;
int e:16;
int f:16;
int g:16;
} S;
void foo(int x)
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330463: [X86] WaitPKG intrinsics (authored by GBuella,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45254?vs=143249&id=143355#toc
Reposito
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D45619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
efriedma added a comment.
> If any of those options we care about wind up being changed, there's a good
> chance we may need to change something on our end anyway, so breaking us is
> actually useful.
I'm not sure I follow. The language options have specific consequences you
could check some
khuttun created this revision.
khuttun added a reviewer: alexfh.
Herald added subscribers: cfe-commits, xazax.hun.
Add support for checking class template member functions.
Also add the following functions to be checked by default:
- std::unique_ptr::release
- std::basic_string::empty
- std::vec
Author: jrose
Date: Fri Apr 20 10:16:04 2018
New Revision: 330452
URL: http://llvm.org/viewvc/llvm-project?rev=330452&view=rev
Log:
Record whether a module came from a private module map
Right now we only use this information in one place, immediately after
we calculate it, but it's still nice in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330447: [CUDA] Set LLVM calling convention for CUDA kernel
(authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45223?vs=14300
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330447: [CUDA] Set LLVM calling convention for CUDA kernel
(authored by yaxunl, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D45223
Files:
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D45873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: yaxunl
Date: Fri Apr 20 10:01:03 2018
New Revision: 330447
URL: http://llvm.org/viewvc/llvm-project?rev=330447&view=rev
Log:
[CUDA] Set LLVM calling convention for CUDA kernel
Some targets need special LLVM calling convention for CUDA kernel.
This patch does that through a TargetCodeGenIn
JDevlieghere added a comment.
In https://reviews.llvm.org/D45255#1073710, @miyuki wrote:
> In https://reviews.llvm.org/D45255#1073703, @JDevlieghere wrote:
>
> > If it were the other way around I’d agree with you, but given that -Qn
> > becomes the default, I think we should not strip it from th
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D45254
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, bkramer, arphaman, aaron.ballman.
Make completion behave consistently no matter if it is run at the
start, in the middle or at the end of an identifier that happens to
be a keyword or a macro name. Since completion is o
miyuki added a comment.
In https://reviews.llvm.org/D45255#1073703, @JDevlieghere wrote:
> If it were the other way around I’d agree with you, but given that -Qn
> becomes the default, I think we should not strip it from the debug info.
No, the default is -Qy
Repository:
rC Clang
https://
svenvh updated this revision to Diff 143330.
svenvh added a comment.
Added a template class test as requested.
https://reviews.llvm.org/D45873
Files:
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Basic/LangOptions.def
lib/Frontend/CompilerInvocation.cpp
lib/Parse/ParseDecl.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330442: [CodeGen] Add an option to suppress output of
llvm.ident (authored by miyuki, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45255
Files:
include/clang/Driver/Options.td
in
JDevlieghere added a comment.
I’m happy with the test, thanks!
In https://reviews.llvm.org/D45255#1072335, @aprantl wrote:
> I'm not sure. Compatibility with GCC and getting identical output for
> debugging purposes seem to be at odds here. I personally lean slightly
> towards stripping it fro
miyuki updated this revision to Diff 143327.
miyuki added a comment.
Updated the test
https://reviews.llvm.org/D45255
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CodeGenModule.cpp
lib/Driver/ToolChains/Clang.
Author: hans
Date: Fri Apr 20 08:33:44 2018
New Revision: 330441
URL: http://llvm.org/viewvc/llvm-project?rev=330441&view=rev
Log:
Fix some tests that were failing on Windows
Modified:
cfe/trunk/test/CodeGen/function-alignment.c
cfe/trunk/test/CodeGenOpenCL/denorms-are-zero.cl
cfe/tru
zahiraam added a comment.
Richard,
Please let me know if I have answered to all the issues you raised. Thanks.
https://reviews.llvm.org/D43576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
zahiraam updated this revision to Diff 143321.
https://reviews.llvm.org/D43576
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Sema/AttributeList.h
include/clang/Sema/Sema.h
lib/AST/Decl.cpp
lib/AST/DeclCXX.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CodeGenMo
zahiraam marked 3 inline comments as done.
zahiraam added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:4937-4938
- return nullptr;
-Diag(UA->getLocation(), diag::err_mismatched_uuid);
-Diag(Range.getBegin(), diag::note_previous_uuid);
-D->dropAttr();
--
yaxunl updated this revision to Diff 143320.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Remove manually added passes from opt and add -mtriple.
https://reviews.llvm.org/D45212
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/c
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:498-501
+OptArgs.push_back(mcpustr);
+OptArgs.push_back("-dce");
+OptArgs.push_back("-sroa");
+OptArgs.push_back("-globaldce");
yaxun
jkorous created this revision.
jkorous added reviewers: vsapsai, arphaman, rsmith.
jkorous added a project: clang.
Herald added a subscriber: cfe-commits.
C++17 [dcl.link]p4:
A linkage specification does not establish a scope.
C++17 [class.union.anon]p2:
Namespace level anonymous unions shall be
yaxunl added inline comments.
Comment at: test/Parser/opencl-cxx-virtual.cl:1
+// RUN: %clang_cc1 %s -triple spir-unknown-unknown -cl-std=c++ -fsyntax-only
-verify
+
can you add a test for template class with virtual member?
Repository:
rC Clang
https://rev
nik added a comment.
In https://reviews.llvm.org/D45815#1073418, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D45815#1072094, @nik wrote:
>
> > @ilya: Using SkipFunctionBodies_AllExceptTemplates for the preamble might
> > be also useful for clangd.
>
>
> Unfortunately, that's also the big
avt77 updated this revision to Diff 143311.
avt77 added a comment.
I fixed issues raised by efriedma.
https://reviews.llvm.org/D45619
Files:
include/clang/Frontend/Utils.h
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CodeGenAction.cpp
lib/Frontend/CMakeLists.txt
lib/Frontend/FrontendTiming
avt77 added inline comments.
Comment at: test/Frontend/ftime-report-template-decl.cpp:2
+// RUN: %clang %s -S -o - -ftime-report 2>&1 | FileCheck %s
+// RUN: %clang %s -S -o - -fdelayed-template-parsing
-DDELAYED_TEMPLATE_PARSING -ftime-report 2>&1 | FileCheck %s
+
---
yaxunl updated this revision to Diff 143307.
yaxunl added a comment.
minor bug fix: do not add CUDA specific link options for HIP.
https://reviews.llvm.org/D45212
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/Options.td
include/cl
Author: hahnfeld
Date: Fri Apr 20 06:26:03 2018
New Revision: 330430
URL: http://llvm.org/viewvc/llvm-project?rev=330430&view=rev
Log:
[docs] Regenerate command line reference
This will correctly sort some manually added entries which should
generally be avoided!
Modified:
cfe/trunk/docs/Cla
Author: hahnfeld
Date: Fri Apr 20 06:25:59 2018
New Revision: 330429
URL: http://llvm.org/viewvc/llvm-project?rev=330429&view=rev
Log:
[OpenMP] Hide -fopenmp-cuda-mode
This is an advanced flag that should show up neither in clang --help
nor in the ClangCommandLineReference.
Modified:
cfe/tru
Author: nico
Date: Fri Apr 20 06:10:44 2018
New Revision: 330427
URL: http://llvm.org/viewvc/llvm-project?rev=330427&view=rev
Log:
clang-cl: Accept (and ignore) /Zc:__cplusplus.
See
https://blogs.msdn.microsoft.com/vcblog/2018/04/09/msvc-now-correctly-reports-__cplusplus/
clang-cl already sets _
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
https://reviews.llvm.org/D45877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
thakis closed this revision.
thakis added a comment.
r330427, thanks!
https://reviews.llvm.org/D45877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis created this revision.
thakis added a reviewer: hans.
thakis edited the summary of this revision.
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
See
https://blogs.msdn.microsoft.com/vcblog/2018/04/09/msvc-now-correctly-re
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330426: [CUDA] Document recent changes (authored by
Hahnfeld, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45449
Files:
docs/ReleaseNotes.rst
include/clang/Driver/Options.td
In
Author: hahnfeld
Date: Fri Apr 20 06:04:45 2018
New Revision: 330425
URL: http://llvm.org/viewvc/llvm-project?rev=330425&view=rev
Log:
[CUDA] Register relocatable GPU binaries
nvcc generates a unique registration function for each object file
that contains relocatable device code. Unique names ar
Author: hahnfeld
Date: Fri Apr 20 06:04:54 2018
New Revision: 330426
URL: http://llvm.org/viewvc/llvm-project?rev=330426&view=rev
Log:
[CUDA] Document recent changes
* Finding installations via ptxas binary
* Relocatable device code
Differential Revision: https://reviews.llvm.org/D45449
Modif
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330425: [CUDA] Register relocatable GPU binaries (authored
by Hahnfeld, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42922
Files:
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/device
yaxunl updated this revision to Diff 143298.
yaxunl edited the summary of this revision.
yaxunl added a comment.
sync to ToT.
https://reviews.llvm.org/D45212
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/Options.td
include/clang/D
Author: fhahn
Date: Fri Apr 20 05:50:10 2018
New Revision: 330422
URL: http://llvm.org/viewvc/llvm-project?rev=330422&view=rev
Log:
[Driver] Support for -save-stats in AddGoldPlugin.
This patch updates AddGoldPlugin to pass stats-file to the Gold plugin,
if -save-stats is passed. It also moves th
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330422: [Driver] Support for -save-stats in AddGoldPlugin.
(authored by fhahn, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45771?vs=143292&id=143299#toc
Repository:
rC Clang
h
Author: adibiagio
Date: Fri Apr 20 02:47:03 2018
New Revision: 330408
URL: http://llvm.org/viewvc/llvm-project?rev=330408&view=rev
Log:
Fix -Wunused-variable warnings after r330377.
Modified:
cfe/trunk/lib/Analysis/ConstructionContext.cpp
Modified: cfe/trunk/lib/Analysis/ConstructionContext.
Author: AlexeySotkin
Date: Fri Apr 20 01:08:04 2018
New Revision: 330404
URL: http://llvm.org/viewvc/llvm-project?rev=330404&view=rev
Log:
[OpenCL] Add 'denorms-are-zero' function attribute
Summary:
Generate attribute 'denorms-are-zero'='true' if '-cl-denorms-are-zero'
compile option was specifie
kosarev added a comment.
Thanks Sjoerd and James. Just added a comment referring to this revision in
https://reviews.llvm.org/rL330420.
Repository:
rL LLVM
https://reviews.llvm.org/D45668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
Author: kosarev
Date: Fri Apr 20 05:09:25 2018
New Revision: 330420
URL: http://llvm.org/viewvc/llvm-project?rev=330420&view=rev
Log:
[NEON] Add a comment explaining the situation with vget_high_f16() and
vget_low_f16() intrinsics
Related differential revision: https://reviews.llvm.org/D45668
M
fhahn updated this revision to Diff 143292.
fhahn marked 2 inline comments as done.
fhahn added a comment.
Thank you very much for the review and the excellent suggestions. I simplified
getStatsFileName, added a doxygen comment and changed the arguments of
AddGoldPlugin as suggested
https://re
ilya-biryukov added a comment.
In https://reviews.llvm.org/D45815#1072094, @nik wrote:
> @ilya: Using SkipFunctionBodies_AllExceptTemplates for the preamble might be
> also useful for clangd.
Unfortunately, that's also the biggest performance win you get when skipping
the function bodies.
I.e
svenvh created this revision.
svenvh added reviewers: yaxunl, bader.
Herald added a subscriber: cfe-commits.
The OpenCL C++ specification doesn't mention restricting virtual inheritance,
so leaving that unaffected for now.
Repository:
rC Clang
https://reviews.llvm.org/D45873
Files:
includ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330418: Parse .h files as objective-c++ if we don't
have a compile command. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org
Author: sammccall
Date: Fri Apr 20 04:35:17 2018
New Revision: 330418
URL: http://llvm.org/viewvc/llvm-project?rev=330418&view=rev
Log:
Parse .h files as objective-c++ if we don't have a compile command.
Summary: This makes C++/objC not totally broken, without hurting C files too
much.
Reviewer
rnkovacs updated this revision to Diff 143287.
rnkovacs edited the summary of this revision.
rnkovacs added a comment.
Fixed logical operator in the
`Z3ConstraintManager::checkRangedStateConstraints()` function.
https://reviews.llvm.org/D45517
Files:
include/clang/StaticAnalyzer/Core/Analyze
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1720
+// Either the record variable or the field has to be const qualified.
+if (RecordVarTy.isConstQualified() || Ty.isConstQualified()) {
+ if (const Expr *Init = VD->getIni
george.karpenkov added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144
+// includes the full path.
+if (SM.getFilename(IL).contains("UnifiedSource")) {
+ StringRef Name = SM.getFilename(SL);
Is this
JonasToth added a comment.
Something came to my mind:
conversion operators. Do they behave as normal overloaded operators? The tests
should reflect both a const conversion and a modifying one.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
JonasToth added a comment.
I like your refactoring very much and i think we have a state that is close to
commit.
My clang-tidy check is already based on top of your functionality, but i can
not work on it this weekend and next week is already busy for me. I decided to
analysis values and refe
klimek updated this revision to Diff 143274.
klimek marked 2 inline comments as done.
klimek added a comment.
Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D45726
Files:
lib/Format/AffectedRangeManager.cpp
lib/Format/AffectedRangeManager.h
lib/Format/Format.cpp
lib/
klimek added a comment.
In https://reviews.llvm.org/D45726#1071925, @krasimir wrote:
> Another point: for the example in the summary about bailing-out early, is
> there a test for this already? If not, we should add one.
Yep, there already is one - I regressed that with my change at first ;)
SimeonEhrig added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:287
+CtorSuffix.append("_");
+CtorSuffix.append(ModuleName);
+ }
tra wrote:
> There is a general problem with this approach. File name can contain the
> characters that PTX does not
ebevhan created this revision.
ebevhan added reviewers: danielmarjamaki, aaron.ballman.
Herald added a subscriber: cfe-commits.
This patch has CheckArrayBounds recurse into
ArraySubscriptExprs and MemberExprs, giving
warnings for invalid indices for every level of
subscript instead of just the top
GBuella updated this revision to Diff 143249.
GBuella retitled this revision from "[X86][WAITPKG] WaitPKG intrinsics" to
"[X86] WaitPKG intrinsics".
https://reviews.llvm.org/D45254
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Ba
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330404: [OpenCL] Add 'denorms-are-zero' function
attribute (authored by AlexeySotkin, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D45808
Files
klimek added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:438
+
+ AlignTokens(Style,
+ [&](const Change &C) {
I'm not sure whether we should use AlignTokens here, given that we pass in a
parameter to basically skip all its interest
SimeonEhrig updated this revision to Diff 143246.
SimeonEhrig added a comment.
Add full context with -U99 to diff.
https://reviews.llvm.org/D44435
Files:
lib/CodeGen/CGCUDANV.cpp
unittests/CodeGen/IncrementalProcessingTest.cpp
Index: unittests/CodeGen/IncrementalProcessingTest.cpp
djasper added inline comments.
Comment at: include/clang/Format/Format.h:154
+ /// \brief If a function call, initializer list, or template
+ /// argument list doesn't fit on a line, allow putting all
writing just "initializer list" is confusing, especially n
HsiangKai updated this revision to Diff 143243.
HsiangKai added a comment.
- Update test cases.
- Checked with clang-format.
Repository:
rC Clang
https://reviews.llvm.org/D45045
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
lib/CodeGen/CGStmt.cpp
test/CodeGen/backend-u
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
95 matches
Mail list logo
