[PATCH] D44189: [RISCV] Verify the input value of -march=

kito-cheng updated this revision to Diff 137970. kito-cheng added a comment. Add test cases for the correct inputs. https://reviews.llvm.org/D44189 Files: lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-arch.c Index: test/Driver/riscv-arch.c =

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked 7 inline comments as done. lichray added a comment. Herald added a subscriber: christof. Pending patch update due to poor network. Comment at: include/charconv:90 + +enum class _LIBCPP_ENUM_VIS chars_format +{ EricWF wrote: > enum types should ha

[PATCH] D44362: [clang] Change std::sort to llvm::sort in response to r327219

mgrang updated this revision to Diff 137966. mgrang added a comment. Fixed indentation. Repository: rC Clang https://reviews.llvm.org/D44362 Files: include/clang/Basic/Attr.td include/clang/Serialization/ContinuousRangeMap.h lib/AST/ASTContext.cpp lib/AST/ItaniumMangle.cpp lib/AST/

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 137964. jdenny added a comment. This commit was reverted by r326862 due to: https://bugs.llvm.org/show_bug.cgi?id=36620 This revision includes a new test case and a fix. While the difference from the last revision is small, it's not trivial, so another revi

[PATCH] D44371: [Driver] Update the comment about incompatible sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rL327249: [Driver] Update the comment about incompatible sanitizers (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44371?v

r327249 - [Driver] Update the comment about incompatible sanitizers

Author: phosek Date: Sun Mar 11 17:23:37 2018 New Revision: 327249 URL: http://llvm.org/viewvc/llvm-project?rev=327249&view=rev Log: [Driver] Update the comment about incompatible sanitizers Differential Revision: https://reviews.llvm.org/D44371 Modified: cfe/trunk/lib/Driver/SanitizerArgs.c

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

Eugene.Zelenko added inline comments. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:47 +const CXXRecordDecl *ThisClass) { + + assert(GrandParent != nullptr); Please remove empty line. Comment at: clang-tidy

[PATCH] D44371: [Driver] Update the comment about incompatible sanitizers

phosek created this revision. phosek added a reviewer: thakis. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D44371 Files: clang/lib/Driver/SanitizerArgs.cpp Index: clang/lib/Driver/SanitizerArgs.cpp ==

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 137953. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 137952. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 137951. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:125 + // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: 'A::virt_1' is a grand-parent's method, not parent's. Did you mean 'BF'? + // CHECK-FI

[PATCH] D40775: [libcxx] Add underscores to win32 locale headers.

halyavin updated this revision to Diff 137945. halyavin added a comment. update to new revision https://reviews.llvm.org/D40775 Files: src/support/win32/locale_win32.cpp Index: src/support/win32/locale_win32.cpp === --- src/supp

[PATCH] D40775: [libcxx] Add underscores to win32 locale headers.

halyavin added a comment. ping. https://reviews.llvm.org/D40775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

khuttun added a comment. Should I close this review? https://reviews.llvm.org/D41655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits