compnerd closed this revision.
compnerd added a comment.
SVN r327105
Repository:
rC Clang
https://reviews.llvm.org/D44278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Thu Mar 8 23:06:42 2018
New Revision: 327105
URL: http://llvm.org/viewvc/llvm-project?rev=327105&view=rev
Log:
CodeGen: simplify and validate exception personalities
Simplify the dispatching for the personality routines. This really had
no test coverage previously, so add
benhamilton added a comment.
Great, I refactored it to avoid parsing the matching parens, so there's no more
danger of O(N^2) parsing behavior.
I had to add a new `InCpp11AttributeSpecifier` boolean to `Context` so when
parsing the inner `[]` we didn't treat it as an ObjC message send or an arr
benhamilton updated this revision to Diff 137696.
benhamilton marked 9 inline comments as done.
benhamilton added a comment.
Refactor to avoid matching open and close parens. Fix @djasper comments.
Repository:
rC Clang
https://reviews.llvm.org/D43902
Files:
lib/Format/ContinuationIndenter.
Author: juliehockett
Date: Thu Mar 8 19:47:18 2018
New Revision: 327103
URL: http://llvm.org/viewvc/llvm-project?rev=327103&view=rev
Log:
Revert "[clang-doc] Setup clang-doc frontend framework"
This reverts commit r327102, since it was breaking the linux-abi-test on
x86.
Removed:
clang-tool
This revision was automatically updated to reflect the committed changes.
juliehockett marked 11 inline comments as done.
Closed by commit rL327102: [clang-doc] Setup clang-doc frontend framework
(authored by juliehockett, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to
Author: juliehockett
Date: Thu Mar 8 19:16:39 2018
New Revision: 327102
URL: http://llvm.org/viewvc/llvm-project?rev=327102&view=rev
Log:
[clang-doc] Setup clang-doc frontend framework
Setting up the mapper part of the frontend framework for a clang-doc
tool. It creates a series of relevant matc
On 03/08/2018 06:03 PM, Richard Smith wrote:
> Might be a good candidate for Clang 6.0.1.
>
Merge request created: https://llvm.org/PR36655
-Tom
> On 8 March 2018 at 18:00, Richard Smith via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
>
> Author: rsmith
> Date: Thu Mar 8
martell added a comment.
Herald added a subscriber: mgrang.
ping @marsupial
https://reviews.llvm.org/D35103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kito-cheng updated this revision to Diff 137687.
kito-cheng added a comment.
This version only update variable name which changed in last version by
accident.
https://reviews.llvm.org/D44189
Files:
lib/Driver/ToolChains/Arch/RISCV.cpp
test/Driver/riscv-arch.c
Index: test/Driver/riscv-arch
Might be a good candidate for Clang 6.0.1.
On 8 March 2018 at 18:00, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Mar 8 18:00:01 2018
> New Revision: 327099
>
> URL: http://llvm.org/viewvc/llvm-project?rev=327099&view=rev
> Log:
> PR36645: Go lo
Author: rsmith
Date: Thu Mar 8 18:00:01 2018
New Revision: 327099
URL: http://llvm.org/viewvc/llvm-project?rev=327099&view=rev
Log:
PR36645: Go looking for an appropriate array bound when constant-evaluating a
name of an array object.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trun
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D44263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327098: [analyzer] MmapWriteExecChecker: Add support for
mprotect(). (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4
Author: dergachev
Date: Thu Mar 8 17:47:24 2018
New Revision: 327098
URL: http://llvm.org/viewvc/llvm-project?rev=327098&view=rev
Log:
[analyzer] MmapWriteExecChecker: Add support for mprotect().
mprotect() allows setting memory access flags similarly to mmap(),
causing similar security issues i
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327096: [CFG] [analyzer] Add construction context for
implicit constructor conversions. (authored by dergachev, committed
Author: dergachev
Date: Thu Mar 8 17:39:59 2018
New Revision: 327096
URL: http://llvm.org/viewvc/llvm-project?rev=327096&view=rev
Log:
[CFG] [analyzer] Add construction context for implicit constructor conversions.
Implicit constructor conversions such as A a = B() are represented by
surrounding
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks! This is nicer.
Repository:
rC Clang
https://reviews.llvm.org/D44278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
az added inline comments.
Comment at: include/clang/Basic/arm_neon.td:1504
+ // Scalar floating point multiply extended (scalar, by element)
+ def SCALAR_FMULX_LANEH : IOpInst<"vmulx_lane", "ssdi", "Sh",
OP_SCALAR_MUL_LN>;
+ def SCALAR_FMULX_LANEQH : IOpInst<"vmulx_laneq", "s
NoQ edited reviewers, added: NoQ; removed: dergachev.a.
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
Repository:
rC Clang
https://reviews.llvm.org/D44250
___
cfe-commits
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
https://reviews.llvm.org/D43791 wasn't quite enough because we often run out of
inlining stack depth limit and for that reason fail to see th
NoQ updated this revision to Diff 137675.
NoQ added a comment.
Add the tests to a CFG-oriented test file as well, because it doesn't have much
to do with the analyzer.
FIXME: `temp-obj-dtors-cfg-output.cpp` is a mess. It'd be great to interleave
code and expected output, like other CFG tests do
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
There's a few places where we can trim some of the boilerplate, which I think
is important - it's hard to find the "real code" among all the plumbing in
places.
Other than that, this see
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327090: [DOXYGEN] Fix doxygen and content issues in
mmintrin.h (authored by dyung, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41517?vs=13
Author: dyung
Date: Thu Mar 8 16:38:51 2018
New Revision: 327090
URL: http://llvm.org/viewvc/llvm-project?rev=327090&view=rev
Log:
[DOXYGEN] Fix doxygen and content issues in mmintrin.h
- Fix instruction mappings/listings for various intrinsics
This patch was made by Craig Flores
Differential
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Nice.. Removed a lot of complexity :). Let's see whether this heuristic is good
enough.
Comment at: lib/Format/TokenAnnotator.cpp:210
-bool MightBeFunctionType = !Co
rsmith added inline comments.
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1790
+// set fake one.
+D->DefinitionData = DD;
ReadCXXDefinitionData(*DD, D);
I think it would make sense to "claim" the definition more eagerly here, by
also updatin
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:329
+ return nullptr;
+// C++17 '[[using namespace: foo, bar(baz, blech)]]'
+bool IsUsingNamespace =
Can you make this:
// C++17 '[[using : foo, bar(baz, blech)]]'
To make
compnerd updated this revision to Diff 137668.
compnerd added a comment.
add more context
Repository:
rC Clang
https://reviews.llvm.org/D44278
Files:
lib/CodeGen/CGException.cpp
test/CodeGen/personality.c
test/CodeGenCXX/personality.cpp
test/CodeGenObjC/personality.m
test/CodeGenOb
compnerd created this revision.
compnerd added reviewers: rnk, smeenai.
Simplify the dispatching for the personality routines. This really had
no test coverage previously, so add test coverage for the various cases.
This turns out to be pretty complicated as the various languages and
models inter
NoQ updated this revision to Diff 137661.
NoQ added a comment.
Same goes for rvalue references. Hmm, we have a fancy helper method for that
exact purpose. But it's not super easy to use, had to sacrifice a sanity check
assertion to use it.
https://reviews.llvm.org/D44273
Files:
include/clan
NoQ updated this revision to Diff 137662.
NoQ added a comment.
Fix typo in the comments.
https://reviews.llvm.org/D44273
Files:
include/clang/Analysis/CFG.h
lib/Analysis/CFG.cpp
test/Analysis/temporaries.cpp
Index: test/Analysis/temporaries.cpp
==
Author: adrian
Date: Thu Mar 8 15:11:46 2018
New Revision: 327078
URL: http://llvm.org/viewvc/llvm-project?rev=327078&view=rev
Log:
Add a debug info testcase for the trvial_abi attribute.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-composite-cc.cpp
Modified: cfe/trunk/test/CodeGenCXX/deb
Author: jvesely
Date: Thu Mar 8 15:01:01 2018
New Revision: 327076
URL: http://llvm.org/viewvc/llvm-project?rev=327076&view=rev
Log:
amdgcn/fmax: fcanonicalize operands
v_max instruction needs canonicalized operands.
Passes CTS on carrizo
Reviewer: Aaron Watry
Signed-off-by: Jan Vesely
Added
Author: jvesely
Date: Thu Mar 8 15:00:58 2018
New Revision: 327075
URL: http://llvm.org/viewvc/llvm-project?rev=327075&view=rev
Log:
amdgcn/fmin: fcanonicalize operands
v_min instruction needs canonicalized operands.
Passes CTS on carrizo
Reviewer: Aaron Watry
Signed-off-by: Jan Vesely
Added
Author: eugenezelenko
Date: Thu Mar 8 14:45:13 2018
New Revision: 327074
URL: http://llvm.org/viewvc/llvm-project?rev=327074&view=rev
Log:
[StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use
warnings; other minor fixes (NFC).
Modified:
cfe/trunk/include/clang/StaticAnal
pfultz2 added a comment.
> If the return type of foo() is changed, then the use for s1 will be
> automatically updated
But usually you write it as:
using foo_return = uint16_t;
foo_return foo();
...
size_t s1 = sizeof(foo());
size_t s2 = sizeof(foo_return);
So you just update the `fo
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
The type of the call expression and the return value type of the function are
not necessarily the same thing. In the attached example, the fu
aaron.ballman added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:1231
+ Types[getContext().VoidPtrTy] = "%p";
+ Types[getContext().FloatTy] = "%f";
+ Types[getContext().DoubleTy] = "%f";
paulsemel wrote:
> aaron.ballman wrote:
> > paulsem
simark created this revision.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov,
mgorny, klimek.
simark added a reviewer: malaperle.
This patch adds support for incremental document syncing, as described
in the LSP spec. The protocol specifies ranges in terms of Positio
vsk added a comment.
Thanks @tvanslyke and @mclow.lists, landed as r327064.
Repository:
rCXX libc++
https://reviews.llvm.org/D41976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX327064: Low-hanging fruit optimization in
string::__move_assign(). (authored by vedantk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41976?vs=130819&id=137647#toc
Repository:
Author: vedantk
Date: Thu Mar 8 13:15:26 2018
New Revision: 327064
URL: http://llvm.org/viewvc/llvm-project?rev=327064&view=rev
Log:
Low-hanging fruit optimization in string::__move_assign().
shrink_to_fit() ends up doing a lot work to get information that we
already know since we just called cl
jbcoe updated this revision to Diff 137646.
https://reviews.llvm.org/D44217
Files:
clang-tools-extra/clang-tidy/add_new_check.py
Index: clang-tools-extra/clang-tidy/add_new_check.py
===
--- clang-tools-extra/clang-tidy/add_new_che
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM - thanks
https://reviews.llvm.org/D41517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
mstorsjo added a comment.
Ping @rnk - let me reiterate the questions that are open:
In https://reviews.llvm.org/D43184#1009355, @rnk wrote:
> Here's a case where a local vtable would help:
>
> struct __declspec(dllimport) A { virtual void a(); };
> struct __declspec(dllimport) B { virtual vo
malaperle added a comment.
In https://reviews.llvm.org/D44247#1031429, @sammccall wrote:
> In https://reviews.llvm.org/D44247#1031366, @sammccall wrote:
>
> > In https://reviews.llvm.org/D44247#1031345, @malaperle wrote:
> >
> > > I was going to change the symbol index to do the opposite :) The r
NoQ added a comment.
In https://reviews.llvm.org/D16403#1031567, @thakis wrote:
> Since this affects analysis-based warnings, have you checked if this patch
> has any effect on compile times?
Just in case - this is under an analyzer-only flag, so the actual warnings are
not affected. I guess
mclow.lists added a comment.
In https://reviews.llvm.org/D41976#1031674, @vsk wrote:
> @mclow.lists is this still fine to commit? I can land it and watch the bots,
> if you'd like.
Sure. Please do so.
https://reviews.llvm.org/D41976
___
cfe-comm
Author: jvesely
Date: Thu Mar 8 10:58:07 2018
New Revision: 327044
URL: http://llvm.org/viewvc/llvm-project?rev=327044&view=rev
Log:
amdgcn,popcount: Workaround broken llvm.ctpop intrinsic on some GCN ASICs
This is only really needed for VI+ ASICs. However, llvm would cast the value to
i32 for o
Author: jvesely
Date: Thu Mar 8 10:58:05 2018
New Revision: 327043
URL: http://llvm.org/viewvc/llvm-project?rev=327043&view=rev
Log:
integer/gentype: Add __CLC_VECSIZE macro
Reviewer: Aaron Watry
Signed-off-by: Jan Vesely
Modified:
libclc/trunk/generic/include/clc/integer/gentype.inc
Mod
Author: jvesely
Date: Thu Mar 8 10:58:00 2018
New Revision: 327042
URL: http://llvm.org/viewvc/llvm-project?rev=327042&view=rev
Log:
popcount: Provide function implementation rather than intrinsic redirect
amdgcn will need to override this
Reviewer: Aaron Watry
Signed-off-by: Jan Vesely
Adde
vsk added a comment.
Herald added a subscriber: christof.
@mclow.lists is this still fine to commit? I can land it and watch the bots, if
you'd like.
https://reviews.llvm.org/D41976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
mclow.lists created this revision.
mclow.lists added reviewers: EricWF, dexonsmith.
https://cplusplus.github.io/LWG/issue2221
This is straightforward; I'm putting it up for review because it will add
symbols to the dylib
https://reviews.llvm.org/D44263
Files:
include/ostream
test/std/inp
aaron.ballman added a comment.
In https://reviews.llvm.org/D44231#1031503, @pfultz2 wrote:
> > Can you point to some real world code that would benefit from this check?
>
> Yes, here:
>
> https://github.com/ROCmSoftwarePlatform/MIOpen/blob/master/src/convolution.cpp#L184
>
> It is erroneously cal
craig.topper added a comment.
I'm happy.
https://reviews.llvm.org/D41517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev accepted this revision.
ABataev added a comment.
LG
Repository:
rC Clang
https://reviews.llvm.org/D43660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gtbercea updated this revision to Diff 137600.
gtbercea added a comment.
Patch splitting: limit support in this patch to standalone target regions only.
Support for combined directives will be fully covered in a subsequent patch.
Repository:
rC Clang
https://reviews.llvm.org/D43660
Files:
lebedev.ri added a comment.
In https://reviews.llvm.org/D36836#1021863, @chandlerc wrote:
> In https://reviews.llvm.org/D36836#931995, @lebedev.ri wrote:
>
> > - Rebased
> > - As advised by @aaron.ballman, moved into it's own directory/module.
> > Please review that, i'm not entirely sure i have
thakis added a comment.
Since this affects analysis-based warnings, have you checked if this patch has
any effect on compile times?
Repository:
rL LLVM
https://reviews.llvm.org/D16403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
ilya-biryukov updated this revision to Diff 137589.
ilya-biryukov marked 9 inline comments as done.
ilya-biryukov added a comment.
This is not final, there are still unadressed comments.
- Significantly simplified the implementation by removing the DiagList, etc.
- Addressed some of the rest of t
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:329
+ {"title",
+ llvm::formatv("Apply FixIt {0}", GetFixitMessage(D.message))},
{"command", ExecuteCommandParams::CLANGD_APPLY_FIX_COMMAND},
sammccall wrote
RKSimon added a comment.
Any more comments?
https://reviews.llvm.org/D41517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ormris abandoned this revision.
ormris added a comment.
@echristo accepted this revision via cfe-commits. As it's now commited, I'm
abandoning this revision.
Repository:
rC Clang
https://reviews.llvm.org/D44218
___
cfe-commits mailing list
cfe-c
pfultz2 added a comment.
> Can you point to some real world code that would benefit from this check?
Yes, here:
https://github.com/ROCmSoftwarePlatform/MIOpen/blob/master/src/convolution.cpp#L184
It is erroneously calling `sizeof(yDesc.GetType())`. The `GetType` function
returns an enum that r
tbourvon updated this revision to Diff 137588.
tbourvon added a comment.
Moves the custom matcher to the check instead of having it in `utils/Matchers.h`
https://reviews.llvm.org/D37014
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tid
simark marked 2 inline comments as done.
simark added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:79
+static llvm::cl::opt Verbose("verbose", llvm::cl::desc("Be more
verbose"),
+ llvm::cl::init(false));
ilya-biryuk
simark updated this revision to Diff 137582.
simark added a comment.
Update
- Add vlog method to Logger interface
- Add method name to "method not found" error message
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44226
Files:
clangd/ClangdLSPServer.cpp
clangd/JSONRPCDisp
ilya-biryukov added inline comments.
Comment at: clangd/Logger.cpp:19
Logger *L = nullptr;
+bool Verbose_ = false;
} // namespace
simark wrote:
> ilya-biryukov wrote:
> > Could we move the flag to implementation of `Logger`?
> > I.e.:
> > ```
> > class Logger {
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE327023: [clangd] Early return for #include goto
definition. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44251?vs=137559&id=137581#toc
Repository:
rCTE Cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327023: [clangd] Early return for #include goto definition.
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44251
Files:
c
Author: hokein
Date: Thu Mar 8 08:28:12 2018
New Revision: 327023
URL: http://llvm.org/viewvc/llvm-project?rev=327023&view=rev
Log:
[clangd] Early return for #include goto definition.
Summary: This would save cost of walking over the AST, NFC.
Reviewers: ilya-biryukov
Subscribers: klimek, jkor
simark added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:79
+static llvm::cl::opt Verbose("verbose", llvm::cl::desc("Be more
verbose"),
+ llvm::cl::init(false));
ilya-biryukov wrote:
> Maybe just call it `-v`?
I wo
simark marked an inline comment as done.
simark added inline comments.
Comment at: clangd/Logger.cpp:19
Logger *L = nullptr;
+bool Verbose_ = false;
} // namespace
ilya-biryukov wrote:
> Could we move the flag to implementation of `Logger`?
> I.e.:
> ```
> clas
paulsemel updated this revision to Diff 137578.
paulsemel marked 3 inline comments as done.
paulsemel added a comment.
Applied Aaron suggestions
Repository:
rC Clang
https://reviews.llvm.org/D44093
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecking.
sammccall added a comment.
In https://reviews.llvm.org/D44247#1031366, @sammccall wrote:
> In https://reviews.llvm.org/D44247#1031345, @malaperle wrote:
>
> > I was going to change the symbol index to do the opposite :) The range of
> > definitions including the bodies of functions, etc is used
petarj added a comment.
Is everyone OK with the patch now?
https://reviews.llvm.org/D39053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Thu Mar 8 08:14:11 2018
New Revision: 327019
URL: http://llvm.org/viewvc/llvm-project?rev=327019&view=rev
Log:
[clangd] Bump vscode extension version to 0.0.5
Modified:
clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json
Modified: clang-tools-extra/trunk/c
paulsemel marked 12 inline comments as done.
paulsemel added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:1231
+ Types[getContext().VoidPtrTy] = "%p";
+ Types[getContext().FloatTy] = "%f";
+ Types[getContext().DoubleTy] = "%f";
aaron.ball
ilya-biryukov added inline comments.
Comment at: clangd/Logger.cpp:19
Logger *L = nullptr;
+bool Verbose_ = false;
} // namespace
Could we move the flag to implementation of `Logger`?
I.e.:
```
class Logger {
virtual log(const llvm::Twine &Message, bool Verbo
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:536-542
+ StringRef CompilerPath = env;
+ while (!CompilerPath.empty()) {
+std::pair Split =
+CompilerPath.split(llvm::sys::EnvPathSeparator);
+LibraryPaths.push_back(
hokein added a comment.
In https://reviews.llvm.org/D44251#1031373, @ilya-biryukov wrote:
> Sorry, being pedantic here... We're not saving time on parsing, but on
> walking over the AST :-)
Yeah, rephased it.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44251
__
aaron.ballman added a comment.
In https://reviews.llvm.org/D44231#1031380, @pfultz2 wrote:
> > Can you elaborate a bit more about this?
>
> This catches problems when calling `sizeof(f())` when `f` returns an
> integer(or enum). This is because, most likely, the integer represents the
> type to
simark added a comment.
Now, if the client calls a method that we do not support (), clangd just
outputs:
C/C++: [10:55:16.033] Error -32601: method not found
It would be useful to at least print in this error message the name of the
method. Because the "unknown method" handler shares the t
simark updated this revision to Diff 137573.
simark added a comment.
Update
- Change switch to -verbose
- Add vlog function, do the filtering there
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44226
Files:
clangd/JSONRPCDispatcher.cpp
clangd/Logger.cpp
clangd/Logger.h
aaron.ballman added a comment.
In https://reviews.llvm.org/D42624#1031073, @sylvestre.ledru wrote:
> @aaron.ballman Hello, Do you think it is ready to land? Thanks
@alexfh was asking to make this matcher local to the check rather than add it
to Matchers.h, so I think this patch should be aband
pfultz2 added a comment.
> How does this differ from misc-unused-raii?
Actually, I was unaware of this check. This seems like a better place to start.
Whats missing from the misc-unused-raii is that it doesn't catch it when
constructing with curly braces(ie `NonTrivial{}`). Let me work on updat
pfultz2 added a comment.
> Can you elaborate a bit more about this?
This catches problems when calling `sizeof(f())` when `f` returns an integer(or
enum). This is because, most likely, the integer represents the type to be
chosen, however, `sizeof` is being computed for an integer and not the t
malaperle added a comment.
In https://reviews.llvm.org/D44251#1031370, @ilya-biryukov wrote:
> LGTM.
> I think this was part of initial changed and I asked to make it this way,
> but I don't remember why.
I think it was just to have a single place that returns. I think it's OK to
early retur
ilya-biryukov added a comment.
Sorry, being pedantic here... We're not saving time on parsing, but on walking
over the AST :-)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44251
___
cfe-commits mailing list
cfe-commits@lists.llvm
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
I think this was part of initial changed and I asked to make it this way, but I
don't remember why.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44251
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327009: [clangd:vscode] Resolve symlinks for file paths from
clangd. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44158
F
sammccall added a comment.
In https://reviews.llvm.org/D44247#1031345, @malaperle wrote:
> I was going to change the symbol index to do the opposite :) The range of
> definitions including the bodies of functions, etc is used in a "peek
> definition" feature by several LSP clients. So for examp
Author: ioeric
Date: Thu Mar 8 07:28:42 2018
New Revision: 327009
URL: http://llvm.org/viewvc/llvm-project?rev=327009&view=rev
Log:
[clangd:vscode] Resolve symlinks for file paths from clangd.
Summary:
For features like go-to-definition, clangd can point clients to symlink paths
(e.g. in bazel e
sammccall added inline comments.
Comment at: clangd/SourceCode.cpp:55
+ const auto& SM = D->getASTContext().getSourceManager();
+ SourceLocation SpellingLoc = SM.getSpellingLoc(D->getLocation());
+ if (D->getLocation().isMacroID()) {
As discussed offline, this
Author: abataev
Date: Thu Mar 8 07:24:08 2018
New Revision: 327008
URL: http://llvm.org/viewvc/llvm-project?rev=327008&view=rev
Log:
[OPENMP] Emit sizes/init ptrs etc. data for task reductions before
using.
We may emit the code in wrong order because of incorrect implementation
of the runtime fu
malaperle added a comment.
I was going to change the symbol index to do the opposite :) The range of
definitions including the bodies of functions, etc is used in a "peek
definition" feature by several LSP clients. So for example in VSCode, you can
hold Ctrl and hover on a function call and see
Author: marshall
Date: Thu Mar 8 07:01:50 2018
New Revision: 327005
URL: http://llvm.org/viewvc/llvm-project?rev=327005&view=rev
Log:
Implement LWG#2518 - Non-member swap for propagate_const should call member swap
Modified:
libcxx/trunk/include/experimental/propagate_const
libcxx/trunk/
ioeric added inline comments.
Comment at: clangd/clients/clangd-vscode/src/extension.ts:3
import * as vscodelc from 'vscode-languageclient';
+import { realpathSync } from 'fs';
sammccall wrote:
> nit: the braces don't do anything here, right?
I'm not sure... t
ioeric updated this revision to Diff 137564.
ioeric marked an inline comment as done.
ioeric added a comment.
- add context about the workaround.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44158
Files:
clangd/clients/clangd-vscode/src/extension.ts
Index: clangd/clients/
1 - 100 of 125 matches
Mail list logo
