oren_ben_simhon updated this revision to Diff 136235.
oren_ben_simhon added a comment.
Implemented commented posted by Aaron (Thanks)
Repository:
rL LLVM
https://reviews.llvm.org/D41880
Files:
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
includ
smeenai added a comment.
Any updates here? We were hitting a similar error internally, which this patch
fixed.
https://reviews.llvm.org/D39562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326307: [ObjC] Allow declaring __strong pointer fields in
structs in Objective-C (authored by ahatanak, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
CodaFi added a comment.
> Can you explain the new algorithm for checking recursive calls?
The idea is to de-clutter as much of the existing algorithm as possible. The
state dictionary is done away with now in favor of just not enqueueing
successors of CFG blocks that have recursive calls. Giv
rtrieu added inline comments.
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:255-257
// If the exit block is unreachable, skip processing the function.
if (cfg->getExit().pred_empty())
return;
This is likely what is causing my previous code example to
rtrieu added a comment.
Can you explain the new algorithm for checking recursive calls?
From the test, this code looks like what you are testing for, but it doesn't
trigger the warning.
void f() {
while(true) {
f();
}
}
https://reviews.llvm.org/D43737
___
rtrieu added a comment.
> I have one very minor nit that I don't know how to fix:
>
> warn-return-std-move.cpp:220:12: warning: local variable 'd' will be copied
> despite being returned by name [-Wreturn-std-move]
> return (d); // e17
> ^
> warn-return-std-move.
dyung marked an inline comment as done.
dyung added inline comments.
Comment at: lib/Headers/mmintrin.h:55
///
-/// This intrinsic corresponds to the VMOVD / MOVD instruction.
+/// This intrinsic corresponds to the MOVD instruction.
///
efriedma wrote:
> RK
dyung updated this revision to Diff 136221.
dyung added a comment.
Updated documentation for instruction generated for _mm_cvtsi32_si64,
_mm_cvtsi64_si32, _mm_cvtsi64_m64 and _mm_cvtm64_si64 based on feedback.
https://reviews.llvm.org/D41517
Files:
lib/Headers/mmintrin.h
Index: lib/Headers
Author: rsmith
Date: Tue Feb 27 19:02:07 2018
New Revision: 326298
URL: http://llvm.org/viewvc/llvm-project?rev=326298&view=rev
Log:
Update cxx_status to mark "SVN" items as "Clang 6" instead.
Modified:
cfe/trunk/www/cxx_status.html
cfe/trunk/www/make_cxx_dr_status
Modified: cfe/trunk/ww
Author: rsmith
Date: Tue Feb 27 19:02:23 2018
New Revision: 326299
URL: http://llvm.org/viewvc/llvm-project?rev=326299&view=rev
Log:
Fix a couple of cases where we would fail to correctly parse deduced class
template specialization types.
Specifically, we would not properly parse these types wit
carlo.bertolli created this revision.
carlo.bertolli added a reviewer: ABataev.
Herald added subscribers: guansong, jholewinski.
This patch extends the SPMD implementation to all target constructs and guards
this implementation under a new flag.
Repository:
rC Clang
https://reviews.llvm.org/
Eugene.Zelenko added a comment.
std::basic_string::starts_with() was suggested for C++20. May be will be good
idea to generalize code to create absl and modernize checks?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43847
___
cfe
Eugene.Zelenko added a comment.
Please add new module in docs/clang-tidy/index.rst and mention it in release
notes.
Comment at: clang-tidy/absl/AbslTidyModule.cpp:14
+#include "StringFindStartswithCheck.h"
+using namespace clang::ast_matchers;
+
Please separat
Author: george.karpenkov
Date: Tue Feb 27 17:55:23 2018
New Revision: 326295
URL: http://llvm.org/viewvc/llvm-project?rev=326295&view=rev
Log:
[analyzer] [tests] Write to logfile instead of stdout while updating
reference results
Modified:
cfe/trunk/utils/analyzer/SATestUpdateDiffs.py
Modif
niko created this revision.
niko added reviewers: ioeric, hokein.
Herald added subscribers: cfe-commits, mgorny.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43847
Files:
clang-tidy/CMakeLists.txt
clang-tidy/absl/AbslTidyModule.cpp
clang-tidy/absl/CMakeLists.txt
clang-t
Author: eugenezelenko
Date: Tue Feb 27 17:10:04 2018
New Revision: 326292
URL: http://llvm.org/viewvc/llvm-project?rev=326292&view=rev
Log:
[StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use
warnings; other minor fixes (NFC).
Modified:
cfe/trunk/include/clang/StaticAnaly
Hello everyone,
Below are some buildbot numbers for the last week of 2/18/2018 - 2/24/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
Hello everyone,
Below are some buildbot numbers for the week of 2/11/2018 - 2/17/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to r
Hello everyone,
Below are some buildbot numbers for the week of 2/04/2018 - 2/10/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to r
compnerd created this revision.
compnerd added reviewers: rjmccall, rnk.
objc_msgSend_stret takes a hidden parameter for the returned structure's
address for the construction. When the function signature is rewritten
for the inalloca passing, the return type is no longer marked as
indirect but ra
Author: kzhuravl
Date: Tue Feb 27 16:27:00 2018
New Revision: 326278
URL: http://llvm.org/viewvc/llvm-project?rev=326278&view=rev
Log:
AMDGPU: Move run and check lines around to match processor order in AMDGPU.h
Modified:
cfe/trunk/test/Driver/amdgpu-mcpu.cl
Modified: cfe/trunk/test/Driver/a
ahatanak created this revision.
ahatanak added a reviewer: rjmccall.
This patch adds a command line option (-fdisable-tail-calls-esca
ping-blocks) that annotates escaping block invoke functions with attribute
"disable-tail-calls". This is an option that helps users in debugging their
code who sp
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
While landing https://reviews.llvm.org/D43428 as
https://reviews.llvm.org/rC325966, i caused an internal compiler error of an
MSVC 2015 comp
ahatanak abandoned this revision.
ahatanak added a comment.
I'm going to send this patch again so that people can read the summary.
https://reviews.llvm.org/D43839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
ahatanak added a subscriber: cfe-commits.
ahatanak added a comment.
Add cfe-commits to subscribers.
https://reviews.llvm.org/D43839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rafael
Date: Tue Feb 27 16:14:18 2018
New Revision: 326272
URL: http://llvm.org/viewvc/llvm-project?rev=326272&view=rev
Log:
Inline trivial function. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGVTables.cpp
Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp
URL:
http://llvm.org/viewvc/llvm-pro
Author: rafael
Date: Tue Feb 27 16:06:01 2018
New Revision: 326270
URL: http://llvm.org/viewvc/llvm-project?rev=326270&view=rev
Log:
Pass a GlobalDecl to setAliasAttributes. NFC.
This just makes a followup change easier to read.
Modified:
cfe/trunk/lib/CodeGen/CGCXX.cpp
cfe/trunk/lib/Cod
aaron.ballman closed this revision.
aaron.ballman added a comment.
Committed in r326266.
https://reviews.llvm.org/D43748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Tue Feb 27 15:49:28 2018
New Revision: 326266
URL: http://llvm.org/viewvc/llvm-project?rev=326266&view=rev
Log:
Improve the way attribute argument printing happens for omitted optional
arguments when pretty printing.
Patch by Joel Denny.
Added:
cfe/trunk/test/Sema
Author: rafael
Date: Tue Feb 27 15:44:36 2018
New Revision: 326265
URL: http://llvm.org/viewvc/llvm-project?rev=326265&view=rev
Log:
Pass a GlobalDecl to setFunctionDefinitionAttributes. NFC.
This just makes a followup patch easier to read.
Modified:
cfe/trunk/lib/CodeGen/CGCXX.cpp
cfe/t
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D43815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
craig.topper added inline comments.
Comment at: lib/Headers/cetintrin.h:44
+
+static __inline__ void __DEFAULT_FN_ATTRS _inc_ssp(unsigned int __a) {
+ __builtin_ia32_incsspq(__a);
Start a new #ifdef __x86_64__ here that is just for your new intrinsics. That
way
bsdjhb updated this revision to Diff 136164.
bsdjhb added a comment.
Herald added a subscriber: christof.
- Rebase after N32 commit.
- Use ldc1/sdc1 rather than l.d and s.d.
Repository:
rUNW libunwind
https://reviews.llvm.org/D41968
Files:
include/__libunwind_config.h
include/libunwind.h
bsdjhb added a comment.
Hmmm, so I was somewhat mistaken as DwarfInstructions.hpp::stepWithDwarf() does
use the Register class's setFloatRegister(), however, it assumes that the
floating point register is always a double
(DwarfInstructions.hpp::getSavedFloatRegister() uses AddressSpace::getDoub
juliehockett added a comment.
In https://reviews.llvm.org/D41102#1020808, @lebedev.ri wrote:
> Ok, great.
> And it will also complain if you try to output a block within block?
Um...no. Since you can have subblocks within blocks.
Comment at: clang-doc/BitcodeWriter.cpp:191
juliehockett updated this revision to Diff 136161.
juliehockett marked 15 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/BitcodeWriter.h
clang-doc/CMakeLists.txt
clang-d
jdenny added a comment.
In https://reviews.llvm.org/D43748#1021246, @aaron.ballman wrote:
> LGTM! I can commit on your behalf, or, if you plan to continue submitting
> patches, you can ask for commit privileges
> (http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) and
> commit
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! I can commit on your behalf, or, if you plan to continue submitting
patches, you can ask for commit privileges
(http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-a
jdenny added a comment.
In https://reviews.llvm.org/D43747#1021234, @aaron.ballman wrote:
> In https://reviews.llvm.org/D43747#1021209, @jdenny wrote:
>
> > In https://reviews.llvm.org/D43747#1018844, @aaron.ballman wrote:
> >
> > > Committed in r326057.
> > >
> > > If you're not already on IRC,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326258: [analyzer] UndefinedAssignmentChecker: Better
warning message in implicit ctors. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
Author: dergachev
Date: Tue Feb 27 14:05:55 2018
New Revision: 326258
URL: http://llvm.org/viewvc/llvm-project?rev=326258&view=rev
Log:
[analyzer] UndefinedAssignmentChecker: Better warning message in implicit ctors.
When a class forgets to initialize a field in the constructor, and then gets
cop
aaron.ballman added a comment.
In https://reviews.llvm.org/D43747#1021209, @jdenny wrote:
> In https://reviews.llvm.org/D43747#1018844, @aaron.ballman wrote:
>
> > Committed in r326057.
> >
> > If you're not already on IRC, I would recommend joining the #llvm channel
> > on OFTC so that you can
NoQ updated this revision to Diff 136151.
NoQ marked an inline comment as done.
NoQ added a comment.
Mention the implicit constructor in the warning message.
https://reviews.llvm.org/D43798
Files:
lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp
test/Analysis/implicit-ctor-undef-v
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM. I have a suggestion for a slight modification of the diagnostic text
inline.
Comment at: test/Analysis/implicit-ctor-undef-value.cpp:12
+// missing. Specify whic
Author: kzhuravl
Date: Tue Feb 27 13:48:05 2018
New Revision: 326254
URL: http://llvm.org/viewvc/llvm-project?rev=326254&view=rev
Log:
AMDGPU: Define FP_FAST_FMA{F} macros for amdgcn
- Expand GK_*s (i.e. GFX6 -> GFX600, GFX601, etc.)
- This allows us to choose features correctly in some cases (
jdenny added a comment.
In https://reviews.llvm.org/D43747#1018844, @aaron.ballman wrote:
> Committed in r326057.
>
> If you're not already on IRC, I would recommend joining the #llvm channel on
> OFTC so that you can watch for build break notifications from the build bots.
Thanks. Can your r
should be fine now.
> On Feb 27, 2018, at 12:04 AM, Yvan Roux wrote:
>
> Hi George,
>
> On 27 February 2018 at 02:31, George Karpenkov via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
>> Author: george.karpenkov
>> Date: Mon Feb 26 17:31:06 2018
>> New Revision: 326156
>>
>> URL: h
bsdjhb added a comment.
After thinking about this some more, I need to rework this a bit. The choice
of how to expose the floating point registers via getFloatingPointRegister /
setFloatingPointRegister only affects consumers of the libunwind
unw_get_fpreg/unw_set_fpreg. I think a bigger fact
malaperle added a comment.
In https://reviews.llvm.org/D39050#949185, @malaperle wrote:
> In https://reviews.llvm.org/D39050#948500, @akyrtzi wrote:
>
> > @malaperle, to clarify we are not suggesting that you write your own
> > parser, the suggestion is to use clang in 'fast-scan' mode to get th
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp:60
// Generate a report for this bug.
+ std::string Str;
+ llvm::raw_string_ostream OS(Str);
a.sidorin wrote:
> SmallString<128>?
*recalls how it's done* Ok!
NoQ updated this revision to Diff 136145.
NoQ marked 2 inline comments as done.
NoQ added a comment.
Use `SmallString`.
Add some test for base-class implicit constructors to see how it currently
works (not ideal but good enough).
https://reviews.llvm.org/D43798
Files:
lib/StaticAnalyzer/Che
This revision was automatically updated to reflect the committed changes.
Closed by commit rUNW326250: [libunwind][MIPS]: Add support for unwinding in
N32 processes. (authored by jhb, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D39074?vs=133660&id=136144#toc
Repository:
Author: jhb
Date: Tue Feb 27 13:24:02 2018
New Revision: 326250
URL: http://llvm.org/viewvc/llvm-project?rev=326250&view=rev
Log:
[libunwind][MIPS]: Add support for unwinding in N32 processes.
Summary:
N32 uses the same register context as N64. However, N32 requires one
change to properly fetch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326249: [analyzer] MallocChecker: Suppress false positives
in shared pointers. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326249: [analyzer] MallocChecker: Suppress false positives
in shared pointers. (authored by dergachev, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D43791
Files:
lib/StaticAnalyzer/C
Author: dergachev
Date: Tue Feb 27 13:19:33 2018
New Revision: 326249
URL: http://llvm.org/viewvc/llvm-project?rev=326249&view=rev
Log:
[analyzer] MallocChecker: Suppress false positives in shared pointers.
Throw away MallocChecker warnings that occur after releasing a pointer within a
destructor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326247: [analyzer] Fix trivial copy for empty objects.
(authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43714?vs=135771
Author: dergachev
Date: Tue Feb 27 13:10:08 2018
New Revision: 326247
URL: http://llvm.org/viewvc/llvm-project?rev=326247&view=rev
Log:
[analyzer] Fix trivial copy for empty objects.
The SVal for any empty C++ object is an UnknownVal. Because RegionStore does
not have binding extents, binding an
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326246: [analyzer] Track temporaries without construction
contexts for destruction. (authored by dergachev, committed by )
Author: dergachev
Date: Tue Feb 27 13:02:58 2018
New Revision: 326246
URL: http://llvm.org/viewvc/llvm-project?rev=326246&view=rev
Log:
[analyzer] Track temporaries without construction contexts for destruction.
Sometimes it is not known at compile time which temporary objects will be
constructed
jdenny updated this revision to Diff 136136.
jdenny edited the summary of this revision.
jdenny added a comment.
This addresses the comment about redundant ifs.
https://reviews.llvm.org/D43748
Files:
include/clang/Basic/Attr.td
lib/Parse/ParseDecl.cpp
test/Sema/attr-print.c
test/Sema/at
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326245: [analyzer] Don't crash when dynamic type of a
variable is set via placement new. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
Author: dergachev
Date: Tue Feb 27 12:54:40 2018
New Revision: 326245
URL: http://llvm.org/viewvc/llvm-project?rev=326245&view=rev
Log:
[analyzer] Don't crash when dynamic type of a variable is set via placement new.
If a variable or an otherwise a concrete typed-value region is being
placement-n
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326240: [analyzer] Disable constructor inlining when
lifetime extending through a field. (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43689?vs=135669&id=136
Author: dergachev
Date: Tue Feb 27 12:14:06 2018
New Revision: 326240
URL: http://llvm.org/viewvc/llvm-project?rev=326240&view=rev
Log:
[analyzer] Disable constructor inlining when lifetime extending through a field.
Automatic destructors are missing in the CFG in situations like
const int &x
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:70
+/// by binding a smaller object within it to a reference.
+bool IsTemporaryLifetimeExtendedViaSubobject = false;
dcoughlin wrote:
> Would you be will
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326239: [analyzer] Self-debug: Dump dynamic type info and
taint with the program state. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326239: [analyzer] Self-debug: Dump dynamic type info and
taint with the program state. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D43657
Files:
include/cl
Author: dergachev
Date: Tue Feb 27 12:06:20 2018
New Revision: 326239
URL: http://llvm.org/viewvc/llvm-project?rev=326239&view=rev
Log:
[analyzer] Self-debug: Dump dynamic type info and taint with the program state.
Useful for debugging problems with dynamic type info and taint.
Differential Rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326238: [CFG] NFC: Refactor ConstructionContext into a
finite set of cases. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
Author: dergachev
Date: Tue Feb 27 12:03:35 2018
New Revision: 326238
URL: http://llvm.org/viewvc/llvm-project?rev=326238&view=rev
Log:
[CFG] NFC: Refactor ConstructionContext into a finite set of cases.
ConstructionContext is moved into a separate translation unit and is separated
into multiple
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326236: [analyzer] Introduce correct lifetime extension
behavior in simple cases. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D43497
Files:
include/clang/St
Author: dergachev
Date: Tue Feb 27 11:47:49 2018
New Revision: 326236
URL: http://llvm.org/viewvc/llvm-project?rev=326236&view=rev
Log:
[analyzer] Introduce correct lifetime extension behavior in simple cases.
This patch uses the reference to MaterializeTemporaryExpr stored in the
construction co
ahatanak added inline comments.
Comment at: lib/AST/ExprConstant.cpp:5236
if (Frame) {
- Result.set(VD, Frame->Index);
+ Result.set({VD, Frame->Index});
return true;
rsmith wrote:
> Hmm. We should be versioning local variables as well. Curre
ahatanak updated this revision to Diff 136124.
ahatanak marked 7 inline comments as done.
ahatanak added a comment.
Address review comments.
https://reviews.llvm.org/D42776
Files:
include/clang/AST/APValue.h
lib/AST/APValue.cpp
lib/AST/ExprConstant.cpp
test/SemaCXX/constant-expression-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326235: [MinGW, CrossWindows] Allow passing -static together
with -shared (authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326235: [MinGW, CrossWindows] Allow passing -static together
with -shared (authored by mstorsjo, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D43811
Files:
lib/Driver/ToolChains/Cros
Author: mstorsjo
Date: Tue Feb 27 11:42:19 2018
New Revision: 326235
URL: http://llvm.org/viewvc/llvm-project?rev=326235&view=rev
Log:
[MinGW, CrossWindows] Allow passing -static together with -shared
In these combinations, link a DLL as usual, but pass -Bstatic instead
of -Bdynamic to indicate p
Author: george.karpenkov
Date: Tue Feb 27 11:28:52 2018
New Revision: 326234
URL: http://llvm.org/viewvc/llvm-project?rev=326234&view=rev
Log:
[analyzer] Remove redundant check
There is no point in assigning void just to crash on it in the next line
Differential Revision: https://reviews.llvm.or
Author: george.karpenkov
Date: Tue Feb 27 11:28:52 2018
New Revision: 326233
URL: http://llvm.org/viewvc/llvm-project?rev=326233&view=rev
Log:
[analyzer] Only attempt to get the value of locations of known type
Fixes https://bugs.llvm.org/show_bug.cgi?id=36474
In general, getSVal API should be c
Author: wizard
Date: Tue Feb 27 10:35:53 2018
New Revision: 326222
URL: http://llvm.org/viewvc/llvm-project?rev=326222&view=rev
Log:
add UUID to the acronyms list of objc property name checks
Reviewers: benhamilton, hokein
Reviewed By: benhamilton
Subscribers: klimek, cfe-commits
Differential
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/RestrictIncludesCheck.cpp:42-44
+SourceLocation Loc; ///< '#' location in the include directive
+CharSourceRange Range; ///< SourceRange for the file name
+std::string Filename; ///< Filename a
mstorsjo added a comment.
In https://reviews.llvm.org/D43811#1020847, @rnk wrote:
> This means, link the CRT and other default libraries statically, but give me
> a DLL, right? Just confirming.
Exactly - for all libraries linked where you have the choice of both dynamic
and static, pick the s
Author: george.karpenkov
Date: Tue Feb 27 11:19:49 2018
New Revision: 326230
URL: http://llvm.org/viewvc/llvm-project?rev=326230&view=rev
Log:
[analyzer] Quickfix: don't crash when runtime definition is not available.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
Modifi
Author: george.karpenkov
Date: Tue Feb 27 11:19:43 2018
New Revision: 326229
URL: http://llvm.org/viewvc/llvm-project?rev=326229&view=rev
Log:
[analyzer] Logging test quickfix #2.
Modified:
cfe/trunk/test/Analysis/region_store_overflow.c
Modified: cfe/trunk/test/Analysis/region_store_overflo
NutshellySima added a comment.
In https://reviews.llvm.org/D43829#1020957, @lebedev.ri wrote:
> Tests?
Thanks for your advice, I'll add one.
Repository:
rC Clang
https://reviews.llvm.org/D43829
___
cfe-commits mailing list
cfe-commits@lists.ll
NoQ updated this revision to Diff 136114.
NoQ added a comment.
Add one more comment.
https://reviews.llvm.org/D43791
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/NewDelete-atomics.cpp
Index: test/Analysis/NewDelete-atomics.cpp
=
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326227: [clang-format] Format operator key in protos
(authored by krasimir, committed by ).
Changed prior to commit:
ht
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This fixes a glitch where ``operator: value`` in a text proto would mess up the
underlying formatting since it gets parsed as a kw_operator instead of an
identifier.
Repository:
rC Clang
https://reviews.llvm.org/
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326227: [clang-format] Format operator key in protos
(authored by krasimir, committed by ).
Herald added a subscriber: llv
Author: krasimir
Date: Tue Feb 27 11:07:47 2018
New Revision: 326227
URL: http://llvm.org/viewvc/llvm-project?rev=326227&view=rev
Log:
[clang-format] Format operator key in protos
Summary: This fixes a glitch where ``operator: value`` in a text proto would
mess up the underlying formatting since
lebedev.ri added a comment.
Tests?
Repository:
rC Clang
https://reviews.llvm.org/D43829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NutshellySima created this revision.
NutshellySima added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
Before, clang does not warn -Wlogical-op-parentheses and
-Wbitwise-op-parentheses in macros, thus miss some cases like PR 18971 and
mismatch gcc's behavior.
Fix this by enabling
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:64
+bool MakeSmartPtrCheck::isLanguageVersionSupported(const LangOptions &
LangOpts) const
+{
The formatting here is wrong.
https://reviews.llvm.org/D43766
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326223: [libunwind] Permit additional compiler and linker
flags to be passed to tests. (authored by jhb, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llv
Author: jhb
Date: Tue Feb 27 10:40:04 2018
New Revision: 326223
URL: http://llvm.org/viewvc/llvm-project?rev=326223&view=rev
Log:
[libunwind] Permit additional compiler and linker flags to be passed to tests.
Summary:
This is done via new LIBUNWIND_TEST_COMPILER_FLAGS and
LIBUNWIND_TEST_LINKER_FL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326222: add UUID to the acronyms list of objc property name
checks (authored by Wizard, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43775
Fil
benhamilton added a comment.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE326222: add UUID to the acronyms list of objc property
name checks (authored by Wizard, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43775?vs=136100&id=136102#toc
Repository:
1 - 100 of 187 matches
Mail list logo
