[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

ahatanak added inline comments. Comment at: lib/AST/ExprConstant.cpp:589-598 +/// Keep track of the version of MTEs that are used by CXXDefaultArgExpr. +/// The version number is updated every time VisitCXXDefaultArgExpr is +/// called. +unsigned getDefaultArgNum(

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

ahatanak updated this revision to Diff 134560. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D42776 Files: include/clang/AST/APValue.h lib/AST/APValue.cpp lib/AST/ExprConstant.cpp test/SemaCXX/constexpr-default-arg

[PATCH] D43371: [clang-include-fixer] Use add_clang_tool instead add_clang_executable

phosek created this revision. phosek added reviewers: klimek, sammccall, bkramer, hokein. Herald added subscribers: cfe-commits, mgorny. This makes it possible to include clang-include-fixer as distribution component when building Clang based toolchain using CMake. Repository: rCTE Clang Tools

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

mstorsjo added a comment. In https://reviews.llvm.org/D43184#1009355, @rnk wrote: > The Qt bug is interesting, but I think we're doing the right thing here. C++ > doesn't define any semantics for partially initialized objects. It's unclear > if clang or GCC's way of doing things is better or no

[PATCH] D42995: [ThinLTO] Allow indexing to request backend to ignore the module

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1176 + // Output of this module is not needed, but build system may not know + // that. So we need to generated empty valid object file. + EmptyModule = llvm::make_unique("empty", M->get

[PATCH] D36701: Use Token::isOneOf method in Parser.

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D36701: Use Token::isOneOf method in Parser.

marsupial added a comment. Ping. https://reviews.llvm.org/D36701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36702: Make Parser::Consume*Token methods public.

marsupial added a comment. Ping. https://reviews.llvm.org/D36702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

brucem added a comment. This is `modernize-redundant-void-arg`: https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html Repository: rCXX libc++ https://reviews.llvm.org/D43226 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D43277: limits: Use `false` instead of `type(0)`.

brucem added a comment. Herald added a subscriber: christof. Without this, anyone using `clang-tidy` with this check gets 6 system header warnings whenever they transitively have included `limits`. Repository: rCXX libc++ https://reviews.llvm.org/D43277 ___

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle updated this revision to Diff 134549. malaperle added a comment. Change some EXPECT_TRUE to ASSERT_TRUE Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38639 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Protocol.h clangd/SourceCode.cpp clangd/Sourc

[PATCH] D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL325312: [DOXYGEN] There was a request in the review D41507 to change the notation for… (authored by kromanova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

r325312 - [DOXYGEN] There was a request in the review D41507 to change the notation for hex numbers in doxygen documentation from <...>h to 0x<...>. Both of these notations were used in x86 intrinsics

Author: kromanova Date: Thu Feb 15 19:11:35 2018 New Revision: 325312 URL: http://llvm.org/viewvc/llvm-project?rev=325312&view=rev Log: [DOXYGEN] There was a request in the review D41507 to change the notation for hex numbers in doxygen documentation from <...>h to 0x<...>. Both of these notatio

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rsmith added inline comments. Comment at: clang/include/clang/AST/Expr.h:103 +/// Contexts in which a converted constant expression is required. +enum CCEKind { + CCEK_CaseValue, ///< Expression in a case label. If we end up moving this out of `Sema` into the

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 134546. juliehockett edited the summary of this revision. juliehockett added a comment. Moving the entire implementation of the bitcode reader to this patch (from the mapper patch, here ) and cleaning up implementation

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 134544. juliehockett edited the summary of this revision. juliehockett added a comment. Updating tests and moving the bitcode reader out (to the next patch) https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-doc/CMakeLists.txt clang-doc/

[PATCH] D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D41888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D41888: [DOXYGEN] documentation changes to emmintrin.h and tmmintrin.h

kromanova updated this revision to Diff 134537. kromanova added a comment. Doug Yung (the reviewer for this patch) noticed that some lines exceed 80 characters limitation. I fixed that. https://reviews.llvm.org/D41888 Files: lib/Headers/emmintrin.h lib/Headers/tmmintrin.h Index: lib/Heade

r325305 - [Modules] Extend -fmodule-name semantic for frameworks with private modules

Author: bruno Date: Thu Feb 15 16:12:57 2018 New Revision: 325305 URL: http://llvm.org/viewvc/llvm-project?rev=325305&view=rev Log: [Modules] Extend -fmodule-name semantic for frameworks with private modules Assume Foo.framework with two module maps and two modules Foo and Foo_Private. Framework

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny marked 3 inline comments as done. jdenny added a comment. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} jdenny wrote: > aaron.ballman wrote: > > Is

r325304 - [OPENMP] Fix PR36399: Crash on C code with ordered doacross construct.

Author: abataev Date: Thu Feb 15 15:39:43 2018 New Revision: 325304 URL: http://llvm.org/viewvc/llvm-project?rev=325304&view=rev Log: [OPENMP] Fix PR36399: Crash on C code with ordered doacross construct. Codegen for ordered with doacross construct might produce incorrect code because of missing

[PATCH] D43362: Simplify setting dso_local. NFC.

espindola created this revision. espindola added a reviewer: rnk. The value of dso_local can be computed from just IR properties and global information (object file type, command line options, etc). With this patch we no longer pass in the Decl. It was almost unused and making it fully unused g

[PATCH] D43359: Clean up 'target' attribute diagnostics

erichkeane added a comment. Thanks! I'll give @aaron.ballman a chance to take a look, so I'll probably do something about this tomorrow. https://reviews.llvm.org/D43359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D43359: Clean up 'target' attribute diagnostics

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Seems ok here. https://reviews.llvm.org/D43359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D43359: Clean up 'target' attribute diagnostics

erichkeane created this revision. erichkeane added reviewers: echristo, aaron.ballman. There were a few issues previously with the target attribute diagnostics implementation that lead to the attribute being added to the AST despite having an error in it. This patch changes that, and adds a test

[PATCH] D43357: Function trailing requires clauses now parsed, supported in overload resolution and when calling, referencing and taking the address of functions or function templates.Does not directl

saar.raz created this revision. saar.raz added reviewers: nwilson, hubert.reinterpretcast, changyu, rsmith, faisalv, Quuxplusone. Herald added a subscriber: cfe-commits. Depends on https://reviews.llvm.org/D41910. Repository: rC Clang https://reviews.llvm.org/D43357 Files: include/clang/A

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone updated this revision to Diff 134514. Quuxplusone added a comment. Reword the diagnostic per rsmith's suggestions. Still TODO: - figure out how to detect whether this is a return-stmt or throw-expression - figure out how to generate the appropriate fixit Repository: rC Clang http

r325302 - [OPENMP] Fix PR38398: compiler crash on standalone pragma ordered with depend sink|source clause.

Author: abataev Date: Thu Feb 15 14:42:57 2018 New Revision: 325302 URL: http://llvm.org/viewvc/llvm-project?rev=325302&view=rev Log: [OPENMP] Fix PR38398: compiler crash on standalone pragma ordered with depend sink|source clause. Patch fixes compiler crash on standalone #pragmas ordered with d

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

kevinl added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:1497 +!(PrevToken->is(tok::exclaim) && + Style.Language == FormatStyle::LK_JavaScript)) // There aren't any trailing unary operators except for TypeScript's krasimir w

[PATCH] D43312: [clang-format] fix handling of consecutive unary operators

kevinl updated this revision to Diff 134511. kevinl edited the summary of this revision. kevinl added a comment. Simplified the heuristic logic, which extends the fix to TypeScript as well Repository: rC Clang https://reviews.llvm.org/D43312 Files: lib/Format/TokenAnnotator.cpp unittests

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rnk updated this revision to Diff 134510. rnk added a comment. - revise as discussed https://reviews.llvm.org/D43320 Files: clang/include/clang/AST/Expr.h clang/include/clang/Sema/Sema.h clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaOverload.cpp clang/test/SemaCXX/dllimport-conste

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

rnk added a comment. In https://reviews.llvm.org/D43184#1005534, @mstorsjo wrote: > In https://reviews.llvm.org/D43184#1005281, @smeenai wrote: > > > > > > A related observation on the topic of this: There's a subtle difference > between what both GCC and MSVC does here, compared to clang. The c

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

oren_ben_simhon marked an inline comment as done. oren_ben_simhon added inline comments. Comment at: test/Sema/attr-nocf_check.c:18-20 + FuncPointerWithNoCfCheck fNoCfCheck = f; // no-warning + (*fNoCfCheck)(); // no-warning + f = fNoCfCheck;

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov marked an inline comment as done. dfukalov added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:9866 + case AMDGPU::BI__builtin_amdgcn_ds_fmax: { +llvm::SmallVector Args; +for (unsigned I = 0; I != 5; ++I) b-sumner wrote: > Can the point

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov updated this revision to Diff 134503. dfukalov edited the summary of this revision. dfukalov added a comment. diff updated as requested by reviewer https://reviews.llvm.org/D43281 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/CodeGen/CGBuiltin.cpp test/CodeGenOpenCL/builtins-

[clang-tools-extra] r325298 - [include-fixer] Add more debug headers to the STL header list

Author: d0k Date: Thu Feb 15 13:37:29 2018 New Revision: 325298 URL: http://llvm.org/viewvc/llvm-project?rev=325298&view=rev Log: [include-fixer] Add more debug headers to the STL header list These are used for std::map/std::set in STL debug mode. Modified: clang-tools-extra/trunk/include-f

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone marked an inline comment as done. Quuxplusone added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:23 +def warn_return_std_move : Warning< + "adding 'std::move' here would select a better conversion sequence">, + InGroup, DefaultIgnore;

r325293 - Silence a -Wparentheses warning; NFC.

Author: aaronballman Date: Thu Feb 15 13:03:39 2018 New Revision: 325293 URL: http://llvm.org/viewvc/llvm-project?rev=325293&view=rev Log: Silence a -Wparentheses warning; NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp

r325292 - Silence some -Wunused-variable warnings; NFC.

Author: aaronballman Date: Thu Feb 15 12:56:19 2018 New Revision: 325292 URL: http://llvm.org/viewvc/llvm-project?rev=325292&view=rev Log: Silence some -Wunused-variable warnings; NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/E

[PATCH] D42606: [Coroutines] Use allocator overload when available

modocache added a comment. Hooray, `[dcl.fct.def.coroutine]/7` is *in!* Thank you for all the reviews, @GorNishanov! Repository: rC Clang https://reviews.llvm.org/D42606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D42606: [Coroutines] Use allocator overload when available

This revision was automatically updated to reflect the committed changes. Closed by commit rC325291: [Coroutines] Use allocator overload when available (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D42606?vs=134304&id=134495#toc Repository: rC Clan

r325291 - [Coroutines] Use allocator overload when available

Author: modocache Date: Thu Feb 15 12:37:22 2018 New Revision: 325291 URL: http://llvm.org/viewvc/llvm-project?rev=325291&view=rev Log: [Coroutines] Use allocator overload when available Summary: Depends on https://reviews.llvm.org/D42605. An implementation of the behavior described in `[dcl.fct

[PATCH] D42605: [Sema] Toggle diags when finding allocators (NFCI)

modocache added a comment. Thanks again, @GorNishanov, for all the reviews! Repository: rC Clang https://reviews.llvm.org/D42605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r325288 - [Sema] Toggle diags when finding allocators (NFCI)

Author: modocache Date: Thu Feb 15 12:09:25 2018 New Revision: 325288 URL: http://llvm.org/viewvc/llvm-project?rev=325288&view=rev Log: [Sema] Toggle diags when finding allocators (NFCI) Summary: Many methods in Sema take a `bool Diagnose` parameter. Examples of such methods include `Sema::FindDe

[PATCH] D42605: [Sema] Toggle diags when finding allocators (NFCI)

This revision was automatically updated to reflect the committed changes. Closed by commit rC325288: [Sema] Toggle diags when finding allocators (NFCI) (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D42605?vs=131728&id=134489#toc Repository: rC Clan

[PATCH] D41228: [ObjC] Enable __strong pointers in structs under ARC

rjmccall added inline comments. Comment at: include/clang/AST/Decl.h:3619 +return NonTrivialToPrimitiveDestructiveMove; + } + Please document that this means a C++-style destructive move that leaves the source object in a validly-initialized state. ==

[PATCH] D43149: [analyzer] Fix a crash on destroying a temporary array.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC325286: [analyzer] Suppress temporary destructors for temporary arrays. (authored by dergachev, committed by ). Repositor

r325286 - [analyzer] Suppress temporary destructors for temporary arrays.

Author: dergachev Date: Thu Feb 15 11:34:19 2018 New Revision: 325286 URL: http://llvm.org/viewvc/llvm-project?rev=325286&view=rev Log: [analyzer] Suppress temporary destructors for temporary arrays. Array destructors, like constructors, need to be called for each element of the array separately.

[PATCH] D43144: [analyzer] Implement path notes for temporary destructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rL325284: [analyzer] Implement path notes for temporary destructors. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D431

r325284 - [analyzer] Implement path notes for temporary destructors.

Author: dergachev Date: Thu Feb 15 11:28:21 2018 New Revision: 325284 URL: http://llvm.org/viewvc/llvm-project?rev=325284&view=rev Log: [analyzer] Implement path notes for temporary destructors. Temporary destructors fire at the end of the full-expression. It is reasonable to attach the path note

[PATCH] D43273: [libcxx] [test] Fix MSVC warnings and errors.

STL_MSFT added a comment. Would pragmas guarded by `_MSC_VER` be acceptable for the truncation warnings? https://reviews.llvm.org/D43273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D43104: [analyzer] Find correct region for simple temporary destructor calls and inline them if possible.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL325282: [analyzer] Compute the correct this-region for temporary destructors. (authored by dergachev, committed by ). Hera

[PATCH] D43104: [analyzer] Find correct region for simple temporary destructor calls and inline them if possible.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC325282: [analyzer] Compute the correct this-region for temporary destructors. (authored by dergachev, committed by ). Rep

r325282 - [analyzer] Compute the correct this-region for temporary destructors.

Author: dergachev Date: Thu Feb 15 11:17:44 2018 New Revision: 325282 URL: http://llvm.org/viewvc/llvm-project?rev=325282&view=rev Log: [analyzer] Compute the correct this-region for temporary destructors. Inline them if possible - a separate flag is added to control this. The whole thing is unde

[PATCH] D43340: Clean up AMDGCN tests

This revision was automatically updated to reflect the committed changes. Closed by commit rC325279: Clean up AMDGCN tests (authored by yaxunl, committed by ). Changed prior to commit: https://reviews.llvm.org/D43340?vs=134445&id=134465#toc Repository: rC Clang https://reviews.llvm.org/D433

r325279 - Clean up AMDGCN tests

Author: yaxunl Date: Thu Feb 15 11:12:41 2018 New Revision: 325279 URL: http://llvm.org/viewvc/llvm-project?rev=325279&view=rev Log: Clean up AMDGCN tests Differential Revision: https://reviews.llvm.org/D43340 Modified: cfe/trunk/test/CodeGen/address-space.c cfe/trunk/test/CodeGenCXX/cxx

[clang-tools-extra] r325272 - [clang-tidy] Add `readability-simd-intrinsics` check.

Author: maskray Date: Thu Feb 15 09:56:43 2018 New Revision: 325272 URL: http://llvm.org/viewvc/llvm-project?rev=325272&view=rev Log: [clang-tidy] Add `readability-simd-intrinsics` check. Summary: Many architectures provide SIMD operations (e.g. x86 SSE/AVX, Power AltiVec/VSX, ARM NEON). It is co

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

xazax.hun added a comment. In https://reviews.llvm.org/D30691#1003514, @george.karpenkov wrote: > Python code looks OK to me, I have one last request: could we have a small > documentation how the whole thing is supposed work in integration, preferably > on an available open-source project any

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

xazax.hun updated this revision to Diff 134431. xazax.hun added a comment. - Rebased to current ToT - Fixed a problem that the scan-build-py used an old version of the ctu configuration option - Added a short guide how to use CTU https://reviews.llvm.org/D30691 Files: include/clang/StaticAna

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

yaxunl added a comment. In https://reviews.llvm.org/D34367#1009021, @rjmccall wrote: > That's not really okay; there are some places that make guarantees about > call-argument ordering, and in general we want that to be decided at a higher > level, rather than having a particular order forced i

[PATCH] D43340: Clean up AMDGCN tests

b-sumner accepted this revision. b-sumner added a comment. Looks good to me. https://reviews.llvm.org/D43340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r325278 - [analyzer] NFC: Eliminate ParentMap lookup in mayInlineCallKind().

Author: dergachev Date: Thu Feb 15 11:01:55 2018 New Revision: 325278 URL: http://llvm.org/viewvc/llvm-project?rev=325278&view=rev Log: [analyzer] NFC: Eliminate ParentMap lookup in mayInlineCallKind(). Don't look at the parent statement to figure out if the cxx-allocator-inlining flag should kic

[PATCH] D43320: Allow dllimport non-type template arguments in C++17

rnk added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10166-10182 +EvalInfo Info(Ctx, Result, EvalInfo::EM_ConstantFold); +Info.IsNonTypeTemplateArgument = true; +LValue LV; +if (!EvaluateLValue(this, LV, Info) || Result.HasSideEffects || +

[PATCH] D43340: Clean up AMDGCN tests

yaxunl added a comment. In https://reviews.llvm.org/D43340#1008980, @t-tye wrote: > LGTM Plus I think there was a test with giz in its name. Should that be > renamed? That's test/CodeGenOpenCL/amdgpu-env-amdgiz.cl. I already renamed it in my last commit. https://reviews.llvm.org/D43340 _

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

rjmccall added a comment. That's not really okay; there are some places that make guarantees about call-argument ordering, and in general we want that to be decided at a higher level, rather than having a particular order forced in corner cases just to satisfy a lower-level implementation requi

Re: r325203 - Reapply r325193

On Thu, 2018-02-15 at 02:37 +, Konstantin Zhuravlyov via cfe- commits wrote: > Author: kzhuravl > Date: Wed Feb 14 18:37:04 2018 > New Revision: 325203 > > URL: http://llvm.org/viewvc/llvm-project?rev=325203&view=rev > Log: > Reapply r325193 Ca you please not do that ? Is it that difficul

[PATCH] D35894: [clangd] Code hover for Clangd

simark updated this revision to Diff 134452. simark added a comment. Fix field names in XRefsTests.cpp I realized I forgot to add some fixups in the previous version, the field names in XRefsTests.cpp were not updated and therefore it did not build. Repository: rCTE Clang Tools Extra https:/

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:355-357 } + else if (DisallowImplicitThisParam) +*DisallowImplicitThisParam = false; jdenny wrote: > aaron.ballman wrote: > > Formatting is off here -- the `else if` should go up a

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett created this revision. juliehockett added reviewers: klimek, sammccall, jakehehrlich. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. juliehockett added a dependency: D41102: Setup clang-doc frontend framework. Implements a simple, in-memory reducer

[PATCH] D43246: [clangd] Assert path is absolute when assigning to URIForFile.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG if we want to do this (please getFile -> file though!) Comment at: clangd/Protocol.h:52 struct URIForFile { + URIForFile() = default; ioeric wro

[PATCH] D43340: Clean up AMDGCN tests

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Plus I think there was a test with giz in its name. Should that be renamed? https://reviews.llvm.org/D43340 ___ cfe-commits mailing list cfe-c

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

jdenny added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} aaron.ballman wrote: > Is there much benefit to forcing the attribute author to p

New LLD performance builder

Hello everyone, I have added a new public LLD performance builder at http://lab.llvm.org:8011/builders/lld-perf-testsuite. It builds LLVM and LLD by the latest releaed Clang and runs a set of perfromance tests. The builder is reliable. Please pay attention on the failures. The performance statis

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325272: [clang-tidy] Add `readability-simd-intrinsics` check. (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D42983?vs=134447&id=134448#toc Repository: rCTE

r325271 - [Test] Remove mangled name from test.

Author: mattd Date: Thu Feb 15 09:55:52 2018 New Revision: 325271 URL: http://llvm.org/viewvc/llvm-project?rev=325271&view=rev Log: [Test] Remove mangled name from test. This line is not needed in the test, and breaks Windows testing. Fixes the test added in r325175. Modified: cfe/trunk/tes

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay added inline comments. Comment at: test/clang-tidy/readability-simd-intrinsics-ppc.cpp:3 +// RUN: -config='{CheckOptions: [ \ +// RUN:{key: readability-simd-intrinsics.Suggest, value: 1} \ +// RUN: ]}' -- -target ppc64le -maltivec -std=c++11 hokein

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 134447. MaskRay marked 2 inline comments as done. MaskRay added a comment. Update Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 134446. MaskRay marked 4 inline comments as done. MaskRay added a comment. Update .rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D43273: [libcxx] [test] Fix MSVC warnings and errors.

mclow.lists added a comment. The `` bit is fine. The `veryLarge` is "ok". The rest of them are just bogus. https://reviews.llvm.org/D43273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D43248: [Attr] Fix printing of parameter indices in attributes

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:182 + // it would always be false. + string DisallowImplicitThisParamName = disallowImplicitThisParamName; +} Is there much benefit to forcing the attribute author to pick a name for t

[PATCH] D43340: Clean up AMDGCN tests

yaxunl created this revision. yaxunl added reviewers: t-tye, b-sumner. Remove amdgiz and use AMDGCN as check prefix. https://reviews.llvm.org/D43340 Files: test/CodeGen/address-space.c test/CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp test/CodeGenCXX/vla.cpp test/CodeGenOpenCL/ad

[PATCH] D42606: [Coroutines] Use allocator overload when available

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

mclow.lists added a comment. Herald added a subscriber: christof. Which clang-tidy module generates this warning, and what is the actual warning? Repository: rCXX libc++ https://reviews.llvm.org/D43226 ___ cfe-commits mailing list cfe-commits@lis

RE: r325175 - [Debug] Annotate compiler generated range-for loop variables.

From: Galina Kistanova [mailto:gkistan...@gmail.com] > Sent: Thursday, February 15, 2018 9:33 AM > To: Davis, Matthew > Cc: cfe-commits > Subject: Re: r325175 - [Debug] Annotate compiler generated range-for loop > variables. > > Hello Matt, > > This commit broke tests on one of our builders: >

Re: r325175 - [Debug] Annotate compiler generated range-for loop variables.

Hello Matt, This commit broke tests on one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/7920 . . . Failing Tests (1): Clang :: CodeGenCXX/debug-info-range-for-var-names.cpp Please have a look? Thanks Galina On Wed, Feb 14, 2018 at 1:22 PM

[PATCH] D35894: [clangd] Code hover for Clangd

ilya-biryukov accepted this revision. ilya-biryukov added a comment. Thanks for fixing all the NITs! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D43114: clang-format: fix formatting of ObjC @synchronized blocks

Typz marked an inline comment as done. Typz added inline comments. Comment at: unittests/Format/FormatTestObjC.cpp:193-198 + verifyFormat("@synchronized(self) {\n" + " f();\n" + "}\n" + "@synchronized(self) {\n" + " f();\

[PATCH] D35894: [clangd] Code hover for Clangd

simark updated this revision to Diff 134440. simark added a comment. Fix some nits - Revert case change of struct fields in Protocol.h - Change return formatting in onHover - Use flush() + return Name in NamedDeclQualifiedName and TypeDeclToString Repository: rCTE Clang Tools Extra https://r

[PATCH] D35894: [clangd] Code hover for Clangd

simark added a comment. In https://reviews.llvm.org/D35894#1008861, @ilya-biryukov wrote: > Only the naming of fields left. > > Also, please make sure to run `git-clang-format` on the code before > submitting to make sure it's formatted properly. Ahh, I was running clang-format by hand, didn't

[PATCH] D38639: [clangd] #include statements support for Open definition

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM modulo the `ASSERT_TRUE` nit. Comment at: unittests/clangd/XRefsTests.cpp:295 + runFindDefinitions(Server, FooCpp, SourceAnnotations.point()); + EXPE

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:1990 -bool Sema::CheckNoReturnAttr(const AttributeList &Attrs) { - if (!checkAttributeNumArgs(*this, Attrs, 0)) { -Attrs.setInvalid(); +static void handleNoCfCheckAttr(Sema &S, Decl *D, const Attrib

[PATCH] D43240: [OpenCL] Fix __enqueue_block for block with captures

This revision was automatically updated to reflect the committed changes. Closed by commit rL325264: [OpenCL] Fix __enqueue_block for block with captures (authored by yaxunl, committed by ). Herald added subscribers: llvm-commits, nhaehnle. Changed prior to commit: https://reviews.llvm.org/D432

r325264 - [OpenCL] Fix __enqueue_block for block with captures

Author: yaxunl Date: Thu Feb 15 08:39:19 2018 New Revision: 325264 URL: http://llvm.org/viewvc/llvm-project?rev=325264&view=rev Log: [OpenCL] Fix __enqueue_block for block with captures The following test case causes issue with codegen of __enqueue_block void (^block)(void) = ^{ callee(id, out);

[PATCH] D35894: [clangd] Code hover for Clangd

ilya-biryukov added a comment. Only the naming of fields left. Also, please make sure to run `git-clang-format` on the code before submitting to make sure it's formatted properly. Comment at: clangd/ClangdLSPServer.cpp:331 + if (!H) { +

[PATCH] D35894: [clangd] Code hover for Clangd

simark added a comment. In https://reviews.llvm.org/D35894#1008593, @ilya-biryukov wrote: > Just a few last remarks and this is good to go. > Should I land it for you after the last comments are fixed? I just received my commit access, so if you are ok with it, I would try to push it once I g

[PATCH] D35894: [clangd] Code hover for Clangd

simark updated this revision to Diff 134437. simark added a comment. New version - Rebase on master, change findHover to have a callback-based interface - Fix nits from previous review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894 Files: clangd/ClangdLSPServe

[PATCH] D35894: [clangd] Code hover for Clangd

simark added inline comments. Comment at: clangd/XRefs.cpp:354 + + return Name; +} ilya-biryukov wrote: > We should call `flush()` before returning `Name` here. The > `raw_string_ostream` is buffered. I replaced it with `Stream.str()`. Commen

r325261 - Amend r325256. This change was not properly merged locally before the commit happened.

Author: aaronballman Date: Thu Feb 15 08:28:10 2018 New Revision: 325261 URL: http://llvm.org/viewvc/llvm-project?rev=325261&view=rev Log: Amend r325256. This change was not properly merged locally before the commit happened. Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp Modified: cfe/trunk

[clang-tools-extra] r325260 - [clangd] Create trace::Span when running ASTCallback

Author: ibiryukov Date: Thu Feb 15 08:24:34 2018 New Revision: 325260 URL: http://llvm.org/viewvc/llvm-project?rev=325260&view=rev Log: [clangd] Create trace::Span when running ASTCallback Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/Clangd

[clang-tools-extra] r325257 - [clangd] Use explicit env in test to make lit+windows happy. NFC

Author: sammccall Date: Thu Feb 15 08:20:33 2018 New Revision: 325257 URL: http://llvm.org/viewvc/llvm-project?rev=325257&view=rev Log: [clangd] Use explicit env in test to make lit+windows happy. NFC Modified: clang-tools-extra/trunk/test/clangd/trace.test Modified: clang-tools-extra/trunk/

  1   2   >