r323627 - [NFC] fix trivial typos in comments

2018-01-28 Thread Hiroshi Inoue via cfe-commits
Author: inouehrs Date: Sun Jan 28 21:15:18 2018 New Revision: 323627 URL: http://llvm.org/viewvc/llvm-project?rev=323627&view=rev Log: [NFC] fix trivial typos in comments "to to" -> "to" Modified: cfe/trunk/lib/Headers/opencl-c.h cfe/trunk/test/Driver/cl-pch-search.cpp cfe/trunk/too

[PATCH] D41829: [cmake] WIP: Add cache file to bootstrap linux cross compile on Darwin.

2018-01-28 Thread Don Hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 131742. hintonda edited the summary of this revision. hintonda added a comment. - Libfuzzers won't build, so turn off. - Fix typos, and set cache. Repository: rC Clang https://reviews.llvm.org/D41829 Files: cmake/caches/Linux.cmake Index: cmake/cache

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

2018-01-28 Thread Yan Zhang via Phabricator via cfe-commits
Wizard marked 3 inline comments as done. Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:115 + +bool prefixedPropertyNameMatches(const llvm::StringRef &PropertyName, + const std::vector &Acronyms) { --

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

2018-01-28 Thread Yan Zhang via Phabricator via cfe-commits
Wizard updated this revision to Diff 131741. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst test/clang-tidy/objc-propert

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-01-28 Thread Brian Gesiak via Phabricator via cfe-commits
modocache updated this revision to Diff 131729. modocache added a comment. Add some diagnostics tests to SemaCXX/coroutines.cpp. Repository: rC Clang https://reviews.llvm.org/D42606 Files: lib/CodeGen/CGCoroutine.cpp lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp te

[PATCH] D42605: [Sema] Toggle diags when finding allocators (NFCI)

2018-01-28 Thread Brian Gesiak via Phabricator via cfe-commits
modocache updated this revision to Diff 131728. modocache added a comment. Prevent note diagnostics from being emitted for arity mismatch. Repository: rC Clang https://reviews.llvm.org/D42605 Files: include/clang/Sema/Sema.h lib/Sema/SemaExprCXX.cpp Index: lib/Sema/SemaExprCXX.cpp =

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

2018-01-28 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: test/clang-tidy/readability-unnecessary-intermediate-var.cpp:206 + auto test = 1; // Test +#ifdef INTERMITTENT_MACRO + return (test == 1); tbourvon wrote: > lebedev.ri wrote: > > Tests are nice :) > > But please, ad

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

2018-01-28 Thread Tristan Bourvon via Phabricator via cfe-commits
tbourvon marked an inline comment as done. tbourvon added inline comments. Comment at: test/clang-tidy/readability-unnecessary-intermediate-var.cpp:206 + auto test = 1; // Test +#ifdef INTERMITTENT_MACRO + return (test == 1); lebedev.ri wrote: > Tests are nice

[PATCH] D42624: [clang-tidy] Add a utility Matcher to match the next statement within a statement sequence

2018-01-28 Thread Tristan Bourvon via Phabricator via cfe-commits
tbourvon created this revision. tbourvon added a reviewer: lebedev.ri. tbourvon added a project: clang-tools-extra. Herald added subscribers: hintonda, xazax.hun, mgorny. This adds a utility matcher (which is placed in `util/Matchers.h`, because it uses functions from `ASTMatchFinder.h` which can

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

2018-01-28 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: test/clang-tidy/readability-unnecessary-intermediate-var.cpp:206 + auto test = 1; // Test +#ifdef INTERMITTENT_MACRO + return (test == 1); Tests are nice :) But please, add the test with assert-like macro.. https:

[PATCH] D42623: [clang-tidy] Add a Lexer util to get the source text of a statement

2018-01-28 Thread Tristan Bourvon via Phabricator via cfe-commits
tbourvon created this revision. tbourvon added a reviewer: lebedev.ri. tbourvon added a project: clang-tools-extra. Herald added subscribers: hintonda, xazax.hun, mgorny. This is a simple Lexer util to get the source text of a statement given as parameter. This is needed for https://reviews.llvm.

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

2018-01-28 Thread Tristan Bourvon via Phabricator via cfe-commits
tbourvon updated this revision to Diff 131709. tbourvon added a comment. Herald added a subscriber: hintonda. Separated the added matcher and lexer utils into a different diff. Also added unit tests to make sure we behave as expected when macros get in the way of the code we detect. https://rev

[PATCH] D41677: Change memcpy/memove/memset to have dest and source alignment attributes.

2018-01-28 Thread Daniel Neilson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323617: Change memcpy/memove/memset to have dest and source alignment attributes. (authored by dneilson, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llv

r323617 - Change memcpy/memove/memset to have dest and source alignment attributes.

2018-01-28 Thread Daniel Neilson via cfe-commits
Author: dneilson Date: Sun Jan 28 09:27:45 2018 New Revision: 323617 URL: http://llvm.org/viewvc/llvm-project?rev=323617&view=rev Log: Change memcpy/memove/memset to have dest and source alignment attributes. Summary: This change is step three in the series of changes to remove alignment argum

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-28 Thread Force.Charlie-I via Phabricator via cfe-commits
fcharlie added a comment. @compnerd Please commit this, Thanks Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-28 Thread Force.Charlie-I via Phabricator via cfe-commits
fcharlie accepted this revision. fcharlie added a comment. libcxx: Fix libcxx MSVC C++17 redefinition of 'align_val_t' Differential Revision: https://reviews.llvm.org/D42354 Repository: rCXX libc++ https://reviews.llvm.org/D42354 ___ cfe-commits

[PATCH] D42589: [git-clang-format] Process CUDA files

2018-01-28 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323615: [git-clang-format] Process CUDA files (authored by Hahnfeld, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42589?vs=131625&id=131701

r323615 - [git-clang-format] Process CUDA files

2018-01-28 Thread Jonas Hahnfeld via cfe-commits
Author: hahnfeld Date: Sun Jan 28 02:11:25 2018 New Revision: 323615 URL: http://llvm.org/viewvc/llvm-project?rev=323615&view=rev Log: [git-clang-format] Process CUDA files Clang supports compiling CUDA source files for some time, format them by default as well. Differential Revision: https://re