rjmccall added a comment.
It's not just that functions can't be overloaded on the parameter-variable type
qualifier — it's not part of the function type at all, just like making a
parameter 'const int' instead of 'int' is not part of the function type. I
understand that MSVC mangles some thing
rjmccall accepted this revision.
rjmccall added a comment.
Still LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D41677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
I think that if we can remove the `__zero` and `__max`, we should do that, but
that is better done as a separate change.
Repository:
rCXX libc++
https://reviews.llvm.org/D42354
jkorous-apple updated this revision to Diff 131693.
jkorous-apple added a comment.
I got rid of backslashes in test and added member of the type parameter with
typo. Thanks for suggestions.
https://reviews.llvm.org/D42170
Files:
FixIt/fixit-typedef-instead-of-typename-typo.cpp
Parse/ParseT
jkorous-apple added a comment.
I got rid of backslashes in test and added member of the type parameter with
typo. Thanks for these suggestions.
https://reviews.llvm.org/D42170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: dhinton
Date: Sat Jan 27 11:31:44 2018
New Revision: 323601
URL: http://llvm.org/viewvc/llvm-project?rev=323601&view=rev
Log:
[cmake] [libunwind] LLVM_FOUND isn't always set, so just test if
llvm_setup_rpath() is available instead.
Modified:
libunwind/trunk/src/CMakeLists.txt
Modifie
Author: dhinton
Date: Sat Jan 27 11:18:04 2018
New Revision: 323600
URL: http://llvm.org/viewvc/llvm-project?rev=323600&view=rev
Log:
[cmake] [libcxxabi] LLVM_FOUND isn't always set, so just test if
llvm_setup_rpath() is available instead.
Modified:
libcxxabi/trunk/src/CMakeLists.txt
Modifie
Author: dhinton
Date: Sat Jan 27 10:55:30 2018
New Revision: 323599
URL: http://llvm.org/viewvc/llvm-project?rev=323599&view=rev
Log:
LLVM_FOUND isn't always set, so just test if llvm_setup_rpath() is
available instead.
Modified:
libcxx/trunk/lib/CMakeLists.txt
Modified: libcxx/trunk/lib/CMa
smeenai added a comment.
pin_ptr is technically not supposed to appear as a function parameter, and
having it in that position can screw up demangling. Considering __strong is the
default, it's probably not a good idea to map that one to pin_ptr; whichever
qualifier is least likely to appear as
compnerd created this revision.
compnerd added a reviewer: rjmccall.
Herald added a subscriber: cfe-commits.
Add support for Objective C lifetime qualifiers in MS ABI. Because
there is no formal way to add a custom extension on a pointer qualifier,
re-use C++/CX (which is deprecated) and C++/CLI
dneilson updated this revision to Diff 131685.
dneilson added a comment.
Herald added subscribers: niosHD, sabuasal, apazos, jordy.potman.lists,
simoncook, johnrusso, rbar, asb.
Rebaseline
Repository:
rC Clang
https://reviews.llvm.org/D41677
Files:
lib/CodeGen/CGBuilder.h
test/CodeGen/a
Author: xazax
Date: Sat Jan 27 08:38:56 2018
New Revision: 323590
URL: http://llvm.org/viewvc/llvm-project?rev=323590&view=rev
Log:
Attempt to make the PS4 build bot happy.
Modified:
cfe/trunk/unittests/AST/ASTImporterTest.cpp
Modified: cfe/trunk/unittests/AST/ASTImporterTest.cpp
URL:
http:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323589: [ASTImporter] Add support to import some AST nodes:
(authored by xazax, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42335?vs=131406&id=131684#toc
Repository:
rC Clang
Author: xazax
Date: Sat Jan 27 08:11:45 2018
New Revision: 323589
URL: http://llvm.org/viewvc/llvm-project?rev=323589&view=rev
Log:
[ASTImporter] Add support to import some AST nodes:
* CXXOperatorCallExpr
* SizeOfPackExpr
* DependentTemplateSpecializationType
* DependentSizedArray
* CXXTypeidExp
14 matches
Mail list logo