[PATCH] D42614: AST: support ObjC lifetime qualifiers in MS ABI

2018-01-27 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. It's not just that functions can't be overloaded on the parameter-variable type qualifier — it's not part of the function type at all, just like making a parameter 'const int' instead of 'int' is not part of the function type. I understand that MSVC mangles some thing

[PATCH] D41677: Change memcpy/memove/memset to have dest and source alignment attributes.

2018-01-27 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. Still LGTM. Repository: rC Clang https://reviews.llvm.org/D41677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'

2018-01-27 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. I think that if we can remove the `__zero` and `__max`, we should do that, but that is better done as a separate change. Repository: rCXX libc++ https://reviews.llvm.org/D42354

[PATCH] D42170: Fixit for 'typedef' instead of 'typename' typo

2018-01-27 Thread Jan Korous via Phabricator via cfe-commits
jkorous-apple updated this revision to Diff 131693. jkorous-apple added a comment. I got rid of backslashes in test and added member of the type parameter with typo. Thanks for suggestions. https://reviews.llvm.org/D42170 Files: FixIt/fixit-typedef-instead-of-typename-typo.cpp Parse/ParseT

[PATCH] D42170: Fixit for 'typedef' instead of 'typename' typo

2018-01-27 Thread Jan Korous via Phabricator via cfe-commits
jkorous-apple added a comment. I got rid of backslashes in test and added member of the type parameter with typo. Thanks for these suggestions. https://reviews.llvm.org/D42170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[libunwind] r323601 - [cmake] [libunwind] LLVM_FOUND isn't always set, so just test if

2018-01-27 Thread Don Hinton via cfe-commits
Author: dhinton Date: Sat Jan 27 11:31:44 2018 New Revision: 323601 URL: http://llvm.org/viewvc/llvm-project?rev=323601&view=rev Log: [cmake] [libunwind] LLVM_FOUND isn't always set, so just test if llvm_setup_rpath() is available instead. Modified: libunwind/trunk/src/CMakeLists.txt Modifie

[libcxxabi] r323600 - [cmake] [libcxxabi] LLVM_FOUND isn't always set, so just test if

2018-01-27 Thread Don Hinton via cfe-commits
Author: dhinton Date: Sat Jan 27 11:18:04 2018 New Revision: 323600 URL: http://llvm.org/viewvc/llvm-project?rev=323600&view=rev Log: [cmake] [libcxxabi] LLVM_FOUND isn't always set, so just test if llvm_setup_rpath() is available instead. Modified: libcxxabi/trunk/src/CMakeLists.txt Modifie

[libcxx] r323599 - LLVM_FOUND isn't always set, so just test if llvm_setup_rpath() is

2018-01-27 Thread Don Hinton via cfe-commits
Author: dhinton Date: Sat Jan 27 10:55:30 2018 New Revision: 323599 URL: http://llvm.org/viewvc/llvm-project?rev=323599&view=rev Log: LLVM_FOUND isn't always set, so just test if llvm_setup_rpath() is available instead. Modified: libcxx/trunk/lib/CMakeLists.txt Modified: libcxx/trunk/lib/CMa

[PATCH] D42614: AST: support ObjC lifetime qualifiers in MS ABI

2018-01-27 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. pin_ptr is technically not supposed to appear as a function parameter, and having it in that position can screw up demangling. Considering __strong is the default, it's probably not a good idea to map that one to pin_ptr; whichever qualifier is least likely to appear as

[PATCH] D42614: AST: support ObjC lifetime qualifiers in MS ABI

2018-01-27 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd created this revision. compnerd added a reviewer: rjmccall. Herald added a subscriber: cfe-commits. Add support for Objective C lifetime qualifiers in MS ABI. Because there is no formal way to add a custom extension on a pointer qualifier, re-use C++/CX (which is deprecated) and C++/CLI

[PATCH] D41677: Change memcpy/memove/memset to have dest and source alignment attributes.

2018-01-27 Thread Daniel Neilson via Phabricator via cfe-commits
dneilson updated this revision to Diff 131685. dneilson added a comment. Herald added subscribers: niosHD, sabuasal, apazos, jordy.potman.lists, simoncook, johnrusso, rbar, asb. Rebaseline Repository: rC Clang https://reviews.llvm.org/D41677 Files: lib/CodeGen/CGBuilder.h test/CodeGen/a

r323590 - Attempt to make the PS4 build bot happy.

2018-01-27 Thread Gabor Horvath via cfe-commits
Author: xazax Date: Sat Jan 27 08:38:56 2018 New Revision: 323590 URL: http://llvm.org/viewvc/llvm-project?rev=323590&view=rev Log: Attempt to make the PS4 build bot happy. Modified: cfe/trunk/unittests/AST/ASTImporterTest.cpp Modified: cfe/trunk/unittests/AST/ASTImporterTest.cpp URL: http:

[PATCH] D42335: [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray, CXXTypeidExpr importing.

2018-01-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC323589: [ASTImporter] Add support to import some AST nodes: (authored by xazax, committed by ). Changed prior to commit: https://reviews.llvm.org/D42335?vs=131406&id=131684#toc Repository: rC Clang

r323589 - [ASTImporter] Add support to import some AST nodes:

2018-01-27 Thread Gabor Horvath via cfe-commits
Author: xazax Date: Sat Jan 27 08:11:45 2018 New Revision: 323589 URL: http://llvm.org/viewvc/llvm-project?rev=323589&view=rev Log: [ASTImporter] Add support to import some AST nodes: * CXXOperatorCallExpr * SizeOfPackExpr * DependentTemplateSpecializationType * DependentSizedArray * CXXTypeidExp