Re: [PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

Hi Ana On 17 January 2018 at 23:14, Ana Pazos via Phabricator via cfe-commits wrote: > apazos added a comment. > > Committed R32276 This commit broke ARM/AArch64 buildbots. riscv-gnutools.c test fails on these boxes. logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-aarch64

[PATCH] D42229: [cmake] [libcxxabi] Don't print warning when tests are disabled.

hintonda created this revision. hintonda added reviewers: compnerd, bryant, beanz. Herald added a subscriber: mgorny. Herald added a reviewer: EricWF. Herald added a reviewer: EricWF. Don't print, possibly erroneous, warning if LIBCXXABI_INCLUDE_TESTS is false. This patch fixes a problem introduc

r322816 - Revert rC322769: [RISCV] Propagate -mabi and -march values to GNU assembler.

Author: inouehrs Date: Wed Jan 17 22:13:25 2018 New Revision: 322816 URL: http://llvm.org/viewvc/llvm-project?rev=322816&view=rev Log: Revert rC322769: [RISCV] Propagate -mabi and -march values to GNU assembler. Temporarily revert rC322769 due to buildbot failurs. Removed: cfe/trunk/test/D

r322813 - Fix Scope::dump()

Author: rtrieu Date: Wed Jan 17 20:28:56 2018 New Revision: 322813 URL: http://llvm.org/viewvc/llvm-project?rev=322813&view=rev Log: Fix Scope::dump() The dump function for Scope only has 20 out of the 24 flags. Since it looped until no flags were left, having an unknown flag lead to an infinite

[PATCH] D42227: [Refactor] Use enum instead of magic number in handleX86ForceAlignArgPointerAttr, NFC

etherzhhb created this revision. etherzhhb added reviewers: aaron.ballman, echristo. Herald added a subscriber: cfe-commits. Simple change to use Use enum instead of magic number in handleX86ForceAlignArgPointerAttr. No functional change Repository: rC Clang https://reviews.llvm.org/D42227

[PATCH] [libcxx] a simple comment fix in include/list

Hello all, This is a simple (and my first) patch that fixes a comment in include/list. Qian Yun --- a/include/list +++ b/include/list @@ -1129,9 +1129,9 @@ __l->__next_->__prev_ = __l; base::__end_.__next_ = __f; } -// Link in nodes [__f, __l] at the front of the list +// Link in nod

[libcxx] r322810 - Fix most GCC test failures.

Author: ericwf Date: Wed Jan 17 19:41:06 2018 New Revision: 322810 URL: http://llvm.org/viewvc/llvm-project?rev=322810&view=rev Log: Fix most GCC test failures. This patch fixes almost all currently failing tests when using GCC ToT. The specific changes are: (A) Workaround gcc.gnu.org/PR83921 w

[PATCH] D41318: Start setting dso_local in clang

espindola updated this revision to Diff 130351. espindola added a comment. Herald added subscribers: niosHD, sabuasal, apazos, jordy.potman.lists, simoncook, johnrusso, rbar, asb. All tests have been updated. A few missing cases in c++ codegen are handled. We now use CodeGenOpts.RelocationModel,

r322809 - [analyzer] a few helper methods for getting and comparing symbolic values

Author: george.karpenkov Date: Wed Jan 17 19:18:36 2018 New Revision: 322809 URL: http://llvm.org/viewvc/llvm-project?rev=322809&view=rev Log: [analyzer] a few helper methods for getting and comparing symbolic values API calls should express intent, and that's a motivation behind this patch. Dif

[PATCH] D37189: Fix an assertion failure that occured when custom 'operator new[]' return non-ElementRegion and 'c++-allocator-inlining' sets true.

NoQ added a comment. That's the "Add Action..." list-box above the comment box. Repository: rC Clang https://reviews.llvm.org/D37189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D37189: Fix an assertion failure that occured when custom 'operator new[]' return non-ElementRegion and 'c++-allocator-inlining' sets true.

MTC added a comment. In https://reviews.llvm.org/D37189#979795, @NoQ wrote: > Oh well, i guess i covered this in my recent patches anyway (esp. > r322787/https://reviews.llvm.org/D41406). Sorry, i just fixed everything > differently and it became unclear how to integrate your patch into the who

r322808 - Update for llvm change.

Author: rafael Date: Wed Jan 17 18:08:38 2018 New Revision: 322808 URL: http://llvm.org/viewvc/llvm-project?rev=322808&view=rev Log: Update for llvm change. Modified: cfe/trunk/test/OpenMP/target_codegen_registration.cpp cfe/trunk/test/OpenMP/target_parallel_codegen_registration.cpp c

[PATCH] D37189: Fix an assertion failure that occured when custom 'operator new[]' return non-ElementRegion and 'c++-allocator-inlining' sets true.

NoQ added a comment. Oh well, i guess i covered this in my recent patches anyway (esp. r322787/https://reviews.llvm.org/D41406). Sorry, i just fixed everything differently and it became unclear how to integrate your patch into the whole thing. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

rsmith added a comment. Please take a look at http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0588r1.html, which respecifies the rules for lambda capture and its interaction with default arguments, and has been voted into the C++ working paper as a defect report resolution. The approa

[PATCH] D42106: [analyzer] Remove the useless method declararion 'BugReporter::RemoveUnneededCalls()'.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322804: [analyzer] NFC: Remove unused method - BugReporter::RemoveUnneededCalls(). (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.l

r322804 - [analyzer] NFC: Remove unused method - BugReporter::RemoveUnneededCalls().

Author: dergachev Date: Wed Jan 17 17:40:31 2018 New Revision: 322804 URL: http://llvm.org/viewvc/llvm-project?rev=322804&view=rev Log: [analyzer] NFC: Remove unused method - BugReporter::RemoveUnneededCalls(). Patch by Henry Wong! Differential Revision: https://reviews.llvm.org/D42106 Modified

[PATCH] D42221: [analyzer] NFC: See if existing C++ tests work with custom operator new().

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. NoQ added a dependency: D42219: [analyzer] Enable c++-allocator-inlining by default?. In order to provide more test coverage for inlined `ope

[PATCH] D42192: [analyzer] Assume that the allocated value is non-null before construction, not after.

NoQ updated this revision to Diff 130335. NoQ added a comment. Use `auto`. https://reviews.llvm.org/D42192 Files: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp test/Analysis/new-ctor-conservative.cpp test/Analysis/new-ctor-null-throw.cpp test/Analysis/new-ctor-null.cpp Index: test/Analysis

[PATCH] D42192: [analyzer] Assume that the allocated value is non-null before construction, not after.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:516 +if (!ProtoType->isNothrow(getContext())) + State = State->assume(RetVal.castAs(), true); +} george.karpenkov wrote: >

[PATCH] D42219: [analyzer] Enable c++-allocator-inlining by default?

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Once https://reviews.llvm.org/D42192 lands, i believe it should be safe to flip the default value of `-analyzer-config c++-allocator-inlining

[PATCH] D42015: [analyzer] NFC: RetainCount: Don't dump() regions to the user.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322799: [analyzer] NFC: RetainCount: Protect from dumping raw region to path notes. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D42015 Files: lib/StaticAnal

r322799 - [analyzer] NFC: RetainCount: Protect from dumping raw region to path notes.

Author: dergachev Date: Wed Jan 17 17:01:56 2018 New Revision: 322799 URL: http://llvm.org/viewvc/llvm-project?rev=322799&view=rev Log: [analyzer] NFC: RetainCount: Protect from dumping raw region to path notes. MemRegion::getString() is a wrapper around MemRegion::dump(), which is not user-frien

[PATCH] D41935: [analyzer] NFC: Mark default constructors for ProgramPoints.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322798: [analyzer] NFC: Use "= default" for default ProgramPoint constructors. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D41935: [analyzer] NFC: Mark default constructors for ProgramPoints.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322798: [analyzer] NFC: Use "= default" for default ProgramPoint constructors. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41935 Files: include/clang/Analy

r322798 - [analyzer] NFC: Use "= default" for default ProgramPoint constructors.

Author: dergachev Date: Wed Jan 17 16:55:29 2018 New Revision: 322798 URL: http://llvm.org/viewvc/llvm-project?rev=322798&view=rev Log: [analyzer] NFC: Use "= default" for default ProgramPoint constructors. Differential Revision: https://reviews.llvm.org/D41935 Modified: cfe/trunk/include/cl

[PATCH] D41934: [analyzer] Fix CXXNewExpr callback order.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322797: [analyzer] operator new: Fix callback order for CXXNewExpr. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41934 Files: lib/StaticAnalyzer/Checkers/An

r322797 - [analyzer] operator new: Fix callback order for CXXNewExpr.

Author: dergachev Date: Wed Jan 17 16:53:50 2018 New Revision: 322797 URL: http://llvm.org/viewvc/llvm-project?rev=322797&view=rev Log: [analyzer] operator new: Fix callback order for CXXNewExpr. PreStmt was never called. Additionally, under c++-allocator-inlining=true, PostStmt was called twice

[PATCH] D41800: [analyzer] Use a custom program point for the check::NewAllocator callback.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322796: [analyzer] operator new: Add a new ProgramPoint for check::NewAllocator. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41800 Files: include/clang/Ana

r322796 - [analyzer] operator new: Add a new ProgramPoint for check::NewAllocator.

Author: dergachev Date: Wed Jan 17 16:50:19 2018 New Revision: 322796 URL: http://llvm.org/viewvc/llvm-project?rev=322796&view=rev Log: [analyzer] operator new: Add a new ProgramPoint for check::NewAllocator. Add PostAllocatorCall program point to represent the moment in the analysis between the

[PATCH] D42217: Set Module Metadata "AvoidPLT" when -fno-plt is used.

tmsriram created this revision. tmsriram added reviewers: rnk, rafael. Set Module Metadata "AvoidPLT" when -fno-plt is used. Please see: https://reviews.llvm.org/D42216 for more details. This allows processing of calls to intrinsics easily. https://reviews.llvm.org/D42217 Files: lib/CodeGen

[PATCH] D41797: [analyzer] Suppress escape of this-pointer during construction.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322795: [analyzer] Suppress "this" pointer escape during construction. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41797 Files: lib/StaticAnalyzer/Core/Cal

r322795 - [analyzer] Suppress "this" pointer escape during construction.

Author: dergachev Date: Wed Jan 17 16:44:41 2018 New Revision: 322795 URL: http://llvm.org/viewvc/llvm-project?rev=322795&view=rev Log: [analyzer] Suppress "this" pointer escape during construction. Pointer escape event notifies checkers that a pointer can no longer be reliably tracked by the ana

[PATCH] D42208: Use an enum value instead of an string

espindola added a comment. 322792 https://reviews.llvm.org/D42208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r322769 - [RISCV] Propagate -mabi and -march values to GNU assembler.

With this I am getting a test failure on linux: TEST 'Clang :: Driver/riscv-gnutools.c' FAILED Script: -- /home/admin/llvm/build/bin/clang -target riscv32-linux-unknown-elf -fno-integrated-as --gcc-toolchain=/home/admin/llvm/llvm-project/clang/test/Dri

[libcxx] r322794 - libcxx: Define set_unexpected, _get_unexpected and __uncaught_exceptions without dllimport.

Author: pcc Date: Wed Jan 17 16:33:35 2018 New Revision: 322794 URL: http://llvm.org/viewvc/llvm-project?rev=322794&view=rev Log: libcxx: Define set_unexpected, _get_unexpected and __uncaught_exceptions without dllimport. It turns out that the MSVC headers define these functions without dllimpor

[PATCH] D42213: [ASTMatchers] [NFC] Fix code examples

MaskRay created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rC Clang https://reviews.llvm.org/D42213 Files: include/clang/ASTMatchers/ASTMatchers.h Index: include/clang/ASTMatchers/ASTMatchers.h =

r322792 - Use an enum value instead of a string.

Author: rafael Date: Wed Jan 17 16:20:03 2018 New Revision: 322792 URL: http://llvm.org/viewvc/llvm-project?rev=322792&view=rev Log: Use an enum value instead of a string. The old StringSwitch use was also broken. It assumed that a StringSwitch returns Optional instead of T and was missing a .Def

Re: r322769 - [RISCV] Propagate -mabi and -march values to GNU assembler.

Hi, Looks like the test is failing on MacOS [1]. Could you please take a look? Thanks, Michael [1] http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/45726/consoleFull#9955924438254eaf0-7326-4999-85b0-388101f2d404

[PATCH] D41409: [analyzer] Fix intermediate diagnostics on paths that go through operator new().

This revision was automatically updated to reflect the committed changes. Closed by commit rC322791: [analyzer] operator new: Fix path diagnostics around the operator call. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41409 Files: lib/StaticAnalyzer

r322791 - [analyzer] operator new: Fix path diagnostics around the operator call.

Author: dergachev Date: Wed Jan 17 16:10:21 2018 New Revision: 322791 URL: http://llvm.org/viewvc/llvm-project?rev=322791&view=rev Log: [analyzer] operator new: Fix path diagnostics around the operator call. Implements finding appropriate source locations for intermediate diagnostic pieces in pat

[PATCH] D41408: [analyzer] NFC: Fix nothrow operator new definition in a test.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322790: [analyzer] NFC: operator new: Fix new(nothrow) definition in tests. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

r322790 - [analyzer] NFC: operator new: Fix new(nothrow) definition in tests.

Author: dergachev Date: Wed Jan 17 16:03:43 2018 New Revision: 322790 URL: http://llvm.org/viewvc/llvm-project?rev=322790&view=rev Log: [analyzer] NFC: operator new: Fix new(nothrow) definition in tests. Fix the const qualifier so that the operator defined in the tests indeed does override the de

[PATCH] D42208: Use an enum value instead of an string

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good! https://reviews.llvm.org/D42208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D41406: [analyzer] Add a new checker callback, check::NewAllocator.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322787: [analyzer] operator new: Add a new checker callback, check::NewAllocator. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D41406?vs=129369&id=130304#toc

[PATCH] D42208: Use an enum value instea of an string

espindola created this revision. espindola added reviewers: rnk, rsmith. The old StringSwitch use was also broken. It assumed that a StringSwitch returns Optional instead of T and was missing a .Default. https://reviews.llvm.org/D42208 Files: clang/include/clang/Frontend/CodeGenOptions.h

r322787 - [analyzer] operator new: Add a new checker callback, check::NewAllocator.

Author: dergachev Date: Wed Jan 17 15:46:13 2018 New Revision: 322787 URL: http://llvm.org/viewvc/llvm-project?rev=322787&view=rev Log: [analyzer] operator new: Add a new checker callback, check::NewAllocator. The callback runs after operator new() and before the construction and allows the check

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

vsk added reviewers: akyrtzi, benlangmuir. vsk added inline comments. Comment at: tools/c-index-test/c-index-test.c:3268 - filename = clang_getFileName(file); - index_data->main_filename = clang_getCString(filename); - clang_disposeString(filename); + index_data->main_filen

r322783 - [ASTMatchers] Support generating docs for single-line matchers

Author: d0k Date: Wed Jan 17 15:14:49 2018 New Revision: 322783 URL: http://llvm.org/viewvc/llvm-project?rev=322783&view=rev Log: [ASTMatchers] Support generating docs for single-line matchers clang-format likes this format. PR35989. Modified: cfe/trunk/docs/tools/dump_ast_matchers.py cf

r322781 - [analyzer] operator new: Fix ambigious type name.

Author: dergachev Date: Wed Jan 17 15:03:25 2018 New Revision: 322781 URL: http://llvm.org/viewvc/llvm-project?rev=322781&view=rev Log: [analyzer] operator new: Fix ambigious type name. Hopefully fixes an MSVC buildbot failure. Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp Modi

[PATCH] D41266: [analyzer] With c++-allocator-inlining, fix memory space for operator new pointers.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322780: [analyzer] operator new: Fix memory space for the returned region. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41266 Files: lib/StaticAnalyzer/Core

r322780 - [analyzer] operator new: Fix memory space for the returned region.

Author: dergachev Date: Wed Jan 17 14:58:35 2018 New Revision: 322780 URL: http://llvm.org/viewvc/llvm-project?rev=322780&view=rev Log: [analyzer] operator new: Fix memory space for the returned region. Make sure that with c++-allocator-inlining=true we have the return value of conservatively eva

r322779 - [Sema] Allow conversion between long double and __float128.

Author: d0k Date: Wed Jan 17 14:56:57 2018 New Revision: 322779 URL: http://llvm.org/viewvc/llvm-project?rev=322779&view=rev Log: [Sema] Allow conversion between long double and __float128. We should only ban this if long double is a double double. x86's 80 bit long double is fine and supported b

[PATCH] D41523: xmmintrin.h documentation fixes and updates

This revision was automatically updated to reflect the committed changes. Closed by commit rC322778: [DOXYGEN] Fix doxygen and content issues in xmmintrin.h (authored by dyung, committed by ). Repository: rC Clang https://reviews.llvm.org/D41523 Files: lib/Headers/xmmintrin.h Index: lib/He

r322778 - [DOXYGEN] Fix doxygen and content issues in xmmintrin.h

Author: dyung Date: Wed Jan 17 14:53:15 2018 New Revision: 322778 URL: http://llvm.org/viewvc/llvm-project?rev=322778&view=rev Log: [DOXYGEN] Fix doxygen and content issues in xmmintrin.h - Fix inaccurate instruction listings. - Fix small issues in _mm_getcsr and _mm_setcsr. - Fix description of

[PATCH] D41250: [analyzer] Model implied cast around operator new().

This revision was automatically updated to reflect the committed changes. Closed by commit rC322777: [analyzer] operator new: Model the cast of returned pointer into object type. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41250 Files: lib/StaticAn

r322777 - [analyzer] operator new: Model the cast of returned pointer into object type.

Author: dergachev Date: Wed Jan 17 14:51:19 2018 New Revision: 322777 URL: http://llvm.org/viewvc/llvm-project?rev=322777&view=rev Log: [analyzer] operator new: Model the cast of returned pointer into object type. According to [basic.stc.dynamic.allocation], the return type of any C++ overloaded

[libcxx] r322776 - Fix nodiscard failure tests on compilers w/o -verify.

Author: ericwf Date: Wed Jan 17 14:48:09 2018 New Revision: 322776 URL: http://llvm.org/viewvc/llvm-project?rev=322776&view=rev Log: Fix nodiscard failure tests on compilers w/o -verify. Previously .fail.cpp tests for nodiscard were run with -Wunused-result being a warning, not an error, when the

[PATCH] D40925: Add option -fkeep-static-consts

rnk added a comment. OK. My concern is that users need to use `__attribute__((used))` or something more robust if they want SVN identifiers to reliably appear in the output. Adding this flag just creates a trap that will fail once they turn on `-O2`. I'd rather not have it in the interface to a

[PATCH] D40939: [analyzer] NFC: Avoid element regions of void type.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322775: [analyzer] NFC: Forbid array elements of void type. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D40939 Files: include/clang/StaticAnalyzer/Core/Path

r322775 - [analyzer] NFC: Forbid array elements of void type.

Author: dergachev Date: Wed Jan 17 14:40:36 2018 New Revision: 322775 URL: http://llvm.org/viewvc/llvm-project?rev=322775&view=rev Log: [analyzer] NFC: Forbid array elements of void type. Represent the symbolic value for results of pointer arithmetic on void pointers in a different way: instead o

[PATCH] D40560: [analyzer] Get construction into `operator new` running in simple cases.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322774: [analyzer] operator new: Use the correct region for the constructor. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

r322774 - [analyzer] operator new: Use the correct region for the constructor.

Author: dergachev Date: Wed Jan 17 14:34:23 2018 New Revision: 322774 URL: http://llvm.org/viewvc/llvm-project?rev=322774&view=rev Log: [analyzer] operator new: Use the correct region for the constructor. The -analyzer-config c++-allocator-inlining experimental option allows the analyzer to reaso

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

apazos added a comment. Committed R322769 Repository: rL LLVM https://reviews.llvm.org/D41271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r322769 - [RISCV] Propagate -mabi and -march values to GNU assembler.

Author: apazos Date: Wed Jan 17 14:09:58 2018 New Revision: 322769 URL: http://llvm.org/viewvc/llvm-project?rev=322769&view=rev Log: [RISCV] Propagate -mabi and -march values to GNU assembler. When using -fno-integrated-as flag, the gnu assembler produces code with some default march/mabi which l

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322769: [RISCV] Propagate -mabi and -march values to GNU assembler. (authored by apazos, committed by ). Changed prior to commit: https://reviews.llvm.org/D41271?vs=129981&id=130272#toc Repository: r

[libcxxabi] r322768 - Fix standalone test-suite run.

Author: ericwf Date: Wed Jan 17 14:07:09 2018 New Revision: 322768 URL: http://llvm.org/viewvc/llvm-project?rev=322768&view=rev Log: Fix standalone test-suite run. This patch updates libc++abi's HandleOutOfTreeLLVM.cmake to match libc++'s -- and more importantly, to fix a bug where llvm-lit wasn'

[PATCH] D41963: [clang-tidy] Adding Fuchsia checker for thread local storage.

juliehockett abandoned this revision. juliehockett added a comment. After some discussion, we decided that the false positive risk for non-kernel code isn't worth the check. https://reviews.llvm.org/D41963 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

apazos added a comment. Thanks for the clarifications Alex. No need to fix these known issues right now. I will proceed with checking in this change. https://reviews.llvm.org/D41271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[libclc] r322763 - rootn: Port from amd_builtins

Author: jvesely Date: Wed Jan 17 13:22:14 2018 New Revision: 322763 URL: http://llvm.org/viewvc/llvm-project?rev=322763&view=rev Log: rootn: Port from amd_builtins Passes piglit on turks and carrizo fp64 passes ctx on carrizo v2: fix formatting check fp32 denormal support at runtime Reviewe

[libclc] r322761 - pown: Port from amd_builtins

Author: jvesely Date: Wed Jan 17 13:22:03 2018 New Revision: 322761 URL: http://llvm.org/viewvc/llvm-project?rev=322761&view=rev Log: pown: Port from amd_builtins Passes piglit on turks and carrizo fp64 passes CTS on carrizo v2: fix formatting check fp32 denormal support at runtime Reviewer

[libclc] r322762 - powr: Port from amd_builtins

Author: jvesely Date: Wed Jan 17 13:22:06 2018 New Revision: 322762 URL: http://llvm.org/viewvc/llvm-project?rev=322762&view=rev Log: powr: Port from amd_builtins Passes piglit on turks and carrizo fp64 passes cts on carrizo v2: fix formatting check fp32 denormal support at runtime Reviewer

[libclc] r322760 - pow: Port from amd_builtins

Author: jvesely Date: Wed Jan 17 13:21:35 2018 New Revision: 322760 URL: http://llvm.org/viewvc/llvm-project?rev=322760&view=rev Log: pow: Port from amd_builtins Passes piglit on turks and carrizo fp64 passes CTS on carrizo v2: fix formatting check fp32 denormal support at runtime Reviewer:

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322759: [clang-tidy] Adding Fuchsia checker for trailing returns (authored by juliehockett, committed by ). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42116 Files: clang-tidy/fuc

[clang-tools-extra] r322759 - [clang-tidy] Adding Fuchsia checker for trailing returns

Author: juliehockett Date: Wed Jan 17 13:18:15 2018 New Revision: 322759 URL: http://llvm.org/viewvc/llvm-project?rev=322759&view=rev Log: [clang-tidy] Adding Fuchsia checker for trailing returns Adds a check to the Fuchsia module to warn if a function has a trailing return. See https://fuchsia.

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

This revision was automatically updated to reflect the committed changes. Closed by commit rL322759: [clang-tidy] Adding Fuchsia checker for trailing returns (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://reviews.llvm.

[PATCH] D42155: [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the helper is used consistently

This revision was automatically updated to reflect the committed changes. Closed by commit rC322753: [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https:

r322753 - [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the helper is used consistently

Author: george.karpenkov Date: Wed Jan 17 12:27:29 2018 New Revision: 322753 URL: http://llvm.org/viewvc/llvm-project?rev=322753&view=rev Log: [analyzer] introduce getSVal(Stmt *) helper on ExplodedNode, make sure the helper is used consistently In most cases using `N->getState()->getSVal(E, N->

[PATCH] D42140: [analyzer] Make isSubRegionOf reflexive

This revision was automatically updated to reflect the committed changes. Closed by commit rC322752: [analyzer] Make isSubRegionOf reflexive (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D42140 Files: inc

[PATCH] D40560: [analyzer] Get construction into `operator new` running in simple cases.

NoQ updated this revision to Diff 130249. NoQ added a comment. Remove pointer casts from the newly added symbolic index test, because once we properly perform the cast of the allocated value (as in https://reviews.llvm.org/D41250), our solver would blow up. https://reviews.llvm.org/D40560 Fil

r322752 - [analyzer] Make isSubRegionOf reflexive

Author: george.karpenkov Date: Wed Jan 17 12:27:26 2018 New Revision: 322752 URL: http://llvm.org/viewvc/llvm-project?rev=322752&view=rev Log: [analyzer] Make isSubRegionOf reflexive All usages of isSubRegionOf separately check for reflexive case, and in any case, set theory tells us that each se

r322750 - [analyzer] Better UI in html reports for displaying shortcuts help

Author: george.karpenkov Date: Wed Jan 17 12:06:26 2018 New Revision: 322750 URL: http://llvm.org/viewvc/llvm-project?rev=322750&view=rev Log: [analyzer] Better UI in html reports for displaying shortcuts help Make the help window accessible, but don't show by default. Use a different CSS class f

[PATCH] D42189: [clang-format] Replace unordered_set with an array

This revision was automatically updated to reflect the committed changes. Closed by commit rL322749: [clang-format] Replace unordered_set with an array (authored by krasimir, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42189 Files:

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! If you felt so inclined, I would say those two AST matchers would both be reasonable candidates to add to ASTMatchers.h if you wanted to do that in a follow-up patch. htt

r322749 - [clang-format] Replace unordered_set with an array

Author: krasimir Date: Wed Jan 17 12:01:02 2018 New Revision: 322749 URL: http://llvm.org/viewvc/llvm-project?rev=322749&view=rev Log: [clang-format] Replace unordered_set with an array Summary: This replaces an unordered_set from r322690 with an array and binary search. Reviewers: bkramer, ben

[PATCH] D40560: [analyzer] Get construction into `operator new` running in simple cases.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:487 +if (const MemRegion *MR = I.second.getAsRegion()) + SymReaper.markElementIndicesLive(MR); + } dcoughlin wrote: > Do we have a test for the MemRegion case? Commenting it o

[PATCH] D40560: [analyzer] Get construction into `operator new` running in simple cases.

NoQ updated this revision to Diff 130243. NoQ marked 2 inline comments as done. NoQ added a comment. Address the final comments. https://reviews.llvm.org/D40560 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngine.cpp lib/StaticAnalyzer/Co

[PATCH] D42189: [clang-format] Replace unordered_set with an array

bkramer accepted this revision. bkramer added a comment. lgtm Repository: rC Clang https://reviews.llvm.org/D42189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42192: [analyzer] Assume that the allocated value is non-null before construction, not after.

NoQ added a comment. Forgot to mention that this patch follows the tradition of duplicating code from `VisitCXXNewExpr()` to `VisitCXXNewAllocatorCall()` - until we enable `c++-allocator-inlining` by default and clean away the old mode support from `VisitCXXNewExpr()` (which would become pretty

[PATCH] D41039: Add support for attribute "trivial_abi"

ahatanak added a comment. I think I've addressed all the review comments. Any other comments from anyone? https://reviews.llvm.org/D41039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D42192: [analyzer] Assume that the allocated value is non-null before construction, not after.

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:514 + QualType Ty = FD->getType(); + if (const FunctionProtoType *ProtoType = Ty->getAs()) +if (!ProtoType->isNothrow(getContext())) auto? ==

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130242. juliehockett added a comment. Rebasing and updating decltypeType matcher https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/TrailingReturnCheck.cpp clang-

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL322746: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

r322746 - [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

Author: lebedevri Date: Wed Jan 17 11:40:55 2018 New Revision: 322746 URL: http://llvm.org/viewvc/llvm-project?rev=322746&view=rev Log: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations Reviewers: aaron.ballman Reviewed By: aaron.ballman Subscribers: dblaikie, klimek, cfe-c

[PATCH] D42146: libcxx: Disable CFI in function std::get_temporary_buffer.

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX322744: libcxx: Disable CFI in function std::get_temporary_buffer. (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D42146?vs

[libcxx] r322744 - libcxx: Disable CFI in function std::get_temporary_buffer.

Author: pcc Date: Wed Jan 17 11:32:35 2018 New Revision: 322744 URL: http://llvm.org/viewvc/llvm-project?rev=322744&view=rev Log: libcxx: Disable CFI in function std::get_temporary_buffer. The specification of this function mandates a cast to uninitialized T*, which is forbidden under CFI. Diffe

[PATCH] D41788: [DeclPrinter] Fix two cases that crash clang -ast-print.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322742: [DeclPrinter] Fix two cases that crash clang -ast-print. (authored by tra, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D41788?vs=12

[PATCH] D42189: [clang-format] Replace unordered_set with an array

krasimir updated this revision to Diff 130232. krasimir added a comment. - Add comment Repository: rC Clang https://reviews.llvm.org/D42189 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp === --- lib/Format/Format.

r322742 - [DeclPrinter] Fix two cases that crash clang -ast-print.

Author: tra Date: Wed Jan 17 11:29:39 2018 New Revision: 322742 URL: http://llvm.org/viewvc/llvm-project?rev=322742&view=rev Log: [DeclPrinter] Fix two cases that crash clang -ast-print. Both are related to handling anonymous structures. * clang didn't handle () around an anonymous struct variabl

[PATCH] D41455: [ASTMatchers] Add isNoReturn() match narrower for FunctionDeclarations

aaron.ballman added a comment. Great, looks good to commit. Thanks, Roman! Repository: rC Clang https://reviews.llvm.org/D41455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/TrailingReturnCheck.cpp:25 + +AST_TYPE_MATCHER(DecltypeType, decltypeType); + Good try, but if you rebase, you'll find that this macro has gone away entirely in r322687. I believe this macro was

  1   2   3   >