Author: chandlerc
Date: Tue Dec 26 21:46:53 2017
New Revision: 321469
URL: http://llvm.org/viewvc/llvm-project?rev=321469&view=rev
Log:
There is no portable format string for printing `uintptr_t` values.
Instead, cast them to `void *` which has a portable format string syntax
of `%p`.
This fixes
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
coby updated this revision to Diff 128185.
coby added a comment.
turning aes off forbids enabling vaes
Repository:
rC Clang
https://reviews.llvm.org/D41583
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
l
coby updated this revision to Diff 128183.
coby added a comment.
turning off pclmul forbids enabling vpclmulqdq
Repository:
rC Clang
https://reviews.llvm.org/D41573
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/
I see. agreed. Will upload shortly
From: Craig Topper [mailto:craig.top...@gmail.com]
Sent: Tuesday, December 26, 2017 19:52
To: reviews+d41583+public+5c6eea8282599...@reviews.llvm.org
Cc: cfe-commits@lists.llvm.org; Tayree, Coby ;
mgo...@gentoo.org
Subject: Re: [PATCH] D41583: [x86][icelake][vae
coby added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:577
} else if (Name == "pclmul") {
if (Enabled)
setSSELevel(Features, SSE2, Enabled);
craig.topper wrote:
> I think we should disable vpclmulqdq when pclmul is being disabled.
agreed
r321457. Happy new year!
--paulr
> -Original Message-
> From: Kim Gräsman [mailto:kim.gras...@gmail.com]
> Sent: Tuesday, December 26, 2017 1:56 AM
> To: Robinson, Paul
> Cc: cfe-commits
> Subject: Re: r321312 - [AST] Incorrectly qualified unscoped enumeration as
> template actual paramet
Author: probinson
Date: Tue Dec 26 10:01:19 2017
New Revision: 321457
URL: http://llvm.org/viewvc/llvm-project?rev=321457&view=rev
Log:
Fix comment typo in r321312.
Post-commit review by Kim Grasman!
Modified:
cfe/trunk/lib/AST/Decl.cpp
Modified: cfe/trunk/lib/AST/Decl.cpp
URL:
http://llvm.
craig.topper requested changes to this revision.
craig.topper added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Basic/Targets/X86.cpp:577
} else if (Name == "pclmul") {
if (Enabled)
setSSELevel(Features, SSE2, Enabled);
-
I meant if the command line says “-mvaes -mno-aes” we should make sure to
disable vaes
On Tue, Dec 26, 2017 at 9:47 AM coby via Phabricator <
revi...@reviews.llvm.org> wrote:
> coby added inline comments.
>
>
>
> Comment at: lib/Basic/Targets/X86.cpp:573
> setMMXLevel(Featur
coby added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:573
setMMXLevel(Features, AMD3DNowAthlon, Enabled);
} else if (Name == "aes") {
if (Enabled)
craig.topper wrote:
> Shouldn't -aes imply -vaes?
how come? perhaps i'm missing here someth
craig.topper added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:573
setMMXLevel(Features, AMD3DNowAthlon, Enabled);
} else if (Name == "aes") {
if (Enabled)
Shouldn't -aes imply -vaes?
Repository:
rC Clang
https://reviews.llvm.org/D415
craig.topper added inline comments.
Comment at: test/CodeGen/gfni-builtins.c:45
+
+#ifdef AVX512
+__m512i test_mm512_gf2p8affineinv_epi64_epi8(__m512i A, __m512i B) {
craig.topper wrote:
> Doesn't the define have underscores around it?
Oh its your own define. You
craig.topper added inline comments.
Comment at: test/CodeGen/gfni-builtins.c:45
+
+#ifdef AVX512
+__m512i test_mm512_gf2p8affineinv_epi64_epi8(__m512i A, __m512i B) {
Doesn't the define have underscores around it?
Repository:
rC Clang
https://reviews.llvm.or
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41557
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
coby updated this revision to Diff 128172.
coby added a comment.
tests
Repository:
rC Clang
https://reviews.llvm.org/D41557
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
lib/Headers/CMakeLists.txt
lib/
coby updated this revision to Diff 128171.
coby added a comment.
addressed comments
Repository:
rC Clang
https://reviews.llvm.org/D41557
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
lib/Headers/CMakeLis
coby marked 2 inline comments as done.
coby added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:589
+// Enable BWI instruction if VBMI/VBMI2 is being enabled.
+if (Name.startswith("avx512vbmi") && Enabled)
Features["avx512bw"] = true;
crai
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for vaes instructions, matching a similar work on the
backend (https://reviews.llvm.org/D40078)
Repository:
rC Clang
https://reviews.llvm.org/D41583
Files:
include/
coby updated this revision to Diff 128168.
coby added a comment.
add forgotten undef[s]
Repository:
rC Clang
https://reviews.llvm.org/D41582
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
lib/Headers/CMak
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for gfni instructions, matching a similar work on the
backend (https://reviews.llvm.org/D40373)
Repository:
rC Clang
https://reviews.llvm.org/D41582
Files:
include/
This broke a test case in IWYU, so I read the diff a few times more
than usual...
On Thu, Dec 21, 2017 at 10:47 PM, Paul Robinson via cfe-commits
wrote:
>
>// scope of the enumeration.
> - if (ED->isScoped() || ED->getIdentifier())
> + // For the case of unscoped enumerator, do
24 matches
Mail list logo
