ahatanak added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:442
Options.DebuggerTuning = CodeGenOpts.getDebuggerTuning();
+ Options.EnableStackProbe = CodeGenOpts.StackProbe;
Is there a reason you can't use function attributes
"probe-stack"="__
lichray updated this revision to Diff 125668.
lichray added a comment.
Rebased.
Repository:
rC Clang
https://reviews.llvm.org/D39412
Files:
lib/Driver/ToolChains/AMDGPU.cpp
lib/Driver/ToolChains/AVR.cpp
lib/Driver/ToolChains/Ananas.cpp
lib/Driver/ToolChains/BareMetal.cpp
lib/Driver
malaperle accepted this revision.
malaperle added a subscriber: sammccall.
malaperle added a comment.
This looks good to me. @ilya-biryukov, @sammccall Any objections?
I think we can do further iterations later to handle macros and other specific
cases (multiple Decls at the position, etc) . It'
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D39284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Author: rsmith
Date: Tue Dec 5 19:00:51 2017
New Revision: 319875
URL: http://llvm.org/viewvc/llvm-project?rev=319875&view=rev
Log:
Fix a bunch of wrong "tautological unsigned enum compare" diagnostics in C++.
An enumeration with a fixed underlying type can have any value in its
underlying type,
lichray updated this revision to Diff 125665.
lichray marked an inline comment as done.
lichray added a comment.
Added -Wbinding-in-condition.
Repository:
rC Clang
https://reviews.llvm.org/D39284
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/DeclSpec.h
lib/Parse/
lichray marked an inline comment as done.
lichray added inline comments.
Comment at: test/Misc/warning-flags.c:19
The list of warnings below should NEVER grow. It should gradually shrink to 0.
rsmith wrote:
> lichray wrote:
> > rsmith wrote:
> > > Please re
NoQ added a comment.
So we have an `ExplodedGraph`, in that there's an `ExplodedNode` against which
the report is being thrown, we have a bunch of `BugReporterVisitor`s that walk
from that node to the root of the graph and mark places they find interesting
with `PathDiagnosticPiece`s of differe
Gerolf added reviewers: dexonsmith, ahatanak, MatzeB.
Gerolf added a comment.
It looks pretty straightforward, but I'd ask (at least) Duncan or Akira, and
Matthias to review this more carefully.
-Gerolf
Repository:
rC Clang
https://reviews.llvm.org/D40864
tra created this revision.
Herald added subscribers: hiraditya, sanjoy, jholewinski.
https://reviews.llvm.org/D40872
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/Headers/__clang_cuda_intrinsics.h
llvm/include/llvm/IR/IntrinsicsNVVM.td
llvm/lib/Target/NVPTX/NVPTXIntrinsics.
tra created this revision.
Herald added a subscriber: sanjoy.
https://reviews.llvm.org/D40871
Files:
clang/lib/Headers/__clang_cuda_intrinsics.h
Index: clang/lib/Headers/__clang_cuda_intrinsics.h
===
--- clang/lib/Headers/__clang
jdenny updated this revision to Diff 125640.
jdenny edited the summary of this revision.
jdenny added a comment.
This update includes all of Hal's suggestions.
I'm also thinking of converting prefix storage from a std::vector to a std::map
so that lookup should be faster during parsing.
https:
Author: rsmith
Date: Tue Dec 5 15:54:25 2017
New Revision: 319858
URL: http://llvm.org/viewvc/llvm-project?rev=319858&view=rev
Log:
P0722R2: The first parameter in an implicit call to a destroying operator
delete should be a cv-unqualified pointer to the deleted object.
Modified:
cfe/trunk/l
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:131
+
+ Finds cases where unsigned and signed integers are used together in
arithmetic expressions.
+ Unsigned integers wrap to 0 when overflowing while the behaviour of signed
integers
I
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:288
+// this-region of the parent stack frame).
+if (dyn_cast_or_null(LCtx->getParentMap().getParent(CE))) {
+ MemRegionManager &MRMgr = getSValBuilder().getRegionManager();
NoQ updated this revision to Diff 125629.
NoQ added a comment.
> Note that there is no constructor call here. This is aggregate
> initialization. And there's not really any part of this that's new, except
> that a class with base classes is now an a aggregate. You'll see the same
> kind of AS
aemerson created this revision.
Add a new -mstack-probe and -mno-stack-probe option to enable the generation of
stack probing functions on non-Windows platforms, if supported. This patch only
enables this for Darwin.
Repository:
rC Clang
https://reviews.llvm.org/D40864
Files:
include/cla
I missed that one, thanks!
Sorry about the breakages.
On 5 December 2017 at 15:04, Douglas Yung via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dyung
> Date: Tue Dec 5 15:04:12 2017
> New Revision: 319848
>
> URL: http://llvm.org/viewvc/llvm-project?rev=319848&view=rev
> Log:
> Fi
Author: dyung
Date: Tue Dec 5 15:04:12 2017
New Revision: 319848
URL: http://llvm.org/viewvc/llvm-project?rev=319848&view=rev
Log:
Fix another record-parsing-invocation.c test issue on Windows
Lit's env should be used before not. (Another case missed by the previous
commit)
Modified:
cfe/
rwols created this revision.
This translates diagnostics correctly between 0-based LSP columns, and 1-based
clang columns.
https://reviews.llvm.org/D40860
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-tools-extra/clangd/ClangdLSPServer.h
clang-tools-extra/clangd/ClangdUnit.cp
Nebiroth updated this revision to Diff 125619.
Nebiroth added a comment.
Added static_cast when unparsing
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38425
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clan
NoQ added a subscriber: rsmith.
NoQ added a comment.
A reply from @rsmith was accidentally lost:
> http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20171204/211785.html
(seems that phabricator cuts away all text below the first "On ...,
Such-and-such wrote:" line)
https://reviews.llvm.
JonasToth updated this revision to Diff 125614.
JonasToth added a comment.
- [Misc] remove iostream
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40854
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-t
Nebiroth marked an inline comment as done.
Nebiroth added inline comments.
Comment at: clangd/ClangdUnit.cpp:38
+class DelegatingPPCallbacks : public PPCallbacks {
+
ilya-biryukov wrote:
> What's the purpose of this class?
We need to be able to use a wrapper cl
JonasToth created this revision.
Herald added subscribers: cfe-commits, kbarton, xazax.hun, mgorny, nemanjai,
klimek.
This check implements rules ES.100 and ES.102 of the CppCoreGuidelines
forbidding to mix `signed` and `unsigned` integer types in arithmetic
expression.
It currently functions
Author: smeenai
Date: Tue Dec 5 13:49:56 2017
New Revision: 319840
URL: http://llvm.org/viewvc/llvm-project?rev=319840&view=rev
Log:
[CMake] Use PRIVATE in target_link_libraries for executables
We currently use target_link_libraries without an explicit scope
specifier (INTERFACE, PRIVATE or PUBL
Author: smeenai
Date: Tue Dec 5 13:49:56 2017
New Revision: 319840
URL: http://llvm.org/viewvc/llvm-project?rev=319840&view=rev
Log:
[CMake] Use PRIVATE in target_link_libraries for executables
We currently use target_link_libraries without an explicit scope
specifier (INTERFACE, PRIVATE or PUBL
jdenny added a comment.
In https://reviews.llvm.org/D40752#945572, @ABataev wrote:
> In https://reviews.llvm.org/D40752#945571, @jdenny wrote:
>
> > In https://reviews.llvm.org/D40752#945255, @ABataev wrote:
> >
> > > In https://reviews.llvm.org/D40752#945234, @jdenny wrote:
> > >
> > > > r319774
Author: arphaman
Date: Tue Dec 5 13:33:05 2017
New Revision: 319836
URL: http://llvm.org/viewvc/llvm-project?rev=319836&view=rev
Log:
Fix one more record-parsing-invocation.c test issue on Windows
Lit's env should be used before not.
Sean Eveson pointed out the right solution. Thanks!
Modified
I committed the fix in r319836.
On 5 December 2017 at 12:49, Alex L wrote:
> Thanks, I will take a look at it right now. I believe your solution is the
> right fix.
>
> On 5 December 2017 at 07:09, Sean Eveson wrote:
>
>> Hi,
>>
>> It looks like the test is still failing on one of the Windows b
Should be fixed in r319835. I'd forgotten that Darwin / MachO uses a
different mechanism from COMDATs here.
On 5 December 2017 at 13:27, Ahmed Bougacha via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Dec 5, 2017 at 11:40 AM, Richard Smith via cfe-commits
> wrote:
> > Sorry about t
Author: rsmith
Date: Tue Dec 5 13:29:36 2017
New Revision: 319835
URL: http://llvm.org/viewvc/llvm-project?rev=319835&view=rev
Log:
Use an even more precise triple to avoid errors on Darwin, where we don't use
comdats for inline entities.
Modified:
cfe/trunk/test/Modules/var-templates.cpp
On Tue, Dec 5, 2017 at 11:40 AM, Richard Smith via cfe-commits
wrote:
> Sorry about that, fixed in r319817.
Hey Richard,
Looks like that's not enough on darwin:
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/44764/consoleFull#-126347322349ba4694-19c4-4d7e-bec5-911270d8a
ABataev added a comment.
In https://reviews.llvm.org/D40752#945571, @jdenny wrote:
> In https://reviews.llvm.org/D40752#945255, @ABataev wrote:
>
> > In https://reviews.llvm.org/D40752#945234, @jdenny wrote:
> >
> > > r319774 works for my current use cases. Thanks.
> > >
> > > While we're on thi
jdenny added a comment.
In https://reviews.llvm.org/D40752#945255, @ABataev wrote:
> In https://reviews.llvm.org/D40752#945234, @jdenny wrote:
>
> > r319774 works for my current use cases. Thanks.
> >
> > While we're on this topic, do you happen to know the rationale behind the
> > OpenMP restr
Author: george.karpenkov
Date: Tue Dec 5 13:19:59 2017
New Revision: 319834
URL: http://llvm.org/viewvc/llvm-project?rev=319834&view=rev
Log:
[analyzer] do not crash on cases where an array subscript is an rvalue
Array subscript is almost always an lvalue, except for a few cases where
it is not,
NoQ added a comment.
In https://reviews.llvm.org/D40809#945551, @NoQ wrote:
> If you want to turn this into a form of user-facing analyzer output variant,
> you may want to implement it as a `PathDiagnosticConsumer` rather than a
> visitor.
Or maybe no, actually it's totally wrong, never mind
NoQ added a comment.
This looks great for understanding what exactly is going on in a large
real-world report.
If you want to turn this into a form of user-facing analyzer output variant,
you may want to implement it as a `PathDiagnosticConsumer` rather than a
visitor. If we only want a neat d
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319830: [libunwind][CMake] Set TARGET_TRIPLE if
LIBUNWND_TARGET_TRIPLE is set (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40820?vs=125458&id=125594#toc
Repository:
rL LLV
Thanks, I will take a look at it right now. I believe your solution is the
right fix.
On 5 December 2017 at 07:09, Sean Eveson wrote:
> Hi,
>
> It looks like the test is still failing on one of the Windows build bots:
> http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015
>
> From lookin
Author: phosek
Date: Tue Dec 5 12:48:05 2017
New Revision: 319830
URL: http://llvm.org/viewvc/llvm-project?rev=319830&view=rev
Log:
[libunwind][CMake] Set TARGET_TRIPLE if LIBUNWND_TARGET_TRIPLE is set
This follows the setup used by other runtimes and is expected by
the lit configuration.
Diffe
jdenny added a comment.
Comment at: lib/Frontend/CompilerInvocation.cpp:1095
+ if (Diags) {
+Diags->Report(diag::err_drv_invalid_value) << "-verify=" << Prefix;
+Diags->Report(diag::note_drv_verify_prefix_unique);
hfinkel wrote:
> jdenny w
nlewycky created this revision.
The way to fix an undefined-template warning is to add lines to the header file
that defines the template pattern. We should suppress the warnings when the
template pattern is in a system header because we don't expect users to edit
those.
https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319823: [libunwind] Pass LIBUNWIND_SYSROOT and
LIBUNWIND_GCC_TOOLCHAIN to lit (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40817?vs=125455&id=125590#toc
Repository:
rL LLV
Author: phosek
Date: Tue Dec 5 12:22:10 2017
New Revision: 319823
URL: http://llvm.org/viewvc/llvm-project?rev=319823&view=rev
Log:
[libunwind] Pass LIBUNWIND_SYSROOT and LIBUNWIND_GCC_TOOLCHAIN to lit
These are expected to be set by the shared lit scripts used from
libc++.
Differential Revisio
Author: sammccall
Date: Tue Dec 5 12:11:29 2017
New Revision: 319820
URL: http://llvm.org/viewvc/llvm-project?rev=319820&view=rev
Log:
[clangd] Clean up code complete unit tests. NFC
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified: clang-tools-extra/trunk/u
rsmith added inline comments.
Comment at: test/Misc/warning-flags.c:19
The list of warnings below should NEVER grow. It should gradually shrink to 0.
lichray wrote:
> rsmith wrote:
> > Please read and respect this rule :)
> Do you know of some categories wh
Sorry about that, fixed in r319817.
On 5 December 2017 at 10:38, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Richard,
>
> This commit broke tests on one of our bots:
>
> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-
> expensive-checks-win/builds/6568
>
> F
Author: rsmith
Date: Tue Dec 5 11:39:37 2017
New Revision: 319817
URL: http://llvm.org/viewvc/llvm-project?rev=319817&view=rev
Log:
Give this test a triple to avoid failures on MS bots.
Modified:
cfe/trunk/test/Modules/var-templates.cpp
Modified: cfe/trunk/test/Modules/var-templates.cpp
URL
hfinkel added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1095
+ if (Diags) {
+Diags->Report(diag::err_drv_invalid_value) << "-verify=" << Prefix;
+Diags->Report(diag::note_drv_verify_prefix_unique);
jdenny wrote:
> hfink
compnerd closed this revision.
compnerd added a comment.
SVN r319816
Repository:
rCXX libc++
https://reviews.llvm.org/D40660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phosek added a comment.
After some more digging through libc++ test suite, I think I understand now why
these are different variables. It may be possible to remove these and just rely
on plain CMake variables but this is likely going to require some more CMake
and lit surgery, so for now I'm go
Author: compnerd
Date: Tue Dec 5 11:32:49 2017
New Revision: 319816
URL: http://llvm.org/viewvc/llvm-project?rev=319816&view=rev
Log:
Enable auto-linking on Windows
The MSVC driver and clang do not link against the C++ runtime
explicitly. Instead, they rely on the auto-linking via the pragma
(t
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
I'm okay with this change in principle, but Im worried that this may break the
buildbots. Please ensure that they remain green after this change.
Repository:
rL LLVM
https://reviews.l
ABataev added a comment.
In https://reviews.llvm.org/D40752#945234, @jdenny wrote:
> r319774 works for my current use cases. Thanks.
>
> While we're on this topic, do you happen to know the rationale behind the
> OpenMP restriction for which err_omp_union_type_not_allowed diagnoses
> violation
Author: abataev
Date: Tue Dec 5 11:20:09 2017
New Revision: 319814
URL: http://llvm.org/viewvc/llvm-project?rev=319814&view=rev
Log:
[OPENMP] Fix implicit mapping analysis.
Fixed processing of implicitly mapped objects in target-based executable
directives.
Modified:
cfe/trunk/lib/Sema/Sema
rwols added a comment.
I will split this diff up into separate parts.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
lichray updated this revision to Diff 125581.
lichray added a comment.
Rebased.
Repository:
rC Clang
https://reviews.llvm.org/D39284
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/DeclSpec.h
lib/Parse/ParseExprCXX.cpp
lib/Sema/SemaDeclCXX.cpp
test/Misc/warning
yaxunl added a comment.
In https://reviews.llvm.org/D39739#945318, @b-sumner wrote:
> The usual rule is to take the first weak definition encountered.
Will this work for us? Usually we would like the last one to be linked.
Repository:
rL LLVM
https://reviews.llvm.org/D39739
Author: juliehockett
Date: Tue Dec 5 10:50:49 2017
New Revision: 319812
URL: http://llvm.org/viewvc/llvm-project?rev=319812&view=rev
Log:
Commit access test.
Modified:
clang-tools-extra/trunk/clang-tidy/fuchsia/FuchsiaTidyModule.cpp
Modified: clang-tools-extra/trunk/clang-tidy/fuchsia/Fuchs
Hello Richard,
This commit broke tests on one of our bots:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/6568
Failing Tests (3):
. . .
Clang :: Modules/var-templates.cpp
. . .
Please have a look?
Thanks
Galina
On Mon, Dec 4, 2017 at 5:31 PM, Richard Smit
b-sumner added a comment.
The usual rule is to take the first weak definition encountered.
Repository:
rL LLVM
https://reviews.llvm.org/D39739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
On 5 December 2017 at 09:08, Artem Dergachev via Phabricator via
cfe-commits wrote:
> NoQ created this revision.
> Herald added subscribers: cfe-commits, rnkovacs.
>
> Yet another situation where we cannot easily guess, by looking at the CFG,
> the target region for C++ constructor call.
>
> Cons
yaxunl added inline comments.
Comment at: lib/Transforms/IPO/FunctionImport.cpp:107
+static cl::opt
+ForceImportWeak("force-import-weak", cl::Hidden,
+cl::desc("Allow weak functions to be imported"),
AlexVlx wrote:
> yaxunl wrote:
> > Is it possib
twoh updated this revision to Diff 125564.
twoh added a comment.
clang-format
https://reviews.llvm.org/D39279
Files:
include/clang/Lex/Lexer.h
lib/Lex/Lexer.cpp
test/Preprocessor/macro_raw_string.cpp
unittests/Lex/LexerTest.cpp
Index: unittests/Lex/LexerTest.cpp
===
twoh updated this revision to Diff 125563.
twoh added a comment.
@jkorous-apple Got it. I agree that it would be better to move the comments to
the header. Will land it soon. Thanks!
https://reviews.llvm.org/D39279
Files:
include/clang/Lex/Lexer.h
lib/Lex/Lexer.cpp
test/Preprocessor/macr
bcraig added a comment.
Talked with mclow and some Microsoft devs in Albuquerque. I'm not expecting
include_next to show up in MSVC. Sometime in the next month I hope to rebase
this change.
https://reviews.llvm.org/D32411
___
cfe-commits mailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX319802: [libcxx] Fix intrinsics for MSVC (authored by
smeenai).
Repository:
rCXX libc++
https://reviews.llvm.org/D40774
Files:
include/algorithm
Index: include/algorithm
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319801: [WebAssembly] Don't use Wasm function sections for
more than one function (authored by djg).
Repository:
rC Clang
https://reviews.llvm.org/D40738
Files:
lib/Basic/Targets/OSTargets.h
test/
Author: smeenai
Date: Tue Dec 5 09:46:23 2017
New Revision: 319802
URL: http://llvm.org/viewvc/llvm-project?rev=319802&view=rev
Log:
[libcxx] Fix intrinsics for MSVC
The parameter was previously renamed but MSVC path was not updated.
Patch by Andrey Khalyavin.
Differential Revision: https://re
Author: djg
Date: Tue Dec 5 09:46:17 2017
New Revision: 319801
URL: http://llvm.org/viewvc/llvm-project?rev=319801&view=rev
Log:
[WebAssembly] Don't use Wasm function sections for more than one function
Patch by Nicholas Wilson!
Fixes PR35467.
Differential Revision: https://reviews.llvm.org/D4
JonasToth added a comment.
@sbenza and @klimek the issue that occurs here is probably ASTMatchers related,
thats why I added you.
The problem:
This patch introduces a stack overflow when building with `RelWithDebInfo` that
is caught by the sanitizers. I isolated the issue in the big switch sta
smeenai added a subscriber: bcraig.
smeenai added a comment.
In https://reviews.llvm.org/D40774#945254, @halyavin wrote:
> In https://reviews.llvm.org/D40774#944751, @smeenai wrote:
>
> > In https://reviews.llvm.org/D40774#944749, @halyavin wrote:
> >
> > > In https://reviews.llvm.org/D40774#9439
ABataev added a comment.
In https://reviews.llvm.org/D40752#945234, @jdenny wrote:
> r319774 works for my current use cases. Thanks.
>
> While we're on this topic, do you happen to know the rationale behind the
> OpenMP restriction for which err_omp_union_type_not_allowed diagnoses
> violation
juliehockett updated this revision to Diff 125560.
juliehockett marked 5 inline comments as done.
https://reviews.llvm.org/D40813
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/VirtualInheritanceCheck.cpp
clang-tidy/fuchsia/VirtualInhe
Author: abataev
Date: Tue Dec 5 09:41:34 2017
New Revision: 319800
URL: http://llvm.org/viewvc/llvm-project?rev=319800&view=rev
Log:
[OPENMP] Remove non-required parameters for distribute simd outlined
region, NFC.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/Sem
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:288
+// this-region of the parent stack frame).
+if (dyn_cast_or_null(LCtx->getParentMap().getParent(CE))) {
+ MemRegionManager &MRMgr = getSValBuilder().getRegionManager();
--
ABataev added a comment.
In https://reviews.llvm.org/D40752#945234, @jdenny wrote:
> r319774 works for my current use cases. Thanks.
>
> While we're on this topic, do you happen to know the rationale behind the
> OpenMP restriction for which err_omp_union_type_not_allowed diagnoses
> violation
halyavin added a comment.
In https://reviews.llvm.org/D40774#944751, @smeenai wrote:
> In https://reviews.llvm.org/D40774#944749, @halyavin wrote:
>
> > In https://reviews.llvm.org/D40774#943993, @smeenai wrote:
> >
> > > Are you actually using libc++ with cl? :)
> >
> >
> > People mostly use it
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D40838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
NoQ updated this revision to Diff 12.
NoQ added a comment.
Herald added a subscriber: rnkovacs.
Rebase on top of https://reviews.llvm.org/D39862 (attn. George!~).
https://reviews.llvm.org/D38801
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
lib/StaticAnalyzer/Che
krasimir updated this revision to Diff 125557.
krasimir added a comment.
- Make 'textproto' the canonical text proto delimiter for google style
Repository:
rC Clang
https://reviews.llvm.org/D40832
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Continua
JonasToth updated this revision to Diff 125556.
JonasToth retitled this revision from "[clang-tidy] WIP Resubmit
hicpp-multiway-paths-covered without breaking test " to "[clang-tidy] WIP
Resubmit hicpp-multiway-paths-covered without breaking test".
JonasToth added a comment.
Herald added a s
jdenny added a comment.
r319774 works for my current use cases. Thanks.
While we're on this topic, do you happen to know the rationale behind the
OpenMP restriction for which err_omp_union_type_not_allowed diagnoses
violations? I googled but couldn't find the rationale. If you would prefer
svenvh updated this revision to Diff 125554.
svenvh added a comment.
Introducing ASTContext::getOpenCLTypeAddrSpace(const Type *T) as suggested.
https://reviews.llvm.org/D40838
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/TargetInfo.h
lib/AST/ASTContext.cpp
lib/Basic/Target
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319793: [analyzer] Mark heap-based symbolic regions in debug
dumps. (authored by dergachev).
Repository:
rC Clang
https://reviews.llvm.org/D40793
Files:
lib/StaticAnalyzer/Core/MemRegion.cpp
Index
Author: dergachev
Date: Tue Dec 5 09:14:39 2017
New Revision: 319793
URL: http://llvm.org/viewvc/llvm-project?rev=319793&view=rev
Log:
[analyzer] Mark heap-based symbolic regions in debug dumps.
They are now printed as HeapSymRegion{$x} in order to discriminate between that
and regular SymRegion
NoQ updated this revision to Diff 125547.
NoQ added a comment.
Add a forgotten //no-warning.
https://reviews.llvm.org/D40841
Files:
lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
test/Analysis/initializer.cpp
Index: test/Analysis/initiali
NoQ created this revision.
Herald added subscribers: cfe-commits, rnkovacs.
Yet another situation where we cannot easily guess, by looking at the CFG, the
target region for C++ constructor call.
Consider the following brace initialization:
struct A {
A();
};
struct B : public A {
ilya-biryukov added a comment.
Additionally:
- All async methods now take `Context` by-value and pass it to their
`Callback`s or return them in `future`s.
- All sync methods take `Context` by-ref
In https://reviews.llvm.org/D40486#941210, @sammccall wrote:
> This is pretty bikesheddy, but I
ilya-biryukov planned changes to this revision.
ilya-biryukov added a comment.
Have to update to match the new `Context` implementation.
https://reviews.llvm.org/D40489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
ilya-biryukov updated this revision to Diff 125545.
ilya-biryukov added a comment.
Herald added a subscriber: klimek.
- Updated to match the new Context implementation.
- Logger is now stored in a global variable instead of the global Context.
- Removed json-specific RequestContext, now storing al
ilya-biryukov marked 6 inline comments as done.
ilya-biryukov added a comment.
A second attempt at implementing the `Context`s. Still missing a few comments,
but hopefully ready for review.
Comment at: clangd/Context.h:71
+/// before any clangd functions are called.
+class Glo
yaxunl added inline comments.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:41
uint32_t AddrSpc = CGM.getContext().getTargetAddressSpace(
- CGM.getTarget().getOpenCLTypeAddrSpace(T));
+ CGM.getTarget().getOpenCLTypeAddrSpace(TK));
switch (cast(T)->getKind()) {
-
ilya-biryukov updated this revision to Diff 125539.
ilya-biryukov added a comment.
Herald added a subscriber: klimek.
Addressed some review comments.
- Removed global context.
- Context now stores a shared_ptr to ContextData to handle lifetimes properly.
- Added helper getters for some commonly u
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319785: [clang-tidy] adjust cppcoreguidelines-owning-memory
documentation (authored by JonasToth).
Repository:
rL LLVM
https://reviews.llvm.org/D40829
Files:
clang-tools-extra/trunk/docs/clang-tidy
Author: jonastoth
Date: Tue Dec 5 08:37:49 2017
New Revision: 319785
URL: http://llvm.org/viewvc/llvm-project?rev=319785&view=rev
Log:
[clang-tidy] adjust cppcoreguidelines-owning-memory documentation
Summary:
A user of the check opened a bugreport and reported that `std::exchange`
triggers a fa
xgsa added a comment.
In https://reviews.llvm.org/D40671#944906, @alexfh wrote:
> BTW, how will this feature interact with cpplint.py's way of handling
> specific NOLINT directives that use different lint rule names, which
> sometimes refer to the same rule (e.g. `// NOLINT(runtime/explicit)`
JonasToth updated this revision to Diff 125536.
JonasToth added a comment.
- [Fix] typo
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40829
Files:
docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst
Index: docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst
=
JonasToth added a comment.
I agree.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 139 matches
Mail list logo
