Author: sammccall
Date: Mon Dec 4 23:34:35 2017
New Revision: 319742
URL: http://llvm.org/viewvc/llvm-project?rev=319742&view=rev
Log:
[clangd] Remove unused test param. NFC
Modified:
clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp
clang-tools-extra/trunk/unittests/clangd/CodeCo
smeenai added a comment.
In https://reviews.llvm.org/D40774#944749, @halyavin wrote:
> In https://reviews.llvm.org/D40774#943993, @smeenai wrote:
>
> > Are you actually using libc++ with cl? :)
>
>
> People mostly use it to compile on Windows but I heard someone launches the
> result too. Since
halyavin added a comment.
In https://reviews.llvm.org/D40774#943993, @smeenai wrote:
> Are you actually using libc++ with cl? :)
People mostly use it to compile on Windows but I heard someone launches the
result too. Since no one complains and it passed most of the testing, I guess
the result
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319741: [clangd] Split code-completion tests out of
ClangdTests. NFC. (authored by sammccall).
Repository:
rL LLVM
https://reviews.llvm.org/D40784
Files:
clang-tools-extra/trunk/clangd/CodeComplete.
Author: sammccall
Date: Mon Dec 4 23:20:26 2017
New Revision: 319741
URL: http://llvm.org/viewvc/llvm-project?rev=319741&view=rev
Log:
[clangd] Split code-completion tests out of ClangdTests. NFC.
Summary:
Common parts are mostly FS related, so pulled out TestFS.h for the common stuff.
Deliberat
sammccall added inline comments.
Comment at: unittests/clangd/CMakeLists.txt:16
JSONExprTests.cpp
+ TestFS.cpp
TraceTests.cpp
hokein wrote:
> nit: maybe name it FSTests.cpp? to be consistent with other test file names.
Ah, this is deliberately inconsistent
halyavin marked an inline comment as done.
halyavin added inline comments.
Comment at: src/support/runtime/exception_pointer_msvc.ipp:119-123
+#ifdef _M_AMD64
+RtlPcToFileHeader(
+reinterpret_cast(const_cast(throw_info)),
+&image_base);
+#endif
---
kc.austin2017 added a comment.
In https://reviews.llvm.org/D28820#944365, @efriedma wrote:
> > What is the best way to modify the code for this compiler change ?
>
> Currently, the "interrupt" attribute only has an effect on functions, not
> function pointers, so your code won't work the way you
Author: marshall
Date: Mon Dec 4 20:09:49 2017
New Revision: 319736
URL: http://llvm.org/viewvc/llvm-project?rev=319736&view=rev
Log:
Land D28253 which fixes PR28929 (which we mistakenly marked as fixed before)
Added:
libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.shared
mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 319736
https://reviews.llvm.org/D28253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Mon Dec 4 19:51:16 2017
New Revision: 319734
URL: http://llvm.org/viewvc/llvm-project?rev=319734&view=rev
Log:
Add issue 2587, which was missed
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llvm-
Author: arsenm
Date: Mon Dec 4 19:51:26 2017
New Revision: 319735
URL: http://llvm.org/viewvc/llvm-project?rev=319735&view=rev
Log:
AMDGPU: Don't add fp64 feature to r600 subtargets
Should fix test after r319709
Modified:
cfe/trunk/lib/Basic/Targets/AMDGPU.cpp
Modified: cfe/trunk/lib/Basic
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM. Ship it!
Repository:
rC Clang
https://reviews.llvm.org/D40793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
hfinkel added a comment.
I think this is a good idea.
Comment at: include/clang/Driver/CC1Options.td:407
def verify : Flag<["-"], "verify">,
- HelpText<"Verify diagnostic output using comment directives">;
+ HelpText<"Similar to -verify=expected">;
def verify_ignore_unexpec
rsmith added a comment.
I expect there are more places that need to be changed, but this is looking
surprisingly clean.
You will need to teach the modules merging code that it needs to check this
attribute in addition to checking that types match when considering merging
declaration chains for
Eugene.Zelenko added inline comments.
Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:42
+
+int main(void) {
+ A *a = new A(0);
void is redundant in C++. See modernize-redundant-void-arg.
https://reviews.llvm.org/D40813
_
Author: arphaman
Date: Mon Dec 4 18:30:43 2017
New Revision: 319729
URL: http://llvm.org/viewvc/llvm-project?rev=319729&view=rev
Log:
[libclang] Store unsaved file hashes when recording parsing invocations
Storing the contents of unsaved files is too expensive.
Instead a hash is stored with a re
bob.wilson accepted this revision.
bob.wilson added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1457-1465
if (iOSVersion && (getTriple().getArch() == llvm::Triple::x86 ||
getTriple().getAr
Ping - I have a pretty clear workaround internally, but still would be
happy to remove any workarounds given the opportunity.
As for layering. For now the issue is that libAST depends on libBasic, and
libraries can't have circular dependencies. Modular builds (well,
especially modular codegen, but
craig.topper added inline comments.
Comment at: include/clang/Basic/X86Target.def:148
/// Cannonlake client microarchitecture based processors.
PROC(Cannonlake, "cannonlake", PROC_64_BIT)
Cannonlake can prioritize off of VBMI or IFMA.
Comme
Author: rsmith
Date: Mon Dec 4 17:31:47 2017
New Revision: 319727
URL: http://llvm.org/viewvc/llvm-project?rev=319727&view=rev
Log:
Generalize "static data member instantiated" notification to cover variable
templates too.
While here, split the "point of instantiation changed" notification out
phosek created this revision.
Herald added a subscriber: mgorny.
This follows the setup used by other runtimes and is expected by the lit
configuration.
Repository:
rL LLVM
https://reviews.llvm.org/D40820
Files:
CMakeLists.txt
Index: CMakeLists.txt
==
jroelofs added a comment.
I think just remove it from them.
Repository:
rL LLVM
https://reviews.llvm.org/D40816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phosek added a comment.
Actually it seems to be missing in libunwind, but I see it in libc++abi and
libc++ (I missed that one). Do you want me to remove it from those two or add
it to libunwind? It's a little strange to be using both
`LIBUNWIND_TARGET_TRIPLE` and `TARGET_TRIPLE` in the same fil
erichkeane abandoned this revision.
erichkeane added a comment.
Completely superceededby this patch here: https://reviews.llvm.org/D40819
Since that one is a complete redesign/reimplementation, I'd prefer to do it
separately.
https://reviews.llvm.org/D38596
_
erichkeane created this revision.
GCC's attribute 'target', in addition to being an optimization hint,
also allows function multiversioning. We currently have the former
implemented, this is the latter's implementation.
This works by enabling functions with the same name/signature to coexist,
so
phosek created this revision.
These are expected to be set by the shared lit scripts used from libc++.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D40818
Files:
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
===
-
phosek created this revision.
These are expected to be set by the shared lit scripts used from libc++.
Repository:
rL LLVM
https://reviews.llvm.org/D40817
Files:
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
===
--- test/
jroelofs added a comment.
(i.e. you should delete that, since this is the last dependency on it AFAICT)
Repository:
rL LLVM
https://reviews.llvm.org/D40816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
jroelofs added a comment.
There's a: `set(TARGET_TRIPLE ...)` in each of these runtimes' CMakeLists.txt...
Repository:
rL LLVM
https://reviews.llvm.org/D40816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
phosek created this revision.
The variable representing target triple in libunwind is named
LIBUNWIND_TARGET_TRIPLE, not TARGET_TRIPLE.
Repository:
rL LLVM
https://reviews.llvm.org/D40816
Files:
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
phosek created this revision.
The variable representing target triple in libcxxabi is named
LIBCXXABI_TARGET_TRIPLE, not TARGET_TRIPLE.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D40815
Files:
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
phosek created this revision.
The variable representing target triple in libcxx is named
LIBCXX_TARGET_TRIPLE, not TARGET_TRIPLE.
Repository:
rCXX libc++
https://reviews.llvm.org/D40814
Files:
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
==
juliehockett added inline comments.
Comment at: test/clang-tidy/fuchsia-multiple-inheritance.cpp:48
+};
+
+// Inherits from multiple concrete classes.
aaron.ballman wrote:
> The virtual base test cases I was thinking of were:
> ```
> struct Base { virtual void fo
juliehockett updated this revision to Diff 125449.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D40580
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
clang-tidy/fuchsia/MultipleIn
juliehockett created this revision.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adds a check to the Fuchsia module to warn if classes are defined or created
with virtual inheritance.
See https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.m
phosek added a comment.
ping
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D40637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319720: [CMake] Don't use comma as an alternate separator
(authored by phosek).
Repository:
rC Clang
https://reviews.llvm.org/D40762
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
Author: phosek
Date: Mon Dec 4 16:15:20 2017
New Revision: 319720
URL: http://llvm.org/viewvc/llvm-project?rev=319720&view=rev
Log:
[CMake] Don't use comma as an alternate separator
Using comma can break in cases when we're passing flags that already
use comma as a separator.
Fixes PR35504.
Di
Author: eugenezelenko
Date: Mon Dec 4 15:38:10 2017
New Revision: 319716
URL: http://llvm.org/viewvc/llvm-project?rev=319716&view=rev
Log:
[Lex] Fix lldb-x86_64-ubuntu-14.04-buildserver build bot broken with r319714
(NFC).
Modified:
cfe/trunk/include/clang/Lex/PreprocessorLexer.h
Modified:
efriedma added a comment.
> What is the best way to modify the code for this compiler change ?
Currently, the "interrupt" attribute only has an effect on functions, not
function pointers, so your code won't work the way you want. It's a bug that
we don't emit a warning for this.
Currently, th
Author: arphaman
Date: Mon Dec 4 15:21:07 2017
New Revision: 319715
URL: http://llvm.org/viewvc/llvm-project?rev=319715&view=rev
Log:
Fix record-parsing-invocation.c test on Windows
We should not check for the forward slash '/'
Modified:
cfe/trunk/test/Index/record-parsing-invocation.c
Mod
cameron314 added inline comments.
Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365
cast(FD)->getParent(), ObjectType,
- ObjectClassification, Args.slice(1), CandidateSet,
+ ObjectClassification, F
Author: eugenezelenko
Date: Mon Dec 4 15:16:21 2017
New Revision: 319714
URL: http://llvm.org/viewvc/llvm-project?rev=319714&view=rev
Log:
[Lex] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/Lex/MacroInfo.h
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319713: [libcxxabi] Set up .arcconfig to point to new
Diffusion CXXA repository (authored by benhamilton).
Repository:
rL LLVM
https://reviews.llvm.org/D40501
Files:
libcxxabi/trunk/.arcconfig
Ind
Author: benhamilton
Date: Mon Dec 4 15:14:03 2017
New Revision: 319713
URL: http://llvm.org/viewvc/llvm-project?rev=319713&view=rev
Log:
[libcxxabi] Set up .arcconfig to point to new Diffusion CXXA repository
Summary:
We want to automatically copy the appropriate mailing list
for review requests
george.karpenkov updated this revision to Diff 125429.
george.karpenkov edited the summary of this revision.
https://reviews.llvm.org/D40809
Files:
include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h
lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp
lib/StaticAnalyz
george.karpenkov created this revision.
Herald added subscribers: a.sidorin, szepet, xazax.hun.
This patch is work in progress, but has already shown itself to be useful in a
few cases.
For large traces understanding the analyzer output can be painful, especially
when arrows indicating the flow
Author: marshall
Date: Mon Dec 4 15:04:53 2017
New Revision: 319711
URL: http://llvm.org/viewvc/llvm-project?rev=319711&view=rev
Log:
Commit tests for changes in revision 319710
Added:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.fail.cpp
Author: marshall
Date: Mon Dec 4 15:03:42 2017
New Revision: 319710
URL: http://llvm.org/viewvc/llvm-project?rev=319710&view=rev
Log:
Implement more of P0600: '[[nodiscard]] in the library' for C++2a
Modified:
libcxx/trunk/include/new
libcxx/trunk/www/cxx2a_status.html
Modified: libcxx/
kc.austin2017 added a comment.
Hi , I am looking for some helps on the issue i have in my project after this
change for the compiler.
typedef void (*callback_t)(uint32_t icciar, void * context);
callback_t callee1;
void _ _attribute__((interrupt("IRQ"))) __cs3_isr_irq() {
callee1(icciar , co
majnemer added inline comments.
Comment at: src/support/runtime/exception_pointer_msvc.ipp:119-123
+#ifdef _M_AMD64
+RtlPcToFileHeader(
+reinterpret_cast(const_cast(throw_info)),
+&image_base);
+#endif
Can't you use the image_base field in thr
yaxunl created this revision.
Herald added a subscriber: nhaehnle.
CreateCoercedLoad/CreateCoercedStore assumes pointer argument of
memcpy is in addr space 0, which is not correct and causes invalid
bitcasts for triple amdgcn---amdgiz.
It is fixed by using alloca addr space instead.
https://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319707: Correctly handle line table entries without
filenames during AST serialization (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D40746?vs=125227&id=125419#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319707: Correctly handle line table entries without
filenames during AST serialization (authored by hans).
Repository:
rC Clang
https://reviews.llvm.org/D40746
Files:
lib/Serialization/ASTReader.cpp
Author: hans
Date: Mon Dec 4 14:28:45 2017
New Revision: 319707
URL: http://llvm.org/viewvc/llvm-project?rev=319707&view=rev
Log:
Correctly handle line table entries without filenames during AST serialization
The current code would hit an assert in ASTWriter when trying to write
out the filename
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319703: Add _Float128 as alias to __float128 to enable
compilations on Fedora27/glibc2… (authored by erichkeane).
Repository:
rC Clang
https://reviews.llvm.org/D40673
Files:
include/clang/Basic/Toke
Author: erichkeane
Date: Mon Dec 4 13:58:43 2017
New Revision: 319703
URL: http://llvm.org/viewvc/llvm-project?rev=319703&view=rev
Log:
Add _Float128 as alias to __float128 to enable compilations on
Fedora27/glibc2-26
Fedora27 is using a new version of glibc that refers to the _Float128 type. T
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319702: [libclang] Record parsing invocation to a temporary
file when requested (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D40527?vs=124788&id=125413#toc
Repository:
rL
Author: arphaman
Date: Mon Dec 4 13:56:36 2017
New Revision: 319702
URL: http://llvm.org/viewvc/llvm-project?rev=319702&view=rev
Log:
[libclang] Record parsing invocation to a temporary file when requested
by client
This patch extends libclang by allowing it to record parsing operations to a
tem
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319702: [libclang] Record parsing invocation to a temporary
file when requested (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D40527?vs=124788&id=125412#toc
Repository:
rC
cameron314 added a comment.
Locally we've done something similar (adding a
`clang_getCursorPrettyPrintedDeclaration` function, though without exposing the
`PrintingPolicy`) and overhauled `DeclPrinter` to produce proper pretty names.
This is a hack that works well for us, but can never be upstr
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:602
def AnalyzerNoReturn : InheritableAttr {
- let Spellings = [GNU<"analyzer_noreturn">];
+ let Spellings = [Clang<"analyzer_noreturn">];
let Documentation = [Undocumented];
dcoug
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D40746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: abataev
Date: Mon Dec 4 13:30:42 2017
New Revision: 319700
URL: http://llvm.org/viewvc/llvm-project?rev=319700&view=rev
Log:
[OPENMP] Fix PR35486: crash when collapsing loops with dependent iteration
spaces.
Though it is incorrect from point of view of OpenMP standard to have
dependent
malaperle added a comment.
Sorry for the delay, I'm looking into this now. I actually don't query (or even
store!) any symbol names in the index interface now, only Occurrences queried
by USR which is enough for findReferences and findDefinitions. It looks like
storing names is the main part in
efriedma added a comment.
The part which seems to be throwing you off is "or the class member access
expression refers to a member of an unknown specialization". A "member of an
unknown specialization" is defined in [temp.dep.type] in the standard.
https://reviews.llvm.org/D40566
_
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
Looks good to me.
Repository:
rL LLVM
https://reviews.llvm.org/D40673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
aaron.ballman updated this revision to Diff 125407.
aaron.ballman added a comment.
Rebased on ToT and given more context.
https://reviews.llvm.org/D40225
Files:
include/clang/Basic/LangOptions.def
include/clang/Frontend/LangStandard.h
include/clang/Frontend/LangStandards.def
lib/Fronten
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319697: [analyzer] [NFC] remove duplicated function
(authored by george.karpenkov).
Repository:
rC Clang
https://reviews.llvm.org/D39709
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
I
Author: george.karpenkov
Date: Mon Dec 4 13:00:05 2017
New Revision: 319697
URL: http://llvm.org/viewvc/llvm-project?rev=319697&view=rev
Log:
[analyzer] [NFC] remove duplicated function
Two copies of getSymLERange in RangeConstraintManager are virtually
identical, which is clearly bad.
This patc
arphaman added inline comments.
Comment at: tools/libclang/CIndexer.h:45
+ std::string ToolchainPath;
+ llvm::sys::SmartMutex Mutex;
+
jkorous-apple wrote:
> I am just wondering - since we anticipate multi-threaded usage, shouldn't we
> synchronize access to a
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 319696.
Repository:
rC Clang
https://reviews.llvm.org/D40795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: marshall
Date: Mon Dec 4 12:46:38 2017
New Revision: 319693
URL: http://llvm.org/viewvc/llvm-project?rev=319693&view=rev
Log:
Ooops. I checked in a test for a bug I haven't fixed yet. Temporrarily
commented it out.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.modifie
Author: hans
Date: Mon Dec 4 12:38:21 2017
New Revision: 319690
URL: http://llvm.org/viewvc/llvm-project?rev=319690&view=rev
Log:
Fix build after r319688: s/CPlusPlus1z/CPlusPlus17/
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UnaryStaticAssertCheck.cpp
Modified:
clang-tools-extr
Author: aaronballman
Date: Mon Dec 4 12:27:34 2017
New Revision: 319688
URL: http://llvm.org/viewvc/llvm-project?rev=319688&view=rev
Log:
Now that C++17 is official (https://www.iso.org/standard/68564.html), start
changing the C++1z terminology over to C++17. NFC intended, these are all
mechani
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ReplaceUncaughtExceptionCheck.cpp:59
+ if (!BeginLoc.isMacroID()) {
+Diag << FixItHint::CreateInsertion(BeginLoc.getLocWithOffset(TextLength),
+ "s");
mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 319687
https://reviews.llvm.org/D40586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Mon Dec 4 12:11:38 2017
New Revision: 319687
URL: http://llvm.org/viewvc/llvm-project?rev=319687&view=rev
Log:
Implement P0457R2: 'String Prefix and Suffix Checking' for c++2a
Added:
libcxx/trunk/test/std/strings/basic.string/string.ends_with/
libcxx/trunk/test/st
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319684: design document for a hardware-assisted memory
safety (HWAMS) tool, similar to… (authored by kcc).
Changed prior to commit:
https://reviews.llvm.org/D40568?vs=125045&id=125398#toc
Repository:
Author: kcc
Date: Mon Dec 4 12:01:38 2017
New Revision: 319684
URL: http://llvm.org/viewvc/llvm-project?rev=319684&view=rev
Log:
design document for a hardware-assisted memory safety (HWAMS) tool, similar to
AddressSanitizer
Summary:
preliminary design document for a hardware-assisted memory sa
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
Are you actually using libc++ with cl? :)
https://reviews.llvm.org/D40774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D40501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
mibintc marked 3 inline comments as done.
mibintc added a comment.
added inline replies to Eli and Hubert
Comment at: lib/Frontend/InitPreprocessor.cpp:817
DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat(), "L");
+ DefineFloatMacros(Builder, "FLT128", &TI.getFloa
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM with the minor comment below.
Comment at: include/clang/Basic/TargetInfo.h:563
+ /// Check whether llvm intrinsics such as llvm.convert.to.fp16 should be used
+ /// to c
mibintc updated this revision to Diff 125378.
mibintc added a subscriber: eli.friedman.
mibintc added a comment.
I responded to comments from @eli.friedman and @hubert.reinterpretcast : I
added FIXME comment regarding the "Q" suffix on the float 128 literals (gcc
uses https://reviews.llvm.org/F
JonasToth added inline comments.
Comment at: clang-tidy/modernize/ReplaceUncaughtExceptionCheck.cpp:32
+ Finder->addMatcher(
+ declRefExpr(to(functionDecl(hasName(MatchText.bind("call_expr"),
+ this);
koldaniel wrote:
> JonasToth wrote:
> > Interes
jroelofs added a comment.
looks fine to me, but this is the sort of thing that @EricWF usually wants the
final say on.
https://reviews.llvm.org/D40775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yep, looks good.
https://reviews.llvm.org/D39709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
george.karpenkov added a comment.
@dcoughlin @NoQ OK to commit?
https://reviews.llvm.org/D39709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Mon Dec 4 10:59:14 2017
New Revision: 319675
URL: http://llvm.org/viewvc/llvm-project?rev=319675&view=rev
Log:
Fix PR#35948: generate_n does not accept floating point Size arguments.
Modified:
libcxx/trunk/include/type_traits
libcxx/trunk/test/std/algorithms/alg.m
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D40795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: aaronballman
Date: Mon Dec 4 10:36:34 2017
New Revision: 319672
URL: http://llvm.org/viewvc/llvm-project?rev=319672&view=rev
Log:
Changing mixed CRLFs back to LFs; NFC.
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h
Modified: cfe/trunk/include/clang/ASTMatchers/
twoh updated this revision to Diff 125368.
twoh added a comment.
Thanks @jkorous-apple for the comment. I think your suggestion is a more
precise description for the implementation, and adjusted the comments
accordingly.
I intentionally didn't add the details to the comments for the header,
as LL
NoQ created this revision.
Herald added subscribers: cfe-commits, rnkovacs.
Because for every symbol `$x` we can construct exactly two different
`MemRegion`s that both get dumped as `SymRegion{$x}`, and i didn't bother
fixing it for years, i wanted to at least make the problem apparent. With thi
Eugene.Zelenko added a comment.
I think will be good idea to rename check to
//modernize-use-uncaught-exceptions// to be consistent with other similar
checks.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm
malaperle added a comment.
Can you also reformat the code too with clang-format? I think there's a few
things in ClangdUnit.h/.cpp
Comment at: clangd/ClangdServer.cpp:521
+ std::shared_ptr Resources = Units.getFile(File);
+ assert(Resources && "Calling findDocumentHighlights
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/index.rst:280
+lint-command
+lint-command lint-args
+
xgsa wrote:
> aaron.ballman wrote:
> > This should have a subscript `opt` following `lint-args` to denote that the
> > args are optiona
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319666: [libcxx] Set up .arcconfig to point to new Diffusion
CXX repository (authored by benhamilton).
Repository:
rL LLVM
https://reviews.llvm.org/D40500
Files:
libcxx/trunk/.arcconfig
Index: lib
Author: benhamilton
Date: Mon Dec 4 09:55:28 2017
New Revision: 319666
URL: http://llvm.org/viewvc/llvm-project?rev=319666&view=rev
Log:
[libcxx] Set up .arcconfig to point to new Diffusion CXX repository
Summary:
We want to automatically copy the appropriate mailing list
for review requests to
1 - 100 of 144 matches
Mail list logo
