malaperle added a comment.
> - Look up in parent directories for a .clang-format file. Use "LLVM" as
> fallback style.
> - Move cached fixits to ClangdServer, remove fixits once the client closes
> the document.
> - Fix translations between LSP rows/cols (0-based) and clang row/cols
> (1-based)
malaperle requested changes to this revision.
malaperle added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/ClangdServer.cpp:528
+ Value = llvm::make_error(
+ "invalid AST",
+ llvm::errc::invalid_argument);
-
Author: dcoughlin
Date: Sun Dec 3 20:46:47 2017
New Revision: 319638
URL: http://llvm.org/viewvc/llvm-project?rev=319638&view=rev
Log:
[analyzer] Don't treat lambda-captures float constexprs as undefined
RegionStore has special logic to evaluate captured constexpr variables.
However, if the cons
malaperle accepted this revision.
malaperle added a comment.
This looks good to me. @ilya-biryukov Any objections?
I think we can do further iterations later to handle macros and other specific
cases (multiple Decls at the position, etc) . It's already very useful
functionality.
Repository:
xgsa added inline comments.
Comment at: docs/clang-tidy/index.rst:280
+lint-command
+lint-command lint-args
+
aaron.ballman wrote:
> This should have a subscript `opt` following `lint-args` to denote that the
> args are optional. I think you can achieve
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a minor commenting nit, this LGTM. Thanks!
Comment at: docs/clang-tidy/index.rst:280
+lint-command
+lint-command lint-args
+
xgsa updated this revision to Diff 125292.
xgsa added a comment.
A typo in documentation was fixed.
https://reviews.llvm.org/D40671
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/nolint.cpp
test/clang-tidy/nolintnextli
xgsa updated this revision to Diff 125291.
xgsa added a comment.
Updated documentation and comments in code.
https://reviews.llvm.org/D40671
Files:
clang-tidy/ClangTidyDiagnosticConsumer.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/nolint.cpp
test/clang-tidy/nol
xgsa marked 2 inline comments as done.
xgsa added inline comments.
Comment at: docs/clang-tidy/index.rst:270
+// Skip only the specified diagnostics for the next line
+// NOLINTNEXTLINE (google-explicit-constructor, google-runtime-int)
+Foo(bool param);
-
Author: a.sidorin
Date: Sun Dec 3 08:04:07 2017
New Revision: 319632
URL: http://llvm.org/viewvc/llvm-project?rev=319632&view=rev
Log:
[ASTImporter] Add unit tests for UsingDecl and UsingShadowDecl
Patch by Kareem Khazem!
Differential Revision: https://reviews.llvm.org/D27181
Modified:
cf
a.sidorin added a comment.
Hello Kareem,
While the functionality of this patch is already implemented in my already
merged patch, I added your tests into the repo. Thank you!
https://reviews.llvm.org/D27181
___
cfe-commits mailing list
cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319632: [ASTImporter] Add unit tests for UsingDecl and
UsingShadowDecl (authored by a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D27181?vs=79488&id=125290#toc
Repository:
rL LLVM
ht
aaron.ballman added a comment.
Ping
https://reviews.llvm.org/D40225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
Ping
https://reviews.llvm.org/D39665
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
I would like to see the large test case added back in -- it was demonstrating a
real problem with the code and it would be good to ensure we don't regress that
behavior again in the future.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40737
aaron.ballman added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:299
+size_t BracketIndex = NolintIndex + NolintMacro.size();
+// Check if the specific checks are specified in brackets
+if (BracketIndex < Line.size() && Line[BracketIndex] ==
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:60
+ // To be an interface, all base classes must be interfaces as well.
+ for (const auto &I : Node->bases()) {
+const auto *Ty = I.getType()->getAs();
julieho
kromanenkov added a comment.
A few comments.
Comment at: lib/StaticAnalyzer/Checkers/LabelInsideSwitchChecker.cpp:19
+if (S.second)
+ return S;
+
Maybe I miss something, but do not we return StringRef to temporary string
going out of scope here? Same
a.sidorin added a comment.
Hello Alexey,
Thank you for the patch. I have made a preliminary review and will add some
other reviewers. You can find my comments inline.
Comment at: lib/StaticAnalyzer/Checkers/LabelInsideSwitchChecker.cpp:1
+#include "clang/AST/StmtVisitor.h"
+#
halyavin created this revision.
Avoid possible collisions with macros.
Repository:
rCXX libc++
https://reviews.llvm.org/D40775
Files:
include/support/win32/locale_win32.h
src/support/win32/locale_win32.cpp
Index: src/support/win32/locale_win32.cpp
===
lichray added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:712-720
+ Diag(Decomp.getLSquareLoc(), [&] {
+if (getLangOpts().CPlusPlus1z) {
+ if (D.getContext() == Declarator::ConditionContext)
+return diag::ext_decomp_decl_cond;
+ else
+retu
lichray updated this revision to Diff 125288.
lichray marked 3 inline comments as done.
lichray added a comment.
Rephrase warning message.
Repository:
rC Clang
https://reviews.llvm.org/D39284
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/DeclSpec.h
lib/Parse/Pars
halyavin created this revision.
The parameter was previously renamed but MSVC path was not updated.
https://reviews.llvm.org/D40774
Files:
include/algorithm
Index: include/algorithm
===
--- include/algorithm
+++ include/algorit
Author: hamzasood
Date: Sun Dec 3 02:18:35 2017
New Revision: 319631
URL: http://llvm.org/viewvc/llvm-project?rev=319631&view=rev
Log:
Corrected a typo in the building libc++ docs
Modified:
libcxx/trunk/docs/BuildingLibcxx.rst
Modified: libcxx/trunk/docs/BuildingLibcxx.rst
URL:
http://llvm
24 matches
Mail list logo
