Hi Kostya,
Sorry for the detailed response.
I forwarded your questions to GCC team who are also adding CET support for
Glibc / Linux Kernel / Loader.
I also talked to the simulations team to understand their timeline.
They will contact this mailing list with detailed answers.
There are few more
Author: martell
Date: Tue Nov 28 23:25:12 2017
New Revision: 319297
URL: http://llvm.org/viewvc/llvm-project?rev=319297&view=rev
Log:
Toolchain: Normalize dwarf, sjlj and seh eh
This is a re-apply of r319294.
adds -fseh-exceptions and -fdwarf-exceptions flags
clang will check if the user has sp
martell added a comment.
I also want to note a small addition armb and thumbeb for NetBSD.
They were missed in the previous version.
Just waiting for tests to pass now.
Repository:
rL LLVM
https://reviews.llvm.org/D39673
___
cfe-commits mailing l
martell added a comment.
@mstorsjo yup, I added a comment on the commit about the failure here
https://reviews.llvm.org/rL319294
I have already fixed both issues.
Will re apply shortly.
Repository:
rL LLVM
https://reviews.llvm.org/D39673
___
cfe
mstorsjo added inline comments.
Comment at: cfe/trunk/lib/Driver/ToolChains/FreeBSD.cpp:368
+getTriple().getArch() == llvm::Triple::thumb)
+ return llvm::ExceptionHandling::SjLj;
case llvm::Triple::GNUEABIHF:
This seems to need a fallthrough comme
mstorsjo added inline comments.
Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:457
+ if (Triple.isOSWindows())
+return llvm::ExceptionHandling::WinEH;
+ return llvm::ExceptionHandling::None;
It looks like this broke some buildbot after all - see e.g.
http:
Author: martell
Date: Tue Nov 28 22:51:27 2017
New Revision: 319295
URL: http://llvm.org/viewvc/llvm-project?rev=319295&view=rev
Log:
Revert "Toolchain: Normalize dwarf, sjlj and seh eh"
This reverts rL319294.
The windows sanitizer does not like seh on x86.
Will re apply with None type for x86
R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319294: Toolchain: Normalize dwarf, sjlj and seh eh
(authored by martell).
Changed prior to commit:
https://reviews.llvm.org/D39673?vs=124695&id=124696#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: martell
Date: Tue Nov 28 22:25:13 2017
New Revision: 319294
URL: http://llvm.org/viewvc/llvm-project?rev=319294&view=rev
Log:
Toolchain: Normalize dwarf, sjlj and seh eh
adds -fseh-exceptions and -fdwarf-exceptions flags
clang will check if the user has specified an exception model flag,
martell added a comment.
landing this as it was previous approved by reid in this state and again re
checked by martin.
Repository:
rL LLVM
https://reviews.llvm.org/D39673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
martell updated this revision to Diff 124695.
martell added a comment.
- disregard my last comment, lets go with seh on all windows targets.
Repository:
rL LLVM
https://reviews.llvm.org/D39673
Files:
docs/ClangCommandLineReference.rst
include/clang/Basic/LangOptions.def
include/clang/D
rjmccall added a comment.
In https://reviews.llvm.org/D40508#938675, @sepavloff wrote:
> In https://reviews.llvm.org/D40508#938040, @rjmccall wrote:
>
> > My skepticism about the raw_ostream is not about the design of having a
> > custom raw_ostream subclass, it's that that subclass could concei
martell added inline comments.
Comment at: lib/Driver/ToolChain.cpp:458
+if (Triple.getArch() == llvm::Triple::x86)
+ return llvm::ExceptionHandling::DwarfCFI;
+else
mstorsjo wrote:
> I'd suggest braces around the outer if statement.
>
> But is ther
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
I think this looks fine (and I agree that the underlying premise makes sense).
Before you commit, could you also please add some tests with nested union
members?
Repository:
rL LLVM
htt
sepavloff added a comment.
In https://reviews.llvm.org/D40508#938040, @rjmccall wrote:
> My skepticism about the raw_ostream is not about the design of having a
> custom raw_ostream subclass, it's that that subclass could conceivably be
> re-used by some other client. It feels like it belongs
mstorsjo added inline comments.
Comment at: lib/Driver/ToolChain.cpp:458
+if (Triple.getArch() == llvm::Triple::x86)
+ return llvm::ExceptionHandling::DwarfCFI;
+else
I'd suggest braces around the outer if statement.
But is there any point to this d
martell updated this revision to Diff 124692.
martell added a comment.
address reid's comment
update to HEAD
Repository:
rL LLVM
https://reviews.llvm.org/D39673
Files:
docs/ClangCommandLineReference.rst
include/clang/Basic/LangOptions.def
include/clang/Driver/Options.td
include/clang
Author: sepavloff
Date: Tue Nov 28 21:10:11 2017
New Revision: 319290
URL: http://llvm.org/viewvc/llvm-project?rev=319290&view=rev
Log:
Use static function instead of anonymous namespace
Modified:
cfe/trunk/lib/AST/TypePrinter.cpp
Modified: cfe/trunk/lib/AST/TypePrinter.cpp
URL:
http://llvm
malaperle added inline comments.
Comment at: clangd/ClangdUnit.cpp:1173
+H.range = L.range;
+Ref = getDataBufferFromSourceRange(AST, SR, L);
+ }
malaperle wrote:
> I get the same crash as I mentioned before if I hover on the class in
> "isa(
malaperle requested changes to this revision.
malaperle added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/ClangdLSPServer.cpp:245
+
+ C.reply(Hover::unparse(H->Value));
+}
we need to check the "Expected" here, so
if (!H)
kcc updated this revision to Diff 124691.
kcc added a comment.
mention alternatives for memory access instrumentation
Repository:
rC Clang
https://reviews.llvm.org/D40568
Files:
docs/TaggedAddressSanitizerDesign.rst
Index: docs/TaggedAddressSanitizerDesign.rst
rsmith added inline comments.
Comment at: lib/AST/ASTContext.cpp:2213
+Field->isBitField()
+? Field->getBitWidthValue(Context)
+: Context.toBits(Context.getTypeSizeInChars(Field->getType()));
erichkeane wrote:
> erichkeane wrote:
>
erichkeane added a comment.
Did ore looking into the bitfield shennangins. Will update this patch
tomorrow. @rsmith if you get a chance, do you perhaps have an opinion on
'bool' fields? It seems to me that a bool could either be considered an 8 bit
value, or a 1 bit value with 7 bits of padd
Author: tstellar
Date: Tue Nov 28 18:49:04 2017
New Revision: 319281
URL: http://llvm.org/viewvc/llvm-project?rev=319281&view=rev
Log:
Creating release candidate rc2 from release_501 branch
Added:
libcxxabi/tags/RELEASE_501/rc2/
- copied from r319280, libcxxabi/branches/release_50/
___
Author: tstellar
Date: Tue Nov 28 18:49:31 2017
New Revision: 319287
URL: http://llvm.org/viewvc/llvm-project?rev=319287&view=rev
Log:
Creating release candidate rc2 from release_501 branch
Added:
libunwind/tags/RELEASE_501/rc2/ (props changed)
- copied from r319286, libunwind/branche
Author: tstellar
Date: Tue Nov 28 18:49:00 2017
New Revision: 319280
URL: http://llvm.org/viewvc/llvm-project?rev=319280&view=rev
Log:
Creating release candidate rc2 from release_501 branch
Added:
libcxx/tags/RELEASE_501/rc2/ (props changed)
- copied from r319279, libcxx/branches/rele
mclow.lists added inline comments.
Comment at: include/string_view:577
+ bool starts_with(basic_string_view __s) const _NOEXCEPT
+ { return size() >= __s.size() && compare(0, __s.size(), __s) == 0; }
+
rsmith wrote:
> mclow.lists wrote:
> > rsmith wro
erichkeane updated this revision to Diff 124679.
erichkeane added a comment.
thanks for the comments rsmith, think this is all caught up to your comments.
Also added the test for member ptr differences.
https://reviews.llvm.org/D39347
Files:
include/clang/AST/ASTContext.h
include/clang/AS
erichkeane added inline comments.
Comment at: lib/AST/ASTContext.cpp:2213
+Field->isBitField()
+? Field->getBitWidthValue(Context)
+: Context.toBits(Context.getTypeSizeInChars(Field->getType()));
erichkeane wrote:
> rsmith wrote:
>
rsmith added inline comments.
Comment at: include/string_view:577
+ bool starts_with(basic_string_view __s) const _NOEXCEPT
+ { return size() >= __s.size() && compare(0, __s.size(), __s) == 0; }
+
mclow.lists wrote:
> rsmith wrote:
> > Is this a confo
mclow.lists updated this revision to Diff 124677.
mclow.lists added a comment.
Wrapped the `string_view` bits in #ifdef for C++2a.
De-tabbed.
https://reviews.llvm.org/D40586
Files:
include/string
include/string_view
test/std/strings/basic.string/string.ends_with/ends_with.char.pass.cpp
kcc added inline comments.
Comment at: docs/TaggedAddressSanitizerDesign.rst:22
+*quarantine* to find use-after-free.
+The shadow, the redzones, and the quarantine are the
+major sources of AddressSanitizer's memory overhead.
davidxl wrote:
> What is the overhead
davidxl added inline comments.
Comment at: docs/TaggedAddressSanitizerDesign.rst:22
+*quarantine* to find use-after-free.
+The shadow, the redzones, and the quarantine are the
+major sources of AddressSanitizer's memory overhead.
What is the overhead of redzones
juliehockett updated this revision to Diff 124675.
juliehockett added a comment.
Fixing typo
https://reviews.llvm.org/D40580
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
clang-tidy/fuchsia/MultipleInher
jlebar added a comment.
I defer to tra on this.
https://reviews.llvm.org/D40453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett updated this revision to Diff 124669.
juliehockett marked 4 inline comments as done.
https://reviews.llvm.org/D40580
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
clang-tidy/fuchsia/MultipleIn
arphaman added a comment.
In https://reviews.llvm.org/D40527#937282, @nik wrote:
> Could you elaborate on "the client will be able to use it to generate a
> reproducer for the crash"? Having the json file, what would I need to do in
> order to reproduce the crash?
Sure. I would like to teach
mclow.lists added inline comments.
Comment at: include/string:309
+ bool ends_with(charT c) const noexcept;
+ bool ends_with(const charT* s) const;
+
rsmith wrote:
> The indentation here seems off. Should these have a `// C++2a` comment?
I may have le
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319267: [CMake] Support side-by-side checkouts in
multi-stage build (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40258?vs=123606&id=124665#toc
Repository:
rL LLVM
https:/
Author: phosek
Date: Tue Nov 28 16:34:46 2017
New Revision: 319267
URL: http://llvm.org/viewvc/llvm-project?rev=319267&view=rev
Log:
[CMake] Support side-by-side checkouts in multi-stage build
Passthrough LLVM_ENABLE_{PROJECTS,RUNTIMES} to followup stages to
support the side-by-side checkouts (ak
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319264: [CMake] Use LIST_SEPARATOR rather than escaping in
ExternalProject_Add (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D40257?vs=123710&id=124663#toc
Repository:
rL LL
Author: phosek
Date: Tue Nov 28 16:23:10 2017
New Revision: 319264
URL: http://llvm.org/viewvc/llvm-project?rev=319264&view=rev
Log:
[CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add
Escaping ; in list arguments passed to ExternalProject_Add doesn't seem
to be working in newe
rsmith added inline comments.
Comment at: lib/AST/MicrosoftCXXABI.cpp:253
+
+ MPI.HasPadding = MPI.Width % MPI.Align == 0;
erichkeane wrote:
> rsmith wrote:
> > rsmith wrote:
> > > erichkeane wrote:
> > > > rsmith wrote:
> > > > > This seems to be backwards?
>
rsmith added inline comments.
Comment at: include/string:309
+ bool ends_with(charT c) const noexcept;
+ bool ends_with(const charT* s) const;
+
The indentation here seems off. Should these have a `// C++2a` comment?
Comment at: inc
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:76
+ for (const auto &I : Node->bases()) {
+const RecordType *Ty = I.getType()->getAs();
+assert(Ty && "RecordType of base class is unknown");
Could be cons
juliehockett updated this revision to Diff 124662.
juliehockett marked 6 inline comments as done.
https://reviews.llvm.org/D40580
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
clang-tidy/fuchsia/MultipleIn
erichkeane added inline comments.
Comment at: lib/AST/ASTContext.cpp:2183-2184
+ for (const auto *Field : RD->fields()) {
+if (!Context.hasUniqueObjectRepresentations(Field->getType()))
+ return false;
+int64_t FieldSizeInBits =
rsmith wrote:
> eric
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:21
+
+ AST_MATCHER(CXXRecordDecl, hasDefinition) {
+if (!Node.hasDefinition())
Please reduce indentation level.
Comment at: clang-tidy/fuchsi
rsmith added inline comments.
Comment at: lib/AST/MicrosoftCXXABI.cpp:253
+
+ MPI.HasPadding = MPI.Width % MPI.Align == 0;
rsmith wrote:
> erichkeane wrote:
> > rsmith wrote:
> > > This seems to be backwards?
> > >
> > > Also, I'm not sure whether this is cor
mclow.lists added a comment.
Sorry for the extra bits.
Comment at: include/string:1365
static _LIBCPP_INLINE_VISIBILITY
size_type __recommend(size_type __s) _NOEXCEPT
+{
This is a leftover change. Disregard this bit.
Comment
mclow.lists created this revision.
This adds six calls each to `basic_string` and `basic_string_view`:
- starts_with (3 variants)
- ends_with (3 variants)
This is a C++2a feature
https://reviews.llvm.org/D40586
Files:
include/string
include/string_view
test/std/strings/basic.string/stri
rsmith added inline comments.
Comment at: lib/AST/ASTContext.cpp:2183-2184
+ for (const auto *Field : RD->fields()) {
+if (!Context.hasUniqueObjectRepresentations(Field->getType()))
+ return false;
+int64_t FieldSizeInBits =
erichkeane wrote:
> rsmi
ioeric added a comment.
First round of comments. Mostly around indexing actions and file records; I
haven't started reviewing the data writing and storing code. I think it might
make sense to split the index writing and storing logics into a separate patch,
which should be possible if `writeUni
jakehehrlich updated this revision to Diff 124646.
jakehehrlich added a comment.
When I changed the test to add "_cc1" I got rid of the temporary file. Well for
some reason on windows we're still getting different output so we need the
temporary file to debug things.
Repository:
rL LLVM
htt
erichkeane added inline comments.
Comment at: lib/AST/ASTContext.cpp:2183-2184
+ for (const auto *Field : RD->fields()) {
+if (!Context.hasUniqueObjectRepresentations(Field->getType()))
+ return false;
+int64_t FieldSizeInBits =
rsmith wrote:
> eric
rsmith added a comment.
Please add tests for the member pointer cases across various different targets.
Comment at: lib/AST/ASTContext.cpp:2183-2184
+ for (const auto *Field : RD->fields()) {
+if (!Context.hasUniqueObjectRepresentations(Field->getType()))
+ return fal
dberris added a comment.
In https://reviews.llvm.org/D39114#938134, @Hahnfeld wrote:
> I'm getting "multiple definition" errors on powerpc64le when linking the unit
> tests, for example `XRayBufferQueueTest`:
>
> src/projects/compiler-rt/lib/xray/xray_utils.cc:34: multiple definition of
> `__
Hello everyone,
LLVM buildmaster is back to work.
Two slaves remain off for now as they produce a lot of warnings and their
log files are way too big.
The next builds have full logs available. Hope this helps to fix this issue:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds
juliehockett created this revision.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adds a check to the Fuchsia module to warn when a class inheritsfrom multiple
classes that are not pure virtual.
See https://fuchsia.googlesource.com/zircon/+/master/
kcc marked an inline comment as done.
kcc added inline comments.
Comment at: docs/TaggedAddressSanitizerDesign.rst:2
+===
+TaggedAddressSanitizer Design Documentation
+===
eugenis wro
kcc updated this revision to Diff 124637.
kcc added a comment.
addressed comments
Repository:
rC Clang
https://reviews.llvm.org/D40568
Files:
docs/TaggedAddressSanitizerDesign.rst
Index: docs/TaggedAddressSanitizerDesign.rst
sylvestre.ledru updated this revision to Diff 124636.
https://reviews.llvm.org/D40453
Files:
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp
===
--- lib/Driver/ToolChains/Cuda.cpp
+++ lib/Driver/ToolChains/Cu
Hahnfeld added a reviewer: ABataev.
Hahnfeld added a comment.
This should add or extend a regression test
https://reviews.llvm.org/D40577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
mmasten added a comment.
This patch is related to revisions https://reviews.llvm.org/D22792 and
https://reviews.llvm.org/D40575
https://reviews.llvm.org/D40577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:81
+
+if (Distro.IsDebian())
+ CudaPathCandidates.push_back(D.SysRoot + "/usr/lib/cuda");
No need for a named temporary. `if (Distro(D.getVFS).IsDebian())` should do.
Also, please add
Hahnfeld added a comment.
On a related note please add context to your patch as described here:
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
https://reviews.llvm.org/D40453
___
cfe-commits mailing list
cfe-commit
mmasten created this revision.
This patch adds "vector-variants" function attributes to simd functions.
https://reviews.llvm.org/D40577
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
Index: lib/CodeGen/CGOpenMPRuntime.cpp
===
--- lib/C
malaperle added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:246
+
+ C.reply(json::ary(Highlights->Value));
+}
malaperle wrote:
> I get a test failure here because there is an assertion that the Expected<>
> needs to be checked. I can't really think
sylvestre.ledru updated this revision to Diff 124629.
https://reviews.llvm.org/D40453
Files:
lib/Driver/ToolChains/Cuda.cpp
Index: lib/Driver/ToolChains/Cuda.cpp
===
--- lib/Driver/ToolChains/Cuda.cpp
+++ lib/Driver/ToolChains/Cu
eugenis added inline comments.
Comment at: docs/TaggedAddressSanitizerDesign.rst:2
+===
+TaggedAddressSanitizer Design Documentation
+===
I vote for HardwareAssistedAddressSanitizer,
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D40108#938131, @juliehockett wrote:
> If you could, that'd be great! Thank you!
It'll be good idea it you'll request commit rights, since you have more checks
in development queue.
https://reviews.llvm.org/D40108
Author: abataev
Date: Tue Nov 28 13:11:44 2017
New Revision: 319227
URL: http://llvm.org/viewvc/llvm-project?rev=319227&view=rev
Log:
[OPENMP] Generalize capturing of clauses expressions.
The handling and capturing of the non-constant expressions of some of
the capturable clauses in combined dire
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r319225.
https://reviews.llvm.org/D40108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Tue Nov 28 13:09:25 2017
New Revision: 319225
URL: http://llvm.org/viewvc/llvm-project?rev=319225&view=rev
Log:
Add a new clang-tidy module for Fuchsia as an umbrella to diagnose issues with
the Fuschia and Zircon coding guidelines
(https://fuchsia.googlesource.com/zir
Hahnfeld added a comment.
I'm getting "multiple definition" errors on powerpc64le when linking the unit
tests, for example `XRayBufferQueueTest`:
src/projects/compiler-rt/lib/xray/xray_utils.cc:34: multiple definition of
`__xray::retryingWriteAll(int, char*, char*)'
src/projects/compiler-rt
juliehockett added a comment.
If you could, that'd be great! Thank you!
https://reviews.llvm.org/D40108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mattd created this revision.
Fixes: PR28520
Perform a bounds check on a function's argument list, before accessing any
index value specified by an 'argument_with_type_tag' attribute.
https://reviews.llvm.org/D40574
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319222: [OpenMP] Stable sort Privates to remove
non-deterministic ordering (authored by mgrang).
Changed prior to commit:
https://reviews.llvm.org/D39947?vs=122751&id=124622#toc
Repository:
rL LLVM
Author: mgrang
Date: Tue Nov 28 12:41:13 2017
New Revision: 319222
URL: http://llvm.org/viewvc/llvm-project?rev=319222&view=rev
Log:
[OpenMP] Stable sort Privates to remove non-deterministic ordering
Summary:
This fixes the following failures uncovered by D39245:
Clang :: OpenMP/task_firstpri
fhahn added reviewers: arphaman, GorNishanov, hfinkel, fhahn.
fhahn added a comment.
Looks good to me, with some nits. However it seems that we do not use the fast
math flags anywhere else in Clang codegen, so it would be good to clarify if it
is OK to use it here.
Comment at
Hahnfeld created this revision.
This is needed to not break with an upcoming change in LLVM to use
dollar signs (which need to be quoted) instead of dots for
generating unique names.
https://reviews.llvm.org/D40572
Files:
test/OpenMP/nvptx_parallel_codegen.cpp
Index: test/OpenMP/nvptx_parall
rjmccall added a comment.
My skepticism about the raw_ostream is not about the design of having a custom
raw_ostream subclass, it's that that subclass could conceivably be re-used by
some other client. It feels like it belongs as an internal hack in Clang
absent some real evidence that someone
rnk requested changes to this revision.
rnk added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Driver/ToolChain.cpp:450-458
+ const llvm::Target *TT = llvm::TargetRegistry::lookupTarget(TS, Error);
+ if (!TT)
+return llvm::ExceptionHandlin
rjmccall added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:2188
+ !Context.getTargetInfo().isVLASupported() &&
+ shouldDiagnoseTargetSupportFromOpenMP()) {
+ // Some targets don't support VLAs.
tra wrote:
> rjmccall w
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, seems reasonable enough.
Repository:
rC Clang
https://reviews.llvm.org/D40569
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
dcoughlin added a comment.
Thanks for tackling this! There is one major comment inline (you are generating
an extra node that you shouldn't, which is causing the analyzer to explore code
it shouldn't) and a suggestion for simpler diagnostic text.
Comment at: lib/StaticAnalyze
jtony added inline comments.
Comment at: test/Driver/ppc-features.cpp:140
+
// RUN: %clang -target powerpc64-unknown-linux-gnu %s -mno-htm -### -o %t.o
2>&1 | FileCheck -check-prefix=CHECK-NOHTM %s
// CHECK-NOHTM: "-target-feature" "-htm"
We probably need to a
jacobly created this revision.
Forcing the 4 byte alignment caused an issue in my out of tree backend that
doesn't even have a 4 byte aligned stack. Using the default target-specific
alignment for i32 seems more reasonable.
Repository:
rC Clang
https://reviews.llvm.org/D40569
Files:
lib
Hello everyone,
LLVM buildmaster will be restarted in few minutes.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bsdjhb added a comment.
Ping @compnerd, @sdardis
https://reviews.llvm.org/D38110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir added a comment.
Re: "I tried to write a test for this, and convinced myself that while +1 is
correct, it is currently impossible to change behavior based on the missing
+1.":
In order to have different outcome based on the start column, you could use
tabs. Consider the content `"aaa\t
erichkeane updated this revision to Diff 124609.
erichkeane added a comment.
Add has padding to CXXABI getMemberPointerWidthAndAlign to correct padding
behavior here.
https://reviews.llvm.org/D39347
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
lib/AST/ASTContext.cpp
l
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:178
Split Split) const {
// Example: consider the content
// lala lala
Offtopic: Should add a FIXME that this doesn't really work in th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319201: [CUDA] Report "unsupported VLA" errors only on
device side. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D40275?vs=123831&id=124607#toc
Repository:
rL LLVM
https://re
Author: tra
Date: Tue Nov 28 10:51:42 2017
New Revision: 319201
URL: http://llvm.org/viewvc/llvm-project?rev=319201&view=rev
Log:
[CUDA] Report "unsupported VLA" errors only on device side.
This fixes erroneously reported CUDA compilation errors
in host-side code during device-side compilation.
arphaman added a comment.
I'll take a look, but my guess is that you might have to use scoping information
https://reviews.llvm.org/D39730
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
spatel added a comment.
Ping * 2.
https://reviews.llvm.org/D40044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:2188
+ !Context.getTargetInfo().isVLASupported() &&
+ shouldDiagnoseTargetSupportFromOpenMP()) {
+ // Some targets don't support VLAs.
rjmccall wrote:
> tra wrote:
kcc updated this revision to Diff 124604.
kcc added a comment.
minor edit (explained shadow)
Repository:
rC Clang
https://reviews.llvm.org/D40568
Files:
docs/TaggedAddressSanitizerDesign.rst
Index: docs/TaggedAddressSanitizerDesign.rst
=
sepavloff added a comment.
https://reviews.llvm.org/D40567 presents a patch that adds template argument
names to class template specializations. It also describes the use case in
which type names are used to identify type across different TUs.
Adding template parameters obviously increase memory
1 - 100 of 178 matches
Mail list logo
