Author: bion
Date: Tue Nov 14 23:45:07 2017
New Revision: 318277
URL: http://llvm.org/viewvc/llvm-project?rev=318277&view=rev
Log:
Tolerate even more [[nodiscard]] in the STL. Reviewed as
https://reviews.llvm.org/D39080
Modified:
libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.search/
Author: bion
Date: Tue Nov 14 23:40:37 2017
New Revision: 318276
URL: http://llvm.org/viewvc/llvm-project?rev=318276&view=rev
Log:
Tolerate [[nodiscard]] annotations in the STL. Reviewed as
https://reviews.llvm.org/D39033
Modified:
libcxx/trunk/test/std/containers/associative/map/map.ops/cou
Author: chapuni
Date: Tue Nov 14 22:53:45 2017
New Revision: 318274
URL: http://llvm.org/viewvc/llvm-project?rev=318274&view=rev
Log:
ASTMatchers.h: Avoid warnings due to "@throw". [-Wdocumentation]
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified: cfe/trunk/include/clang
Author: marshall
Date: Tue Nov 14 21:51:26 2017
New Revision: 318269
URL: http://llvm.org/viewvc/llvm-project?rev=318269&view=rev
Log:
First part of P0600 - '[[nodiscard] in the standard library'. Mark the
'empty()' methods of all the containers as nodiscard. If you're calling empty()
w/o lookin
Author: marshall
Date: Tue Nov 14 21:25:36 2017
New Revision: 318268
URL: http://llvm.org/viewvc/llvm-project?rev=318268&view=rev
Log:
Still more missing tests - this time for the unordered containers
Added:
libcxx/trunk/test/std/containers/unord/unord.map/empty.pass.cpp
libcxx/trunk/test
Author: jvesely
Date: Tue Nov 14 20:10:37 2017
New Revision: 318264
URL: http://llvm.org/viewvc/llvm-project?rev=318264&view=rev
Log:
math: Implement maxmag
Reviewer: Aaron Watry
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/include/clc/math/maxmag.h
libclc/trunk/generic/lib/mat
Author: jvesely
Date: Tue Nov 14 20:10:39 2017
New Revision: 318265
URL: http://llvm.org/viewvc/llvm-project?rev=318265&view=rev
Log:
math: Implement minmag
Reviewer: Aaron Watry
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/include/clc/math/minmag.h
libclc/trunk/generic/lib/mat
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D40062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: marshall
Date: Tue Nov 14 19:08:39 2017
New Revision: 318259
URL: http://llvm.org/viewvc/llvm-project?rev=318259&view=rev
Log:
Named the macro wrong in the test.
Modified:
libcxx/trunk/test/libcxx/diagnostics/nodiscard.pass.cpp
Modified: libcxx/trunk/test/libcxx/diagnostics/nodiscard
Author: rsmith
Date: Tue Nov 14 19:03:56 2017
New Revision: 318258
URL: http://llvm.org/viewvc/llvm-project?rev=318258&view=rev
Log:
PR35214: don't crash if we see an array of unknown bound added to an empty but
invalid designator.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/t
Author: marshall
Date: Tue Nov 14 18:31:14 2017
New Revision: 318256
URL: http://llvm.org/viewvc/llvm-project?rev=318256&view=rev
Log:
More missing tests - array<>::size() and array<>::max_size()
Added:
libcxx/trunk/test/std/containers/sequences/array/empty.pass.cpp
libcxx/trunk/test/std/
yaxunl created this revision.
Herald added subscribers: Prazek, wdng.
https://reviews.llvm.org/D40062
Files:
test/CodeGenCXX/invariant.group-for-vptrs.cpp
test/CodeGenCXX/strict-vtable-pointers.cpp
Index: test/CodeGenCXX/strict-vtable-pointers.cpp
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaOverload.cpp:7618
- // Define some constants used to index and iterate over the arithemetic types
- // provided via the getArithmeticType() m
sammccall updated this revision to Diff 122956.
sammccall added a comment.
clang-format
https://reviews.llvm.org/D40060
Files:
clangd/CMakeLists.txt
clangd/FuzzyMatch.cpp
clangd/FuzzyMatch.h
unittests/clangd/CMakeLists.txt
unittests/clangd/FuzzyMatchTests.cpp
Index: unittests/clangd/
sammccall created this revision.
Herald added a subscriber: mgorny.
This will be used for rescoring code completion results based on partial
identifiers.
Short-term use:
- we want to limit the number of code completion results returned to improve
performance of global completion. The scorer will
Author: ericwf
Date: Tue Nov 14 17:37:11 2017
New Revision: 318247
URL: http://llvm.org/viewvc/llvm-project?rev=318247&view=rev
Log:
Update Appveyor LLVM install link to be current and non-broken
Modified:
libcxx/trunk/appveyor-reqs-install.cmd
Modified: libcxx/trunk/appveyor-reqs-install.cm
Author: rsmith
Date: Tue Nov 14 17:33:46 2017
New Revision: 318245
URL: http://llvm.org/viewvc/llvm-project?rev=318245&view=rev
Log:
[modules] Fix crash in complex class merging scenario.
When we merge together class definitions, we can end up with the canonical
declaration of a field not being t
Author: marshall
Date: Tue Nov 14 17:33:33 2017
New Revision: 318244
URL: http://llvm.org/viewvc/llvm-project?rev=318244&view=rev
Log:
Added tests for xxx.size() and xxx.empty() for all the sequence containers
Added:
libcxx/trunk/test/std/containers/sequences/deque/deque.capacity/empty.pass.
Wizard updated this revision to Diff 122953.
Wizard added a comment.
new line
https://reviews.llvm.org/D40058
Files:
clang-tidy/google/AvoidThrowingObjcExceptionCheck.cpp
clang-tidy/google/AvoidThrowingObjcExceptionCheck.h
clang-tidy/google/CMakeLists.txt
clang-tidy/google/GoogleTidyMod
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D5767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rsmith closed this revision.
rsmith added a comment.
Let's keep the complete review thread together on
https://reviews.llvm.org/D5767.
https://reviews.llvm.org/D38818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
arphaman updated this revision to Diff 122949.
arphaman added a comment.
Remove C++ support for now (it will be in a followup patch along with
non-member function support).
Repository:
rL LLVM
https://reviews.llvm.org/D39913
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clan
arphaman added a comment.
In https://reviews.llvm.org/D39913#924131, @ahatanak wrote:
> Is it not necessary to print a diagnostic when a non-member function
> declaration is missing an availability attribute?
>
> void foo1();
>
> __attribute__((availability(macos, introduced=10.1)))
> vo
Author: tstellar
Date: Tue Nov 14 16:21:20 2017
New Revision: 318236
URL: http://llvm.org/viewvc/llvm-project?rev=318236&view=rev
Log:
Merging r313776:
r313776 | marshall | 2017-09-20 10:34:11 -0700 (Wed, 20 Sep 2017) | 1 li
Author: erichkeane
Date: Tue Nov 14 16:11:24 2017
New Revision: 318234
URL: http://llvm.org/viewvc/llvm-project?rev=318234&view=rev
Log:
Simplify CpuIs code to use include from LLVM
LLVM exposes a file in the backend (X86TargetParser.def) that
contains information about the correct list of CpuIs
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318234: Simplify CpuIs code to use include from LLVM
(authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D40054?vs=122936&id=122942#toc
Repository:
rL LLVM
https://reviews.ll
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D40054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318229: [PGO] Detect more structural changes with the stable
hash (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D39446?vs=122368&id=122939#toc
Repository:
rL LLVM
https://
Author: vedantk
Date: Tue Nov 14 15:56:53 2017
New Revision: 318229
URL: http://llvm.org/viewvc/llvm-project?rev=318229&view=rev
Log:
[PGO] Detect more structural changes with the stable hash
Lifting from Bob Wilson's notes: The hash value that we compute and
store in PGO profile data to detect o
erichkeane updated this revision to Diff 122936.
erichkeane added a comment.
Re-ran format on a few lines to make them more sane.
https://reviews.llvm.org/D40054
Files:
lib/Basic/Targets/X86.cpp
lib/CodeGen/CGBuiltin.cpp
Index: lib/CodeGen/CGBuiltin.cpp
erichkeane abandoned this revision.
erichkeane added a comment.
First, updated this incorrectly. Second, going to do this work over a few
patches to take advantage of work that Craig did in the backend.
https://reviews.llvm.org/D39521
___
cfe-comm
erichkeane updated this revision to Diff 122934.
erichkeane added a comment.
Re-ran clang-format, which now has more sane decisions in CGBuiltin.cpp
https://reviews.llvm.org/D39521
Files:
lib/Basic/Targets/X86.cpp
lib/CodeGen/CGBuiltin.cpp
Index: lib/CodeGen/CGBuiltin.cpp
=
erichkeane added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:4630
case NEON::BI__builtin_neon_vsha1mq_u32:
- case ARM::BI_MoveToCoprocessor:
- case ARM::BI_MoveToCoprocessor2:
+ case clang::ARM::BI_MoveToCoprocessor:
+ case clang::ARM::BI_MoveToCoprocessor2:
---
Author: eugenezelenko
Date: Tue Nov 14 15:35:42 2017
New Revision: 318221
URL: http://llvm.org/viewvc/llvm-project?rev=318221&view=rev
Log:
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/AST/Stmt.h
cfe/tru
erichkeane created this revision.
LLVM exposes a file in the backend (X86TargetParser.def) that
contains information about the correct list of CpuIs values.
This patch removes 2 of the copied and pasted versions of this
list from clang and instead includes the data from the .def file.
https://r
t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.
LGTM except for Bonaire.
Comment at: lib/Basic/Targets/AMDGPU.cpp:271
.Case("gfx700", GK_GFX7)
.Case("bonaire", GK_GFX7)
.Case("kaveri", GK_GFX7)
-
Author: eugenezelenko
Date: Tue Nov 14 15:13:32 2017
New Revision: 318216
URL: http://llvm.org/viewvc/llvm-project?rev=318216&view=rev
Log:
[AST] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/AST/DeclCXX.h
cfe/
vsk added a comment.
Thanks for the review Alex. There hasn't been any more feedback so I'll commit
this soon.
https://reviews.llvm.org/D39446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: arphaman
Date: Tue Nov 14 15:10:50 2017
New Revision: 318215
URL: http://llvm.org/viewvc/llvm-project?rev=318215&view=rev
Log:
[refactor][selection] canonicalize decl ref callee to the call expr
We would like to extract the full call when just the callee function is
selected
Modified:
Author: hans
Date: Tue Nov 14 15:10:04 2017
New Revision: 318214
URL: http://llvm.org/viewvc/llvm-project?rev=318214&view=rev
Log:
Try to fix the instrument-functions tests
On e.g. PPC the return value and argument were marked 'signext'. This
makes the test expectations a bit more flexible.
Foll
Author: marshall
Date: Tue Nov 14 14:26:50 2017
New Revision: 318208
URL: http://llvm.org/viewvc/llvm-project?rev=318208&view=rev
Log:
Add two new macros: _LIBCPP_NODISCARD_AFTER_CXX17 and
_LIBCPP_CONSTEXPR_AFTER_CXX17, along with a way to turn off the NODISCARD one:
_LIBCPP_DISABLE_NODISCARD_AF
Nebiroth marked 18 inline comments as done.
Nebiroth added inline comments.
Comment at: clangd/Protocol.h:285
+
+ DidChangeConfigurationParams() {}
+
malaperle wrote:
> I don't think you need this constructor?
I do inside parse() for DidChangeConfigurationParams
Author: arphaman
Date: Tue Nov 14 14:06:55 2017
New Revision: 318205
URL: http://llvm.org/viewvc/llvm-project?rev=318205&view=rev
Log:
[refactor][selection] canonicalize member expr callee to the full
member call expression
We would like to extract the full call when just the callee is selected.
Author: jvesely
Date: Tue Nov 14 13:55:41 2017
New Revision: 318204
URL: http://llvm.org/viewvc/llvm-project?rev=318204&view=rev
Log:
native_powr: Switch implementation to native_exp2 and native_log2
v2: don't use assume
check only for x<0, the other conditions are handled transparently
v3: d
rwols marked 2 inline comments as done.
rwols added inline comments.
Comment at: clangd/ClangdServer.h:289
+ llvm::Expected>
+ formatRange(llvm::StringRef Code, PathRef File, Range Rng);
+
ilya-biryukov wrote:
> Why do we accept `Code` as a parameter here inste
rwols updated this revision to Diff 122904.
rwols marked an inline comment as done.
rwols added a comment.
Removed braces around single statement if-else.
https://reviews.llvm.org/D39430
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/JSONRPCDispat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318199: Switch -mcount and -finstrument-functions to emit
EnterExitInstrumenter… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D39331?vs=122889&id=122901#toc
Repository:
rL LL
Author: hans
Date: Tue Nov 14 13:13:27 2017
New Revision: 318199
URL: http://llvm.org/viewvc/llvm-project?rev=318199&view=rev
Log:
Switch -mcount and -finstrument-functions to emit EnterExitInstrumenter
attributes
This updates -mcount to use the new attribute names (LLVM r318195), and
switches o
efriedma added reviewers: efriedma, rjmccall.
efriedma added a comment.
You need more test coverage for the cases where arguments end up on the stack.
And some test coverage for varargs calls.
Comment at: lib/CodeGen/TargetInfo.cpp:8858
+ else
+NeededArgGPRs = 1;
+
-
Author: abataev
Date: Tue Nov 14 13:01:01 2017
New Revision: 318194
URL: http://llvm.org/viewvc/llvm-project?rev=318194&view=rev
Log:
[OPENMP] Fix DSA analysis for threadprivates after deserialization.
If threadprivate vaible is deserialized, it is not marked as
threadprivate in DSAStack.
Modifi
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good, sorry for the delay!
Comment at: include/clang/Basic/LangOptions.def:129
LANGOPT(SjLjExceptions, 1, 0, "setjmp-longjump exception handling")
+LANGOPT(SEHExceptions
ABataev added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > Hahnfeld wrote:
> > > rjm
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> Hahnfeld wrote:
> > rjmccall wrote:
> > > Ha
erichkeane updated this revision to Diff 122897.
erichkeane added a comment.
Added a test for aligned bitfield, as @majnemer requested. Is this sufficient?
https://reviews.llvm.org/D39347
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
lib/AST/ASTContext.cpp
lib/AST/Type
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > Hahnfeld wrote:
> > > rj
kzhuravl added a comment.
Ping.
https://reviews.llvm.org/D39879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kzhuravl created this revision.
Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng.
- Remove gfx804
- Remove gfx901
- Remove gfx903
https://reviews.llvm.org/D40045
Files:
lib/Basic/Targets/AMDGPU.cpp
test/Driver/amdgpu-mcpu.cl
Index: test/Driver/amdgpu-mcpu.cl
==
majnemer added a comment.
It'd be good to have tests which have alignment directives on bitfields.
https://reviews.llvm.org/D39347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Thanks, looks good!
https://reviews.llvm.org/D39331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
hans updated this revision to Diff 122889.
hans edited the summary of this revision.
hans added a comment.
Renaming the new flag and making it sufficient to turn on instrumentation by
itself.
https://reviews.llvm.org/D39331
Files:
include/clang/Driver/Options.td
include/clang/Frontend/Code
hans added inline comments.
Comment at: include/clang/Driver/Options.td:1032
+def fno_instrument_functions_inline : Flag<["-"],
"fno-instrument-functions-inline">, Group, Flags<[CC1Option]>,
+ HelpText<"When using -finstrument-functions, insert the calls after
inlining">;
--
spatel created this revision.
Herald added a subscriber: mcrosier.
There are 20 LLVM math intrinsics that correspond to mathlib calls according to
the LangRef:
http://llvm.org/docs/LangRef.html#standard-c-library-intrinsics
We were only converting 3 mathlib calls (sqrt, fma, pow) and 12 builtin
bruno added a comment.
Ping!
https://reviews.llvm.org/D33275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
Comment at: include/clang/Driver/Options.td:1032
+def fno_instrument_functions_inline : Flag<["-"],
"fno-instrument-functions-inline">, Group, Flags<[CC1Option]>,
+ HelpText<"When using -finstrument-functions, insert the calls after
inlining">;
---
erichkeane updated this revision to Diff 122883.
erichkeane added a comment.
Fixed for bitfields. Review by anyone greatly appreciated :)
https://reviews.llvm.org/D39347
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
lib/AST/ASTContext.cpp
lib/AST/Type.cpp
lib/Sema/Se
Author: arphaman
Date: Tue Nov 14 10:59:01 2017
New Revision: 318169
URL: http://llvm.org/viewvc/llvm-project?rev=318169&view=rev
Log:
[refactor][extract] avoid extracting expressions from types in functions
Modified:
cfe/trunk/lib/Tooling/Refactoring/ASTSelection.cpp
cfe/trunk/test/Refac
hans updated this revision to Diff 122878.
hans retitled this revision from "Add flags to control the
-finstrument-functions instrumentation calls to __cyg_profile functions" to
"Switch -mcount and -finstrument-functions to emit EnterExitInstrumenter
attributes".
hans edited the summary of this
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks!
https://reviews.llvm.org/D34342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
In https://reviews.llvm.org/D39129#924425, @bader wrote:
> In https://reviews.llvm.org/D39129#923235, @Anastasia wrote:
>
> > In https://reviews.llvm.org/D39129#902848, @bader wrote:
> >
> > > @Anastasia, during the discussion of similar fix
> > > (https://reviews.llvm
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:153
+ if (ReplacementsOrError) {
+C.reply(json::ary{replacementsToEdits(Code, ReplacementsOrError.get())});
+ } else {
NIT: remove braces from single-statement branches
==
ilya-biryukov added a comment.
Sorry, not familiar enough with the AST bits yet to LGTM this.
Looks good from a higher-level perspective, though.
It's a bit of a shame that's it is still super-easy to write code that does not
account for typo-corrected nodes. A more explicit approach, similar to
klimek added a comment.
One interesting trade-off I'm running into:
My gut feeling is that we really want to make local decisions about whether we
want to break/reflow - this makes the code significantly simpler (IMO), and
handles all tests in this patch correctly, but is fundamentally limiting
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
ilya-biryukov added a comment.
In https://reviews.llvm.org/D39843#920568, @sammccall wrote:
> As a very first step, can we make this configurable but off-by-default? That
> will address the pressing diskless-servers need.
I think on-disk by default makes sense now until we do the measurements
ilya-biryukov updated this revision to Diff 122845.
ilya-biryukov added a comment.
Made in-memory preambles optional (on-disk by default).
https://reviews.llvm.org/D39843
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/Cl
Author: sammccall
Date: Tue Nov 14 07:22:34 2017
New Revision: 318154
URL: http://llvm.org/viewvc/llvm-project?rev=318154&view=rev
Log:
[tooling] Make compile_flags.txt negative test more hermetic
Modified:
cfe/trunk/test/Tooling/fixed-database.cpp
Modified: cfe/trunk/test/Tooling/fixed-data
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM! But wait for @dcoughlin, @zaks.anna , or @NoQ before commit.
https://reviews.llvm.org/D37187
___
cfe-commits mailing list
cfe-commit
ilya-biryukov added inline comments.
Comment at: lib/Frontend/ASTUnit.cpp:1028
+IntrusiveRefCntPtr OldVFS = VFS;
+Preamble->AddImplicitPreamble(*CCInvocation, /*ref*/ VFS,
+ OverrideMainBuffer.get());
klimek wrote:
> Since
ilya-biryukov updated this revision to Diff 122838.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Fixed comments.
- Removed /*ref*/ annotations.
- Removed unused "Storage" variable.
- Extract a helper function that properly sets up VFS to access the PCHStorage.
Hahnfeld added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
rjmccall wrote:
> Hahnfeld wrote:
> > rjmccall wrote:
> > > AB
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318152: Make isDefinition matcher support ObjCMethodDecl
(authored by kastiglione).
Repository:
rL LLVM
https://reviews.llvm.org/D39948
Files:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk
Author: kastiglione
Date: Tue Nov 14 06:17:26 2017
New Revision: 318152
URL: http://llvm.org/viewvc/llvm-project?rev=318152&view=rev
Log:
Make isDefinition matcher support ObjCMethodDecl
Summary:
Allow the `isDefinition()` matcher to apply to `ObjCMethodDecl` nodes, in
addition to those it alread
kastiglione updated this revision to Diff 122831.
kastiglione added a comment.
Regenerate AST Matcher docs
https://reviews.llvm.org/D39948
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
Index: unittests/
asb added inline comments.
Comment at: lib/Driver/ToolChains/RISCV.cpp:86
+CmdArgs.push_back("-lc");
+CmdArgs.push_back("-lgloss");
+CmdArgs.push_back("--end-group");
apazos wrote:
> mgrang wrote:
> > How about if our sysroot is linux (as opposed to e
kastiglione updated this revision to Diff 122830.
kastiglione added a comment.
Update isDefinition comment docs to reflect addition of ObjCMethodDecl
https://reviews.llvm.org/D39948
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTM
kastiglione updated this revision to Diff 122829.
kastiglione added a comment.
Add a continue;
https://reviews.llvm.org/D40024
Files:
lib/Tooling/ArgumentsAdjusters.cpp
Index: lib/Tooling/ArgumentsAdjusters.cpp
===
--- lib/Tool
kastiglione created this revision.
The ArgumentsAdjuster returned from `getClangStripDependencyFileAdjuster` will
skip dependency flags, and also their associated values for those flags that
take an argument. This change corrects the handling of the `-MD` and `-MMD`
flags, which do not take an arg
asb created this revision.
Herald added subscribers: jordy.potman.lists, rbar, arichardson.
RISCVABIInfo is implemented in terms of XLen, supporting both RV32 and RV64.
Unfortunately we need to count argument registers in the frontend in order to
determine when to emit signext and zeroext attrib
Attached is a patch that adds two new options,
AllowAllArgumentsOnNextLine and
AllowAllConstructorInitializersOnNextLine. These mirror the existing
AllowAllParametersOfDeclarationOnNextLine and allow me to support an
internal style guide where I work. I think this would be generally
useful, some
Author: arichardson
Date: Tue Nov 14 03:14:25 2017
New Revision: 318144
URL: http://llvm.org/viewvc/llvm-project?rev=318144&view=rev
Log:
Rename identifiers named `__output`
Summary:
In the CHERI clang compiler __output and __input are keywords and therefore
we can't compile libc++ with our compi
lebedev.ri added a comment.
Ping.
In https://reviews.llvm.org/D36836#889375, @aaron.ballman wrote:
> Adding @dberlin for licensing discussion questions.
@dberlin ping? I'm wondering if you had the chance to look at this? :)
Repository:
rL LLVM
https://reviews.llvm.org/D36836
__
xazax.hun added a comment.
In https://reviews.llvm.org/D39049#910482, @NoQ wrote:
> // TODO: once the constraint manager is smart enough to handle non
> simplified
> // symbolic expressions remove this function. Note that this can not be
> used in
> // the constraint manager as is, since
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318150: Make DiagnosticIDs::getAllDiagnostics static. NFC.
(authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D39372?vs=121104&id=122822#toc
Repository:
rL LLVM
https://reviews.l
Author: xazax
Date: Tue Nov 14 04:14:49 2017
New Revision: 318150
URL: http://llvm.org/viewvc/llvm-project?rev=318150&view=rev
Log:
Make DiagnosticIDs::getAllDiagnostics static. NFC.
Patch by: Andras Leitereg!
Differential Revision: https://reviews.llvm.org/D39372
Modified:
cfe/trunk/includ
arichardson created this revision.
Slightly reduces the amount of duplicated code.
https://reviews.llvm.org/D40016
Files:
lib/Sema/SemaOverload.cpp
Index: lib/Sema/SemaOverload.cpp
===
--- lib/Sema/SemaOverload.cpp
+++ lib/Sema
mstorsjo added a comment.
Ping @joerg
https://reviews.llvm.org/D38680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: xazax
Date: Tue Nov 14 03:30:38 2017
New Revision: 318147
URL: http://llvm.org/viewvc/llvm-project?rev=318147&view=rev
Log:
[ASTImporter] TypeAliasTemplate and PackExpansion importing capability
Patch by: Zoltan Gera!
Differential Revision: https://reviews.llvm.org/D39247
Modified:
bader added a comment.
In https://reviews.llvm.org/D39129#923235, @Anastasia wrote:
> In https://reviews.llvm.org/D39129#902848, @bader wrote:
>
> > @Anastasia, during the discussion of similar fix
> > (https://reviews.llvm.org/D34342).
> >
> > I found another bug in the CodeGen library. Do you
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318144: Rename identifiers named `__output` (authored by
arichardson).
Repository:
rL LLVM
https://reviews.llvm.org/D39537
Files:
libcxx/trunk/include/algorithm
libcxx/trunk/include/experimental/a
klimek added a comment.
In https://reviews.llvm.org/D33589#920160, @Typz wrote:
> ping ?
I'm working on understanding this better :) I've refactored the code a bit so I
could fully understand the problem, which I now do (sorry for this taking a
while, but it took me multiple hours to work thr
1 - 100 of 110 matches
Mail list logo
