rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:944
+ /// \brief Whether target supports variable-length arrays.
+ bool isVLASupported() const { return VLASupported; }
+
Hahnfeld wrote:
> rjmccall wrote:
> > The way you've written t
hfinkel added a comment.
In https://reviews.llvm.org/D39611#915799, @efriedma wrote:
> > In general, because all of these functions are well defined over the entire
> > complex domain, they don't have errors. The "no errors defined" is likely
> > correct.
>
> One, it is not true that all these
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317398: CodeGenCXX: no default dllimport storage for mingw
(authored by martell).
Changed prior to commit:
https://reviews.llvm.org/D33620?vs=100523&id=121578#toc
Repository:
rL LLVM
https://reviews
Author: martell
Date: Fri Nov 3 19:15:49 2017
New Revision: 317398
URL: http://llvm.org/viewvc/llvm-project?rev=317398&view=rev
Log:
CodeGenCXX: no default dllimport storage for mingw
GNU frontends don't have options like /MT, /MD
This fixes a few link error regressions with libc++ and libc++abi
Author: martell
Date: Fri Nov 3 19:07:59 2017
New Revision: 317397
URL: http://llvm.org/viewvc/llvm-project?rev=317397&view=rev
Log:
[Driver] MinGW: Remove custom linker detection
This is a re-apply of rL313082 which was reverted in rL313088
In rL289668 the ability to specify the default linker
efriedma added a comment.
> In general, because all of these functions are well defined over the entire
> complex domain, they don't have errors. The "no errors defined" is likely
> correct.
One, it is not true that all these functions are well-defined over the entire
complex domain. For exam
Author: rtrieu
Date: Fri Nov 3 18:20:50 2017
New Revision: 317394
URL: http://llvm.org/viewvc/llvm-project?rev=317394&view=rev
Log:
Update ODR hashing tests
Add a mix of postive and negative tests to check that wrong Decls won't be
flagged in the diagnostic. Split the check everything test and
hfinkel added a comment.
In https://reviews.llvm.org/D39611#915560, @efriedma wrote:
> > The POSIX docs all have language like this for complex calls:
> > "No errors are defined."
>
> I would not trust the POSIX documentation.
>
> carg() is an alias for atan2(), and cabs() is an alias for hypot(
For now it is gone in the meaning that you don’t have to dedicate time and
effort to support this configuration. But I wouldn’t say that taking other
dependencies on llvm is welcome. In this aspect nothing has changed.
> On Nov 3, 2017, at 15:22, Zachary Turner wrote:
>
> The reason I ask is b
When you say "symbols table" - what are you referring to?
On Fri, Nov 3, 2017 at 4:20 PM Adrian Prantl via Phabricator <
revi...@reviews.llvm.org> wrote:
> aprantl added a comment.
>
> Can you add a testcase?
>
>
> Repository:
> rL LLVM
>
> https://reviews.llvm.org/D39622
>
>
>
>
__
aprantl added inline comments.
Comment at: include/clang/AST/PrettyPrinter.h:68
/// \brief The number of spaces to use to indent each line.
- unsigned Indentation : 8;
+ unsigned Indentation : 7;
this change looks like it has the potential to break existin
aprantl added inline comments.
Comment at: include/clang/AST/PrettyPrinter.h:227
+
+ /// \brief Use formatting compatible with ABI specification. It is necessary
for
+ /// saving entities into debug tables which have to be compatible with
Te \brief is redundan
aprantl added a comment.
Can you add a testcase?
Repository:
rL LLVM
https://reviews.llvm.org/D39622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xgsa created this revision.
xgsa added a project: clang.
Herald added a subscriber: aprantl.
Currently, there is an inconsistency between type name record in ".apple_types"
section and entry in symbols table for the same type. In particular, for such
types lldb is unable to resolve the real type
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D39615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: eugenezelenko
Date: Fri Nov 3 15:35:27 2017
New Revision: 317381
URL: http://llvm.org/viewvc/llvm-project?rev=317381&view=rev
Log:
[Basic] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/Basic/IdentifierTabl
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
The reason I ask is because I remember several months ago when I originally
made these changes, there was quite a bit of difficulty because some of the
Jenkins builders were wanting to run libcxx tests without any llvm source
tree on the machine.
Does this configuration still exist, or is it gone?
rsmith added a comment.
I'm still unconvinced that this mechanism is worth supporting.
The use case of putting this information into .d files doesn't make sense to
me. .d files are generally outputs of prior compilations, whereas this
information is a compilation input, needed in every compilat
We have llvm source tree next to libcxx and configure libcxx with -DLLVM_PATH.
> On Nov 2, 2017, at 16:53, Zachary Turner wrote:
>
> No problem. If you don't mind me asking, what was the configuration change
> you made? Or do you have a link to the patch which fixed it that I can look
> at?
george.karpenkov created this revision.
Herald added subscribers: szepet, xazax.hun.
https://reviews.llvm.org/D39620
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h
Index: include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h
==
Author: arphaman
Date: Fri Nov 3 14:31:10 2017
New Revision: 317372
URL: http://llvm.org/viewvc/llvm-project?rev=317372&view=rev
Log:
Add -fcxx-exceptions for ExtractionSemicolonPolicy.cpp to appease PS4 bots
Modified:
cfe/trunk/test/Refactor/Extract/ExtractionSemicolonPolicy.cpp
Modified:
gtbercea updated this revision to Diff 121543.
gtbercea edited the summary of this revision.
gtbercea added a comment.
Remove blocks.
https://reviews.llvm.org/D38976
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGOpenMPRuntimeNVPTX.h
test/OpenMP/nvptx_data_sharing.cpp
test/Op
efriedma added inline comments.
Comment at: include/clang/Basic/Builtins.def:169
+// Disregard that 'cbrt' could set errno with a NaN input. The C standard says
+// that NaN arguments generally do not raise FP exceptions.
+BUILTIN(__builtin_cbrt , "dd", "Fnc")
No
Hello Alex,
This commit broke tests on few builders:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
. . .
Failing Tests (1):
Clang :: Refactor/Extract/Extract
efriedma added a comment.
> The POSIX docs all have language like this for complex calls:
> "No errors are defined."
I would not trust the POSIX documentation.
carg() is an alias for atan2(), and cabs() is an alias for hypot(), so they
should be marked the same way. (On glibc, cabs/hypot will
gtbercea updated this revision to Diff 121538.
Repository:
rL LLVM
https://reviews.llvm.org/D38976
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGOpenMPRuntimeNVPTX.h
test/OpenMP/nvptx_data_sharing.cpp
test/OpenMP/nvptx_parallel_codegen.cpp
test/OpenMP/nvptx_target_teams_c
spatel created this revision.
Herald added a subscriber: mcrosier.
I assume this is just an oversight because we already do recognize
__builtin_remquo() with the same signature.
http://en.cppreference.com/w/c/numeric/math/remquo
http://pubs.opengroup.org/onlinepubs/9699919799/functions/remquo.ht
Author: aaronballman
Date: Fri Nov 3 13:09:17 2017
New Revision: 317359
URL: http://llvm.org/viewvc/llvm-project?rev=317359&view=rev
Log:
Replace a use of std::for_each() with llvm::for_each(); NFC.
Modified:
cfe/trunk/lib/Sema/SemaPseudoObject.cpp
Modified: cfe/trunk/lib/Sema/SemaPseudoObj
Hahnfeld added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:2393
+
+ // Level0(CGF);
+
Is this meant to be a comment or should there be something happening here?
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:2396
+ CGF
EricWF requested changes to this revision.
EricWF added inline comments.
This revision now requires changes to proceed.
Comment at: include/type_traits:4746
+big= 0xFACE,
+#if _LIBCPP_LITTLE_ENDIAN
+native = little
These macros have been changed to be
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D38976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
rwols marked 2 inline comments as done.
rwols added inline comments.
Comment at: clangd/ClangdServer.cpp:41
// Call clang-format.
- // FIXME: Don't ignore style.
- format::FormatStyle Style = format::getLLVMStyle();
- auto Result = format::reformat(Style, Code, Ranges, File
rwols updated this revision to Diff 121524.
rwols added a comment.
Use llvm::Error for beautiful handling of errors.
It's perhaps an idea to write a `replyExpected(llvm::Expected)`, that will
transparently handle `llvm::Error`s.
I'll write a unit test for these changes next.
It's probably best
aaron.ballman added a comment.
In https://reviews.llvm.org/D39121#915441, @baloghadamsoftware wrote:
> In https://reviews.llvm.org/D39121#915123, @aaron.ballman wrote:
>
> > Out of curiosity, were there any true positives, either?
>
>
> No, in a release version there should be no true positives o
aaron.ballman accepted this revision.
aaron.ballman added a comment.
Aside from some minor commenting nits, this LGTM.
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:445
+ // Do not bind to double negation, it is uneffective.
const auto NegateNegateRelationalExp
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D39121#915123, @aaron.ballman wrote:
> Out of curiosity, were there any true positives, either?
No, in a release version there should be no true positives of this kind, I
think.
https://reviews.llvm.org/D39121
___
aaron.ballman added a comment.
In https://reviews.llvm.org/D33722#915134, @xazax.hun wrote:
> Two problems are not resolved. One is Aaron prefers to query some infor from
> the AST instead of relexing. The second is providing base initializers in the
> wrong order.
> I think there are other ch
spatel created this revision.
Herald added a subscriber: mcrosier.
These are 3 errno-related diffs raised in D39841.
1. Cube root
We're going to dismiss POSIX language like this:
"On successful completion, cbrt() returns the cube root of x. If x is NaN,
cbrt() returns NaN and errno may be set t
Author: cryptoad
Date: Fri Nov 3 10:04:13 2017
New Revision: 317337
URL: http://llvm.org/viewvc/llvm-project?rev=317337&view=rev
Log:
[Driver] Add Scudo as a possible -fsanitize= option
Summary:
This change adds Scudo as a possible Sanitizer option via -fsanitize=.
This allows for easier static
Author: arphaman
Date: Fri Nov 3 11:21:06 2017
New Revision: 317344
URL: http://llvm.org/viewvc/llvm-project?rev=317344&view=rev
Log:
Move Extract.cpp that wasn't moved in r317343
Added:
cfe/trunk/lib/Tooling/Refactoring/Extract/Extract.cpp
Removed:
cfe/trunk/lib/Tooling/Refactoring/Extr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317343: [refactor][extract] insert semicolons into
extracted/inserted code (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D39441?vs=121339&id=121516#toc
Repository:
rL LLVM
Author: arphaman
Date: Fri Nov 3 11:11:22 2017
New Revision: 317343
URL: http://llvm.org/viewvc/llvm-project?rev=317343&view=rev
Log:
[refactor][extract] insert semicolons into extracted/inserted code
when needed
This commit implements the semicolon insertion logic into the extract
refactoring.
sugak added a comment.
@djasper: would you accept and push this for me :)
https://reviews.llvm.org/D39587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun created this revision.
Herald added subscribers: baloghadamsoftware, whisperity.
Currently relative paths wasn't supperted by run-clang-tidy.py
I added the support, however I did not find any existing tests. Is it ok for
this to land without a test or should I introduce one?
https://
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D39419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: spatel
Date: Fri Nov 3 09:27:27 2017
New Revision: 317336
URL: http://llvm.org/viewvc/llvm-project?rev=317336&view=rev
Log:
[CodeGen] add libcall attr tests to show errno-related diffs; NFC
See rL317220 for the builtin siblings.
Added:
cfe/trunk/test/CodeGen/libcalls-errno.c
Added:
nik added a comment.
Ping...
https://reviews.llvm.org/D37554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Fri Nov 3 09:03:56 2017
New Revision: 317333
URL: http://llvm.org/viewvc/llvm-project?rev=317333&view=rev
Log:
Use ToolExecutor framework in the sample tool-template.
Modified:
clang-tools-extra/trunk/tool-template/CMakeLists.txt
clang-tools-extra/trunk/tool-template
Author: ioeric
Date: Fri Nov 3 08:57:27 2017
New Revision: 317332
URL: http://llvm.org/viewvc/llvm-project?rev=317332&view=rev
Log:
[Tooling] Fix linking of StandaloneToolExecutorPlugin.
Modified:
cfe/trunk/lib/Tooling/Execution.cpp
cfe/trunk/lib/Tooling/StandaloneExecution.cpp
cfe/t
malaperle requested changes to this revision.
malaperle added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/ClangdLSPServer.cpp:51
+ "definitionProvider": true,
+ "configurationChangeProvider": true
}})");
--
Author: ioeric
Date: Fri Nov 3 08:20:57 2017
New Revision: 317328
URL: http://llvm.org/viewvc/llvm-project?rev=317328&view=rev
Log:
[Tooling] Put createExecutorFromCommandLineArgs implementation in a wrapper. NFC
Modified:
cfe/trunk/include/clang/Tooling/Execution.h
cfe/trunk/lib/Tooling
xazax.hun marked 5 inline comments as done.
xazax.hun added a comment.
Two problems are not resolved. One is Aaron prefers to query some infor from
the AST instead of relexing. The second is providing base initializers in the
wrong order.
I think there are other checks that do relexing in some c
xazax.hun updated this revision to Diff 121477.
xazax.hun added a comment.
- Dominic said he no longer have time to continue with this patch, so I
commandeered this revision
- Skip template instantiations
- Do not attempt fix macro expansions
- Do not attempt fix type aliases and typedef types
-
aaron.ballman added a comment.
In https://reviews.llvm.org/D39121#914871, @baloghadamsoftware wrote:
> I tested it on a C project (Postgres) and found no false positives.
Out of curiosity, were there any true positives, either?
https://reviews.llvm.org/D39121
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317325: [clang-format] Sort using-declarations case
sensitively with a special case for… (authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D39549
Files:
cfe/trunk/lib/Format/Using
Author: krasimir
Date: Fri Nov 3 07:38:07 2017
New Revision: 317325
URL: http://llvm.org/viewvc/llvm-project?rev=317325&view=rev
Log:
[clang-format] Sort using-declarations case sensitively with a special case for
'_'
Summary:
This makes clang-format sort using declarations case-sensitive with
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg, thanks!
https://reviews.llvm.org/D39549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
krasimir updated this revision to Diff 121475.
krasimir added a comment.
- Address review comment
https://reviews.llvm.org/D39549
Files:
lib/Format/UsingDeclarationsSorter.cpp
unittests/Format/UsingDeclarationsSorterTest.cpp
Index: unittests/Format/UsingDeclarationsSorterTest.cpp
=
Author: malaperle
Date: Fri Nov 3 06:39:15 2017
New Revision: 317322
URL: http://llvm.org/viewvc/llvm-project?rev=317322&view=rev
Log:
[clangd] Handle clangd.applyFix server-side
Summary:
When the user selects a fix-it (or any code action with commands), it is
possible to let the client forward
krasimir added a comment.
How about this trade-off? I don't really want to re-implement comparison (it
makes the code harder to read), so I replaced the state with an explicit
computation.
https://reviews.llvm.org/D39549
___
cfe-commits mailing li
krasimir updated this revision to Diff 121465.
krasimir added a comment.
- Remove SortLabel
https://reviews.llvm.org/D39549
Files:
lib/Format/UsingDeclarationsSorter.cpp
unittests/Format/UsingDeclarationsSorterTest.cpp
Index: unittests/Format/UsingDeclarationsSorterTest.cpp
===
baloghadamsoftware added a comment.
Thank you for you work! Probably I did some mistake because my MAX/4solution
did not work when I it earlier. Your solution seems to work. For the iterator
checkers this is surely enough. Should I upload my patch patched with your one?
https://reviews.llvm.or
martell updated this revision to Diff 121462.
martell edited the summary of this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D39588
Files:
include/clang/Driver/Distro.h
lib/Driver/Distro.cpp
lib/Driver/ToolChains/Linux.cpp
test/Driver/pic.c
Index: test/Driver/pic.c
===
hokein added inline comments.
Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101
+ std::string NewQualifiedName) {
+ return QualifiedRenameRule(std::move(OldQualifiedName),
+ std::move(NewQualifiedName));
--
hokein updated this revision to Diff 121456.
hokein marked an inline comment as done.
hokein added a comment.
Document the qualified rename.
https://reviews.llvm.org/D39332
Files:
include/clang/Tooling/Refactoring/Rename/RenamingAction.h
lib/Tooling/Refactoring/RefactoringActions.cpp
lib/
yamaguchi updated this revision to Diff 121449.
yamaguchi added a comment.
Made a trivial fix in the testcase
https://reviews.llvm.org/D39342
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/l
jkorous-apple updated this revision to Diff 121448.
jkorous-apple added a comment.
newline at the end of test file
https://reviews.llvm.org/D39419
Files:
lib/Parse/ParseExprCXX.cpp
test/Parser/objcxx11-invalid-lambda.cpp
Index: test/Parser/objcxx11-invalid-lambda.cpp
=
jkorous-apple added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:1020
- PA.Commit();
- return false;
+ PA2.Revert();
+ return true;
arphaman wrote:
> Just to clarify: It seems like this revert (in addition to two TPAs) is the
> main addition. Di
Author: erikjv
Date: Fri Nov 3 02:40:07 2017
New Revision: 317308
URL: http://llvm.org/viewvc/llvm-project?rev=317308&view=rev
Log:
[preamble] Also record the "skipping" state of the preprocessor
When a preamble ends in a conditional preprocessor block that is being
skipped, the preprocessor nee
yamaguchi updated this revision to Diff 121444.
yamaguchi added a comment.
Herald added a subscriber: hiraditya.
Update diff. Pass all flags just with "," including values.
https://reviews.llvm.org/D39342
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
clang/test/Dr
erikjv added a comment.
The patch has aged a bit since upload, so does it still apply? And, can you add
a testcase please?
Repository:
rL LLVM
https://reviews.llvm.org/D20124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
djasper added a comment.
Looks good, thank you.
https://reviews.llvm.org/D39587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D39121#914875, @Abpostelnicu wrote:
> I can test this on our repo, Mozilla, since it's a large code-base I think we
> you will have a better understanding of the false-positive ratio.
Thank you in advance!
https://reviews.llvm.o
Abpostelnicu added a comment.
I can test this on our repo, Mozilla, since it's a large code-base I think we
you will have a better understanding of the false-positive ratio.
https://reviews.llvm.org/D39121
___
cfe-commits mailing list
cfe-commits@l
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D39441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
baloghadamsoftware added a comment.
I tested it on a C project (Postgres) and found no false positives.
https://reviews.llvm.org/D39121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
boris added a comment.
Ping.
https://reviews.llvm.org/D37299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo added inline comments.
Comment at: src/UnwindRegistersRestore.S:396
.fpu vfpv3-d16
+#endif
DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm19restoreVFPWithFLDMDEPy)
mstorsjo wrote:
> compnerd wrote:
> > This really isn't an ELF vs COFF
79 matches
Mail list logo
