[PATCH] D39419: Fix crash when parsing objective-c++ containing invalid lambda

arphaman added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:1020 - PA.Commit(); - return false; + PA2.Revert(); + return true; Just to clarify: It seems like this revert (in addition to two TPAs) is the main addition. Did we hit the assertion pr

[PATCH] D39588: Distro: initial support for alpine

martell created this revision. Add alpine linux as a distro. We support building for musl since https://reviews.llvm.org/rL292848. Let's add this important docker / kubernetes empowering distro. Some bits are still missing but this is a good base. Repository: rL LLVM https://reviews.llvm.org

[PATCH] D39587: [clang-format] Handle unary operator overload with arguments and specifiers

sugak created this revision. Before: int operator++(int)noexcept; After: int operator++(int) noexcept; https://reviews.llvm.org/D39587 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ===

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

alexshap updated this revision to Diff 121431. alexshap added a comment. 1. Add no-warning comments 2. Switch to using a cached IdentifierInfo (similar to how it's done in CheckObjCDealloc.cpp) 3. Rerun the all the tests - they are fine. @dcoughlin - many thanks for the code review, yeah, i will

[PATCH] D39586: [CUDA] Mark CUDA as a no-errno platform.

This revision was automatically updated to reflect the committed changes. Closed by commit rL317297: [CUDA] Mark CUDA as a no-errno platform. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D39586?vs=121427&id=121429#toc Repository: rL LLVM https://reviews.llvm.org/D

r317297 - [CUDA] Mark CUDA as a no-errno platform.

Author: jlebar Date: Thu Nov 2 19:30:00 2017 New Revision: 317297 URL: http://llvm.org/viewvc/llvm-project?rev=317297&view=rev Log: [CUDA] Mark CUDA as a no-errno platform. Summary: CUDA doesn't support errno at all, so this is the right thing -- or at least, in the right direction. But also, t

[PATCH] D39586: [CUDA] Mark CUDA as a no-errno platform.

jlebar created this revision. CUDA doesn't support errno at all, so this is the right thing -- or at least, in the right direction. But also, this unbreaks the CUDA test-suite math tests [0] after https://reviews.llvm.org/D39481. __cuda_cmath.h forwards nexttoward() to __builtin_nexttoward, whic

r317296 - [c++17] Visit class template explicit specializations just like all other class definitions in codegen.

Author: rsmith Date: Thu Nov 2 18:26:01 2017 New Revision: 317296 URL: http://llvm.org/viewvc/llvm-project?rev=317296&view=rev Log: [c++17] Visit class template explicit specializations just like all other class definitions in codegen. If an explicit specialization has a static data member, it

[PATCH] D39584: [analyzer] [NFC] another very minor ExprEngineC refactoring

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun. couldn't resist adding a function here. I think this would be the last one. https://reviews.llvm.org/D39584 Files: lib/StaticAnalyzer/Core/ExprEngineC.cpp Index: lib/StaticAnalyzer/Core/ExprEngineC.cpp

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

dcoughlin added a comment. Thanks! Another round of comments inline. With those addressed it looks good to me -- but you should wait on Artem's go-ahead before committing. Comment at: lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp:121 +QualType Q = C.getVariable()

[PATCH] D39577: [analyzer] [NFC] very minor ExprEngineC refactoring

This revision was automatically updated to reflect the committed changes. Closed by commit rL317294: [analyzer] [NFC] very minor ExprEngineC refactoring (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39577?vs=121401&id=121424#toc Repository: rL LLVM https

r317294 - [analyzer] [NFC] very minor ExprEngineC refactoring

Author: george.karpenkov Date: Thu Nov 2 17:41:29 2017 New Revision: 317294 URL: http://llvm.org/viewvc/llvm-project?rev=317294&view=rev Log: [analyzer] [NFC] very minor ExprEngineC refactoring Differential Revision: https://reviews.llvm.org/D39577 Modified: cfe/trunk/lib/StaticAnalyzer/Cor

[PATCH] D39577: [analyzer] [NFC] very minor ExprEngineC refactoring

george.karpenkov added a comment. @dcoughlin thanks for accepting quickly, actually the whole file has a very large amount of duplicated code, but I guess we can't do it right now. https://reviews.llvm.org/D39577 ___ cfe-commits mailing list cfe-co

r317293 - [analyzer] do not crash on libcxx03 call_once implementation

Author: george.karpenkov Date: Thu Nov 2 17:36:03 2017 New Revision: 317293 URL: http://llvm.org/viewvc/llvm-project?rev=317293&view=rev Log: [analyzer] do not crash on libcxx03 call_once implementation Addresses https://bugs.llvm.org/show_bug.cgi?id=35075, rdar://35230961 Differential Revision

[PATCH] D39518: [analyzer] do not crash on libcxx03 call_once implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL317293: [analyzer] do not crash on libcxx03 call_once implementation (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39518?vs=121418&id=121423#toc Repository: rL LL

[PATCH] D39579: BuiltinOperatorOverloadBuilder: Don't consider types that are unavailable on the target (PR35174)

rsmith added inline comments. Comment at: lib/Sema/SemaOverload.cpp:7669 +// End of integral types. +// FIXME: What about complex? What about half?/ } Spurious trailing slash. Comment at: lib/Sema/SemaOverload.cpp:7731-7746 // V

[PATCH] D39577: [analyzer] [NFC] very minor ExprEngineC refactoring

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. It is a nice cleanup. https://reviews.llvm.org/D39577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D39518: [analyzer] do not crash on libcxx03 call_once implementation

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks great. Thank you! https://reviews.llvm.org/D39518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D39518: [analyzer] do not crash on libcxx03 call_once implementation

george.karpenkov updated this revision to Diff 121418. https://reviews.llvm.org/D39518 Files: lib/Analysis/BodyFarm.cpp test/Analysis/call_once.cpp Index: test/Analysis/call_once.cpp === --- test/Analysis/call_once.cpp +++ test/

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

No problem. If you don't mind me asking, what was the configuration change you made? Or do you have a link to the patch which fixed it that I can look at? On Thu, Nov 2, 2017 at 4:43 PM Volodymyr Sapsai via Phabricator < revi...@reviews.llvm.org> wrote: > vsapsai abandoned this revision. > vsap

[PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

vsapsai abandoned this revision. vsapsai added a comment. Fixed by changing libcxx build configuration, no CMake change required. https://reviews.llvm.org/D39520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

Thanks for explanation, Zachary. We’ve fixed the buildbots in a different way, so I’ll discard this patch. > On Nov 2, 2017, at 16:06, Zachary Turner wrote: > > Yes that is the reason. But in a way it is more than that, because if those > variables aren't available to lit.cfg, then test suite

[PATCH] D39502: [Driver] Make clang/cc conforms to UNIX standard

steven_wu updated this revision to Diff 121410. steven_wu added a comment. Fix testcase. My test was passing because files left over from previous run. Now it should work with a clean build. https://reviews.llvm.org/D39502 Files: lib/Driver/Compilation.cpp test/Driver/output-file-cleanup.c

[PATCH] D39579: BuiltinOperatorOverloadBuilder: Don't consider types that are unavailable on the target (PR35174)

hans created this revision. In the test case, we'd end up in a situation where Clang tried to mangle the __float128 types, which isn't supported when targeting MSVC, because it instantiated a variable template with that type when searching for a conversion. https://reviews.llvm.org/D39579 Fil

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

Yes that is the reason. But in a way it is more than that, because if those variables aren't available to lit.cfg, then test suite won't work. lit *must* be able to find a site config. There are three ways to get around this: 1) When you run lit.py, pass it a directory to your build tree. Then

[PATCH] D39502: [Driver] Make clang/cc conforms to UNIX standard

dexonsmith added a comment. In https://reviews.llvm.org/D39502#914667, @steven_wu wrote: > Also split out the testcase for UNIX conformance. That test is not related > to output file cleanup. Split it out to make it clear that is for UNIX > conformance. Great idea. Confirming this LGTM once

[PATCH] D39502: [Driver] Make clang/cc conforms to UNIX standard

steven_wu updated this revision to Diff 121403. steven_wu added a comment. Address review feedback. Also split out the testcase for UNIX conformance. That test is not related to output file cleanup. Split it out to make it clear that is for UNIX conformance. https://reviews.llvm.org/D39502 Fil

[PATCH] D39577: [analyzer] [NFC] very minor ExprEngineC refactoring

george.karpenkov created this revision. Herald added subscribers: szepet, xazax.hun. https://reviews.llvm.org/D39577 Files: lib/StaticAnalyzer/Core/ExprEngineC.cpp Index: lib/StaticAnalyzer/Core/ExprEngineC.cpp === --- lib/Static

[PATCH] D39518: [analyzer] do not crash on libcxx03 call_once implementation

dcoughlin added a comment. In https://reviews.llvm.org/D39518#914515, @george.karpenkov wrote: > Updated the diff, addressed review concerns. > Made it more explicit in comments in tests that we do not crash on libcxx03 > implementation, but that we don't model it either. > > @dcoughlin sorry I

Re: [PATCH] D39520: [libcxx][CMake] Fix libc++ build when no LLVM source tree is available.

On Nov 1, 2017, at 17:22, Zachary Turner wrote: > > > > On Wed, Nov 1, 2017 at 5:13 PM Volodymyr Sapsai > wrote: > On Nov 1, 2017, at 16:47, Zachary Turner > wrote: >> >> This will remove the ability to use llvm-lit script even if source t

[PATCH] D39430: [clangd] formatting: don't ignore style

rwols added inline comments. Comment at: clangd/ClangdLSPServer.cpp:93 +void ClangdLSPServer::replyWithTextEditsOrError( +Ctx C, std::string Code, sammccall wrote: > This function is pretty hard to understand from a high level - it's a bit of > an odd spli

r317279 - Modular Codegen: Don't home always_inline functions

Author: dblaikie Date: Thu Nov 2 15:28:50 2017 New Revision: 317279 URL: http://llvm.org/viewvc/llvm-project?rev=317279&view=rev Log: Modular Codegen: Don't home always_inline functions Since they'll likely (not always - if the address is taken, etc) be inlined away, even at -O0, separately prov

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

bsdjhb updated this revision to Diff 121396. bsdjhb added a comment. - Rebase. - Update O32 cursor size after unw_word_t change. https://reviews.llvm.org/D38110 Files: include/__libunwind_config.h include/libunwind.h src/Registers.hpp src/UnwindCursor.hpp src/UnwindRegistersRestore.S

r317274 - Modular Codegen: Don't home/modularize static functions in headers

Author: dblaikie Date: Thu Nov 2 14:55:40 2017 New Revision: 317274 URL: http://llvm.org/viewvc/llvm-project?rev=317274&view=rev Log: Modular Codegen: Don't home/modularize static functions in headers Consistent with various workarounds in the backwards compatible modules that allow static funct

r317273 - [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Thu Nov 2 14:45:30 2017 New Revision: 317273 URL: http://llvm.org/viewvc/llvm-project?rev=317273&view=rev Log: [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Serializatio

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

Nebiroth created this revision. Implementation of DidChangeConfiguration notification handling in clangd. This currently only supports changing one setting: the path of the compilation database to be used for the current project In other words, it is no longer necessary to restart clangd with a d

[PATCH] D38986: [Analyzer] Better unreachable message in enumeration

george.karpenkov abandoned this revision. george.karpenkov added a comment. @dcoughlin OK, I guess you could theoretically come up with a scenario where an error in this code would lead to crashing-while-crashing which would obscure the original error. https://reviews.llvm.org/D38986 __

[PATCH] D39518: [analyzer] do not crash on libcxx03 call_once implementation

george.karpenkov updated this revision to Diff 121371. george.karpenkov added a comment. Updated the diff, addressed review concerns. Made it more explicit in comments in tests that we do not crash on libcxx03 implementation, but that we don't model it either. @dcoughlin sorry I disagree on prev

[PATCH] D39210: Add default calling convention support for regcall.

This revision was automatically updated to reflect the committed changes. Closed by commit rL317268: Add default calling convention support for regcall. (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D39210?vs=120284&id=121372#toc Repository: rL LLVM https://rev

[PATCH] D39210: Add default calling convention support for regcall.

eandrews added a comment. No problem! Thanks! https://reviews.llvm.org/D39210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r317268 - Add default calling convention support for regcall.

Author: erichkeane Date: Thu Nov 2 14:08:00 2017 New Revision: 317268 URL: http://llvm.org/viewvc/llvm-project?rev=317268&view=rev Log: Add default calling convention support for regcall. Added support for regcall as default calling convention. Also added code to exclude main when applying defau

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

ahatanak added a comment. This is tracked by rdar://problem/34363596. https://reviews.llvm.org/D39562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39534: [libunwind] Add ifdefs around ELF specific parts of UnwindRegisters*.S for ARM

mstorsjo added inline comments. Comment at: src/UnwindRegistersRestore.S:396 .fpu vfpv3-d16 +#endif DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm19restoreVFPWithFLDMDEPy) compnerd wrote: > This really isn't an ELF vs COFF/Mach-O thing. Does

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

This revision was automatically updated to reflect the committed changes. Closed by commit rL317265: [CodeGen] fix const-ness of builtin equivalents of and … (authored by spatel). Changed prior to commit: https://reviews.llvm.org/D39481?vs=121344&id=121363#toc Repository: rL LLVM https://r

r317265 - [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

Author: spatel Date: Thu Nov 2 13:39:26 2017 New Revision: 317265 URL: http://llvm.org/viewvc/llvm-project?rev=317265&view=rev Log: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno This just makes const-ness of the builtins match const-ness of their lib f

[PATCH] D39534: [libunwind] Add ifdefs around ELF specific parts of UnwindRegisters*.S for ARM

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: src/UnwindRegistersRestore.S:396 .fpu vfpv3-d16 +#endif DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm19restoreVFPWithFLDMD

[PATCH] D39551: [analyzer] Make __builtin_debugtrap() a sink

xazax.hun abandoned this revision. xazax.hun added a comment. In https://reviews.llvm.org/D39551#914360, @dcoughlin wrote: > I believe that the intent of `__builtin_debugtrap()` is to provide an > in-source mechanism so that the developer can trap into the debugger and then > continue executi

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. (For reference, lgamma is weird because of the POSIX signgam.) https://reviews.llvm.org/D39481 ___ cfe-commits mailing list cfe-commit

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

belleyb added a comment. Autodesk would also like to see this fix merged into LLVM 5.0.1 and we also agree about the importance of having a regression tests. @sylvestre.ledru : Is someone on the Firefox team working on writing a unit test for this ? Shall we jump-in and try to help ? https://

[PATCH] D39551: [analyzer] Make __builtin_debugtrap() a sink

dcoughlin added a comment. I believe that the intent of `__builtin_debugtrap()` is to provide an in-source mechanism so that the developer can trap into the debugger and then continue execution. For example, in the Swift codebase this is used in combination with a debug flag to break into the d

[PATCH] D39210: Add default calling convention support for regcall.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good! Sorry for the delay. https://reviews.llvm.org/D39210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[clang-tools-extra] r317261 - Update release notes (check SVN commit-after-approval access)

Author: benhamilton Date: Thu Nov 2 13:00:17 2017 New Revision: 317261 URL: http://llvm.org/viewvc/llvm-project?rev=317261&view=rev Log: Update release notes (check SVN commit-after-approval access) Summary: I was just granted commit-after-approval access to SVN, and @clattner recommended I try

[libclc] r317259 - tanh: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:58 2017 New Revision: 317259 URL: http://llvm.org/viewvc/llvm-project?rev=317259&view=rev Log: tanh: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/tanh.inc M

[libclc] r317260 - tgamma: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:49:00 2017 New Revision: 317260 URL: http://llvm.org/viewvc/llvm-project?rev=317260&view=rev Log: tgamma: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/tgamma.i

[libclc] r317258 - tan: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:57 2017 New Revision: 317258 URL: http://llvm.org/viewvc/llvm-project?rev=317258&view=rev Log: tan: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/tan.inc Mod

[libclc] r317256 - sinpi: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:53 2017 New Revision: 317256 URL: http://llvm.org/viewvc/llvm-project?rev=317256&view=rev Log: sinpi: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/sinpi.inc

[libclc] r317257 - sqrt: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:55 2017 New Revision: 317257 URL: http://llvm.org/viewvc/llvm-project?rev=317257&view=rev Log: sqrt: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/sqrt.inc M

[libclc] r317252 - native_log2: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:46 2017 New Revision: 317252 URL: http://llvm.org/viewvc/llvm-project?rev=317252&view=rev Log: native_log2: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/nat

[libclc] r317255 - sinh: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:51 2017 New Revision: 317255 URL: http://llvm.org/viewvc/llvm-project?rev=317255&view=rev Log: sinh: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/sinh.inc M

[libclc] r317253 - native_log: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:48 2017 New Revision: 317253 URL: http://llvm.org/viewvc/llvm-project?rev=317253&view=rev Log: native_log: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/nati

[libclc] r317254 - sin: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:50 2017 New Revision: 317254 URL: http://llvm.org/viewvc/llvm-project?rev=317254&view=rev Log: sin: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/sin.inc Mod

[libclc] r317251 - native_log10: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:44 2017 New Revision: 317251 URL: http://llvm.org/viewvc/llvm-project?rev=317251&view=rev Log: native_log10: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/na

[libclc] r317250 - log: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:43 2017 New Revision: 317250 URL: http://llvm.org/viewvc/llvm-project?rev=317250&view=rev Log: log: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/log.inc Mod

[libclc] r317249 - logb: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:41 2017 New Revision: 317249 URL: http://llvm.org/viewvc/llvm-project?rev=317249&view=rev Log: logb: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/logb.inc M

[libclc] r317248 - log2: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:39 2017 New Revision: 317248 URL: http://llvm.org/viewvc/llvm-project?rev=317248&view=rev Log: log2: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/log2.inc M

[libclc] r317246 - lgamma: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:35 2017 New Revision: 317246 URL: http://llvm.org/viewvc/llvm-project?rev=317246&view=rev Log: lgamma: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/lgamma.i

[libclc] r317247 - log1p: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:37 2017 New Revision: 317247 URL: http://llvm.org/viewvc/llvm-project?rev=317247&view=rev Log: log1p: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/log1p.inc

[libclc] r317243 - cosh: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:30 2017 New Revision: 317243 URL: http://llvm.org/viewvc/llvm-project?rev=317243&view=rev Log: cosh: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/cosh.inc M

[libclc] r317245 - exp2: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:33 2017 New Revision: 317245 URL: http://llvm.org/viewvc/llvm-project?rev=317245&view=rev Log: exp2: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/exp2.inc M

[libclc] r317242 - cos: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:27 2017 New Revision: 317242 URL: http://llvm.org/viewvc/llvm-project?rev=317242&view=rev Log: cos: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/cos.inc Mod

[libclc] r317244 - cospi: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:31 2017 New Revision: 317244 URL: http://llvm.org/viewvc/llvm-project?rev=317244&view=rev Log: cospi: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/cospi.inc

[libclc] r317234 - acospi: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:13 2017 New Revision: 317234 URL: http://llvm.org/viewvc/llvm-project?rev=317234&view=rev Log: acospi: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/acospi.i

[libclc] r317240 - atanpi: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:23 2017 New Revision: 317240 URL: http://llvm.org/viewvc/llvm-project?rev=317240&view=rev Log: atanpi: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/atanpi.i

[libclc] r317235 - asin: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:15 2017 New Revision: 317235 URL: http://llvm.org/viewvc/llvm-project?rev=317235&view=rev Log: asin: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/asin.inc M

[libclc] r317237 - asinpi: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:18 2017 New Revision: 317237 URL: http://llvm.org/viewvc/llvm-project?rev=317237&view=rev Log: asinpi: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/asinpi.i

[libclc] r317241 - cbrt: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:25 2017 New Revision: 317241 URL: http://llvm.org/viewvc/llvm-project?rev=317241&view=rev Log: cbrt: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/cbrt.inc M

[libclc] r317236 - asinh: Use unary_dec instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:16 2017 New Revision: 317236 URL: http://llvm.org/viewvc/llvm-project?rev=317236&view=rev Log: asinh: Use unary_dec instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/asinh.inc

[libclc] r317238 - atan: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:20 2017 New Revision: 317238 URL: http://llvm.org/viewvc/llvm-project?rev=317238&view=rev Log: atan: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/atan.inc M

[libclc] r317239 - atanh: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:22 2017 New Revision: 317239 URL: http://llvm.org/viewvc/llvm-project?rev=317239&view=rev Log: atanh: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/atanh.inc

[libclc] r317233 - acosh: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:11 2017 New Revision: 317233 URL: http://llvm.org/viewvc/llvm-project?rev=317233&view=rev Log: acosh: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/acosh.inc

[libclc] r317232 - acos: Use unary_decl instead of custom inc file

Author: jvesely Date: Thu Nov 2 12:48:06 2017 New Revision: 317232 URL: http://llvm.org/viewvc/llvm-project?rev=317232&view=rev Log: acos: Use unary_decl instead of custom inc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/generic/include/clc/math/acos.inc M

[PATCH] D39210: Add default calling convention support for regcall.

eandrews added a comment. *ping* https://reviews.llvm.org/D39210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

ahatanak created this revision. Herald added subscribers: kristof.beyls, aemerson. The assertion failure occurs when a setter is called using the dot syntax to set a property of a class type that doesn't have trivial copy/move constructors or assignment operators. It happens only when clang is c

r317231 - revert r317228: remove unused function from ObjCRuntime.h, NFC

Author: arphaman Date: Thu Nov 2 12:42:40 2017 New Revision: 317231 URL: http://llvm.org/viewvc/llvm-project?rev=317231&view=rev Log: revert r317228: remove unused function from ObjCRuntime.h, NFC This function is actually used in LLDB Modified: cfe/trunk/include/clang/Basic/ObjCRuntime.h

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

spatel updated this revision to Diff 121344. spatel added a comment. Patch updated: Make const-ness of the builtins match const-ness of their lib function siblings. We're deferring fixing some of these that are obviously wrong to follow-up patches. Hopefully, the bugs are visible in the new test

r317228 - remove unused function from ObjCRuntime.h, NFC

Author: arphaman Date: Thu Nov 2 12:01:34 2017 New Revision: 317228 URL: http://llvm.org/viewvc/llvm-project?rev=317228&view=rev Log: remove unused function from ObjCRuntime.h, NFC Modified: cfe/trunk/include/clang/Basic/ObjCRuntime.h Modified: cfe/trunk/include/clang/Basic/ObjCRuntime.h UR

r317227 - [OPENMP] Fix PR35152: Do not use getInvokeDest() function for EH checks.

Author: abataev Date: Thu Nov 2 11:55:05 2017 New Revision: 317227 URL: http://llvm.org/viewvc/llvm-project?rev=317227&view=rev Log: [OPENMP] Fix PR35152: Do not use getInvokeDest() function for EH checks. The compiler may crash under some conditions if the getInvokeDest() is used, but later it

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

arphaman added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), + std::move(NewQualifiedName));

[PATCH] D39441: [refactor][extract] insert semicolons into extracted/inserted code when needed

arphaman updated this revision to Diff 121339. arphaman marked 3 inline comments as done. arphaman added a comment. Address review comments Repository: rL LLVM https://reviews.llvm.org/D39441 Files: include/clang/Lex/Lexer.h lib/Lex/Lexer.cpp lib/Tooling/Refactoring/CMakeLists.txt li

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

hfinkel added a comment. In https://reviews.llvm.org/D39481#914174, @craig.topper wrote: > There's an oddity with fma. The version without __builtin has 'e' already Something that is potentially relevant: POSIX says that fma() can set errno (http://pubs.opengroup.org/onlinepubs/9699919799/func

r317224 - [refactor][selection] canonicalize selected string literal to objc

Author: arphaman Date: Thu Nov 2 11:05:48 2017 New Revision: 317224 URL: http://llvm.org/viewvc/llvm-project?rev=317224&view=rev Log: [refactor][selection] canonicalize selected string literal to objc string literal when possible Modified: cfe/trunk/lib/Tooling/Refactoring/ASTSelection.cpp

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

efriedma added a comment. > But we don't check the const attribute in CGBuiltin.cpp before converting it > to an intrinsic In practice, fma() implementations don't set errno (at least, glibc and msvcrt don't). And people would be really annoyed if we forced them to use fast-math flags to gene

[PATCH] D39430: [clangd] formatting: don't ignore style

sammccall added a comment. Thanks for this! Comment at: clangd/ClangdLSPServer.cpp:93 +void ClangdLSPServer::replyWithTextEditsOrError( +Ctx C, std::string Code, This function is pretty hard to understand from a high level - it's a bit of an odd split.

[PATCH] D39549: [clang-format] Sort using-declarations case sensitively with a special case for '_'

bkramer added a comment. Can we just write out the modified string comparison function instead of keeping both versions of the string around in memory? I'd prefer less state. https://reviews.llvm.org/D39549 ___ cfe-commits mailing list cfe-commits@

[PATCH] D39481: [CodeGen] fix const-ness of builtin equivalents of and functions that might set errno

craig.topper added a comment. There's an oddity with fma. The version without __builtin has 'e' already LIBBUILTIN(fma, "", "fne", "math.h", ALL_LANGUAGES) LIBBUILTIN(fmaf, "", "fne", "math.h", ALL_LANGUAGES) LIBBUILTIN(fmal, "LdLdLdLd", "fne", "math.h", ALL_LANGUAGES) But we don't

r317220 - [CodeGen] add builtin attr tests to show errno-related diffs; NFC

Author: spatel Date: Thu Nov 2 10:06:05 2017 New Revision: 317220 URL: http://llvm.org/viewvc/llvm-project?rev=317220&view=rev Log: [CodeGen] add builtin attr tests to show errno-related diffs; NFC Added: cfe/trunk/test/CodeGen/builtin-errno.c Added: cfe/trunk/test/CodeGen/builtin-errno.c U

r317216 - Fix comment typo

Author: jkorous Date: Thu Nov 2 09:37:00 2017 New Revision: 317216 URL: http://llvm.org/viewvc/llvm-project?rev=317216&view=rev Log: Fix comment typo Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/t

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), + std::move(NewQualifiedName)); --

[PATCH] D39114: [XRay] Initial XRay in Darwin Support

kubamracek added a comment. Also, please make sure this builds and tests pass before actually landing this patch. FYI, there are bots that run on older macOS versions (10.11 for sure, probably even older). https://reviews.llvm.org/D39114 ___ cfe-c

[PATCH] D39114: [XRay] Initial XRay in Darwin Support

kubamracek accepted this revision. kubamracek added a comment. This revision is now accepted and ready to land. Hi and sorry for replying so late! All of the changes LGTM with a few nits. > Assembly for Darwin x86_64 and how we avoid the ELF'isms (do we need to > implement darwin-specific assemb

  1   2   >