This revision was automatically updated to reflect the committed changes.
Closed by commit rL312306: Reland r312224 - [ItaniumCXXABI] Always use
linkonce_odr linkage for RTTI data… (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D37327?vs=113380&id=113511#toc
Reposito
Author: mstorsjo
Date: Thu Aug 31 23:41:55 2017
New Revision: 312306
URL: http://llvm.org/viewvc/llvm-project?rev=312306&view=rev
Log:
Reland r312224 - [ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data
on MinGW
This fixes cases where dynamic classes produced RTTI data with
external l
compnerd added a comment.
I think that splitting this up in a series of patches would be much better.
The first patch should be to do the entirely mechanical change of the
visibility attribute. It is a separate library and needs its own visibility
attribute. That would significantly slim dow
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D36707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Prazek updated this revision to Diff 113507.
Prazek marked 4 inline comments as done.
Prazek added a comment.
- docs fixes
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
Inde
Prazek added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let Content = [{This attribute makes global symbol have a weak definition
aaron.ballman wrote:
> I think you need to set the `Category` as we
ddcc marked 5 inline comments as done.
ddcc added a comment.
All testcases pass, except the issue with `range_casts.c`. The cause is still
the range intersection discussed in https://reviews.llvm.org/D35450#810469.
https://reviews.llvm.org/D35450
_
ddcc updated this revision to Diff 113505.
ddcc added a comment.
Rebase, make complexity limits configurable
https://reviews.llvm.org/D35450
Files:
include/clang/AST/Expr.h
include/clang/Config/config.h.cmake
include/clang/StaticAnalyzer/Checkers/SValExplainer.h
include/clang/StaticAnal
[STL]
> I can't check in copies of `cl.exe` and `link.exe` (the former's version is
> inspected, so it can't just be a dummy file).
> I'm happy without upstream tests for this logic. In the long run, I hope that
> we can eliminate this internal directory structure and make it identical to
> the
efriedma added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:2434
+// Emit section information for extern variables.
+if (D->hasExternalStorage() && !D->isThisDeclarationADefinition()) {
+ if (const SectionAttr *SA = D->getAttr())
eandre
Author: abataev
Date: Thu Aug 31 16:34:33 2017
New Revision: 312296
URL: http://llvm.org/viewvc/llvm-project?rev=312296&view=rev
Log:
[OPENMP] Fix the test, NFC.
Modified:
cfe/trunk/test/OpenMP/for_codegen.cpp
Modified: cfe/trunk/test/OpenMP/for_codegen.cpp
URL:
http://llvm.org/viewvc/llvm-
Author: abataev
Date: Thu Aug 31 16:06:52 2017
New Revision: 312292
URL: http://llvm.org/viewvc/llvm-project?rev=312292&view=rev
Log:
[OPENMP] Fix for PR34398: assert with random access iterator if the
step>1.
If the loop is a loot with random access iterators and the iteration
construct is repre
erichkeane added a comment.
In https://reviews.llvm.org/D37308#858309, @zahiraam wrote:
> Aaron,
>
> Yes I want to this to succeed:
>
> struct __declspec(uuid("---C000-0046")) IUnknown {};
> __interface ISfFileIOPropertyPage : public IUnknown {};
>
> But I also want this
zahiraam added a comment.
Aaron,
Yes I want to this to succeed:
struct __declspec(uuid("---C000-0046")) IUnknown {};
__interface ISfFileIOPropertyPage : public IUnknown {};
But I also want this to succeed:
struct __declspec(uuid("---C000-0046"))
dcoughlin added a comment.
@ddcc : When I run this I get a bunch of assertion failures. Does this depend
on https://reviews.llvm.org/D28953? (Which was reverted) Is it subsumed by
https://reviews.llvm.org/D35450?
Is this blocking on a review of another patch on our end?
https://reviews.llvm.o
yaxunl updated this revision to Diff 113483.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
update tests.
https://reviews.llvm.org/D36678
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/cl20-device-side-enqueue.cl
Index: test/CodeGenOpenCL/cl20-device-side-enqueue.cl
puremourning updated this revision to Diff 113476.
puremourning added a comment.
Validate that the duplicate message is printed.
https://reviews.llvm.org/D37282
Files:
clangd/JSONRPCDispatcher.cpp
test/clangd/protocol.test
Index: test/clangd/protocol.test
==
kastiglione added a comment.
thanks @aaron.ballman
Repository:
rL LLVM
https://reviews.llvm.org/D37346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane added a comment.
In https://reviews.llvm.org/D37312#858217, @anatol.pomozov wrote:
> Thank you folks for your work.
>
> By the way when these changes are going to be released? clang 6.0?
Most likely. Its too late to get into 5.0, and 6.0 hasn't been branched yet.
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312283: Register linkageSpecDecl matcher (authored by
kastiglione).
Repository:
rL LLVM
https://reviews.llvm.org/D37346
Files:
cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
Index: cfe/trunk/lib/A
Author: kastiglione
Date: Thu Aug 31 14:18:27 2017
New Revision: 312283
URL: http://llvm.org/viewvc/llvm-project?rev=312283&view=rev
Log:
Register linkageSpecDecl matcher
Summary:
This allows `linkageSpecDecl` to be used from `clang-query`.
See also D31869 which similary adds `isStaticStorageCla
anatol.pomozov added a comment.
Thank you folks for your work.
By the way when these changes are going to be released? clang 6.0?
Repository:
rL LLVM
https://reviews.llvm.org/D37312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312281: Add documentation for force_align_arg_pointer
function attribute (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D37312?vs=113458&id=113469#toc
Repository:
rL LLVM
Author: erichkeane
Date: Thu Aug 31 14:08:24 2017
New Revision: 312281
URL: http://llvm.org/viewvc/llvm-project?rev=312281&view=rev
Log:
Add documentation for force_align_arg_pointer function attribute
Patch By: anatol.pomozov (anatol.pomo...@gmail.com)
Differential Revision: https://reviews.ll
Author: oleg
Date: Thu Aug 31 13:31:30 2017
New Revision: 312275
URL: http://llvm.org/viewvc/llvm-project?rev=312275&view=rev
Log:
[clang-cl] Explicitly set object format to COFF in CL mode
Summary:
Currently object format is taken from the default target triple. For toolchains
with a non-COFF d
iid_iunknown added a comment.
Thanks for reviewing this!
Repository:
rL LLVM
https://reviews.llvm.org/D37336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane added a comment.
In https://reviews.llvm.org/D37312#858108, @aaron.ballman wrote:
> LGTM! Thank you for working on this!
Did you want to land this, or should I?
https://reviews.llvm.org/D37312
___
cfe-commits mailing list
cfe-commits@l
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Thank you for working on this!
https://reviews.llvm.org/D37312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
anatol.pomozov updated this revision to Diff 113458.
https://reviews.llvm.org/D37312
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
===
--- include/clang/Basic/AttrDocs
erichkeane requested changes to this revision.
erichkeane added a comment.
This revision now requires changes to proceed.
When forming 'diffs', please make sure you do so against the current status of
Clang. Your latest diff seems to be only against your first commit, so the
diff is crazy looki
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D37336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
zahiraam added a comment.
That's both of the code snip-its are supposed to fail (take the diagnostic). If
I remove the ClasshasAttrs() condition, from line #2459, these snip-its will
pass. I was trying to explain the need for that part of the condition.
https://reviews.llvm.org/D37308
_
aaron.ballman added a comment.
In https://reviews.llvm.org/D37308#858035, @zahiraam wrote:
> The test case you gave doesn't compile. It returns the diagnostic. CL has the
> same behavior. I don't think it is because of the dllimport.
My test case was based off your example code, not something
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let Content = [{This attribute makes global symbol have a weak definition
I think you need to set the `Category` as well.
To test thi
zahiraam added a comment.
The test case you gave doesn't compile. It returns the diagnostic. CL has the
same behavior. I don't think it is because of the dllimport.
https://reviews.llvm.org/D37308
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: dblaikie
Date: Thu Aug 31 11:49:34 2017
New Revision: 312268
URL: http://llvm.org/viewvc/llvm-project?rev=312268&view=rev
Log:
Disable clang-format's MemoizationTest as it becomes prohibitive with
EXPENSIVE_CHECKS
EXPENSIVE_CHECKS enables libstdc++'s library consistency checks, which
inc
iid_iunknown added a comment.
> Do you think you can write a test for your patch that will work on the
> buildbots we have?
I am afraid, this is not possible with the existing buildbots. `--target` does
not affect the default triple. There is `LLVM_TARGET_TRIPLE_ENV` that allows to
override th
aaron.ballman added a comment.
In https://reviews.llvm.org/D37308#857607, @zahiraam wrote:
> Removed the helper function.
>
> If RD (base class) has uuid attribute, we want to ensure that the interface
> doesn't have attributes. Otherwise cases like:
>
> class __declspec(uuid("--
probinson added a comment.
I now think the tactic to pursue is making sure the containing
DICompositeType(s) for the method have complete descriptions, and RAUW the
temporary nodes, prior to calling CloneFunction. Actually wading around in the
MDNodes, Types, and Decls to accomplish that resul
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2812
+Legacy x86 code uses 4-byte stack alignment. Newer aligned SSE instructions
+(like 'movaps') that work with stack require operands to be 16-byte aligned.
+This attribute realigns stack in the f
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D37346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
kastiglione created this revision.
Herald added a subscriber: klimek.
This allows `linkageSpecDecl` to be used from `clang-query`.
See also https://reviews.llvm.org/D31869 which similary adds
`isStaticStorageClass`.
https://reviews.llvm.org/D37346
Files:
lib/ASTMatchers/Dynamic/Registry.cpp
yaxunl updated this revision to Diff 113443.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D34367
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCall.h
lib/CodeGen/CGDecl.cpp
test/CodeGenCXX/amdgcn-func-arg.cpp
test/CodeGenOpenCL/addr-space-struct-arg.cl
I
vivekvpandya updated this revision to Diff 113434.
vivekvpandya added a comment.
Updated the patch! I don't think now we require to save OldDiagnosticHandler
and context as we have ClangDiagnosticHandler class with creation of
CreateASTConsumer, but I need some review.
https://reviews.llvm.org
erichkeane added a comment.
Looks good to me, but I want to give @aaron.ballman a chance to take a look
before this gets accepted.
https://reviews.llvm.org/D37312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: stl_msft
Date: Thu Aug 31 10:59:51 2017
New Revision: 312263
URL: http://llvm.org/viewvc/llvm-project?rev=312263&view=rev
Log:
[libcxx] [www] Change an absolute link to cxx1z_status.html to be relative.
Fixes D37318.
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/
Author: stl_msft
Date: Thu Aug 31 10:59:48 2017
New Revision: 312262
URL: http://llvm.org/viewvc/llvm-project?rev=312262&view=rev
Log:
[libcxx] [www] Strip trailing whitespace.
Fixes D37318.
Modified:
libcxx/trunk/www/atomic_design_c.html
libcxx/trunk/www/cxx1y_status.html
libcxx/tru
Author: stl_msft
Date: Thu Aug 31 10:59:46 2017
New Revision: 312261
URL: http://llvm.org/viewvc/llvm-project?rev=312261&view=rev
Log:
[libcxx] [www] Fix broken link for LLVM Bugzilla.
Fixes D37318.
Modified:
libcxx/trunk/www/index.html
Modified: libcxx/trunk/www/index.html
URL:
http://llv
Author: stl_msft
Date: Thu Aug 31 10:59:39 2017
New Revision: 312259
URL: http://llvm.org/viewvc/llvm-project?rev=312259&view=rev
Log:
[libcxx] [www] Semi-manually change http://www.open-std.org and
http://isocpp.org papers to https://wg21.link .
Fixes D37318.
Modified:
libcxx/trunk/www/ato
Author: stl_msft
Date: Thu Aug 31 10:59:42 2017
New Revision: 312260
URL: http://llvm.org/viewvc/llvm-project?rev=312260&view=rev
Log:
[libcxx] [www] Manually change http links to https.
Fixes D37318.
Modified:
libcxx/trunk/www/atomic_design.html
libcxx/trunk/www/atomic_design_a.html
Author: stl_msft
Date: Thu Aug 31 10:59:36 2017
New Revision: 312258
URL: http://llvm.org/viewvc/llvm-project?rev=312258&view=rev
Log:
[libcxx] [www] Change http://cplusplus.github.io/LWG/lwg-defects.html# to
https://wg21.link/lwg .
Fixes D37318.
Modified:
libcxx/trunk/www/cxx1y_status.html
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312256: [test] Cleanup nullopt_t tests (authored by
CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D37024?vs=112224&id=113432#toc
Repository:
rL LLVM
https://reviews.llvm.org/D37024
Author: caseycarter
Date: Thu Aug 31 10:56:31 2017
New Revision: 312256
URL: http://llvm.org/viewvc/llvm-project?rev=312256&view=rev
Log:
[test] Cleanup nullopt_t tests
* Update specification text from N4387
* Delete not_brace_initializable.fail.cpp: it's redundant with
nullopt_t.fail.cpp
* is
szepet added a comment.
Thanks for the update!
It looks good to me! (Probably somebody else (most likely NoQ) will have some
additional comment but I think it's great!)
https://reviews.llvm.org/D37187
___
cfe-commits mailing list
cfe-commits@lists.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3861
< Align.getQuantity()) ||
(ArgInfo.getIndirectByVal() && (RVAddrSpace != ArgAddrSpace))) {
// Create an aligned temporary, and copy to it.
yaxunl wrote:
MTC marked an inline comment as done.
MTC added inline comments.
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:694
+ } else if (Optional BE = P.getAs()) {
+CFGElement BlockFront = BE->getBlock()->front();
+if (BlockFront.getKind() == CFGElement::Statement) {
---
MTC updated this revision to Diff 113427.
MTC added a comment.
(1) Modify the description of the bug report
(2) Update loop-widening-notes.c
(3) PathDiagnosticLocation::create() - Use the location of TerminatorCondition.
https://reviews.llvm.org/D37187
Files:
lib/StaticAnalyzer/Core/BugRepo
erichkeane updated this revision to Diff 113424.
erichkeane marked 4 inline comments as done.
https://reviews.llvm.org/D36707
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CodeGenFunction.h
Index: lib/CodeGen/CodeGenFunction.h
==
arphaman added a comment.
In https://reviews.llvm.org/D37291#857727, @klimek wrote:
> Thanks! I think this makes the code easier to understand. Now my remaining
> question is why the ResultType is templates vs. also being an interface
> (sorry for being late, was out on vacation the past 2 week
craig.topper added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:7414
+ StringRef FeatureStr = cast(FeatureExpr)->getString();
+ return EmitX86CpuSupports({FeatureStr});
+}
You shouldn't need curly braces here. ArrayRef has a conversion constructor
th
arphaman added inline comments.
Comment at: include/clang/Tooling/Refactoring/RefactoringResultConsumer.h:30
+ /// the source selection has no overlap at all with any relevant AST nodes.
+ virtual void handleInitiationFailure() = 0;
+
klimek wrote:
> ioeric wro
mclow.lists added inline comments.
Comment at:
test/libcxx/utilities/function.objects/func.require/incomplete_return_type.pass.cpp:22
+int main() {
+ return 0;
+}
Is copy constructible; can be instantiated.
static_assert( std::is_copy_constructible::value
arphaman created this revision.
This patch fixes an an assertion that previously occurred for the following
sample:
template
struct SourceSelectionRequirement {
template
OutputT evaluateSelectionRequirement(InputT &&Value) {
}
};
template
OutputT SourceSelectionRequ
hans added a comment.
In https://reviews.llvm.org/D37336#857814, @iid_iunknown wrote:
> In https://reviews.llvm.org/D37336#857802, @hans wrote:
>
> > But why isn't that failure showing on some buildbot, then?
>
>
> The test needs `system-windows` to run:
>
> // REQUIRES: system-windows
>
>
> Th
iid_iunknown added a comment.
In https://reviews.llvm.org/D37336#857802, @hans wrote:
> But why isn't that failure showing on some buildbot, then?
The test needs `system-windows` to run:
// REQUIRES: system-windows
There is no windows buildbot that builds clang defaulted to the AArch64 targ
hans added a comment.
Seems reasonable, but should probably have a test.
> This can be observed on the clang's Driver/cl-pch.c test with AArch64 as a
> default target.
But why isn't that failure showing on some buildbot, then?
Repository:
rL LLVM
https://reviews.llvm.org/D37336
Author: arphaman
Date: Thu Aug 31 08:51:23 2017
New Revision: 312246
URL: http://llvm.org/viewvc/llvm-project?rev=312246&view=rev
Log:
Revert r312240
The buildbots have shown that -Wstrict-prototypes behaves differently in GCC
and Clang so we should keep it disabled until Clang follows GCC's beha
Author: compnerd
Date: Thu Aug 31 08:35:01 2017
New Revision: 312244
URL: http://llvm.org/viewvc/llvm-project?rev=312244&view=rev
Log:
Driver: extract ARCMT flag construction (NFC)
Extract the ARC migration tool flag handling into its own function.
This simplifies the flow of the clang frontend c
erichkeane added a comment.
Hey @efriedma : Did you get a chance to take a look at this? She got the
langref changes in, so it is just waiting on this.
https://reviews.llvm.org/D36487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
iid_iunknown created this revision.
Herald added subscribers: kristof.beyls, aemerson.
Currently object format is taken from the default target triple. For toolchains
with a non-COFF default target this may result in an object format
inappropriate for pc-windows and lead to compilation issues.
klimek added a comment.
Thanks! I think this makes the code easier to understand. Now my remaining
question is why the ResultType is templates vs. also being an interface (sorry
for being late, was out on vacation the past 2 weeks :)
Comment at: include/clang/Tooling/Refactor
mclow.lists added a comment.
This feature has not been added to the draft standard yet, so I'm reluctant to
add it to libc++.
I appreciate the patch, and we may adopt it in the future, but not now.
https://reviews.llvm.org/D35470
___
cfe-commits m
mclow.lists added inline comments.
Comment at:
test/std/diagnostics/syserr/syserr.errcat/syserr.errcat.objects/generic_category.pass.cpp:35
+// Exact message format varies by platform.
+LIBCPP_ASSERT(msg == "Unknown error -1" || msg == "Unknown error" ||
+
mclow.lists added a comment.
This looks reasonable to me.
https://reviews.llvm.org/D36720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
LGTM.
@klimek Manuel, would you like to take a look? This addresses your comment
https://reviews.llvm.org/D36075#854075
Comment at: include/clang/Tooling/Refactoring/Refact
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D37024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM; thanks!
https://reviews.llvm.org/D37318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
arphaman added inline comments.
Comment at: unittests/Tooling/RefactoringActionRulesTest.cpp:39
+ class Consumer final : public RefactoringResultConsumer {
+void handleInitiationFailure() {
+ Result = Expected>(None);
ioeric wrote:
> Can we probably hav
arphaman updated this revision to Diff 113397.
arphaman marked an inline comment as done.
arphaman added a comment.
- Add default implementation for `handle()`
- Merge two error handling functions into one
https://reviews.llvm.org/D37291
Files:
include/clang/Tooling/Refactoring/RefactoringAct
Author: arphaman
Date: Thu Aug 31 06:23:24 2017
New Revision: 312240
URL: http://llvm.org/viewvc/llvm-project?rev=312240&view=rev
Log:
Build LLVM with -Wstrict-prototypes enabled
Clang 5 supports -Wstrict-prototypes. We should use it to catch any C
declarations that declare a non-prototype functi
arphaman added inline comments.
Comment at: include/clang/Tooling/Refactoring/RefactoringResultConsumer.h:39
+ /// Handles the source replacements that are produced by a refactoring
action.
+ virtual void handle(AtomicChanges SourceReplacements) = 0;
+};
ioeri
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/RefactoringResultConsumer.h:39
+ /// Handles the source replacements that are produced by a refactoring
action.
+ virtual void handle(AtomicChanges SourceReplacements) = 0;
+};
arphama
zahiraam updated this revision to Diff 113387.
zahiraam added a comment.
Removed the helper function.
If RD (base class) has uuid attribute, we want to ensure that the interface
doesn't have attributes. Otherwise cases like:
class __declspec(uuid("---C000-0046")) IUnknow
danielmarjamaki added a comment.
small nits
Comment at: include/clang/CrossTU/CrossTranslationUnit.h:58
+
+/// \brief This function can parse an index file that determines which
+///translation unit contains which definition.
I suggest that "can" is rem
barancsuk updated this revision to Diff 113376.
barancsuk added a comment.
Major changes that have been made since the last update are as follows:
- It is checked, whether implicit type conversion is possible from the argument
to the other parameter. The following conversion rules are considered
whisperity added a comment.
The Python code here still uses `mangled name` in their wording. Does this mean
this patch is yet to be updated with the USR management in the parent patch?
Comment at: tools/scan-build-py/libscanbuild/analyze.py:165
+with open(filename,
Author: dvyukov
Date: Thu Aug 31 04:02:44 2017
New Revision: 312232
URL: http://llvm.org/viewvc/llvm-project?rev=312232&view=rev
Log:
docs: don't say that data flow tracing interface is unstable
We are starting to use data flow tracing in kernel.
The interface is not subject to change anymore.
R
danielmarjamaki added inline comments.
Comment at: tools/scan-build-py/libscanbuild/analyze.py:165
+with open(filename, 'r') as in_file:
+for line in in_file:
+yield line
I believe you can write:
for line in op
lebedev.ri added a comment.
In https://reviews.llvm.org/D33826#772676, @aaron.ballman wrote:
> How does this check compare with the -Wcast-align diagnostic in the Clang
> frontend? I believe that warning already covers these cases, so I'm wondering
> what extra value is added with this check?
PriMee added a comment.
Sorry for wrong formatting before. Some inline comments added.
Comment at: lib/Format/UnwrappedLineFormatter.cpp:286
}
+if (TheLine->Last->is(tok::l_brace) &&
+TheLine->First != TheLine->Last &&
krasimir wrote:
> No test
MontyKutyi added a comment.
Ping.
https://reviews.llvm.org/D34030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo created this revision.
This fixes cases where dynamic classes produced RTTI data with external
linkage, producing linker errors about duplicate symbols.
This touches code close to what was changed in SVN r244266, but this change
doesn't break the tests added in that revision.
The prev
PriMee updated this revision to Diff 113379.
PriMee added a comment.
Diff file updated. Some tests added. Some new bugs fixed as well :)
https://reviews.llvm.org/D37140
Files:
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
barancsuk commandeered this revision.
barancsuk added a reviewer: varjujan.
barancsuk added a comment.
Herald added a subscriber: baloghadamsoftware.
Since the previous author, @varjujan is not available anymore, I take over the
role of the author of this revision.
https://reviews.llvm.org/D206
Author: mstorsjo
Date: Thu Aug 31 02:46:27 2017
New Revision: 312229
URL: http://llvm.org/viewvc/llvm-project?rev=312229&view=rev
Log:
Revert r312224: "[ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data
on MinGW"
Breaks on buildbot:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D30295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312224: [ItaniumCXXABI] Always use linkonce_odr linkage for
RTTI data on MinGW (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D37206?vs=113309&id=113367#toc
Repository:
rL
Author: mstorsjo
Date: Thu Aug 31 01:29:59 2017
New Revision: 312224
URL: http://llvm.org/viewvc/llvm-project?rev=312224&view=rev
Log:
[ItaniumCXXABI] Always use linkonce_odr linkage for RTTI data on MinGW
This fixes cases where dynamic classes produced RTTI data with
external linkage, producing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL31: [analyzer] Performance optimizations for the
CloneChecker (authored by teemperor).
Changed prior to commit:
https://reviews.llvm.org/D34182?vs=108839&id=113361#toc
Repository:
rL LLVM
https:
Author: teemperor
Date: Thu Aug 31 00:10:46 2017
New Revision: 31
URL: http://llvm.org/viewvc/llvm-project?rev=31&view=rev
Log:
[analyzer] Performance optimizations for the CloneChecker
Summary:
This patch aims at optimizing the CloneChecker for larger programs. Before this
patch we took
100 matches
Mail list logo
