arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D36728
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
srhines added a comment.
https://reviews.llvm.org/D36729 similarly fixes a few more instances of this
problem (discovered while running tests for this configuration).
https://reviews.llvm.org/D36728
___
cfe-commits mailing list
cfe-commits@lists.ll
yaxunl marked 6 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Basic/SyncScope.h:92
+/// \brief Defines the synch scope ABI for OpenCL.
+class AtomicScopeOpenCLABI : public AtomicScopeABI {
+public:
rjmccall wrote:
> yaxunl wrote
hfinkel updated this revision to Diff 30.
hfinkel added a comment.
Herald added a subscriber: jholewinski.
Rebased.
https://reviews.llvm.org/D22189
Files:
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/Code
hfinkel updated this revision to Diff 29.
hfinkel added a comment.
Herald added a subscriber: javed.absar.
Rebased and addressing review comments.
https://reviews.llvm.org/D9403
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGStmt.cpp
lib/CodeGen/CodeGenFunction.c
hfinkel added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1291
+// where the pointer to the local variable is the key in the map.
+void CodeGenFunction::EmitAutoVarNoAlias(const AutoVarEmission &emission) {
+ assert(emission.Variable && "emission was not valid!");
--
vsk updated this revision to Diff 13.
vsk added a comment.
Thanks for the review. I've updated the patch so that we do better with "#\"
directives.
https://reviews.llvm.org/D36642
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPDirectives.cpp
test/CoverageMapping/preprocessor.c
t
hfinkel updated this revision to Diff 09.
hfinkel added a comment.
Rebased.
https://reviews.llvm.org/D32199
Files:
include/clang/Basic/Sanitizers.def
include/clang/Driver/SanitizerArgs.h
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGen/Cod
rnk added a comment.
This shouldn't be necessary after https://reviews.llvm.org/rL310905.
https://reviews.llvm.org/D34873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Mon Aug 14 18:17:47 2017
New Revision: 310905
URL: http://llvm.org/viewvc/llvm-project?rev=310905&view=rev
Log:
Avoid PointerIntPair of constexpr EvalInfo structs
They are stack allocated, so their alignment is not to be trusted.
32-bit MSVC only guarantees 4 byte stack alignmen
rnk added a subscriber: gbiv.
rnk added a comment.
I looked at the blame, and I added this alignment thing in
https://reviews.llvm.org/rL289575 to deal with some PointerIntPair assertions.
Those probably started in @gbiv's https://reviews.llvm.org/rL270781, which
introduced a `PointerIntPair` f
Author: danalbert
Date: Mon Aug 14 17:31:44 2017
New Revision: 310903
URL: http://llvm.org/viewvc/llvm-project?rev=310903&view=rev
Log:
Revert "Fix LLVMgold plugin name/path for non-Linux."
Broke a test. Will fix the test and re-land later.
Modified:
cfe/trunk/lib/Driver/ToolChains/CommonArg
Merged in r310902.
Thanks,
Hans
On Mon, Aug 14, 2017 at 4:03 AM, Alex L wrote:
> Sure, I committed r310829 which moves the lexical decl adjustment.
>
> Hans, can you please merge r310706 with r310829.
>
> Cheers,
> Alex
>
> On 12 August 2017 at 01:29, Richard Smith wrote:
>>
>> On 11 August 201
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310901: [CMake] Include LLVMFuzzer in Fuchsia toolchain
(authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D36541?vs=110452&id=03#toc
Repository:
rL LLVM
https://reviews.llv
Author: phosek
Date: Mon Aug 14 17:22:00 2017
New Revision: 310901
URL: http://llvm.org/viewvc/llvm-project?rev=310901&view=rev
Log:
[CMake] Include LLVMFuzzer in Fuchsia toolchain
Differential Revision: https://reviews.llvm.org/D36541
Modified:
cfe/trunk/cmake/caches/Fuchsia-stage2.cmake
M
smeenai added a comment.
In https://reviews.llvm.org/D36713#841478, @mclow.lists wrote:
> What's the use case here? What are you trying to accomplish?
The `_LIBCPP_DISABLE_AVAILABILITY` macro already exists, but since it
influences headers, it's a lot more useful to have it as a site config o
On 14 August 2017 at 03:27, Diana Picus via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> Strangely enough, it turns out that if I run
> Asan-armhf-with-calls-Noinst-Test on the command line it fails,
> although it doesn't fail when run with lit.
Looks like the crash is within the "
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310895: Fix LLVMgold plugin name/path for non-Linux.
(authored by danalbert).
Repository:
rL LLVM
https://reviews.llvm.org/D35739
Files:
cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp
Index: cfe/t
Author: danalbert
Date: Mon Aug 14 16:19:38 2017
New Revision: 310895
URL: http://llvm.org/viewvc/llvm-project?rev=310895&view=rev
Log:
Fix LLVMgold plugin name/path for non-Linux.
Summary:
It's only named LLVMgold.so on Linux. Fix the name for Windows and
Darwin.
Also fix the path for Windows s
smeenai added a comment.
There should probably be some documentation for this, but I couldn't think of
the right place; the Using libc++ documentation only mentions the actual
configuration macros, not their corresponding cmake defines. Any suggestions?
https://reviews.llvm.org/D36719
_
smeenai created this revision.
Herald added a subscriber: mgorny.
If we define cmake macros that require a site config, and then undefine
all such macros, a stale site config header will be left behind.
Explicitly delete any generate site config if we don't need one to avoid
this.
https://review
saugustine added a comment.
I've cleaned up this patch a bit. Now the only files that are in the x86_ARCH
group are those that require 80 bits floats and cpu_model.c. Tests for all of
these were already disabled on arm and powerpc (because neither has 80-bit
floats), so we knew these library fu
smeenai created this revision.
Herald added a subscriber: mgorny.
Some ABI macros affect headers, so it's nice to have a site config
option for them. Add a LIBCXX_ABI_DEFINES cmake macro to allow
specifying a list of ABI macros to define in the site config.
The primary design constraint (as discu
mclow.lists added a comment.
What's the use case here? What are you trying to accomplish?
https://reviews.llvm.org/D36713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D36713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
mehdi_amini added a comment.
Seems fine to me. Adding @dexonsmith (I don't know who maintain libc++ at Apple
right now)
https://reviews.llvm.org/D36713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
efriedma added inline comments.
Comment at: docs/LangRef.rst:629
+corresponding to the LLVM module, section information specified in the
+declaration is retained in LLVM IR to enable OpenCL processes.
+
This doesn't really explain the part that matters. For Lang
alexshap created this revision.
1. Add missing explicit.
2. Add missing std::move
(return type is Expected> but we return
std::vector, so cast to && is necessary).
Test plan: make check-all
Repository:
rL LLVM
https://reviews.llvm.org/D36715
Files:
include/clang/Tooling/Refactoring/Rena
dcoughlin added a comment.
Thanks! This looks good to me, with the note about factoring out the duplicated
logic addressed, Would you factor out that logic into a static function and
update phabricator summary to be a commit message. Then I will commit!
Comment at: lib/Static
smeenai created this revision.
Herald added a subscriber: mgorny.
Add _LIBCPP_DISABLE_AVAILABILITY to the site config options, and add a
cmake option LIBCXX_DISABLE_AVAILABILITY to control the site config.
This is similar to other options which influence headers and therefore
shold have some way t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310887: [analyzer] Fix SimpleSValBuilder::simplifySVal
(authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D36564?vs=110502&id=111073#toc
Repository:
rL LLVM
https://reviews.ll
Author: alexshap
Date: Mon Aug 14 14:23:08 2017
New Revision: 310887
URL: http://llvm.org/viewvc/llvm-project?rev=310887&view=rev
Log:
[analyzer] Fix SimpleSValBuilder::simplifySVal
This diff fixes a crash (triggered assert) on the newly added test case.
In the method Simplifier::VisitSymbolData
rnk added a comment.
tests?
Repository:
rL LLVM
https://reviews.llvm.org/D36371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane added a comment.
@efriedma : LangRef changed in this review: https://reviews.llvm.org/D36712
https://reviews.llvm.org/D36487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
eandrews created this revision.
Update IR generated to retain section information for external declarations.
This is related to https://reviews.llvm.org/D36487
https://reviews.llvm.org/D36712
Files:
docs/LangRef.rst
Index: docs/LangRef.rst
==
eandrews updated this revision to Diff 111064.
eandrews added a comment.
As per review comments, removed extra RUNS in lit test.
https://reviews.llvm.org/D36487
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/extern-section-attribute.cpp
Index: test/CodeGenCXX/extern-section-attribut
erichkeane updated this revision to Diff 111061.
erichkeane added a comment.
Thinking about it further, the emit functions should be private in this case.
https://reviews.llvm.org/D36707
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CodeGenFunction.h
Index: lib/CodeGen/CodeGenFunction.h
===
efriedma added a comment.
I'm not sure this produces the right locations in general. Consider the
following slightly evil testcase:
#\
if 0
#elif \
11\
int a;
#endif
https://reviews.llvm.org/D36642
___
cfe-commits mailing list
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310874: [Sema] Improve some -Wunguarded-availability
diagnostics (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D36200?vs=109252&id=111051#toc
Repository:
rL LLVM
https://rev
Author: epilk
Date: Mon Aug 14 12:49:12 2017
New Revision: 310874
URL: http://llvm.org/viewvc/llvm-project?rev=310874&view=rev
Log:
[Sema] Improve some -Wunguarded-availability diagnostics
rdar://33543523
Differential revision: https://reviews.llvm.org/D36200
Modified:
cfe/trunk/include/clan
erichkeane created this revision.
A small set of refactors that'll make it easier for me to implement 'target'
support.
First, extract the CPUSupports functionality into its own function. THis has
the advantage of not wasting time in this builtin to deal with arguments.
Second, pulls both CP
rjmccall added inline comments.
Comment at: include/clang/Basic/SyncScope.h:92
+/// \brief Defines the synch scope ABI for OpenCL.
+class AtomicScopeOpenCLABI : public AtomicScopeABI {
+public:
yaxunl wrote:
> rjmccall wrote:
> > yaxunl wrote:
> > > rjmccall wrot
It's helpful to mention why a patch is reverted in the commit message that
reverts. Thought for next time! :)
On Tue, Aug 8, 2017 at 9:46 AM Alexey Bataev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: abataev
> Date: Tue Aug 8 09:45:36 2017
> New Revision: 310379
>
> URL: http:/
johannes added a comment.
In https://reviews.llvm.org/D36686#840827, @arphaman wrote:
> It might be useful to have both source and destination in a different
> revision. Maybe something like `-src-git-rev` and `-dst-git-rev`?
Then I'd rather have a revision range such as `-git-revs ..`
and if
chh added a comment.
Daniel, Manuel, I will take over this CL since Yan has finished his internship
at Google.,
Yan's latest patch to tryToParseLambda looks acceptable to me.
I think it should take care of new kw_auto in additional to kw_new, ke_delete,
etc.
Could you suggest if there is any be
yaxunl marked 4 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Basic/SyncScope.h:92
+/// \brief Defines the synch scope ABI for OpenCL.
+class AtomicScopeOpenCLABI : public AtomicScopeABI {
+public:
rjmccall wrote:
> yaxunl wrote
dcoughlin added a comment.
Also, please mention in the commit message that tests will be added in a
following commit.
https://reviews.llvm.org/D35670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
rjmccall added inline comments.
Comment at: test/FixIt/fixit-cxx0x.cpp:57
(void)[&, &i, &i]{}; // expected-error 2{{'&' cannot precede a capture when
the capture default is '&'}}
- (void)[=, this]{ this->g(5); }; // expected-error{{'this' cannot be
explicitly captured}}
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me! (Please expand the comment, though.)
Comment at: include/clang/Analysis/ProgramPoint.h:658
+class LoopExit : public ProgramPoint {
+public:
rjmccall added inline comments.
Comment at: include/clang/Basic/SyncScope.h:92
+/// \brief Defines the synch scope ABI for OpenCL.
+class AtomicScopeOpenCLABI : public AtomicScopeABI {
+public:
yaxunl wrote:
> rjmccall wrote:
> > Please correct me if I'm wrong, b
marsupial created this revision.
The fix in r303372 exposed a problem when using **Parser::ConsumeToken** from
client code in DEBUG.
**ConsumeToken** will assert for all **isTokenSpecial()** cases, but there is
no way to call the proper method.
The isToken methods are just convenient.
https:/
hamzasood added inline comments.
Comment at: test/FixIt/fixit-cxx0x.cpp:57
(void)[&, &i, &i]{}; // expected-error 2{{'&' cannot precede a capture when
the capture default is '&'}}
- (void)[=, this]{ this->g(5); }; // expected-error{{'this' cannot be
explicitly captured}}
marsupial created this revision.
Easier to read and possibly optimize.
https://reviews.llvm.org/D36701
Files:
include/clang/Parse/Parser.h
Index: include/clang/Parse/Parser.h
===
--- include/clang/Parse/Parser.h
+++ include/cla
yaxunl marked 7 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Basic/SyncScope.h:89
+ static std::unique_ptr create(LangOptions &Opt);
+};
+
rjmccall wrote:
> The previous design of this header seems more appropriate to me. Cla
Author: abataev
Date: Mon Aug 14 10:56:13 2017
New Revision: 310865
URL: http://llvm.org/viewvc/llvm-project?rev=310865&view=rev
Log:
[OPENMP] Fix for PR33922: New ident_t flags for
__kmpc_for_static_init().
OpenMP 5.0 will include OpenMP Tools interface that requires distinguishing
different wo
rjmccall added inline comments.
Comment at: lib/Sema/SemaLambda.cpp:959
+ ? diag::ext_equals_this_lambda_capture_cxx2a
+ : diag::warn_cxx1z_compat_equals_this_lambda_capture);
hamzasood wrote:
> faisalv wrote:
> >
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310863: [clang-tidy] Add a close-on-exec check on
inotify_init1() in Android module. (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D35368?vs=110750&id=111033#toc
Repository:
rL
Author: chh
Date: Mon Aug 14 10:45:48 2017
New Revision: 310863
URL: http://llvm.org/viewvc/llvm-project?rev=310863&view=rev
Log:
[clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.
Summary:
inotify_init1() is better to set IN_CLOEXEC flag to avoid file descriptor
leakag
rjmccall added inline comments.
Comment at: include/clang/Basic/SyncScope.h:59
+return "opencl_subgroup";
+ }
+}
yaxunl wrote:
> rjmccall wrote:
> > t-tye wrote:
> > > Should there be a default/assert/static_assert to allow SyncScope enum to
> > > grow due
Hi,
Ok that's a progress. Could you figure out which optimizer pass
breaks it. I bet it is the inliner. I assume we could run a reducer on
the ll file.
Cheers, Vassil
On 14/08/17 17:21, Diana Picus wrote:
Hi,
I didn't manage to reproduce this at -O0. Yes, I think the version in
1.8.0, sli
r310862. Thanks!
On Sun, Aug 13, 2017 at 3:41 PM, Richard Smith wrote:
> Since we took the -std=c++17 change for Clang 5, we should take this one
> too.
>
> On 13 August 2017 at 15:26, Richard Smith via cfe-commits
> wrote:
>>
>> Author: rsmith
>> Date: Sun Aug 13 15:26:53 2017
>> New Revision:
Author: chh
Date: Mon Aug 14 10:25:41 2017
New Revision: 310861
URL: http://llvm.org/viewvc/llvm-project?rev=310861&view=rev
Log:
[clang-tidy] Add a close-on-exec check on inotify_init() in Android module.
Summary:
inotify_init() is better to be replaced by inotify_init1() with IN_CLOEXEC flag
t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310861: [clang-tidy] Add a close-on-exec check on
inotify_init() in Android module. (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D35370?vs=110749&id=111028#toc
Repository:
rL
DIVYA added a comment.
Added benchmark from Aditya's repo into the libcxx benchmark code base
https://reviews.llvm.org/D36423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DIVYA updated this revision to Diff 111027.
https://reviews.llvm.org/D36423
Files:
benchmarks/algorithms.bench.cpp
include/algorithm
include/rng_utils.h
include/test_configs.h
include/test_utils.h
Index: include/test_utils.h
=
Sounds good to me. Let's give it another day and see how it goes.
On Fri, Aug 11, 2017 at 6:48 PM, Richard Smith wrote:
> Hi Hans,
>
> I'd like to get this into Clang 5, but it's not entirely risk-free. Perhaps
> we could leave it in the tree for a little while and then merge if it seems
> OK?
>
mibintc updated this revision to Diff 111019.
mibintc added a comment.
@jyknight recommended adding the new option to skipArgs in Job.cpp. This
revision makes that change and tests that in crash-report.c; look OK?
https://reviews.llvm.org/D34158
Files:
include/clang/Driver/CC1Options.td
i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310858: [clang-tidy] Add a close-on-exec check on dup() in
Android module. (authored by chh).
Changed prior to commit:
https://reviews.llvm.org/D35364?vs=110753&id=111021#toc
Repository:
rL LLVM
htt
Author: chh
Date: Mon Aug 14 10:04:16 2017
New Revision: 310858
URL: http://llvm.org/viewvc/llvm-project?rev=310858&view=rev
Log:
[clang-tidy] Add a close-on-exec check on dup() in Android module.
Summary:
dup() is better to be replaced by fcntl() to avoid file descriptor leakage.
Differential R
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, LGTM
https://reviews.llvm.org/D36200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D36200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi,
I didn't manage to reproduce this at -O0. Yes, I think the version in
1.8.0, slightly modified (see
llvm/utils/unittest/googletest/README.LLVM)
On 14 August 2017 at 17:06, Vassil Vassilev wrote:
> On 14/08/17 15:59, Diana Picus wrote:
>>
>> No, the buildbots don't build with -O0 (at least no
It's an NFC, thus untested.
On 14 August 2017 at 17:19, Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Mon Aug 14 09:19:24 2017
> New Revision: 310853
>
> URL: http://llvm.org/viewvc/llvm-project?rev=310853&view=rev
> Log:
> [rename] Introduce symbol o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310853: [rename] Introduce symbol occurrences (authored by
arphaman).
Changed prior to commit:
https://reviews.llvm.org/D36156?vs=110964&id=110999#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
Author: arphaman
Date: Mon Aug 14 09:19:24 2017
New Revision: 310853
URL: http://llvm.org/viewvc/llvm-project?rev=310853&view=rev
Log:
[rename] Introduce symbol occurrences
Symbol occurrences store the results of local rename and will also be used for
the global, indexed rename results. Their kin
danielmarjamaki added a comment.
LGTM. But others should approve.
Repository:
rL LLVM
https://reviews.llvm.org/D36672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
It might be useful to have both source and destination in a different revision.
Maybe something like `-src-git-rev` and `-dst-git-rev`?
https://reviews.llvm.org/D36686
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310852: clang-format: [JS] wrap optional properties in type
aliases. (authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36684
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/t
Author: mprobst
Date: Mon Aug 14 09:09:08 2017
New Revision: 310852
URL: http://llvm.org/viewvc/llvm-project?rev=310852&view=rev
Log:
clang-format: [JS] wrap optional properties in type aliases.
Summary:
clang-format wraps object literal keys in an object literal if they are
marked as `TT_Selecto
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310851: clang-format: [JS] do not insert whitespace in call
positions. (authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36142
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe
Author: mprobst
Date: Mon Aug 14 09:08:16 2017
New Revision: 310851
URL: http://llvm.org/viewvc/llvm-project?rev=310851&view=rev
Log:
clang-format: [JS] do not insert whitespace in call positions.
Summary:
In JavaScript, may keywords can be used in method names and thus call sites:
foo.delet
johannes created this revision.
Herald added a subscriber: klimek.
This makes Node::getIdentifier return a valid value for special
NamedDecl nodes that do not have a name, such as ctors, dtors
and unnamed classes / namespaces.
https://reviews.llvm.org/D36688
Files:
lib/Tooling/ASTDiff/ASTDiff
johannes created this revision.
This adds another pass to the matching algorithm that tries to match nodes with
common parents, if they have similar values.
https://reviews.llvm.org/D36687
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-di
johannes created this revision.
This adds a command line option "-git-rev=".
When it is used, only one filename is accepted. The file in its version
in the specified revision is compared against the current version. Note
that this calls `git checkout` in the current directory.
https://reviews.l
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D36142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D36684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: abataev
Date: Mon Aug 14 09:03:47 2017
New Revision: 310850
URL: http://llvm.org/viewvc/llvm-project?rev=310850&view=rev
Log:
[OPENMP][DEBUG] Fix for PR33676: Debug info for OpenMP region is broken.
After some changes in clang/LLVM debug info for task-based regions was
not generated at al
johannes created this revision.
This adds shortcuts j and k to jump between changes.
It is especially useful in diffs with few changes.
https://reviews.llvm.org/D36685
Files:
tools/clang-diff/ClangDiff.cpp
Index: tools/clang-diff/ClangDiff.cpp
===
Merged in r310848.
On Wed, Aug 9, 2017 at 1:12 PM, Hans Wennborg via cfe-commits
wrote:
> Author: hans
> Date: Wed Aug 9 13:12:53 2017
> New Revision: 310516
>
> URL: http://llvm.org/viewvc/llvm-project?rev=310516&view=rev
> Log:
> Make -std=c++17 an alias of -std=c++1z
>
> As suggested on PR339
mprobst created this revision.
Herald added a subscriber: klimek.
clang-format wraps object literal keys in an object literal if they are
marked as `TT_SelectorName`s and/or the colon is marked as
`TT_DictLiteral`. Previously, clang-format would accidentally work
because colons in type aliases wer
yaxunl added a comment.
In https://reviews.llvm.org/D36327#840658, @bader wrote:
> In https://reviews.llvm.org/D36327#840616, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D36327#839809, @rjmccall wrote:
> >
> > > Could you just implement this in SimplifyLibCalls? I assume there's some
> > >
szepet added inline comments.
Comment at: include/clang/Analysis/ProgramPoint.h:658
+class LoopExit : public ProgramPoint {
+public:
dcoughlin wrote:
> Can you add a comment explaining what meaning of this program point is.
Can you help me with that? I am not s
szepet updated this revision to Diff 110981.
szepet marked an inline comment as done.
szepet added a comment.
Updates based on comments.
https://reviews.llvm.org/D35670
Files:
include/clang/Analysis/ProgramPoint.h
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnal
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: include/clang/Tooling/Refactoring/Rename/SymbolName.h:19
+namespace clang {
+namespace tooling {
+
arphaman wrote:
> hokein wrote:
> > An o
yvvan updated this revision to Diff 110978.
yvvan added a comment.
I have minimized the crash case and added simple test for it.
https://reviews.llvm.org/D36458
Files:
lib/Parse/Parser.cpp
test/Index/std-begin-error.cpp
Index: test/Index/std-begin-error.cpp
===
arphaman updated this revision to Diff 110964.
arphaman marked an inline comment as done.
arphaman added a comment.
Use `takeOccurrences`
Repository:
rL LLVM
https://reviews.llvm.org/D36156
Files:
include/clang/Tooling/Refactoring/Rename/RenamingAction.h
include/clang/Tooling/Refactoring
arphaman marked an inline comment as done.
arphaman added inline comments.
Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:398
Visitor.TraverseDecl(Decl);
- return Visitor.getLocationsFound();
+ return std::move(Visitor.getOccurrences());
}
hoke
On 14/08/17 15:59, Diana Picus wrote:
No, the buildbots don't build with -O0 (at least not the ones that broke).
The command line for that particular object is:
build/./bin/clang -fPIC -fvisibility-inlines-hidden -Werror=date-time
-std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-
On 14 August 2017 at 16:59, Diana Picus wrote:
> No, the buildbots don't build with -O0 (at least not the ones that broke).
>
> The command line for that particular object is:
> build/./bin/clang -fPIC -fvisibility-inlines-hidden -Werror=date-time
> -std=c++11 -Wall -W -Wno-unused-parameter -Wwrit
Author: abataev
Date: Mon Aug 14 08:01:03 2017
New Revision: 310840
URL: http://llvm.org/viewvc/llvm-project?rev=310840&view=rev
Log:
[OPENMP] Generalization of calls of the outlined functions.
General improvement of the outlined functions calls.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRunti
1 - 100 of 161 matches
Mail list logo
