alexshap added a comment.
https://reviews.llvm.org/rL309505
plus I changed the code to emit this warning via DiagnosticEngine and updated
the tests accordingly.
Repository:
rL LLVM
https://reviews.llvm.org/D35972
___
cfe-commits mailing list
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309505: [clang-reorder-fields] Emit warning when reordering
breaks member init list… (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D35972?vs=108812&id=108818#toc
Repository:
Author: alexshap
Date: Sat Jul 29 23:43:03 2017
New Revision: 309505
URL: http://llvm.org/viewvc/llvm-project?rev=309505&view=rev
Log:
[clang-reorder-fields] Emit warning when reordering breaks member init list
dependencies
This diff adds a warning emitted by clang-reorder-fields
when reorderin
Author: chapuni
Date: Sat Jul 29 23:39:52 2017
New Revision: 309504
URL: http://llvm.org/viewvc/llvm-project?rev=309504&view=rev
Log:
CodeGenModule.cpp: [PR33810][Modules] Remove an assertion that confirms
MangledDeclNames[CanonicalGD] might be still empty.
FIXME: It is accepted that MangledDecl
We should take this fix for Clang 5.
On 29 July 2017 at 23:31, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Sat Jul 29 23:31:29 2017
> New Revision: 309503
>
> URL: http://llvm.org/viewvc/llvm-project?rev=309503&view=rev
> Log:
> PR33902: Invalidate
Author: rsmith
Date: Sat Jul 29 23:31:29 2017
New Revision: 309503
URL: http://llvm.org/viewvc/llvm-project?rev=309503&view=rev
Log:
PR33902: Invalidate line number cache when adding more text to existing buffer.
This led to crashes as the line number cache would report a bogus line number
for a
Author: chapuni
Date: Sat Jul 29 22:06:26 2017
New Revision: 309501
URL: http://llvm.org/viewvc/llvm-project?rev=309501&view=rev
Log:
CodeGenModule.cpp: [PR33810][Modules] Avoid reusing FoundStr to try to fix
crash.
MangledDeclNames might grow up and be reallocated when it were reused by
reente
Author: chapuni
Date: Sat Jul 29 21:08:23 2017
New Revision: 309499
URL: http://llvm.org/viewvc/llvm-project?rev=309499&view=rev
Log:
CodeGenModule.cpp: [PR33810][Modules] Make sure actual memory corruption before
random crash with -fmodules.
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
sameconrad added a comment.
In https://reviews.llvm.org/D35972#825348, @alexshap wrote:
> LGTM, thanks!
> do you have commit access ? (if not i can commit this patch for you)
I don't have commit access, so you will have to commit it.
Thank you
https://reviews.llvm.org/D35972
alexshap accepted this revision.
alexshap added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
do you have commit access ? (if not i can commit this patch for you)
https://reviews.llvm.org/D35972
___
cfe-commits mailing l
sameconrad added inline comments.
Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:178
for (const auto *Initializer : CtorDecl->inits()) {
-if (!Initializer->isWritten())
+if (!Initializer->isMemberInitializer() || !Initializer->isWritten())
continue;
--
sameconrad updated this revision to Diff 108812.
sameconrad added a comment.
Add additional tests for cases with base and derived classes.
Add clarifying comments about emitting warnings for base class members during
reordering checks.
Add fix for bug where reordering in init lists that contain n
sylvestre.ledru created this revision.
Herald added subscribers: xazax.hun, JDevlieghere.
In the current list http://clang.llvm.org/extra/clang-tidy/checks/list.html
it is hard to know which one has autofix or not.
This isn't perfect because we will have to list but I haven't found a better
way.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309488: [X86][AVX] Ensure vector non-temporal load/store
intrinsics force pointer… (authored by RKSimon).
Changed prior to commit:
https://reviews.llvm.org/D35996?vs=108646&id=108788#toc
Repository:
Author: rksimon
Date: Sat Jul 29 08:33:34 2017
New Revision: 309488
URL: http://llvm.org/viewvc/llvm-project?rev=309488&view=rev
Log:
[X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer
alignment (PR33830)
Clang specifies a max type alignment of 16 bytes on darwin targets (
Author: vleschuk
Date: Sat Jul 29 01:18:38 2017
New Revision: 309484
URL: http://llvm.org/viewvc/llvm-project?rev=309484&view=rev
Log:
Fix incorrect assertion condition.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http://llvm.org/viewvc/l
16 matches
Mail list logo
