[PATCH] D33719: Add _Float16 as a C/C++ source language type

ahatanak added a comment. Also, please create your new patch with context (git diff -U99 other-branch). https://reviews.llvm.org/D33719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D33721: [ARM] Add support for target("arm") and target("thumb").

ahatanak added inline comments. Comment at: lib/Basic/Targets.cpp:5444 +Feature = "-thumb-mode"; + if (Feature.compare("+thumb") == 0) +Feature = "+thumb-mode"; This can be "else if". https://reviews.llvm.org/D33721 _

[PATCH] D33719: Add _Float16 as a C/C++ source language type

ahatanak added inline comments. Comment at: include/clang/Basic/TokenKinds.def:379 +// C11 Extension +KEYWORD(_Float16, KEYALL) + Just wanted to confirm that your intention is to unconditionally support _Float16 (for example, c99 supports it

[PATCH] D33852: Enable __declspec(selectany) on linux

majnemer added inline comments. Comment at: include/clang/Basic/Attr.td:2421 -def SelectAny : InheritableAttr, TargetSpecificAttr { +def SelectAny : InheritableAttr, TargetSpecificAttr { let Spellings = [Declspec<"selectany">, GCC<"selectany">]; selectany sh

[PATCH] D32385: [libcxx] optional: Implement LWG 2900 and P0602

CaseyCarter updated this revision to Diff 101366. CaseyCarter added a comment. Fix merge conflicts. https://reviews.llvm.org/D32385 Files: include/optional test/libcxx/utilities/optional/optional.object/special_member_gen.pass.cpp test/std/utilities/optional/optional.object/optional.obje

r304687 - [clang-format] Don't align too long broken trailing comments

Author: krasimir Date: Sun Jun 4 14:27:02 2017 New Revision: 304687 URL: http://llvm.org/viewvc/llvm-project?rev=304687&view=rev Log: [clang-format] Don't align too long broken trailing comments Summary: This patch fixes a bug where clang-format will align newly broken trailing comments even if

[PATCH] D30170: Function definition may have uninstantiated body

sepavloff updated this revision to Diff 101362. sepavloff added a comment. Updated patch according to review notes https://reviews.llvm.org/D30170 Files: include/clang/AST/Decl.h lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp test/SemaCXX/friend2.cpp Index: test/SemaCXX

[PATCH] D33732: Catch invalid bitwise operation on vector of floats

sepavloff updated this revision to Diff 101359. sepavloff added a comment. Updated regression test The new regression test was obtained from Sema/vector-ops.c, the part of it that checks binary complement was copied. https://reviews.llvm.org/D33732 Files: lib/Sema/SemaExpr.cpp test/Sema/ex

[PATCH] D33732: Catch invalid bitwise operation on vector of floats

sepavloff added inline comments. Comment at: test/Sema/types.c:92 + +typedef float __attribute__((ext_vector_type(4))) float4; +float4 test3(float4 x) { bruno wrote: > Can you also add a test for the `vector_type` variant? It might be more > appropriate to put

[PATCH] D33852: Enable __declspec(selectany) on linux

Prazek added a comment. I fired bug about the crash: https://bugs.llvm.org/show_bug.cgi?id=33300 https://reviews.llvm.org/D33852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33852: Enable __declspec(selectany) on linux

Prazek updated this revision to Diff 101352. Prazek added a comment. - Fixes https://reviews.llvm.org/D33852 Files: include/clang/Basic/Attr.td test/Sema/attr-selectany-not-supported.c test/Sema/attr-selectany.c test/SemaCXX/attr-selectany.cpp utils/TableGen/ClangAttrEmitter.cpp Ind

r304684 - Implement isDefined by call to isThisDeclarationADefinition.

Author: sepavloff Date: Sun Jun 4 07:53:12 2017 New Revision: 304684 URL: http://llvm.org/viewvc/llvm-project?rev=304684&view=rev Log: Implement isDefined by call to isThisDeclarationADefinition. Modifies FunctionDecl::isThisDeclarationADefinition so that it covers all the cases checked by Funct

[PATCH] D33877: [test] Fix baremetal test to allow any -resource-dir

mgorny created this revision. The baremetal test (r303873) has been added with expectance of very specific -resource-dir. However, the test itself nor the BareMetal driver does not enforce any specific -resource-dir, making this constraint invalid. It already has been altered twice -- in r303910 f