arphaman added a comment.
Thanks for working on this!
We had some more discussion about these tests yesterday, and we would prefer to
keep them actually. We might want to use something like `REQUIRES` instead, but
right now we are still not sure what to check for.
https://reviews.llvm.org/D32
Hahnfeld added a comment.
Ping
https://reviews.llvm.org/D30087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xiangzhai updated this revision to Diff 95690.
xiangzhai added a comment.
Hi Artem,
> so you're doing the binding thing now?
No! it only works for `RetVal` for example `int *ret = memset(x, 0,
sizeof(int));`, please see my testcase:
void foo() {
int *x = malloc(sizeof(int));
int *ret
djasper added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:413
+
+ while (Param && !Param->is(tok::l_paren)) {
+if (!Param->is(tok::identifier) && !Param->is(tok::comma))
enyquist wrote:
> djasper wrote:
> > enyquist wrote:
> > > djasper wro
smeenai created this revision.
Windows Itanium aims to use MSVC export and import semantics. Inner
class members shouldn't be exported on a dllexport explicit
instantiation definition of the outer class, and they shouldn't be
imported on a dllimport explicit instantiation declaration of the outer
Author: djasper
Date: Wed Apr 19 01:06:38 2017
New Revision: 300661
URL: http://llvm.org/viewvc/llvm-project?rev=300661&view=rev
Log:
clang-format: Properly match parens of macro parameter lists.
No tests yet, but this will be tested by the upcoming:
https://reviews.llvm.org/D28462
Modified:
Thanks for the revert, I'll investigate tomorrow.
On 18 Apr 2017 10:41 pm, "Chandler Carruth" wrote:
> Reverted in r300658.
>
> On Tue, Apr 18, 2017 at 8:30 PM Chandler Carruth
> wrote:
>
>> Consider code like the following:
>>
>> ```
>> #include
>>
>> template
>> class MyAllocator : public s
Reverted in r300658.
On Tue, Apr 18, 2017 at 8:30 PM Chandler Carruth
wrote:
> Consider code like the following:
>
> ```
> #include
>
> template
> class MyAllocator : public std::allocator {
> public:
> typedef std::allocator Alloc;
> typedef typename Alloc::pointer pointer;
> typedef t
Author: chandlerc
Date: Wed Apr 19 00:25:13 2017
New Revision: 300659
URL: http://llvm.org/viewvc/llvm-project?rev=300659&view=rev
Log:
Revert r300653 and r300650. The underlying commit fixes one issue with
modules but exposes much more widespread issues. Example and more
information is on the rev
Author: ctopper
Date: Wed Apr 19 00:17:33 2017
New Revision: 300658
URL: http://llvm.org/viewvc/llvm-project?rev=300658&view=rev
Log:
[CodeGen] Use APInt::lshrInPlace instead of APInt::lshr. NFC
Modified:
cfe/trunk/lib/CodeGen/CGExprConstant.cpp
Modified: cfe/trunk/lib/CodeGen/CGExprConstant
xiangzhai updated this revision to Diff 95684.
xiangzhai added a subscriber: cfe-commits.
xiangzhai added a comment.
Hi Artem,
I updated my patch as you suggested: never using `Arg1Val` after `TotalSize` is
computed, on all branches. please review it, thanks a lot!
Regards,
Leslie Zhai
Reposi
rjmccall added a comment.
Thanks for CC'ing me. There are two problems here.
The first is that vectors are aggregates which contain values of their element
type. (And honestly, we may need to be more permissive than this because
people are pretty lax about the element type in a vector until i
Consider code like the following:
```
#include
template
class MyAllocator : public std::allocator {
public:
typedef std::allocator Alloc;
typedef typename Alloc::pointer pointer;
typedef typename Alloc::size_type size_type;
MyAllocator() {}
template
MyAllocator(const MyAllocator
enyquist updated this revision to Diff 95680.
enyquist added a comment.
Rebased on latest
Repository:
rL LLVM
https://reviews.llvm.org/D28462
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/WhitespaceManager.cpp
lib/Format/Whit
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, this looks great. A few tweaks about the diagnostic and LGTM.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4985
+def note_protected_by_objc_fast_enumer
This appears to break a pretty straightforward use of things like
libstdc++'s __alloctr_rebind (undefined template with a default argument,
specializations, etc):
https://github.com/gcc-mirror/gcc/blob/gcc-4_9-branch/libstdc++-v3/include/bits/alloc_traits.h#L58-L73
At least, I'm getting errors fro
hfinkel added a comment.
To be clear, I'm find with disabling union tbaa until we can fix things for
real. I'm somewhat concerned that this patch is quadratic in the AST.
FWIW, I tried just setting TBAAPath = true in EmitLValueForField and then
returning nullptr from CodeGenTBAA::getTBAAStructT
Author: rsmith
Date: Tue Apr 18 21:19:21 2017
New Revision: 300653
URL: http://llvm.org/viewvc/llvm-project?rev=300653&view=rev
Log:
Fix member function call with null 'this' pointer.
Modified:
cfe/trunk/lib/AST/Decl.cpp
Modified: cfe/trunk/lib/AST/Decl.cpp
URL:
http://llvm.org/viewvc/llvm-
Author: ericwf
Date: Tue Apr 18 21:07:12 2017
New Revision: 300652
URL: http://llvm.org/viewvc/llvm-project?rev=300652&view=rev
Log:
Fix tests for extended noexcept in the container adaptors tests
Modified:
libcxx/trunk/test/std/containers/container.adaptors/priority.queue/priqueue.cons/defa
ahatanak created this revision.
This patch adds support for attribute "noescape", which is used to tell the
compiler that a block passed to a function will not be called after the
function returns.
To ensure that the block does not escape, clang imposes the following
restrictions on its usage:
Author: rsmith
Date: Tue Apr 18 20:36:43 2017
New Revision: 300650
URL: http://llvm.org/viewvc/llvm-project?rev=300650&view=rev
Log:
[modules] Properly look up the owning module for an instantiation of a merged
template.
When looking for the template instantiation pattern of a templated entity,
Author: ericwf
Date: Tue Apr 18 20:35:58 2017
New Revision: 300649
URL: http://llvm.org/viewvc/llvm-project?rev=300649&view=rev
Log:
Cleanup usages of _LIBCPP_HAS_NO_ in
Modified:
libcxx/trunk/include/exception
Modified: libcxx/trunk/include/exception
URL:
http://llvm.org/viewvc/llvm-proje
Author: ericwf
Date: Tue Apr 18 20:34:08 2017
New Revision: 300648
URL: http://llvm.org/viewvc/llvm-project?rev=300648&view=rev
Log:
Cleanup usages of _LIBCPP_HAS_NO_ in , , ,
and
Modified:
libcxx/trunk/include/bitset
libcxx/trunk/include/ios
libcxx/trunk/include/iterator
libcxx
Author: ericwf
Date: Tue Apr 18 20:28:47 2017
New Revision: 300646
URL: http://llvm.org/viewvc/llvm-project?rev=300646&view=rev
Log:
Cleanup remaining usages of _LIBCPP_HAS_NO_ in the functional
library
Modified:
libcxx/trunk/include/__functional_base
libcxx/trunk/include/functional
Mod
Author: ericwf
Date: Tue Apr 18 20:23:39 2017
New Revision: 300644
URL: http://llvm.org/viewvc/llvm-project?rev=300644&view=rev
Log:
Cleanup remaining usages of _LIBCPP_HAS_NO_ in tuple and utility
Modified:
libcxx/trunk/include/__tuple
libcxx/trunk/include/tuple
libcxx/trunk/include/
Author: ericwf
Date: Tue Apr 18 20:23:04 2017
New Revision: 300643
URL: http://llvm.org/viewvc/llvm-project?rev=300643&view=rev
Log:
Cleanup remaining _LIBCPP_HAS_NO_ usages in container headers
Modified:
libcxx/trunk/include/__hash_table
libcxx/trunk/include/__split_buffer
libcxx/tru
Author: ericwf
Date: Tue Apr 18 20:02:49 2017
New Revision: 300637
URL: http://llvm.org/viewvc/llvm-project?rev=300637&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ in support headers and final tests
Modified:
libcxx/trunk/test/libcxx/containers/sequences/vector/asan_throw.pass.cpp
libcxx/trunk/t
ahatanak updated this revision to Diff 95667.
ahatanak added a comment.
Unconditionally ban jumping into body of ObjC fast enumeration loop.
https://reviews.llvm.org/D32187
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/JumpDiagnostics.cpp
lib/Sema/SemaStmt.cpp
test/SemaObjC
Author: ericwf
Date: Tue Apr 18 19:56:32 2017
New Revision: 300635
URL: http://llvm.org/viewvc/llvm-project?rev=300635&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ in the utilities library
Modified:
libcxx/trunk/test/std/utilities/meta/meta.help/integral_constant.pass.cpp
libcxx/trunk/test/std/
erichkeane created this revision.
The original idea was that if the attribute on an operator, that the
return-value unused-ness wouldn't matter. However, all of the operators except
postfix inc/dec return references! References don't result in this warning
anyway, so those are already exclude
Author: ericwf
Date: Tue Apr 18 19:28:44 2017
New Revision: 300633
URL: http://llvm.org/viewvc/llvm-project?rev=300633&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ in the string library.
Modified:
libcxx/trunk/include/string
libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_ins
Author: ericwf
Date: Tue Apr 18 19:23:45 2017
New Revision: 300632
URL: http://llvm.org/viewvc/llvm-project?rev=300632&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ macros in the numeric tests and headers
Modified:
libcxx/trunk/include/random
libcxx/trunk/include/valarray
libcxx/trunk/test/s
Author: rnk
Date: Tue Apr 18 18:50:03 2017
New Revision: 300628
URL: http://llvm.org/viewvc/llvm-project?rev=300628&view=rev
Log:
Use less temporary AttributeLists NFC
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/lib/CodeGen/CGCall.h
cfe/trunk/lib/CodeGen/CGVTables.cpp
cfe
Author: ericwf
Date: Tue Apr 18 18:42:15 2017
New Revision: 300627
URL: http://llvm.org/viewvc/llvm-project?rev=300627&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ macro usage in regex
Modified:
libcxx/trunk/include/regex
libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/init.pass.cpp
Author: ericwf
Date: Tue Apr 18 18:38:41 2017
New Revision: 300626
URL: http://llvm.org/viewvc/llvm-project?rev=300626&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ in the input.output library
Modified:
libcxx/trunk/include/fstream
libcxx/trunk/include/istream
libcxx/trunk/include/ostream
Thanks! One nit: StringRef doesn't need to be qualified.
On Apr 18, 2017 11:00 PM, "Haojian Wu via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: hokein
Date: Tue Apr 18 15:47:34 2017
New Revision: 300588
URL: http://llvm.org/viewvc/llvm-project?rev=300588&view=rev
Log:
[clang-tidy] A
mclow.lists added inline comments.
Comment at: libcxx/include/math.h:400
+inline _LIBCPP_INLINE_VISIBILITY
+typename std::enable_if::value, int>::type
+fpclassify(_A1 __lcpp_x) _NOEXCEPT
hfinkel wrote:
> Maybe we should predicate this, and other infinity-related
Author: ericwf
Date: Tue Apr 18 18:26:47 2017
New Revision: 300625
URL: http://llvm.org/viewvc/llvm-project?rev=300625&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ in algorithm
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/test/std/algorithms/alg.modifying.operations/alg.move/move.pass.
Author: ericwf
Date: Tue Apr 18 18:09:36 2017
New Revision: 300623
URL: http://llvm.org/viewvc/llvm-project?rev=300623&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ macros for std::initializer_list
Added:
libcxx/trunk/test/std/language.support/support.initlist/include_cxx03.pass.cpp
Modified:
li
Author: ericwf
Date: Tue Apr 18 18:05:08 2017
New Revision: 300622
URL: http://llvm.org/viewvc/llvm-project?rev=300622&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ macros in thread.
Modified:
libcxx/trunk/include/__mutex_base
libcxx/trunk/include/mutex
libcxx/trunk/include/thread
libcxx
hfinkel created this revision.
Herald added subscribers: mcrosier, emaste.
This patch introduces the runtime components of a TBAA sanitizer: a sanitizer
for type-based aliasing violations.
C/C++ have type-based aliasing rules, and LLVM's optimizer can exploit these
given TBAA metadata added by
joshz updated this revision to Diff 95655.
joshz added a comment.
Updated per some suggestions by sbenza@ on dealing with the parentheses;
IsBinaryOrTernary is based on a function he wrote at Google.
PTAL.
Repository:
rL LLVM
https://reviews.llvm.org/D31542
Files:
clang-tidy/readability/
Author: ericwf
Date: Tue Apr 18 17:50:56 2017
New Revision: 300620
URL: http://llvm.org/viewvc/llvm-project?rev=300620&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ in std::unordered_map and
std::unordered_multimap
This completes the cleanup of the containers, at least within the tests.
Modified:
l
Author: ericwf
Date: Tue Apr 18 17:37:32 2017
New Revision: 300619
URL: http://llvm.org/viewvc/llvm-project?rev=300619&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ macros in std::unordered_set and
std::unordered_multiset
Modified:
libcxx/trunk/include/unordered_set
libcxx/trunk/test/std/contain
Author: rsmith
Date: Tue Apr 18 16:55:37 2017
New Revision: 300611
URL: http://llvm.org/viewvc/llvm-project?rev=300611&view=rev
Log:
[modules-ts] Fold together -x c++ and -x c++-module at -cc1 level.
The driver needs to know whether it's building a module interface or
implementation unit because
Author: rsmith
Date: Tue Apr 18 16:45:04 2017
New Revision: 300609
URL: http://llvm.org/viewvc/llvm-project?rev=300609&view=rev
Log:
Do not warn about whitespace between ??/ trigraph and newline in line comments
if trigraphs are disabled in the current language.
Modified:
cfe/trunk/lib/Lex/L
djasper added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:11652
static bool ShouldWarnAboutMissingPrototype(const FunctionDecl *FD,
- const FunctionDecl*& PossibleZeroParamPrototype) {
+ const FunctionDecl*& Possible
Author: ericwf
Date: Tue Apr 18 16:23:18 2017
New Revision: 300604
URL: http://llvm.org/viewvc/llvm-project?rev=300604&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ for std::queue and std::priority_queue.
Modified:
libcxx/trunk/include/queue
libcxx/trunk/test/std/containers/container.adaptors/pr
fjricci created this revision.
Support for leak sanitizer on darwin has been added to
compiler-rt, this patch adds compiler support.
https://reviews.llvm.org/D32192
Files:
lib/Driver/ToolChains/Darwin.cpp
Index: lib/Driver/ToolChains/Darwin.cpp
==
Author: ericwf
Date: Tue Apr 18 16:16:26 2017
New Revision: 300602
URL: http://llvm.org/viewvc/llvm-project?rev=300602&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ macro uses in std::stack.
Modified:
libcxx/trunk/include/stack
libcxx/trunk/test/std/containers/container.adaptors/stack/stack.cons
Author: ericwf
Date: Tue Apr 18 16:08:06 2017
New Revision: 300600
URL: http://llvm.org/viewvc/llvm-project?rev=300600&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ macros in std::map and std::multimap
Modified:
libcxx/trunk/include/map
libcxx/trunk/test/std/containers/associative/map/map.access
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r300594.
https://reviews.llvm.org/D32119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Tue Apr 18 15:58:03 2017
New Revision: 300595
URL: http://llvm.org/viewvc/llvm-project?rev=300595&view=rev
Log:
Cleanup _LIBCPP_HAS_NO_ for std::set and std::multiset
Modified:
libcxx/trunk/include/set
libcxx/trunk/test/std/containers/associative/multiset/emplace.pass
Author: vvassilev
Date: Tue Apr 18 15:57:29 2017
New Revision: 300594
URL: http://llvm.org/viewvc/llvm-project?rev=300594&view=rev
Log:
PR30508: Downgrade error to warning if the umbrella folder doesn't exist.
Patch by Yuka Takahashi (D32119)!
Modified:
cfe/trunk/include/clang/Basic/Diagnost
rjmccall added a comment.
I wouldn't mind unconditionally banning this in JumpDiagnostics, actually.
https://reviews.llvm.org/D32187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Tue Apr 18 15:54:23 2017
New Revision: 300591
URL: http://llvm.org/viewvc/llvm-project?rev=300591&view=rev
Log:
The SubjectMatchRule enum should not be used as a DenseMap key to avoid
UBSAN 'invalid value' failures
The commit r300556 introduced a UBSAN issue that was caught
Author: hokein
Date: Tue Apr 18 15:47:34 2017
New Revision: 300588
URL: http://llvm.org/viewvc/llvm-project?rev=300588&view=rev
Log:
[clang-tidy] Address a few late comments.
Modified:
clang-tools-extra/trunk/clang-tidy/performance/InefficientVectorOperationCheck.cpp
Modified:
clang-tools-
ahatanak added a comment.
I see, thank you for the explanation.
https://reviews.llvm.org/D31976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak created this revision.
This fixes a bug in EmitObjCForCollectionStmt which is causing clang to
generate malformed IR.
When the following code (which I think is legal, at least when it is not
compiled with ARC) is compiled:
$ cat test1.m
@interface Obj
@end
void bar(void);
voi
erichkeane added a comment.
Bump! I'll note that this patch has nothing to do with MSVC and should simply
be a memory-usage savings.
https://reviews.llvm.org/D32046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: caseycarter
Date: Tue Apr 18 15:04:39 2017
New Revision: 300581
URL: http://llvm.org/viewvc/llvm-project?rev=300581&view=rev
Log:
[test] Silence another unused-typedef warning
Modified:
libcxx/trunk/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move_convert.
Author: kromanova
Date: Tue Apr 18 14:44:07 2017
New Revision: 300578
URL: http://llvm.org/viewvc/llvm-project?rev=300578&view=rev
Log:
[DOXYGEN] Minor improvements in doxygen comments.
- To be consistent with the rest of the intrinsics headers, I removed the tags
.. for marking instruction na
eugenis added a comment.
Ping.
I don't really have a preference.
Repository:
rL LLVM
https://reviews.llvm.org/D32064
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sorry I've been meaning to enable `-Wunused-typedef" for a while but I
haven't had a chance to clean up the remaining occurrences
Thanks for the cleanup.
On Tue, Apr 18, 2017 at 12:44 PM, Casey Carter via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: caseycarter
> Date: Tue Apr 18 1
Author: caseycarter
Date: Tue Apr 18 13:44:33 2017
New Revision: 300575
URL: http://llvm.org/viewvc/llvm-project?rev=300575&view=rev
Log:
[test] Silence unused parameter/typedef warnings
Modified:
libcxx/trunk/test/std/language.support/support.exception/except.nested/throw_with_nested.pass.c
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D32119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
alexfh added inline comments.
Comment at: cfe/trunk/include/clang/Basic/AttrDocs.td:2792
+ namespace N {
+[[clang::suppress("type", "bounds")]];
+...
Should this be `gsl::suppress` as well?
Repository:
rL LLVM
https://reviews.llvm.org/D24886
aaron.ballman created this revision.
The -coverage-file flag was removed in r280306, but I believe this part may
have been missed. However, since I'm unfamiliar with this feature, I wanted to
be sure.
https://reviews.llvm.org/D32181
Files:
lib/Driver/Job.cpp
Index: lib/Driver/Job.cpp
alexfh accepted this revision.
alexfh added a comment.
LG with one nit.
Comment at: clang-tidy/readability/ContainerSizeEmptyCheck.cpp:209
+ "the 'empty' method should be used to check "
+ "for emptiness instead of comparing to an empty object.")
+<< Hin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300572: Remove unused varible (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D32014?vs=95123&id=95602#toc
Repository:
rL LLVM
https://reviews.llvm.org/D32014
Files:
cfe/trunk
Author: rnk
Date: Tue Apr 18 12:44:41 2017
New Revision: 300572
URL: http://llvm.org/viewvc/llvm-project?rev=300572&view=rev
Log:
Remove unused varible
The Result variable is unused both in Sema::CheckARMBuiltinFunctionCall
and Sema::CheckAArch64BuiltinFunctionCall, remove it.
Patch by Wei-Ren C
Author: manojgupta
Date: Tue Apr 18 12:36:10 2017
New Revision: 300571
URL: http://llvm.org/viewvc/llvm-project?rev=300571&view=rev
Log:
[AArch64][clang] Pass cpu/arch information to assembler for AArch64.
Summary:
Pass Cpu/Arch options to assembler for AArch64 with no-integrated-as.
This fixes P
Author: manojgupta
Date: Tue Apr 18 12:34:46 2017
New Revision: 300570
URL: http://llvm.org/viewvc/llvm-project?rev=300570&view=rev
Log:
Testing commit access.
Summary: Test commit access.
Reviewers: gbiv, george.burgess.iv
Reviewed By: george.burgess.iv
Subscribers: cfe-commits
Differential
Author: alexfh
Date: Tue Apr 18 12:26:00 2017
New Revision: 300569
URL: http://llvm.org/viewvc/llvm-project?rev=300569&view=rev
Log:
[clang-tidy] Fix google-explicit-constructor issue with out-of-line conversions
Modified:
clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.cpp
Author: marshall
Date: Tue Apr 18 12:22:49 2017
New Revision: 300568
URL: http://llvm.org/viewvc/llvm-project?rev=300568&view=rev
Log:
Mark LWG#2788 as complete - we already do this
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.or
alexfh added a comment.
Awesome, thanks! A few late comments inline.
Comment at:
clang-tools-extra/trunk/clang-tidy/performance/InefficientVectorOperationCheck.cpp:56
+void InefficientVectorOperationCheck::registerMatchers(MatchFinder *Finder) {
+ const auto VectorDecl = cxxR
jroelofs created this revision.
These tests are breaking when tested under the upstream 3.8.1 release + the
10.12 / 16C58 sdk. They use headers from the host SDKs, so they are not stable
with respect to adding new language features, such as class `@properties`.
Regression tests should not depen
arphaman updated this revision to Diff 95596.
arphaman marked 2 inline comments as done.
arphaman added a comment.
Add comments and remove `-fno-allow-editor-placeholders` from CC1 options.
Repository:
rL LLVM
https://reviews.llvm.org/D32081
Files:
include/clang/Basic/DiagnosticLexKinds.td
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D32164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
arphaman updated this revision to Diff 95593.
arphaman added a comment.
Avoid a vector copy by using a reference variable.
Repository:
rL LLVM
https://reviews.llvm.org/D32176
Files:
include/clang/Basic/Attr.td
lib/Sema/SemaDeclAttr.cpp
test/Misc/pragma-attribute-supported-attributes-li
arphaman created this revision.
Right now the `external_source_symbol` attribute isn't supported by `#pragma
clang attribute` for the following two reasons:
- The `Named` attribute subject isn't supported by TableGen.
- There was no way to specify a subject match rule for `#pragma clang
attribu
Author: hokein
Date: Tue Apr 18 11:25:03 2017
New Revision: 300563
URL: http://llvm.org/viewvc/llvm-project?rev=300563&view=rev
Log:
Make the test pass on x86_64-win32 target.
Modified:
clang-tools-extra/trunk/test/clang-tidy/performance-inefficient-vector-operation.cpp
Modified:
clang-too
hokein added a comment.
@chapuni, thanks for the workaround. It makes sense to make it work for
targeting msvc. Will fix it in a follow-up.
Repository:
rL LLVM
https://reviews.llvm.org/D31757
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
alexfh created this revision.
Missing 'static' on functions that are intended to be local to a translation
unit seems to be the most common cause of -Wmissing-prototypes warnings, so
suggesting a fix seems to be convenient and useful.
https://reviews.llvm.org/D32170
Files:
include/clang/Basic
joshz added a comment.
I don't believe I have access to commit this revision myself; can someone
please do it for me?
Thanks! :-)
Repository:
rL LLVM
https://reviews.llvm.org/D31542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
joshz added a comment.
Thanks, Aaron!
Repository:
rL LLVM
https://reviews.llvm.org/D31542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: martell
Date: Tue Apr 18 10:56:24 2017
New Revision: 300562
URL: http://llvm.org/viewvc/llvm-project?rev=300562&view=rev
Log:
mingw-w64: enable support for __declspec(selectany)
Add selectany as a GCC spelling for mingw-w64
Reviewers: rnk
Differential revision: https://reviews.llvm.org/
benlangmuir added inline comments.
Comment at: include/clang/Basic/IdentifierTable.h:358
+ /// Return true if this identifier is an editor placeholder.
+ bool isEditorPlaceholder() const {
Nitpick: There should probably be an example in the doc comment. The
Author: arphaman
Date: Tue Apr 18 10:12:34 2017
New Revision: 300560
URL: http://llvm.org/viewvc/llvm-project?rev=300560&view=rev
Log:
[ASTPrinter] Print template parameter lists for out-of-line functions
Modified:
cfe/trunk/lib/AST/DeclPrinter.cpp
cfe/trunk/test/Misc/ast-print-out-of-lin
No problem, thanks for the quick update!
On 18 April 2017 at 15:56, Martell Malone wrote:
> Yes I do :)
> I updated https://reviews.llvm.org/D15005 with a comment incase anyone
> goes there.
> I also updated https://reviews.llvm.org/D15006 (the correct link) to
> point to the commit revision.
>
xiangzhai added a comment.
Hi All,
Thanks for your review! I will update my patch tomorrow! Almost 4+ days no see,
I miss you :)
Regards,
Leslie Zhaii
Repository:
rL LLVM
https://reviews.llvm.org/D31868
___
cfe-commits mailing list
cfe-commits
Yes I do :)
I updated https://reviews.llvm.org/D15005 with a comment incase anyone goes
there.
I also updated https://reviews.llvm.org/D15006 (the correct link) to point
to the commit revision.
Thanks for pointing that out Alex
On Tue, Apr 18, 2017 at 3:49 PM, Alex L wrote:
> I think you've got
martell added a comment.
It won't let me revert the automatically updated diff to the previous one
because I am not the author.
@faisalv are you able todo this and Sorry for the confusion.
Repository:
rL LLVM
https://reviews.llvm.org/D15005
___
martell added a comment.
In case anyone comes here looking for https://reviews.llvm.org/rL300555 that
should be https://reviews.llvm.org/D15006 no https://reviews.llvm.org/D15005.
Thanks
Repository:
rL LLVM
https://reviews.llvm.org/D15005
___
c
I think you've got the wrong Phabricator link in the commit log.
On 18 April 2017 at 15:27, Martell Malone via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: martell
> Date: Tue Apr 18 09:27:36 2017
> New Revision: 300555
>
> URL: http://llvm.org/viewvc/llvm-project?rev=300555&view=re
martell added a comment.
Committed as https://reviews.llvm.org/rL300555
Repository:
rL LLVM
https://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300555: Driver: Better detection of mingw-gcc (authored by
martell).
Changed prior to commit:
https://reviews.llvm.org/D15005?vs=41206&id=95568#toc
Repository:
rL LLVM
https://reviews.llvm.org/D1500
Author: martell
Date: Tue Apr 18 09:27:36 2017
New Revision: 300555
URL: http://llvm.org/viewvc/llvm-project?rev=300555&view=rev
Log:
Driver: Better detection of mingw-gcc
Stop blindly searching for "gcc.exe" on windows.
Stop assuming "/usr" on unix, fixes cross compiling.
Reviewers: mati865, ya
baloghadamsoftware created this revision.
Herald added a subscriber: whisperity.
Users reported some false positives using this check. This patch sets the
default value of the option for checking implicit widening casts to false. We
also suggest renaming the check to something like missing-or-mi
NoQ added a comment.
Wow, so you're doing the binding thing now? Thanks! It was not critical for
landing this patch, so you could have fixed comments here, allowing us to
commit what's already done, and then proceed with further improvements. It's
also easier to review and aligns with the LLVM'
1 - 100 of 136 matches
Mail list logo
