[PATCH] D31168: Set FMF for -ffp-contract=fast

rjmccall added a comment. I may have missed earlier steps in this patch series. Why is this being done statefully and contextually in the IRBuilder instead of just applying the flag from the BinaryOperator to the instruction when building it? It's not like ScalarExprEmitter doesn't know that

[PATCH] D31575: [clang-format] Use configured IndentWidth instead of 2

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. looks good https://reviews.llvm.org/D31575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

r299321 - [X86] Add __extension__ to f16c macro intrinsics to suppress warnings about compound literals when compiled for with earlier language standards enabled.

Author: ctopper Date: Sat Apr 1 22:02:53 2017 New Revision: 299321 URL: http://llvm.org/viewvc/llvm-project?rev=299321&view=rev Log: [X86] Add __extension__ to f16c macro intrinsics to suppress warnings about compound literals when compiled for with earlier language standards enabled. Fixes PR3

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D31168: Set FMF for -ffp-contract=fast

anemet added a comment. Ping. This is the only patch in the series now that wasn't approved. https://reviews.llvm.org/D31168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

GorNishanov added inline comments. Comment at: lib/Sema/CoroutineBuilder.h:1 +//===- CoroutineBuilder.h - Coroutine Semantic checking -*- C++ -*-===// +// I would name the file to match the class it declares, i.e CoroutineStmtBuilder.h, since it is the

[PATCH] D31508: [ThinLTO] Set up lto::Config properly for codegen in ThinLTO backends

tejohnson added a comment. In https://reviews.llvm.org/D31508#716087, @davide wrote: > clang -cc1 crashes if an invalid reloc model is passed (via > `-mreloc-model=`), see https://bugs.llvm.org/show_bug.cgi?id=32490 > I'm not sure if the bug was already there or this refactoring exposed it. >

[PATCH] D31575: [clang-format] Use configured IndentWidth instead of 2

thatguystone created this revision. Herald added a subscriber: klimek. For JS projects that use a IdentWidth other than 2, this was causing the indent to be 2 when creating new objects in arrays. Repository: rL LLVM https://reviews.llvm.org/D31575 Files: lib/Format/ContinuationIndenter.cp

r299316 - [NFC, Scoped Enum] Convert Sema::ExpressionEvaluationContext into a scoped Enum

Author: faisalv Date: Sat Apr 1 16:30:49 2017 New Revision: 299316 URL: http://llvm.org/viewvc/llvm-project?rev=299316&view=rev Log: [NFC, Scoped Enum] Convert Sema::ExpressionEvaluationContext into a scoped Enum - also replace direct equality checks against the ConstantEvaluated enumerator wi

[PATCH] D31508: [ThinLTO] Set up lto::Config properly for codegen in ThinLTO backends

davide added a comment. r299315 Repository: rL LLVM https://reviews.llvm.org/D31508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r299315 - [Driver] Don't crash on invalid values of -mrelocation-model=.

Author: davide Date: Sat Apr 1 16:07:07 2017 New Revision: 299315 URL: http://llvm.org/viewvc/llvm-project?rev=299315&view=rev Log: [Driver] Don't crash on invalid values of -mrelocation-model=. This is handled in a similar way we handle invalid -mcode-model. PR: 31840 Added: cfe/trunk/tes

[PATCH] D31508: [ThinLTO] Set up lto::Config properly for codegen in ThinLTO backends

davide added a comment. clang -cc1 crashes if an invalid reloc model is passed (via `-mreloc-model=`), see https://bugs.llvm.org/show_bug.cgi?id=32490 I'm not sure if the bug was already there or this refactoring exposed it. Either way, I'm going to submit a patch to get this fixed. Ideally, we

Re: [PATCH] Use the correct ObjC++ personality

Landed in r299306 with a test case. Yes, even one-liners should have a test case. On Thu, Mar 30, 2017 at 10:30 PM, Jonathan Schleifer via cfe-commits wrote: >> Testcase? > > Shouldn't be necessary for such a simple and extremely obvious one-liner. > > -- > Jonathan >

r299306 - [ObjC++] Use the correct EH personality in GNU mode

Author: d0k Date: Sat Apr 1 12:59:01 2017 New Revision: 299306 URL: http://llvm.org/viewvc/llvm-project?rev=299306&view=rev Log: [ObjC++] Use the correct EH personality in GNU mode Previously, it would just always use the ObjC DWARF personality, even with SjLj or SEH exceptions. Patch by Jonath

[PATCH] D31568: Add Python 3 support to clang.cindex

jbcoe created this revision. jbcoe added a project: clang-c. Introduce an interop string to convert from unicode to c-strings where needed. Add missing conversions from _CXString to strings in function registrations. Explicitly evaluate lists where Python 3's lazy iterators would not otherwise do

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

EricWF updated this revision to Diff 93742. EricWF added a comment. - Actually remove incorrectly added changes. https://reviews.llvm.org/D31562 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/SemaCXX/coroutines.cpp Index: test/SemaCXX/coroutines.cpp ===