dyung closed this revision.
dyung added a comment.
I forgot to add a reference to this in the commit message, so I'm closing this
manually.
This change was submitted with commit r296066.
https://reviews.llvm.org/D29812
___
cfe-commits mailing list
Hi Hans,
Did r295474 fall off your radar? Sorry that I asked for both commits in one
email, should I reply to the other original commit?
Thanks,
Jonas
> -Original Message-
> From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf
> Of Hans Wennborg
> Sent: Thursday, February
mgorny added inline comments.
Comment at: test/CodeGen/atomic-ops.c:1
-// RUN: %clang_cc1 %s -emit-llvm -o - -ffreestanding -ffake-address-space-map
-triple=i686-apple-darwin9 | FileCheck %s
+// RUN: %clang_cc1 %s -emit-llvm -o - -ffreestanding -ffake-address-space-map
-triple=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296082: [Driver] Enable SafeStack for Fuchsia targets
(authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D30238?vs=89393&id=89607#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: phosek
Date: Thu Feb 23 21:17:41 2017
New Revision: 296082
URL: http://llvm.org/viewvc/llvm-project?rev=296082&view=rev
Log:
[Driver] Enable SafeStack for Fuchsia targets
The runtime support is provided directly by the Fuchsia system C
library.
Patch by Roland McGrath
Differential Revis
Author: rtrieu
Date: Thu Feb 23 20:59:12 2017
New Revision: 296078
URL: http://llvm.org/viewvc/llvm-project?rev=296078&view=rev
Log:
[ODRHash] Add handling of TypedefType and DeclarationName
Differential Revision: https://reviews.llvm.org/D21675
Modified:
cfe/trunk/include/clang/Basic/Diagno
WFM; added them to ExtParameterInfo in r296076. Thanks for the idea!
On Wed, Feb 15, 2017 at 5:44 PM, Richard Smith
wrote:
> On 15 February 2017 at 17:32, George Burgess IV <
> george.burgess...@gmail.com> wrote:
>
>> I remember that we wanted to pretend that pass_object_size isn't a part
>> of
Author: gbiv
Date: Thu Feb 23 20:49:47 2017
New Revision: 296076
URL: http://llvm.org/viewvc/llvm-project?rev=296076&view=rev
Log:
Represent pass_object_size attrs in ExtParameterInfo
The goal of this is to fix a bug in modules where we'd merge
FunctionDecls that differed in their pass_object_siz
Author: rsmith
Date: Thu Feb 23 20:07:20 2017
New Revision: 296073
URL: http://llvm.org/viewvc/llvm-project?rev=296073&view=rev
Log:
Factor out some common code between SpecialMemberExceptionSpecInfo and
SpecialMemberDeletionInfo.
To simplify this, convert SpecialMemberOverloadResult to a value
Apparently not - I'm at 289944 locally. Sigh. Oh well, it was an
interesting investigation.
On Thu, Feb 23, 2017 at 3:48 PM, Nico Weber wrote:
> This looks pretty similar to https://reviews.llvm.org/D27849 – are you
> synced to trunk?
>
> On Thu, Feb 23, 2017 at 5:42 PM, Kevin Marshall via Phabr
hans added a comment.
lgtm2
https://reviews.llvm.org/D30239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
inglorion updated this revision to Diff 89598.
inglorion added a comment.
changed error message
https://reviews.llvm.org/D30239
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test/Driver/cl-options.c
Index: test/Driver/cl-opti
Author: rsmith
Date: Thu Feb 23 19:36:58 2017
New Revision: 296068
URL: http://llvm.org/viewvc/llvm-project?rev=296068&view=rev
Log:
Simplify and pass a more useful source location when computing an exception
specification for an implicit special member.
Modified:
cfe/trunk/lib/Sema/SemaDeclC
Author: rsmith
Date: Thu Feb 23 19:29:42 2017
New Revision: 296067
URL: http://llvm.org/viewvc/llvm-project?rev=296067&view=rev
Log:
Refactor computation of exception specification for special members to remove
some of the repetition.
Modified:
cfe/trunk/include/clang/AST/DeclCXX.h
cfe/tr
Author: dyung
Date: Thu Feb 23 19:25:02 2017
New Revision: 296066
URL: http://llvm.org/viewvc/llvm-project?rev=296066&view=rev
Log:
Recently a change was made to this test in r294639 which fails when the
compiler is run in a mode where the default C++ standard is newer than C++03.
The reason is be
This was reverted in r296063 due to PR31864.
On Mon, Jan 9, 2017 at 12:54 PM, Michal Gorny via cfe-commits
wrote:
> Author: mgorny
> Date: Mon Jan 9 14:54:20 2017
> New Revision: 291477
>
> URL: http://llvm.org/viewvc/llvm-project?rev=291477&view=rev
> Log:
> [Frontend] Correct values of ATOMIC_
Author: hans
Date: Thu Feb 23 19:16:34 2017
New Revision: 296063
URL: http://llvm.org/viewvc/llvm-project?rev=296063&view=rev
Log:
Revert r291477 "[Frontend] Correct values of ATOMIC_*_LOCK_FREE to match
builtin"
It caused PR31864. There is a patch in progress to fix that, but let's
revert in th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296062: [profiling] PR31992: Don't skip interesting non-base
constructors (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D30131?vs=89151&id=89595#toc
Repository:
rL LLVM
ht
Author: vedantk
Date: Thu Feb 23 19:15:19 2017
New Revision: 296062
URL: http://llvm.org/viewvc/llvm-project?rev=296062&view=rev
Log:
[profiling] PR31992: Don't skip interesting non-base constructors
Fix the fact that we don't assign profile counters to constructors in
classes with virtual bases,
vsk added a comment.
In https://reviews.llvm.org/D30131#684310, @arphaman wrote:
> LGTM.
>
> One point to note, when we are displaying coverage for constructors that have
> both the base and complete versions instrumented, e.g.:
>
> class Foo {
> public:
> Foo() { }
> };
>
> clas
hans added a reviewer: jyknight.
hans added a comment.
+jyknight, who had a similar patch in http://reviews.llvm.org/D17933 (see also
r291477 and PR31864)
Comment at: test/CodeGen/atomic-ops.c:1
-// RUN: %clang_cc1 %s -emit-llvm -o - -ffreestanding -ffake-address-space-map
-t
akyrtzi accepted this revision.
akyrtzi added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D28772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
arsenm created this revision.
Herald added subscribers: tpr, dstuttard, tony-tye, nhaehnle, wdng, kzhuravl.
https://reviews.llvm.org/D30316
Files:
lib/Basic/Targets.cpp
test/CodeGenOpenCL/amdgpu-nullptr.cl
Index: test/CodeGenOpenCL/amdgpu-nullptr.cl
==
hans added inline comments.
Comment at: test/Driver/cl-options.c:532
+// RUN: %clang_cl -### -Fe%t.exe -entry:main -flto -- %s 2>&1 | FileCheck
-check-prefix=LTO-WITHOUT-LLD %s
+// LTO-WITHOUT-LLD: invalid argument '-flto' only allowed with '-fuse-ld=lld'
+
This
inglorion updated this revision to Diff 89590.
inglorion added a comment.
fail early with a friendlier message when using -flto without -fuse-ld=lld
https://reviews.llvm.org/D30239
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test/Driver/cl-options.c
Index: test/Driver/c
Thanks for catching this! :)
On Thu, Feb 23, 2017 at 2:47 PM, Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Thu Feb 23 16:47:56 2017
> New Revision: 296034
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296034&view=rev
> Log:
> [CodeGen] Silence unus
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D29812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
dyung added a comment.
ping
https://reviews.llvm.org/D29812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Thu Feb 23 18:21:20 2017
New Revision: 296054
URL: http://llvm.org/viewvc/llvm-project?rev=296054&view=rev
Log:
NFC, Remove commented out block of code from CGBlocks.cpp
This is a preparation clean-up commit around the code that emits
block copy/dispose routines.
Modified:
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
It might make sense to move the *Arch.cpp files to a subdirectory of
lib/Driver, but otherwise this looks good.
https://reviews.llvm.org/D30315
Author: arphaman
Date: Thu Feb 23 18:09:30 2017
New Revision: 296048
URL: http://llvm.org/viewvc/llvm-project?rev=296048&view=rev
Log:
NFC, Add a test that ensures that we don't emit helper code in copy/dispose
routines for objects that are captured with the __unsafe_unretained
ownership qualifier
inglorion updated this revision to Diff 89583.
inglorion added a comment.
added missing --
https://reviews.llvm.org/D30239
Files:
include/clang/Driver/Options.td
test/Driver/cl-options.c
Index: test/Driver/cl-options.c
===
--
inglorion added inline comments.
Comment at: test/Driver/cl-options.c:525
+// RUN: %clang_cl -### /c -flto %s 2>&1 | FileCheck -check-prefix=LTO %s
+// LTO: -flto
hans wrote:
> This needs `--` before `%s`, otherwise if `%s` expands to e.g. `/Users/foo`
> it wi
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm with a comment
Comment at: test/Driver/cl-options.c:525
+// RUN: %clang_cl -### /c -flto %s 2>&1 | FileCheck -check-prefix=LTO %s
+// LTO: -flto
This need
Author: arphaman
Date: Thu Feb 23 17:41:50 2017
New Revision: 296040
URL: http://llvm.org/viewvc/llvm-project?rev=296040&view=rev
Log:
NFC, Add a test that ensure that we don't emit helper code in copy/dispose
routines for variables that are const-captured
This is a preparation commit that improv
This looks pretty similar to https://reviews.llvm.org/D27849 – are you
synced to trunk?
On Thu, Feb 23, 2017 at 5:42 PM, Kevin Marshall via Phabricator via
cfe-commits wrote:
> kmarshall created this revision.
>
> The extent calculation function had a bug which caused it to ignore if the
> size
inglorion updated this revision to Diff 89577.
inglorion retitled this revision from "enable -flto=thin, -flto-jobs=, and
-fthinlto-index= in clang-cl" to "enable -flto=thin in clang-cl".
inglorion added a comment.
Implemented @hans's suggestion of moving the tests into cl-options.c.
Also restri
Author: d0k
Date: Thu Feb 23 16:47:56 2017
New Revision: 296034
URL: http://llvm.org/viewvc/llvm-project?rev=296034&view=rev
Log:
[CodeGen] Silence unused variable warning in Release builds.
Modified:
cfe/trunk/lib/CodeGen/CGVTables.cpp
Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp
URL:
htt
Author: rsmith
Date: Thu Feb 23 16:41:47 2017
New Revision: 296033
URL: http://llvm.org/viewvc/llvm-project?rev=296033&view=rev
Log:
PR32044: Fix some cases where we would confuse a transparent init-list
expression with an aggregate init.
Modified:
cfe/trunk/lib/AST/Expr.cpp
cfe/trunk/li
kmarshall created this revision.
The extent calculation function had a bug which caused it to ignore if the size
value was defined prior to casting it. As a result, size expressions with free
variables would trigger assertion failures during the cast operation.
This patch adds that missing chec
Author: gbiv
Date: Thu Feb 23 16:14:55 2017
New Revision: 296027
URL: http://llvm.org/viewvc/llvm-project?rev=296027&view=rev
Log:
Tighten up a regex in a test
...If we're trying to match "this function has only two arguments", `.*`
probably isn't the best thing to use. :)
Modified:
cfe/trun
Author: gbiv
Date: Thu Feb 23 16:07:35 2017
New Revision: 296024
URL: http://llvm.org/viewvc/llvm-project?rev=296024&view=rev
Log:
[CodeGen] Fix ExtParameterInfo bugs in C++ CodeGen code.
This patch makes use of the prefix/suffix ABI argument distinction that
was introduced in r295870, so that we
Author: rsmith
Date: Thu Feb 23 15:43:43 2017
New Revision: 296020
URL: http://llvm.org/viewvc/llvm-project?rev=296020&view=rev
Log:
Add context note to diagnostics that occur while declaring an implicit special
member function.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:76
if (Ex) {
+ bool ArrayIndexOutOfBounds = false;
+ if (isa(Ex)) {
Please, pull this out into a sub-rutine. Thanks!
https://reviews.llvm.org/D28278
On Feb 23, 2017 8:48 PM, "Haojian Wu via Phabricator" <
revi...@reviews.llvm.org> wrote:
hokein added inline comments.
Comment at: unittests/include-fixer/find-all-symbols/
FindAllSymbolsTests.cpp:40
+ void reportSymbols(llvm::StringRef FileName,
+ SymbolInf
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D28772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296015: [ObjC][CodeGen] CodeGen support for @available.
(authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D27827?vs=89305&id=89556#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: epilk
Date: Thu Feb 23 15:08:08 2017
New Revision: 296015
URL: http://llvm.org/viewvc/llvm-project?rev=296015&view=rev
Log:
[ObjC][CodeGen] CodeGen support for @available.
CodeGens uses of @available into calls to the compiler-rt function
__isOSVersionAtLeast.
This commit is part of a fe
arphaman added a comment.
Thanks for the explanation, now I get it!
LGTM, with one request for change in the tests
Comment at: test/CodeGenObjC/availability-check.m:22
+ // CHECK: br i1 true
+ if (__builtin_available(macos 10.11, *))
+;
Please add a line
madsravn marked 18 inline comments as done.
madsravn added inline comments.
Comment at: test/clang-tidy/modernize-replace-random-shuffle.cpp:50
+ // CHECK-MESSAGE: [[@LINE-1]]:3: warning: do not use 'random_shuffle'. It is
deprecated and replaced by 'shuffle'. The old user defi
madsravn updated this revision to Diff 89543.
madsravn added a comment.
Updated the code based on comments received.
https://reviews.llvm.org/D30158
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp
Hi Eric
Looks like the issue is fixed in r295794? Now green dragon is failing due to
XPASS.
http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/3018/testReport/
Can we remove that XFAILs in these two files?
std/strings/basic_string/string_cons.implicit_deduction_guides.pass.cpp
std
hokein added inline comments.
Comment at: unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:40
+ void reportSymbols(llvm::StringRef FileName,
+ SymbolInfo::SignalMap NewSymbols) override {
+for (const auto &Entry : NewSymbols)
-
danielmarjamaki updated this revision to Diff 89540.
danielmarjamaki added a comment.
Making the error message more precise.
https://reviews.llvm.org/D28278
Files:
lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp
test/Analysis/uninit-vals-ps.c
Index: test/Analysis/uninit-vals-ps.c
=
danielmarjamaki abandoned this revision.
danielmarjamaki added a comment.
I will not work on this in the near future
Repository:
rL LLVM
https://reviews.llvm.org/D24861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Thanks! r296001.
On Thu, Feb 23, 2017 at 2:01 AM, Anastasia Stulova
wrote:
> Sure! No objections here!
>
> Thanks,
> Anastasia
>
> -Original Message-
> From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans
> Wennborg
> Sent: 22 February 2017 18:10
> To: Jan Vesely
>
Thanks! r296000.
On Wed, Feb 22, 2017 at 8:15 PM, Alexey Bataev wrote:
> Yes, approved
>
> Best regards,
> Alexey Bataev
>
>> 23 февр. 2017 г., в 1:00, Hans Wennborg написал(а):
>>
>> Alexey: ping?
>>
>>> On Tue, Feb 21, 2017 at 11:07 AM, Hans Wennborg wrote:
>>> I'm Ok with it if Alexey approv
rjmccall added a comment.
In https://reviews.llvm.org/D29986#684811, @rogfer01 wrote:
> Ping?
Are you expecting something even more conclusive than "looks good to me"?
Because I sent you that feedback a week ago. :)
https://reviews.llvm.org/D29986
rogfer01 added a comment.
Ping?
https://reviews.llvm.org/D29986
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:530
+ auto value = RVal;
+ if (auto loc = value.getAs()) {
+value = State->getRawSVal(*loc);
NoQ wrote:
> baloghadamsoftware wrote:
> > NoQ wrote:
> > > baloghadam
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:530
+ auto value = RVal;
+ if (auto loc = value.getAs()) {
+value = State->getRawSVal(*loc);
baloghadamsoftware wrote:
> NoQ wrote:
> > baloghadamsoftware wrote:
>
Author: klimek
Date: Thu Feb 23 10:02:53 2017
New Revision: 295988
URL: http://llvm.org/viewvc/llvm-project?rev=295988&view=rev
Log:
Make clang-include-fixer--insert-line work when the difference is on an empty
line
`clang-include-fixer--insert-line` has an off-by-one error because it
uses `(got
sammccall updated this revision to Diff 89510.
sammccall added a comment.
Update comment - oops!
https://reviews.llvm.org/D30210
Files:
include-fixer/InMemorySymbolIndex.cpp
include-fixer/InMemorySymbolIndex.h
include-fixer/IncludeFixer.cpp
include-fixer/SymbolIndex.h
include-fixer/Sy
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks! Looks good from my side.
I'd wait to see whether @bkramer has more comments before commit it.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:50
+ // used.
danielmarjamaki requested review of this revision.
danielmarjamaki added a comment.
I have updated the patch and want a new review.
https://reviews.llvm.org/D28297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
danielmarjamaki updated this revision to Diff 89507.
danielmarjamaki added a comment.
It was reported in the bugzilla report that my first fix did not fix all
crashes. A new example code was provided that triggered a new crash. I have
updated the patch so both crashes are fixed.
https://review
sammccall added a comment.
Thanks for bearing with me here :)
Comment at: include-fixer/InMemorySymbolIndex.h:27
- std::vector
+ std::vector
search(llvm::StringRef Identifier) override;
hokein wrote:
> sammccall wrote:
> > hokein wrote:
> > > There are m
sammccall updated this revision to Diff 89506.
sammccall marked 3 inline comments as done.
sammccall added a comment.
Address review comments; remove redundant namespace qualifiers; format.
https://reviews.llvm.org/D30210
Files:
include-fixer/InMemorySymbolIndex.cpp
include-fixer/InMemorySy
Hi Akira,
Pardon my slow reply here- I was traveling and just got back to work email. I
will check into this as soon as I can, and get back to you.
Thank you,
David
> On Feb 20, 2017, at 12:04 AM, Akira Hatanaka wrote:
>
> This patch changes the encoding of an id conforming to a protocol, w
hokein added inline comments.
Comment at: include-fixer/InMemorySymbolIndex.h:27
- std::vector
+ std::vector
search(llvm::StringRef Identifier) override;
sammccall wrote:
> hokein wrote:
> > There are many places using
> > `std::vector`. Maybe we can use
Author: sepavloff
Date: Thu Feb 23 09:10:45 2017
New Revision: 295982
URL: http://llvm.org/viewvc/llvm-project?rev=295982&view=rev
Log:
Reverted r295975
Removed:
cfe/trunk/test/SemaCXX/friend3.cpp
Removed: cfe/trunk/test/SemaCXX/friend3.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk
Author: sepavloff
Date: Thu Feb 23 08:34:04 2017
New Revision: 295975
URL: http://llvm.org/viewvc/llvm-project?rev=295975&view=rev
Log:
Added regression tests
Added:
cfe/trunk/test/SemaCXX/friend3.cpp
Added: cfe/trunk/test/SemaCXX/friend3.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tru
danielmarjamaki created this revision.
The error messages are confusing when shift result is undefined because the
shift count is negative or exceeds the bit width. I have seen that users often
draw the conclusion that Clang thinks some operand is uninitialized and
determine that Clang shows a
rmaprath marked an inline comment as done.
rmaprath added a comment.
Thanks!
Committed as r295963.
@gkistanova: Could you please let me know when the next restart is due? I would
like to keep an eye on the builders.
Cheers,
/ Asiri
Repository:
rL LLVM
https://reviews.llvm.org/D30290
_
vlad.tsyrklevich updated this revision to Diff 89497.
vlad.tsyrklevich marked 2 inline comments as done.
vlad.tsyrklevich added a comment.
Fixes and a test for Artem's suggestions.
https://reviews.llvm.org/D30289
Files:
lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp
test/Analysis/taint
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295963: [zorg] Fix no-exceptions libcxx configurations
(authored by asiri).
Changed prior to commit:
https://reviews.llvm.org/D30290?vs=89485&id=89496#toc
Repository:
rL LLVM
https://reviews.llvm.or
filcab accepted this revision.
filcab added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D30285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
I'll add a local task to look into that, but with Connect coming, I'm not sure
how long that will take. :)
https://reviews.llvm.org/D30290
__
rmaprath marked an inline comment as done.
rmaprath added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:1196
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl
-L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'},
rmaprath updated this revision to Diff 89485.
rmaprath added a comment.
Updated to address comments from @rengolin.
In theory, it should not be necessary to link-in or enable the unwinder for
these tests. However, it is best to leave this for a separate patch (after some
local testing), just to
danielmarjamaki added a comment.
In https://reviews.llvm.org/D28278#677905, @zaks.anna wrote:
> Does the code you added detects array out of bounds cases without false
> positives? Is it an option to just have this checkers produce a more precise
> error message in the specific case.
>
> A lot
rengolin added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:1196
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl
-L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'},
+cmake_extra_opts={'LIBCXX_ENAB
rmaprath added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:1196
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl
-L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'},
+cmake_extra_opts={'LIBCXX_ENAB
rengolin added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:1196
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl
-L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'},
+cmake_extra_opts={'LIBCXX_ENAB
sammccall added inline comments.
Comment at: include-fixer/InMemorySymbolIndex.h:27
- std::vector
+ std::vector
search(llvm::StringRef Identifier) override;
hokein wrote:
> There are many places using
> `std::vector`. Maybe we can use a
> type alias for
sammccall updated this revision to Diff 89484.
sammccall marked 4 inline comments as done.
sammccall added a comment.
Address review comments.
https://reviews.llvm.org/D30210
Files:
include-fixer/InMemorySymbolIndex.cpp
include-fixer/InMemorySymbolIndex.h
include-fixer/IncludeFixer.cpp
rmaprath created this revision.
Herald added a reviewer: EricWF.
The no-exceptions builders are missing the -DLIBCXXABI_ENABLE_EXCEPTIONS=OFF
flag (without this, only the libc++ libraries will be built without exceptions
support, libc++abi will still be built with exceptions support - this is no
Sure! No objections here!
Thanks,
Anastasia
-Original Message-
From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans
Wennborg
Sent: 22 February 2017 18:10
To: Jan Vesely
Cc: cfe-commits; Matt Arsenault; Anastasia Stulova
Subject: Re: r295843 - [OpenCL] r600 needs Ope
Hi there,
2017-02-23 10:37 GMT+01:00 Asiri Rathnayake :
> I have a feeling that the no-exceptions builders are missing a few
> configuration bits.
>
> "No-exceptions" libraries should not require libunwind...
>
> Looking at the cmake configs:
> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-li
NoQ added a comment.
Yay, this is awesome!
It's actually possible to test visitors with the `-analyzer-output=text`
option. This option converts path notes to `note:` diagnostics, which you can
catch with `expected-note{{}}`, see `test/Analysis/inlining/path-notes.c` for
an example (well, it's
Hi Ed,
I have a feeling that the no-exceptions builders are missing a few
configuration bits.
"No-exceptions" libraries should not require libunwind...
Looking at the cmake configs:
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-arm-linux-noexceptions/builds/430/steps/cmake/logs/st
vlad.tsyrklevich created this revision.
Add a bug visitor to the taint checker to make it easy to distinguish where the
tainted value originated. This is especially useful when the original taint
source is obscured by complex data flow.
https://reviews.llvm.org/D30289
Files:
lib/StaticAnaly
Author: ed
Date: Thu Feb 23 03:13:22 2017
New Revision: 295948
URL: http://llvm.org/viewvc/llvm-project?rev=295948&view=rev
Log:
Revert r295944.
Even though the change works perfectly fine on CloudABI, it fails to
work on the libcxx-libcxxabi-libunwind-arm-linux-noexceptions build bot.
Looking at
hokein added inline comments.
Comment at: include-fixer/InMemorySymbolIndex.h:27
- std::vector
+ std::vector
search(llvm::StringRef Identifier) override;
There are many places using
`std::vector`. Maybe we can use a
type alias for it, so that we can type
Author: ed
Date: Thu Feb 23 02:05:58 2017
New Revision: 295944
URL: http://llvm.org/viewvc/llvm-project?rev=295944&view=rev
Log:
Drop the dependency on dl_unwind_find_exidx().
While porting libunwind over to CloudABI for ARMv6, I observed that this
source file doesn't build, as it depends on dl_u
95 matches
Mail list logo
