dblaikie marked 6 inline comments as done.
dblaikie added a comment.
Addressed CR feedback
Comment at: lib/AST/ExternalASTSource.cpp:33
+ExternalASTSource::hasExternalDefinitions(unsigned ID) {
+ return EK_ReplyHazy;
+}
rsmith wrote:
> You should add support f
dblaikie updated this revision to Diff 86200.
dblaikie added a comment.
- Address code review feedback
- Formatting
https://reviews.llvm.org/D28845
Files:
include/clang/AST/ASTContext.h
include/clang/AST/ExternalASTSource.h
include/clang/Basic/LangOptions.def
include/clang/Basic/Module.
Author: rizsotto
Date: Sat Jan 28 22:59:32 2017
New Revision: 293418
URL: http://llvm.org/viewvc/llvm-project?rev=293418&view=rev
Log:
[scan-build-py] remove not used flag
Modified:
cfe/trunk/tools/scan-build-py/libscanbuild/intercept.py
Modified: cfe/trunk/tools/scan-build-py/libscanbuild/i
Author: akirtzidis
Date: Sat Jan 28 22:50:35 2017
New Revision: 293416
URL: http://llvm.org/viewvc/llvm-project?rev=293416&view=rev
Log:
[c-index-test] Provide capability for 'c-index-test core' to dump symbol
information from a PCH/module file.
Added:
cfe/trunk/test/Index/Core/index-pch.c
M
Author: dexonsmith
Date: Sat Jan 28 22:42:21 2017
New Revision: 293415
URL: http://llvm.org/viewvc/llvm-project?rev=293415&view=rev
Log:
Modules: Fix a minor performance bug from r293393
Oops... r293393 started calling ReadSignature in
ModuleManager::addModule even when there was no ExpectedSigna
On 28 Jan 2017 8:16 pm, "Duncan P. N. Exon Smith via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Hi Richard,
This commit makes one of the tests fail in:
https://reviews.llvm.org/D27689
The implicit modules model expects to be able to "upgrade" an implicit PCM
with more -Werror flags *witho
Hi Richard,
This commit makes one of the tests fail in:
https://reviews.llvm.org/D27689
The implicit modules model expects to be able to "upgrade" an implicit PCM with
more -Werror flags *without* affecting the signature. However, with your
commit, the command-line diagnostic flags (e.g., -Wco
dexonsmith updated this revision to Diff 86193.
dexonsmith added a comment.
I've rebased the patch on ToT and cleaned a few things up.
Sadly, the clang/test/Modules/diagnostic-options-out-of-date.m test fails
because r293123 makes the command-line diagnostic options affect the AST, and
thus mak
dexonsmith commandeered this revision.
dexonsmith added a reviewer: manmanren.
dexonsmith added a comment.
Taking this over to rebase.
https://reviews.llvm.org/D27689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: dexonsmith
Date: Sat Jan 28 18:39:09 2017
New Revision: 293404
URL: http://llvm.org/viewvc/llvm-project?rev=293404&view=rev
Log:
Modules: Simplify the ModuleFile constructor; likely NFC
Zero-initialize ModuleFile members directly in the class definition, and
move the (now uninteresting) c
Author: dexonsmith
Date: Sat Jan 28 17:22:40 2017
New Revision: 293400
URL: http://llvm.org/viewvc/llvm-project?rev=293400&view=rev
Log:
Modules: Return early in ModuleManager::addModule; NFC
Invert the main branch in ModuleManager::addModule to return early and
reduce indentation, and clean up a
Author: dexonsmith
Date: Sat Jan 28 17:12:13 2017
New Revision: 293399
URL: http://llvm.org/viewvc/llvm-project?rev=293399&view=rev
Log:
Modules: Clean up ModuleFile::Imports in ModuleManager::removeModules
I don't have a testcase for this (and I'm not sure if it's an observable
bug), but it seem
Author: dexonsmith
Date: Sat Jan 28 17:02:12 2017
New Revision: 293398
URL: http://llvm.org/viewvc/llvm-project?rev=293398&view=rev
Log:
Modules: Enforce that ModuleManager::removeModules deletes the tail
ModuleManager::removeModules always deletes a tail of the
ModuleManager::Chain. Change the
Author: rizsotto
Date: Sat Jan 28 16:55:25 2017
New Revision: 293397
URL: http://llvm.org/viewvc/llvm-project?rev=293397&view=rev
Log:
[scan-build-py] remove batch files
Removed:
cfe/trunk/tools/scan-build-py/bin/analyze-build.bat
cfe/trunk/tools/scan-build-py/bin/analyze-c++.bat
cfe/
Author: rizsotto
Date: Sat Jan 28 16:48:26 2017
New Revision: 293396
URL: http://llvm.org/viewvc/llvm-project?rev=293396&view=rev
Log:
[scan-build-py] use subprocess wrapper
Modified:
cfe/trunk/tools/scan-build-py/libscanbuild/__init__.py
cfe/trunk/tools/scan-build-py/libscanbuild/clang.p
Author: dexonsmith
Date: Sat Jan 28 16:24:01 2017
New Revision: 293395
URL: http://llvm.org/viewvc/llvm-project?rev=293395&view=rev
Log:
Modules: Clarify ownership of ModuleFile instances in ModuleManager, NFC
Use std::unique_ptr to clarify the ownership of the ModuleFile instances in
ModuleManag
Author: dexonsmith
Date: Sat Jan 28 16:15:22 2017
New Revision: 293394
URL: http://llvm.org/viewvc/llvm-project?rev=293394&view=rev
Log:
Modules: Return ModuleFile& from ModuleManager::begin, etc.; NFC
Hide the pointer indirection in ModuleManager::begin, ModuleManager::end,
ModuleManager::rbegin
Author: dexonsmith
Date: Sat Jan 28 15:34:28 2017
New Revision: 293393
URL: http://llvm.org/viewvc/llvm-project?rev=293393&view=rev
Log:
Modules: Separate out a checkSignature helper, almost NFC
The main point is to move the delete-the-new-module logic into the same block
that creates it, so I ca
nlopes added a comment.
Let me give just 2 more Z3-related suggestions:
- instead of re-creating the solver, it might be faster to do Z3_solver_reset
- "once in a while" it might be helpful to delete everything (all solvers,
asts, context) and call Z3_reset_memory. Z3's small object pool is not
Prazek added a comment.
I have read the patch, but I don't have enough knowledge about C++ rules and
fronted to accept it. Richard?
Comment at: lib/Sema/Sema.cpp:684
+ for (auto PII : Pending)
+if (FunctionDecl *Func = dyn_cast(PII.first))
+ Func->setMar
Author: sylvestre
Date: Sat Jan 28 07:41:50 2017
New Revision: 293381
URL: http://llvm.org/viewvc/llvm-project?rev=293381&view=rev
Log:
Remove unused 'using' declaration. Found by clang-tidy: misc-unused-using-decls
NFC
Modified:
cfe/trunk/lib/Analysis/OSLog.cpp
Modified: cfe/trunk/lib/Anal
Author: sylvestre
Date: Sat Jan 28 07:36:34 2017
New Revision: 293379
URL: http://llvm.org/viewvc/llvm-project?rev=293379&view=rev
Log:
Pass a char instead of a string to the find function. clang-tidy:
performance-faster-string-find
Modified:
cfe/trunk/lib/Frontend/Rewrite/RewriteModernObjC.
22 matches
Mail list logo
