Author: rsmith
Date: Tue Dec 27 00:18:22 2016
New Revision: 290587
URL: http://llvm.org/viewvc/llvm-project?rev=290587&view=rev
Log:
Add reference/non-reference mismatch test.
Modified:
cfe/trunk/test/SemaTemplate/temp_arg_nontype.cpp
Modified: cfe/trunk/test/SemaTemplate/temp_arg_nontype.cp
Author: rsmith
Date: Tue Dec 27 00:14:37 2016
New Revision: 290586
URL: http://llvm.org/viewvc/llvm-project?rev=290586&view=rev
Log:
Work around a standard defect: template argument deduction for non-type
template parameters of reference type basically doesn't work, because we're
always deducing f
r290584 :)
On Mon, Dec 26, 2016 at 8:30 PM, George Burgess IV <
george.burgess...@gmail.com> wrote:
> SG; working on a follow-up now. Thanks!
>
> On Mon, Dec 26, 2016 at 8:26 PM, Richard Smith
> wrote:
>
>> On 26 December 2016 at 20:01, George Burgess IV via cfe-commits <
>> cfe-commits@lists.ll
Author: gbiv
Date: Mon Dec 26 23:33:20 2016
New Revision: 290584
URL: http://llvm.org/viewvc/llvm-project?rev=290584&view=rev
Log:
Emit CCEDiags when evaluating a const variable.
This addresses post-review feedback from r290577.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/test
SG; working on a follow-up now. Thanks!
On Mon, Dec 26, 2016 at 8:26 PM, Richard Smith
wrote:
> On 26 December 2016 at 20:01, George Burgess IV via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: gbiv
>> Date: Mon Dec 26 22:01:22 2016
>> New Revision: 290577
>>
>> URL: http://llv
On 26 December 2016 at 20:01, George Burgess IV via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: gbiv
> Date: Mon Dec 26 22:01:22 2016
> New Revision: 290577
>
> URL: http://llvm.org/viewvc/llvm-project?rev=290577&view=rev
> Log:
> Add a test for `const` folding introduced by r290297
Author: ctopper
Date: Mon Dec 26 22:04:57 2016
New Revision: 290580
URL: http://llvm.org/viewvc/llvm-project?rev=290580&view=rev
Log:
[AVX-512] Replace masked 512-bit pmuldq and pmuludq builtins with the newly
added unmasked versions and selects.
Modified:
cfe/trunk/include/clang/Basic/Built
Author: ctopper
Date: Mon Dec 26 22:03:25 2016
New Revision: 290578
URL: http://llvm.org/viewvc/llvm-project?rev=290578&view=rev
Log:
Revert r290575 "[AVX-512] Replace masked 512-bit pmuldq and pmuludq builtins
with the newly added unmasked versions and selects."
I failed to merge this with r290
Author: ctopper
Date: Mon Dec 26 22:03:29 2016
New Revision: 290579
URL: http://llvm.org/viewvc/llvm-project?rev=290579&view=rev
Log:
Revert r290574 "foo"
This was supposed to be merged with another commit with a real commit message.
Sorry.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX8
Author: gbiv
Date: Mon Dec 26 22:01:22 2016
New Revision: 290577
URL: http://llvm.org/viewvc/llvm-project?rev=290577&view=rev
Log:
Add a test for `const` folding introduced by r290297. NFC.
AFAICT, we didn't add a test targeted at the new "const can sometimes
act as constexpr" behavior introduced
Author: rsmith
Date: Mon Dec 26 21:59:58 2016
New Revision: 290576
URL: http://llvm.org/viewvc/llvm-project?rev=290576&view=rev
Log:
Factor out repeated code for deducing a non-type template parameter as a given
argument value. No functionality change intended.
Modified:
cfe/trunk/lib/Sema/Se
Oops. I failed to squash this into another commit properly. Reverting
momentarily.
~Craig
On Mon, Dec 26, 2016 at 7:46 PM, Craig Topper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ctopper
> Date: Mon Dec 26 21:46:13 2016
> New Revision: 290574
>
> URL: http://llvm.org/viewvc/l
Author: ctopper
Date: Mon Dec 26 21:46:16 2016
New Revision: 290575
URL: http://llvm.org/viewvc/llvm-project?rev=290575&view=rev
Log:
[AVX-512] Replace masked 512-bit pmuldq and pmuludq builtins with the newly
added unmasked versions and selects.
Modified:
cfe/trunk/lib/Headers/avx512fintrin
Author: ctopper
Date: Mon Dec 26 21:46:13 2016
New Revision: 290574
URL: http://llvm.org/viewvc/llvm-project?rev=290574&view=rev
Log:
foo
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cfe/trunk/lib/Headers/avx512fintrin.h
Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def
On Mon, Dec 26, 2016 at 6:22 PM, Vitaly Buka wrote:
> This fails here http://lab.llvm.org:8011/builders/sanitizer-windows/
> builds/3537/steps/run%20tests/logs/stdio
>
Thanks for letting me know. Should be addressed in SVN r290571.
>
> On Sun, Dec 25, 2016 at 7:45 PM Saleem Abdulrasool via cf
vitalybuka added a comment.
These patches break asan tests:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/528/steps/check-asan%20in%20gcc%20build/logs/stdio
Repository:
rL LLVM
https://reviews.llvm.org/D15075
___
cfe-commits ma
Author: compnerd
Date: Mon Dec 26 20:20:35 2016
New Revision: 290569
URL: http://llvm.org/viewvc/llvm-project?rev=290569&view=rev
Log:
Driver: switch Windows to static RelocModel
Windows uses PE/COFF which is inherently position independent. The use
of the PIC model is unnecessary. In fact, we
This fails here
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/3537/steps/run%20tests/logs/stdio
On Sun, Dec 25, 2016 at 7:45 PM Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Sun Dec 25 21:35:24 2016
> New Revision: 290533
>
> URL:
Author: rsmith
Date: Mon Dec 26 20:02:09 2016
New Revision: 290567
URL: http://llvm.org/viewvc/llvm-project?rev=290567&view=rev
Log:
Check and build conversion sequences for non-type template arguments in
dependent contexts when processing the template in C++11 and C++14, just like
we do in C++98
Author: kromanova
Date: Mon Dec 26 18:49:38 2016
New Revision: 290561
URL: http://llvm.org/viewvc/llvm-project?rev=290561&view=rev
Log:
[DOXYGEN] Improved doxygen comments for x86 intrinsics.
Improved doxygen comments for the following intrinsics headers:
__wmmintrin_pclmul.h, bmiintrin.h, emmi
Author: chandlerc
Date: Mon Dec 26 18:31:34 2016
New Revision: 290560
URL: http://llvm.org/viewvc/llvm-project?rev=290560&view=rev
Log:
[PM] The new pass manager requires a registered target for these, and
given that they hard code specific triples that seems reasonable so add
the REQUIRES.
Modif
Author: chandlerc
Date: Mon Dec 26 18:13:09 2016
New Revision: 290558
URL: http://llvm.org/viewvc/llvm-project?rev=290558&view=rev
Log:
[PH] Teach the new PM code path to support -disable-llvm-passes.
This is kind of funny because I specifically did work to make this easy
and then it didn't actua
madsravn updated this revision to Diff 82521.
madsravn added a comment.
Changes based on comments.
Shortened the ast matcher.
https://reviews.llvm.org/D27210
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringCompareCheck.cpp
clang-tidy/misc/
malcolm.parsons added inline comments.
Comment at: clang-tidy/misc/StringCompareCheck.cpp:37
+ hasArgument(0, expr().bind("str2")), argumentCountIs(1),
+ callee(memberExpr(has(implicitCastExpr(anyOf(
+
has(callExpr(has(implicitCastExpr(has(declRefExpr().bi
madsravn added inline comments.
Comment at: clang-tidy/misc/StringCompareCheck.cpp:37
+ hasArgument(0, expr().bind("str2")), argumentCountIs(1),
+ callee(memberExpr(has(implicitCastExpr(anyOf(
+
has(callExpr(has(implicitCastExpr(has(declRefExpr().bind("str
Author: rsmith
Date: Mon Dec 26 16:28:29 2016
New Revision: 290552
URL: http://llvm.org/viewvc/llvm-project?rev=290552&view=rev
Log:
Update comment to match dr1770.
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp
URL:
http://llvm.org/viewvc/llvm-p
malcolm.parsons added inline comments.
Comment at: clang-tidy/misc/StringCompareCheck.cpp:25
+"operator instead";
+static const StringRef GuaranteeMessage = "'compare' is not guaranteed to "
+ "retur
madsravn updated this revision to Diff 82518.
madsravn added a comment.
Reviews based on comments. Removed check for suspicious string compare.
https://reviews.llvm.org/D27210
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringCompareCheck.cpp
malcolm.parsons added a reviewer: malcolm.parsons.
malcolm.parsons added inline comments.
Comment at: clang-tidy/misc/StringCompareCheck.cpp:25
+"operator instead";
+static const StringRef GuaranteeMessage = "'compare' is not guaranteed to
Quuxplusone added a comment.
PVS-Studio implements tons of checks of this variety. See e.g.
http://www.viva64.com/en/b/0299/#ID0E4KBM
They don't have a catchy name for the category either, but perhaps
"suspicious-" or "copypaste-" would do.
I agree with Aaron that "thinko-" would be a little ina
Quuxplusone added inline comments.
Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:62
+ auto CallsAlgorithm = hasDeclaration(
+ functionDecl(Names.size() > 0 ? hasAnyName(Names) : anything()));
+
Prazek wrote:
> alexfh wrote:
> > Does this check make
Hi,
The last mail was only meant to contain the question about the comment to
misc-suspicious-string-compare check.
Do you reckon I should remove that match from my check? Or should we move
it?
Best regards,
Mads Ravn
On Mon, Dec 26, 2016 at 8:48 PM Mads Ravn via Phabricator <
revi...@reviews.l
madsravn marked 2 inline comments as done.
madsravn added inline comments.
Comment at: clang-tidy/misc/MiscStringCompareCheck.h:24
+///
http://clang.llvm.org/extra/clang-tidy/checks/misc-string-compare-check.html
+class MiscStringCompareCheck : public ClangTidyCheck {
+public:
-
malcolm.parsons added inline comments.
Comment at: clang-tidy/misc/StringCompareCheck.cpp:25
+"operator instead";
+static const StringRef GuaranteeMessage = "'compare' is not guaranteed to "
+ "retur
madsravn updated this revision to Diff 82513.
madsravn added a comment.
Updated according to comments.
I have decided to keep the fixit for match1 a FIXME.
https://reviews.llvm.org/D27210
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringCompa
Author: rksimon
Date: Mon Dec 26 12:11:49 2016
New Revision: 290547
URL: http://llvm.org/viewvc/llvm-project?rev=290547&view=rev
Log:
Wdocumentation fix
Modified:
cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp
Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp
URL:
http://llvm.org/viewvc/
Author: myatsina
Date: Mon Dec 26 07:16:40 2016
New Revision: 290541
URL: http://llvm.org/viewvc/llvm-project?rev=290541&view=rev
Log:
Fix build error caused by r290539.
Modified:
cfe/trunk/lib/Sema/SemaStmtAsm.cpp
Modified: cfe/trunk/lib/Sema/SemaStmtAsm.cpp
URL:
http://llvm.org/viewvc/ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290539: [inline-asm]No error for conflict between
inputs\outputs and clobber list (authored by myatsina).
Changed prior to commit:
https://reviews.llvm.org/D15075?vs=74500&id=82495#toc
Repository:
rL
Author: myatsina
Date: Mon Dec 26 06:23:42 2016
New Revision: 290539
URL: http://llvm.org/viewvc/llvm-project?rev=290539&view=rev
Log:
[inline-asm]No error for conflict between inputs\outputs and clobber list
According to extended asm syntax, a case where the clobber list includes a
variable fro
39 matches
Mail list logo
