mclow.lists added a comment.
> I think it might be better to add TEST_TRY and TEST_CATCH(...) macros
> defined like
@rogfer01 said at the top that he didn't want to add "a magical TEST_TRY macro"
- and I agree. Someone tried that in another review, and I nixed it there.
https://reviews.llv
djasper added a comment.
In case you still want to move forward with this, some more comments.
Why have you opted for doing this in getNewLineColumn instead of the
UnwrappedLineFormatter::formatFirstToken() function I suggested? I think the
latter would be way easier, but there might be cases I
ioeric updated this revision to Diff 76975.
ioeric added a comment.
- addressed comments.
https://reviews.llvm.org/D26288
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/
klimek added a comment.
Ok, makes sense. Can you add a comment to the function that explains what
happens with replacements for files that do not exist (we ignore them, unless
I'm mistaken). Otherwise LG.
https://reviews.llvm.org/D26288
___
cfe-co
malcolm.parsons updated this revision to Diff 76971.
malcolm.parsons added a comment.
Check for non-public deleted methods.
Remove imperfect FixItHint.
Add FIXME comments.
https://reviews.llvm.org/D26138
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
ioeric added a comment.
In https://reviews.llvm.org/D26288#587513, @klimek wrote:
> In https://reviews.llvm.org/D26288#586932, @ioeric wrote:
>
> > - Addressed comments: handle non-existing files.
>
>
> We're not really handling them now though? We're just printing an error?
>
> My point is that
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm. I've made a note to clean this up.
Repository:
rL LLVM
https://reviews.llvm.org/D26317
___
cfe-commits mailing list
cfe-commits@lists.
klimek added a comment.
In https://reviews.llvm.org/D26288#586932, @ioeric wrote:
> - Addressed comments: handle non-existing files.
We're not really handling them now though? We're just printing an error?
My point is that we might run the replacement generation on a distributed
system, and t
Author: djasper
Date: Sat Nov 5 12:43:16 2016
New Revision: 286041
URL: http://llvm.org/viewvc/llvm-project?rev=286041&view=rev
Log:
clang-format: Better support for CUDA's triple brackets.
Before:
aaa<
a, aa,
aa><<>>();
After:
aaa
+richard
On Fri, Oct 14, 2016 at 10:18 AM Joshua Hurwitz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> See attached.
>
> Returning a bool from main is a special case of return type mismatch. The
> common convention when returning a bool is that 'true' (== 1) indicates
> success and 'fals
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D26311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
zaks.anna added a comment.
Thanks for fixing this!
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:39
+if (IncludeExperimental ||
+(!CheckName.startswith("debug.") && !CheckName.startswith("alpha.")))
+ Result.push_back(CheckName);
Debu
Anastasia added a comment.
LGTM! Thanks! Do you know the runtime of this test now?
https://reviews.llvm.org/D26302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons planned changes to this revision.
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:58
+ << FixItHint::CreateInsertion(StartLoc, "public: ")
+ << FixItHint::CreateInsertion(AfterLoc, " private:");
+}
---
zvi added inline comments.
Comment at: lib/Basic/Targets.cpp:3353
setSSELevel(Features, AVX512F, Enabled);
+// Enable BWI instruction is VBMI is being enabled.
+if (Name == "avx512vbmi" && Enabled)
is -> if
Comment at: test/Prepr
jtony updated this revision to Diff 76945.
jtony added a comment.
Reorder the overloads according to their size.
https://reviews.llvm.org/D26282
Files:
lib/Headers/altivec.h
test/CodeGen/builtins-ppc-altivec.c
test/CodeGen/builtins-ppc-quadword.c
test/CodeGen/builtins-ppc-vsx.c
Index:
zvi accepted this revision.
zvi added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
I created a fix as described above. Could you please tell me if it works for
you?
It can be found here:
https://reviews.llvm.org/D26324
https://reviews.llvm.org/D25897
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
18 matches
Mail list logo
