r285985 - Add some more asserts to clearly indicate that there are special cases

Author: chandlerc Date: Fri Nov 4 01:32:57 2016 New Revision: 285985 URL: http://llvm.org/viewvc/llvm-project?rev=285985&view=rev Log: Add some more asserts to clearly indicate that there are special cases which guarantee pointers are not null. These all seem to have useful properties and correla

[PATCH] D26285: [index] Expose FriendDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL285984: [index] Expose FriendDecl (authored by ogoffart). Changed prior to commit: https://reviews.llvm.org/D26285?vs=76873&id=76913#toc Repository: rL LLVM https://reviews.llvm.org/D26285 Files:

r285984 - [index] Expose FriendDecl

Author: ogoffart Date: Fri Nov 4 01:29:27 2016 New Revision: 285984 URL: http://llvm.org/viewvc/llvm-project?rev=285984&view=rev Log: [index] Expose FriendDecl Differential Revision: https://reviews.llvm.org/D26285 Modified: cfe/trunk/include/clang-c/Index.h cfe/trunk/lib/Sema/SemaCodeC

r285983 - Delete a trivially true check for a variable 'S' being null.

Author: chandlerc Date: Fri Nov 4 01:16:09 2016 New Revision: 285983 URL: http://llvm.org/viewvc/llvm-project?rev=285983&view=rev Log: Delete a trivially true check for a variable 'S' being null. The exact same test guards entry into the loop in which this test occurs, and there is nothing insid

r285982 - Add an assert to further check the invariant that a null pointer

Author: chandlerc Date: Fri Nov 4 01:11:54 2016 New Revision: 285982 URL: http://llvm.org/viewvc/llvm-project?rev=285982&view=rev Log: Add an assert to further check the invariant that a null pointer corresponds to another argument being valid. This makes it clear that the code is correct despit

r285981 - Enhancement to test for -ast-print

Author: sepavloff Date: Fri Nov 4 01:09:23 2016 New Revision: 285981 URL: http://llvm.org/viewvc/llvm-project?rev=285981&view=rev Log: Enhancement to test for -ast-print Present tests for the functionality provided by command lime option `-ast-print` check only absence of crash. This change trie

r285980 - Remove no-op checks for a null CodeCompleter. We have already

Author: chandlerc Date: Fri Nov 4 01:06:50 2016 New Revision: 285980 URL: http://llvm.org/viewvc/llvm-project?rev=285980&view=rev Log: Remove no-op checks for a null CodeCompleter. We have already dereferenced the pointer at this point, and these routines are exclusively called after the parser e

r285979 - Do not print enum underlying type if language is not C++11

Author: sepavloff Date: Fri Nov 4 01:03:34 2016 New Revision: 285979 URL: http://llvm.org/viewvc/llvm-project?rev=285979&view=rev Log: Do not print enum underlying type if language is not C++11 Output generated by option '-ast-print' must not contains enum base type specifications if source lang

[PATCH] D26196: AMDGPU: Translate null pointers in private and local addr space

arsenm added a comment. In https://reviews.llvm.org/D26196#586433, @rjmccall wrote: > I think there are a number of conceptual questions here, chiefly among them > whether an llvm::ConstantPointerNull in an address-space type should have the > correct representation for the target. If the deci

[PATCH] D26287: clang-format: Use git-ls-tree to get file mode in diff mode

lodato accepted this revision. lodato added a comment. This revision is now accepted and ready to land. Thanks for the fix! https://reviews.llvm.org/D26287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. Thanks Richard for reviewing the patch and for the comments. Please, see answers below. Regards, Amjad Comment at: include/clang/AST/ASTConsumer.h:163 + /// The caller takes ownership on the returned pointer. + virtual std::unique_ptr CreatePreproces

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

mehdi_amini added a comment. (Quick stylistic comments) Comment at: include/clang/Analysis/CloneDetection.h:224 - /// \brief Searches the provided statements for clones. + /// \brief Represents a way to filter clones from a list of clone groups. /// Use

[PATCH] D16135: Macro Debug Info support in Clang

rsmith added inline comments. Comment at: include/clang/AST/ASTConsumer.h:163 + /// The caller takes ownership on the returned pointer. + virtual std::unique_ptr CreatePreprocessorCallbacks(Preprocessor &PP); }; aaboud wrote: > Richard, > I know that you sugg

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

v.g.vassilev added a comment. Could you include more context when creating the diff eg. git diff -U, or equivalent. Comment at: include/clang/Lex/ModuleMap.h:278 + /// headers. + static bool isBuiltinHeader(StringRef FileName); + It seems this is in the

r285971 - Remove the unused POLLY_LINK_LIBS for linking polly into clang

Author: ether Date: Thu Nov 3 17:02:40 2016 New Revision: 285971 URL: http://llvm.org/viewvc/llvm-project?rev=285971&view=rev Log: Remove the unused POLLY_LINK_LIBS for linking polly into clang Modified: cfe/trunk/tools/driver/CMakeLists.txt Modified: cfe/trunk/tools/driver/CMakeLists.txt U

Re: r276934 - [OpenMP] Add support to map member expressions with references to pointers.

Hi Richard,   The tests in each section of the file use slightly different code, so it is not like the same code is generated multiple times. In each section the same code is compiled 4 times with different configurations Regular/Precompiled Header and 64/32.   If I compile the code in a single go,

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

ioeric added a comment. In https://reviews.llvm.org/D26288#586902, @klimek wrote: > If the files do not exist, how does this work? Won't that potentially give > different results if the files exist locally vs if they don't? This would be problematic. Thanks for the catch! https://reviews.llv

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

ioeric updated this revision to Diff 76894. ioeric added a comment. - Addressed comments: handle non-existing files. https://reviews.llvm.org/D26288 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp lib/Tooling/Refactoring.cpp unittests/Tooling/Refactoring

Re: r276934 - [OpenMP] Add support to map member expressions with references to pointers.

On Wed, Jul 27, 2016 at 3:52 PM, Samuel Antao via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sfantao > Date: Wed Jul 27 17:52:16 2016 > New Revision: 276934 > > URL: http://llvm.org/viewvc/llvm-project?rev=276934&view=rev > Log: > [OpenMP] Add support to map member expressions with

Re: r273191 - [OpenCL] Include opencl-c.h by default as a clang module

Hi, This test (test/Headers/opencl-c-header.cl) is *extremely* slow -- it parses the 17KLoC opencl-c.h header 40 times, and on my Debug builds it's the slowest test by far, taking nearly 2 minutes to run *alone*. (For reference, the *entire clang test suite* finishes in 90s on my machine with this

[PATCH] D25311: Add FixItHint for missing #include (err_module_unimported_use_header)

rsmith added a comment. In https://reviews.llvm.org/D25311#576382, @bkramer wrote: > I think clang already depends on libclangRewrite. libclangToolingCore is > tiny, it's basically just the Replacement class and a couple of utilities. > While it would be possible to hoist just the include handl

[PATCH] D26285: [index] Expose FriendDecl

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

klimek added a comment. If the files do not exist, how does this work? Won't that potentially give different results if the files exist locally vs if they don't? https://reviews.llvm.org/D26288 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

ioeric added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:578 + continue; +ProcessedFileEntries.insert(FE); +Result[Entry.first] = std::move(Entry.second); alexshap wrote: > (saves 2 lines of code) (although not particularly importan

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

ioeric updated this revision to Diff 76888. ioeric added a comment. - Kill a few lines. https://reviews.llvm.org/D26288 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp lib/Tooling/Refactoring.cpp unittests/Tooling/RefactoringTest.cpp Index: unittests/To

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

alexshap added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:578 + continue; +ProcessedFileEntries.insert(FE); +Result[Entry.first] = std::move(Entry.second); (saves 2 lines of code) (although not particularly important) if (Proces

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

ahatanak updated this revision to Diff 76883. ahatanak added a comment. Rebase. Pass the destructor's DeclarationNameInfo to the call to RebuildMemberExpr rather than getting it inside RebuildMemberExpr. https://reviews.llvm.org/D24969 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp lib/Se

[PATCH] D26157: [OpenCL] always use SPIR address spaces for kernel_arg_addr_space MD

pekka.jaaskelainen added a comment. Indeed, it requires wider scale discussion to get it right, and e.g. to pass the info to AA. But to be honest, I think OpenCL and CUDA are still considered 'minority' languages in Clang/LLVM which makes me usually lean towards least intrusive implementation s

r285960 - Add debug info support for C++11 inline namespaces.

Author: adrian Date: Thu Nov 3 14:42:14 2016 New Revision: 285960 URL: http://llvm.org/viewvc/llvm-project?rev=285960&view=rev Log: Add debug info support for C++11 inline namespaces. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp Mo

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

ioeric created this revision. ioeric added a reviewer: djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. The current version does not deduplicate equivalent file paths correctly. For example, a relative path and an absolute path are considered inequivalent. Compar

[PATCH] D26286: [Sparc]: correct the ATOMIC_LLONG_LOCK_FREE macro

dougk updated this revision to Diff 76879. dougk added a comment. fix atomics-inlining test https://reviews.llvm.org/D26286 Files: lib/Basic/Targets.cpp test/CodeGen/atomics-inlining.c test/Preprocessor/init.c Index: test/Preprocessor/init.c =

[PATCH] D26207: [ClangTidy - performance-unnecessary-value-param] Only add "const" when current parameter is not already const qualified

flx removed rL LLVM as the repository for this revision. flx updated this revision to Diff 76877. https://reviews.llvm.org/D26207 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp test/clang-tidy/performance-unnecessary-value-param.cpp Index: test/clang-tidy/performance-unnecessa

[PATCH] D26207: [ClangTidy - performance-unnecessary-value-param] Only add "const" when current parameter is not already const qualified

flx marked an inline comment as done. flx added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:242 +// Case where parameter in declaration is already const-qualified but not in +// implementation. Make sure a second 'const' is not added to th

r285954 - Improve obvious-most-derived-type devirtualization:

Author: rsmith Date: Thu Nov 3 13:55:18 2016 New Revision: 285954 URL: http://llvm.org/viewvc/llvm-project?rev=285954&view=rev Log: Improve obvious-most-derived-type devirtualization: * if the base is produced by a series of derived-to-base conversions, check the expression inside them whe

Re: RE: RE: r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

This issue should be fixed in r285925.   Thanks, Samuel   - Original message -From: "Hahnfeld, Jonas" To: "Hahnfeld, Jonas" , Samuel F Antao/Watson/IBM@IBMUSCc: "cfe-commits@lists.llvm.org" Subject: RE: RE: r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.Date: T

[PATCH] D23657: Remove some false positives when taking the address of packed members

joerg added a comment. It works for me with the mentioned TODO item. But I'm not the right one to give a full OK. https://reviews.llvm.org/D23657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

r285950 - Instead of resetting the pointer, or releasing it which was the previous

Author: chandlerc Date: Thu Nov 3 13:03:14 2016 New Revision: 285950 URL: http://llvm.org/viewvc/llvm-project?rev=285950&view=rev Log: Instead of resetting the pointer, or releasing it which was the previous code, let's just assert that the DiagonsticEngine doesn't own the client because our cons

[PATCH] D26286: [Sparc]: correct the ATOMIC_LLONG_LOCK_FREE macro

dougk created this revision. dougk added a reviewer: jyknight. dougk added a subscriber: cfe-commits. https://reviews.llvm.org/D26286 Files: lib/Basic/Targets.cpp test/Preprocessor/init.c Index: test/Preprocessor/init.c === ---

r285946 - Using release to free memory is at best confusing -- one would expect

Author: chandlerc Date: Thu Nov 3 12:42:32 2016 New Revision: 285946 URL: http://llvm.org/viewvc/llvm-project?rev=285946&view=rev Log: Using release to free memory is at best confusing -- one would expect that its result is in fact used. Instead, use reset. This was pointed out by PVS-Studio. M

[PATCH] D23657: Remove some false positives when taking the address of packed members

rogfer01 added a comment. Ping? :) https://reviews.llvm.org/D23657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26157: [OpenCL] always use SPIR address spaces for kernel_arg_addr_space MD

Anastasia added a comment. I am wondering whether returning the strings with source level information would be an option instead? But yes this MD are OpenCL specific indeed. I am just not sure whether putting hard-coded arbitrary numbers would not cause any confusions in the future. I feel that

[PATCH] D26285: [index] Expose FriendDecl

ogoffart created this revision. ogoffart added reviewers: cfe-commits, alexey.klimov.dev, bkramer. I need to be able to visit friend declarations (the function) for the clang based qdoc (documentation parser). This also fix KDevelop not highlighting friend declarations. (Espetialy ennoying when

[PATCH] D26285: [index] Expose FriendDecl

ogoffart added a comment. KDevelop bug report: https://bugs.kde.org/show_bug.cgi?id=360509 https://reviews.llvm.org/D26285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26157: [OpenCL] always use SPIR address spaces for kernel_arg_addr_space MD

yaxunl added a comment. The enum for address space is not necessarily bound to SPIR as long as the runtime knows it. Since most OpenCL runtime already uses that definition (if they use clang as compiler), I don't see a reason to change that. I doubt this metadata can be used for anything else

Re: [PATCH] D26166: [Sema] Don't issue analysis-based warnings when a fatal error has occurred

Thanks, fixed in r285938. > On Nov 3, 2016, at 8:27 AM, Malcolm Parsons via cfe-commits > wrote: > > malcolm.parsons added inline comments. > > > > Comment at: cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp:213 > + // Don't allow further instantiation if a fatal error and an

r285938 - Fix spelling mistake.

Author: ahatanak Date: Thu Nov 3 12:11:28 2016 New Revision: 285938 URL: http://llvm.org/viewvc/llvm-project?rev=285938&view=rev Log: Fix spelling mistake. Modified: cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp Modified: cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp URL: http://llvm.org

[PATCH] D26157: [OpenCL] always use SPIR address spaces for kernel_arg_addr_space MD

Anastasia added a comment. In https://reviews.llvm.org/D26157#586764, @yaxunl wrote: > One purpose of kernel arg info metadata is to be passed to OpenCL runtime to > fulfill clGetKernelArgInfo queries. > (https://www.khronos.org/registry/cl/sdk/1.2/docs/man/xhtml/clGetKernelArgInfo.html). > As

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

This revision was automatically updated to reflect the committed changes. Closed by commit rL285934: Fixed column shift when formatting line containing bit shift operators (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D25439?vs=75635&id=76869#toc Repository:

r285934 - Fixed column shift when formatting line containing bit shift operators

Author: malcolm.parsons Date: Thu Nov 3 11:57:30 2016 New Revision: 285934 URL: http://llvm.org/viewvc/llvm-project?rev=285934&view=rev Log: Fixed column shift when formatting line containing bit shift operators Summary: During clang-format source lexing >> and << operators are split and treated

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode added a comment. No, not yet - I was about to ask someone to commit this for me :) https://reviews.llvm.org/D25439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26157: [OpenCL] always use SPIR address spaces for kernel_arg_addr_space MD

yaxunl added a comment. One purpose of kernel arg info metadata is to be passed to OpenCL runtime to fulfill clGetKernelArgInfo queries. (https://www.khronos.org/registry/cl/sdk/1.2/docs/man/xhtml/clGetKernelArgInfo.html). As such, the address space id needs to be at source level instead of IR

[PATCH] D26196: AMDGPU: Translate null pointers in private and local addr space

tstellarAMD added a comment. In https://reviews.llvm.org/D26196#586723, @Anastasia wrote: > My understanding of NULL constant in IR was that it doesn't assume any > specific integer value (i.e. 0). And currently as I can see it is lowered > very late in LLVM backend during the code selection p

[PATCH] D26160: [PowerPC] Implement remaining vector comparison builtins

jtony updated this revision to Diff 76862. jtony marked 2 inline comments as done. jtony added a comment. Fix a few format and layout issues. Format: clang-format is not always correct, sometimes separate parameters in different lines is better. Layout: put the overloaded builtin functions in s

[PATCH] D26282: [PowerPC] Implement plain VSX load/store builtins.

jtony created this revision. jtony added reviewers: nemanjai, amehsan, kbarton, sfertile, syzaara, lei. jtony added subscribers: llvm-commits, cfe-commits, echristo. Implement all the different 24 overloads for vec_xl and vec_xst. Signatures: vector signed char vec_xl (signed long long, signed ch

r285925 - Rename the version of ConstructJob for multiple outputs to ConstructJobMultipleOutputs.

Author: sfantao Date: Thu Nov 3 10:41:50 2016 New Revision: 285925 URL: http://llvm.org/viewvc/llvm-project?rev=285925&view=rev Log: Rename the version of ConstructJob for multiple outputs to ConstructJobMultipleOutputs. It was causing trouble with the GCC bots. Modified: cfe/trunk/include

[PATCH] D26157: [OpenCL] always use SPIR address spaces for kernel_arg_addr_space MD

Anastasia added a comment. > Is there nowadays such a thing as "standard OpenCL logical AS IDs" which > could be retained down to code gen? I must say I haven't checked the current > situation here. It used to be that the logical ids are assumed to be > converted to the target ones already in C

[PATCH] D26166: [Sema] Don't issue analysis-based warnings when a fatal error has occurred

malcolm.parsons added inline comments. Comment at: cfe/trunk/lib/Sema/SemaTemplateInstantiate.cpp:213 + // Don't allow further instantiation if a fatal error and an uncompilable + // error have occcured. Any diagnostics we might have raised will not be + // visible, and we do

r285923 - [Sema] Avoid instantiating templates only when UncompilableErrorOccurred

Author: ahatanak Date: Thu Nov 3 10:04:58 2016 New Revision: 285923 URL: http://llvm.org/viewvc/llvm-project?rev=285923&view=rev Log: [Sema] Avoid instantiating templates only when UncompilableErrorOccurred and FatalErrorOccurred are both set. This fixes a crash that occurs when a warning promot

[PATCH] D26166: [Sema] Don't issue analysis-based warnings when a fatal error has occurred

This revision was automatically updated to reflect the committed changes. Closed by commit rL285923: [Sema] Avoid instantiating templates only when UncompilableErrorOccurred (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D26166?vs=76521&id=76863#toc Repository: rL

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

xazax.hun updated this revision to Diff 76860. xazax.hun marked 5 inline comments as done. xazax.hun added a comment. - Addressed review comments. https://reviews.llvm.org/D24894 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/U

[PATCH] D24933: Enable configuration files in clang

hans added a comment. Apologies for seeming so negative here. I can see that this would possibly be beneficial for some users. This would be a powerful feature, which is what worries me. Here's a specific scenario I'm worried about. For Chromium, our build system provides a specific Clang vers

[PATCH] D26196: AMDGPU: Translate null pointers in private and local addr space

Anastasia added a comment. My understanding of NULL constant in IR was that it doesn't assume any specific integer value (i.e. 0). And currently as I can see it is lowered very late in LLVM backend during the code selection phase. Looking at the lowering code in LLVM, it seems like it shouldn'

r285909 - Support for Python 3 in libclang python bindings

Author: jbcoe Date: Thu Nov 3 08:55:34 2016 New Revision: 285909 URL: http://llvm.org/viewvc/llvm-project?rev=285909&view=rev Log: Support for Python 3 in libclang python bindings Summary: Python bindings tests now pass in Python 3. `map` in Python 3 is lazily evaluated so the method by which f

[PATCH] D26082: Support for Python 3 in libclang python bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rL285909: Support for Python 3 in libclang python bindings (authored by jbcoe). Changed prior to commit: https://reviews.llvm.org/D26082?vs=76774&id=76854#toc Repository: rL LLVM https://reviews.llvm.

[clang-tools-extra] r285907 - [clang-tidy] Ignore forward declarations without definitions in the same translation unit in readability-identifier-naming

Author: jbcoe Date: Thu Nov 3 08:52:09 2016 New Revision: 285907 URL: http://llvm.org/viewvc/llvm-project?rev=285907&view=rev Log: [clang-tidy] Ignore forward declarations without definitions in the same translation unit in readability-identifier-naming Summary: This change ensures that forward

[PATCH] D26207: [ClangTidy - performance-unnecessary-value-param] Only add "const" when current parameter is not already const qualified

aaron.ballman added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:242 +// Case where parameter in declaration is already const-qualified but not in +// implementation. Make sure a second 'const' is not added to the declaration. +void Positiv

[PATCH] D26279: [clang-tidy] Handle data() in readability-redundant-string-cstr

This revision was automatically updated to reflect the committed changes. Closed by commit rL285901: [clang-tidy] Handle data() in readability-redundant-string-cstr (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D26279?vs=76848&id=76851#toc Repository: rL LL

[clang-tools-extra] r285901 - [clang-tidy] Handle data() in readability-redundant-string-cstr

Author: malcolm.parsons Date: Thu Nov 3 07:56:48 2016 New Revision: 285901 URL: http://llvm.org/viewvc/llvm-project?rev=285901&view=rev Log: [clang-tidy] Handle data() in readability-redundant-string-cstr Summary: std::string::data() and std::string::c_str() are equivalent. Enhance the readabili

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha updated this revision to Diff 76850. Alpha added a comment. Remove debug symbols. Repository: rL LLVM https://reviews.llvm.org/D26137 Files: include/clang/Tooling/Core/Diagnostic.h include/clang/Tooling/DiagnosticsYaml.h lib/Tooling/Core/CMakeLists.txt lib/Tooling/Core/Diagnost

[PATCH] D26271: [PPC} add extract significand/ extract exponent/test data class for vector float and vector double -- clang portion

sfertile added inline comments. Comment at: lib/Headers/altivec.h:15629 +#define vec_test_data_class(__a, __b) \ +_Generic((__a),\ + vector float:

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha removed rL LLVM as the repository for this revision. Alpha updated this revision to Diff 76849. Alpha added a comment. Fix diagnostic deserialization bug for clang-apply-replacement. https://reviews.llvm.org/D26137 Files: include/clang/Tooling/Core/Diagnostic.h include/clang/Tooling/D

Re: RE: RE: r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

Hi Jonas,   Thanks for the quotes. I'll rename one of the versions of ConstructJob to make the problem disappear. I'll post a patch soon.   Thanks again, Samuel    - Original message -From: "Hahnfeld, Jonas" To: "Hahnfeld, Jonas" , Samuel F Antao/Watson/IBM@IBMUSCc: "cfe-commits@lists.llvm.

[PATCH] D26279: [clang-tidy] Handle data() in readability-redundant-string-cstr

malcolm.parsons updated this revision to Diff 76848. malcolm.parsons added a comment. Add to release notes. Add to documentation of check. https://reviews.llvm.org/D26279 Files: clang-tidy/readability/RedundantStringCStrCheck.cpp docs/ReleaseNotes.rst docs/clang-tidy/checks/readability-re

[PATCH] D26279: [clang-tidy] Handle data() in readability-redundant-string-cstr

malcolm.parsons added a comment. In https://reviews.llvm.org/D26279#586641, @aaron.ballman wrote: > I like the idea, but would point out that `data()` and `c_str()` had > different semantics once upon a time. I'm aware of this, but it doesn't affect whether the call is redundant. https://rev

[PATCH] D26279: [clang-tidy] Handle data() in readability-redundant-string-cstr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I like the idea, but would point out that `data()` and `c_str()` had different semantics once upon a time. In c++03 and earlier, `data()` was not guaranteed to be null ter

[PATCH] D26276: Remove redundant calls to std::string::data()

This revision was automatically updated to reflect the committed changes. Closed by commit rL285899: Remove redundant calls to std::string::data() (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D26276?vs=76835&id=76846#toc Repository: rL LLVM https://review

r285899 - Remove redundant calls to std::string::data()

Author: malcolm.parsons Date: Thu Nov 3 07:25:51 2016 New Revision: 285899 URL: http://llvm.org/viewvc/llvm-project?rev=285899&view=rev Log: Remove redundant calls to std::string::data() Reviewers: aaron.ballman, mehdi_amini, dblaikie Subscribers: klimek, cfe-commits Differential Revision: htt

[PATCH] D26279: [clang-tidy] Handle data() in readability-redundant-string-cstr

malcolm.parsons created this revision. malcolm.parsons added reviewers: etienneb, alexfh, aaron.ballman. malcolm.parsons added a subscriber: cfe-commits. std::string::data() and std::string::c_str() are equivalent. Enhance the readability-redundant-string-cstr check to also handle calls to data().

[PATCH] D26276: Remove redundant calls to std::string::data()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D26276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

RE: RE: r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

Hi Samuel, if we trust StackOverflow, the code is wrong because all functions with the same name are hidden, ignoring the rest of the signature. I will try to find the corresponding section in the C++ standard… I think any version of GCC gives the error, I was able to reproduce this with

Re: RE: r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

Hi Jonas,   I think that the code is correct. Is probably some bug in the compiler. We are not hiding anything - the compiler is checking against the wrong virtual function (using the wrong signature).   I am in process to compile the same version of gcc the bot is using to see if there is any mass

RE: r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

Hi, I think I have identified what is the problem here: the so-called “name hiding” when overloading virtual functions. (see http://stackoverflow.com/a/1629074) To fix it, I see two possible solutions: Either apply the attached patch or rename one method so that the hiding does not happen.

[PATCH] D26278: Avoid -Wshadow warnings for shadowed variables that aren't captured by lambdas with an explicit capture list

arphaman created this revision. arphaman added reviewers: rsmith, rnk. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch avoids the -Wshadow warning for variables which shadow variables that aren't captured by lambdas with an explicit c

[PATCH] D26276: Remove redundant calls to std::string::data()

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, mehdi_amini, dblaikie. malcolm.parsons added a subscriber: cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D26276 Files: lib/Parse/ParseObjc.cpp lib/Tooling/Core/Replacement.cpp I

[PATCH] D26274: clang-format: [JS] do not break after declare namespace.

mprobst updated this revision to Diff 76831. mprobst added a comment. - drop kw_module from ASI protection block https://reviews.llvm.org/D26274 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestJS.cpp Index: uni

[PATCH] D26274: clang-format: [JS] do not break after declare namespace.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. See TypeScript grammar for tokens following 'declare': https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#A.10 Additional minor change: clang-

[PATCH] D21072: [mips] Account for -mabi when determining whether IAS is the default or not.

sdardis updated this revision to Diff 76824. sdardis added a comment. Rebase and ping https://reviews.llvm.org/D21072 Files: include/clang/Driver/ToolChain.h lib/Driver/MSVCToolChain.cpp lib/Driver/MinGWToolChain.cpp lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib/Driver/Tool

[PATCH] D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'

sdardis updated this revision to Diff 76823. sdardis added a comment. Rebase and ping. https://reviews.llvm.org/D21070 Files: lib/Basic/Targets.cpp lib/Driver/ToolChains.cpp lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp tools/driver/cc1as_main.cpp Index: tools/driver/cc1as

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

malcolm.parsons added a comment. Do you have commit access? https://reviews.llvm.org/D25439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r285889 - Reverted r285882 (Enhancement to test for -ast-print)

Author: sepavloff Date: Thu Nov 3 03:58:44 2016 New Revision: 285889 URL: http://llvm.org/viewvc/llvm-project?rev=285889&view=rev Log: Reverted r285882 (Enhancement to test for -ast-print) It broke buildbot on Windows. Modified: cfe/trunk/test/Coverage/ast-printing.c Modified: cfe/trunk/te

[PATCH] D26271: [PPC} add extract significand/ extract exponent/test data class for vector float and vector double -- clang portion

nemanjai added a comment. LGTM but I'll let @kbarton have a look and provide the final approval. Comment at: lib/Headers/altivec.h:15629 +#define vec_test_data_class(__a, __b) \ +_Generic((__a),

[PATCH] D21502: Fix heuristics skipping invalid ctor-initializers with C++11

This revision was automatically updated to reflect the committed changes. Closed by commit rL285883: Fix heuristics skipping invalid ctor-initializers with C++11 (authored by ogoffart). Changed prior to commit: https://reviews.llvm.org/D21502?vs=69223&id=76819#toc Repository: rL LLVM https:

r285883 - Fix heuristics skipping invalid ctor-initializers with C++11

Author: ogoffart Date: Thu Nov 3 02:36:17 2016 New Revision: 285883 URL: http://llvm.org/viewvc/llvm-project?rev=285883&view=rev Log: Fix heuristics skipping invalid ctor-initializers with C++11 Use better heuristics to detect if a '{' might be the start of the constructor body or not. Especial

r285882 - Enhancement to test for -ast-print

Author: sepavloff Date: Thu Nov 3 02:32:02 2016 New Revision: 285882 URL: http://llvm.org/viewvc/llvm-project?rev=285882&view=rev Log: Enhancement to test for -ast-print Present tests for the functionality provided by command lime option `-ast-print` check only absence of crash. This change trie

[PATCH] D25263: [Driver] Allow setting the default linker during build

Hahnfeld added a comment. I have two high level remarks here: 1. `CLANG_DEFAULT_LINKER` should override whatever the platform default is. So `ToolChain::getDefaultLinker()` should return `ld` as the variable `DefaultLinker` currently says and the logic should be in `ToolChain::GetLinkerPath()`

[PATCH] D25669: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC)

Hahnfeld added a comment. Can I commit this as-is for now and we can think about `StringSwitch` in the driver later on? https://reviews.llvm.org/D25669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li