I'll look at these first thing next week. If you remember please ping me.
(It's Cppcon this week)
Sorry I haven't reviewed this already. Thank you for working on this.
On Sep 18, 2016 11:55 PM, "Igor Kudrin" wrote:
> ikudrin added a comment.
>
> Hi,
>
> Ping.
>
> The patch is under review for a
danielmarjamaki added a comment.
> However, I think this check should be part of Clang diagnostics. GCC has
> -Wredundant-decls for a long time.
I am not against that.
What is the criteria? When should it be in the compiler and when should it be
in clang-tidy?
Personally I think it's natural
ikudrin added a comment.
Hi,
Ping.
The patch is under review for a long time and the described problem is still
here. As we've seen the issue in practice, I'm sure that others may also run
into it, and I do believe it should be fixed, one way or another.
@EricWF, can I improve the patch someh
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks Good.
https://reviews.llvm.org/D24708
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
https://reviews.llvm.org/D24703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
danalbert added inline comments.
Comment at: include/__config:90
@@ +89,3 @@
+#if defined(__linux__)
+#include
+#if !defined(__GLIBC_PREREQ)
EricWF wrote:
> Does MUSL libc have a `features.h`? This include was previously guarded by
> if `!defined(_LIBCPP_HAS_MU
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing the MUSL libc comment.
Comment at: include/__config:90
@@ +89,3 @@
+#if defined(__linux__)
+#include
+#if !defined(__GLIBC_PREREQ)
Does
Author: vedantk
Date: Sun Sep 18 20:42:38 2016
New Revision: 281881
URL: http://llvm.org/viewvc/llvm-project?rev=281881&view=rev
Log:
[docs] Touch up the code coverage doc
Modified:
cfe/trunk/docs/SourceBasedCodeCoverage.rst
Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst
URL:
http://l
Author: dcoughlin
Date: Sun Sep 18 20:36:40 2016
New Revision: 281880
URL: http://llvm.org/viewvc/llvm-project?rev=281880&view=rev
Log:
[analyzer] SATestBuild.py: Treat '#' as comment in projectMap.csv
Treat lines in projectMap.csv that start with '#' as comments. This enables a
workflow where pr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281880: [analyzer] SATestBuild.py: Treat '#' as comment in
projectMap.csv (authored by dcoughlin).
Changed prior to commit:
https://reviews.llvm.org/D24709?vs=71757&id=71766#toc
Repository:
rL LLVM
Author: dberris
Date: Sun Sep 18 19:59:19 2016
New Revision: 281879
URL: http://llvm.org/viewvc/llvm-project?rev=281879&view=rev
Log:
[XRay] ARM 32-bit no-Thumb support in Clang
Just a test for now, adapted from x86_64 tests of XRay.
This is one of 3 commits to different repositories of XRay ARM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281879: [XRay] ARM 32-bit no-Thumb support in Clang
(authored by dberris).
Changed prior to commit:
https://reviews.llvm.org/D23932?vs=71635&id=71765#toc
Repository:
rL LLVM
https://reviews.llvm.org
DmitryPolukhin added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:668
@@ -664,3 +667,3 @@
llvm::raw_svector_ostream FunctionEncodingStream(FunctionEncodingBuf);
CXXNameMangler FunctionEncodingMangler(*this, FunctionEncodingStream);
// Output name of the function
daphnediane added a comment.
In https://reviews.llvm.org/D24703#545706, @djasper wrote:
> I think, this is the wrong fix. Instead, a
>
> || (Left.is(TT_TemplateOpener) && !Right.is(TT_TemplateCloser))
>
>
> should be added to the last return statement of this function.
>
> Also, could you pl
rsmith added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:668
@@ -664,3 +667,3 @@
llvm::raw_svector_ostream FunctionEncodingStream(FunctionEncodingBuf);
CXXNameMangler FunctionEncodingMangler(*this, FunctionEncodingStream);
// Output name of the function.
--
dcoughlin created this revision.
dcoughlin added reviewers: zaks.anna, NoQ.
dcoughlin added a subscriber: cfe-commits.
Treat lines in projectMap.csv that start with '#' as comments.
This enables a workflow where projects can be temporarily disabled with a
comment describing when they should be t
rsmith added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:668
@@ -664,3 +667,3 @@
llvm::raw_svector_ostream FunctionEncodingStream(FunctionEncodingBuf);
CXXNameMangler FunctionEncodingMangler(*this, FunctionEncodingStream);
// Output name of the function.
--
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281857: clang-format: [JS] Do not wrap taze annotation
comments. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D24477?vs=71189&id=71756#toc
Repository:
rL LLVM
https://rev
Author: mprobst
Date: Sun Sep 18 12:33:51 2016
New Revision: 281857
URL: http://llvm.org/viewvc/llvm-project?rev=281857&view=rev
Log:
clang-format: [JS] Do not wrap taze annotation comments.
Summary:
`// taze: ... from ...` comments are used help tools where a
specific global symbol comes from.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281856: clang-format: [JS] ASI insertion after boolean
literals. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D24574?vs=71385&id=71755#toc
Repository:
rL LLVM
https://rev
Author: mprobst
Date: Sun Sep 18 12:21:52 2016
New Revision: 281856
URL: http://llvm.org/viewvc/llvm-project?rev=281856&view=rev
Log:
clang-format: [JS] ASI insertion after boolean literals.
Summary:
Before when a semicolon was missing after a boolean literal:
a = true
return 1;
clang-fo
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Previously, clang-format would always insert an additional line break after the
import block if the main body started with a comment, due to loosing track o
Author: compnerd
Date: Sun Sep 18 11:12:04 2016
New Revision: 281854
URL: http://llvm.org/viewvc/llvm-project?rev=281854&view=rev
Log:
CodeGen: mark ObjC cstring literals as constant
These strings are constants, mark them as such. This doesn't matter too much in
practice on MachO since the const
Author: compnerd
Date: Sun Sep 18 11:12:14 2016
New Revision: 281855
URL: http://llvm.org/viewvc/llvm-project?rev=281855&view=rev
Log:
CodeGen: mark ObjC cstring literals as unnamed_addr
These are all emitted into a section with a cstring_literal attribute. The
attribute permits the linker to co
zdtorok added a comment.
As it's my first contribution I think I have no commit access.
So far I could not test it on larger codebase. I've tried to do so on clang but
my computer was too slow for that. I will try it again.
What you mean by alpha-phase? What should be the next steps now?
Reposi
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rsmith.
DmitryPolukhin added subscribers: cfe-commits, andreybokhanko.
Recursive mangling should use all existing substitutions and newly created
substitutions should be copied outer mangler.
This patch should fix PR30401 and
daphnediane created this revision.
daphnediane added a reviewer: djasper.
daphnediane added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Fix for the formatting options combination of BreakBeforeBinaryOperators: All,
AlignAfterOpenBracket: AlwaysBreak not handling long templates c
27 matches
Mail list logo
