Re: [PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

omtcyfz added inline comments. Comment at: clang-rename/USRFindingAction.cpp:168 @@ +167,3 @@ + } else +errs() << "clang-rename: could not find symbol named " << OldName + << ".\n"; I am not sure whether "could not find symbol **called**

r280057 - Combine two FileCheck patterns to prevent overzealous matching of .*

Author: rsmith Date: Tue Aug 30 00:14:38 2016 New Revision: 280057 URL: http://llvm.org/viewvc/llvm-project?rev=280057&view=rev Log: Combine two FileCheck patterns to prevent overzealous matching of .* Modified: cfe/trunk/test/Driver/modules-ts.cpp Modified: cfe/trunk/test/Driver/modules-ts.

r280053 - [PowerPC] Update the DWARF register-size table

Author: hfinkel Date: Mon Aug 29 21:38:34 2016 New Revision: 280053 URL: http://llvm.org/viewvc/llvm-project?rev=280053&view=rev Log: [PowerPC] Update the DWARF register-size table The PPC64 DWARF register-size table did not match the ABI specification (or GCC, for that matter). Fix that, and add

[libcxx] r280050 - Add "FLAKY_TEST" test directive to support re-running flaky tests.

Author: ericwf Date: Mon Aug 29 20:46:43 2016 New Revision: 280050 URL: http://llvm.org/viewvc/llvm-project?rev=280050&view=rev Log: Add "FLAKY_TEST" test directive to support re-running flaky tests. Some of the mutex tests fail on machines with high load. This patch implements the test directive

r280044 - [sanitizer-coverage] add two more modes of instrumentation: trace-div and trace-gep, mostly usaful for value-profile-based fuzzing; clang part

Author: kcc Date: Mon Aug 29 20:27:03 2016 New Revision: 280044 URL: http://llvm.org/viewvc/llvm-project?rev=280044&view=rev Log: [sanitizer-coverage] add two more modes of instrumentation: trace-div and trace-gep, mostly usaful for value-profile-based fuzzing; clang part Modified: cfe/trunk

[libcxx] r280042 - Fix syntax error in recent CMake change.

Author: ericwf Date: Mon Aug 29 20:10:33 2016 New Revision: 280042 URL: http://llvm.org/viewvc/llvm-project?rev=280042&view=rev Log: Fix syntax error in recent CMake change. Modified: libcxx/trunk/lib/CMakeLists.txt Modified: libcxx/trunk/lib/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-

r280041 - [PowerPC] Add support for -mlongcall

Author: hfinkel Date: Mon Aug 29 20:07:03 2016 New Revision: 280041 URL: http://llvm.org/viewvc/llvm-project?rev=280041&view=rev Log: [PowerPC] Add support for -mlongcall Add support for GCC's PowerPC -mlongcall option; the backend supports the corresponding target feature as of r280040. Fixes P

[libcxx] r280037 - Fix PR28831 - Bad logic around CMAKE_OSX_SYSROOT and CMAKE_OSX_ARCHITECTURES.

Author: ericwf Date: Mon Aug 29 19:54:37 2016 New Revision: 280037 URL: http://llvm.org/viewvc/llvm-project?rev=280037&view=rev Log: Fix PR28831 - Bad logic around CMAKE_OSX_SYSROOT and CMAKE_OSX_ARCHITECTURES. See https://llvm.org/bugs/show_bug.cgi?id=28831 for more information about the changes

Re: [PATCH] D23765: Fix for clang PR 29087

twoh added a comment. ping https://reviews.llvm.org/D23765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280035 - C++ Modules TS: driver support for building modules.

Author: rsmith Date: Mon Aug 29 19:44:54 2016 New Revision: 280035 URL: http://llvm.org/viewvc/llvm-project?rev=280035&view=rev Log: C++ Modules TS: driver support for building modules. This works as follows: we add --precompile to the existing gamut of options for specifying how far to go when c

Re: [PATCH] D23734: Add -fprofile-dir= to clang.

compnerd added a subscriber: compnerd. Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:121 @@ -120,2 +120,3 @@ - std::string mangleName(const DICompileUnit *CU, const char *NewStem); + enum GCovFileType { GCNO, GCDA }; + std::string mangleName(const DICompileUnit

Re: [PATCH] D22766: Handle -mlong-calls on Hexagon

compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. That is a bug in the LLVM implementation. The functionality is supported on other (i.e. `gcc`) compilers. Repository: rL LLVM https://reviews.llvm

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. F2347517: pingu Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24015: [CMake] Copy headers relative to LLVM_BINARY_DIR

Chris Bieneman writes: > beanz created this revision. > beanz added reviewers: bogner, EricWF. > beanz added a subscriber: cfe-commits. > > This copy phase is only needed for in-tree builds, so we should be > copying to the LLVM build directory's include dir instead of the > sub-project include di

[PATCH] D24015: [CMake] Copy headers relative to LLVM_BINARY_DIR

beanz created this revision. beanz added reviewers: bogner, EricWF. beanz added a subscriber: cfe-commits. This copy phase is only needed for in-tree builds, so we should be copying to the LLVM build directory's include dir instead of the sub-project include dir. https://reviews.llvm.org/D24015

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

rnk added a comment. In https://reviews.llvm.org/D23895#528208, @aaron.ballman wrote: > You are removing a lot of instances of `MaybeParseMicrosoftAttributes()`, but > I'm not certain I understand why. Can you describe why you need to remove > those? That shouldn't change functionality, Nico

r280031 - [cfi] Export __cfi_check when linking with -fsanitize-cfi-cross-dso.

Author: eugenis Date: Mon Aug 29 18:42:34 2016 New Revision: 280031 URL: http://llvm.org/viewvc/llvm-project?rev=280031&view=rev Log: [cfi] Export __cfi_check when linking with -fsanitize-cfi-cross-dso. Multi-DSO CFI model requires every DSO to export a __cfi_check function. Modified: cfe/tr

r280028 - Fix typo in test.

Author: eugenis Date: Mon Aug 29 18:15:46 2016 New Revision: 280028 URL: http://llvm.org/viewvc/llvm-project?rev=280028&view=rev Log: Fix typo in test. Modified: cfe/trunk/test/Driver/sanitizer-ld.c Modified: cfe/trunk/test/Driver/sanitizer-ld.c URL: http://llvm.org/viewvc/llvm-project/cfe/

[PATCH] D24012: Fix strict-aliasing violation in typeinfo::hash_code()

EricWF created this revision. EricWF added reviewers: mclow.lists, howard.hinnant. EricWF added a subscriber: cfe-commits. The current implementation of `hash_code()` for uniqued RTTI strings violates strict aliasing by dereferencing a type-punned pointer. Specifically it generates a `const char

Re: [PATCH] D23944: Parsing MS pragma intrinsic

agutowski marked 4 inline comments as done. agutowski added a comment. https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23944: Parsing MS pragma intrinsic

agutowski updated this revision to Diff 69632. agutowski added a comment. Changed warning template to use select, fixed some mistakes in the comments. https://reviews.llvm.org/D23944 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Parse/Parser.h lib/Parse/ParsePragma.cpp

Re: [PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

pirama added a subscriber: srhines. pirama added a comment. Tim: Thanks for looking into this. It's definitely a simpler fix than I thought it would be :) https://reviews.llvm.org/D24010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

timshen created this revision. timshen added reviewers: rsmith, pirama. timshen added a subscriber: cfe-commits. https://reviews.llvm.org/D24010 Files: clang/include/clang/AST/Stmt.h clang/lib/Analysis/ReachableCode.cpp clang/test/SemaCXX/PR29152.cpp Index: clang/test/SemaCXX/PR29152.cpp =

[libcxxabi] r280023 - [CMake] Trying to fix the bots I broke

Author: cbieneman Date: Mon Aug 29 17:26:00 2016 New Revision: 280023 URL: http://llvm.org/viewvc/llvm-project?rev=280023&view=rev Log: [CMake] Trying to fix the bots I broke See: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx1z/builds/981/steps/build.libcxxabi/logs/s

Re: [PATCH] D23944: Parsing MS pragma intrinsic

agutowski added inline comments. Comment at: lib/Parse/ParsePragma.cpp:2164 @@ +2163,3 @@ + + bool SuggestIntrinH = !PP.isMacroDefined("__INTRIN_H"); + aaron.ballman wrote: > Is this safe to rely on? I'm not familiar with how we do our intrinsics, but > it's spe

Re: [PATCH] D24007: [CMake] Use -std=c++11 if supported

This revision was automatically updated to reflect the committed changes. Closed by commit rL280021: [CMake] Use -std=c++11 if supported (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D24007?vs=69619&id=69624#toc Repository: rL LLVM https://reviews.llvm.org/D2400

[libcxxabi] r280021 - [CMake] Use -std=c++11 if supported

Author: cbieneman Date: Mon Aug 29 17:12:21 2016 New Revision: 280021 URL: http://llvm.org/viewvc/llvm-project?rev=280021&view=rev Log: [CMake] Use -std=c++11 if supported Summary: This patch adds a check for if -std=c++11 is a supported flag, and adds it to CMAKE_CXX_FLAGS if it is supported.

Re: [PATCH] D24007: [CMake] Use -std=c++11 if supported

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. I'm surprised we don't already require C++11. Comment at: cmake/config-ix.cmake:40 @@ -39,1 +39,3 @@ check_cxx_compiler_flag(/GR- LIBCXXABI_HAS_NO_GR_F

[PATCH] D24007: [CMake] Use -std=c++11 if supported

beanz created this revision. beanz added a reviewer: EricWF. beanz added a subscriber: cfe-commits. This patch adds a check for if -std=c++11 is a supported flag, and adds it to CMAKE_CXX_FLAGS if it is supported. https://reviews.llvm.org/D24007 Files: cmake/config-ix.cmake Index: cmake/conf

[PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

mgorny created this revision. mgorny added reviewers: samsonov, Hahnfeld. mgorny added a subscriber: cfe-commits. Herald added a subscriber: dberris. Support overriding LLVM_* variables obtained from llvm-config when doing stand-alone builds. The override of LLVM_MAIN_SRC_DIR is necessary to prov

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

compnerd closed this revision. compnerd added a comment. SVN r280015 https://reviews.llvm.org/D23856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r280015 - libc++: perform configuration checks with -nodefaultlibs

Author: compnerd Date: Mon Aug 29 16:33:37 2016 New Revision: 280015 URL: http://llvm.org/viewvc/llvm-project?rev=280015&view=rev Log: libc++: perform configuration checks with -nodefaultlibs We're compiling libc++ with -nodefaultlibs, so we should also pass this option during the configuration c

Re: [PATCH] D23944: Parsing MS pragma intrinsic

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. Comment at: include/clang/Basic/DiagnosticParseKinds.td:918 @@ +917,3 @@ + InGroup; +def warn_pragma_intrinsic_builtin_suggest : Warning< + "%0 is not a recognized builtin; consider i

Re: [PATCH] D23734: Add -fprofile-dir= to clang.

nlewycky added a comment. Ping! I think the review this patch really needs is a comparison to GCC's implementation to double-check that it really does the same thing that GCC does. Is there a gcov user who could take a look at this? https://reviews.llvm.org/D23734 _

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. You are removing a lot of instances of `MaybeParseMicrosoftAttributes()`, but I'm not certain I understand why. Can you describe why you need to remove those? There are

Re: r279765 - Omit column info for CodeView by default

Sorry, no, I don't have plans to implement column ranges at this time. On Mon, Aug 29, 2016 at 2:10 PM, Adrian Prantl wrote: > > > On Aug 25, 2016, at 11:24 AM, Adrian McCarthy via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > Author: amccarth > > Date: Thu Aug 25 13:24:35 2016 > >

Re: r279765 - Omit column info for CodeView by default

> On Aug 25, 2016, at 11:24 AM, Adrian McCarthy via cfe-commits > wrote: > > Author: amccarth > Date: Thu Aug 25 13:24:35 2016 > New Revision: 279765 > > URL: http://llvm.org/viewvc/llvm-project?rev=279765&view=rev > Log: > Omit column info for CodeView by default > > Clang tracks only start

r280009 - Fix a bug preventing the cause of a module-out-of-date error from being printed

Author: adrian Date: Mon Aug 29 15:46:56 2016 New Revision: 280009 URL: http://llvm.org/viewvc/llvm-project?rev=280009&view=rev Log: Fix a bug preventing the cause of a module-out-of-date error from being printed Modified: cfe/trunk/lib/Serialization/ASTReader.cpp cfe/trunk/test/Modules/e

r280010 - Fix a bug preventing the cause for a module file-not-found from being displayed

Author: adrian Date: Mon Aug 29 15:46:59 2016 New Revision: 280010 URL: http://llvm.org/viewvc/llvm-project?rev=280010&view=rev Log: Fix a bug preventing the cause for a module file-not-found from being displayed Modified: cfe/trunk/lib/Serialization/ASTReader.cpp cfe/trunk/test/Modules/e

[libcxx] r280007 - Fix or suppress GCC warnings during build.

Author: ericwf Date: Mon Aug 29 15:43:38 2016 New Revision: 280007 URL: http://llvm.org/viewvc/llvm-project?rev=280007&view=rev Log: Fix or suppress GCC warnings during build. Summary: Currently a number of GCC warnings are emitted when building libc++. This patch fixes or ignores all of them. T

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associate with extensions

yaxunl retitled this revision from "[OpenCL] Allow user to add supported OpenCL extensions by pragma" to "[OpenCL] Allow disabling types and declarations associate with extensions". yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 69606. yaxunl added a comment.

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

smeenai marked an inline comment as done. smeenai added a comment. https://reviews.llvm.org/D23856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

smeenai updated this revision to Diff 69607. smeenai added a comment. Putting -nodefaultlibs in CMAKE_REQUIRED_FLAGS https://reviews.llvm.org/D23856 Files: cmake/Modules/CheckLibcxxAtomic.cmake cmake/config-ix.cmake Index: cmake/config-ix.cmake =

Re: [PATCH] D23999: [libc++] Minimal std::tuple fix for PR29123

rsmith added a comment. Ouch. This testcase is horrible. Note that we find two different ways to convert `Optional>` to itself: the obvious way, and `Optional> -> dynamic -> std::tuple -> Optional>` (because `tuple`'s conversion happens inside its converting constructor, this sidesteps the "at

Re: [PATCH] D23944: Parsing MS pragma intrinsic

agutowski marked 2 inline comments as done. agutowski added a comment. https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23944: Parsing MS pragma intrinsic

agutowski updated this revision to Diff 69605. agutowski added a comment. Changed warning messages https://reviews.llvm.org/D23944 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Parse/Parser.h lib/Parse/ParsePragma.cpp test/Preprocessor/pragma_microsoft.c Index: lib/P

[PATCH] D24002: clang-rename: improve error message when -old-name is used and could not find symbol

vmiklos created this revision. vmiklos added reviewers: klimek, omtcyfz. vmiklos added a subscriber: cfe-commits. Old output was: clang-rename: could not find symbol at tools/clang/tools/extra/test/clang-rename/ClassFindByName.cpp:1:1 (offset 0). https://reviews.llvm.org/D24002 Files: clang

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

smeenai added inline comments. Comment at: cmake/config-ix.cmake:18 @@ +17,3 @@ +if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG) + list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs) + if (LIBCXX_HAS_C_LIB) EricWF wrote: > smeenai wrote: > > smeenai wrote: > > > compne

[libcxx] r279999 - Turn On -DLIBCXX_ENABLE_BENCHMARKS by default.

Author: ericwf Date: Mon Aug 29 14:50:49 2016 New Revision: 27 URL: http://llvm.org/viewvc/llvm-project?rev=27&view=rev Log: Turn On -DLIBCXX_ENABLE_BENCHMARKS by default. This patch enables the `cxx-benchmarks` target by default. Note that the target still has to be manually invoked sinc

[libcxx] r279989 - Update Google Benchmark library.

Author: ericwf Date: Mon Aug 29 14:12:01 2016 New Revision: 279989 URL: http://llvm.org/viewvc/llvm-project?rev=279989&view=rev Log: Update Google Benchmark library. Added: libcxx/trunk/utils/google-benchmark/test/output_test.h libcxx/trunk/utils/google-benchmark/test/output_test_helper.c

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

EricWF added inline comments. Comment at: cmake/config-ix.cmake:18 @@ +17,3 @@ +if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG) + list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs) + if (LIBCXX_HAS_C_LIB) smeenai wrote: > smeenai wrote: > > compnerd wrote: > > > Can w

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

smeenai marked an inline comment as done. Comment at: cmake/config-ix.cmake:18 @@ +17,3 @@ +if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG) + list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs) + if (LIBCXX_HAS_C_LIB) smeenai wrote: > compnerd wrote: > > Can we not use

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff updated this revision to Diff 69597. sepavloff added a comment. Added missed test case. https://reviews.llvm.org/D16989 Files: include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp test/SemaCXX/PR25848.cpp test/SemaCXX/friend2.cpp test/SemaCXX/function-redecl-2.cpp Index: test/Se

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff updated this revision to Diff 69595. sepavloff added a comment. Updated patch Added missing checks for forward declarations in `shouldLinkDependentDeclWithPrevious`. Added test case from an ancient bug report. https://reviews.llvm.org/D16989 Files: include/clang/Sema/Sema.h lib/

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff marked an inline comment as done. Comment at: lib/Sema/SemaDecl.cpp:8657-8658 @@ +8656,4 @@ + DeclContext *SemanticDC = D->getDeclContext(); + if (SemanticDC->isDependentContext()) +return false; + // Get here only for out-of-line declarations: lexical context is

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/google-runtime-int.rst:27 @@ +26,2 @@ + + A string represents type suffix. Default is empty. I think empty string will be better. Same for other occurrences. https://reviews.llvm.org/D239

Re: [PATCH] D23999: [libc++] Minimal std::tuple fix for PR29123

EricWF updated this revision to Diff 69591. EricWF added a comment. Add testcase to patch. https://reviews.llvm.org/D23999 Files: include/__tuple include/tuple test/std/utilities/tuple/tuple.tuple/tuple.cnstr/PR29123_implicit_constructor_sfinae.pass.cpp Index: test/std/utilities/tuple/

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

vsk added a comment. Thanks for looking into this! I like the SourceRegionFilter setup. Comment at: lib/CodeGen/CoverageMappingGen.cpp:261 @@ -253,1 +260,3 @@ + void + emitSourceRegions(const SourceRegionFilter &Filter = SourceRegionFilter()) { for (const auto &Region : S

Re: [libcxxabi] r279938 - [CMake] Be more consistent about naming targets and components in libc++abi

And I just noticed your other commit, which I think means you did all the work there. Many thanks! -Chris > On Aug 29, 2016, at 11:09 AM, Chris Bieneman via cfe-commits > wrote: > > Many thanks for taking this on. I haven’t yet had a chance to look into > libcxxabi, but it is next on my list

Re: [libcxxabi] r279938 - [CMake] Be more consistent about naming targets and components in libc++abi

Many thanks for taking this on. I haven’t yet had a chance to look into libcxxabi, but it is next on my list of projects to get into the runtimes subdirectory. Thanks! -Chris > On Aug 28, 2016, at 11:28 AM, Eric Fiselier via cfe-commits > wrote: > > Author: ericwf > Date: Sun Aug 28 13:28:51

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

rnk added a comment. The code looks good and I'm happy to leave the naming as it is for now. Apparently MSVC is warning on these attributes and calling them "ATL attributes" now: https://msdn.microsoft.com/en-us/library/mt723604.aspx I'm not sure if that warning applies to all square-bracketed

Re: [PATCH] D23944: Parsing MS pragma intrinsic

rnk added inline comments. Comment at: include/clang/Basic/DiagnosticParseKinds.td:916 @@ +915,3 @@ +def warn_pragma_expected_builtin : Warning< + "expected builtin function in '#pragma %0' - ignored">, + InGroup; I'd use this wording: '%0' is not a recognized

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis added a comment. rnk: ping https://reviews.llvm.org/D23895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r279765 - Omit column info for CodeView by default

ah, fair enough - only saw the diff, not the rest of the file On Mon, Aug 29, 2016 at 9:59 AM Adrian McCarthy wrote: > Thanks. I was trying to be consistent with how the prefixes were used in > this particular file, where the prefix was modeled after the case-sensitive > flags being tested. > >

Re: r279765 - Omit column info for CodeView by default

Thanks. I was trying to be consistent with how the prefixes were used in this particular file, where the prefix was modeled after the case-sensitive flags being tested. On Mon, Aug 29, 2016 at 8:49 AM, David Blaikie wrote: > > > On Thu, Aug 25, 2016 at 11:32 AM Adrian McCarthy via cfe-commits <

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added a comment. Anyone else have any thoughts on this or is this good to go? https://reviews.llvm.org/D23848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23375: Add kfree( ) to MallocChecker.cpp

dcoughlin added a comment. In https://reviews.llvm.org/D23375#527291, @andrewmw94 wrote: > One more thing, obviously it should mimic malloc/free's behavior in > complaining about delete/new being used. Should it also complain about > free/malloc being used? I can't imagine that would be some

r279978 - Try to fix clang-offload-bunder.c test once more

Author: rnk Date: Mon Aug 29 11:24:57 2016 New Revision: 279978 URL: http://llvm.org/viewvc/llvm-project?rev=279978&view=rev Log: Try to fix clang-offload-bunder.c test once more Modified: cfe/trunk/test/Driver/clang-offload-bundler.c Modified: cfe/trunk/test/Driver/clang-offload-bundler.c U

Re: r279765 - Omit column info for CodeView by default

On Thu, Aug 25, 2016 at 11:32 AM Adrian McCarthy via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: amccarth > Date: Thu Aug 25 13:24:35 2016 > New Revision: 279765 > > URL: http://llvm.org/viewvc/llvm-project?rev=279765&view=rev > Log: > Omit column info for CodeView by default > > Cl

[PATCH] D23992: [OpenCL] Augment pipe built-ins with pipe packet size and alignment.

bader created this revision. bader added reviewers: Anastasia, vpykhtin. bader added a subscriber: cfe-commits. Keep pipe packet size and alignment in LLVM IR layer to enable translation from LLVM IR to SPIR-V format. https://reviews.llvm.org/D23992 Files: lib/CodeGen/CGBuiltin.cpp lib/CodeG

Re: [PATCH] D22766: Handle -mlong-calls on Hexagon

kparzysz added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D22766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. One minor typo fix, but otherwise LGTM. Thank you for the check! Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:125-126 @@ +124,4 @@ +

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

aaron.ballman requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/AST/ExprCXX.h:109 @@ -108,1 +108,3 @@ + // Check to see if a given overloaded operator is of assignment kind + static bool isAssignmentOp(OverloadedOperat

Re: [PATCH] D23989: Fix -Wunused-but-set-variable warning.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279964: Fix -Wunused-but-set-variable warning. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D23989?vs=69554&id=69559#toc Repository: rL LLVM https://reviews.llvm.org/D2398

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

danielmarjamaki marked 4 inline comments as done. danielmarjamaki added a comment. https://reviews.llvm.org/D21134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

danielmarjamaki updated this revision to Diff 69558. danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. fix review comments https://reviews.llvm.org/D21134 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/MisplacedArrayIndexCheck.cpp clan

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

iamsergio added a comment. In https://reviews.llvm.org/D17983#527399, @iamsergio wrote: > @ariccio, are you blocked on this or waiting for reviewers ? This seems to be > blocking the patch that fixes plugins on MSVC, thanks https://llvm.org/bugs/show_bug.cgi?id=11446 comment #6 links to this r

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

jasjuang added a comment. @jsmouret Bravo for the improved solution! https://reviews.llvm.org/D12407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23160: [Coverage] Prevent creating a redundant counter if a nested body ends with a macro.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279962: [Coverage] Prevent creating a redundant counter if a nested body ends with a… (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D23160?vs=66790&id=69556#toc Repository:

r279962 - [Coverage] Prevent creating a redundant counter if a nested body ends with a macro.

Author: ikudrin Date: Mon Aug 29 06:48:50 2016 New Revision: 279962 URL: http://llvm.org/viewvc/llvm-project?rev=279962&view=rev Log: [Coverage] Prevent creating a redundant counter if a nested body ends with a macro. If there were several nested statements arranged in a way that all of them end

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

ikudrin added a comment. This patch fixes the following issue: $ cat > test.cpp << EOF void dummy() {} #define MACRO_1 dummy() #define MACRO_2 MACRO_1 int main() { int i = 0; if (i > 5) MACRO_2; } EOF $ clang++ -fprofile-instr-generate -fcoverage-mapping dum

Re: [PATCH] D23989: Fix -Wunused-but-set-variable warning.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg. Feel free to submit trivial changes like this without pre-commit review. https://reviews.llvm.org/D23989 ___ cfe-commits mailing list cfe-c

[PATCH] D23989: Fix -Wunused-but-set-variable warning.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. A follow-up fix on r279958. https://reviews.llvm.org/D23989 Files: lib/Target/X86/X86ISelLowering.cpp Index: lib/Target/X86/X86ISelLowering.cpp =

Re: [PATCH] D23160: [Coverage] Prevent creating a redundant counter if a nested body ends with a macro.

ikudrin added a comment. I figured out that the last issue is an independent one, so I prepared a separate fix for it: https://reviews.llvm.org/D23987. https://reviews.llvm.org/D23160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

ikudrin created this revision. ikudrin added reviewers: davidxl, bogner, vsk. ikudrin added a subscriber: cfe-commits. In many cases, these code regions are just redundant, but sometimes they could be assigned to the counter of the parent code region instead of the counter of the nested block.

Re: [PATCH] D23985: [InstructionSelect] NumBlocks isn't defined in DEBUG build.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279959: [InstructionSelect] NumBlocks isn't defined in DEBUG build. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D23985?vs=69540&id=69542#toc Repository: rL LLVM https://r

Re: [PATCH] D23985: [InstructionSelect] NumBlocks isn't defined in DEBUG build.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D23985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D23985: [InstructionSelect] NumBlocks isn't defined in DEBUG build.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. A follow-up fixing on http://llvm.org/viewvc/llvm-project?view=revision&revision=279905. https://reviews.llvm.org/D23985 Files: lib/CodeGen/GlobalISel/InstructionSelect.cpp Index: lib/Code

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein added inline comments. Comment at: docs/clang-tidy/checks/google-readability-namespace-comments.rst:11 @@ +10,3 @@ + +Options +--- Eugene.Zelenko wrote: > This documentation is redirect, so options description should be moved to > llvm-namespace-commen

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein updated this revision to Diff 69539. hokein added a comment. Remove extra blank line. https://reviews.llvm.org/D23918 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-build-namespaces.rst docs/clang-tidy/checks/google

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein updated this revision to Diff 69538. hokein marked 8 inline comments as done. hokein added a comment. Address review comments: - Use "Default is XYZ" instead of "XYZ by default". - Replace empty string `` with empty word, passing docs compilation. https://reviews.llvm.org/D23918 Files: