Author: chapuni
Date: Fri Aug 19 00:25:26 2016
New Revision: 279207
URL: http://llvm.org/viewvc/llvm-project?rev=279207&view=rev
Log:
clang/test/Modules/prebuilt-module.m: Prune "-triple" to fix a configuration
mismatch.
Modified:
cfe/trunk/test/Modules/prebuilt-module.m
Modified: cfe/trunk
timshen created this revision.
timshen added a reviewer: dblaikie.
timshen added a subscriber: cfe-commits.
Currently nodes_iterator may dereference to a NodeType* or a NodeType&. Make
them all dereference to NodeType*, which is NodeRef later. Corresponding LLVM
change: D23704
https://reviews.l
Author: yaxunl
Date: Fri Aug 19 00:17:25 2016
New Revision: 279206
URL: http://llvm.org/viewvc/llvm-project?rev=279206&view=rev
Log:
Re-commit [OpenCL] AMDGCN: Fix size_t type
There was a premature cast to pointer type in emitPointerArithmetic which
caused assertion in tests with assertion enabl
faisalv added a comment.
Address Richard's comments.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:190
@@ -189,3 +189,3 @@
if (A->getCond()->isValueDependent() && !Cond->isValueDependent() &&
- !Expr::isPotentialConstantExprUnevaluated(Cond, cast(Tmpl),
+ !Ex
faisalv updated this revision to Diff 68644.
faisalv marked 4 inline comments as done.
faisalv added a comment.
Address Richard's comments.
https://reviews.llvm.org/D23493
Files:
lib/AST/ExprConstant.cpp
lib/Sema/SemaTemplateInstantiateDecl.cpp
test/SemaCXX/constant-expression-cxx11.cpp
The key.snk is generated when you build, the problem is the csproj file
hardcodes the directory to the sdk instead of using the appropriate project
system variable like $(SDKToolsDir)
On Thu, Aug 18, 2016 at 7:09 PM Zachary Turner wrote:
> Llvm doesn't support vs2012 anymore, as long as it suppor
Llvm doesn't support vs2012 anymore, as long as it supports vs2013 it's
fine
On Thu, Aug 18, 2016 at 7:07 PM Antonio Maiorano
wrote:
> Hi,
>
> What I meant by upgrade was simply making it build in VS 2015. However,
> you bring up a valid point about making sure the extension will continue to
> wo
Author: hans
Date: Thu Aug 18 20:42:56 2016
New Revision: 279195
URL: http://llvm.org/viewvc/llvm-project?rev=279195&view=rev
Log:
Creating release candidate rc2 from release_390 branch
Added:
libunwind/tags/RELEASE_390/rc2/ (props changed)
- copied from r279194, libunwind/branches/re
Author: rsmith
Date: Thu Aug 18 20:43:06 2016
New Revision: 279196
URL: http://llvm.org/viewvc/llvm-project?rev=279196&view=rev
Log:
C++ Modules TS: support parsing the 'module' declaration (including extensions
from p0273r0 approved by EWG). We'll eventually need to handle this from the
lexer as
Author: hans
Date: Thu Aug 18 20:42:35 2016
New Revision: 279188
URL: http://llvm.org/viewvc/llvm-project?rev=279188&view=rev
Log:
Creating release candidate rc2 from release_390 branch
Added:
libcxx/tags/RELEASE_390/rc2/ (props changed)
- copied from r279187, libcxx/branches/release_
Author: hans
Date: Thu Aug 18 20:42:38 2016
New Revision: 279189
URL: http://llvm.org/viewvc/llvm-project?rev=279189&view=rev
Log:
Creating release candidate rc2 from release_390 branch
Added:
libcxxabi/tags/RELEASE_390/rc2/ (props changed)
- copied from r279188, libcxxabi/branches/re
Author: dcoughlin
Date: Thu Aug 18 20:22:50 2016
New Revision: 279183
URL: http://llvm.org/viewvc/llvm-project?rev=279183&view=rev
Log:
[www] Add analyzer FAQ about not releasing ivars in -dealloc.
Modified:
cfe/trunk/www/analyzer/faq.html
Modified: cfe/trunk/www/analyzer/faq.html
URL:
http
Author: dcoughlin
Date: Thu Aug 18 20:05:31 2016
New Revision: 279181
URL: http://llvm.org/viewvc/llvm-project?rev=279181&view=rev
Log:
[analyzer] Weaken assertion in trackNullOrUndefValue()
We should ignore paren casts when making sure that the semantic expression
in a PseudoObjectExpr for an Ob
beanz created this revision.
beanz added a reviewer: EricWF.
beanz added a subscriber: cfe-commits.
The point of this patch is to have a consistent convention for naming build,
check and install targets so that the targets can be constructed from the
project name.
This change renames a bunch of
Author: compnerd
Date: Thu Aug 18 18:59:12 2016
New Revision: 279180
URL: http://llvm.org/viewvc/llvm-project?rev=279180&view=rev
Log:
EHABI: cover switch once more
When making WMMX support optional, we uncovered the switch. Add the missing
entries. Since the entry is a break leading to a dead
Hi Antonio,
On Wed, Aug 17, 2016 at 8:15 AM, Antonio Maiorano via cfe-commits
wrote:
> This patch for clang-format-vs includes the following:
>
> - Upgrade to VS 2015, including .NET framework upgrade from 4.0 to 4.5, and
> upgrading Microsoft.VisualStudio references to v14 versions
> - Fix build
teemperor updated this revision to Diff 68632.
teemperor added a comment.
This revision is now accepted and ready to land.
- Moved from hash_stream to LLVM's MD5 implementation.
https://reviews.llvm.org/D22515
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
vsk updated this revision to Diff 68630.
vsk added a comment.
Per Akira's suggestion, don't pretend that the Arg* for -arch is a
user-specified CPU name (and update the doxygen to reflect this).
https://reviews.llvm.org/D23643
Files:
lib/Driver/Tools.cpp
test/Driver/arm-cortex-cpus.c
Inde
vsk added inline comments.
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
// FIXME: Should this be picked by checking the target triple instead?
- if (Args.getLastArg(options::OPT_arch))
+ if ((A = Args.getLastArg(options::OPT_arch)))
return "cyclone";
-
ahatanak added inline comments.
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
// FIXME: Should this be picked by checking the target triple instead?
- if (Args.getLastArg(options::OPT_arch))
+ if ((A = Args.getLastArg(options::OPT_arch)))
return "cyclone";
compnerd closed this revision.
compnerd added a comment.
SVN r279173
https://reviews.llvm.org/D23530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eugenezelenko
Date: Thu Aug 18 17:11:27 2016
New Revision: 279170
URL: http://llvm.org/viewvc/llvm-project?rev=279170&view=rev
Log:
[Documentation] Fixed style in modernize-use-emplace.rst.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-emplace.rst
Modified:
Author: chfang
Date: Thu Aug 18 17:04:54 2016
New Revision: 279165
URL: http://llvm.org/viewvc/llvm-project?rev=279165&view=rev
Log:
AMDGPU: Add clang builtin for ds_swizzle.
Summary:
int __builtin_amdgcn_ds_swizzle (int a, int imm);
while imm is a constant.
Differential Revision:
http://rev
Author: vvassilev
Date: Thu Aug 18 17:01:25 2016
New Revision: 279164
URL: http://llvm.org/viewvc/llvm-project?rev=279164&view=rev
Log:
PR28794: Don't try to instantiate function templates which are not visible.
Reviewed by Richard Smith.
Added:
cfe/trunk/test/Modules/Inputs/PR28794/
cfe
Author: rsmith
Date: Thu Aug 18 16:59:42 2016
New Revision: 279163
URL: http://llvm.org/viewvc/llvm-project?rev=279163&view=rev
Log:
C++ Modules TS: Add parsing support for module import declaration.
Added:
cfe/trunk/test/Parser/cxx-modules-import.cpp
Modified:
cfe/trunk/include/clang/Bas
Author: bogner
Date: Thu Aug 18 16:46:54 2016
New Revision: 279159
URL: http://llvm.org/viewvc/llvm-project?rev=279159&view=rev
Log:
CodeGen: Rename a variable to better fit LLVM style. NFC
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL:
http://llv
v.g.vassilev updated this revision to Diff 68620.
v.g.vassilev marked an inline comment as done.
v.g.vassilev added a comment.
Move DiagnoseUninstantiableTemplate before the late template parsing.
https://reviews.llvm.org/D23492
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaTemplate.cpp
l
Author: compnerd
Date: Thu Aug 18 16:40:06 2016
New Revision: 279154
URL: http://llvm.org/viewvc/llvm-project?rev=279154&view=rev
Log:
CodeGen: use range based for loop, NFC
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL:
http://llvm.org/viewvc/llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279151: [CMake] Get libcxx building under LLVM/runtimes
(authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D23696?vs=68610&id=68613#toc
Repository:
rL LLVM
https://reviews.ll
Author: cbieneman
Date: Thu Aug 18 16:31:51 2016
New Revision: 279151
URL: http://llvm.org/viewvc/llvm-project?rev=279151&view=rev
Log:
[CMake] Get libcxx building under LLVM/runtimes
Summary:
The new LLVM runtimes build directory requires some basic conventions across
the runtime projects. Thes
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23696
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
beanz created this revision.
beanz added a reviewer: EricWF.
beanz added a subscriber: cfe-commits.
The new LLVM runtimes build directory requires some basic conventions across
the runtime projects. These changes make libcxx build under the runtimes
subdirectory. The general idea of the changes
PR28422 is invalid. Giving better diagnostics in this case seems
reasonable, but we should not accept the ill-formed code.
On 18 Aug 2016 11:41 a.m., "Serge Pavlov" wrote:
> sepavloff created this revision.
> sepavloff added reviewers: rsmith, doug.gregor.
> sepavloff added a subscriber: cfe-com
rsmith added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3598-3603
@@ -3599,1 +3597,8 @@
+ // FIXME: We need to track the instantiation stack in order to know which
+ // definitions should be visible within this instantiation.
+ if (DiagnoseUninstantia
erichkeane abandoned this revision.
erichkeane added a comment.
In https://reviews.llvm.org/D23692#520081, @rsmith wrote:
> This is not a conforming extension. We are explicitly not allowed to make
> standard library functions `constexpr` if the standard doesn't say they are;
> see [constexpr.f
Author: cameron314
Date: Thu Aug 18 15:56:48 2016
New Revision: 279145
URL: http://llvm.org/viewvc/llvm-project?rev=279145&view=rev
Log:
Fixed more signed/unsigned mismatch warnings introduced in my change at r279076
Modified:
cfe/trunk/unittests/libclang/LibclangTest.cpp
Modified: cfe/trunk
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
This is not a conforming extension. We are explicitly not allowed to make
standard library functions `constexpr` if the standard doesn't say they are;
see [constexpr.functions] (17.6
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279140: [CUDA] Improve handling of math functions. (authored
by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D23627?vs=68427&id=68600#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: jlebar
Date: Thu Aug 18 15:43:13 2016
New Revision: 279140
URL: http://llvm.org/viewvc/llvm-project?rev=279140&view=rev
Log:
[CUDA] Improve handling of math functions.
Summary:
A bunch of related changes here to our CUDA math headers.
- The second arg to nexttoward is a double (well, tec
jlebar added a comment.
These changes have always been kind of scary. tra tested this against Thrust
all combinations of CUDA 7.0/7.5, c++98/11,
libc++/libstdc++{4.8.5/4.9.3,5.3.0}. So we should be good here. I hope.
https://reviews.llvm.org/D23627
___
erichkeane created this revision.
erichkeane added reviewers: cfe-commits, majnemer, vbyakovl, DavidKreitzer,
andreybokhanko, rsmith.
erichkeane set the repository for this revision to rL LLVM.
GCC (and other compilers) treat strlen as a 'constexpr' function as an
extension to the language. Cla
Author: yaxunl
Date: Thu Aug 18 15:01:06 2016
New Revision: 279127
URL: http://llvm.org/viewvc/llvm-project?rev=279127&view=rev
Log:
Revert [OpenCL] AMDGCN: Fix size_t type
due to regressions in test/CodeGen/exprs.c on certain platforms.
Removed:
cfe/trunk/test/CodeGenOpenCL/size_t.cl
Modifi
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
As discussed offline, since the functionality being added in this patch is only
useful for tests, the related simplification of tests seems not worth the added
complexity.
https://
Author: zturner
Date: Thu Aug 18 14:42:00 2016
New Revision: 279122
URL: http://llvm.org/viewvc/llvm-project?rev=279122&view=rev
Log:
Fix json compilation database syntax on non-Windows.
Modified:
cfe/trunk/lib/Tooling/JSONCompilationDatabase.cpp
Modified: cfe/trunk/lib/Tooling/JSONCompilati
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rL279121: [OpenCL] AMDGCN: Fix size_t type (authored by
yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D23361?vs=68360&id=68594#toc
Repository:
rL L
Author: yaxunl
Date: Thu Aug 18 14:34:04 2016
New Revision: 279121
URL: http://llvm.org/viewvc/llvm-project?rev=279121&view=rev
Log:
[OpenCL] AMDGCN: Fix size_t type
Pointers of certain GPUs in AMDGCN target in private address space is 32 bit
but pointers in other address spaces are 64 bit. size
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279120: Resubmit "[Tooling] Parse compilation database
command lines on Windows." (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D23628?vs=68426&id=68593#toc
Repository:
rL
Author: zturner
Date: Thu Aug 18 14:31:48 2016
New Revision: 279120
URL: http://llvm.org/viewvc/llvm-project?rev=279120&view=rev
Log:
Resubmit "[Tooling] Parse compilation database command lines on Windows."
This patch introduced the ability to decide at runtime whether to parse
JSON compilation
rsmith added inline comments.
Comment at: lib/AST/Expr.cpp:2865-2867
@@ +2864,5 @@
+ case CXXOperatorCallExprClass: {
+// If it is an operator call expr it can have side effects when the
+// underlaying operator is of assignment kind.
+// Othrwise fall through the res
Author: rnk
Date: Thu Aug 18 13:45:07 2016
New Revision: 279116
URL: http://llvm.org/viewvc/llvm-project?rev=279116&view=rev
Log:
[MS] Silence -Wextern-init on const selectany variables
In C, 'extern' is typically used to avoid tentative definitions when
declaring variables in headers, but adding
Author: alexfh
Date: Thu Aug 18 13:43:47 2016
New Revision: 279115
URL: http://llvm.org/viewvc/llvm-project?rev=279115&view=rev
Log:
[clang-tidy docs] Move option descriptions to the Options section
+ random fixes
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-assert-side-effe
Author: cameron314
Date: Thu Aug 18 13:41:41 2016
New Revision: 279114
URL: http://llvm.org/viewvc/llvm-project?rev=279114&view=rev
Log:
Removed use of 'emplace' on std::map, since not all buildbot slaves support it
Modified:
cfe/trunk/unittests/libclang/LibclangTest.cpp
Modified: cfe/trunk/
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Code was recently added to this test that uses std::back_inserter. Therefore,
the header must be included. (MSVC's STL demands this, as we don't
otherwise drag in back_insert
sepavloff created this revision.
sepavloff added reviewers: rsmith, doug.gregor.
sepavloff added a subscriber: cfe-commits.
If a declaration references a function from global namespace by its
qualified name and if that function return type is a class or enum, there
is possible ambiguity. The decla
vsk added inline comments.
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
// FIXME: Should this be picked by checking the target triple instead?
- if (Args.getLastArg(options::OPT_arch))
+ if ((A = Args.getLastArg(options::OPT_arch)))
return "cyclone";
-
On Wed, Aug 17, 2016 at 6:35 AM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Wed, Aug 17, 2016 at 01:05:08AM -, Richard Smith via cfe-commits
> wrote:
> > Author: rsmith
> > Date: Tue Aug 16 20:05:07 2016
> > New Revision: 278882
> >
> > URL: http://llvm.org/vi
llvm-config.h doesn't provide the necessary macros. I've applied a
different fix for out-of-tree builds in r279112.
On Wed, Aug 17, 2016 at 11:51 PM, Vedant Kumar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Done in clang/r279035.
>
> thanks,
> vedant
>
> > On Aug 17, 2016, at 7:43 AM,
Author: rsmith
Date: Thu Aug 18 13:22:22 2016
New Revision: 279112
URL: http://llvm.org/viewvc/llvm-project?rev=279112&view=rev
Log:
Use __has_include rather than a configure-time macro to determine if
is available. This should fix out-of-tree builds, at the cost
of not providing the higher rlimi
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D23628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
vsk added inline comments.
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
// FIXME: Should this be picked by checking the target triple instead?
- if (Args.getLastArg(options::OPT_arch))
+ if ((A = Args.getLastArg(options::OPT_arch)))
return "cyclone";
-
djasper accepted this revision.
djasper added a comment.
Looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D23602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added a subscriber: ahatanak.
ahatanak added a comment.
Thanks Vedant, this also fixes the crash that occurs when -mtune=native is
provided.
https://reviews.llvm.org/D14471.
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
// FIXME: Should this be picked
vsk accepted this revision.
vsk added a reviewer: vsk.
vsk added a comment.
This revision is now accepted and ready to land.
This lgtm. I haven't touched clang-format before, so it would be good to
double-check with the code owner before committing.
Repository:
rL LLVM
https://reviews.llvm.o
I shouldn't have assumed that this was correct because it built.
Reverted in r279097.
vedant
> On Aug 18, 2016, at 9:25 AM, Richard Smith wrote:
>
> This doesn't work at all, llvm-config.h does not provide the relevant
> configuration macros.
>
>
> On 17 Aug 2016 11:56 p.m., "Vedant Kumar v
Author: mren
Date: Thu Aug 18 12:42:15 2016
New Revision: 279096
URL: http://llvm.org/viewvc/llvm-project?rev=279096&view=rev
Log:
Module: add -fprebuilt-module-path to support loading prebuilt modules.
In this mode, there is no need to load any module map and the programmer can
simply use "@impo
Author: vedantk
Date: Thu Aug 18 12:43:02 2016
New Revision: 279097
URL: http://llvm.org/viewvc/llvm-project?rev=279097&view=rev
Log:
Revert "[Driver] Use llvm-config.h, not config.h to unbreak out-of-tree builds"
This reverts commit r279035. According to Richard Smith, llvm-config.h
does not con
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279096: Module: add -fprebuilt-module-path to support
loading prebuilt modules. (authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D23125?vs=68456&id=68570#toc
Repository:
rL LLVM
teemperor updated this revision to Diff 68568.
teemperor marked 2 inline comments as done.
teemperor added a comment.
- Added false-positives note for empty macros to the test suite.
https://reviews.llvm.org/D23316
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.c
teemperor marked 10 inline comments as done.
Comment at: lib/Analysis/CloneDetection.cpp:436
@@ +435,3 @@
+if (IsInMacro) {
+ Signature.Complexity = 0;
+}
NoQ wrote:
> omtcyfz wrote:
> > omtcyfz wrote:
> > > omtcyfz wrote:
> > > > NoQ wrote:
> > > > >
Author: cameron314
Date: Thu Aug 18 12:18:03 2016
New Revision: 279092
URL: http://llvm.org/viewvc/llvm-project?rev=279092&view=rev
Log:
[libclang] Added missing entry for newly introduced 'clang_getAllSkippedRanges'
to libclang.exports
Modified:
cfe/trunk/tools/libclang/libclang.exports
Mo
teemperor updated this revision to Diff 68556.
teemperor added a comment.
- Added more documentation to the CloneSignature::Complexity field.
- Macros now have a complexity value of 1 + sum(ChildComplexityValues).
- Tests should be less cryptic now.
https://reviews.llvm.org/D23316
Files:
incl
Ah, is that why! My fault, sorry. I couldn't figure out why it wouldn't
link on the build machines when it worked fine for me locally (on
Windows)...
Thank you, I will fix this shortly.
On Thu, Aug 18, 2016 at 12:52 PM, Will Dietz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> (Sending ag
On 18 Aug 2016 9:36 a.m., "Reid Kleckner" wrote:
>
> Clang isn't allowed to use LLVM's config.h, though, specifically to
support the standalone build.
>
> You can either create equivalent LLVM_ prefixed macros in
llvm-config.h.cmake, or repeat the checks and define the same macros in
clang/include
(Sending again, somehow the uiuc.edu mailing list address was in my
reply-all! Sorry for the duplicates :))
This breaks things for me, I think an entry in 'libclang.exports' is needed
for clang_getAllSkippedRanges ?
If that sounds right, can someone commit the fix?
Thanks! :)
~Will, he-who-buil
On Thu, Aug 18, 2016 at 8:43 AM, Cameron Desrochers via cfe-commits
wrote:
> Author: cameron314
> Date: Thu Aug 18 10:43:55 2016
> New Revision: 279076
>
> URL: http://llvm.org/viewvc/llvm-project?rev=279076&view=rev
> Log:
> [libclang] Add clang_getAllSkippedRanges function
>
> This complements t
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Clang isn't allowed to use LLVM's config.h, though, specifically to support
the standalone build.
You can either create equivalent LLVM_ prefixed macros in
llvm-config.h.cmake, or repeat the checks and define the same macros in
clang/include/clang/Config/config.h.cmake.
On Thu, Aug 18, 2016 at 9:
Author: cameron314
Date: Thu Aug 18 11:25:42 2016
New Revision: 279085
URL: http://llvm.org/viewvc/llvm-project?rev=279085&view=rev
Log:
[libclang] Fixed signed/unsigned comparison warning introduced in my revision
r279076
Modified:
cfe/trunk/unittests/libclang/LibclangTest.cpp
Modified: cf
This doesn't work at all, llvm-config.h does not provide the relevant
configuration macros.
On 17 Aug 2016 11:56 p.m., "Vedant Kumar via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: vedantk
> Date: Thu Aug 18 01:43:07 2016
> New Revision: 279035
>
> URL: http://llvm.org/viewvc/llvm
rnk added a comment.
Hm, resending my comments because it doesn't appear to work from email. I swear
it used to...
In https://reviews.llvm.org/D21959#519179, @guyblank wrote:
> Still, __XSAVE__ should have been defined when compiling for a target that
> supports the feature.
That's not how M
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279076: [libclang] Add clang_getAllSkippedRanges function
(authored by cameron314).
Changed prior to commit:
https://reviews.llvm.org/D20132?vs=56964&id=68548#toc
Repository:
rL LLVM
https://reviews
Author: cameron314
Date: Thu Aug 18 10:43:55 2016
New Revision: 279076
URL: http://llvm.org/viewvc/llvm-project?rev=279076&view=rev
Log:
[libclang] Add clang_getAllSkippedRanges function
This complements the clang_getSkippedRanges function which returns skipped
ranges filtered by a specific file
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-rename/USRFindingAction.cpp:69
@@ -69,2 +68,3 @@
}
-USRs->insert(USRs->end(), USRSet.begin(), USRSet.end());
+USRs.insert(USRs.end(), USRSet.begin(), USRSet.end
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D23361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
yaxunl marked an inline comment as done.
Comment at: lib/CodeGen/CGExprScalar.cpp:1513
@@ -1512,2 +1512,3 @@
// extension.
-llvm::Type *MiddleTy = CGF.IntPtrTy;
+auto DestLLVMTy = ConvertType(DestTy);
+llvm::Type *MiddleTy = CGF.CGM.getDataLayout().getIntPtrType(D
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:104
@@ +103,3 @@
+ const QualType T = Parm->getType();
+ if (!T->isPointerType() || T->getPointeeType().isCo
Anastasia added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1513
@@ -1512,2 +1512,3 @@
// extension.
-llvm::Type *MiddleTy = CGF.IntPtrTy;
+auto DestLLVMTy = ConvertType(DestTy);
+llvm::Type *MiddleTy = CGF.CGM.getDataLayout().getIntPtrType(DestLLVMT
john.brawn added a subscriber: john.brawn.
john.brawn added a comment.
> When my Java application calls clang_createIndex() with crash recovery
> enabled it replaces the JVM's segfault handler with
> CrashRecoverySignalHandler and now this handler gets all the segfault signals
> that would have
v.g.vassilev updated this revision to Diff 68536.
v.g.vassilev marked 2 inline comments as done.
v.g.vassilev added a comment.
Add setHidden(false) and update fixme.
https://reviews.llvm.org/D23492
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaTemplate.cpp
lib/Sema/SemaTemplateInstantiate
cameron314 added inline comments.
Comment at: unittests/libclang/LibclangTest.cpp:16-20
@@ -15,4 +15,7 @@
#include "gtest/gtest.h"
#include
#include
+#include
+#include
+#include
#define DEBUG_TYPE "libclang-test"
rsmith wrote:
> Please put these in alpha
danielmarjamaki updated this revision to Diff 68531.
danielmarjamaki added a comment.
Fixed review comments about formatting in doc
https://reviews.llvm.org/D15332
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/NonConstParameterCheck.cpp
clang-tidy/readability/NonCons
danielmarjamaki updated this revision to Diff 68528.
danielmarjamaki marked 2 inline comments as done.
danielmarjamaki added a comment.
Fixed review comments
https://reviews.llvm.org/D15332
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/NonConstParameterCheck.cpp
clan
rogfer01 created this revision.
rogfer01 added reviewers: aaron.ballman, rsmith.
rogfer01 added a subscriber: cfe-commits.
This change remove some false positives when taking the address of packed
members.
- It silences the warning when a cast to uintptr_t/intptr_t happens.
- If the field is in
Author: dergachev
Date: Thu Aug 18 07:29:41 2016
New Revision: 279056
URL: http://llvm.org/viewvc/llvm-project?rev=279056&view=rev
Log:
[analyzer] Teach CloneDetector to find clones that look like copy-paste errors.
The original clone checker tries to find copy-pasted code that is exactly
identic
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279056: [analyzer] Teach CloneDetector to find clones that
look like copy-paste errors. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D23314?vs=68422&id=68518#toc
Repositor
Author: aaronballman
Date: Thu Aug 18 07:26:17 2016
New Revision: 279055
URL: http://llvm.org/viewvc/llvm-project?rev=279055&view=rev
Log:
Correct the documentation for isSignedInteger() and isUnsignedInteger().
Patch by Visoiu Mistrih Francis
Modified:
cfe/trunk/docs/LibASTMatchersReference
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r279055
https://reviews.llvm.org/D23641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
On second thought, in `RangeConstraintManager` we need a different
functionality. In particular, from `4 * x < 1000` it does not follow that `x <
250` in the general case (due to possible overflows). But in the case of this
checker, it doesn't matter - we are always sure th
thegameg added a comment.
Can you commit this for me, please? Thanks!
https://reviews.llvm.org/D23641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D23641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
1 - 100 of 129 matches
Mail list logo
