Done in r277425.
-Dimitry
> On 01 Aug 2016, at 22:50, Hans Wennborg wrote:
>
> Go ahead (or let me know if you'd prefer me to do it).
>
> Cheers,
> Hans
>
> On Sun, Jul 31, 2016 at 1:37 PM, Dimitry Andric wrote:
>> Hi Hans,
>>
>> I would like to merge this one to release_39, since it fixes
mstorsjo added inline comments.
Comment at: lib/Headers/armintr.h:26
@@ +25,3 @@
+#ifndef _MSC_VER
+#include_next
+#else
compnerd wrote:
> Hmm, why not do __has_header instead? armv7-windows-itanium won't define
> `_MSC_VER` but you may have the header from the
Hi,
What I mean is the spec of spir 1.2/2.0 has very clear example about how the
metadata should organized. But now with this patch, the result of spir is
changed and not like it before. So what I want to know is why we change the old
spir example style code, but not add something alongside.
No
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: ioeric, bkramer, hokein.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I tested this changes on my RHEL 6 build.
Repository:
rL LLVM
https://reviews.llvm.org/
vsk closed this revision.
vsk added a comment.
Done in clang/r246054
https://reviews.llvm.org/D12344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added a comment.
Ping.
https://reviews.llvm.org/D7
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Done in clang/r257092
https://reviews.llvm.org/D15853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
vsk closed this revision.
vsk added a comment.
Closing old review
https://reviews.llvm.org/D15853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Aug 1, 2016 at 9:36 AM, Alexander Kornienko
wrote:
> Please revert or fix (or better revert and then post another patch for
> review).
>
Kirill reverted it in SVN r277354.
--
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
___
cfe-commits
This is the IR I see in today’s trunk:
*** IR Dump Before Module Verifier ***
; Function Attrs: noinline optsize ssp
define i32 @_ZThn4_N1C4SeekE6_LARGE(%class.C* %this, %union._LARGE* byval align
4) unnamed_addr #2 align 2 {
entry:
%L = alloca %union._LARGE, align 8
%this.addr = alloca %clas
tra added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4834
@@ -4831,2 +4833,3 @@
+getDriver().Diag(diag::err_drv_cuda_nvptx_host);
}
return DAL;
jlebar wrote:
> IRL we talked about putting an assert() here and bailing out earlier. Does
> tha
jlebar added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4834
@@ -4831,2 +4833,3 @@
+getDriver().Diag(diag::err_drv_cuda_nvptx_host);
}
return DAL;
IRL we talked about putting an assert() here and bailing out earlier. Does
that not work?
My
compnerd added inline comments.
Comment at: lib/Headers/armintr.h:26
@@ +25,3 @@
+#ifndef _MSC_VER
+#include_next
+#else
Hmm, why not do __has_header instead? armv7-windows-itanium won't define
`_MSC_VER` but you may have the header from the SDK.
https://revi
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
It does not make sense and violates enough assumptions in the code to crash
compiler.
https://reviews.llvm.org/D23042
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains.cpp
jfb created this revision.
jfb added a reviewer: EricWF.
jfb added a subscriber: cfe-commits.
The ABI version flag should fix the error.
https://reviews.llvm.org/D23041
Files:
test/libcxx/atomics/atomics.align/align.pass.sh.cpp
test/libcxx/test/config.py
Index: test/libcxx/test/config.py
==
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please add install rule for clang-rename.el. See clang-rename CMakeLists.txt as
example.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lis
Reverted in r277405 since the LLVM change got reverted.
For what it's worth, it would have been great if this commit mentioned
that it was a companion commit to r276895. That would give some nice
context for anyone reading the log, and also I wouldn't have missed it
when reverting the LLVM side.
Author: jfb
Date: Mon Aug 1 18:34:29 2016
New Revision: 277404
URL: http://llvm.org/viewvc/llvm-project?rev=277404&view=rev
Log:
NFC: fix typo
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config.py
URL:
http://llvm.org/viewvc/llvm-project/libcxx
Author: hans
Date: Mon Aug 1 18:34:42 2016
New Revision: 277405
URL: http://llvm.org/viewvc/llvm-project?rev=277405&view=rev
Log:
Revert r276896 "Update Clang Parser test error message to match new parser
errors"
This depended on r276895, which was reverted in r277402.
Modified:
cfe/trunk/
Author: cbieneman
Date: Mon Aug 1 17:54:00 2016
New Revision: 277401
URL: http://llvm.org/viewvc/llvm-project?rev=277401&view=rev
Log:
[Order Files] Fixing an error in the perf-helper script
Dtrace probemod needs to be based on the first argument of the command, not the
first argument of the ar
jlebar added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4773
@@ +4772,3 @@
+ StringRef GpuArch =
+ DriverArgs.getLastArgValue(options::OPT_march_EQ, "sm_20");
+ std::string LibDeviceFile = CudaInstallation.getLibDeviceFile(GpuArch);
Hm. I total
tra updated this revision to Diff 66392.
tra added a comment.
Added tests for libdevice mapping correctness.
https://reviews.llvm.org/D23037
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains.cpp
test/Driver/Inputs/CUDA_80/usr/local/cuda/nvvm/libdevice/libdevice.co
tra added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4773
@@ +4772,3 @@
+ StringRef GpuArch =
+ DriverArgs.getLastArgValue(options::OPT_march_EQ, "sm_20");
+ std::string LibDeviceFile = CudaInstallation.getLibDeviceFile(GpuArch);
jlebar wrote:
>
Author: probinson
Date: Mon Aug 1 17:12:46 2016
New Revision: 277396
URL: http://llvm.org/viewvc/llvm-project?rev=277396&view=rev
Log:
Add FIXMEs for MSVC 2013 hacks in r277211. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
URL:
jlebar added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4773
@@ +4772,3 @@
+ StringRef GpuArch =
+ DriverArgs.getLastArgValue(options::OPT_march_EQ, "sm_20");
+ std::string LibDeviceFile = CudaInstallation.getLibDeviceFile(GpuArch);
I *think* ma
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
This makes clang's libdevice selection match that of NVCC as described in
http://docs.nvidia.com/cuda/libdevice-users-guide/basic-usage.html#version-selection
If required libdevice variant is not found,
Author: compnerd
Date: Mon Aug 1 16:31:24 2016
New Revision: 277390
URL: http://llvm.org/viewvc/llvm-project?rev=277390&view=rev
Log:
CodeGen: simplify the CC handling for TLS wrappers
Use the calling convention of the wrapper directly to set the calling convention
to ensure that the calling con
Prazek added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
@@ -95,1 +114,3 @@
+ auto CtorCallSourceRange = CharSourceRange::getTokenRange(
+ InnerCtorCall->getExprLoc(), CallParensRange.getBegin());
alexfh wrote:
> Prazek wrote:
dcoughlin added a comment.
It's really great to see this!
Comment at: lib/Sema/SemaExpr.cpp:15200
@@ -15182,2 +15199,3 @@
// platform.
-Diag(AtLoc, diag::warn_available_using_star_case) << RParen << Platform;
+Diag(AtLoc, diag::warn_available_using_star_case)
+
Prazek added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.h:36-37
@@ -32,1 +35,4 @@
+private:
+ std::vector ContainersWithPushBack;
+ std::vector SmartPointers;
};
aaron.ballman wrote:
> What about `llvm::make_range()`?
llvm::make_range do
Go ahead (or let me know if you'd prefer me to do it).
Cheers,
Hans
On Sun, Jul 31, 2016 at 1:37 PM, Dimitry Andric wrote:
> Hi Hans,
>
> I would like to merge this one to release_39, since it fixes a few third
> party programs using cpuid.h, and expecting gcc-compatible CPUID bit macros.
>
> -
Merged in r277384.
Cheers,
Hans
On Fri, Jul 29, 2016 at 5:33 PM, Eric Christopher wrote:
> Hi Hans,
>
> Can you make sure this makes it into 3.9 please?
>
> Thanks!
>
> -eric
>
>
> On Fri, Jul 29, 2016 at 3:18 PM Eric Christopher via cfe-commits
> wrote:
>>
>> Author: echristo
>> Date: Fri Jul
I don't think I can:
- Hack around __gcc_atomic_t.
- Unconditionally pass -fabi-version=6 to the RUN command (because LLVM
won't accept it).
it seems like changing test/libcxx/test/config.py would be better.
WDYT?
On Mon, Aug 1, 2016 at 1:28 PM, JF Bastien via cfe-commits <
cfe-commits
Thanks!
-eric
On Mon, Aug 1, 2016 at 1:41 PM Hans Wennborg wrote:
> Merged in r277384.
>
> Cheers,
> Hans
>
> On Fri, Jul 29, 2016 at 5:33 PM, Eric Christopher
> wrote:
> > Hi Hans,
> >
> > Can you make sure this makes it into 3.9 please?
> >
> > Thanks!
> >
> > -eric
> >
> >
> > On Fri, Jul 2
Merged in r277385.
Cheers,
Hans
On Fri, Jul 29, 2016 at 3:58 PM, Piotr Padlewski
wrote:
> It would be very good to import this patch to clang-tidy-3.9
>
>
> -- Forwarded message --
> From: Piotr Padlewski
> Date: 2016-07-28 19:18 GMT-07:00
> Subject: Re: [Diffusion] rL277097: [c
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jfb
Date: Mon Aug 1 15:28:13 2016
New Revision: 277380
URL: http://llvm.org/viewvc/llvm-project?rev=277380&view=rev
Log:
atomics.align: XFAIL GCC
It currently fails because GCC changed the mangling of templates, which affects
std::atomic using __attribute__((vector(X))). The bot using G
omtcyfz updated this revision to Diff 66373.
omtcyfz added a comment.
Apply `clang-format` to fit 80 cols limit.
https://reviews.llvm.org/D22853
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/TemplateTypenameFindByTemplateParam.cpp
test/clang-rename/Te
omtcyfz marked 3 inline comments as done.
omtcyfz added a comment.
https://reviews.llvm.org/D22853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 66372.
omtcyfz added a comment.
Addressed comments; updated to the latest revision.
https://reviews.llvm.org/D22853
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/TemplateTypenameFindByTemplateParam.cpp
test/clang-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277378: [ObjC Availability] Fix partial-availability false
positive introduced in… (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D23024?vs=66348&id=66370#toc
Repository:
rL L
Author: epilk
Date: Mon Aug 1 15:19:49 2016
New Revision: 277378
URL: http://llvm.org/viewvc/llvm-project?rev=277378&view=rev
Log:
[ObjC Availability] Fix partial-availability false positive introduced in
r277058
Thanks to Nico Weber for pointing this out!
Differential revision: https://review
On Tue, Jul 26, 2016 at 4:37 PM Laxman Sole via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> laxmansole created this revision.
> laxmansole added reviewers: mclow.lists, howard.hinnant.
> laxmansole added subscribers: cfe-commits, sebpop, hiraditya, evandro,
> flyingforyou.
>
>
> Currently b
Ping
On Mon, Jul 25, 2016 at 10:24 AM David Blaikie wrote:
> Ping?
>
> On Mon, Jul 18, 2016 at 11:28 AM David Blaikie wrote:
>
>> What build problem did this cause? Did this just not compile (it looks as
>> if ArgList has hasArg and hasFlag, so I'm not sure what the specific
>> problem might've
vmiklos added a comment.
Rebased on top of r277356 and resolved conflicts. (A busy day, it seems. :-) )
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: bcraig
Date: Mon Aug 1 14:56:39 2016
New Revision: 277373
URL: http://llvm.org/viewvc/llvm-project?rev=277373&view=rev
Log:
Adding smart_ptr benchmark
Initial draft here:
https://reviews.llvm.org/D22470
... though this is Eric Fiselier's rewrite to fit in with Google
Benchmark.
Added:
vmiklos updated this revision to Diff 66362.
https://reviews.llvm.org/D21814
Files:
clang-rename/RenamingAction.cpp
clang-rename/RenamingAction.h
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassTestMulti.cpp
test/c
NoQ updated this revision to Diff 66360.
NoQ added a comment.
Copy-paste the code from CGDebugInfo.cpp to support Objective-C instance and
class methods. Add more tests. Move the `analyze_display_progress.cpp` because
most tests use dashes in names.
https://reviews.llvm.org/D22856
Files:
li
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:177
@@ +176,3 @@
+ if (ExplodedNode *N = C.addTransition(State))
+reportLeakedVALists(LeakedVALists, "Initialized va_list", " is leaked", C,
+N);
---
rnk added a comment.
So, if clang were to use a temporary alloca for the byval parameter, then yes,
I agree marking it as a tail call would be incorrect. However, clang doesn't
use an alloca, it forwards the byval pointer parameter directly to the callee:
define i32 @_ZThn4_N1C4SeekE6_LARGE(%
I forwarded your the thread for the DSE path. Even my original intent for was a
short-term bandage and by no means a long term fix.
> On Aug 1, 2016, at 10:53 AM, Reid Kleckner wrote:
>
> rnk added a comment.
>
> I think the correctness problem is in DSE. It should be safe for clang to put
>
Prazek added a comment.
In https://reviews.llvm.org/D22725#502374, @JDevlieghere wrote:
> Addressed comments from Piotr Padlewski
>
> LLVM compiles with the latest version of this check, however some tests are
> failing. I'll investigate the cause of this and update this check if it can
> be pr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277368: libc++: test lock-free atomic alignment (authored by
jfb).
Changed prior to commit:
https://reviews.llvm.org/D22073?vs=66342&id=66356#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22073
Author: jfb
Date: Mon Aug 1 14:27:08 2016
New Revision: 277368
URL: http://llvm.org/viewvc/llvm-project?rev=277368&view=rev
Log:
libc++: test lock-free atomic alignment
Summary:
libc++ implements std::atomic<_Tp> using __atomic_base<_Tp> with
`mutable _Atomic(_Tp) __a_`. That member must be suit
ariccio added a comment.
Bump?
https://reviews.llvm.org/D18073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Mon Aug 1 13:56:13 2016
New Revision: 277367
URL: http://llvm.org/viewvc/llvm-project?rev=277367&view=rev
Log:
[codeview] Skip injected class names in nested record emission
We were already trying to do this, but our check wasn't quite right.
Fixes PR28790
Added:
cfe/trun
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks for the quick fix!
https://reviews.llvm.org/D23024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
erik.pilkington created this revision.
erik.pilkington added reviewers: manmanren, thakis.
erik.pilkington added a subscriber: cfe-commits.
As of r277058, Clang would incorrectly emit -Wpartial-availability for the
following (when compiled with -mmacosx-verison-min=10.6):
```
int fn_10_5() __att
JDevlieghere updated this revision to Diff 66350.
JDevlieghere added a comment.
Addressed comments from Piotr Padlewski
Repository:
rL LLVM
https://reviews.llvm.org/D22725
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseAl
Author: evandro
Date: Mon Aug 1 13:39:55 2016
New Revision: 277365
URL: http://llvm.org/viewvc/llvm-project?rev=277365&view=rev
Log:
[AArch64] Add support for Samsung Exynos M2 (NFC).
Modified:
cfe/trunk/test/CodeGen/arm-target-features.c
cfe/trunk/test/Driver/aarch64-cpus.c
cfe/trun
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
include-fixer will firstly try to use scoped namespace context information to
search identifier. However, in some cases, it's unsafe to do nested class
search, because it might treat the identif
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D22927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
jfb added a comment.
In https://reviews.llvm.org/D22073#486636, @EricWF wrote:
> OK, IMO the way to handle this test is to have it manually link `-latomic`.
> This can be done by renaming the test to `.sh.cpp` and adding the
> following lines:
>
> // REQUIRES: libatomic
> // RUN: %build -la
jfb updated this revision to Diff 66342.
jfb added a comment.
- Move atomics.align to libcxx-specific
- Give names to anonymous structs
- Rename test, use REQUIRES / RUN commands
https://reviews.llvm.org/D22073
Files:
test/libcxx/atomics/atomics.align/align.pass.sh.cpp
Index: test/libcxx/ato
Hi Xiuli,
Could you please elaborate what do you think it broken exactly?
Because we haven't actually removed opencl.kernels metadata but just changed
the format of it.
Basically, we are using function metadata instead of generic metadata as it was
before.
Thanks,
Anastasia
-Original Me
LokiAstari added a comment.
@djasper@klimek
Just want to bring this to the top of your queue again :-)
Any further thoughts on the processes?
Loki
https://reviews.llvm.org/D22505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
bcraig closed this revision.
bcraig added a comment.
committed https://reviews.llvm.org/rL277357: Improve shared_ptr dtor
performance.
https://reviews.llvm.org/D22470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: bcraig
Date: Mon Aug 1 12:51:26 2016
New Revision: 277357
URL: http://llvm.org/viewvc/llvm-project?rev=277357&view=rev
Log:
Improve shared_ptr dtor performance
If the last destruction is uncontended, skip the atomic store on
__shared_weak_owners_. This shifts some costs from normal
share
rnk added a comment.
I think Nick was responsible for adding this DSE optimization *years* ago.
https://reviews.llvm.org/D22900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
I think the correctness problem is in DSE. It should be safe for clang to put
'tail' here. The tail call does not capture the address of any local variables,
but it does load from them via 'byval'.
https://reviews.llvm.org/D22900
Hi Erik,
with this change clangs warns on this program:
$ cat test.mm
#import
@interface AXPlatformNodeCocoa : NSObject
@end
@implementation AXPlatformNodeCocoa
- (NSArray*)accessibilityAttributeNames {
NSArray* const kTextfieldAttributes = @[
NSAccessibilityPlaceholderValueAttribute,
];
bcraig added a comment.
I am going to submit the code changes and the tests independently. I'm having
trouble getting cmake to use the right compiler for the libcxx-benchmarks
target.
https://reviews.llvm.org/D22470
___
cfe-commits mailing list
c
omtcyfz added inline comments.
Comment at: clang-rename/USRFinder.cpp:80
@@ -79,1 +79,3 @@
TypeBeginLoc, 0, Context.getSourceManager(), Context.getLangOpts());
+if (const auto *TemplateTypeParm =
dyn_cast(Loc.getType())) {
+ return setResult(TemplateTypeParm->ge
Author: omtcyfz
Date: Mon Aug 1 12:15:57 2016
New Revision: 277356
URL: http://llvm.org/viewvc/llvm-project?rev=277356&view=rev
Log:
[clang-rename] handle overridden functions correctly
1. Renaming overridden functions only works for two levels of "overriding
hierarchy". clang-rename should r
omtcyfz marked 2 inline comments as done.
Comment at: clang-rename/tool/clang-rename.el:28
@@ +27,3 @@
+(orig-buf (current-buffer))
+(file-name (buffer-file-name)))
+
alexfh wrote:
> For posterity, please add a short summary of the offline discussi
omtcyfz updated this revision to Diff 66341.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clang-rename.rst
+++ docs/clang-rename.rst
@@
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277356: [clang-rename] handle overridden functions correctly
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23009?vs=66338&id=66340#toc
Repository:
rL LLVM
https://reviews
alexfh added inline comments.
Comment at: clang-rename/tool/clang-rename.el:28
@@ +27,3 @@
+(orig-buf (current-buffer))
+(file-name (buffer-file-name)))
+
For posterity, please add a short summary of the offline discussion.
Commen
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-rename/USRFinder.cpp:80
@@ -79,1 +79,3 @@
TypeBeginLoc, 0, Context.getSourceManager(), Context.getLangOpts());
+if (const auto *TemplateTypeParm =
dyn_cast(Loc
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D23009
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh added a subscriber: alexfh.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2440
@@ +2439,3 @@
+
+ return (UnderlyingDecl != nullptr &&
+ InnerMatcher.matches(*UnderlyingDecl, Finder, Builder));
nit: Parentheses are superfluous here.
omtcyfz updated this revision to Diff 66338.
omtcyfz marked an inline comment as done.
https://reviews.llvm.org/D23009
Files:
clang-rename/USRFindingAction.cpp
test/clang-rename/FunctionOverride.cpp
Index: test/clang-rename/FunctionOverride.cpp
===
Author: omtcyfz
Date: Mon Aug 1 11:48:33 2016
New Revision: 277354
URL: http://llvm.org/viewvc/llvm-project?rev=277354&view=rev
Log:
[clang-rename] revert r276836
Revert r276836, which resulted in tests passing regardless of the actual tool
replacements.
Modified:
clang-tools-extra/trunk/
Author: majnemer
Date: Mon Aug 1 11:39:29 2016
New Revision: 277352
URL: http://llvm.org/viewvc/llvm-project?rev=277352&view=rev
Log:
[Parse] Let declarations follow labels in -fms-extensions mode
MSVC permits declarations in these places as conforming extension (it is
a constraint violation oth
On Wed, Jul 27, 2016 at 6:43 AM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Tue Jul 26 23:43:15 2016
> New Revision: 276836
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276836&view=rev
> Log:
> test: simplify commands, NFC
>
> Rather than
On Sun, Jul 31, 2016 at 10:32 PM, Gerolf Hoflehner
wrote:
>
> > On Jul 31, 2016, at 1:46 AM, Amjad Aboud wrote:
> >
> > aaboud added a comment.
> >
> >> ISTM that the DWARF spec intended such thunks to be encoded as
> `DW_AT_trampoline`. That seems more appropriate than relying on codegen
> emi
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/clang-rename/FunctionOverride.cpp:3
@@ +2,3 @@
+
+class A { virtual void foo(); };// CHECK: class A { virtual void boo(); };
+class B : public A { void foo(); }; // CHECK
omtcyfz added a comment.
All the comments seem to be addressed.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> On Jul 30, 2016, at 12:59 PM, Joerg Sonnenberger via cfe-commits
> wrote:
>
> On Thu, Jul 28, 2016 at 10:11:05PM +, Vedant Kumar wrote:
>> - test/Driver/netbsd.c
>>
>>We see -mcpu=arm1022e instead of arm926ej-s in a single run.
>
> Which one exactly?
Here is the test (test/Driver/
omtcyfz updated this revision to Diff 66328.
omtcyfz marked 8 inline comments as done.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clan
omtcyfz added inline comments.
Comment at: clang-rename/tool/clang-rename.el:20
@@ +19,3 @@
+ "Rename all instances of the symbol at the point using clang-rename"
+ (interactive "sEnter a new name: ")
+ (let (;; Emacs offset is 1-based.
hokein wrote:
> `s` is a
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh added inline comments.
Comment at: clang-rename/tool/clang-rename.el:18
@@ +17,3 @@
+
+(defun clang-rename-upstream (new-name)
+ "Rename all instances of the symbol at the point using clang-rename"
The name should be just "clang-rename".
hokein added inline comments.
Comment at: clang-rename/tool/clang-rename.el:16
@@ +15,3 @@
+
+(defvar clang-rename-binary "clang-rename")
+
I think we should make `clang-rename` binary path configurable by making it a
custom variable (using `defcustom`).
===
sepavloff created this revision.
sepavloff added a subscriber: cfe-commits.
Function specializations used in friend declarations in class templates, like:
```
template class C1 {
friend void func<>(int);
```
previously were processed incorrectly: class instantiation made them ordinary
xazax.hun added inline comments.
Comment at: test/Analysis/NewDelete-checker-test.cpp:394
@@ +393,3 @@
+ Derived *p = (Derived *)allocate();
+ delete p;
+}
Before the modification the analyzer reports a leak here, since the symbol
returned by the BaseToDerived
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin, dergachev.a, a.sidorin.
xazax.hun added a subscriber: cfe-commits.
Dynamic casts are handled relatively well by the static analyzer. BaseToDerived
casts however are handled conservatively. This can cause some false
teemperor updated this revision to Diff 66309.
teemperor added a comment.
- s/super class/base class/g
https://reviews.llvm.org/D22514
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
test/Analysis/copypaste/asm.cpp
test/Analysis/copypaste/attributes.cpp
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D22774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
teemperor updated this revision to Diff 66308.
teemperor added a comment.
- No longer re-initialize memory created from resize().
- Added test for checking that StmtDataCollector visits all parent classes.
https://reviews.llvm.org/D22514
Files:
include/clang/Analysis/CloneDetection.h
lib/An
1 - 100 of 150 matches
Mail list logo
