Author: jlebar
Date: Fri Jul 29 00:26:58 2016
New Revision: 277113
URL: http://llvm.org/viewvc/llvm-project?rev=277113&view=rev
Log:
[Typo police] s/proccess/process/, s/auxiliary/auxilliary/.
Modified:
cfe/trunk/include/clang/AST/Decl.h
Modified: cfe/trunk/include/clang/AST/Decl.h
URL:
htt
Author: jlebar
Date: Fri Jul 29 00:26:58 2016
New Revision: 277113
URL: http://llvm.org/viewvc/llvm-project?rev=277113&view=rev
Log:
[Typo police] s/proccess/process/, s/auxiliary/auxilliary/.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
Modified: clang-tools-
ABataev created this revision.
ABataev added reviewers: rnk, rsmith, majnemer.
ABataev added subscribers: cfe-commits, andreybokhanko.
MSVC actively uses unqualified lookup in dependent bases, lookup at the
instantiation point (non-dependent names may be resolved on things declared
later) etc. a
hubert.reinterpretcast added a comment.
In https://reviews.llvm.org/D22668#499164, @aaron.ballman wrote:
> I don't suppose there's a way to test these changes, is there?
It's a utility class (which is not even used yet). I am not aware of testing
for the ADTs, etc. aside from using them intern
hfinkel added a comment.
In https://reviews.llvm.org/D22666#500338, @honggyu.kim wrote:
> In https://reviews.llvm.org/D22666#500329, @hfinkel wrote:
>
> > In this case, I think that making a simple test (changing the current test
> > to be) like test/CodeGen/stackrealign.c would be fine. If you
honggyu.kim added a comment.
In https://reviews.llvm.org/D22666#500329, @hfinkel wrote:
> In this case, I think that making a simple test (changing the current test to
> be) like test/CodeGen/stackrealign.c would be fine. If you have any
> questions, please feel free to ask.
Thanks. Please co
Gerolf updated this revision to Diff 66075.
Gerolf added a comment.
Reduced test case.
https://reviews.llvm.org/D22900
Files:
lib/CodeGen/CGVTables.cpp
test/CodeGenCXX/microsoft-abi-structors.cpp
test/CodeGenCXX/tail-byval.cpp
Index: test/CodeGenCXX/tail-byval.cpp
===
hubert.reinterpretcast added inline comments.
Comment at: include/llvm/Support/MathExtras.h:672
@@ -669,2 +671,3 @@
inline uint64_t alignTo(uint64_t Value, uint64_t Align, uint64_t Skew = 0) {
+ assert(Align != 0u);
Skew %= Align;
aaron.ballman wrote:
> Usual
hfinkel added a comment.
In https://reviews.llvm.org/D22666#500328, @honggyu.kim wrote:
> In https://reviews.llvm.org/D22666#500327, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D22666#500326, @honggyu.kim wrote:
> >
> > > Should we also modify clang/test/CodeGen/mcount.c as well? I'm not
honggyu.kim added a comment.
In https://reviews.llvm.org/D22666#500327, @rjmccall wrote:
> In https://reviews.llvm.org/D22666#500326, @honggyu.kim wrote:
>
> > Should we also modify clang/test/CodeGen/mcount.c as well? I'm not
> > actually familiar with test infra.
>
>
> Yes, you'll need to mod
rjmccall added a comment.
In https://reviews.llvm.org/D22666#500326, @honggyu.kim wrote:
> Should we also modify clang/test/CodeGen/mcount.c as well? I'm not actually
> familiar with test infra.
Yes, you'll need to modify it to test for the attribute instead.
https://reviews.llvm.org/D22666
honggyu.kim added a comment.
Should we also modify clang/test/CodeGen/mcount.c as well? I'm not actually
familiar with test infra.
$ cat llvm/tools/clang/test/CodeGen/mcount.c
// RUN: %clang_cc1 -pg -triple i386-unknown-unknown -emit-llvm -o - %s |
FileCheck %s
// RUN: %clang_cc1 -pg -tr
zlei added a comment.
@rengolin Thanks for your comments. Patch updated.
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zlei updated this revision to Diff 66074.
zlei added a comment.
Restructure the code and add a few tests.
https://reviews.llvm.org/D22904
Files:
lib/Driver/ToolChains.cpp
test/Driver/linux-ld.c
Index: test/Driver/linux-ld.c
==
honggyu.kim marked 4 inline comments as done.
honggyu.kim added a comment.
In https://reviews.llvm.org/D22666#499583, @hfinkel wrote:
> Comments about the comment, but otherwise, LGTM.
Just updated the comment as you mentioned. Thanks for correcting my English :)
https://reviews.llvm.org/D226
honggyu.kim updated the summary for this revision.
honggyu.kim updated this revision to Diff 66072.
https://reviews.llvm.org/D22666
Files:
lib/CodeGen/CodeGenFunction.cpp
Index: lib/CodeGen/CodeGenFunction.cpp
===
--- lib/CodeGen/
Author: prazek
Date: Thu Jul 28 21:10:23 2016
New Revision: 277097
URL: http://llvm.org/viewvc/llvm-project?rev=277097&view=rev
Log:
[clang-tidy] Fixes to modernize-use-emplace
Not everything is valid, but it should works for 99.8% cases
https://reviews.llvm.org/D22208
Modified:
clang-tools
Sorry, I was supposed to chime in here.
I don't have a strong opinion on this, but I don't think it's a
problem for us to allow the -gline-tables-only spelling in addition to
/Zd.
It just doesn't seem like a big deal to me.
On Mon, Jul 11, 2016 at 5:50 PM, Saleem Abdulrasool via cfe-commits
wro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277095: [Parser] Fix bug where delayed typo in conditional
expression was corrected… (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D22930?vs=65965&id=66067#toc
Repository:
rL
Author: epilk
Date: Thu Jul 28 19:55:40 2016
New Revision: 277095
URL: http://llvm.org/viewvc/llvm-project?rev=277095&view=rev
Log:
[Parser] Fix bug where delayed typo in conditional expression was corrected
twice
Patch by David Tarditi!
Differential revision: https://reviews.llvm.org/D22930
M
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D22930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: wolfgangp
Date: Thu Jul 28 19:54:13 2016
New Revision: 277094
URL: http://llvm.org/viewvc/llvm-project?rev=277094&view=rev
Log:
Change a test to be less prone to random failures due to
unintended matches of label numbers to debug metadata
handles in release builds.
Modified:
cfe/trunk
teemperor marked an inline comment as done.
Comment at: lib/Analysis/CloneDetection.cpp:134
@@ +133,3 @@
+ DEF_ADD_DATA(Stmt, { addData(S->getStmtClass()); })
+ DEF_ADD_DATA(Expr, { addData(S->getType()); })
+
NoQ wrote:
> I noticed something: with this patch, y
Author: vedantk
Date: Thu Jul 28 18:22:42 2016
New Revision: 277081
URL: http://llvm.org/viewvc/llvm-project?rev=277081&view=rev
Log:
[docs] Coverage: Reference the new -output-dir option
Modified:
cfe/trunk/docs/SourceBasedCodeCoverage.rst
Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rs
Author: vedantk
Date: Thu Jul 28 18:18:48 2016
New Revision: 277080
URL: http://llvm.org/viewvc/llvm-project?rev=277080&view=rev
Log:
[docs] Mention some new options in llvm-cov
Modified:
cfe/trunk/docs/SourceBasedCodeCoverage.rst
Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst
URL:
ht
sfantao created this revision.
sfantao added a reviewer: tra.
sfantao added a subscriber: cfe-commits.
Add test to detect the C++ include paths are passed to both CUDA host and
device frontends.
https://reviews.llvm.org/D22946
Files:
test/Driver/cuda-simple.cu
Index: test/Driver/cuda-simple.
The change seems straight-forward, well reviewed and has been in the
tree for a while, so I've merged it to 3.9 in r277075.
Thanks,
Hans
On Mon, Jul 25, 2016 at 1:51 PM, Hans Wennborg wrote:
> Should me merge this to 3.9?
>
> On Mon, Jul 25, 2016 at 10:17 AM, Sunil Srivastava via cfe-commits
>
Author: epilk
Date: Thu Jul 28 17:51:11 2016
New Revision: 277070
URL: http://llvm.org/viewvc/llvm-project?rev=277070&view=rev
Log:
Revert "[ObjC] Consider availability of context when emitting availability
warnings"
Reverting r277058, while I fugure out why it broke internal bots.
This reverts
+Bruno
> On Jul 27, 2016, at 11:58 PM, Nico Weber wrote:
>
> I played with modules a bit today, and as far as I can tell this is still
> broken. If this proves difficult to fix, should this change be reverted for
> now? It breaks using modules on Darwin.
>
> On Sun, Mar 13, 2016 at 12:53 AM, A
sfantao added a comment.
In https://reviews.llvm.org/D22518#500066, @tra wrote:
> Samuel, the patch breaks CUDA. With the patch clang no longer adds include
> paths to standard c++ library during device-side compilation.
> if you run "clang++ -### -c -x cuda /dev/null" you will see that host si
Author: sfantao
Date: Thu Jul 28 17:42:42 2016
New Revision: 277064
URL: http://llvm.org/viewvc/llvm-project?rev=277064&view=rev
Log:
[CUDA] Unswitch enumerators in the selection of the offloading tool chain.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
U
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277058: [ObjC] Consider availability of context when
emitting availability warnings (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D22697?vs=65595&id=66037#toc
Repository:
rL
tra added a comment.
Samuel, the patch breaks CUDA. With the patch clang no longer adds include
paths to standard c++ library during device-side compilation.
if you run "clang++ -### -c -x cuda /dev/null" you will see that host side gets
`"-internal-isystem"
"/usr/lib/gcc/x86_64-linux-gnu/4.8/.
vsk created this revision.
vsk added reviewers: echristo, dexonsmith.
vsk added a subscriber: cfe-commits.
Herald added subscribers: mehdi_amini, srhines, danalbert, tberghammer.
Wherever possible, replace:
- getToolChain.getArch() with .getArch()
- getToolChain.getTriple() with
On my end,
Author: epilk
Date: Thu Jul 28 17:09:53 2016
New Revision: 277058
URL: http://llvm.org/viewvc/llvm-project?rev=277058&view=rev
Log:
[ObjC] Consider availability of context when emitting availability warnings
This means that a function marked with an availability attribute can safely
refer to a de
vsk created this revision.
vsk added reviewers: echristo, dexonsmith.
vsk added a subscriber: cfe-commits.
Herald added subscribers: mehdi_amini, srhines, danalbert, tberghammer.
No functionality change is intended. This set of replacements is fairly
targeted -- hopefully this makes it easier to v
vsk created this revision.
vsk added reviewers: echristo, dexonsmith.
vsk added subscribers: joerg, rengolin, cfe-commits.
Herald added subscribers: mehdi_amini, aemerson.
... even though we *should* be able to.
If we used effective triples at the marked sites, we would fail:
- test/Driver/{da
sfantao added a comment.
Any more comments on this patch or depending ones?
Thanks!
Samuel
https://reviews.llvm.org/D18172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 66021.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21848
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/ToolChain.h
lib/Driver/Compilation.cpp
lib/Driver/Driver.cpp
lib/Driver/MSVCToolChain.cpp
lib/Driver/ToolCha
sfantao updated this revision to Diff 66029.
sfantao added a comment.
- Fix type qualifier.
- Rebase.
https://reviews.llvm.org/D21857
Files:
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
include/clang/Driver/Tool.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver
sfantao updated this revision to Diff 66028.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/Driver/
sfantao updated this revision to Diff 66026.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21852
Files:
include/clang/Driver/Action.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
=
sfantao updated this revision to Diff 66027.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21853
Files:
include/clang/Driver/Action.h
include/clang/Driver/Types.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Types.cpp
test/Driver/o
sfantao updated this revision to Diff 66025.
sfantao added a comment.
- Refactor code to dump contents of temporary file instead of creating the
actual file in dry-run mode.
- Rebase.
https://reviews.llvm.org/D21851
Files:
test/Driver/clang-offload-bundler.c
test/Driver/clang-offload-bundl
sfantao updated this revision to Diff 66023.
sfantao added a comment.
- Fix bug in conditional.
- Rebase.
https://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundler.c
tools/CMakeLists.txt
tools/clang-offload-bundler/CMakeLists.txt
tools/clang-offload-
sfantao updated this revision to Diff 66020.
sfantao added a comment.
- Add option to dump and test the linker script contents.
- Rebase.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index
sfantao updated this revision to Diff 66019.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21845
Files:
lib/Driver/Driver.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
===
--- test/Driver/
sfantao updated this revision to Diff 66018.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21843
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/Tool
sfantao updated this revision to Diff 66017.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.
sfantao updated this revision to Diff 66016.
sfantao added a comment.
- Remove redundant phases from cuda-phases.cu and use DAG check.
- Rebase.
https://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
test/Driver/cuda-phases.cu
Index: test/Driver/c
manmanren added a comment.
Yes, this still looks good to me. Please commit.
Manman
https://reviews.llvm.org/D22697
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:62
@@ +61,3 @@
+std::string
+SpecialMemberFunctionsCheck::join(llvm::ArrayRef
SMFS,
+ llvm::StringRef AndOr) {
aaron.ballman wrote:
>
jbcoe updated this revision to Diff 66011.
jbcoe added a comment.
Minor changes from review.
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsC
yaxunl created this revision.
yaxunl added reviewers: Anastasia, nhaustov.
yaxunl added subscribers: cfe-commits, tstellarAMD.
Let the driver pass the option to frontend. Do not set precision metadata for
division instructions when this option is set. Set function attribute
"correctly-rounded-di
kulpreet updated this revision to Diff 66006.
kulpreet added a comment.
Sorry, uploaded the wrong patch. This one should compile with the unique
variable names.
https://reviews.llvm.org/D22926
Files:
lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp
Index: lib/StaticAnalyzer/Checkers/Loca
rjmccall added a comment.
LGTM, too.
https://reviews.llvm.org/D22666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbdsmoke added a comment.
Indeed I was incorrect, and I agree with your analysis of the problem @majnemer
I'll try to correct this issue in my own time and get some tests going
Repository:
rL LLVM
https://reviews.llvm.org/D22931
___
cfe-commits
Author: dergachev
Date: Thu Jul 28 15:13:14 2016
New Revision: 277029
URL: http://llvm.org/viewvc/llvm-project?rev=277029&view=rev
Log:
[analyzer] Update the web manual for checker developers.
Fix the explanation of how to run tests after migration
from autotools to cmake.
Significantly expand t
dcoughlin added a comment.
This doesn't compile for me. It looks like there are two separate declarations
of 'buttonWithTitleNSButton'.
https://reviews.llvm.org/D22926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Hi Mike,
I've already pushed r276981 and r276988 to fix those failures shortly after I pushed the patch. After that I didn't receive any bot message complaining about that code.
Do you still see the issues?
Thanks,
Samuel
- Original message -From: Mike Aizatsky To: Samuel F Antao/W
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277029: [analyzer] Update the web manual for checker
developers. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D22874?vs=65762&id=65979#toc
Repository:
rL LLVM
https://r
sbenza added inline comments.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:93
@@ +92,3 @@
+ hasArgument(0, ignoringParenImpCasts(declRefExpr(
+ to(ForwardingReferenceParmMatcher)
+ .bind("call-move"),
majnemer added a subscriber: majnemer.
majnemer requested changes to this revision.
majnemer added a reviewer: majnemer.
majnemer added a comment.
This revision now requires changes to proceed.
Thanks for contributing this! I actually worked on an implementation of this
feature but never sent it
rnk added a subscriber: rnk.
rnk added a comment.
Needs tests, though. The MSDN sample code is probably a good starting point.
Comment at: lib/Sema/SemaDeclAttr.cpp:2659
@@ -2658,1 +2658,3 @@
+ // code_seg only ever applies to functions.
+ if (Attr.getName()->getName() == "c
kbdsmoke created this revision.
kbdsmoke added a subscriber: cfe-commits.
kbdsmoke set the repository for this revision to rL LLVM.
clang does not support this by default. By default, if you want to utilize
__declspec to assign a SectionAttr to a function, you should use __declspec
allocate.
How
dtarditi created this revision.
dtarditi added a reviewer: erik.pilkington.
dtarditi added a subscriber: cfe-commits.
r272587 (http://reviews.llvm.org/D20490) fixed an issue where typo correction
could cause a crash when compiling C programs.The problem was that a typo
expression could be in
ahatanak created this revision.
ahatanak added reviewers: doug.gregor, akyrtzi.
ahatanak added a subscriber: cfe-commits.
This patch fixes a stack overflow bug in ASTContext::getObjCEncodingForTypeImpl
where it keeps expanding a class recursively. I added a check to avoid
expanding a class if Ex
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rL277024: [OpenCL] Generate opaque type for sampler_t and
function call for the… (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D21567?vs=
Author: yaxunl
Date: Thu Jul 28 14:26:30 2016
New Revision: 277024
URL: http://llvm.org/viewvc/llvm-project?rev=277024&view=rev
Log:
[OpenCL] Generate opaque type for sampler_t and function call for the
initializer
Currently Clang use int32 to represent sampler_t, which have been a source of
is
szepet marked 2 inline comments as done.
szepet added a comment.
https://reviews.llvm.org/D22507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
szepet updated this revision to Diff 65966.
szepet marked 12 inline comments as done.
szepet added a comment.
updates based on comments, counter and search functions replaced by std
functions
https://reviews.llvm.org/D22507
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/EnumMisuseCh
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
Comments about the comment, but otherwise, LGTM.
Comment at: lib/CodeGen/CodeGenFunction.cpp:789
@@ -796,1 +788,3 @@
+ // Since emitting mcount call here impacts optimiza
yaxunl created this revision.
yaxunl added a reviewer: Anastasia.
yaxunl added subscribers: cfe-commits, tstellarAMD.
The size of image type is reported incorrectly as size of a pointer to address
space 0, which causes error when casting image type to pointers by
__builtin_astype.
The fix is to
kulpreet created this revision.
kulpreet added reviewers: zaks.anna, dcoughlin.
kulpreet added a subscriber: cfe-commits.
- Added in new iOS and macOS APIs that require a localized string
- Removed two APIs that incorrectly were marked as requiring a localized
string
https://reviews.llv
Anastasia added inline comments.
Comment at: lib/Sema/SemaInit.cpp:6961
@@ +6960,3 @@
+// the initializer.
+if (!Init->isConstantInitializer(S.Context, false))
+ break;
yaxunl wrote:
> Anastasia wrote:
> > I think you don't need this check
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D22637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D22767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dcoughlin
Date: Thu Jul 28 12:18:33 2016
New Revision: 277009
URL: http://llvm.org/viewvc/llvm-project?rev=277009&view=rev
Log:
[analyzer] Fix misleading indentation in ObjCDeallocChecker. NFC.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp
Modified: cfe/trunk/l
yaxunl marked 2 inline comments as done.
Comment at: lib/Sema/SemaInit.cpp:6961
@@ +6960,3 @@
+// the initializer.
+if (!Init->isConstantInitializer(S.Context, false))
+ break;
Anastasia wrote:
> I think you don't need this check any more
Author: john.brawn
Date: Thu Jul 28 12:17:22 2016
New Revision: 277008
URL: http://llvm.org/viewvc/llvm-project?rev=277008&view=rev
Log:
Revert r276973 "Adjust Registry interface to not require plugins to export a
registry"
Buildbot failures when building with clang -Werror. Reverting while I tr
Author: john.brawn
Date: Thu Jul 28 12:17:22 2016
New Revision: 277008
URL: http://llvm.org/viewvc/llvm-project?rev=277008&view=rev
Log:
Revert r276973 "Adjust Registry interface to not require plugins to export a
registry"
Buildbot failures when building with clang -Werror. Reverting while I tr
Committed in r277005
On Thu, Jul 28, 2016 at 9:38 AM Zachary Turner wrote:
> Sorry for the delay, I had forgotten about this. I will check it in today.
>
> On Wed, Jul 27, 2016 at 5:57 PM comicfans44 wrote:
>
>> comicfans44 added a comment.
>>
>> In https://reviews.llvm.org/D21946#473071, @ztu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277005: [Driver] Fix Windows SDK Detection (authored by
zturner).
Changed prior to commit:
https://reviews.llvm.org/D21946?vs=62570&id=65958#toc
Repository:
rL LLVM
https://reviews.llvm.org/D21946
Author: zturner
Date: Thu Jul 28 12:13:32 2016
New Revision: 277005
URL: http://llvm.org/viewvc/llvm-project?rev=277005&view=rev
Log:
[Driver] Fix Windows SDK Detection
This fixes a couple of bugs in Windows SDK Detection.
1. `readFullStringValue` returns a bool, but was being compared
with E
I've merged it in r277004.
Cheers,
Hans
On Thu, Jul 28, 2016 at 10:15 AM, Samuel F Antao wrote:
> Hi Hans,
>
> I think it should. All the stuff that enables this fix seems to be in 3.9
> already.
>
> Thanks!
> Samuel
>
>
>
> - Original message -
> From: Hans Wennborg
> Sent by: hwennb..
Hi Hans,
I think it should. All the stuff that enables this fix seems to be in 3.9 already.
Thanks!
Samuel
- Original message -From: Hans Wennborg Sent by: hwennb...@google.comTo: Samuel F Antao/Watson/IBM@IBMUS, "Bataev, Alexey" Cc: cfe-commits Subject: Re: r276979 - [OpenMP][CUDA]
Should we merge this to 3.9?
Cheers,
Hans
On Thu, Jul 28, 2016 at 7:29 AM, Samuel Antao via cfe-commits
wrote:
> Author: sfantao
> Date: Thu Jul 28 09:29:18 2016
> New Revision: 276979
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276979&view=rev
> Log:
> [OpenMP][CUDA] Do not forward OpenMP
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
https://reviews.llvm.org/D22913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks! Could you please address these small comments before committing!
Comment at: lib/Sema/SemaInit.cpp:6959
@@ +6958,3 @@
+// this has already been don
NoQ added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:91
@@ +90,3 @@
+ ASTContext &Context;
+ std::vector &CollectedData;
+
Maybe it's a good idea to introduce a typedef for `unsigned` here, because it'd
be nice to be able to change it (eg., so
klimek added a subscriber: klimek.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:83
@@ -80,3 +82,3 @@
if (const auto *Used = Result.Nodes.getNodeAs("used")) {
-if (const auto *Specialization =
-dyn_cast(Used))
+if (const auto *FD = dyn_cast(Used)) {
Sorry for the delay, I had forgotten about this. I will check it in today.
On Wed, Jul 27, 2016 at 5:57 PM comicfans44 wrote:
> comicfans44 added a comment.
>
> In https://reviews.llvm.org/D21946#473071, @zturner wrote:
>
> > In https://reviews.llvm.org/D21946#473070, @comicfans44 wrote:
> >
>
erichkeane marked an inline comment as done.
erichkeane added a comment.
Fixed the braces mentioned.
https://reviews.llvm.org/D22919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane removed rL LLVM as the repository for this revision.
erichkeane updated this revision to Diff 65951.
https://reviews.llvm.org/D22919
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Parse/Parser.h
include/clang/Sema/DeclSpec.h
lib/Parse/ParseDeclCXX.cpp
lib/Sem
Author: sfantao
Date: Thu Jul 28 11:18:31 2016
New Revision: 276996
URL: http://llvm.org/viewvc/llvm-project?rev=276996&view=rev
Log:
[CUDA] Remove duplicated test that should have been removed in r276995.
Removed:
cfe/trunk/test/Driver/cuda_phases.cu
Removed: cfe/trunk/test/Driver/cuda_phas
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM as-is, clang's behavior would be congruent with GCC's.
Comment at: lib/Parse/ParseDeclCXX.cpp:3024-3026
@@ -3013,2 +3023,5 @@
Diag(FinalLoc, diag::ext_ms_seale
Author: sfantao
Date: Thu Jul 28 11:12:30 2016
New Revision: 276995
URL: http://llvm.org/viewvc/llvm-project?rev=276995&view=rev
Log:
[CUDA] Rename cuda_phases.cu test to cuda-phases.cu to be consistent with the
other tests.
Added:
cfe/trunk/test/Driver/cuda-phases.cu
Added: cfe/trunk/test/
rnk created this revision.
rnk added reviewers: amccarth, aprantl, dblaikie, dexonsmith.
rnk added a subscriber: cfe-commits.
rnk added a dependency: D22884: [codeview] Emit vftable records.
MSVC emits codeview records describing all the methods contained in a
vftable. This is observable in windbg
kimgr added a comment.
This is probably not the right place for this discussion, but I thought I'd
offer one more note.
Comment at: include/string_view:216
@@ +215,3 @@
+ basic_string_view(const _CharT* __s)
+ : __data(__s), __size(_Traits::length(__s)) {}
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276994: Mention of proper support for "__unaligned" type
qualifier in 3.9 clang… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D22913?vs=65914&id=65943#toc
Repository:
rL LLVM
1 - 100 of 144 matches
Mail list logo
