Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

2016-07-10 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added a comment. In http://reviews.llvm.org/D21851#479042, @sfantao wrote: > That was probably not the reason why you were getting the failure, but the > bundler was not prepared to bundle files if the host was not the first input. > I fixed that. This was indeed the problem, this no

r275049 - [AVX512] Replace masked AND/OR/XOR intrinsics with native code and remove the builtins.

2016-07-10 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon Jul 11 01:14:18 2016 New Revision: 275049 URL: http://llvm.org/viewvc/llvm-project?rev=275049&view=rev Log: [AVX512] Replace masked AND/OR/XOR intrinsics with native code and remove the builtins. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/

r275047 - [Sema] Disallow __make_integer_seq from showing up in __make_integer_seq

2016-07-10 Thread David Majnemer via cfe-commits
Author: majnemer Date: Mon Jul 11 00:59:24 2016 New Revision: 275047 URL: http://llvm.org/viewvc/llvm-project?rev=275047&view=rev Log: [Sema] Disallow __make_integer_seq from showing up in __make_integer_seq We hit over stringent asserts when trying to diagnose. Loosen them as appropriate. This

Re: [PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

2016-07-10 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. BTW I've made clang-extra project on phabricator as you can see. Please use it, it will be much easier to filter reviews. Repository: rL LLVM http://reviews.llvm.org/D22208 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D22208: clang-tidy] Fixes to modernize-use-emplace

2016-07-10 Thread Piotr Padlewski via cfe-commits
Prazek created this revision. Prazek added reviewers: sbenza, alexfh, aaron.ballman. Prazek added subscribers: cfe-commits, hokein, sbarzowski, mnbvmar, staronj, sbenza. Prazek set the repository for this revision to rL LLVM. Prazek added a project: clang-extra. Not everything is valid (as you se

r275043 - Revert r275029 - Update Clang tests after adding inference for the returned argument attribute

2016-07-10 Thread Hal Finkel via cfe-commits
Author: hfinkel Date: Sun Jul 10 23:52:07 2016 New Revision: 275043 URL: http://llvm.org/viewvc/llvm-project?rev=275043&view=rev Log: Revert r275029 - Update Clang tests after adding inference for the returned argument attribute The associated backend change is causing miscompiles from the AArch

r275040 - [CodeGen] Treat imported static local variables as declarations

2016-07-10 Thread David Majnemer via cfe-commits
Author: majnemer Date: Sun Jul 10 23:28:21 2016 New Revision: 275040 URL: http://llvm.org/viewvc/llvm-project?rev=275040&view=rev Log: [CodeGen] Treat imported static local variables as declarations Imported variables cannot really be definitions for the purposes of IR generation. Modified:

Re: [PATCH] D21834: Implementing 'If statement with Initializer'

2016-07-10 Thread Richard Smith via cfe-commits
rsmith added a comment. This looks really good. Some minor comments then this is ready to commit. Comment at: include/clang/AST/Stmt.h:890 @@ -889,3 +889,3 @@ IfStmt(const ASTContext &C, SourceLocation IL, - bool IsConstexpr, VarDecl *var, Expr *cond, + bool I

r275032 - Reapply SVN r274797.

2016-07-10 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Jul 10 18:24:36 2016 New Revision: 275032 URL: http://llvm.org/viewvc/llvm-project?rev=275032&view=rev Log: Reapply SVN r274797. Original Commit Message Driver: Stop linking to C++ when using sanitizers on Darwin Sanitizers on Darwin are built as dynamic libra

r275030 - AMDGPU: Export workitem builtins

2016-07-10 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Sun Jul 10 17:38:04 2016 New Revision: 275030 URL: http://llvm.org/viewvc/llvm-project?rev=275030&view=rev Log: AMDGPU: Export workitem builtins Reviewers: tstellardAMD Differential Revision: http://reviews.llvm.org/D20299 Modified: cfe/trunk/include/clang/Basic/Builti

r275029 - Update Clang tests after adding inference for the returned argument attribute

2016-07-10 Thread Hal Finkel via cfe-commits
Author: hfinkel Date: Sun Jul 10 17:26:52 2016 New Revision: 275029 URL: http://llvm.org/viewvc/llvm-project?rev=275029&view=rev Log: Update Clang tests after adding inference for the returned argument attribute Adjusting tests after r275027. Modified: cfe/trunk/test/CodeGen/ppc64-struct-one

[PATCH] D22200: [libc++] Fix macOS Sierra build issues by declaring basic_string(const allocator_type& __a) noexcept.

2016-07-10 Thread ELI JOSEPH BRADLEY via cfe-commits
EtherTyper created this revision. EtherTyper added a subscriber: cfe-commits. EtherTyper set the repository for this revision to rL LLVM. EtherTyper changed the edit policy of this Differential Revision from "All Users" to "Administrators". Repository: rL LLVM http://reviews.llvm.org/D22200 F

r275018 - [AVX512] Remove masked shufps/shudpd builtins. These are all handled with __builtin_shufflevector.

2016-07-10 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun Jul 10 11:35:54 2016 New Revision: 275018 URL: http://llvm.org/viewvc/llvm-project?rev=275018&view=rev Log: [AVX512] Remove masked shufps/shudpd builtins. These are all handled with __builtin_shufflevector. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

Re: [PATCH] D22196: Fix Bug "28480 - cppcoreguidelines-pro-bounds-array-to-pointer-decay handling __PRETTY_FUNCTION__"

2016-07-10 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. I agree with your assessment that these should be safe, but the C++ Core Guidelines themselves don't call this case out as part of the enforcement (https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#bounds3-no-array-to-pointer-decay). Hav

Re: [PATCH] D22190: cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent index in c++03 mode

2016-07-10 Thread Aaron Ballman via cfe-commits
aaron.ballman added a reviewer: rsmith. aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. Hmm, perhaps @rsmith has other opinions, but I think this should be fixed in `isIntegerConstantExpr()`. C++03 has the notion of value dependence, and [temp.dep.type]p1 and [expr.const

[PATCH] D22196: Fix Bug "28480 - cppcoreguidelines-pro-bounds-array-to-pointer-decay handling __PRETTY_FUNCTION__"

2016-07-10 Thread Eric Lemanissier via cfe-commits
ericLemanissier created this revision. ericLemanissier added reviewers: alexfh, sbenza, bkramer, aaron.ballman. ericLemanissier added subscribers: ericLemanissier, cfe-commits. Herald added a subscriber: nemanjai. Ignore array to pointer decay for predefined macros. It is ok because there is no s

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-10 Thread Alexander Droste via cfe-commits
Alexander_Droste updated this revision to Diff 63422. Alexander_Droste added a comment. - simplify `argumentType()` function http://reviews.llvm.org/D21962 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/MpiTypeMismatchCheck.cpp clang-tidy/misc/M

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-10 Thread Kirill Bobyrev via cfe-commits
omtcyf0 marked an inline comment as done. Comment at: clang-rename/USRLocFinder.cpp:73-75 @@ -73,3 +72,5 @@ SourceLocation Location = Initializer->getSourceLocation(); - StringRef TokenName = Lexer::getSourceText(CharSourceRange::getTokenRange(Location), Cont

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-10 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63418. http://reviews.llvm.org/D22091 Files: clang-rename/RenamingAction.cpp clang-rename/USRLocFinder.cpp clang-rename/USRLocFinder.h clang-rename/tool/ClangRename.cpp Index: clang-rename/tool/ClangRename.cpp