r275012 - [X86] Use __butilin_shufflevector for 512-bit shufps intrinsics.

2016-07-09 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun Jul 10 00:57:21 2016 New Revision: 275012 URL: http://llvm.org/viewvc/llvm-project?rev=275012&view=rev Log: [X86] Use __butilin_shufflevector for 512-bit shufps intrinsics. Modified: cfe/trunk/lib/Headers/avx512fintrin.h cfe/trunk/test/CodeGen/avx512f-builtins.c

r275006 - Add CLANG_BUILD_TOOLS as a clang counterpart for LLVM_BUILD_TOOLS

2016-07-09 Thread Michael Gottesman via cfe-commits
Author: mgottesman Date: Sat Jul 9 20:44:00 2016 New Revision: 275006 URL: http://llvm.org/viewvc/llvm-project?rev=275006&view=rev Log: Add CLANG_BUILD_TOOLS as a clang counterpart for LLVM_BUILD_TOOLS LLVM_BUILD_TOOLS is a boolean variable that controls whether or not generated targets for llvm

r275005 - Delete dead code.

2016-07-09 Thread Sean Silva via cfe-commits
Author: silvas Date: Sat Jul 9 19:57:52 2016 New Revision: 275005 URL: http://llvm.org/viewvc/llvm-project?rev=275005&view=rev Log: Delete dead code. We were just setting DisableUnitAtATime to its default value. Modified: cfe/trunk/include/clang/Frontend/CodeGenOptions.def cfe/trunk/lib

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

2016-07-09 Thread Sean Silva via cfe-commits
silvas added a comment. In http://reviews.llvm.org/D21823#479418, @davidxl wrote: > I should have brought it up earlier, but I forgot.I think a better (and > simpler) proposal is to make -fprofile-generate and -fprofile-use turn on IR > based PGO. > > -fprofile-generate and -fprofile-use op

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

2016-07-09 Thread David Li via cfe-commits
davidxl added a comment. I should have brought it up earlier, but I forgot.I think a better (and simpler) proposal is to make -fprofile-generate and -fprofile-use turn on IR based PGO. -fprofile-generate and -fprofile-use options were introduced by Diego (cc'ed) recently for GCC option com

r274992 - Move add_clang_* entry points from the main clang CMakeLists.txt to cmake/modules/AddClang.cmake.

2016-07-09 Thread Michael Gottesman via cfe-commits
Author: mgottesman Date: Sat Jul 9 16:58:40 2016 New Revision: 274992 URL: http://llvm.org/viewvc/llvm-project?rev=274992&view=rev Log: Move add_clang_* entry points from the main clang CMakeLists.txt to cmake/modules/AddClang.cmake. This matches how LLVM has its cmake files organized and is cl

r274991 - [clang-cl] Add support for /Zd

2016-07-09 Thread David Majnemer via cfe-commits
Author: majnemer Date: Sat Jul 9 16:49:16 2016 New Revision: 274991 URL: http://llvm.org/viewvc/llvm-project?rev=274991&view=rev Log: [clang-cl] Add support for /Zd MASM (ML.exe and ML64.exe) and older versions of MSVC (CL.exe) support a flag called /Zd which is more-or-less -gline-tables-only.

[PATCH] D22190: cppcoreguidelines-pro-bounds-constant-array-index: crash for value dependent index in c++03 mode

2016-07-09 Thread Matthias Gehre via cfe-commits
mgehre created this revision. mgehre added reviewers: alexfh, aaron.ballman. mgehre added a subscriber: cfe-commits. Herald added a subscriber: nemanjai. When the expression is value dependent, isIntegerConstantExpr() crashes in C++03 mode with ../tools/clang/lib/AST/ExprConstant.cpp:9330: (anony

Re: [PATCH] D22069: clang-tidy modernize-loop-convert: preserve type of alias declaration (bug 28341)

2016-07-09 Thread Matthias Gehre via cfe-commits
mgehre updated this revision to Diff 63400. mgehre added a comment. Added assert. Runs on llvm code-base without triggering the assert. http://reviews.llvm.org/D22069 Files: clang-tidy/modernize/LoopConvertCheck.cpp test/clang-tidy/modernize-loop-convert-extra.cpp Index: test/clang-tidy/mo

[PATCH] D22189: llvm.noalias - Clang CodeGen - check restrict variable map only for restrict-qualified lvalues

2016-07-09 Thread Hal Finkel via cfe-commits
hfinkel created this revision. hfinkel added reviewers: rjmccall, chandlerc, rsmith, dberlin. hfinkel added a subscriber: cfe-commits. Herald added a subscriber: mcrosier. As part of D9403, John McCall asked to avoid making a DenseMap query per emitted store instruction. This can be done by restr

Re: [PATCH] D22188: clang-tidy/readability-identifier-naming: crash on DependentTemplateSpecializationType

2016-07-09 Thread Matthias Gehre via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274985: clang-tidy/readability-identifier-naming: crash on… (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D22188?vs=63397&id=63398#toc Repository: rL LLVM http://reviews.llv

[clang-tools-extra] r274985 - clang-tidy/readability-identifier-naming: crash on DependentTemplateSpecializationType

2016-07-09 Thread Matthias Gehre via cfe-commits
Author: mgehre Date: Sat Jul 9 15:09:28 2016 New Revision: 274985 URL: http://llvm.org/viewvc/llvm-project?rev=274985&view=rev Log: clang-tidy/readability-identifier-naming: crash on DependentTemplateSpecializationType Summary: Previously, the added test cases crashed because the passed a null

Re: [PATCH] D22188: clang-tidy/readability-identifier-naming: crash on DependentTemplateSpecializationType

2016-07-09 Thread Matthias Gehre via cfe-commits
mgehre added a comment. I didn't see that bug before, but with my patch, I cannot reproduce the reported crash. So I guess that fixed it. http://reviews.llvm.org/D22188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

2016-07-09 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-rename/USRLocFinder.cpp:63 @@ -62,3 +62,3 @@ const ASTContext &Context = ConstructorDecl->getASTContext(); -for (clang::CXXConstructorDecl::init_const_iterator it = ConstructorDecl->init_begin(); it != ConstructorDecl->init

Re: [PATCH] D22188: clang-tidy/readability-identifier-naming: crash on DependentTemplateSpecializationType

2016-07-09 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Is it related to https://llvm.org/bugs/show_bug.cgi?id=28481 ? http://reviews.llvm.org/D22188 ___ cfe-commits mailing list cfe-commi

Re: [PATCH] D22188: clang-tidy/readability-identifier-naming: crash on DependentTemplateSpecializationType

2016-07-09 Thread Matthias Gehre via cfe-commits
mgehre updated this revision to Diff 63397. mgehre added a comment. Add a second test case and fix http://reviews.llvm.org/D22188 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier-naming.cpp Index: test/clang-tidy/readability-identifier-naming.c

[PATCH] D22188: clang-tidy/readability-identifier-naming: crash on DependentTemplateSpecializationType

2016-07-09 Thread Matthias Gehre via cfe-commits
mgehre created this revision. mgehre added a reviewer: alexfh. mgehre added a subscriber: cfe-commits. Previously, the added test cases crashed because Ref.getTypePtr()->getAsTagDecl() is nullptr. http://reviews.llvm.org/D22188 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/cl

r274984 - [MS ABI] Some code cleanups

2016-07-09 Thread David Majnemer via cfe-commits
Author: majnemer Date: Sat Jul 9 14:26:25 2016 New Revision: 274984 URL: http://llvm.org/viewvc/llvm-project?rev=274984&view=rev Log: [MS ABI] Some code cleanups Don't create unnecessary truncations if the result will not be used. Also prefer preforming math before the truncation, it makes it a

r274983 - [AST] Tighten up some bitfields

2016-07-09 Thread David Majnemer via cfe-commits
Author: majnemer Date: Sat Jul 9 14:26:19 2016 New Revision: 274983 URL: http://llvm.org/viewvc/llvm-project?rev=274983&view=rev Log: [AST] Tighten up some bitfields Optimize the bitfield types to conserve space for the MSVC ABI. Modified: cfe/trunk/include/clang/AST/DeclFriend.h cfe/tr

Re: [PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

2016-07-09 Thread Hal Finkel via cfe-commits
hfinkel updated this revision to Diff 63394. hfinkel added a comment. Herald added a subscriber: mcrosier. Rebased. Recursive AST visitor (which John pointed out was bad because it caused quadratic behavior and was wasteful in terms of code size) replaced with a function with some loops over the

Re: [PATCH] D22146: clang-format: [JS] Sort imports case insensitive.

2016-07-09 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274977: clang-format: [JS] Sort imports case insensitive. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D22146?vs=63271&id=63391#toc Repository: rL LLVM http://reviews.llvm

r274977 - clang-format: [JS] Sort imports case insensitive.

2016-07-09 Thread Martin Probst via cfe-commits
Author: mprobst Date: Sat Jul 9 10:11:18 2016 New Revision: 274977 URL: http://llvm.org/viewvc/llvm-project?rev=274977&view=rev Log: clang-format: [JS] Sort imports case insensitive. Summary: ASCII case sorting does not help finding imported symbols quickly, and it is common to have e.g. class

Re: [PATCH] D22147: clang-format: [JS] support trailing commas in imports.

2016-07-09 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274976: clang-format: [JS] support trailing commas in imports. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D22147?vs=63270&id=63390#toc Repository: rL LLVM http://reviews

r274976 - clang-format: [JS] support trailing commas in imports.

2016-07-09 Thread Martin Probst via cfe-commits
Author: mprobst Date: Sat Jul 9 10:09:22 2016 New Revision: 274976 URL: http://llvm.org/viewvc/llvm-project?rev=274976&view=rev Log: clang-format: [JS] support trailing commas in imports. Reviewers: djasper Subscribers: cfe-commits, klimek Differential Revision: http://reviews.llvm.org/D22147

r274975 - [analyzer] Older version of GCC 4.7 crash on lambdas in default arguments.

2016-07-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Jul 9 07:16:58 2016 New Revision: 274975 URL: http://llvm.org/viewvc/llvm-project?rev=274975&view=rev Log: [analyzer] Older version of GCC 4.7 crash on lambdas in default arguments. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp Modif

r274974 - [analyzer] Rewrite manual erase loop using remove_if.

2016-07-09 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Jul 9 06:16:56 2016 New Revision: 274974 URL: http://llvm.org/viewvc/llvm-project?rev=274974&view=rev Log: [analyzer] Rewrite manual erase loop using remove_if. No functionality change intended. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChec

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

2016-07-09 Thread Serge Pavlov via cfe-commits
2016-07-01 15:26 GMT+06:00 Aleksei Sidorin : > a.sidorin updated this revision to Diff 62474. > a.sidorin added a comment. > > Fix some issues pointed by Serge Pavlov. > Serge: putting a check of FriendDecls to `IsStructurallyEquivalent()` > seems like a good idea for me, but we need some addition

Re: [PATCH] D16579: Warn if friend function depends on template parameters.

2016-07-09 Thread Serge Pavlov via cfe-commits
sepavloff marked 6 inline comments as done. Comment at: include/clang/Sema/Sema.h:9469 @@ +9468,3 @@ + /// of proper templates, but they are needed for checks. + SmallVector FriendsOfTemplates; + Do we really need it? When compiler is compiling a module containi

Re: [PATCH] D16579: Warn if friend function depends on template parameters.

2016-07-09 Thread Serge Pavlov via cfe-commits
sepavloff updated this revision to Diff 63387. sepavloff added a comment. Repared file modes. http://reviews.llvm.org/D16579 Files: include/clang/AST/TypeInstantiationMatcher.h include/clang/AST/TypeMatcher.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKind

Re: [PATCH] D16579: Warn if friend function depends on template parameters.

2016-07-09 Thread Serge Pavlov via cfe-commits
sepavloff updated this revision to Diff 63386. sepavloff added a comment. Updated patch http://reviews.llvm.org/D16579 Files: include/clang/AST/TypeInstantiationMatcher.h include/clang/AST/TypeMatcher.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td