mclow.lists added a comment.
I know that there are more tests needed.
http://reviews.llvm.org/D21459
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272986: AMDGPU: Fix supported CL features (authored by
jvesely).
Changed prior to commit:
http://reviews.llvm.org/D20388?vs=60259&id=61060#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20388
Fil
Author: jvesely
Date: Thu Jun 16 21:25:03 2016
New Revision: 272986
URL: http://llvm.org/viewvc/llvm-project?rev=272986&view=rev
Log:
AMDGPU: Fix supported CL features
Reviewers: arsenm
Differential Revision: http://reviews.llvm.org/D20388
Added:
cfe/trunk/test/Misc/amdgcn.languageOptsOpenC
chapuni added a subscriber: chapuni.
Comment at: cfe/trunk/unittests/Tooling/ToolingTest.cpp:315
@@ -262,1 +314,3 @@
+ runToolOnCode(new SkipBodyAction,
+"template int skipMeNot() { an_error_here }"));
}
It didn't pass for targeting *-msv
Author: chapuni
Date: Thu Jun 16 21:04:51 2016
New Revision: 272985
URL: http://llvm.org/viewvc/llvm-project?rev=272985&view=rev
Log:
ToolingTests/runToolOnCode.TestSkipFunctionBody: Appease msc targets.
Modified:
cfe/trunk/unittests/Tooling/ToolingTest.cpp
Modified: cfe/trunk/unittests/Tool
thanks!
On Fri, Jun 17, 2016 at 2:27 AM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Thu Jun 16 19:27:02 2016
> New Revision: 272979
>
> URL: http://llvm.org/viewvc/llvm-project?rev=272979&view=rev
> Log:
> Headers: wordsmith error message
>
Author: rsingh
Date: Thu Jun 16 19:59:41 2016
New Revision: 272983
URL: http://llvm.org/viewvc/llvm-project?rev=272983&view=rev
Log:
[ARM] Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics.
Reapplying patch in r272777 which was reverted
because the llvm patch which added support
Author: compnerd
Date: Thu Jun 16 19:27:02 2016
New Revision: 272979
URL: http://llvm.org/viewvc/llvm-project?rev=272979&view=rev
Log:
Headers: wordsmith error message
Use the marketing name for the MSVC release as pointed out by Nico Weber!
Modified:
cfe/trunk/lib/Headers/inttypes.h
Modifi
On Thu, Jun 16, 2016 at 1:40 AM, Nico Weber wrote:
> Maybe this should use the marketing name ("before msvc 2013")? People
> might be more familiar with that.
>
Thats a pretty good idea actually. Ill make a follow up change.
> On Jun 15, 2016 2:34 AM, "Saleem Abdulrasool via cfe-commits" <
> c
rsmith added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2073-2079
@@ +2072,9 @@
+ let Content = [{
+Use ``overallocated`` to indicate a struct or union is over-allocated. For
example,
+
+.. code-block:: c++
+
+struct S {
+ char a[4], char b[4];
+} __attribute_
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D20388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Hello everyone,
LLVM buildmaster will be restarted after 8 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jvesely added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D20388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jvesely added a comment.
ping
@jholewinski, is the exported list of features OK with you?
@Anastasia, are the tests OK now?
Repository:
rL LLVM
http://reviews.llvm.org/D20389
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Ilod added a comment.
I don't think weak linkage defines this.
For example, in:
struct A {
inline int foo() { return 0; }
int bar() { return 1; }
int baz();
};
int A::baz() { return 2; }
With /Ob1, we should inline foo and bar, but never baz. But baz doesn't have
weak linkage
ahatanak created this revision.
ahatanak added reviewers: rsmith, george.burgess.iv, aaron.ballman.
ahatanak added subscribers: cfe-commits, dexonsmith, hfinkel.
This patch adds support for attribute "overallocated", which will be used to
indicate a union or struct is over-allocated. This is need
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272971: [CodeGen] Fix a segfault caused by pass_object_size.
(authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D17462?vs=61041&id=61048#toc
Repository:
rL LLVM
http://reviews.llvm
Author: gbiv
Date: Thu Jun 16 18:06:04 2016
New Revision: 272971
URL: http://llvm.org/viewvc/llvm-project?rev=272971&view=rev
Log:
[CodeGen] Fix a segfault caused by pass_object_size.
This patch fixes a bug where we'd segfault (in some cases) if we saw a
variadic function with one or more pass_ob
rnk added a comment.
Can't we implement /Ob1 by applying noinline to every non-inline specified
function with weak linkage?
http://reviews.llvm.org/D20647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
george.burgess.iv added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:331
@@ -329,3 +330,3 @@
// And the rest of the call args
EmitCallArgs(Args, FPT, E->arguments(), E->getDirectCallee());
return EmitCall(CGM.getTypes().arrangeCXXMethodCall(Args, FPT, required),
george.burgess.iv updated this revision to Diff 61041.
george.burgess.iv marked 2 inline comments as done.
george.burgess.iv added a comment.
Addressed all feedback.
http://reviews.llvm.org/D17462
Files:
include/clang/CodeGen/CGFunctionInfo.h
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExprCXX.c
LGTM
On 16 Jun 2016 3:07 p.m., "Pirama Arumuga Nainar via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> pirama created this revision.
> pirama added a reviewer: rsmith.
> pirama added subscribers: srhines, cfe-commits.
>
> If the RenderScript LangOpt is set, either via '-x renderscript' or
pirama created this revision.
pirama added a reviewer: rsmith.
pirama added subscribers: srhines, cfe-commits.
If the RenderScript LangOpt is set, either via '-x renderscript' or the '.rs'
file extension, set the DWARF language tag to be that of RenderScript.
http://reviews.llvm.org/D21451
Files
ogoffart abandoned this revision.
ogoffart added a comment.
Replaced by http://reviews.llvm.org/D19764
http://reviews.llvm.org/D19327
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272962: Keep invalid functions as part of the AST (authored
by ogoffart).
Changed prior to commit:
http://reviews.llvm.org/D19764?vs=55714&id=61034#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272963: Fix a few issues while skipping function bodies
(authored by ogoffart).
Changed prior to commit:
http://reviews.llvm.org/D20821?vs=60340&id=61035#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: ogoffart
Date: Thu Jun 16 16:39:55 2016
New Revision: 272962
URL: http://llvm.org/viewvc/llvm-project?rev=272962&view=rev
Log:
Keep invalid functions as part of the AST
Differential Revision: http://reviews.llvm.org/D19764
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
cfe/trunk/test/
Author: ogoffart
Date: Thu Jun 16 16:40:06 2016
New Revision: 272963
URL: http://llvm.org/viewvc/llvm-project?rev=272963&view=rev
Log:
Fix a few issues while skipping function bodies
- In functions with try { } catch { }, only the try block would be
skipped, not the catch blocks
- The templ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272961: Functions declared in a scope should not hide
previous declaration in earlier… (authored by ogoffart).
Changed prior to commit:
http://reviews.llvm.org/D19763?vs=55712&id=61033#toc
Repository:
Author: ogoffart
Date: Thu Jun 16 16:39:46 2016
New Revision: 272961
URL: http://llvm.org/viewvc/llvm-project?rev=272961&view=rev
Log:
Functions declared in a scope should not hide previous declaration in earlier
scopes
This code should be an error:
void foo(int);
void f3() {
int foo(float
Ilod added a reviewer: rnk.
Ilod updated this revision to Diff 61029.
Ilod added a comment.
Updated to head revision, and pinging this.
http://reviews.llvm.org/D20647
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunction.cpp
lib/Fro
kcc added inline comments.
Comment at: docs/CSI.rst:7
@@ +6,3 @@
+
+CSI:LLVM is a framework providing comprehensive static instrumentation via the
+compiler in order to simplify the task of building efficient and effective
The intro paragraph is important to attra
Prazek added a reviewer: hokein.
Prazek added a subscriber: hokein.
Prazek added a comment.
@alexfh or @hokein ping
http://reviews.llvm.org/D20964
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: tra
Date: Thu Jun 16 15:16:49 2016
New Revision: 272947
URL: http://llvm.org/viewvc/llvm-project?rev=272947&view=rev
Log:
Minor fixes for miamcpu-opt.c test
Added -no-canonical-prefixes to make cc1 binary name more predictable.
Added appropriate REQUIRES keywords.
Modified:
cfe/trunk
Author: rnk
Date: Thu Jun 16 15:08:51 2016
New Revision: 272944
URL: http://llvm.org/viewvc/llvm-project?rev=272944&view=rev
Log:
[DebugInfo] Put the vftable index in the debug info
This won't always be enough info to call a virtual method from the
debugger, but it's a start.
Modified:
cfe/t
tdenniston created this revision.
tdenniston added reviewers: kcc, zhaoqin, bruening.
tdenniston added subscribers: cfe-commits, eugenis, pcc, vitalybuka, aizatsky.
tdenniston set the repository for this revision to rL LLVM.
tdenniston added a project: Comprehensive Static Instrumentation.
This di
rsmith added a comment.
I agree, that looks like correct behavior for the warning. Thanks!
Comment at: lib/Sema/SemaCast.cpp:259-260
@@ -258,2 +258,4 @@
return ExprError();
+ if (DestType->isVoidPointerType())
+DiscardMisalignedMemberAddress(E);
}
erik.pilkington added a comment.
Ping!
http://reviews.llvm.org/D20923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:57-58
@@ -56,2 +56,4 @@
const FunctionProtoType *FPT = MD->getType()->castAs();
- RequiredArgs required = RequiredArgs::forPrototypePlus(FPT, Args.size());
+ // Don't pass in the MethodDecl, because we should
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Fine with me.
-eric
Comment at: lib/Basic/Targets.cpp:5709
@@ -5716,3 +5708,3 @@
void getTargetDefines(const LangOptions &Opts,
MacroBuilder
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
eugenis added a comment.
This timeval thing looks like a legitimate warning to me.
I don't think the analysis should go beyond the function boundaries. If a
callee expects timeval * as part of its signature it should get a properly
aligned timeval *.
http://reviews.llvm.org/D20561
_
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaLookup.cpp:1091
@@ -1091,2 +1091,2 @@
bool Found = false;
for (; I != IEnd && S->isDeclScope(*I); ++I) {
Please rename this to something like `Search
Author: spatel
Date: Thu Jun 16 13:45:01 2016
New Revision: 272933
URL: http://llvm.org/viewvc/llvm-project?rev=272933&view=rev
Log:
[x86] generate IR for AVX2 integer min/max builtins
Sibling patch to r272932:
http://reviews.llvm.org/rL272932
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Author: sfantao
Date: Thu Jun 16 13:39:34 2016
New Revision: 272931
URL: http://llvm.org/viewvc/llvm-project?rev=272931&view=rev
Log:
Re-apply r272900 - [OpenMP] Cast captures by copy when passed to fork call so
that they are compatible to what the runtime library expects.
An issue in one of the
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
ah, rightio - thanks for the reminder!
On Thu, Jun 16, 2016 at 10:44 AM, George Burgess IV <
george.burgess...@gmail.com> wrote:
> I don't think so -- 4.7p2 says "If the destination type is unsigned, the
> resulting value is the least unsigned integer congruent to the source
> integer (modulo 2 n
zizhar updated this revision to Diff 60996.
zizhar added a comment.
A redo, investigated a bit more, had to fix some things, moved it to
ActOnGCCAsmStmt.
fixed intrin.h (the patch reveals a problem in it).
added tests to check for regression and examples.
http://reviews.llvm.org/D15075
Files:
Anastasia added a comment.
Ping! :)
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
Ping! It would be nice to have this fix committed soon!
Thanks!
http://reviews.llvm.org/D20630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I don't think so -- 4.7p2 says "If the destination type is unsigned, the
resulting value is the least unsigned integer congruent to the source
integer (modulo 2 n where n is the number of bits used to represent the
unsigned type). [ Note: In a two’s complement representation, this
conversion is con
I can't remember the rules - but wouldn't this produce UB on a signed char
platform in the case where Ch is negative? (or is that just unspecified?
implementation defined?)
On Wed, Jun 15, 2016 at 7:30 PM, George Burgess IV via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: gbiv
> Dat
timshen updated this revision to Diff 60992.
timshen added a comment.
Updated the patch to use ignorngImplicit/Expr::IgnoreImplicit matcher.
I think there is a systematic way to do this change:
Look at every ignoringImpCasts, ignoringParenCasts, ignoringParenImpCasts,
ignoringParens, and
Expr::
alexfh added a comment.
The check seems reasonable, I'm surprised there's no warning in Clang that
catches index[array] syntax ;)
A few comments re: implementation.
Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:43
@@ +42,3 @@
+
+static StringRef getAsString(c
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a couple of nits.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:808
@@ +807,3 @@
+ addUsage(NamingCheckFailures, ID, Range);
+ return;
+}
Author: sfantao
Date: Thu Jun 16 11:06:22 2016
New Revision: 272908
URL: http://llvm.org/viewvc/llvm-project?rev=272908&view=rev
Log:
Revert r272900 - [OpenMP] Cast captures by copy when passed to fork call so
that they are compatible to what the runtime library expects.
Was causing trouble in o
etienneb updated this revision to Diff 60983.
etienneb added a comment.
refactoring
http://reviews.llvm.org/D21392
Files:
clang-tidy/misc/RedundantExpressionCheck.cpp
clang-tidy/misc/RedundantExpressionCheck.h
test/clang-tidy/misc-redundant-expression.cpp
Index: test/clang-tidy/misc-redu
etienneb added a comment.
thx Aaron.
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:131
@@ +130,3 @@
+
+ // Handle the case where constants are off by one: x <= 4 <==> x < 5.
+ llvm::APSInt ValueLHS_plus1 = ValueLHS;
aaron.ballman wrote:
> Why is o
etienneb updated this revision to Diff 60982.
etienneb marked 7 inline comments as done.
etienneb added a comment.
address comments
http://reviews.llvm.org/D21392
Files:
clang-tidy/misc/RedundantExpressionCheck.cpp
clang-tidy/misc/RedundantExpressionCheck.h
test/clang-tidy/misc-redundant-
cameron314 added a comment.
Ping? :-)
http://reviews.llvm.org/D20338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Thu Jun 16 10:09:31 2016
New Revision: 272900
URL: http://llvm.org/viewvc/llvm-project?rev=272900&view=rev
Log:
[OpenMP] Cast captures by copy when passed to fork call so that they are
compatible to what the runtime library expects.
Summary:
This patch fixes an issue detect
Author: alexfh
Date: Thu Jun 16 09:32:41 2016
New Revision: 272896
URL: http://llvm.org/viewvc/llvm-project?rev=272896&view=rev
Log:
[clang-tidy] misc-move-const-arg: Detect if result of std::move() is being
passed as a const ref argument
Summary:
Conceptually, this is very close to the existing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272897: [clang-tidy] misc-move-const-arg: Fix typos
(authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D21366?vs=60802&id=60975#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272896: [clang-tidy] misc-move-const-arg: Detect if result
of std::move() is being… (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D21223?vs=60686&id=60974#toc
Repository:
rL
Author: alexfh
Date: Thu Jun 16 09:32:54 2016
New Revision: 272897
URL: http://llvm.org/viewvc/llvm-project?rev=272897&view=rev
Log:
[clang-tidy] misc-move-const-arg: Fix typos
Reviewers: alexfh
Subscribers: cfe-commits
Patch by Martin Boehme!
Differential Revision: http://reviews.llvm.org/D21
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. I'll commit the patch for you.
http://reviews.llvm.org/D21366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
alexfh added a comment.
BTW, I'll commit the patch for you.
http://reviews.llvm.org/D21223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
LG. Thanks!
http://reviews.llvm.org/D21223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, but you should wait for @alexfh to sign off as well since he had some
comments.
http://reviews.llvm.org/D21223
___
cfe-commi
rengolin added a comment.
In http://reviews.llvm.org/D21277#459703, @jojo wrote:
> Do you mean updating the diff to let it include the change of
> http://reviews.llvm.org/D21276,or commiting these two reviews as one commit?
Committing them as one, after they're both approved.
Repository:
r
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:114
@@ -112,1 +113,3 @@
+// Perform a comparison bitween APSInt with respect to bit-width and
signedness.
+static int compareValues(const llvm::APSInt &ValueLHS,
s/bit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272893: [Builtin] Make __builtin_thread_pointer
target-independent. (authored by koriakin).
Changed prior to commit:
http://reviews.llvm.org/D19589?vs=55216&id=60966#toc
Repository:
rL LLVM
http://r
Author: koriakin
Date: Thu Jun 16 08:41:54 2016
New Revision: 272893
URL: http://llvm.org/viewvc/llvm-project?rev=272893&view=rev
Log:
[Builtin] Make __builtin_thread_pointer target-independent.
This is now supported for ARM, AArch64, PowerPC, SystemZ, SPARC, Mips.
Differential Revision: http://
Author: hokein
Date: Thu Jun 16 08:27:02 2016
New Revision: 272890
URL: http://llvm.org/viewvc/llvm-project?rev=272890&view=rev
Log:
A follow-up fixing on cuda-march.cu: Don't match clang to other place.
Modified:
cfe/trunk/test/Driver/cuda-march.cu
Modified: cfe/trunk/test/Driver/cuda-march
Author: aturetsk
Date: Thu Jun 16 07:26:20 2016
New Revision: 272887
URL: http://llvm.org/viewvc/llvm-project?rev=272887&view=rev
Log:
Patch "Compilation for Intel MCU (Part 2/3)" caused the clang-x64-ninja-win7
buildbot to fail because of inaccurate CHECK in the test. This is a quick fix
for the
Author: ed
Date: Thu Jun 16 06:53:11 2016
New Revision: 272886
URL: http://llvm.org/viewvc/llvm-project?rev=272886&view=rev
Log:
Remove CloudABI specific workaround.
CloudABI has gained the mblen_l() function in the meantime that does
properly return whether the character set has shift-states (re
rogfer01 added a comment.
Firefox build shows a couple of warnings in the sctp library that already gave
warnings with the earlier patches.
That code has the following structure.
#define SCTP_PACKED __attribute__((packed))
#define SCTP_IDENTIFICATION_SIZE 16
// ...
/* state cookie heade
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272885: Compilation for Intel MCU (Part 3/3) (authored by
aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D20675?vs=58592&id=60960#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20675
Author: aturetsk
Date: Thu Jun 16 05:49:27 2016
New Revision: 272885
URL: http://llvm.org/viewvc/llvm-project?rev=272885&view=rev
Log:
Compilation for Intel MCU (Part 3/3)
This is the last patch required to support compilation for Intel MCU target
(e.g. Intel(R) Quark(TM) micro controller D 2000
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272883: Compilation for Intel MCU (Part 2/3) (authored by
aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D19274?vs=57017&id=60958#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19274
Author: aturetsk
Date: Thu Jun 16 05:36:09 2016
New Revision: 272883
URL: http://llvm.org/viewvc/llvm-project?rev=272883&view=rev
Log:
Compilation for Intel MCU (Part 2/3)
This is the second patch required to support compilation for Intel MCU target
(e.g. Intel(R) Quark(TM) micro controller D 20
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D21150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev abandoned this revision.
ABataev added a comment.
Revision is abandoned as the construct is supported already.
http://reviews.llvm.org/D15321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
jojo added a comment.
> I recommend you squash this patch with D21276 before commit.
Hi, Renato,
Do you mean updating the diff to let it include the change of
http://reviews.llvm.org/D21276,or commiting these two reviews as one commit?
Repository:
rL LLVM
http://reviews.llvm.org/D21277
rogfer01 updated the summary for this revision.
rogfer01 updated this revision to Diff 60951.
rogfer01 added a comment.
Thanks @rsmith for the suggestions. I removed the whitelisting totally and
changed the strategy. This patch implements your second suggestion which seemed
more obvious to me. S
Maybe this should use the marketing name ("before msvc 2013")? People might
be more familiar with that.
On Jun 15, 2016 2:34 AM, "Saleem Abdulrasool via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Tue Jun 14 19:28:15 2016
> New Revision: 272741
>
> URL: http://llvm
rengolin added a comment.
Hi Jojo,
This looks good to me, and I recommend you squash this patch with
http://reviews.llvm.org/D21276 before commit. But I'll let @echristo and
@compnerd have the final say.
cheers,
--renato
Repository:
rL LLVM
http://reviews.llvm.org/D21277
__
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r272877.
Comment at: include/llvm/module.modulemap:121-126
@@ -106,8 +120,8 @@
// FIXME: Is this the right place for these?
module Pass { header "Pass.h" export * }
module PassSupport { header
88 matches
Mail list logo
