Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

EricWF added a comment. I checked in tests for the reported bug in r272642. They aren't the most portable so hopefully the pass on all supported platforms. http://reviews.llvm.org/D20903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[libcxx] r272642 - Update errcat.objects tests so they test the bug fixed in r272640.

Author: ericwf Date: Tue Jun 14 01:37:36 2016 New Revision: 272642 URL: http://llvm.org/viewvc/llvm-project?rev=272642&view=rev Log: Update errcat.objects tests so they test the bug fixed in r272640. Modified: libcxx/trunk/test/std/diagnostics/syserr/syserr.errcat/syserr.errcat.objects/gener

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

rmaprath added a comment. > > Fine by me. > > > > > > I didn't have much time to go through the patch, is there a way to disable > > this module from building? It won't compile for our targets until we put in > > some sort of a porting layer (which I need to start thinking of). Would be

[libcxx] r272641 - Fix syntax error in r272640.

Author: ericwf Date: Tue Jun 14 01:08:10 2016 New Revision: 272641 URL: http://llvm.org/viewvc/llvm-project?rev=272641&view=rev Log: Fix syntax error in r272640. Modified: libcxx/trunk/src/system_error.cpp Modified: libcxx/trunk/src/system_error.cpp URL: http://llvm.org/viewvc/llvm-project/

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

EricWF added a comment. In http://reviews.llvm.org/D20903#457252, @erik65536 wrote: > > The POSIX version of strerror_r() returns 0 on success, and any other value > > indicates an error (Reference > > ). > > > I should ha

[libcxx] r272640 - Fix error checking for strerror_r implementations that return the error code.

Author: ericwf Date: Tue Jun 14 01:03:20 2016 New Revision: 272640 URL: http://llvm.org/viewvc/llvm-project?rev=272640&view=rev Log: Fix error checking for strerror_r implementations that return the error code. Modified: libcxx/trunk/src/system_error.cpp Modified: libcxx/trunk/src/system_err

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

erik65536 added a comment. > The POSIX version of strerror_r() returns 0 on success, and any other value > indicates an error (Reference > ). I should have been more explicit when I wrote this recommendation. Checking if

Re: [PATCH] D21094: [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types.

EricWF added inline comments. Comment at: test/support/test_allocator.h:83 @@ -82,2 +82,3 @@ {return UINT_MAX / sizeof(T);} +#ifdef _LIBCPP_HAS_NO_RVALUE_REFERENCES void construct(pointer p, const T& val) `#if TEST_STD_VER < 11` Com

Re: [PATCH] D21096: [libcxx] [test] Fix MSVC warning C4125 "decimal digit terminates octal escape sequence".

EricWF closed this revision. EricWF added a comment. r272639. http://reviews.llvm.org/D21096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272639 - Avoid octal escape sequence warning with MSVC. Patch from s...@microsoft.com

Author: ericwf Date: Tue Jun 14 00:47:46 2016 New Revision: 272639 URL: http://llvm.org/viewvc/llvm-project?rev=272639&view=rev Log: Avoid octal escape sequence warning with MSVC. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/re/re.regex/re.regex.construct/awk_oct.pass.cpp

Re: [PATCH] D21096: [libcxx] [test] Fix MSVC warning C4125 "decimal digit terminates octal escape sequence".

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I'm not a fan of the warning, but it seems like a minimally invasive fix. http://reviews.llvm.org/D21096 ___ cfe-commits mailing list cfe-commits

Re: [libcxx] r272634 - Implement variadic lock_guard.

This is causing some of the libc++ bots to go red. `variadic_copy.fail.cpp` is encountering an error, which seems to be a clang bug which temporarily existed in 3.9. The test passes against current ToT and older clang releases and GCC. Please do not revert this commit due to that specific failure.

[libcxx] r272638 - Add missing include

Author: ericwf Date: Mon Jun 13 23:58:19 2016 New Revision: 272638 URL: http://llvm.org/viewvc/llvm-project?rev=272638&view=rev Log: Add missing include Modified: libcxx/trunk/test/std/thread/thread.mutex/thread.lock/thread.lock.guard/variadic_mutex.pass.cpp Modified: libcxx/trunk/test/std

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF added a comment. @mclow.lists What would you like to see in order to help this patch proceed? http://reviews.llvm.org/D20786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272637 - Temporarily XFAIL variadic lock_guard mangling test for GCC 4.9

Author: ericwf Date: Mon Jun 13 23:45:26 2016 New Revision: 272637 URL: http://llvm.org/viewvc/llvm-project?rev=272637&view=rev Log: Temporarily XFAIL variadic lock_guard mangling test for GCC 4.9 Modified: libcxx/trunk/test/libcxx/thread/thread.mutex/thread.lock/thread.lock.guard/variadic_m

Re: [PATCH] D21320: Alternative to D1332

EricWF added a comment. My personal preference would be to diagnose `std::default_delete` and `std::unique_ptr`, but I'll defer to your judgment here. An alternative implementation would be to provide a "default_delete" specialization. (Note that adding this specialization does not change the

Re: [PATCH] D21320: Alternative to D1332

mclow.lists updated this revision to Diff 60651. mclow.lists added a comment. @EricWF pointed out that this didn't actually suppress the warning that we were trying to suppress. All I can say is that it did several weeks ago when I wrote it. Apparently clang has gotten pickier. Use tag dispatch

[PATCH] D21320: Alternative to D1332

mclow.lists created this revision. mclow.lists added reviewers: EricWF, STL_MSFT. mclow.lists added a subscriber: cfe-commits. There's a bug in the standard, where the default deleter will always call `delete x`; even if `x` is an array type. This shows up for `shared_ptr`. Do the right thing,

[libcxx] r272634 - Implement variadic lock_guard.

Author: ericwf Date: Mon Jun 13 22:48:09 2016 New Revision: 272634 URL: http://llvm.org/viewvc/llvm-project?rev=272634&view=rev Log: Implement variadic lock_guard. Summary: This patch implements the variadic `lock_guard` paper. Making `lock_guard` variadic is a ABI breaking change because the

[libcxx] r272633 - Make system_error::message() thread safe. Fixes PR25598.

Author: ericwf Date: Mon Jun 13 22:45:31 2016 New Revision: 272633 URL: http://llvm.org/viewvc/llvm-project?rev=272633&view=rev Log: Make system_error::message() thread safe. Fixes PR25598. Summary: system_error::message() uses `strerror` for the generic and system categories. This function is n

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

EricWF updated this revision to Diff 60649. EricWF added a comment. Use named variable `strerror_buff_size` variable instead of literal `1024`. http://reviews.llvm.org/D20903 Files: src/system_error.cpp test/std/diagnostics/syserr/syserr.errcat/syserr.errcat.objects/generic_category.pass.c

Re: [PATCH] D21260: Implement variadic lock_guard.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. Thanks. http://reviews.llvm.org/D21260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D21260: Implement variadic lock_guard.

EricWF updated this revision to Diff 60647. EricWF added a comment. Use primary template `lock_guard<_MArgs...>` for the variadic implementation instead of specialization `lock_guard<_M1, _M2, _MRest...>`. http://reviews.llvm.org/D21260 Files: include/__config include/__mutex_base includ

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D20903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D21260: Implement variadic lock_guard.

EricWF updated this revision to Diff 60646. EricWF marked an inline comment as done. EricWF added a comment. Add a `__unlock` helper function. http://reviews.llvm.org/D21260 Files: include/__config include/__mutex_base include/mutex test/libcxx/thread/thread.mutex/thread.lock/thread.lo

[libcxx] r272632 - Ignore depricated warnings from and

Author: ericwf Date: Mon Jun 13 22:26:11 2016 New Revision: 272632 URL: http://llvm.org/viewvc/llvm-project?rev=272632&view=rev Log: Ignore depricated warnings from and Modified: libcxx/trunk/test/libcxx/containers/gnu_cxx/hash_map.pass.cpp libcxx/trunk/test/libcxx/containers/gnu_cxx/ha

r272631 - Fix PR28100 - Allow redeclarations of deleted explicit specializations.

Author: faisalv Date: Mon Jun 13 22:23:15 2016 New Revision: 272631 URL: http://llvm.org/viewvc/llvm-project?rev=272631&view=rev Log: Fix PR28100 - Allow redeclarations of deleted explicit specializations. See https://llvm.org/bugs/show_bug.cgi?id=28100. In r266561 when I implemented allowing ex

[libcxx] r272629 - Fix warnings in tests.

Author: ericwf Date: Mon Jun 13 22:21:49 2016 New Revision: 272629 URL: http://llvm.org/viewvc/llvm-project?rev=272629&view=rev Log: Fix warnings in tests. Modified: libcxx/trunk/test/std/experimental/utilities/tuple/tuple.apply/return_type.pass.cpp libcxx/trunk/test/std/input.output/fil

r272628 - [Parser] Handle __pragma(pack, etc. after type definitions

Author: majnemer Date: Mon Jun 13 22:20:28 2016 New Revision: 272628 URL: http://llvm.org/viewvc/llvm-project?rev=272628&view=rev Log: [Parser] Handle __pragma(pack, etc. after type definitions Support certain MS pragmas right after the closing curly brace of a class. Clang did not expect __prag

Re: [PATCH] D21098: [libcxx] [test] Replace __cplusplus comparisons with TEST_STD_VER and __has_feature with TEST_HAS_FEATURE.

EricWF added a comment. Please change the `TEST_HAS_FEATURE(XXX)` into `TEST_STD_VER >= 11` for the following C++11 features: - `cxx_noexcept` - `cxx_atomic` - `cxx_access_control_sfinae` Also if the entire test is wrapped in a `TEST_HAS_FEATURE(XXX)` please translate that into a `// UNSUPPORT

Re: r272604 - [docs] Coverage: Document the profile merge pool specifier

On Mon, Jun 13, 2016 at 5:42 PM, Vedant Kumar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vedantk > Date: Mon Jun 13 19:42:12 2016 > New Revision: 272604 > > URL: http://llvm.org/viewvc/llvm-project?rev=272604&view=rev > Log: > [docs] Coverage: Document the profile merge pool sp

Re: [PATCH] D21301: Detect recursive default argument definition

This revision was automatically updated to reflect the committed changes. Closed by commit rL272623: Detect recursive default argument definition (authored by sepavloff). Changed prior to commit: http://reviews.llvm.org/D21301?vs=60564&id=60644#toc Repository: rL LLVM http://reviews.llvm.or

Re: [PATCH] D21095: [libcxx] [test] Fix another MSVC warning C4101 "unreferenced local variable".

EricWF closed this revision. EricWF added a comment. r272622 http://reviews.llvm.org/D21095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272623 - Detect recursive default argument definition

Author: sepavloff Date: Mon Jun 13 21:55:56 2016 New Revision: 272623 URL: http://llvm.org/viewvc/llvm-project?rev=272623&view=rev Log: Detect recursive default argument definition If definition of default function argument uses itself, clang crashed, because corresponding function parameter is n

[libcxx] r272622 - Remove unused local var. Patch from s...@microsoft.com

Author: ericwf Date: Mon Jun 13 21:55:21 2016 New Revision: 272622 URL: http://llvm.org/viewvc/llvm-project?rev=272622&view=rev Log: Remove unused local var. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pa

[libcxx] r272621 - Prevent truncation warning. Patch from s...@microsoft.com

Author: ericwf Date: Mon Jun 13 21:54:15 2016 New Revision: 272621 URL: http://llvm.org/viewvc/llvm-project?rev=272621&view=rev Log: Prevent truncation warning. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/utilities/function.objects/unord.hash/floating.pass.cpp Modified: l

Re: [PATCH] D21093: [libcxx] [test] In unord.hash/floating.pass.cpp, add a static_cast to fix a truncation warning.

EricWF closed this revision. EricWF added a comment. r272621. http://reviews.llvm.org/D21093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21092: [libcxx] [test] Fix vector tests that were using ints copy-pasted from vector tests.

EricWF closed this revision. EricWF added a comment. r272620. http://reviews.llvm.org/D21092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272620 - Fix vector tests that were using ints. Patch from s...@microsoft.com

Author: ericwf Date: Mon Jun 13 21:53:04 2016 New Revision: 272620 URL: http://llvm.org/viewvc/llvm-project?rev=272620&view=rev Log: Fix vector tests that were using ints. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/containers/sequences/vector.bool/assign_copy.pass.cpp

[libcxx] r272619 - Rename variables to prevent shadowing. Patch from s...@microsoft.com

Author: ericwf Date: Mon Jun 13 21:51:13 2016 New Revision: 272619 URL: http://llvm.org/viewvc/llvm-project?rev=272619&view=rev Log: Rename variables to prevent shadowing. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.berno

Re: [PATCH] D20920: [libcxx] [test] Rename d to dbl in order to avoid shadowing distributions named d.

EricWF closed this revision. EricWF added a comment. r272619. http://reviews.llvm.org/D20920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20919: [libcxx] [test] Rename b to b2 in order to avoid shadowing between nested catch blocks.

EricWF closed this revision. EricWF added a comment. r272618. http://reviews.llvm.org/D20919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272618 - Avoid name shadowing in test. Patch from s...@microsoft.com

Author: ericwf Date: Mon Jun 13 21:47:46 2016 New Revision: 272618 URL: http://llvm.org/viewvc/llvm-project?rev=272618&view=rev Log: Avoid name shadowing in test. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/language.support/support.exception/except.nested/rethrow_if_nested.

[libcxx] r272617 - Silence more unused variable warnings. Patch from s...@microsoft.com

Author: ericwf Date: Mon Jun 13 21:46:39 2016 New Revision: 272617 URL: http://llvm.org/viewvc/llvm-project?rev=272617&view=rev Log: Silence more unused variable warnings. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/depr/depr.c.headers/wchar_h.pass.cpp Modified: libcxx/trun

Re: [PATCH] D20918: [libcxx] [test] Silence more "unreferenced local variable" warnings.

EricWF closed this revision. EricWF added a comment. r272617. http://reviews.llvm.org/D20918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

EricWF updated this revision to Diff 60642. EricWF added a comment. - Use a local buffer instead of a `static` `thread_local` one. - Save and restore errno in the POSIX implementation. http://reviews.llvm.org/D20903 Files: src/system_error.cpp test/std/diagnostics/syserr/syserr.errcat/syse

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

EricWF added a comment. In http://reviews.llvm.org/D20903#446922, @mclow.lists wrote: > In general, I'm OK with this - but I'm concerned about that there's not > really any provision for the case where `strerror_r` does not exist. > > Also, there's no reason to have a thread local static array h

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

EricWF added a comment. In http://reviews.llvm.org/D16948#456966, @rmaprath wrote: > In http://reviews.llvm.org/D16948#456929, @EricWF wrote: > > > Unless there are any objections I plan to commit this change on Friday. > > > > That will give it about a month of in-tree time before the 3.9 releas

Re: [PATCH] D21314: Make pair and tuple respect is_copy_assignable and is_move_assignable

EricWF updated this revision to Diff 60640. EricWF added a comment. Fix merge conflicts with master. http://reviews.llvm.org/D21314 Files: include/tuple include/utility test/test.pass.cpp Index: test/test.pass.cpp === --- /d

[libcxx] r272613 - Remove _LIBCPP_TRIVIAL_PAIR_COPY_CTOR option.

Author: ericwf Date: Mon Jun 13 20:36:15 2016 New Revision: 272613 URL: http://llvm.org/viewvc/llvm-project?rev=272613&view=rev Log: Remove _LIBCPP_TRIVIAL_PAIR_COPY_CTOR option. Added: libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/move_ctor.pass.cpp libcxx/trunk/test/std/util

r272610 - Remove stray semi-colon in *.py file, NFC

Author: vedantk Date: Mon Jun 13 20:14:50 2016 New Revision: 272610 URL: http://llvm.org/viewvc/llvm-project?rev=272610&view=rev Log: Remove stray semi-colon in *.py file, NFC Modified: cfe/trunk/utils/perf-training/perf-helper.py Modified: cfe/trunk/utils/perf-training/perf-helper.py URL:

r272609 - Remove nonsense and simplify. To forward a reference, we always just load the

Author: rsmith Date: Mon Jun 13 20:13:21 2016 New Revision: 272609 URL: http://llvm.org/viewvc/llvm-project?rev=272609&view=rev Log: Remove nonsense and simplify. To forward a reference, we always just load the pointer-to-pointer representing the parameter. An aggregate rvalue representing a point

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

2016-06-14 5:00 GMT+08:00 Rafael Espíndola : > Do you need someone to commit it for you? Yes, please :) Lei ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272605 - Add a test to ensure that pass_object_size is handled properly by a delegate constructor.

Author: rsmith Date: Mon Jun 13 19:48:35 2016 New Revision: 272605 URL: http://llvm.org/viewvc/llvm-project?rev=272605&view=rev Log: Add a test to ensure that pass_object_size is handled properly by a delegate constructor. Modified: cfe/trunk/test/CodeGenCXX/pass-object-size.cpp Modified: c

r272604 - [docs] Coverage: Document the profile merge pool specifier

Author: vedantk Date: Mon Jun 13 19:42:12 2016 New Revision: 272604 URL: http://llvm.org/viewvc/llvm-project?rev=272604&view=rev Log: [docs] Coverage: Document the profile merge pool specifier Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCovera

Re: [PATCH] D21314: Make pair and tuple respect is_copy_assignable and is_move_assignable

EricWF updated this revision to Diff 60638. EricWF added a comment. Actually get all of the tests passing. Sorry for the spam. http://reviews.llvm.org/D21314 Files: include/tuple include/utility test/test.pass.cpp Index: test/test.pass.cpp ===

Re: [PATCH] D21314: Make pair and tuple respect is_copy_assignable and is_move_assignable

EricWF updated this revision to Diff 60637. EricWF added a comment. All tests are now passing. http://reviews.llvm.org/D21314 Files: include/tuple include/utility test/test.pass.cpp Index: test/test.pass.cpp === --- /dev/nul

Re: [PATCH] D21314: Make pair and tuple respect is_copy_assignable and is_move_assignable

EricWF updated this revision to Diff 60636. EricWF added a comment. Get all but 1 test passing. http://reviews.llvm.org/D21314 Files: include/tuple include/utility test/test.pass.cpp Index: test/test.pass.cpp === --- /dev/nu

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

eugenis added a comment. For the context, this is supposed to fix this problem: https://bugs.chromium.org/p/chromium/issues/detail?id=618534 Of course there are other ways of dealing with that that do not require changing the compiler, but this change seems like the right thing to do. The limit

[PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

eugenis created this revision. eugenis added reviewers: pcc, kcc. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. The reason is that this (a) seems to work just fine and (b) is useful when building stuff with sanitizer+coverage, but needing to exc

Re: [PATCH] D21314: Make pair and tuple respect is_copy_assignable and is_move_assignable

EricWF updated this revision to Diff 60633. EricWF added a comment. Fix bad #ifdef change in pair. http://reviews.llvm.org/D21314 Files: include/tuple include/utility test/test.pass.cpp Index: test/test.pass.cpp === --- /dev

Re: [PATCH] D21314: Make pair and tuple respect is_copy_assignable and is_move_assignable

EricWF retitled this revision from "Make pair respect is_copy_assignable and is_move_assignable" to "Make pair and tuple respect is_copy_assignable and is_move_assignable". EricWF updated this revision to Diff 60631. EricWF added a comment. - Remove `= default` copy/move constructors in pair.

Re: [PATCH] D21145: [Sema] Fix crash on valid where instantiation of lambda cannot access type of 'this'

erik.pilkington updated this revision to Diff 60622. erik.pilkington added a comment. This patch removes the handmade loop from `Sema::getCurrentThisType` instead just using the result of `Sema::getFunctionLevelDeclContext`. I believe that this will always give us the nearest `CXXRecordDecl` tha

Re: [PATCH] D21306: [x86] AVX FP compare builtins should require AVX target feature (PR28112)

spatel added a comment. In http://reviews.llvm.org/D21306#456965, @echristo wrote: > The 128 bit versions should only be selecting for sse functions and shouldn't > need avx to work? What instructions are getting emitted here? No, the 128-bit versions of these C intrinsics are strictly for AVX

Re: [PATCH] D20561: Warn when taking address of packed member

On Mon, Jun 13, 2016 at 7:17 PM, Evgenii Stepanov wrote: > On Mon, Jun 13, 2016 at 4:12 PM, Aaron Ballman > wrote: >> On Mon, Jun 13, 2016 at 6:30 PM, Evgeniy Stepanov wrote: >>> eugenis added a subscriber: eugenis. >>> eugenis added a comment. >>> >>> In http://reviews.llvm.org/D20561#446031,

[PATCH] D21314: Make pair respect is_copy_assignable and is_move_assignable

EricWF created this revision. EricWF added reviewers: mclow.lists, rsmith, K-ballo. EricWF added a subscriber: cfe-commits. This shows the basic jist of my proposed changes. I haven't tested them enough to ensure they are 100% correct. Can anybody suggest a better solution? http://reviews.llvm.

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

echristo added inline comments. Comment at: lib/Basic/Targets.cpp:5709 @@ -5715,1 +5708,3 @@ + +return false; } compnerd wrote: > Please collapse this: > > return Name == "generic" || llvm::AArch64::parseCPUArch(Name) != > llvm::ARM::AK_INVALID; ... w

Re: [PATCH] D20561: Warn when taking address of packed member

On Mon, Jun 13, 2016 at 4:12 PM, Aaron Ballman wrote: > On Mon, Jun 13, 2016 at 6:30 PM, Evgeniy Stepanov wrote: >> eugenis added a subscriber: eugenis. >> eugenis added a comment. >> >> In http://reviews.llvm.org/D20561#446031, @aaron.ballman wrote: >> >>> In http://reviews.llvm.org/D20561#44582

Re: [PATCH] D20561: Warn when taking address of packed member

On Mon, Jun 13, 2016 at 6:30 PM, Evgeniy Stepanov wrote: > eugenis added a subscriber: eugenis. > eugenis added a comment. > > In http://reviews.llvm.org/D20561#446031, @aaron.ballman wrote: > >> In http://reviews.llvm.org/D20561#445824, @rogfer01 wrote: >> >> > I think I wasn't clear with the pur

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

rmaprath added a comment. In http://reviews.llvm.org/D16948#456929, @EricWF wrote: > Unless there are any objections I plan to commit this change on Friday. > > That will give it about a month of in-tree time before the 3.9 release branch. Fine by me. I didn't have much time to go through the

Re: [PATCH] D21306: [x86] AVX FP compare builtins should require AVX target feature (PR28112)

echristo added a comment. The 128 bit versions should only be selecting for sse functions and shouldn't need avx to work? What instructions are getting emitted here? http://reviews.llvm.org/D21306 ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D20561: Warn when taking address of packed member

eugenis added a subscriber: eugenis. eugenis added a comment. In http://reviews.llvm.org/D20561#446031, @aaron.ballman wrote: > In http://reviews.llvm.org/D20561#445824, @rogfer01 wrote: > > > I think I wasn't clear with the purpose of the fix-it: there are a few > > cases where getting the addr

Re: [PATCH] D21260: Implement variadic lock_guard.

K-ballo added a subscriber: K-ballo. K-ballo added a comment. LGTM http://reviews.llvm.org/D21260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

EricWF added a comment. Unless there are any objections I plan to commit this change on Friday. That will give it about a month of in-tree time before the 3.9 release branch. http://reviews.llvm.org/D16948 ___ cfe-commits mailing list cfe-commits@l

Re: [PATCH] D21260: Implement variadic lock_guard.

EricWF marked an inline comment as done. Comment at: include/mutex:592-652 @@ -578,3 +591,63 @@ #endif // _LIBCPP_HAS_NO_VARIADICS + +#if defined(_LIBCPP_ABI_VARIADIC_LOCK_GUARD) \ +&& !defined(_LIBCPP_CXX03_LANG) +template <> +class _LIBCPP_TYPE_VIS_ONLY lock_guard<> { +p

Re: [PATCH] D21260: Implement variadic lock_guard.

EricWF updated this revision to Diff 60619. EricWF added a comment. Address review comments: - Update synopsis it `` - Add missing `// UNSUPPORTED: libcpp-has-no-threads` in tests. http://reviews.llvm.org/D21260 Files: include/__config include/__mutex_base include/mutex test/libcxx/th

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

twoh added a comment. Patch committed in http://reviews.llvm.org/rL272592. http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272592 - Patch for r272584 (http://reviews.llvm.org/rL272584) to address clang-x64-ninja-win7 buildbot failure.

Author: twoh Date: Mon Jun 13 16:55:33 2016 New Revision: 272592 URL: http://llvm.org/viewvc/llvm-project?rev=272592&view=rev Log: Patch for r272584 (http://reviews.llvm.org/rL272584) to address clang-x64-ninja-win7 buildbot failure. Patch by Eric Niebler Modified: cfe/trunk/lib/Lex/PPDire

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler updated this revision to Diff 60615. eric_niebler added a comment. s/`constexpr`/`const`/ http://reviews.llvm.org/D19843 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Basic/FileManager.h include/clang/Basic/VirtualFileSystem.h include/clang/Lex/DirectoryLoo

Re: [PATCH] D21260: Implement variadic lock_guard.

mclow.lists added a comment. You should only get the multi-mutex version in C++17. Comment at: include/mutex:579 @@ -578,2 +578,3 @@ #endif // _LIBCPP_HAS_NO_VARIADICS + You need to update the synopsis at the top of the file. http://reviews.llvm.org/D21260

Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added a comment. Win2008 buildbot //still// unhappy. Sorry about this guys. I suppose it's the `constexpr`. We don't have a win2008 machine locally to test on. Is there a way for us to run this through your gauntlet without actually doing a commit? http://reviews.llvm.org/D19843

Re: [PATCH] D21030: [Sema] Fix rejects-valid where parameter pack was not expanded in type alias

erik.pilkington added a comment. Ping! http://reviews.llvm.org/D21030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21260: Implement variadic lock_guard.

EricWF updated this revision to Diff 60609. EricWF added a comment. - Add missing `_LIBCPP_ABI_VARIADIC_LOCK_GUARD` macro in `__config`. - Update `cxx1z_status.html`. http://reviews.llvm.org/D21260 Files: include/__config include/__mutex_base include/mutex test/libcxx/thread/thread.mut

Re: [PATCH] D21260: Implement variadic lock_guard.

EricWF updated this revision to Diff 60605. EricWF added a comment. Add a variadic lock_guard test that compiles in C++03. This tests the C++11 behavior of lock_guard but using the new implementation. http://reviews.llvm.org/D21260 Files: include/__mutex_base include/mutex test/libcxx/t

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: docs/ReleaseNotes.rst:238 @@ +237,3 @@ + + This check finds places where we are returning object of a different type than + the function return type. In such places, we should use std::move, otherwise --

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao updated this revision to Diff 60604. sfantao added a comment. Herald added a subscriber: mehdi_amini. - Rebase. http://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp ==

Re: [PATCH] D21260: Implement variadic lock_guard.

EricWF updated the summary for this revision. EricWF updated this revision to Diff 60602. EricWF added a comment. Address K-ballo's comments: - Remove `mutex_type` typedef when `sizeof...(MutexTypes) > 1`. - Move the variadic `lock_guard` implementation into `` instead of `<__mutex_base>`. This

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

Hi David, IIUC Eric Feiveson drives Visual Studio visualizers. I'll email him (and will also demo to STL in Oulu). Best, Mike On Monday, June 13, 2016, David Blaikie wrote: > > > On Mon, Jun 13, 2016 at 8:55 AM, Michael Spertus > wrote: > >> Hi David, >> While I understand the initial reasonin

r272587 - [Parser] Only correct delayed typos when needed

Author: epilk Date: Mon Jun 13 15:56:45 2016 New Revision: 272587 URL: http://llvm.org/viewvc/llvm-project?rev=272587&view=rev Log: [Parser] Only correct delayed typos when needed ActOnBinOp corrects delayed typos when in C mode; don't correct them in that case. Fixes PR26700. Differential Revis

Re: [PATCH] D20490: [Parser] Fix a crash on invalid where a delayed TypoExpr was corrected twice

This revision was automatically updated to reflect the committed changes. Closed by commit rL272587: [Parser] Only correct delayed typos when needed (authored by epilk). Changed prior to commit: http://reviews.llvm.org/D20490?vs=57980&id=60603#toc Repository: rL LLVM http://reviews.llvm.org

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

Do you need someone to commit it for you? On Jun 13, 2016 9:50 AM, "Lei Zhang via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > 2016-06-13 21:21 GMT+08:00 Felix Janda : > > [Added CC to the musl list] > > > > Lei Zhang wrote: > >> 2016-06-13 3:07 GMT+08:00 Joerg Sonnenberger : > >> > On Sun,

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Prazek added inline comments. Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:53 @@ +52,3 @@ +/// matches the given matcher. +AST_MATCHER_P(QualType, ignoringRefsAndConsts, + ast_matchers::internal::Matcher, InnerMatcher) { {meme, src="instr

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

twoh closed this revision. twoh added a comment. Committed by commit http://reviews.llvm.org/rL272584 http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Prazek added inline comments. Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:43 @@ +42,3 @@ +/// matches "b(1)". +AST_MATCHER_P(CXXConstructExpr, ctorCallee, + ast_matchers::internal::Matcher, This seems like a usefull matcher. We should

r272584 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

Author: twoh Date: Mon Jun 13 15:40:21 2016 New Revision: 272584 URL: http://llvm.org/viewvc/llvm-project?rev=272584&view=rev Log: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths. Differential Revision: http://reviews.llvm.org/D19843 Corre

r272583 - clang-cl: Support -resource-dir option (PR28074)

Author: hans Date: Mon Jun 13 15:31:30 2016 New Revision: 272583 URL: http://llvm.org/viewvc/llvm-project?rev=272583&view=rev Log: clang-cl: Support -resource-dir option (PR28074) It's useful e.g. for distributed build systems. Modified: cfe/trunk/include/clang/Driver/Options.td cfe/trun

[PATCH] D21306: [x86] AVX FP compare builtins should require AVX target feature (PR28112)

spatel created this revision. spatel added reviewers: echristo, bogner, RKSimon. spatel added a subscriber: cfe-commits. Herald added subscribers: mehdi_amini, mcrosier. This is a fix for PR28112: https://llvm.org/bugs/show_bug.cgi?id=28112 The FP comparison intrinsics that take an immediate para

Re: [PATCH] D20490: [Parser] Fix a crash on invalid where a delayed TypoExpr was corrected twice

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Let's go ahead with this for now and figure out the proper way to handle this as a follow-up change. http://reviews.llvm.org/D20490 ___ cfe-comm

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow added a comment. ping http://reviews.llvm.org/D19815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   >