Author: chandlerc
Date: Sat Jun 11 01:32:56 2016
New Revision: 272456
URL: http://llvm.org/viewvc/llvm-project?rev=272456&view=rev
Log:
Fix this test to handle NDEBUG builds which don't have a name for the
basic block.
Modified:
cfe/trunk/test/CodeGen/avx512vlbw-builtins.c
Modified: cfe/trun
Author: chandlerc
Date: Fri Jun 10 23:57:29 2016
New Revision: 272454
URL: http://llvm.org/viewvc/llvm-project?rev=272454&view=rev
Log:
Revert "Strip Android version when looking up toolchain paths."
This reverts commit r272413. The tests here have been failing on several
different build bots for
This broke several bots that have now been red most of the day. Here are
recent builds that show the failure:
http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/4611
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/6331
http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-
Author: chandlerc
Date: Fri Jun 10 23:45:38 2016
New Revision: 272453
URL: http://llvm.org/viewvc/llvm-project?rev=272453&view=rev
Log:
Revert "[ASTMatchers] New forEachOverriden matcher."
This reverts commit r272386. It doesn't compile with MSVC and those bots
have been red the entire day as a c
This has broken Windows build bots all day. Here are some recent examples:
http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/8506/steps/ninja%20check%201/logs/stdio
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/12981/steps/ninja%20check%201/logs/stdio
Please pay a
Author: ctopper
Date: Fri Jun 10 22:31:13 2016
New Revision: 272452
URL: http://llvm.org/viewvc/llvm-project?rev=272452&view=rev
Log:
[AVX512] Implement 512-bit and masked shufflelo and shufflehi intrinsics
directly with __builtin_shufflevector and __builtin_ia32_select. Also improve
the formatt
Author: ctopper
Date: Fri Jun 10 22:31:07 2016
New Revision: 272451
URL: http://llvm.org/viewvc/llvm-project?rev=272451&view=rev
Log:
[AVX512] Add _mm512_bsrli_epi128 and _mm512_bslli_epi128 intrinsics.
Modified:
cfe/trunk/lib/Headers/avx512bwintrin.h
cfe/trunk/test/CodeGen/avx512bw-built
Author: mps
Date: Fri Jun 10 22:02:33 2016
New Revision: 272448
URL: http://llvm.org/viewvc/llvm-project?rev=272448&view=rev
Log:
Visual Studio visualizers associated with LookupResults
Visualizers for DeclAccessPair, UnresolvedSet, and LookupResult. For example,
when combined with LLVM diff D212
mspertus created this revision.
mspertus added reviewers: aaron.ballman, zturner, aemerson.
mspertus added a subscriber: cfe-commits.
When visualizing small vectors in VS2015, show the first few elements in the
DisplayString instead of the size. For example, a `SmallVector` of
`DeclAccessPair` w
Author: majnemer
Date: Fri Jun 10 20:25:04 2016
New Revision: 272447
URL: http://llvm.org/viewvc/llvm-project?rev=272447&view=rev
Log:
[Sema] Return an appropriate result from CheckSpecifiedExceptionType
We shouldn't return true from CheckSpecifiedExceptionType if
the record type is incomplete an
probinson created this revision.
probinson added reviewers: chh, ismail.
probinson added a subscriber: cfe-commits.
Herald added subscribers: danalbert, tberghammer.
Capture the resource directory and use it for subsequent checks.
This is the same tactic used in linux-header-search.cpp.
http://r
vsk added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:41
@@ +40,3 @@
+ // (and destructed) as in push_back case.
+ auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl(
+ ofClass(hasAnyName("std::shared_ptr", "std::unique_ptr", "std::auto_ptr"
pirama updated this revision to Diff 60425.
pirama added a comment.
Convert error to warning, update tests, and rename variable name.
http://reviews.llvm.org/D20602
Files:
include/clang/AST/Type.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/Expr.cpp
lib/Sema/SemaExprMember.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272443: Add `REQUIRES: c++experimental` where appropriate.
(authored by danalbert).
Changed prior to commit:
http://reviews.llvm.org/D21247?vs=60420&id=60421#toc
Repository:
rL LLVM
http://reviews.l
Author: danalbert
Date: Fri Jun 10 17:45:11 2016
New Revision: 272443
URL: http://llvm.org/viewvc/llvm-project?rev=272443&view=rev
Log:
Add `REQUIRES: c++experimental` where appropriate.
Summary:
I haven't added it to all the tests, just those that fail without it
(those that aren't header only).
danalbert created this revision.
danalbert added reviewers: EricWF, mclow.lists.
danalbert added a subscriber: cfe-commits.
I haven't added it to all the tests, just those that fail without it
(those that aren't header only).
http://reviews.llvm.org/D21247
Files:
test/libcxx/experimental/memo
Author: mps
Date: Fri Jun 10 17:25:43 2016
New Revision: 272441
URL: http://llvm.org/viewvc/llvm-project?rev=272441&view=rev
Log:
Added missing close brace to OpaquePtr Visual Studio visualizer
This syntax error resulted in garbage being appended to OpaquePtr visualizations
Modified:
cfe/tru
pirama updated this revision to Diff 60412.
pirama added a comment.
Rebase after submission of http://reviews.llvm.org/D21240.
http://reviews.llvm.org/D21212
Files:
docs/ReleaseNotes.rst
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
==
Author: pirama
Date: Fri Jun 10 16:51:18 2016
New Revision: 272438
URL: http://llvm.org/viewvc/llvm-project?rev=272438&view=rev
Log:
Revise RenderScript attribute declaration
Summary:
Address post-patch comments to r272342.
- Rename the 'kernel' attribute's name
- Idiomatically restrict the attr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272438: Revise RenderScript attribute declaration (authored
by pirama).
Changed prior to commit:
http://reviews.llvm.org/D21240?vs=60397&id=60411#toc
Repository:
rL LLVM
http://reviews.llvm.org/D212
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900
@@ -7897,1 +7899,3 @@
+def err_opencl_ext_vector_type_rgba_selector: Error<
+ "vector component name '%0' cannot be used earlier than OpenCL version 2.2">;
} // end of sema category
---
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Comment at: include/clang/Basic/Attr.td:735
@@ -733,2 +734,3 @@
let Subjects = SubjectList<[Function]>;
let Documentation = [Undocumented]
yaxunl added a comment.
In http://reviews.llvm.org/D20979#453632, @Anastasia wrote:
> In http://reviews.llvm.org/D20979#452616, @yaxunl wrote:
>
> > In http://reviews.llvm.org/D20979#452463, @Anastasia wrote:
> >
> > > Looking good generally, I am just not sure about mixing two different
> > > r
EricWF added a comment.
@mclow.lists Just a reminder that 3.9 branches for release on July 19th.
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
That was certainly one of the counterarguments (& global variables also use
a type rather than a size). I've not really settled on which way to
go/haven't given it lots of thought. I may loop back around to the original
thread when it comes to that.
On Fri, Jun 10, 2016 at 2:18 PM, James Y Knight
Yes, it was intended to -- at least for bitcode produced by clang.
I do think it would be a good idea to continue to pass the value type to
byval, though...Either that or get rid of the type in the "alloca"
instruction. They're basically doing the same thing, and having them
specified completely d
Excuse the necromancy, but do you know if this change (or other work you
did in this area) completely eclipsed LLVM's use of inferred alignment via
the llvm struct's alignment for byval arguments?
I ask because this was something I was going to need to fix for the
typeless pointer work & I have so
timshen reopened this revision.
timshen added a comment.
This revision is now accepted and ready to land.
Clang-tidy is broken by this change. Dependency is added to track the fix.
Repository:
rL LLVM
http://reviews.llvm.org/D20498
___
cfe-commit
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
This is a fix for the new ExprWithCleanups introduced by clang's temporary
variable lifetime marks change.
http://reviews.llvm.org/D21243
Files:
clang-tidy/llvm/TwineLocalCheck.cpp
clan
Uploaded http://reviews.llvm.org/D21240 with the requested changes.
On Fri, Jun 10, 2016 at 7:39 AM, Aaron Ballman
wrote:
> > +def Kernel : Attr {
>
> Please rename this to RenderScriptKernel. We have another attribute
> that is spelled "kernel" already, and we want to distinguish between
> them
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This is part of the fix of clang-tidy patterns to adapt to newly added
ExprWithCleanups node.
http://reviews.llvm.org/D21241
Files:
include/clang/ASTMat
pirama created this revision.
pirama added reviewers: aaron.ballman, rsmith.
pirama added subscribers: srhines, cfe-commits.
Address post-patch comments to r272342.
- Rename the 'kernel' attribute's name
- Idiomatically restrict the attribute to the 'RenderScript' LangOpt.
http://reviews.llvm.or
yaxunl added inline comments.
Comment at: test/Headers/opencl-c-header.cl:53-54
@@ +52,4 @@
+// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -fdisable-module-hash -ftime-report %s 2
Hi Eric,
> On Jun 6, 2016, at 4:00 AM, Eric Liu via cfe-commits
> wrote:
>
> Author: ioeric
> Date: Mon Jun 6 06:00:13 2016
> New Revision: 271883
>
> URL: http://llvm.org/viewvc/llvm-project?rev=271883&view=rev
> Log:
> [clang-format] make header guard identification stricter (with Lexer).
>
Author: majnemer
Date: Fri Jun 10 15:21:15 2016
New Revision: 272425
URL: http://llvm.org/viewvc/llvm-project?rev=272425&view=rev
Log:
[-fms-extensions] Don't crash on explicit class-scope specializations & default
arguments
The code had a typo it was doing:
Param->setUninstantiatedDefaultArg(
pirama updated this revision to Diff 60394.
pirama added a comment.
Expand description of RenderScript kernel functions.
http://reviews.llvm.org/D21212
Files:
docs/ReleaseNotes.rst
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
Index: include/clang/Basic/AttrDocs.td
Author: compnerd
Date: Fri Jun 10 15:12:00 2016
New Revision: 272424
URL: http://llvm.org/viewvc/llvm-project?rev=272424&view=rev
Log:
Driver: make it easier to select the SjLj EH model
GCC still permits enabling the SjLj EH model. This is something which can be
done on various targets. Hoist t
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D19854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
yaxunl marked 2 inline comments as done.
Comment at: test/Headers/opencl-c-header.cl:70
@@ +69,3 @@
+// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t %s | FileCheck %s
+// RUN: %clan
zaks.anna added a comment.
Please, pull out the refactor into a separate commit and ask someone who often
reviews SemaChecking review it.
Comment at: lib/AST/CMakeLists.txt:10
@@ -9,2 +9,3 @@
ASTImporter.cpp
+ ASTStructure.cpp
ASTTypeTraits.cpp
Do we wan
Author: nico
Date: Fri Jun 10 13:53:04 2016
New Revision: 272415
URL: http://llvm.org/viewvc/llvm-project?rev=272415&view=rev
Log:
Remove a few gendered pronouns.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
tigerleapgorge updated this revision to Diff 60385.
tigerleapgorge added a comment.
Forgot to provide context last time.
Last patch was created using command: svn diff
This patch was created using command: svn diff --diff-cmd=diff -x -U99
http://reviews.llvm.org/D20710
Files:
test/CXX/bas
Author: jmgao
Date: Fri Jun 10 13:30:33 2016
New Revision: 272413
URL: http://llvm.org/viewvc/llvm-project?rev=272413&view=rev
Log:
Strip Android version when looking up toolchain paths.
Summary:
Android target triples can include a version number in the abi field
(e.g. 'aarch64-linux-android21')
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272413: Strip Android version when looking up toolchain
paths. (authored by jmgao).
Changed prior to commit:
http://reviews.llvm.org/D21163?vs=60294&id=60379#toc
Repository:
rL LLVM
http://reviews.l
Author: majnemer
Date: Fri Jun 10 13:24:41 2016
New Revision: 272412
URL: http://llvm.org/viewvc/llvm-project?rev=272412&view=rev
Log:
[-fms-extensions] Permit incomplete types in dynamic exception specifications
Microsoft headers, comdef.h and comutil.h, assume that this is an OK
thing to do. D
jmgao added a comment.
Thanks for the review!
http://reviews.llvm.org/D21163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Thu, Jun 9, 2016 at 5:31 PM, Joerg Sonnenberger via cfe-commits
wrote:
> On Wed, Jun 08, 2016 at 01:12:31AM +, Hans Wennborg via cfe-commits wrote:
>> There has been a patch for this before (http://reviews.llvm.org/D2972),
>> but this one is more general, as it works on the virtual filesyst
Any updates on this ?
On Thu, May 19, 2016 at 8:37 PM, Max Bazaliy
wrote:
> Hey,
>
> For some reason clang does not emit ObjC method and block annotations to
> IR. Here is a fix for that.
>
> --
> Max Bazaliy
>
--
Max Bazaliy
___
cfe-commits mailin
rengolin added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3817
@@ +3816,3 @@
+
+Value *Arg0 = EmitScalarExpr(E->getArg(0)); /* coproc */
+Value *Arg1 = EmitScalarExpr(E->getArg(1)); /* opc1 */
Would be better to use the comments as names and av
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D18170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: evandro
Date: Fri Jun 10 11:00:29 2016
New Revision: 272401
URL: http://llvm.org/viewvc/llvm-project?rev=272401&view=rev
Log:
[streambuf] Added call to traits_type::copy to common case in xsgetn()
Patch by Laman Sole , Sebastian Pop
, Aditya Kumar
Differential Revision: http://reviews.l
steven_wu created this revision.
steven_wu added reviewers: rsmith, dexonsmith.
steven_wu added subscribers: cfe-commits, jfb, dschuff.
Previously, all the cc1 options are passed to both compile stage and codegen
stage and almost all of them are embedded in the commandline section in the
object fi
Author: spetrovic
Date: Fri Jun 10 11:09:20 2016
New Revision: 272402
URL: http://llvm.org/viewvc/llvm-project?rev=272402&view=rev
Log:
This patch fixes target linker emulation for ARM 32 big endian.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/linux-ld.c
Modified: cfe/
Anastasia added a comment.
LGTM! Looks much cleaner now. Please, add me to related reviews later on.
Thanks!
http://reviews.llvm.org/D20681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
eric_niebler added a comment.
@rsmith wrote:
> Thanks for the updates, LGTM (@bruno, did you get the performance numbers you
> wanted?)
FWIW, I benchmarked (on Windows, where problems are likely to occur) with 3
implementations of `warnByDefaultOnWrongCase`: 1) `StringSwitch`, 2)
`StringSet`
aaron.ballman added a comment.
In http://reviews.llvm.org/D20428#452680, @hintonda wrote:
> The comment says to rebuild TypeSourceInfo, but isn't that what this does?
>
> if (TSInfo->getType() != FD->getType())
> Updated = getFunctionTypeWithExceptionSpec(*this, TSInfo->getType(), ESI);
>
aaron.ballman added a comment.
Richard, with the following test case, my patch currently fails an assertion in
`ASTContext::adjustExceptionSpec()` that I want to solve before committing:
template void f7() {
struct S { void g() noexcept(undefined_val); }; // expected-error{{use of
undecl
mlemay-intel updated this revision to Diff 60357.
mlemay-intel added a comment.
Added driver test.
http://reviews.llvm.org/D19854
Files:
lib/Driver/Driver.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
==
bcraig created this revision.
bcraig added reviewers: zaks.anna, dcoughlin, jordan_rose.
bcraig added a subscriber: cfe-commits.
During the core analysis, ExplodedNodes are added to the ExplodedGraph, and
those nodes are cached for deduplication purposes.
After core analysis, reports are generat
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:20
@@ -19,1 +19,3 @@
+namespace {
+
Instead of an unnamed namespace, you should use static functions per our
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2440
@@ +2439,3 @@
+ let Content = [{
+``__attribute__((kernel))`` is used to mark a ``kernel`` function in
RenderScript_. See the RenderScript_ documentation for more information.
+
--
Anastasia added inline comments.
Comment at: include/clang/Driver/CC1Options.td:670
@@ -669,21 +669,3 @@
-def cl_opt_disable : Flag<["-"], "cl-opt-disable">,
- HelpText<"OpenCL only. This option disables all optimizations. The default
is optimizations are enabled.">;
-def cl_s
On Thu, Jun 9, 2016 at 7:34 PM, Pirama Arumuga Nainar via cfe-commits
wrote:
> Author: pirama
> Date: Thu Jun 9 18:34:20 2016
> New Revision: 272342
>
> URL: http://llvm.org/viewvc/llvm-project?rev=272342&view=rev
> Log:
> RenderScript support in the Frontend
>
> Summary:
>
> Create a new Fronten
a.makarov created this revision.
a.makarov added a reviewer: rsmith.
a.makarov added a subscriber: cfe-commits.
It's a patch for PR28050. Seems like overloading resolution wipes out the first
standard conversion sequence (before user-defined conversion) in case of
deprecated string literal conve
bcraig closed this revision.
bcraig added a comment.
Completed: At revision: 272394
http://reviews.llvm.org/D20933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bcraig
Date: Fri Jun 10 08:22:13 2016
New Revision: 272394
URL: http://llvm.org/viewvc/llvm-project?rev=272394&view=rev
Log:
Preallocate ExplodedNode hash table
Rehashing the ExplodedNode table is very expensive. The hashing
itself is expensive, and the general activity of iterating over
sbarzowski added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:41
@@ +40,3 @@
+ // (and destructed) as in push_back case.
+ auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl(
+ ofClass(hasAnyName("std::shared_ptr", "std::unique_ptr", "std::au
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272387: [include-fixer] give users an option to show N more
headers in case there are… (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D21181?vs=60338&id=60342#toc
Repository:
Author: ioeric
Date: Fri Jun 10 07:09:33 2016
New Revision: 272387
URL: http://llvm.org/viewvc/llvm-project?rev=272387&view=rev
Log:
[include-fixer] give users an option to show N more headers in case there are
too many candidates.
Summary: give users an option to show N more headers in case the
courbet closed this revision.
courbet added a comment.
This was submitted as r272386.
http://reviews.llvm.org/D19324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: courbet
Date: Fri Jun 10 06:54:43 2016
New Revision: 272386
URL: http://llvm.org/viewvc/llvm-project?rev=272386&view=rev
Log:
[ASTMatchers] New forEachOverriden matcher.
Matches methods overridden by the given method.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trun
Anastasia marked 2 inline comments as done.
Anastasia added a comment.
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ogoffart updated this revision to Diff 60340.
ogoffart added a comment.
Using Parser::ConsumeAndStoreFunctionPrologue this time
http://reviews.llvm.org/D20821
Files:
lib/Parse/ParseCXXInlineMethods.cpp
lib/Parse/ParseObjc.cpp
lib/Parse/ParseStmt.cpp
lib/Parse/Parser.cpp
lib/Sema/SemaD
Anastasia updated this revision to Diff 60339.
Anastasia added a comment.
Fixed issue with block typedef.
http://reviews.llvm.org/D20249
Files:
include/clang/AST/Type.h
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/Basic
ioeric updated this revision to Diff 60338.
ioeric added a comment.
- remove option (a) in favor of option (m); show a new prompt on invalid option
instead of aborting.
http://reviews.llvm.org/D21181
Files:
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/tool/clang-include-fi
nhaustov updated this revision to Diff 60333.
nhaustov updated the summary for this revision.
nhaustov added a comment.
Fix summary.
http://reviews.llvm.org/D21224
Files:
include/clang/Driver/Compilation.h
lib/Driver/Compilation.cpp
Index: lib/Driver/Compilation.cpp
===
nhaustov created this revision.
nhaustov added a reviewer: tstellarAMD.
nhaustov added a subscriber: cfe-commits.
Currently output of child process, however in my use case, it
needs to be captured and presented to the user.
Add Redirect method to Compilation and use existing infrastructure
for re
peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.
I think the change looks fine and it looks small enough for me to approve.
http://reviews.llvm.org/D21022
___
cfe-commits mailing list
Anastasia updated this revision to Diff 60330.
Anastasia marked 2 inline comments as done.
Anastasia added a comment.
- Allow passing array of events as a valid event list object (following C
implicit cast rules of arrays to pointers) in enqueue_kernel function.
- Added failing test case!
- Rem
bkramer added a comment.
I'm not convinced that this use case is common enough to make the interface
more complex. Should we remove (a) in favor of this?
http://reviews.llvm.org/D21181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
mboehme created this revision.
mboehme added reviewers: alexfh, hokein.
mboehme added a subscriber: cfe-commits.
Conceptually, this is very close to the existing functionality of
misc-move-const-arg, which is why I'm adding it here and not creating a new
check. For example, for a type A that is
Hahnfeld added a comment.
@tra any more comments on this?
http://reviews.llvm.org/D18170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vmiklos
Date: Fri Jun 10 03:29:02 2016
New Revision: 272381
URL: http://llvm.org/viewvc/llvm-project?rev=272381&view=rev
Log:
clang-rename: fix the DynamicCastExpr test on ps4
It has RTTI disabled by default, so need to enable it explicitly.
Reviewers: silvas
Differential Revision: http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272381: clang-rename: fix the DynamicCastExpr test on ps4
(authored by vmiklos).
Changed prior to commit:
http://reviews.llvm.org/D21186?vs=60324&id=60326#toc
Repository:
rL LLVM
http://reviews.llvm
silvas accepted this revision.
silvas added a reviewer: silvas.
silvas added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D21186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
vmiklos updated this revision to Diff 60324.
vmiklos added a comment.
Correct diff this time.
http://reviews.llvm.org/D21186
Files:
test/clang-rename/DynamicCastExpr.cpp
Index: test/clang-rename/DynamicCastExpr.cpp
===
--- test/
Author: courbet
Date: Fri Jun 10 03:12:37 2016
New Revision: 272378
URL: http://llvm.org/viewvc/llvm-project?rev=272378&view=rev
Log:
test commit: remove trailing whitespace in comments
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified: cfe/trunk/include/clang/ASTMatchers/
vmiklos retitled this revision from "clang-rename: mark the DynamicCastExpr
test unsupported on ps4" to "clang-rename: fix the DynamicCastExpr test on ps4".
vmiklos updated the summary for this revision.
vmiklos updated this revision to Diff 60320.
vmiklos added a comment.
Ah, then the fix is sim
silvas added a comment.
In http://reviews.llvm.org/D21186#454497, @silvas wrote:
> > It has no RTTI, so the test would always fail in a non-interesting way.
>
>
> It does. There is a call to dynamic_cast on lines 20 and 21 of this test. You
> can fix this by explicitly adding -frtti I believe.
silvas added a subscriber: silvas.
silvas added a comment.
> It has no RTTI, so the test would always fail in a non-interesting way.
It does. There is a call to dynamic_cast on lines 20 and 21 of this test. You
can fix this by explicitly adding -frtti I believe.
http://reviews.llvm.org/D21186
90 matches
Mail list logo
