Re: Missing definition of a template virtual function

On Sun, Jun 5, 2016 at 10:27 PM, Srivastava, Sunil < sunil.srivast...@sony.com> wrote: > Hi Richard, > > > > Thanks for you analysis. I have some follow up questions though: > > > First, either of these two suggestions below should fix the bug, though it > may be better to do both. Right ? > Eith

r271873 - [AVX512] Convert masked palignr builtins directly to native IR similar to the other palignr builtins, but with a select to handle masking.

Author: ctopper Date: Mon Jun 6 01:13:01 2016 New Revision: 271873 URL: http://llvm.org/viewvc/llvm-project?rev=271873&view=rev Log: [AVX512] Convert masked palignr builtins directly to native IR similar to the other palignr builtins, but with a select to handle masking. Modified: cfe/trunk

r271866 - Slightly improve Visual Studio visualization of clang::Expr

Author: mps Date: Sun Jun 5 22:37:18 2016 New Revision: 271866 URL: http://llvm.org/viewvc/llvm-project?rev=271866&view=rev Log: Slightly improve Visual Studio visualization of clang::Expr Now it gives the StmtClass of the Expr as well as the type. It's still a long way from full visualization o

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

But what pipeline do we setup? For instance with ThinLTO we reduced the amount of passes ran during the compile phase with the expectation that more will run during the link, this would get fuzzy here... > On Jun 5, 2016, at 6:49 PM, Davide Italiano wrote: > > davide added a comment. > > In h

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

mehdi_amini added a comment. But what pipeline do we setup? For instance with ThinLTO we reduced the amount of passes ran during the compile phase with the expectation that more will run during the link, this would get fuzzy here... http://reviews.llvm.org/D21006 ___

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

davide added a comment. In http://reviews.llvm.org/D21006#449409, @dexonsmith wrote: > I agree with Mehdi. I expect `-S -flto` to give equivalent output to `-c > -flto`. > > In effect, with this change, `-flto -S` would silently ignore the `-flto` > flag. That doesn't make sense to me. I gu

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

rafael added a comment. Fair enough, let's keep it as is and try to update the build. Cheers, Rafael http://reviews.llvm.org/D21006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

Fair enough, let's keep it as is and try to update the build. Cheers, Rafael On Jun 5, 2016 9:28 PM, "Mehdi AMINI" wrote: > mehdi_amini added a comment. > > What makes me not comfortable with this change is that after that `-c` > would not involves codegen but `-S` would. > Indeed I am using so

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

I agree with Mehdi. I expect `-S -flto` to give equivalent output to `-c -flto`. In effect, with this change, `-flto -S` would silently ignore the `-flto` flag. That doesn't make sense to me. > On 2016-Jun-05, at 18:28, Mehdi AMINI wrote: > > mehdi_amini added a comment. > > What makes me

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. I agree with Mehdi. I expect `-S -flto` to give equivalent output to `-c -flto`. In effect, with this change, `-flto -S` would silently ignore the `-flto` flag. That doesn't make sense to me. http://reviews.llvm.org/D210

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

mehdi_amini added a comment. What makes me not comfortable with this change is that after that `-c` would not involves codegen but `-S` would. Indeed I am using sometimes `-flto -S` and I expect IR, that's what is the most logical to me considering what -c does. http://reviews.llvm.org/D21006

Re: r271692 - Don't pass --build-id to ld by default.

lgtm On Sun, Jun 5, 2016 at 3:31 PM, Rafael Espíndola wrote: > Patch attached. What do you think? > > Cheers, > Rafael > > > On 3 June 2016 at 16:11, Ed Maste wrote: > > On 3 June 2016 at 15:53, Nico Weber via cfe-commits > > wrote: > >> Can you add this to the release notes? It'll for example

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

OK, it prints assembly with ir in it. That doesn't apply to us since .BC is not elf. I guess we could just produce assembly. A .ll cannot be used for lto. So I guess this is OK, but please wait to see what others think. Cheers, Rafael On Jun 5, 2016 7:45 PM, "Davide Italiano" wrote: > davide

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

rafael added a comment. OK, it prints assembly with ir in it. That doesn't apply to us since .BC is not elf. I guess we could just produce assembly. A .ll cannot be used for lto. So I guess this is OK, but please wait to see what others think. Cheers, Rafael http://reviews.llvm.org/D21006

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

davide added a comment. In http://reviews.llvm.org/D21006#449380, @rafael wrote: > Can you check what GCC does? Sure. $ gcc flto.c -o flto.o -flto -S && cat flto.o |head -n 15 .file "flto.c" .section.gnu.lto_.inline.513e7babbe55b1f8,"e",@progbits .string "x\

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

rafael added a subscriber: rafael. rafael added a comment. Can you check what GCC does? http://reviews.llvm.org/D21006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

Can you check what GCC does? On Jun 5, 2016 6:40 PM, "Mehdi AMINI" wrote: > mehdi_amini added a comment. > > Duncan CC for opinion. > > > http://reviews.llvm.org/D21006 > > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

mehdi_amini added a comment. Duncan CC for opinion. http://reviews.llvm.org/D21006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

davide added a comment. In http://reviews.llvm.org/D21006#449365, @mehdi_amini wrote: > I'm not sure it is consistent with how we handle -flto, for instance -c means > usually to output an object file, but adding -flto indicates to dump bitcode > instead. I see two alternative approaches: 1.

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

mehdi_amini added a comment. I'm not sure it is consistent with how we handle -flto, for instance -c means usually to output an object file, but adding -flto indicates to dump bitcode instead. http://reviews.llvm.org/D21006 ___ cfe-commits mailing

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

davide updated this revision to Diff 59679. davide added a comment. Add a test, fix a typo. http://reviews.llvm.org/D21006 Files: lib/Driver/Driver.cpp test/CodeGen/2009-10-20-GlobalDebug.c test/CodeGen/emit-asm.c test/CodeGenCXX/cxx-apple-kext.cpp test/Driver/darwin-iphone-defaults.m

Re: [PATCH] D20687: Update hasDynamicExceptionSpec to use functionType instead of functionDecl.

aaron.ballman added a comment. In http://reviews.llvm.org/D20687#449312, @hintonda wrote: > This marcher was recently added, and has never been in a release. > Specifically, it was added by me in support of a checker that has now been > abandoned in lieu of a better approach -- the new approac

Re: [PATCH] D20687: Update hasDynamicExceptionSpec to use functionType instead of functionDecl.

hintonda added a comment. This marcher was recently added, and has never been in a release. Specifically, it was added by me in support of a checker that has now been abandoned in lieu of a better approach -- the new approach requires this change -- so I doubt it would break anything. That sa

Re: r271692 - Don't pass --build-id to ld by default.

Patch attached. What do you think? Cheers, Rafael On 3 June 2016 at 16:11, Ed Maste wrote: > On 3 June 2016 at 15:53, Nico Weber via cfe-commits > wrote: >> Can you add this to the release notes? It'll for example break chromium's >> crash server (we can fix this on our end by explicitly passi

[cfe-commitsatlists.llvm.org: r271801 - Add PIE magic for NetBSD. Add tests for the correct flags for]

Hi Tom, I'd like to merge this change for getting rid of the stupid '-pie is nont used' warnings and to actual make it do the right thing :) This doesn't affect any other targets. Joerg - Forwarded message from Joerg Sonnenberger via cfe-commits - Author: joerg Date: Sat Jun 4 15:03:2

Re: [PATCH] D20687: Update hasDynamicExceptionSpec to use functionType instead of functionDecl.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Sorry for the delayed response, this review got lost in my inbox! This change will break existing out-of-tree users and would be a regression. Instead, the matcher shou

r271836 - Fixing problem with rsqrt28_sd

Author: mzuckerm Date: Sun Jun 5 10:57:49 2016 New Revision: 271836 URL: http://llvm.org/viewvc/llvm-project?rev=271836&view=rev Log: Fixing problem with rsqrt28_sd maskz_rsqrt28_sd mapped to mask_rsqrt28_sd and not to the maskz. Modified: cfe/trunk/lib/Headers/avx512erintrin.h Modified:

Re: [PATCH] D20866: [Clang][AVX512]Adding set4 intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL271835: [Clang][AVX512]Adding set4 intrinsics (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20866?vs=59379&id=59667#toc Repository: rL LLVM http://reviews.llvm.org/D20866

r271835 - [Clang][AVX512]Adding set4 intrinsics

Author: mzuckerm Date: Sun Jun 5 10:43:30 2016 New Revision: 271835 URL: http://llvm.org/viewvc/llvm-project?rev=271835&view=rev Log: [Clang][AVX512]Adding set4 intrinsics Differential Revision: http://reviews.llvm.org/D20866 Modified: cfe/trunk/lib/Headers/avx512fintrin.h cfe/trunk/tes

Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32

This revision was automatically updated to reflect the committed changes. Closed by commit rL271832: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and… (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20871?vs=59659&id=59665#toc Repository: rL LLV

r271832 - [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32

Author: mzuckerm Date: Sun Jun 5 10:12:52 2016 New Revision: 271832 URL: http://llvm.org/viewvc/llvm-project?rev=271832&view=rev Log: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32 Differential Revision: http://reviews.llvm.org/D20871 Modified: c

[PATCH] D21002: [Clang][AVX512][BUILTIN]Adding intrinsics for range_round_{sd|ss}

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D21002 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512dqintrin.h test/CodeGen/avx512dq-builtins.c Index: test/CodeGe

Re: [PATCH] D20866: [Clang][AVX512]Adding set4 intrinsics

AsafBadouh accepted this revision. AsafBadouh added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D20626: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps

m_zuckerman updated this revision to Diff 59663. http://reviews.llvm.org/D20626 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c ++

Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - add test_mm512_setzero_pd() as well if you can. Comment at: test/CodeGen/avx512f-builtins.c:7291 @@ +7290,3 @@ + +__m512i test_mm512_setzero_ps() +{

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

bittnerbarni updated this revision to Diff 59661. bittnerbarni marked 6 inline comments as done. bittnerbarni added a comment. Removed the unnecessary hasDescendant calls and simplified the checker as suggested. Tested on LLVM codebase, with minor improvements in speed (~1%). http://reviews.llv

Re: [PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32

m_zuckerman updated this revision to Diff 59659. http://reviews.llvm.org/D20871 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c ++