Author: mprobst
Date: Tue May 17 01:29:33 2016
New Revision: 269748
URL: http://llvm.org/viewvc/llvm-project?rev=269748&view=rev
Log:
clang-format: [JS] simplify logic by parsing forward.
This also reduces complexity to O(n) from O(n^2) by avoiding backtracking
re-parses, and fixes length calcula
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269747: clang-format: [JS] fix template string width
counting. (authored by mprobst).
Changed prior to commit:
http://reviews.llvm.org/D20208?vs=57066&id=57434#toc
Repository:
rL LLVM
http://reviews
Author: mprobst
Date: Tue May 17 01:29:29 2016
New Revision: 269747
URL: http://llvm.org/viewvc/llvm-project?rev=269747&view=rev
Log:
clang-format: [JS] fix template string width counting.
Summary:
Simply looking at the final text greatly simplifies the algorithm and also
fixes a reported issue.
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Nice.
http://reviews.llvm.org/D20208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
I think, this looks good.
Manuel: Are you fine with this, design-wise?
Comment at: lib/Format/SortJavaScriptImports.cpp:77
@@ +76,3 @@
+return false;
+ // NB: empty UR
Author: ctopper
Date: Mon May 16 23:41:40 2016
New Revision: 269742
URL: http://llvm.org/viewvc/llvm-project?rev=269742&view=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512PF intrinsics. Remove
leading underscores from macro argument names. Add explicit typecasts to all
macro
Author: ctopper
Date: Mon May 16 23:41:42 2016
New Revision: 269743
URL: http://llvm.org/viewvc/llvm-project?rev=269743&view=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512VLBW intrinsics.
Remove leading underscores from macro argument names. Add explicit typecasts to
all macr
Author: ctopper
Date: Mon May 16 23:41:46 2016
New Revision: 269744
URL: http://llvm.org/viewvc/llvm-project?rev=269744&view=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512VLDQ intrinsics.
Remove leading underscores from macro argument names. Add explicit typecasts to
all macr
Author: ctopper
Date: Mon May 16 23:41:38 2016
New Revision: 269741
URL: http://llvm.org/viewvc/llvm-project?rev=269741&view=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512ER intrinsics. Remove
leading underscores from macro argument names. Add explicit typecasts to all
macro
Author: ctopper
Date: Mon May 16 23:41:33 2016
New Revision: 269739
URL: http://llvm.org/viewvc/llvm-project?rev=269739&view=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512BW intrinsics. Remove
leading underscores from macro argument names. Add explicit typecasts to all
macro
Author: ctopper
Date: Mon May 16 23:41:29 2016
New Revision: 269737
URL: http://llvm.org/viewvc/llvm-project?rev=269737&view=rev
Log:
[AVX512] Correct types for scalar double precision FMA intrinsics and single
precision getexp intrinsics.
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
Mod
Author: ctopper
Date: Mon May 16 23:41:36 2016
New Revision: 269740
URL: http://llvm.org/viewvc/llvm-project?rev=269740&view=rev
Log:
[AVX512] Add parentheses around macro arguments in AVX512DQ intrinsics. Remove
leading underscores from macro argument names. Add explicit typecasts to all
macro
Author: ctopper
Date: Mon May 16 23:41:32 2016
New Revision: 269738
URL: http://llvm.org/viewvc/llvm-project?rev=269738&view=rev
Log:
[AVX512] Fix return types in several test cases to match the intrinsic they're
testing.
Modified:
cfe/trunk/test/CodeGen/avx512f-builtins.c
Modified: cfe/tru
hintonda updated this revision to Diff 57432.
hintonda added a comment.
- Address additional comments.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/Us
Author: ctopper
Date: Mon May 16 22:42:31 2016
New Revision: 269734
URL: http://llvm.org/viewvc/llvm-project?rev=269734&view=rev
Log:
[X86] Add a few missing typecasts to intrinsics. Found by playing with
-fno-lax-vector-conversions on the builtin tests.
Modified:
cfe/trunk/lib/Headers/avx2i
Author: ctopper
Date: Mon May 16 22:42:25 2016
New Revision: 269733
URL: http://llvm.org/viewvc/llvm-project?rev=269733&view=rev
Log:
[AVX512] _m512_setzero_qi/hi should return __m512i.
Modified:
cfe/trunk/lib/Headers/avx512bwintrin.h
cfe/trunk/test/Headers/x86intrin-2.c
Modified: cfe/tr
Author: ctopper
Date: Mon May 16 22:42:15 2016
New Revision: 269732
URL: http://llvm.org/viewvc/llvm-project?rev=269732&view=rev
Log:
[AVX512] Fix odd formatting in intrinsic header.
Modified:
cfe/trunk/lib/Headers/avx512bwintrin.h
Modified: cfe/trunk/lib/Headers/avx512bwintrin.h
URL:
http:
Author: ctopper
Date: Mon May 16 22:42:37 2016
New Revision: 269735
URL: http://llvm.org/viewvc/llvm-project?rev=269735&view=rev
Log:
[X86] Fix a few intrinsic tests to use the return type that matches the
intrinsic they're testing.
Modified:
cfe/trunk/test/CodeGen/sse-builtins.c
Modified:
Author: mren
Date: Mon May 16 21:15:12 2016
New Revision: 269730
URL: http://llvm.org/viewvc/llvm-project?rev=269730&view=rev
Log:
Modules: set SystemHeader to true if we are building a system module.
If we are processing a #include from a module build, we should treat it
as a system header if we
petarj created this revision.
petarj added a reviewer: atanasyan.
petarj added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Change default CPU for MIPS32 Android. Now it is mips32 (rev1).
http://reviews.llvm.org/D20313
Files:
lib/Driver/Tools.cpp
test
sfantao marked 2 inline comments as done.
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5452
@@ +5451,3 @@
+ // in there.
+ for (const auto *C : D.getClausesOfKind()) {
+for (const auto *D : C->varlists()) {
---
sfantao updated this revision to Diff 57420.
sfantao added a comment.
- Move the flags adjustment for first private declarations to the mappable
expressions handler.
http://reviews.llvm.org/D20112
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_firstprivate_codegen.cpp
test/Ope
sfantao updated this revision to Diff 57419.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D20111
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_codegen.cpp
test/OpenMP/target_codegen_registration.cpp
test/OpenMP/target_data_codegen.cpp
test/OpenMP/target_enter
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
On Fri, May 13, 2016 at 12:01 AM, Filipe Cabecinhas wrote:
>
> > On 13 May 2016, at 07:03, Sean Silva wrote:
> >
> >
> >
> > On Thu, May 12, 2016 at 9:51 AM, Filipe Cabecinhas via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> > Author: filcab
> > Date: Thu May 12 11:51:36 2016
> > New Rev
Author: rsmith
Date: Mon May 16 18:07:58 2016
New Revision: 269721
URL: http://llvm.org/viewvc/llvm-project?rev=269721&view=rev
Log:
Less broken fix for buildbot breakage.
Modified:
cfe/trunk/include/clang/AST/AttrIterator.h
Modified: cfe/trunk/include/clang/AST/AttrIterator.h
URL:
http://l
After this tweak, Chromium builds cleanly with the new warning enabled.
Maybe it's time to turn it on by default.
On Wed, May 11, 2016 at 1:43 PM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Wed May 11 12:43:13 2016
> New Revision: 269214
>
> URL: http
Author: rsmith
Date: Mon May 16 18:03:40 2016
New Revision: 269720
URL: http://llvm.org/viewvc/llvm-project?rev=269720&view=rev
Log:
Try to make the buildbots green again: avoid the need for class Attr to be
complete for users of AttrVec.
Modified:
cfe/trunk/include/clang/AST/AttrIterator.h
Author: kromanova
Date: Mon May 16 17:54:45 2016
New Revision: 269718
URL: http://llvm.org/viewvc/llvm-project?rev=269718&view=rev
Log:
Doxygen comments for avxintrin.h.
Added doxygen comments to avxintrin.h's intrinsics. As of now, only around 50%
of the intrinsics in this file are documented h
Author: rsmith
Date: Mon May 16 17:53:19 2016
New Revision: 269717
URL: http://llvm.org/viewvc/llvm-project?rev=269717&view=rev
Log:
Switch from SmallVector to TinyPtrVector for the list of attributes on a
declaration. This removes a memory allocation for the common case where the
declaration ha
Author: rsmith
Date: Mon May 16 17:52:23 2016
New Revision: 269716
URL: http://llvm.org/viewvc/llvm-project?rev=269716&view=rev
Log:
Avoid O(n^2) string analysis when handling GNU __asm__ statements.
Modified:
cfe/trunk/lib/AST/Stmt.cpp
Modified: cfe/trunk/lib/AST/Stmt.cpp
URL:
http://llvm.
rsmith added inline comments.
Comment at: include/clang/AST/DeclCXX.h:522
@@ -545,7 +521,3 @@
- typedef LazyDefinitionDataPtr
- DefinitionDataPtr;
- friend class LazyDefinitionDataPtr;
-
- mutable DefinitionDataPtr DefinitionData;
+ mutable DefinitionData* DefinitionDat
v.g.vassilev created this revision.
v.g.vassilev added a reviewer: rsmith.
v.g.vassilev added a subscriber: cfe-commits.
v.g.vassilev set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D20302
Files:
include/clang/AST/DeclCXX.h
lib/AST/DeclCXX.cpp
Author: probinson
Date: Mon May 16 16:25:15 2016
New Revision: 269709
URL: http://llvm.org/viewvc/llvm-project?rev=269709&view=rev
Log:
[PS4] Tighten up a test (noticed in passing)
Modified:
cfe/trunk/test/Driver/ps4-linker-win.c
Modified: cfe/trunk/test/Driver/ps4-linker-win.c
URL:
http://
aaron.ballman added inline comments.
Comment at: test/clang-tidy/modernize-use-noexcept-macro.cpp:11
@@ +10,3 @@
+
+// Should not trigger a FixItHint
+class A {};
hintonda wrote:
> aaron.ballman wrote:
> > I may have missed some context in the discussion, but why
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:46
@@ +45,3 @@
+ const SmallVector &Tokens) {
+ // Find throw token -- it's a keyword, so there can't be more than one.
Also,
+ // it should be near the end of the decla
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:21
@@ +20,3 @@
+
+static StringRef
+makeDynamicExceptionString(const SourceManager &SM,
hintonda wrote:
> aaron.ballman wrote:
> > Instead of a bunch of static functions, wo
hubert.reinterpretcast added a comment.
Ping (#2).
http://reviews.llvm.org/D19322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
Below are some buildbot numbers for the last week of 5/08/2016 - 5/14/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
Author: vedantk
Date: Mon May 16 16:04:19 2016
New Revision: 269701
URL: http://llvm.org/viewvc/llvm-project?rev=269701&view=rev
Log:
Revert "Reapply^2 "[ProfileData] (clang) Use Error in InstrProf and Coverage,
NFC""
This reverts commit r269695. The llvm commit does not pass the MSVC bot.
Modi
Author: vedantk
Date: Mon May 16 15:50:13 2016
New Revision: 269695
URL: http://llvm.org/viewvc/llvm-project?rev=269695&view=rev
Log:
Reapply^2 "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"
Sync up with "(llvm) Use Error in InstrProf and Coverage".
Differential Revision: http:
Author: spyffe
Date: Mon May 16 15:48:03 2016
New Revision: 269693
URL: http://llvm.org/viewvc/llvm-project?rev=269693&view=rev
Log:
Added support to the ASTImporter for C++ constructor initializers.
Also added named casts and propagation of "implicit" to fix the LLDB testsuite.
This is a fixed co
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:21
@@ +20,3 @@
+
+static StringRef
+makeDynamicExceptionString(const SourceManager &SM,
aaron.ballman wrote:
> Instead of a bunch of static functions, would an unnamed namespace
Hello everyone,
I am cleaning zorg a little and going to remove the next builder modules
since they are not in use for a long time now:
If anyone have plans for any of them please speak up!
ChrootSetup.py
DragonEggBuilder.py
KLEEBuilder.py
ScriptedBuilder.py
gccSuiteBuilder.py
Thanks
Galina
___
yaxunl updated this revision to Diff 57393.
yaxunl added a comment.
Update test.
http://reviews.llvm.org/D20133
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGenOpenCL/as_type.cl
Index: test/CodeGenOpenCL/as_type.cl
===
--- /de
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:21
@@ +20,3 @@
+
+static StringRef
+makeDynamicExceptionString(const SourceManager &SM,
Instead of a bunch of static functions, would an unnamed namespace make more
sense?
yaxunl updated this revision to Diff 57392.
yaxunl added a comment.
Add a test for casting char16 to i3 as Alexey suggested.
http://reviews.llvm.org/D20133
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGenOpenCL/as_type.cl
Index: test/CodeGenOpenCL/as_type.cl
===
Author: majnemer
Date: Mon May 16 15:30:03 2016
New Revision: 269687
URL: http://llvm.org/viewvc/llvm-project?rev=269687&view=rev
Log:
[Lex] inferModuleFromLocation should do no work if there are no modules
getModuleContainingLocation ends up on the hot-path for typical C code
which can lead to c
cdavis5x marked an inline comment as done.
Comment at: include/clang/Basic/Attr.td:2032
@@ -2031,1 +2031,3 @@
+def MSHookPrologue : InheritableAttr {
+ let Spellings = [GCC<"ms_hook_prologue">];
aaron.ballman wrote:
> Does this attribute appertain to all target
cdavis5x updated this revision to Diff 57389.
cdavis5x added a comment.
- Use Sanjoy's `patchable-function` attribute.
- Add documentation for this new attribute.
http://reviews.llvm.org/D19909
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/TargetInfo.cpp
sbenza added inline comments.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:83
@@ +82,3 @@
+ if (!IsConstQualified) {
+auto Matches = utils::decl_ref_expr::allDeclRefExprs(
+*Param, *Function->getBody(), *Result.Context);
We should
vmiklos created this revision.
vmiklos added reviewers: klimek, cfe-commits.
Even if this is defined in the .cpp file and only used as part of the
function (so here it's safe), usually storing StringRefs in the class is
dangerous, so don't do so.
http://reviews.llvm.org/D20296
Files:
clang-ren
Hi Michael,
have you see then trhead "The intrinsics headers (especially avx512) are
too big. What to do about it?"? Can you maybe comment on it?
Thanks,
Nico
On Mon, May 16, 2016 at 2:57 PM, Michael Zuckerman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mzuckerm
> Date: Mon M
Author: mzuckerm
Date: Mon May 16 13:57:24 2016
New Revision: 269680
URL: http://llvm.org/viewvc/llvm-project?rev=269680&view=rev
Log:
[Clang][AVX512] completing missing intrinsics for [vpabs] instruction set
Differential Revision: http://reviews.llvm.org/D20069
Modified:
cfe/trunk/lib/Heade
Thanks! Committed in r269679
Steven
> On May 16, 2016, at 11:54 AM, Rafael Espíndola
> wrote:
>
> LGTM
>
> On 16 May 2016 at 14:03, Steven Wu wrote:
>>
>>> On May 16, 2016, at 6:52 AM, Rafael Espíndola
>>> wrote:
>>>
>>> + auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true);
>
Author: steven_wu
Date: Mon May 16 13:54:58 2016
New Revision: 269679
URL: http://llvm.org/viewvc/llvm-project?rev=269679&view=rev
Log:
Change embed-bitcode linkage type
Embedded bitcode should have private linkage instead of appending or external.
Otherwise, it will cause link failure due to dup
LGTM
On 16 May 2016 at 14:03, Steven Wu wrote:
>
>> On May 16, 2016, at 6:52 AM, Rafael Espíndola
>> wrote:
>>
>> + auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true);
>>
>> Please use an explicit type instead of auto.
>
> Sure.
>
>>
>> You deleted the assert
>
> Are you referring t
meadori added a comment.
Hmmm, it works on trunk r269671. Not sure what happened before.
http://reviews.llvm.org/D20192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi,
I hereby attach a patch to fix bug no. 27731:
https://llvm.org/bugs/show_bug.cgi?id=27731
Best regards,
Mads Ravn
Index: clang-tidy/modernize/PassByValueCheck.cpp
===
--- clang-tidy/modernize/PassByValueCheck.cpp (revision 269603
thakis closed this revision.
thakis added a comment.
r269675, thanks!
http://reviews.llvm.org/D20291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Mon May 16 13:14:07 2016
New Revision: 269675
URL: http://llvm.org/viewvc/llvm-project?rev=269675&view=rev
Log:
[ms] Reintroduce feature guards in intrinsic headers in Microsoft mode
Visual Studio's C++ standard library headers include intrin.h, so the intrinsic
headers get inc
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D20291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
> On May 16, 2016, at 6:52 AM, Rafael Espíndola
> wrote:
>
> + auto Used = collectUsedGlobalVariables(*M, UsedGlobals, true);
>
> Please use an explicit type instead of auto.
Sure.
>
> You deleted the assert
Are you referring to the assertion that llvm.embedded.module has no uses. I
adde
cameron314 updated the summary for this revision.
cameron314 updated this revision to Diff 57367.
cameron314 added a comment.
This version of the patch takes into account potential changes between
filenames and their unique IDs between parses.
http://reviews.llvm.org/D20137
Files:
lib/Fronte
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
Visual Studio's C++ standard library headers include intrin.h, so the intrinsic
headers get included a lot more often in Microsoft mode then elsewhere. The
AVX512 intrinsics are a lot of code (0.
On Mon, May 16, 2016 at 10:03 AM, Nick Lewycky wrote:
> Hans Wennborg wrote:
>>
>> On Sat, May 14, 2016 at 10:44 AM, Nick Lewycky via cfe-commits
>> wrote:
>>>
>>>
>>> Author: nicholas
>>> Date: Sat May 14 12:44:14 2016
>>> New Revision: 269572
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?re
erik.pilkington added a comment.
Very weird, the test suite runs fine on my machine. Looks like the expected
line for the diagnostics on your run is always one more than the line of the
actual diagnostic. Could you please update your build to top-of-trunk, reapply
the patch, and run the suite a
Author: probinson
Date: Mon May 16 12:22:25 2016
New Revision: 269671
URL: http://llvm.org/viewvc/llvm-project?rev=269671&view=rev
Log:
[PS4] Change the names of some "environmental" things to what our
licensees actually see in the toolchain we deliver to them. This will
reduce the set of local p
davidxl added a comment.
Strictly speaking, this patch requires a version bump of the indexed format.
The profile reader also needs to adjust the FunctionHash computation (either
using 0 or simple function hash) based on the version of the profile data.
Check with Justin/vsk to see if it is imp
danalbert accepted this revision.
danalbert added a comment.
This revision is now accepted and ready to land.
LGTM. Sorry for the delay in response.
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
yaxunl added inline comments.
Comment at: lib/Headers/opencl-c.h:17051
@@ +17050,3 @@
+#define CLK_SUCCESS 0
+#define CLK_ENQUEUE_FAILURE -101
+#define CLK_INVALID_QUEUE -102
jprice
Author: yaxunl
Date: Mon May 16 12:06:34 2016
New Revision: 269670
URL: http://llvm.org/viewvc/llvm-project?rev=269670&view=rev
Log:
[OpenCL] Add supported OpenCL extensions to target info.
Add supported OpenCL extensions to target info. It serves as default values to
save the users of the burde
Author: ericwf
Date: Mon May 16 12:05:14 2016
New Revision: 269669
URL: http://llvm.org/viewvc/llvm-project?rev=269669&view=rev
Log:
Remove C++11 feature macros in tests. Use TEST_STD_VER instead.
Modified:
libcxx/trunk/test/libcxx/utilities/meta/is_referenceable.pass.cpp
libcxx/trunk/tes
Hans Wennborg wrote:
On Sat, May 14, 2016 at 10:44 AM, Nick Lewycky via cfe-commits
wrote:
Author: nicholas
Date: Sat May 14 12:44:14 2016
New Revision: 269572
URL: http://llvm.org/viewvc/llvm-project?rev=269572&view=rev
Log:
Warn when a reference is bound to an empty l-value (dereferenced n
Author: marshall
Date: Mon May 16 11:57:15 2016
New Revision: 269665
URL: http://llvm.org/viewvc/llvm-project?rev=269665&view=rev
Log:
Add a test for uniqueptr having either NULL and nullptr
Modified:
libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.cto
cameron314 added inline comments.
Comment at: lib/Frontend/ASTUnit.cpp:1402-1406
@@ +1401,7 @@
+
+vfs::Status Status;
+if (FileMgr->getNoncachedStatValue(RB.first, Status)) {
+ AnyFileChanged = true;
+ break;
+}
+
rsmith w
Author: marshall
Date: Mon May 16 11:55:32 2016
New Revision: 269663
URL: http://llvm.org/viewvc/llvm-project?rev=269663&view=rev
Log:
Add a couple of _LIBCPP_ASSERT calls. No functional change.
Modified:
libcxx/trunk/include/future
Modified: libcxx/trunk/include/future
URL:
http://llvm.org
rmaprath added a comment.
Ping.
http://reviews.llvm.org/D20119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thank you for the work on this! I've commit in r269662
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: aaronballman
Date: Mon May 16 11:49:01 2016
New Revision: 269662
URL: http://llvm.org/viewvc/llvm-project?rev=269662&view=rev
Log:
Add the hasDynamicExceptionSpec() AST matcher to match function declarations
that have a dynamic exception specification.
Patch by Don Hinton.
Modified:
On Sat, May 14, 2016 at 10:44 AM, Nick Lewycky via cfe-commits
wrote:
>
> Author: nicholas
> Date: Sat May 14 12:44:14 2016
> New Revision: 269572
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269572&view=rev
> Log:
> Warn when a reference is bound to an empty l-value (dereferenced null
> poin
Author: bruno
Date: Mon May 16 11:46:01 2016
New Revision: 269661
URL: http://llvm.org/viewvc/llvm-project?rev=269661&view=rev
Log:
[Modules] Use vfs for (recursive) directory iteration
Clang performs directory walk while searching headers inside modules by
using the ::sys::fs instead of ::vfs. T
jprice added inline comments.
Comment at: lib/Headers/opencl-c.h:17051
@@ +17050,3 @@
+#define CLK_SUCCESS 0
+#define CLK_ENQUEUE_FAILURE -101
+#define CLK_INVALID_QUEUE -102
yaxunl
mclow.lists added a comment.
A couple of packaging comments. In general, this looks fine to me - still
waiting on someone from Android to chime in. -- I'll ping Dan.
Comment at: include/support/xlocale/__posix_l_fallback.h:13
@@ +12,3 @@
+// extended locale support for libc's
hintonda added a comment.
Great, thanks again. This has been a great learning experience.
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Okay, back to looking good. :-) I will commit on your behalf, since I'm back to
somewhere with source access again.
http://reviews.llvm.org/D20052
___
yaxunl added inline comments.
Comment at: lib/Headers/opencl-c.h:17051
@@ +17050,3 @@
+#define CLK_SUCCESS 0
+#define CLK_ENQUEUE_FAILURE -101
+#define CLK_INVALID_QUEUE -102
Anastas
ikudrin added a comment.
Does anyone known, why we need dummy coverage mapping records for unused
functions? How are they used? Isn't it better to remove these dummy records to
prevent confusion with the real ones?
http://reviews.llvm.org/D20287
_
meadori added a subscriber: meadori.
meadori added a comment.
I see failure when running the Clang test suite with this patch:
Command Output (stderr):
--
error: 'error' diagnostics expected but not seen:
File
/Users/meadori/Code/src/llvm/llvm-mainline/tools/clang/test/SemaTemplate/fr
ikudrin added a comment.
The motivation sample (using llvm-cov with http://reviews.llvm.org/D20286
applied):
$ cat > sample.h << EOF
inline int sample_func(int A) {
return A;
}
EOF
$ cat > dummy.cpp << EOF
#include "sample.h"
EOF
$ cat > sample.cpp << EOF
#include "sample.h
ikudrin created this revision.
ikudrin added reviewers: bogner, davidxl, vsk.
ikudrin added a subscriber: cfe-commits.
A valid function might not have any statement which affects the hash value, so
the hash for that function was zero. The hash value for an unused function is
also zero, so the lo
hintonda updated this revision to Diff 57357.
hintonda added a comment.
- Revert back to previous version of the matcher and use Aaron's syntax with
allOf and unless to achieve the same results -- much simpler.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang
hintonda updated this revision to Diff 57356.
hintonda added a comment.
Revert back to previous version.
http://reviews.llvm.org/D20052
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchers
hans added a comment.
I'd leave out the blank lines between DEF_TRAVERSE_STMTs, but the rest looks
good.
Comment at: include/clang/AST/RecursiveASTVisitor.h:2014
@@ -2002,2 +2013,3 @@
DEF_TRAVERSE_STMT(ObjCAutoreleasePoolStmt, {})
+
DEF_TRAVERSE_STMT(CXXForRangeStmt, {
--
hintonda added a comment.
Great, that's exactly what I needed. I'll revert back to the previous version.
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
aaron.ballman added a comment.
In http://reviews.llvm.org/D20052#430903, @hintonda wrote:
> Great, unless() was what I was missing. I'll refactor along those lines.
>
> As for what I'm trying to achieve, I want a set containing "throw()" and
> another set containing "throw(something)". If ther
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
hintonda added a comment.
Great, unless() was what I was missing. I'll refactor along those lines.
As for what I'm trying to achieve, I want a set containing "throw()" and
another set containing "throw(something)". If there's a cleaner way to achieve
that with an existing matcher, please let
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
LGTM!
http://reviews.llvm.org/D19841
___
cfe-commits mailing list
cfe-commits@lists.
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
I'm not keen on the new direction this patch has taken.
`hasDynamicExceptionSpec(isThrow())` is quite novel. What is the problem you
are trying to solve with this?
==
1 - 100 of 120 matches
Mail list logo
