Re: [PATCH] D19534: [clang-tidy] new google-default-arguments check

courbet added a comment. Thanks. I don't have write access, could you please submit this for me ? http://reviews.llvm.org/D19534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19534: [clang-tidy] new google-default-arguments check

courbet updated this revision to Diff 56529. courbet marked an inline comment as done. http://reviews.llvm.org/D19534 Files: clang-tidy/google/CMakeLists.txt clang-tidy/google/DefaultArgumentsCheck.cpp clang-tidy/google/DefaultArgumentsCheck.h clang-tidy/google/GoogleTidyModule.cpp docs

Re: [PATCH] D19851: Warn on binding reference to null in copy initialization

nicholas updated this revision to Diff 56526. nicholas added a comment. Unsure why, but the previous diff didn't have the 'volatile' check removed. http://reviews.llvm.org/D19851 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaInit.cpp test/CXX/expr/expr.prim/expr.prim.lamb

r268893 - [X86] Fix up type arguments of __builtin_ia32_cvtss2sd_round_mask and __builtin_ia32_cvtsd2ss_round_mask to match the backend.

Author: ctopper Date: Mon May 9 00:34:22 2016 New Revision: 268893 URL: http://llvm.org/viewvc/llvm-project?rev=268893&view=rev Log: [X86] Fix up type arguments of __builtin_ia32_cvtss2sd_round_mask and __builtin_ia32_cvtsd2ss_round_mask to match the backend. Modified: cfe/trunk/include/cla

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

pxli168 added a comment. The pointer type seems to be not that important, we can just cast it to any type we want. Comment at: test/SemaOpenCL/to_addr_builtin.cl:24 @@ +23,3 @@ + + glob = to_global(con); +#if __OPENCL_C_VERSION__ < CL_VERSION_2_0 should this r

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

pxli168 accepted this revision. pxli168 added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D19780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

pxli168 added a comment. In http://reviews.llvm.org/D18369#422367, @yaxunl wrote: > In http://reviews.llvm.org/D18369#421963, @pxli168 wrote: > > > If we want to save some space, could we use some macro to expand the > > gentype or some script to expand the gentype into each types when the clang

[libcxx] r268887 - Generate code coverage for experimental libraries

Author: ericwf Date: Sun May 8 18:08:50 2016 New Revision: 268887 URL: http://llvm.org/viewvc/llvm-project?rev=268887&view=rev Log: Generate code coverage for experimental libraries Modified: libcxx/trunk/test/CMakeLists.txt Modified: libcxx/trunk/test/CMakeLists.txt URL: http://llvm.org/v

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

kerberizer added a comment. Just to confirm seeing exactly the same error as @foutrelis on Arch i686 (and everything else pass too), but when building the current 3.9.0svn trunk with only this patch applied unmodified on it. Thus, it's probably not likely to be something connected to Evangelos'

[PATCH] D20053: [clang-tidy] Add misc-unnecessary-mutable check.

mnbvmar created this revision. mnbvmar added a reviewer: alexfh. mnbvmar added subscribers: krystyna, sbarzowski, Prazek, staronj, cfe-commits. This implements unnecessary-mutable check. It's still bug-prone and might produce false positives, so all suggestions are welcome. http://reviews.llvm.o

Re: [PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

hintonda updated this revision to Diff 56522. hintonda added a comment. - Added test, re-generated documentation, and add new matcher to the dynamic matchers registry. http://reviews.llvm.org/D20052 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTM

Re: [Clang] Convergent Attribute

> On May 6, 2016, at 18:12, Richard Smith via cfe-commits > wrote: > > On Fri, May 6, 2016 at 4:20 PM, Matt Arsenault via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > On 05/06/2016 02:42 PM, David Majnemer via cfe-commits wrote: > This example looks wrong to me. It doesn't seem m

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda updated this revision to Diff 56521. hintonda added a comment. - Fix typo in docs. http://reviews.llvm.org/D18575 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp clang-tidy/modernize/UseNoexceptCh

Re: [PATCH] D19804: Make clang-format cleaner remove redundant commas/colons in constructor initializer list.

djasper added inline comments. Comment at: lib/Format/Format.cpp:1821 @@ +1820,3 @@ + if (Line->Affected) +checkConstructorInitList(*Line); +} Why are we restricting this to constructor initializers? I think we should directly be more generic and

Re: [PATCH] D20018: Support variables and functions types in misc-unused-using-decls.

djasper added inline comments. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:63 @@ +62,3 @@ +removeFromFoundDecls(Used->getCanonicalDecl()); + } else if (const auto *DRE = Result.Nodes.getNodeAs("used")) { +if (const auto *FD = dyn_cast(DRE->getDecl())) {

r268879 - clang-format: Fix space after argument comments.

Author: djasper Date: Sun May 8 13:14:01 2016 New Revision: 268879 URL: http://llvm.org/viewvc/llvm-project?rev=268879&view=rev Log: clang-format: Fix space after argument comments. Before: f(/*a=*/a, /*b=*/ ::b); After: f(/*a=*/a, /*b=*/::b); Modified: cfe/trunk/lib/Format/TokenAnnota

r268878 - clang-format: Support enum type template arguments.

Author: djasper Date: Sun May 8 13:12:22 2016 New Revision: 268878 URL: http://llvm.org/viewvc/llvm-project?rev=268878&view=rev Log: clang-format: Support enum type template arguments. Before: template class A { public : E *f(); }; After: template class A { public: E *f(); }; Mod

Re: [PATCH] D20054: Fix spurious warnings about unused private field

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D20054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D20053: [clang-tidy] Add misc-unnecessary-mutable check.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). http://reviews.llvm.org/D20053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D20054: Fix spurious warnings about unused private field

ogoffart created this revision. ogoffart added reviewers: cfe-commits, djasper. If the address of a field is taken as a pointer to member, we should not warn that the field is not used. Normaly, yse of fields are done from MemberExpr, but in case of pointer to member, it is in a DeclRefExpr

Re: [PATCH] D19764: Keep invalid functions as part of the AST

ogoffart added a comment. Ping? http://reviews.llvm.org/D19764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r268874 - Teach header search about GCC 4.9 header search paths in Gentoo, they

Author: chandlerc Date: Sun May 8 02:59:56 2016 New Revision: 268874 URL: http://llvm.org/viewvc/llvm-project?rev=268874&view=rev Log: Teach header search about GCC 4.9 header search paths in Gentoo, they now use the full GCC version in their weird suffix. Added: cfe/trunk/test/Driver/Inputs

Re: [PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

alexfh added a comment. Please add tests, re-generate documentation and add the matcher to the dynamic matchers registry. See http://reviews.llvm.org/D19871 for an example. http://reviews.llvm.org/D20052 ___ cfe-commits mailing list cfe-commits@lis