pxli168 added a comment.
LGTM!
Thanks!
http://reviews.llvm.org/D17412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D18286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Tom, may I commit it into release_38?
It has been preventing "lit --use-processes" on windows.
2016-02-16 17:13 GMT+09:00 NAKAMURA Takumi via cfe-commits
:
> Author: chapuni
> Date: Tue Feb 16 02:13:36 2016
> New Revision: 260944
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260944&view=rev
> L
Author: etienneb
Date: Mon Apr 4 20:41:02 2016
New Revision: 265375
URL: http://llvm.org/viewvc/llvm-project?rev=265375&view=rev
Log:
[clang-tidy] Fix documentation of misc-suspicious-missing-comma
Summary:
The clang-tidy documentation generation was broken since commit :
http://reviews.llvm.or
etienneb updated this revision to Diff 52653.
etienneb added a comment.
Fix list.rst (bad merge)
http://reviews.llvm.org/D18783
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp
clang-tidy/misc/StringLiteralWit
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
This patch add the support for detecting suspicious string
literals and their usage.
The following example shows a incorrect character escaping leading
to an embedded NUL character.
```
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
erik.pilkington updated this revision to Diff 52641.
erik.pilkington added a comment.
Include local static data member template in test. Thanks for taking a look
Richard, would you mind committing this for me?
http://reviews.llvm.org/D18653
Files:
lib/Sema/SemaDeclCXX.cpp
test/CXX/temp/tem
rsmith added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:5218-5221
@@ -5209,1 +5217,6 @@
+ Fn, NDecl, LParenLoc, ArgExprs, RParenLoc, ExecConfig, IsExecConfig);
+
+ if (MakeCallInstantiationDependent)
+BuiltCall.get()->setInstantiationDependent(true);
+ return Bu
carlo.bertolli updated this revision to Diff 52640.
carlo.bertolli added a comment.
[OPENMP] Rebase patch on new support for codegen for teams in nvptx target.
private and firstprivate clauses are now dealt with in the teams patch and this
one only becomes regression tests.
Repository:
rL LL
Author: rsmith
Date: Mon Apr 4 18:29:43 2016
New Revision: 265364
URL: http://llvm.org/viewvc/llvm-project?rev=265364&view=rev
Log:
Move local helper class into anonymous namespace.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
Modified: cfe/trunk/lib/AST/ExprConstant.cpp
URL:
http://llvm.o
Author: marshall
Date: Mon Apr 4 18:23:35 2016
New Revision: 265363
URL: http://llvm.org/viewvc/llvm-project?rev=265363&view=rev
Log:
Remove unused internal routines. No functional change
Modified:
libcxx/trunk/include/algorithm
Modified: libcxx/trunk/include/algorithm
URL:
http://llvm.org
rsmith added a subscriber: rsmith.
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM. Post-commit review is fine for changes like this that mechanically update
Clang to match LLVM API changes.
http://rev
On Fri, Apr 1, 2016 at 6:43 PM, Douglas Yung <
douglas_y...@playstation.sony.com> wrote:
> dyung added a comment.
>
> In http://reviews.llvm.org/D18708#390166, @rsmith wrote:
>
> > In http://reviews.llvm.org/D18708#390150, @dyung wrote:
> >
> > > From my understanding, there are 2 issues that bloc
On Mon, Apr 4, 2016 at 3:49 PM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Mon Apr 4 17:49:20 2016
> New Revision: 265358
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265358&view=rev
> Log:
> Put back the undefs that Richard removed. Boost wo
Author: rnk
Date: Mon Apr 4 18:14:14 2016
New Revision: 265362
URL: http://llvm.org/viewvc/llvm-project?rev=265362&view=rev
Log:
Fix test failure from r265361
Modified:
cfe/trunk/test/CodeGen/align_value.cpp
Modified: cfe/trunk/test/CodeGen/align_value.cpp
URL:
http://llvm.org/viewvc/llvm-
jfb created this revision.
jfb added reviewers: jyknight, reames.
jfb added a subscriber: cfe-commits.
See LLVM change D18775 for details, this change depends on it.
http://reviews.llvm.org/D18776
Files:
lib/CodeGen/CGAtomic.cpp
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGExprScalar.cpp
lib/
Author: ssrivastava
Date: Mon Apr 4 17:56:05 2016
New Revision: 265359
URL: http://llvm.org/viewvc/llvm-project?rev=265359&view=rev
Log:
Set the default C standard to C99 when targeting the PS4.
Patch by Douglas Yung!
Differential Revision: http://reviews.llvm.org/D18708
Modified:
cfe/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265359: Set the default C standard to C99 when targeting the
PS4. (authored by ssrivastava).
Changed prior to commit:
http://reviews.llvm.org/D18708?vs=52622&id=52633#toc
Repository:
rL LLVM
http://
Author: marshall
Date: Mon Apr 4 17:49:20 2016
New Revision: 265358
URL: http://llvm.org/viewvc/llvm-project?rev=265358&view=rev
Log:
Put back the undefs that Richard removed. Boost won't build w/o these;
specifically the file 'bytes_methods.h' in Apple's python framework defines
these.
Modifi
Author: jyknight
Date: Mon Apr 4 17:35:56 2016
New Revision: 265355
URL: http://llvm.org/viewvc/llvm-project?rev=265355&view=rev
Log:
Fix "suggest parentheses" warning.
Modified:
cfe/trunk/lib/CodeGen/SwiftCallingConv.cpp
Modified: cfe/trunk/lib/CodeGen/SwiftCallingConv.cpp
URL:
http://llv
ariccio added a comment.
So for `_wcsdup_dbg`, I should leave only `testWinWcsdupDbg`?
http://reviews.llvm.org/D18073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
I'm not real fond of the testcase being in attr-target-x86, but there's not a
better place at the moment either.
-eric
http://reviews.llvm.org/D18651
_
echristo added a comment.
That's fascinating and terrifying all at once.
Can you rename the test to avx-v-modifier-inline-asm.c please?
One inline comment as well.
Thanks!
-eric
Comment at: lib/AST/Stmt.cpp:639
@@ +638,3 @@
+ // into "pcmpestri" otherwise.
+ if (C.
ygao accepted this revision.
ygao added a reviewer: ygao.
ygao added a comment.
The test LGTM. Thanks!
http://reviews.llvm.org/D18708
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
Can you add one test per new function, which tests that the function if modeled
correctly. Please, do not duplicate all tests that contain a function with it's
windows variants.
Hope this is more clear.
http://reviews.llvm.org/D18073
_
sfantao added a comment.
I just wanted to add to what Carlo just said, that the feature to capture by
value is already used in the offloading upstreamed code. This is not a new
feature we are proposing , it is already there used in the code and tested in
relevant regression tests. This patch is
ariccio added a comment.
Here's my confusion: don't we //kinda// have to duplicate tests? After all
these functions are //essentially// duplicate functions.
http://reviews.llvm.org/D18073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
etienneb added a comment.
thanks, lgtm.
http://reviews.llvm.org/D18766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbenza marked an inline comment as done and an inline comment as not done.
Comment at: clang-tidy/misc/MultipleStatementMacroCheck.cpp:33
@@ +32,3 @@
+
+namespace {
+
etienneb wrote:
> I feel it nicer if you merge this namespace with the one at line 20.
I like to
sbenza updated this revision to Diff 52625.
sbenza marked an inline comment as done.
sbenza added a comment.
Minor fixes
http://reviews.llvm.org/D18766
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MultipleStatementMacroCheck.cpp
clang-tidy/mis
Yeah, fair enough.
That's the downside of committing on behalf of others and focusing on throughput :(
Kit Barton, Ph.D.LLVM Development on POWERIBM Toronto Lab, D2/929/8200/MKM8200 Warden Ave, Markham, L6G 1C7(905) 413-3452kbar...@ca.ibm.com
- Original message -From: Eric Christophe
dyung updated this revision to Diff 52622.
dyung added a comment.
Moved the test to test/Preprocessor as suggested by Gao and found a nice place
to add it.
http://reviews.llvm.org/D18708
Files:
include/clang/Frontend/CompilerInvocation.h
lib/Frontend/CompilerInvocation.cpp
test/Preproces
Nah, just worth knowing. It was probably more useful to know last month.
-eric
On Mon, Apr 4, 2016 at 11:56 AM Kit Barton wrote:
> I forgot to edit the message.
> Do you think it's worth going back and fixing the log message at this
> point?
>
> Kit Barton, Ph.D.
> LLVM Development on POWER
> I
Author: rjmccall
Date: Mon Apr 4 15:39:50 2016
New Revision: 265344
URL: http://llvm.org/viewvc/llvm-project?rev=265344&view=rev
Log:
Fix an unused-variable warning by using the variable in the place
it was supposed to have been used.
Modified:
cfe/trunk/lib/CodeGen/SwiftCallingConv.cpp
In addition to the Sema tests, this change needs tests in CodeGenObjC to
show where the attribute is applied in the IR.
--- a/lib/CodeGen/CGBlocks.cpp
+++ b/lib/CodeGen/CGBlocks.cpp
@@ -2334,5 +2334,9 @@ llvm::Constant
*CodeGenModule::getNSConcreteStackBlock() {
george.burgess.iv added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:5047-5098
@@ -5046,57 +5046,54 @@
+CallExpr *Sema::buildDependentCallExpr(Expr *ExecConfig, Expr *Fn,
+ MultiExprArg ArgExprs,
+
george.burgess.iv updated this revision to Diff 52619.
george.burgess.iv marked 4 inline comments as done.
george.burgess.iv added a comment.
Addressed most feedback; see comments. :)
http://reviews.llvm.org/D18425
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExpr.cpp
lib/Sema/SemaOverlo
Author: bruno
Date: Mon Apr 4 15:26:57 2016
New Revision: 265343
URL: http://llvm.org/viewvc/llvm-project?rev=265343&view=rev
Log:
[CrashReproducer] Pass -I, -F and -resource-dir to the reproducer script when
using modules/vfs
The reproducer should use -I/-F/-resource-dir in the same way as the
ahatanak added a comment.
Also, fixed the regex in test case so that the test passes on release builds
too.
http://reviews.llvm.org/D18618
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ahatanak updated this revision to Diff 52609.
ahatanak added a comment.
Changed the patch based on review comments.
Added code to enter RunCleanupsScope before the condition is evaluated and
force its cleanup before emitting LoopEnd.
http://reviews.llvm.org/D18618
Files:
lib/CodeGen/CGObjC.
etienneb added a subscriber: etienneb.
etienneb added a comment.
this is cool.
Comment at: clang-tidy/misc/MultipleStatementMacroCheck.cpp:33
@@ +32,3 @@
+
+namespace {
+
I feel it nicer if you merge this namespace with the one at line 20.
Comm
yaxunl updated this revision to Diff 52607.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Removed 2016-04-01-addrcast.cl and it to address-spaces-conversions.cl.
http://reviews.llvm.org/D18713
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGenOpenCL/address-spaces-conversio
yaxunl marked an inline comment as done.
Comment at: test/CodeGenOpenCL/2016-04-01-addrcast.cl:1
@@ +1,2 @@
+// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -O0 -cl-std=CL2.0
-emit-llvm -o - | FileCheck %s
+
Anastasia wrote:
> Can we rename the file to jus
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
This revision is now accepted and ready to land.
Comment at: lib/Lex/PPMacroExpansion.cpp:1489-1492
@@ +1488,6 @@
+// a diagnostic and a dummy value.
+if (Result.hasValue())
+ OS << Result.get
Author: gbiv
Date: Mon Apr 4 14:44:16 2016
New Revision: 265341
URL: http://llvm.org/viewvc/llvm-project?rev=265341&view=rev
Log:
[Sema] Delete FIXME that has been fixed. NFC.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/ll
Author: mps
Date: Mon Apr 4 14:36:48 2016
New Revision: 265338
URL: http://llvm.org/viewvc/llvm-project?rev=265338&view=rev
Log:
Fix redundant "typename typename T" in Visual Studio Native Visualizer
Also, a little minor cleanup
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modif
etienneb updated this revision to Diff 52602.
etienneb added a comment.
nits
http://reviews.llvm.org/D18703
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.h
docs/cla
etienneb updated this revision to Diff 52601.
etienneb marked 3 inline comments as done.
etienneb added a comment.
add options, configurable list of function names, support for ! pattern.
http://reviews.llvm.org/D18703
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
djasper added inline comments.
Comment at: include/clang/Format/Format.h:770
@@ +769,3 @@
+/// \brief Returns the replacements corresponding to applying, fixing, and
+/// reformatting \p Replaces.
+tooling::Replacements fixReplacements(StringRef Code,
I think we s
Please accept this diff as a change to support dllimport of objective c
interfaces on windows. I've included a new test and changes to an existing test
as well. All clang tests pass on Linux & Windows. This change is required for
Microsoft's use of the clang compiler in support of objective c on
Thanks, r265324 fixed the assert.
On Fri, Apr 1, 2016 at 8:25 PM, John McCall wrote:
> On Apr 1, 2016, at 3:50 PM, Nico Weber wrote:
> On Thu, Mar 10, 2016 at 8:30 PM, John McCall via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rjmccall
>> Date: Thu Mar 10 22:30:31 2016
>> N
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:2489
@@ -2485,1 +2488,3 @@
+ bool MissingImplicitThis = false,
+ bool *FailedDueToValueDependentExpr = nullptr);
I'd just call this `Dep
> On Apr 4, 2016, at 11:49 AM, Sean Silva wrote:
> On Mon, Apr 4, 2016 at 11:33 AM, John McCall via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: rjmccall
> Date: Mon Apr 4 13:33:00 2016
> New Revision: 265323
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265323&view=rev
Author: rjmccall
Date: Mon Apr 4 13:53:01 2016
New Revision: 265328
URL: http://llvm.org/viewvc/llvm-project?rev=265328&view=rev
Log:
Assignment operators should return by reference.
Thanks to Sean Silva for pointing this out.
Modified:
cfe/trunk/include/clang/AST/CharUnits.h
Modified: cfe
I forgot to edit the message.
Do you think it's worth going back and fixing the log message at this point?
Kit Barton, Ph.D.LLVM Development on POWERIBM Toronto Lab, D2/929/8200/MKM8200 Warden Ave, Markham, L6G 1C7(905) 413-3452kbar...@ca.ibm.com
- Original message -From: Eric Christo
Author: ygao
Date: Mon Apr 4 13:46:09 2016
New Revision: 265325
URL: http://llvm.org/viewvc/llvm-project?rev=265325&view=rev
Log:
Add copyright notice to the modulemap file.
The module.modulemap file in the lib/Headers directory was missing the LLVM
copyright notice. This patch adds the copyrigh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265325: Add copyright notice to the modulemap file.
(authored by ygao).
Changed prior to commit:
http://reviews.llvm.org/D18709?vs=52414&id=52590#toc
Repository:
rL LLVM
http://reviews.llvm.org/D187
On Mon, Apr 4, 2016 at 11:33 AM, John McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rjmccall
> Date: Mon Apr 4 13:33:00 2016
> New Revision: 265323
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265323&view=rev
> Log:
> Add a couple of convenience operations to CharUnits
dblaikie abandoned this revision.
dblaikie added a subscriber: rsmith.
dblaikie added a comment.
In http://reviews.llvm.org/D3635#44720, @rsmith wrote:
> Implementation LGTM, if you decide that you want to go in this direction.
Just looking over some old patches/git branches I had lying around.
yaxunl added a comment.
> Btw, there is another place in lib/CodeGen/CGExprScalar.cpp with
> CreateAddrSpaceCast call too. I am wondering if that could have the same
> issue... if yes, may be we should fix it already now.
I cannot find another CreateAddrSpaceCast in lib/CodeGen/CGExprScalar.cp
Author: rjmccall
Date: Mon Apr 4 13:33:00 2016
New Revision: 265323
URL: http://llvm.org/viewvc/llvm-project?rev=265323&view=rev
Log:
Add a couple of convenience operations to CharUnits.
Modified:
cfe/trunk/include/clang/AST/CharUnits.h
Modified: cfe/trunk/include/clang/AST/CharUnits.h
URL:
Author: rjmccall
Date: Mon Apr 4 13:33:08 2016
New Revision: 265324
URL: http://llvm.org/viewvc/llvm-project?rev=265324&view=rev
Log:
IRGen-level lowering for the Swift calling convention.
Added:
cfe/trunk/include/clang/CodeGen/SwiftCallingConv.h
cfe/trunk/lib/CodeGen/SwiftCallingConv.cp
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, doug.gregor.
aaron.ballman added a subscriber: cfe-commits.
Currently, attribute subject lists attempt to automatically determine what
diagnostic to emit when the attribute does not appertain to a given
declaration. It d
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:782
@@ +781,3 @@
+LLVM_ATTRIBUTE_UNUSED_RESULT bool noteUnrecoverableFailure() {
+ // This is a little bit icky. We leave HasSideEffects unchange if we
+ // aren't going to keep running, because eval
jyknight updated this revision to Diff 52587.
jyknight marked 2 inline comments as done.
jyknight added a comment.
review fixes
http://reviews.llvm.org/D17933
Files:
lib/Basic/Targets.cpp
lib/Frontend/InitPreprocessor.cpp
test/CodeGen/atomic-ops.c
test/CodeGen/ms-volatile.c
test/CodeG
jyknight added a comment.
Done and done.
http://reviews.llvm.org/D17933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbenza created this revision.
sbenza added a reviewer: alexfh.
sbenza added a subscriber: cfe-commits.
The check detects multi-statement macros that are used in unbraced conditionals.
Only the first statement will be part of the conditionals and the rest will fall
outside of it and executed uncond
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: alexfh.
george.burgess.iv added a subscriber: cfe-commits.
This patch seems trivial, but I've never touched clang-tidy before, so I'm just
making sure I didn't miss something obvious. :)
--
Clang has a parameter attrib
Matt added a comment.
In http://reviews.llvm.org/D17412#391322, @Anastasia wrote:
> Cool, thanks! I think we should commit this ASAP.
>
> @Xiuli/@Matt, do you have any more comments here?
Hi! I think that "Matt" for this one would be @arsenm :-)
http://reviews.llvm.org/D17412
_
Anastasia added a subscriber: Matt.
Anastasia added a comment.
Cool, thanks! I think we should commit this ASAP.
@Xiuli/@Matt, do you have any more comments here?
http://reviews.llvm.org/D17412
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Hello,
Here's a little one-off patch that fixes
https://llvm.org/bugs/show_bug.cgi?id=19986 for me, by allowing a few
more things inside [] when trying to match a lambda capture section.
I hope someone can help it find its way into the main repo.
Cheers,
Jacek
Index: lib/Format/UnwrappedLinePars
Anastasia added a comment.
LG, apart from renaming the test file.
Btw, there is another place in lib/CodeGen/CGExprScalar.cpp with
CreateAddrSpaceCast call too. I am wondering if that could have the same
issue... if yes, may be we should fix it already now.
Comment at: test/C
bruno added a subscriber: bruno.
bruno added a comment.
Hi Andrey,
Comment at: include/clang/Driver/Options.td:1281
@@ -1280,1 +1280,3 @@
+def miamcu : Flag<["-"], "miamcu">, Group, Flags<[DriverOption,
CoreOption]>,
+ HelpText<"Use Intel MCU ABI.">;
def malign_functions_EQ :
george.burgess.iv added a comment.
Ping ;)
http://reviews.llvm.org/D18425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D18540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265314: Document standard substitutions defined by lit.
(authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D18752?vs=52531&id=52578#toc
Repository:
rL LLVM
http://reviews.llvm
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Lgtm I suppose the test worked fine because it still found the right magic
bytes.
http://reviews.llvm.org/D18747
___
cfe-commits mailing list
cfe-comm
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
The clang-tidy documentation generation was broken since commit :
http://reviews.llvm.org/D18457
I ran locally the documentation generation and I fixed errors related to that
specific ch
dsanders created this revision.
dsanders added a reviewer: vkalintiris.
dsanders added a subscriber: cfe-commits.
dsanders added a dependency: D18753: [mips][sanitizer_common] Don't use `ld` in
internal_clone() on 32-bit MIPS..
The MIPS IAS can now pass 'ninja check-all' and recurse now that the
d.zobnin.bugzilla added a comment.
Richard, thank you for the review and explanation!
I don't have any examples of useful code using this extension, I was trying to
fix the PR... So, do you think we should add this GCC extension to Clang (with
a proper warning, of course) for compatibility reaso
Prazek added a comment.
In http://reviews.llvm.org/D18745#390739, @Eugene.Zelenko wrote:
> Isn't readability-implicit-bool-cast¶ should catch such issues? If not, I
> think will be good idea to improve that check instead of introducing new one.
I wouldn't add this functionality there. I see th
Author: marshall
Date: Mon Apr 4 11:08:54 2016
New Revision: 265306
URL: http://llvm.org/viewvc/llvm-project?rev=265306&view=rev
Log:
Fix for Bug #27193; 'std::acos on complex does not agree with C'. Tests need
work; so the bug will stay open.
Modified:
libcxx/trunk/include/complex
Modifi
RedX2501 added a comment.
Thanks for the advice.
Please use Guilherme Bufolo as the name for the commit.
Am 04.04.2016 21:33 schrieb "Paul Robinson" <
paul_robin...@playstation.sony.com>:
> probinson added a subscriber: probinson.
> probinson added a comment.
>
> In http://reviews.llvm.org/
Rob added a comment.
Thanks :)
Repository:
rL LLVM
http://reviews.llvm.org/D18396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a subscriber: probinson.
probinson added a comment.
In http://reviews.llvm.org/D18752#390906, @RedX2501 wrote:
> Somebody else needs to commit this as I don't have any rights for it.
When someone else commits for you, our practice is to attribute the correct
author in the commi
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 265304.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: cbertol
Date: Mon Apr 4 10:55:02 2016
New Revision: 265304
URL: http://llvm.org/viewvc/llvm-project?rev=265304&view=rev
Log:
[OPENMP] Codegen for teams directive for NVPTX
This patch implements the teams directive for the NVPTX backend. It is
different from the host code generation path
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265303: [clang-tidy] Reduce false-positive ratio in
misc-suspicious-missing-comma check. (authored by etienneb).
Changed prior to commit:
http://reviews.llvm.org/D18695?vs=52365&id=52563#toc
Repository
Author: etienneb
Date: Mon Apr 4 10:46:38 2016
New Revision: 265303
URL: http://llvm.org/viewvc/llvm-project?rev=265303&view=rev
Log:
[clang-tidy] Reduce false-positive ratio in misc-suspicious-missing-comma check.
Summary:
This patch is adding detection of common string literal patterns
that sh
sbenza added a comment.
In http://reviews.llvm.org/D18191#391168, @sdowney wrote:
> At least in my codebase, skipping templates is too strong. I run across ones
> where the const& parameter is not one controlled by a template. It's often a
> size_t.
The only check we are doing (other than mat
Is it worth teaching FileCheck about lit-defined keywords, and
reject check-prefixes that end in one of them?
Offhand that would be UNSUPPORTED, RUN, REQUIRES, XFAIL
(I haven't actually gone to look at what lit knows).
--paulr
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-bo
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D17482#390237, @alexfh wrote:
> My main concern is that this change makes the already complicated and
> unobvious testing mechanism [...]
The complexity and obtuseness of the existing testing mechanism is unrelated to
this changese
Author: chapuni
Date: Mon Apr 4 10:30:44 2016
New Revision: 265301
URL: http://llvm.org/viewvc/llvm-project?rev=265301&view=rev
Log:
AnnotateFunctions: Tweak for mingw.
- Externalize the registry.
- Update libdeps.
Modified:
cfe/trunk/examples/AnnotateFunctions/CMakeLists.txt
cfe/tr
carlo.bertolli added a comment.
Hi Alexey
I understand your concerns and share the danger of working on optimizations
before a correct implementation is actually in place.
I do not think this is the case. My comment was very precise about the
cause-effect: the OpenMP specification was defined i
sdowney added a comment.
At least in my codebase, skipping templates is too strong. I run across ones
where the const& parameter is not one controlled by a template. It's often a
size_t.
I could easily see not fixing the typedef'd refs, also, although I think
warning on them is still useful. P
LegalizeAdulthood added a comment.
As it stands currently, you can't commit a header with `CHECK-MESSAGES` and
`CHECK-FIXES` lines and have them verified.
That's the whole point of this changeset.
Currently you have to do something very hacky in order to verify changes made
to headers.
http:
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D18509#388071, @hintonda wrote:
> With this change, won't you need to update 2 different repos: clang and
> extra? Is it possible to update both with a single Phabricator patch?
This is updating the release notes in the extra repos
alexfh added inline comments.
Comment at:
clang-tidy/readability/StaticDefinitionInAnonymousNamespaceCheck.cpp:49
@@ +48,3 @@
+
+ DiagnosticBuilder Diag =
+ diag(Def->getLocation(), "%0 is a static definition in "
nit: `auto`?
Comment at:
alexfh added inline comments.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:329
@@ +328,3 @@
+for (const std::string& Check : EnabledChecks) {
+ for (const ClangTidyOptions::StringPair &CheckSource:
+ EffectiveOptions.CheckSources) {
hokein wrot
1 - 100 of 147 matches
Mail list logo
