r265257 - Fix test case committed in r265197.

2016-04-02 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Sat Apr 2 22:36:22 2016 New Revision: 265257 URL: http://llvm.org/viewvc/llvm-project?rev=265257&view=rev Log: Fix test case committed in r265197. The test was failing on some release build because the basic block names I was expecting weren't printed. Modified: cfe/t

Re: [PATCH] D18709: Add copyright notice to modulemap files

2016-04-02 Thread Doug Gregor via cfe-commits
doug.gregor added a subscriber: doug.gregor. doug.gregor accepted this revision. doug.gregor added a reviewer: doug.gregor. doug.gregor added a comment. This revision is now accepted and ready to land. Yes, this is acceptable. Please go ahead and commit. http://reviews.llvm.org/D18709 ___

r265252 - [c-index-test] Fix leak in print_completion_result, NFC

2016-04-02 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Sat Apr 2 19:54:46 2016 New Revision: 265252 URL: http://llvm.org/viewvc/llvm-project?rev=265252&view=rev Log: [c-index-test] Fix leak in print_completion_result, NFC Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified: cfe/trunk/tools/c-index-test/c-index-t

r265238 - clang-cl: Don't skip i_group flags other than -include when building pchs.

2016-04-02 Thread Nico Weber via cfe-commits
Author: nico Date: Sat Apr 2 14:10:07 2016 New Revision: 265238 URL: http://llvm.org/viewvc/llvm-project?rev=265238&view=rev Log: clang-cl: Don't skip i_group flags other than -include when building pchs. Before this change, e.g. -isystem flags in front of the /FI corresponding to the pch file w

Re: [PATCH] D18703: [clang-tidy] Add new checker for comparison with runtime string functions.

2016-04-02 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. I think will be good idea to convert !strcmp(...) to strcmp(...) == 0. http://reviews.llvm.org/D18703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18501: Fix compilation on FreeBSD

2016-04-02 Thread Dimitry Andric via cfe-commits
dim abandoned this revision. dim added a comment. Yes, this was indeed the wrong include order. During the latter stages of FreeBSD's buildworld, the compiler is invoked with `-nostdinc++`, but `/usr/include` was put before the libc++ include directory, `/usr/include/c++/v1`. So as @rsmith re