dblaikie accepted this revision.
dblaikie added a reviewer: dblaikie.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks great - thanks!
http://reviews.llvm.org/D16949
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: majnemer
Date: Wed Mar 2 00:48:47 2016
New Revision: 262466
URL: http://llvm.org/viewvc/llvm-project?rev=262466&view=rev
Log:
[Sema] PR26444 fix crash when alignment value is >= 2**16
Sema allows max values up to 2**28, use unsigned instead of unsiged
short to hold values that large.
Di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262463: [modules] addHeaderInclude() can't fail. (authored
by davide).
Changed prior to commit:
http://reviews.llvm.org/D17794?vs=49578&id=49581#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1779
Author: davide
Date: Wed Mar 2 00:09:18 2016
New Revision: 262463
URL: http://llvm.org/viewvc/llvm-project?rev=262463&view=rev
Log:
[modules] addHeaderInclude() can't fail.
Differential Revision:http://reviews.llvm.org/D17794
Modified:
cfe/trunk/lib/Frontend/FrontendActions.cpp
Modifie
On Wed, Mar 2, 2016 at 6:42 AM Daniel Jasper wrote:
> On Tue, Mar 1, 2016 at 9:30 PM, Manuel Klimek wrote:
>
>>
>>
>> On Wed, Mar 2, 2016 at 6:20 AM Daniel Jasper wrote:
>>
>>> On Tue, Mar 1, 2016 at 9:12 PM, Daniel Jasper
>>> wrote:
>>>
On Mon, Feb 29, 2016 at 8:49 AM, Manuel K
davidxl added a comment.
I think we just need one cc1 option -fprofile-instrument-use-path=<>. An
overloaded setPGOInstrumenter method can peak at the profile header and get the
Profile flavor.
http://reviews.llvm.org/D17737
___
cfe-commits maili
djasper added a comment.
I don't think this is the right abstraction:
- Formatting so far is fundamentally per file. Grouping replacements per file
is something that can be done outside of libFormat.
- The logic to sort and deduplicate Replacements is important independent of
whether formatting
On Tue, Mar 1, 2016 at 9:30 PM, Manuel Klimek wrote:
>
>
> On Wed, Mar 2, 2016 at 6:20 AM Daniel Jasper wrote:
>
>> On Tue, Mar 1, 2016 at 9:12 PM, Daniel Jasper wrote:
>>
>>>
>>>
>>> On Mon, Feb 29, 2016 at 8:49 AM, Manuel Klimek via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>>>
>>>
mprobst marked 2 inline comments as done.
Comment at: unittests/Format/FormatTestJS.cpp:639-640
@@ -638,3 +638,4 @@
verifyFormat("var literal = 'hello ' +\n"
- "'world';");
+ "'worldworldworldworld';",
+ getGoogleJSStyleWithColu
mprobst updated this revision to Diff 49579.
mprobst added a comment.
- Move code closer together by piping Replacements into the FormatTokenLexer.
- remove sstream import
- * Treat JavaScript single quoted string literals as tok::string_literal, not
- Address review comments, mostly renaming thin
On Wed, Mar 2, 2016 at 6:20 AM Daniel Jasper wrote:
> On Tue, Mar 1, 2016 at 9:12 PM, Daniel Jasper wrote:
>
>>
>>
>> On Mon, Feb 29, 2016 at 8:49 AM, Manuel Klimek via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Mon, Feb 29, 2016 at 5:39 PM Chandler Carruth
>>> wrote:
>>>
>>>
On Tue, Mar 1, 2016 at 9:12 PM, Daniel Jasper wrote:
>
>
> On Mon, Feb 29, 2016 at 8:49 AM, Manuel Klimek via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Mon, Feb 29, 2016 at 5:39 PM Chandler Carruth
>> wrote:
>>
>>> On Mon, Feb 29, 2016 at 11:32 AM Manuel Klimek via cfe-commits <
On Mon, Feb 29, 2016 at 8:49 AM, Manuel Klimek via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Feb 29, 2016 at 5:39 PM Chandler Carruth
> wrote:
>
>> On Mon, Feb 29, 2016 at 11:32 AM Manuel Klimek via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: klimek
>>> Dat
djasper added inline comments.
Comment at: lib/Format/Format.cpp:1131
@@ +1130,3 @@
+// and adjust ColumnWidth to take the added escapes into account.
+FormatTok->ColumnWidth = ColumnWidth;
+
Maybe add a FIXME saying that we also need to modify the TokenTe
Author: abataev
Date: Tue Mar 1 22:57:40 2016
New Revision: 262460
URL: http://llvm.org/viewvc/llvm-project?rev=262460&view=rev
Log:
[OPENMP 4.5] Codegen for data members in 'reduction' clause.
OpenMP 4.5 allows to privatize non-static data members of current class
in non-static member functions
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Nice cleanup. LGTM.
http://reviews.llvm.org/D17794
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
davide added a comment.
As an added bonus, this simplifies the code a little bit.
http://reviews.llvm.org/D17794
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davide created this revision.
davide added reviewers: silvas, rsmith, christof.
davide added a subscriber: cfe-commits.
I noticed that addHeaderInclude() returns bool although it can never fail.
I find this a little bit weird from a semantic point of view. My best guess is
that the 'bool' return
silvas added a comment.
This makes sense. LGTM.
http://reviews.llvm.org/D17787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ariccio added a comment.
In http://reviews.llvm.org/D17688#365951, @zaks.anna wrote:
> ls ./clang/test/Analysis/malloc*
Ah, ok. Would it be ok if (for _strdup & _alloca) I just do this at the
beginning:
#if defined(_WIN32)
#define strdup _strdup
#define alloca _alloca
#endif //d
ryee88 updated this revision to Diff 49577.
http://reviews.llvm.org/D16949
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOverload.cpp
test/SemaCXX/overload-call.cpp
Index: test/SemaCXX/overload-call.cpp
===
--
ryee88 added a comment.
Yeah you’re right about this one being the original variant. I missed it when I
was reading through the tests in this file.
I’ve reworked it to reflect the new variants.
http://reviews.llvm.org/D16949
___
cfe-commits mailin
davide added a reviewer: rsmith.
davide updated this revision to Diff 49575.
davide added a comment.
Added a test. Yes, with the patch we stop immediately if we fail to parse
attributes, while the old code kept emitting diagnostics. I like the new
behaviour better, but I'll defer the decision to
Kirill, FYI.
On Thu, Feb 25, 2016 at 3:21 AM, Richard Smith
wrote:
> On Wed, Feb 24, 2016 at 5:36 AM, Alexander Kornienko via cfe-commits
> wrote:
> > Author: alexfh
> > Date: Wed Feb 24 07:36:34 2016
> > New Revision: 261738
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=261738&view=rev
alexfh added inline comments.
Comment at: clang-tidy/utils/FixItHintUtils.cpp:2
@@ +1,3 @@
+//===--- FixItHintUtils.cpp -
+// clang-tidy---===//
+//
Please fix the line break.
http://reviews.llvm.org/D17488
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks!
http://reviews.llvm.org/D17488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262442: Add a few dllimport/dllexport tests. NFC (authored
by rnk).
Changed prior to commit:
http://reviews.llvm.org/D17775?vs=49510&id=49570#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17775
Author: rnk
Date: Tue Mar 1 19:21:48 2016
New Revision: 262442
URL: http://llvm.org/viewvc/llvm-project?rev=262442&view=rev
Log:
Add a few dllimport/dllexport tests. NFC
Summary:
This change just adds tests for some corner cases of dllimport/dllexport,
primarily for some static methods.
We pla
mprobst updated this revision to Diff 49569.
mprobst marked an inline comment as done.
mprobst added a comment.
- Move code closer together by piping Replacements into the FormatTokenLexer.
- remove sstream import
- * Treat JavaScript single quoted string literals as tok::string_literal, not
- Add
zaks.anna added a comment.
Of cause, we have regression tests for (almost) everything:
ls ./clang/test/Analysis/malloc*
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
ariccio added a comment.
In http://reviews.llvm.org/D17688#365880, @zaks.anna wrote:
> I suggest to update the malloc regression test with these.
Eh? There's a malloc regression test?
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cf
On 03/01/2016 11:43 AM, Michael Matz wrote:
Hi,
On Mon, 29 Feb 2016, Jason Merrill wrote:
Also this insistence that all of "trivially copyable" is already quite
nicely specified in the C++ ABI is still not really relevant because
C++ _is not the only language out there_. I'm not sure how ofte
Author: cbieneman
Date: Tue Mar 1 18:27:15 2016
New Revision: 262429
URL: http://llvm.org/viewvc/llvm-project?rev=262429&view=rev
Log:
[CMake] Add convenience target clang-test-depends to build test dependencies.
This is useful when paired with the distribution targets to build prerequisites
fo
silvas added a comment.
makes sense. can you include a testcase? I assume we are forgetting some sort
of diagnostic without this patch.
Also, if learning about Clang's modules, I would start with `addHeaderInclude`
in lib/Frontend/FrontendActions.cpp. The module map stuff ultimately boils down
davide created this revision.
davide added reviewers: silvas, doug.gregor.
davide added a subscriber: cfe-commits.
I found this by visual inspection while trying to get up-to-speed on modules,
so I'm still uncertain how to test it. If the current one is really the actual
behaviour, then parse ca
mprobst updated this revision to Diff 49562.
mprobst marked 6 inline comments as done.
mprobst added a comment.
- Move code closer together by piping Replacements into the FormatTokenLexer.
- remove sstream import
- * Treat JavaScript single quoted string literals as tok::string_literal, not
- Add
mprobst added inline comments.
Comment at: lib/Format/Format.cpp:1087
@@ +1086,3 @@
+(Style.Quotes == FormatStyle::QS_Single &&
+ !FormatTok->TokenText.startswith("\"")) ||
+(Style.Quotes == FormatStyle::QS_Double &&
djasper wrote:
> Are th
tra updated this revision to Diff 49561.
tra marked 9 inline comments as done.
tra added a comment.
Addressed Justin's comments.
http://reviews.llvm.org/D17779
Files:
lib/CodeGen/CGCUDANV.cpp
lib/CodeGen/CGCUDARuntime.h
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCUDA/device-stub.cu
tes
zaks.anna added a comment.
I suggest to update the malloc regression test with these.
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> I just don't understand why some functions made it in this patch and not
> others (notably, why the lack of _mbsdup, which is documented on the same
> page as others you are adding).
It's partly because of the better wrapper class that was mentioned (in a
discussion that I'm having trouble fi
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Sorry for the delayed reply. I think this looks good.
http://reviews.llvm.org/D15643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
djasper added inline comments.
Comment at: include/clang/Format/Format.h:606
@@ +605,3 @@
+ /// \brief The QuoteStyle to use for JavaScript strings.
+ QuoteStyle Quotes;
+
As this only affects JavaScript and doesn't make any sense for Java or C++, I'd
like to h
Author: nico
Date: Tue Mar 1 17:16:44 2016
New Revision: 262420
URL: http://llvm.org/viewvc/llvm-project?rev=262420&view=rev
Log:
clang-cl: Implement initial limited support for precompiled headers.
In the gcc precompiled header model, one explicitly runs clang with `-x
c++-header` on a .h file
thakis closed this revision.
thakis marked 3 inline comments as done.
thakis added a comment.
r262420, thanks!
http://reviews.llvm.org/D17695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
hans added a comment.
lgtm2
Comment at: include/clang/Driver/Job.h:142
@@ +141,3 @@
+/// Like Command, but always pretends that the wrapped command succeeded.
+/// the primary command crashes.
+class ForceSuccessCommand : public Command {
The second sentence loo
chaoren created this revision.
chaoren added reviewers: kparzysz, bkramer.
chaoren added a subscriber: cfe-commits.
LLVM_PREFIX could be undefined if CMAKE_INSTALL_PREFIX were set to empty.
http://reviews.llvm.org/D17784
Files:
lib/Driver/ToolChains.cpp
Index: lib/Driver/ToolChains.cpp
==
Author: rksimon
Date: Tue Mar 1 16:38:33 2016
New Revision: 262418
URL: http://llvm.org/viewvc/llvm-project?rev=262418&view=rev
Log:
Updated SSE41 builtin tests to more closely match the llvm fast-isel equivalent
tests
Modified:
cfe/trunk/test/CodeGen/sse41-builtins.c
Modified: cfe/trunk/t
jlebar added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:168
@@ -163,1 +167,3 @@
+/// of global scope device-side variables generated in this module
+/// with the CUDA runtime.
/// \code
This is kind of hard to parse. How about rephrasing to something
RKSimon updated this revision to Diff 49552.
RKSimon added a comment.
Thanks - I've removed adding XSAVE to btver2, as long as nobody thinks we need
to keep it to be explicit?
Repository:
rL LLVM
http://reviews.llvm.org/D17682
Files:
lib/Basic/Targets.cpp
test/Preprocessor/predefined-ar
Author: rjmccall
Date: Tue Mar 1 16:18:03 2016
New Revision: 262414
URL: http://llvm.org/viewvc/llvm-project?rev=262414&view=rev
Log:
Mangle extended qualifiers in the proper order and mangle the
ARC ownership-convention function type modifications.
According to the Itanium ABI, vendor extended
steven_wu updated this revision to Diff 49549.
steven_wu added a comment.
I did some more digging of the issue. It seems ObjCSubscriptRefExpr always
rebuilds and hinds both base and key behind OpaqueValueExpr. See
ObjCSubscriptOpBuilder::rebuildAndCaptureObject so it looks the AST generated
is in
On Tue, Mar 1, 2016 at 1:00 PM, Warren Ristow <
warren_ris...@playstation.sony.com> wrote:
> wristow added a comment.
>
> In http://reviews.llvm.org/D17775#365611, @silvas wrote:
>
> > Random question:
> >
> > > We plan to enable dllimport/dllexport support for the PS4
> >
> >
> > How are you plan
No problem.
It seems I missed one of the relevant RUN lines on the first attempt. I've
fixed that in r262409.
From: steve...@apple.com [steve...@apple.com]
Sent: 01 March 2016 17:26
To: Daniel Sanders
Cc: cfe-commits@lists.llvm.org
Subject: Re: r262282 -
Author: dsanders
Date: Tue Mar 1 15:57:22 2016
New Revision: 262409
URL: http://llvm.org/viewvc/llvm-project?rev=262409&view=rev
Log:
Explicitly select IAS on one more RUN line in new embed-bitcode.c test.
This should fix clang-cmake-mips builder since MIPS does not have IAS enabled
by default (
thakis updated this revision to Diff 49544.
thakis added a comment.
forgot to `svn add` two new test files
http://reviews.llvm.org/D17695
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGroups.td
include/clang/Driver/CC1Options.td
include/clang/Driver/C
thakis added inline comments.
Comment at: lib/Driver/Driver.cpp:2355
@@ +2354,3 @@
+
+// Add pch if needed: "If you do not specify an extension as part of the
+// path name, an extension of .pch is assumed. "
hans wrote:
> Maybe add .pch if needed?
It alre
Author: djasper
Date: Tue Mar 1 15:41:58 2016
New Revision: 262402
URL: http://llvm.org/viewvc/llvm-project?rev=262402&view=rev
Log:
[clang-format] Detect constructor initializers preceded by `noexcept`.
Patch by Erik Kessler, thank you.
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
djasper closed this revision.
djasper added a comment.
Submitted as r262402. Thank you.
http://reviews.llvm.org/D17621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis updated the summary for this revision.
thakis updated this revision to Diff 49541.
thakis marked 5 inline comments as done.
thakis added a comment.
- rebase across jlebar's r261774 => implicit_inputs gone, ForceSuccessCommand
is new
- .h file is found relative to include paths => introduce
tra created this revision.
tra added reviewers: jlebar, jingyue.
tra added a subscriber: cfe-commits.
Do not generate runtime init code if we don't have anything to init.
http://reviews.llvm.org/D17780
Files:
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/device-stub.cu
Index: test/CodeGenCUDA/d
hubert.reinterpretcast added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:1658
@@ -1657,1 +1657,3 @@
} else if (FromType->isRealFloatingType() && ToType->isRealFloatingType()) {
+// FIXME: disable conversions between long double and __float128 if
+// their rep
LegalizeAdulthood added a comment.
Squeak
http://reviews.llvm.org/D17482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
wristow added a comment.
In http://reviews.llvm.org/D17775#365611, @silvas wrote:
> Random question:
>
> > We plan to enable dllimport/dllexport support for the PS4
>
>
> How are you planning on codegenning them? The same way as we do in our
> private branch?
Yes, that's the intention.
http:
tra created this revision.
tra added reviewers: jlebar, jingyue.
tra added a subscriber: cfe-commits.
.. and register them with CUDA runtime.
This is needed for commonly used cudaMemcpy*() APIs that use address of
host-side shadow to access their counterparts on device side.
Fixes PR26340.
htt
Hi Richard,
it looks like this commit causes an assertion failure in Sema when mixing PCH
and modules. The following script is the smallest reproduction I could come up
with. Could you please have a look?
$ cat ../repro.sh
mkdir -p usr/include
mkdir -p usr/include/bsm
mkdir -p usr/include/netin
ygao added a subscriber: ygao.
Comment at: lib/Basic/Targets.cpp:2772
@@ -2771,2 +2771,3 @@
setFeatureEnabledImpl(Features, "xsaveopt", true);
+setFeatureEnabledImpl(Features, "xsave", true);
// FALLTHROUGH
Is this line necessary? Line#3027 below in
On Tue, Mar 1, 2016 at 1:42 PM,
wrote:
> I'd quite happily add them... but can I do it in another patch? I think I
> could be more thorough that way.
I'm not certain I understand the reasoning, but I also don't have
strong feelings on whether it's this patch or another. I just don't
understand w
aaron.ballman added a comment.
Some quick thoughts below.
Comment at: include/clang/Basic/Attr.td:997
@@ +996,3 @@
+ let Subjects = SubjectList<[Function], ErrorDiag,
+ "ExpectedKernelFunction">;
+}
I don't see any code that checks w
ariccio added a comment.
Is this patch all clear to go?
I hope I don't sound too pushy - I just don't want to lose momentum here.
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Maybe config options could allow addition of owning and non-owning pairs?
I'd like to do that as an extension if this path is approved.
Jon
On 1 March 2016 at 12:29, David Blaikie wrote:
> Any way to/would it be worth broadening this with an annotation or some
> such (or just a lost for now) o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262385: This patch adds doxygen comments for the intrinsincs
in the header file… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D17550?vs=48844&id=49534#toc
Repository:
rL
Author: kromanova
Date: Tue Mar 1 14:04:57 2016
New Revision: 262385
URL: http://llvm.org/viewvc/llvm-project?rev=262385&view=rev
Log:
This patch adds doxygen comments for the intrinsincs in the header file
popcntintrin.h.
The doxygen comments are automatically generated based on Sony's intrins
jbcoe added a comment.
Has anyone had a chance to look over this?
http://reviews.llvm.org/D15654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
silvas added a subscriber: silvas.
silvas added a comment.
Random question:
> We plan to enable dllimport/dllexport support for the PS4
How are you planning on codegenning them? The same way as we do in our private
branch?
http://reviews.llvm.org/D17775
___
bcraig added a comment.
In http://reviews.llvm.org/D17741#365457, @thakis wrote:
> > I think we can do this separately. A "basename" macro is easier for
> > programmers to use and no build system change needed.
>
>
> Hm, I would think that adding a flag to your CFLAGS is easier than getting
> a
On Tue, Mar 1, 2016 at 10:54 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> thakis added a comment.
>
> > I think we can do this separately. A "basename" macro is easier for
> programmers to use and no build system change needed.
>
>
> Hm, I would think that adding a flag to
Author: rnk
Date: Tue Mar 1 13:51:48 2016
New Revision: 262382
URL: http://llvm.org/viewvc/llvm-project?rev=262382&view=rev
Log:
Reword a misleading comment discussing landingpads and SEH
SEH doesn't use landingpads anymore.
Modified:
cfe/trunk/lib/CodeGen/CGException.cpp
Modified: cfe/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262379: [MSVC Compat] Correctly handle finallys nested
within finallys (authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D17752?vs=49522&id=49525#toc
Repository:
rL LLVM
http:
Author: majnemer
Date: Tue Mar 1 13:42:53 2016
New Revision: 262379
URL: http://llvm.org/viewvc/llvm-project?rev=262379&view=rev
Log:
[MSVC Compat] Correctly handle finallys nested within finallys
We'd lose track of the parent CodeGenFunction, leading us to get
confused with regard to which func
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D17752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer updated this revision to Diff 49522.
majnemer added a comment.
- Address Reid's review comments
http://reviews.llvm.org/D17752
Files:
lib/CodeGen/CGException.cpp
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGen/exceptions-seh-finally.c
Index: test/Cod
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
http://reviews.llvm.org/D16876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
That's fine, thanks.
On Tue, Mar 1, 2016 at 10:52 AM Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
> Hi Dmitri,
> Thank you for your reply. I have double-checked that compiling a test
> invoking an intrinsic that has C++ style doxygen comments in the
> corresponding header doesn't
xur marked an inline comment as done.
Comment at: lib/CodeGen/CodeGenModule.cpp:154
@@ +153,3 @@
+assert(!CodeGenOpts.ProfileInstrumentUsePath.empty() &&
+ "Need to explicitly specify the profile name.");
+auto ReaderOrErr = llvm::IndexedInstrProfReader::create(
thakis added a comment.
> I think we can do this separately. A "basename" macro is easier for
> programmers to use and no build system change needed.
Hm, I would think that adding a flag to your CFLAGS is easier than getting all
your dependencies to use a clang-only new macro…
http://reviews
wristow created this revision.
wristow added reviewers: cfe-commits, rnk, majnemer.
This change just adds tests for some corner cases of dllimport/dllexport,
primarily for some static methods.
We plan to enable dllimport/dllexport support for the PS4, and these
additional tests are for points we
Hi Dmitri,
Thank you for your reply. I have double-checked that compiling a test invoking
an intrinsic that has C++ style doxygen comments in the corresponding header
doesn't cause compile-time errors/warnings in
-std=c89 (and in gnu89, c99, gnu99, c11, gnu11) modes.
I will continue committing
nemanjai updated this revision to Diff 49508.
nemanjai added a comment.
Removed questionable macro definitions.
Renamed the test function for invalid conversions and changed the semantics so
that it allows __float128 <-> long double conversions only if the two types
have the same representation
I'd quite happily add them... but can I do it in another patch? I think I
could be more thorough that way.
For the same reason, can we list all the microsoft memory allocating
routines here? There are a thousand routines we might want to add, and then
a few others (like _dupenv_s, _malloca, and _e
dblaikie added a comment.
Are there not any existing cases that test this diagnostic?
Could you just update some existing cases to cover this? (it looks like, in the
same file, the test case added for PR 6117 could be expanded to test this as
well, perhaps?) It looks like that's the original te
bcraig added a comment.
LGTM. You should probably wait for someone else to approve it though.
http://reviews.llvm.org/D17741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbarton closed this revision.
kbarton added a comment.
Committed r262359
http://reviews.llvm.org/D17637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
weimingz added a comment.
In http://reviews.llvm.org/D17741#364954, @thakis wrote:
> In http://reviews.llvm.org/D17741#364931, @weimingz wrote:
>
> > In http://reviews.llvm.org/D17741#364756, @thakis wrote:
> >
> > > Instead of doing this, would it make sense to have a flag like
> > > -ffile-bas
Author: kbarton
Date: Tue Mar 1 12:11:28 2016
New Revision: 262359
URL: http://llvm.org/viewvc/llvm-project?rev=262359&view=rev
Log:
[PPC64][VSX] Add short, char, and bool data type for vec_vsx_ld and vec_vsx_st
intrinsics
Issue: https://llvm.org/bugs/show_bug.cgi?id=26720
Fix compile error wh
alexfh added a comment.
As David noted, there are other similar classes like `llvm::StringRef`,
`llvm::ArraryRef`, `gsl::span`, `StringPiece` (in various Google projects, e.g.
https://github.com/google/re2/blob/master/re2/stringpiece.h) and numerous other
in different code bases. I think, we sh
Author: mzuckerm
Date: Tue Mar 1 11:49:03 2016
New Revision: 262355
URL: http://llvm.org/viewvc/llvm-project?rev=262355&view=rev
Log:
[CLANG][AVX512][BUILTIN] Adding PSRL{DI|QI}{128|256|512} builtin
Differential Revision: http://reviews.llvm.org/D17714
Modified:
cfe/trunk/include/clang/Basi
arsenm added inline comments.
Comment at: include/clang/Basic/Attr.td:993-998
@@ +992,8 @@
+
+def AMDGPUToolsInsertNops : InheritableAttr {
+ let Spellings = [GNU<"amdgpu_tools_insert_nops">];
+ let Documentation = [AMDGPUToolsInsertNopsDocs];
+ let Subjects = SubjectList<[Func
rnk added inline comments.
Comment at: lib/CodeGen/CGException.cpp:1680-1682
@@ -1679,4 +1679,5 @@
StartFunction(GlobalDecl(), RetTy, Fn, FnInfo, Args,
OutlinedStmt->getLocStart(), OutlinedStmt->getLocStart());
+ CurCodeDecl = ParentCGF.CurCodeDecl;
--
Any way to/would it be worth broadening this with an annotation or some
such (or just a lost for now) of types that maintain references to their
ctor params? (Eg: llvm arrayref, etc)
On Mar 1, 2016 9:19 AM, "Jonathan B Coe via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> jbcoe created this
dblaikie added a subscriber: dblaikie.
dblaikie added a comment.
Any way to/would it be worth broadening this with an annotation or some
such (or just a lost for now) of types that maintain references to their
ctor params? (Eg: llvm arrayref, etc)
Repository:
rL LLVM
http://reviews.llvm.org/D
1 - 100 of 136 matches
Mail list logo
