Re: [PATCH] D16582: fix array index out of bounds

This revision was automatically updated to reflect the committed changes. Closed by commit rL258911: Fix array index out of bounds (authored by danielmarjamaki). Changed prior to commit: http://reviews.llvm.org/D16582?vs=45991&id=46102#toc Repository: rL LLVM http://reviews.llvm.org/D16582

r258911 - Fix array index out of bounds

Author: danielmarjamaki Date: Wed Jan 27 01:33:50 2016 New Revision: 258911 URL: http://llvm.org/viewvc/llvm-project?rev=258911&view=rev Log: Fix array index out of bounds Differential Revision: http://reviews.llvm.org/D16582 Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp Modified: cfe/tr

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rjmccall added a comment. In http://reviews.llvm.org/D15120#336996, @hubert.reinterpretcast wrote: > In http://reviews.llvm.org/D15120#336891, @rjmccall wrote: > > > > The C committee decided that "undefined behavior" was what they could > > > agree on for this sort of case. > > > > > > That's o

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood updated this revision to Diff 46101. LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. Update from comments: - leave existing raw string literals unchanged - don't change UTF-8, UTF-16, UTF-32 or wide character string literals - apply changes

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 added inline comments. Comment at: test/Parser/opencl-image-access.cl:9 @@ -7,1 +8,3 @@ +#if CL20 __kernel void f__rw(__read_write image2d_t a) { } +#endif Anastasia wrote: > Btw, I can see that read_write is now accepted even if -cl-std=CL1.1. So > esse

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added a comment. In http://reviews.llvm.org/D15120#336891, @rjmccall wrote: > > The C committee decided that "undefined behavior" was what they could agree > > on for this sort of case. > > > That's only when the operand value is actually outside of the range of the > typ

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

pxli168 marked 6 inline comments as done. pxli168 added a comment. I will separate this patch into small ones. Comment at: lib/Sema/SemaDecl.cpp:5724 @@ +5723,3 @@ + R->isPipeType()) { +Diag(D.getIdentifierLoc(), + diag::err_opencl_type_can_only_be_used_as_funct

Re: [PATCH] D15636: Reduce false positives in printf/scanf format checker

rtrieu added a comment. It looks like you are limiting to one diagnostic per printf, no matter the number of format strings. How is the case when multiple format strings would trigger the warning? http://reviews.llvm.org/D15636 ___ cfe-commits ma

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rjmccall added a comment. In http://reviews.llvm.org/D15120#336855, @hubert.reinterpretcast wrote: > In http://reviews.llvm.org/D15120#336827, @rjmccall wrote: > > > Here's the thing, though: I don't think there's a reasonable language > > solution here besides saying that float128_t has higher

Re: [PATCH] D16498: AMDGPU: Add amdgcn cube builtins

arsenm closed this revision. arsenm added a comment. r258794 http://reviews.llvm.org/D16498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258902 - Adding a test for PR25717.

Author: ygao Date: Tue Jan 26 20:18:28 2016 New Revision: 258902 URL: http://llvm.org/viewvc/llvm-project?rev=258902&view=rev Log: Adding a test for PR25717. The test tries to produce a large preprocessed output to the console, and checks that we do not see any unexpected fatal errors. The test

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

george.burgess.iv added a reviewer: hfinkel. george.burgess.iv updated this revision to Diff 46088. george.burgess.iv added a comment. +hfinkel as a reviewer, because `git` said he originally added the tests I'm removing. I played around a bit, and it turns out that we don't generate correct mac

Re: [PATCH] D16529: [clang-tidy] Add modernize-raw-string-literal check

LegalizeAdulthood added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:35 @@ +34,3 @@ + const bool HasBackSlash = Text.find(R"(\\)") != StringRef::npos; + const bool HasNewLine = Text.find(R"(\n)") != StringRef::npos; + const bool HasQuote = Text.fi

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

ahatanak abandoned this revision. ahatanak added a comment. Abandoning this patch as I've removed -Wpadded in r258900. http://reviews.llvm.org/D15897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[libcxx] r258900 - [libcxx] Remove -Wpadded from buildit script.

Author: ahatanak Date: Tue Jan 26 19:55:11 2016 New Revision: 258900 URL: http://llvm.org/viewvc/llvm-project?rev=258900&view=rev Log: [libcxx] Remove -Wpadded from buildit script. Per discussion with Eric and Joerg, this commit removes -Wpadded to silence the warning about the padding inserted a

r258896 - [analyzer] ObjCDeallocChecker: Only operate on classes with retained properties.

Author: dcoughlin Date: Tue Jan 26 19:41:58 2016 New Revision: 258896 URL: http://llvm.org/viewvc/llvm-project?rev=258896&view=rev Log: [analyzer] ObjCDeallocChecker: Only operate on classes with retained properties. Previously the ObjC Dealloc Checker only checked classes with ivars, not retaine

Re: [PATCH] D5023: [analyzer] Fix ObjC Dealloc Checker to operate only on classes with retained properties

This revision was automatically updated to reflect the committed changes. Closed by commit rL258896: [analyzer] ObjCDeallocChecker: Only operate on classes with retained properties. (authored by dcoughlin). Changed prior to commit: http://reviews.llvm.org/D5023?vs=45756&id=46087#toc Repository

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added a comment. In http://reviews.llvm.org/D15120#336827, @rjmccall wrote: > Here's the thing, though: I don't think there's a reasonable language > solution here besides saying that float128_t has higher rank. You can't make > the types incompatible, because it's clear

Re: r258504 - Change of UserLabelPrefix default value from "_" to ""

I reverted this change with r258894, as it breaks (at least) sparc-rtems. Clearly this area of the code was not sufficiently covered by the testsuite. On Fri, Jan 22, 2016 at 10:24 AM, Andrey Bokhanko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: asbokhan > Date: Fri Jan 22 09:24

Re: [PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

ahatanak added inline comments. Comment at: lib/CodeGen/ModuleBuilder.cpp:219 @@ -211,2 +218,3 @@ + } } Is it possible to avoid the code duplication if the condition is inverted as shown below? if (!Diags.hasErrorOccurred()) // call Builder->Releas

r258894 - Revert "Change of UserLabelPrefix default value from "_" to """

Author: jyknight Date: Tue Jan 26 19:04:51 2016 New Revision: 258894 URL: http://llvm.org/viewvc/llvm-project?rev=258894&view=rev Log: Revert "Change of UserLabelPrefix default value from "_" to """ This reverts commit r258504. This commit breaks (at least) sparc-rtems -- the OS (RTEMS) used to

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rjmccall added a comment. In http://reviews.llvm.org/D15120#336776, @hubert.reinterpretcast wrote: > In http://reviews.llvm.org/D15120#336430, @rjmccall wrote: > > > As I understand it, PPC's long-double (~103 bits of precision) is still > > strictly less precise than float128_t (113 bits of pre

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added inline comments. Comment at: lib/Driver/Tools.cpp:5520 @@ +5519,3 @@ +A->claim(); +if ((StringRef(A->getValue(0)) == "-fprofile-ir-instr") && +(Args.hasArg(options::OPT_fprofile_instr_generate) || This is definitely not the right thing

[libcxx] r258893 - Fix broken commit r258888. I missed adding two pointer conversions

Author: ericwf Date: Tue Jan 26 18:49:20 2016 New Revision: 258893 URL: http://llvm.org/viewvc/llvm-project?rev=258893&view=rev Log: Fix broken commit r25. I missed adding two pointer conversions Modified: libcxx/trunk/include/forward_list Modified: libcxx/trunk/include/forward_list URL:

Re: [PATCH] D16613: Use LLVM's CheckAtomic cmake module to figure out whether we need to link with libatomic.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D16613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D16613: Use LLVM's CheckAtomic cmake module to figure out whether we need to link with libatomic.

vkalintiris created this revision. vkalintiris added reviewers: dsanders, mclow.lists, EricWF, jroelofs. vkalintiris added a subscriber: cfe-commits. This fixes the tests under std/atomics for 32-bit MIPS CPUs where the 8-byte atomic operations call into the libatomic library. http://reviews.llvm

Buildbot numbers for week of 1/17/2016 - 1/23/2016

Hello everyone, Below are some buildbot numbers for the last week of 1/17/2016 - 1/23/2016. Thanks Galina Number of commits by project: project | commits ---+--- llvm | 315 cfe |86

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added a comment. In http://reviews.llvm.org/D15120#336430, @rjmccall wrote: > As I understand it, PPC's long-double (~103 bits of precision) is still > strictly less precise than float128_t (113 bits of precision), so it ought to > be have lower rank. Is there actually a

[libcxx] r258888 - [libcxx] Fix undefined behavior in forward_list

Author: ericwf Date: Tue Jan 26 18:11:54 2016 New Revision: 25 URL: http://llvm.org/viewvc/llvm-project?rev=25&view=rev Log: [libcxx] Fix undefined behavior in forward_list Summary: This patch is similar to the fix but it has a few differences. This patch doesn't use a `__link_pointer`

Re: [PATCH] D15836: [libcxx] Fix undefined behavior in forward_list

This revision was automatically updated to reflect the committed changes. Closed by commit rL25: [libcxx] Fix undefined behavior in forward_list (authored by EricWF). Changed prior to commit: http://reviews.llvm.org/D15836?vs=46071&id=46073#toc Repository: rL LLVM http://reviews.llvm.or

Re: [PATCH] D15836: [libcxx] Fix undefined behavior in forward_list

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Accepting on phab to reflect @mclow.lists LGTM. Comment at: include/forward_list:369 @@ +368,3 @@ +} +__node_pointer __get_node_unchec

Re: [PATCH] D15836: [libcxx] Fix undefined behavior in forward_list

EricWF updated this revision to Diff 46071. EricWF added a comment. Address @mclow.lists comment about `__get_node_unchecked()`'s name. http://reviews.llvm.org/D15836 Files: include/__config include/forward_list test/std/containers/sequences/forwardlist/incomplete.pass.cpp Index: test/st

[libcxx] r258887 - Merging r258403:

Author: hans Date: Tue Jan 26 18:07:27 2016 New Revision: 258887 URL: http://llvm.org/viewvc/llvm-project?rev=258887&view=rev Log: Merging r258403: r258403 | dsanders | 2016-01-21 07:35:15 -0800 (Thu, 21 Jan 2016) | 7 lines

Re: [libcxx] r258403 - [libcxx] Add appropriate 'REQUIRE' directives to tests that require en_US.UTF-8.

As per the discussion on http://reviews.llvm.org/D16408, I've merged this in r258887. On Thu, Jan 21, 2016 at 9:36 AM, Daniel Sanders wrote: > I'm not sure why my reply-all dropped Hans from the recipients. Re-added > him. > > > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On B

r258886 - [analyzer] Body farm: Look for property ivar in shadowing readwrite property.

Author: dcoughlin Date: Tue Jan 26 17:58:48 2016 New Revision: 258886 URL: http://llvm.org/viewvc/llvm-project?rev=258886&view=rev Log: [analyzer] Body farm: Look for property ivar in shadowing readwrite property. After r251874, readonly properties that are shadowed by a readwrite property in a c

Re: [PATCH] D16593: [CUDA] Implemented device-side support for functions in .

This revision was automatically updated to reflect the committed changes. Closed by commit rL258880: [CUDA] Implemented device-side support functions in . (authored by tra). Changed prior to commit: http://reviews.llvm.org/D16593?vs=46055&id=46066#toc Repository: rL LLVM http://reviews.llvm

r258880 - [CUDA] Implemented device-side support functions in .

Author: tra Date: Tue Jan 26 17:37:29 2016 New Revision: 258880 URL: http://llvm.org/viewvc/llvm-project?rev=258880&view=rev Log: [CUDA] Implemented device-side support functions in . CUDA expects math functions in std:: namespace to work on device side. In order to make it work with clang withou

Re: [libcxx] r249798 - Split out of .

> Eric, Marshall, what do you think about using only /*...*/-style comments in these headers, to handle the case where libc++ is somehow in the include path for a C89 compilation? I'm NOT OK with this in general. These are C++ standard library headers that are written in C++. These headers should

[PATCH] D16607: Implementation of PS4 ABI, round 1

Sunil_Srivastava created this revision. Sunil_Srivastava added a reviewer: rsmith. Sunil_Srivastava added a subscriber: cfe-commits. We are planning to upstream changes needed for maintaining PS4 ABI across future releases. Unlike many other targets, we need to maintain, in most cases, strict ob

r258877 - [WinEH] Annotate calls to __RTtypeid with a funclet bundle

Author: majnemer Date: Tue Jan 26 17:14:47 2016 New Revision: 258877 URL: http://llvm.org/viewvc/llvm-project?rev=258877&view=rev Log: [WinEH] Annotate calls to __RTtypeid with a funclet bundle Clang's CodeGen has several paths which end up invoking or calling a function. The one that we used for

[PATCH] D16605: Implement `std::experimental::ostream_joiner`

mclow.lists created this revision. mclow.lists added reviewers: EricWF, howard.hinnant. mclow.lists added a subscriber: cfe-commits. This is part of the Library Fundamentals 2 TS http://reviews.llvm.org/D16605 Files: include/experimental/iterator test/std/experimental/iterator/nothing_to_do.

Re: [PATCH] D16593: [CUDA] Implemented device-side support for functions in .

tra added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:33 @@ +32,3 @@ +// builtins if CUDA does not provide a suitable function. +// We also provide device-side std::abs() for integer types. + jlebar wrote: > Why is std::abs a special case that ne

Re: [PATCH] D16593: [CUDA] Implemented device-side support for functions in .

tra updated this revision to Diff 46055. tra marked 6 inline comments as done. tra added a comment. Fixed few issues revealed by -Wdouble-promotion http://reviews.llvm.org/D16593 Files: lib/Headers/CMakeLists.txt lib/Headers/__clang_cuda_cmath.h lib/Headers/__clang_cuda_runtime_wrapper.h

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL258870: Fix Clang-tidy modernize-use-override warning in unittests/clang… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D16566?vs=45938&id=46054#toc Repository: rL LLV

[clang-tools-extra] r258870 - Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes.

Author: eugenezelenko Date: Tue Jan 26 16:32:24 2016 New Revision: 258870 URL: http://llvm.org/viewvc/llvm-project?rev=258870&view=rev Log: Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes. Differential revision: http://reviews.llvm

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

george.burgess.iv added a comment. > I think we will also need to forbid the invalid conversions too at some point. test/SemaOpenCL/vector_conv_invalid.cl checks that clang gives you errors converting e.g. a `4 x unsigned` to a `4 x int`. So, unless you were referring to something else, that s

Re: [PATCH] D15721: [Sema] Fix ICE on casting a vector of bools to a vector of T

george.burgess.iv updated this revision to Diff 46053. george.burgess.iv marked an inline comment as done. george.burgess.iv added a comment. Updated comment, as requested. http://reviews.llvm.org/D15721 Files: lib/Sema/SemaExpr.cpp lib/Sema/SemaType.cpp test/CodeGen/bool-vector-conversio

Re: [PATCH] D16475: Remove autoconf support

This revision was automatically updated to reflect the committed changes. Closed by commit rL258864: Remove autoconf support (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D16475?vs=45709&id=46045#toc Repository: rL LLVM http://reviews.llvm.org/D16475 Files: cla

[clang-tools-extra] r258864 - Remove autoconf support

Author: cbieneman Date: Tue Jan 26 15:31:36 2016 New Revision: 258864 URL: http://llvm.org/viewvc/llvm-project?rev=258864&view=rev Log: Remove autoconf support Summary: This patch is provided in preparation for removing autoconf on 1/26. The proposal to remove autoconf on 1/26 was discussed on t

Re: [PATCH] D16593: [CUDA] Implemented device-side support for functions in .

tra updated this revision to Diff 46041. tra marked 3 inline comments as done. tra added a comment. Added missing :: http://reviews.llvm.org/D16593 Files: lib/Headers/CMakeLists.txt lib/Headers/__clang_cuda_cmath.h lib/Headers/__clang_cuda_runtime_wrapper.h Index: lib/Headers/__clang_cud

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

On Tue, Jan 26, 2016 at 07:43:03PM +, Akira Hatanaka via cfe-commits wrote: > ahatanak added a comment. > > Do you mean "-Wpadded -Wno-error=padded" instead of padding? > > I'm looking for a way to silence the warning, so that isn't enough. If > we need more time to decide whether we want to

Re: [PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 46034. aaboud marked 6 inline comments as done. aaboud added a comment. Added comments explaining the implementation. http://reviews.llvm.org/D16135 Files: include/clang/AST/ASTConsumer.h lib/AST/ASTConsumer.cpp lib/CodeGen/CGDebugInfo.cpp lib/CodeGe

Re: [PATCH] D16584: [libcxx] Work around for clang calling GAS after having already failed.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Obviously LGTM. @hans I'm OK with this going into 3.8. http://reviews.llvm.org/D16584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[libcxx] r258855 - Remove dead code missed in r258852.

Author: ericwf Date: Tue Jan 26 14:31:01 2016 New Revision: 258855 URL: http://llvm.org/viewvc/llvm-project?rev=258855&view=rev Log: Remove dead code missed in r258852. Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL: http://llvm.org/viewvc/llvm-pro

Re: [PATCH] D16344: [libcxx] Fix PR26103 - Error calling is_convertible with incomplete type

EricWF closed this revision. EricWF added a comment. Committed as r258852. Thanks for the patch. http://reviews.llvm.org/D16344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r258852 - Fix PR26103 - Error calling is_convertible with incomplete type. Patch from Michael Daniels.

Author: ericwf Date: Tue Jan 26 14:24:30 2016 New Revision: 258852 URL: http://llvm.org/viewvc/llvm-project?rev=258852&view=rev Log: Fix PR26103 - Error calling is_convertible with incomplete type. Patch from Michael Daniels. Modified: libcxx/trunk/include/type_traits libcxx/trunk/test/s

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

EricWF added a subscriber: EricWF. EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. LGTM. @dsanders: What platform are you on that doesn't have en_US.UTF-8? If your serious about testing libc++ you should ins

Re: [PATCH] D16365: Do not define GXX_RTTI macro for C

This revision was automatically updated to reflect the committed changes. Closed by commit rL258850: Do not define GXX_RTTI macro for C. (authored by ygao). Changed prior to commit: http://reviews.llvm.org/D16365?vs=45416&id=46031#toc Repository: rL LLVM http://reviews.llvm.org/D16365 File

r258850 - Do not define GXX_RTTI macro for C.

Author: ygao Date: Tue Jan 26 14:15:02 2016 New Revision: 258850 URL: http://llvm.org/viewvc/llvm-project?rev=258850&view=rev Log: Do not define GXX_RTTI macro for C. This is same as GCC behavior (tested with GCC 4.8.2). Differential Revision: http://reviews.llvm.org/D16365 Modified: cfe/tr

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rjmccall added a comment. In http://reviews.llvm.org/D15120#336282, @nemanjai wrote: > Addressed review comments. > The key differences are: > > - No assignments or operations between entities of long double and __float128 > allowed if the two types have a different representation > - Each type

Re: [PATCH] D16593: [CUDA] Implemented device-side support for functions in .

jlebar added a comment. Missing (?) functions: - div, ldiv, lldiv, imaxdiv - imaxabs If you left these out intentionally (I forget if nvidia supports div_t), that's probably fine, but maybe add a comment? wrt the "::" comments, some are nits because I think we end up calling the right thing,

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

ahatanak added a comment. There is also a PR about splitting -Wpadded into two options: one warns about padding in the middle of a struct and the other warns about padding at the end. If the former option is used instead of -Wpadded, I believe it's possible to remove the pragmas that are curren

Re: [PATCH] D15897: [libc++] Silence warning about padding inserted at the tail of struct _Rep_base

ahatanak added a comment. Do you mean "-Wpadded -Wno-error=padded" instead of padding? I'm looking for a way to silence the warning, so that isn't enough. If we need more time to decide whether we want to use -Wpadded (for both buildit and cmake), I think I'll just remove -Wpadded from buildit'

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson added a comment. Ping. @rsmith - would you also mind clarifying the comment regarding `setConcept(bool IC)` at to whether it should exist at all or simply not have any params? http://reviews.llvm.org/D13357 ___ cfe-commits mailing list cfe

Re: [PATCH] D16586: Make clang AAPCS compliant w.r.t volatile bitfield accesses

rjmccall added a comment. Well, that's certainly an interesting ABI rule. A few high-level notes: 1. AAPCS requires the bit-field to be loaded on a store, even if the store fills the entire container; that doesn't seem to be implemented in your patch. 2. Especially because of #1, let's not do

r258839 - [MS ABI] Allow a member pointers' converted type to change

Author: majnemer Date: Tue Jan 26 13:30:26 2016 New Revision: 258839 URL: http://llvm.org/viewvc/llvm-project?rev=258839&view=rev Log: [MS ABI] Allow a member pointers' converted type to change Member pointers in the MS ABI are tricky for a variety of reasons. The size of a member pointer is inde

[PATCH] D16593: [CUDA] Implemented device-side support for functions in .

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. CUDA expects math functions in std:: namespace to work on device side. In order to make it work with clang without allowing device-side code generation for functions w/o appropriate target attributes, thi

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

mcrosier added inline comments. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">, + Help

Re: r258307 - [OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.

Did that fix land, and should it be merged to 3.8? On Thu, Jan 21, 2016 at 7:03 PM, Alexey Bataev wrote: > Later today I will post another fix, that will fix all 'sections' > related troubles, including this one. So I don't think it is necessary > to merge it > > Best regards, > Alexey Bataev > =

Re: [libcxx] r249798 - Split out of .

Eric, Marshall: has there been any progress here? On Wed, Jan 20, 2016 at 10:29 AM, Hans Wennborg wrote: > /sub > > On Wed, Jan 20, 2016 at 4:45 AM, Nico Weber via cfe-commits > wrote: >> Eric, Marshall: another ping. This should be fixed on the 3.8 branch, so it >> needs to be resolved soon. >>

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

Eugene.Zelenko added inline comments. Comment at: unittests/clang-tidy/IncludeInserterTest.cpp:101 @@ -100,3 +100,3 @@ : IncludeInserterCheckBase(CheckName, Context) {} - virtual ~CXXSystemIncludeInserterCheck() {} + ~CXXSystemIncludeInserterCheck() override = default;

Re: [PATCH] D16408: [libcxx] Additional 'REQUIRE' directives for tests that require en_US.UTF-8.

hans added a comment. Ping? This and r258403 are on my watch-list for 3.8. http://reviews.llvm.org/D16408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r258107 - Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as http://reviews.llvm.org/D16262

On Tue, Jan 19, 2016 at 9:21 AM, Hans Wennborg wrote: > On Tue, Jan 19, 2016 at 12:01 AM, Dimitry Andric wrote: >> On 19 Jan 2016, at 01:50, Marshall Clow via cfe-commits >> wrote: >>> >>> Author: marshall >>> Date: Mon Jan 18 18:50:37 2016 >>> New Revision: 258107 >>> >>> URL: http://llvm.org/

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

tra added inline comments. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">, + HelpText<

r258836 - Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

Author: eugenezelenko Date: Tue Jan 26 13:01:06 2016 New Revision: 258836 URL: http://llvm.org/viewvc/llvm-project?rev=258836&view=rev Log: Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D16567 Modified: cfe/trunk/include/clan

Re: [PATCH] D16567: [Clang] Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL258836: Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D16567?vs=45941&id=46016#toc Repository: rL LLV

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

mcrosier added inline comments. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">, + Help

[clang-tools-extra] r258835 - Test commit. Fix typo in comment.

Author: jbcoe Date: Tue Jan 26 12:55:55 2016 New Revision: 258835 URL: http://llvm.org/viewvc/llvm-project?rev=258835&view=rev Log: Test commit. Fix typo in comment. Modified: clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp Modified: clang-tools-extra/trunk/clang-ti

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

mcrosier added a subscriber: mcrosier. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">,

Re: [PATCH] D16553: [OpenMP] Parsing + sema for target parallel directive.

arpith-jacob closed this revision. arpith-jacob added a comment. Committed revision 258832. I had to modify test cases 'target_parallel_reduction_messages.cpp' and 'target_parallel_map_messages.cpp' to use the updated error messages from patches recently committed to trunk. http://reviews.llv

Re: [PATCH] D16591: Add backend dignostic printer for unsupported features

ast added a comment. looks good. could you add a testcase for DK_Unsupported ? Repository: rL LLVM http://reviews.llvm.org/D16591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r258834 - Class Property: parse property attribute (class).

Author: mren Date: Tue Jan 26 12:52:43 2016 New Revision: 258834 URL: http://llvm.org/viewvc/llvm-project?rev=258834&view=rev Log: Class Property: parse property attribute (class). This is the third patch in a series of patches to support class properties in addition to instance properties in obj

Re: [PATCH] D16351: [FIX] Bug 25404 - Crash on typedef in OpenCL 2.0

arsenm added a subscriber: arsenm. arsenm added a comment. Add cfe-commits http://reviews.llvm.org/D16351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Merge OpenCL 2.0 Pipe builtins (r258782) in 3.8

Hi Hans, Could you please merge Clang commit r258782 into release 3.8. It adds Pipe BIFs to be used along with Pipe type committed earlier (in r257254). Thanks, Anastasia ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

nemanjai updated this revision to Diff 45998. nemanjai added a comment. Addressed review comments. The key differences are: - No assignments or operations between entities of long double and __float128 allowed if the two types have a different representation - Each type has a distinct rank This

r258824 - Use instance_properties instead of properties. NFC.

Author: mren Date: Tue Jan 26 12:05:23 2016 New Revision: 258824 URL: http://llvm.org/viewvc/llvm-project?rev=258824&view=rev Log: Use instance_properties instead of properties. NFC. All current properties are instance properties. This is the second patch in a series of patches to support class

[PATCH] D16591: Add backend dignostic printer for unsupported features

olista01 created this revision. olista01 added reviewers: ast, sunfish, tstellarAMD. olista01 added a subscriber: cfe-commits. olista01 set the repository for this revision to rL LLVM. The related LLVM patch adds a backend diagnostic type for reporting unsupported features, this adds a printer for

Re: [PATCH] D16572: PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression

DmitryPolukhin added a comment. I didn't introduce a leak because I pass ownership of the Buffer to EnterTokenStream (i.e. pass true as the last argument OwnsTokens). ASan also doesn't report a leak with my patch. Original code didn't have double free because it used call EnterTokenStream with

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL258822: [CUDA] Add -fcuda-allow-variadic-functions. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16559?vs=45915&id=46005#toc Repository: rL LLVM http://reviews.llvm.org/D1

r258822 - [CUDA] Add -fcuda-allow-variadic-functions.

Author: jlebar Date: Tue Jan 26 11:47:20 2016 New Revision: 258822 URL: http://llvm.org/viewvc/llvm-project?rev=258822&view=rev Log: [CUDA] Add -fcuda-allow-variadic-functions. Summary: Turns out the variadic function checking added in r258643 was too strict for some existing users; give them an

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

tra accepted this revision. tra added a comment. LGTM. http://reviews.llvm.org/D16559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16578: [clang-tidy] bug fix: Don't warn on partial template specialization in `misc-definitions-in-headers` check.

hokein added a comment. Yes, please help to land the patch for me :). Thanks. Repository: rL LLVM http://reviews.llvm.org/D16578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

bkramer accepted this revision. bkramer added a reviewer: bkramer. bkramer added a comment. This revision is now accepted and ready to land. Looks good to me, but I don't really now CUDA. http://reviews.llvm.org/D16559 ___ cfe-commits mailing list c

[PATCH] D16587: Fixed function params comparison. Updated docs and tests.

congliu created this revision. congliu added a reviewer: alexfh. congliu added a subscriber: cfe-commits. "checkParamTypes" may fail if the the type of some parameter is not canonical. Fixed it by comparing canonical types. And added "getCanonicalType()" and "getCanonicalDecl()" on more places t

Re: [PATCH] D16582: fix array index out of bounds

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm This code is old and super janky. =/ Repository: rL LLVM http://reviews.llvm.org/D16582 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D16586: Make clang AAPCS compliant w.r.t volatile bitfield accesses

rmaprath created this revision. rmaprath added reviewers: rjmccall, jmolloy, rengolin, olista01. rmaprath added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Lets consider the following plain struct: ``` struct S1 { char a; short b : 8; }; ``` According to the AAPCS,

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

On Tue, Jan 26, 2016 at 4:36 AM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Is this really a good idea? Yes, there are many broken configure > scripts, but at the same point, this change makes it more difficult > to detect whether an option is supported. > Of cours

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

flx added a comment. In http://reviews.llvm.org/D16517#336148, @alexfh wrote: > A high-level comment: I think, this comment > still applies. I'm also slightly > concerned about having this check in misc-, since the check isn't universally > applicable (e

Re: [PATCH] D16572: PR23057: fix use-after-free due to local token buffer in ParseCXXAmbiguousParenExpression

I don't fully understand your explanation. Is your change introducing a memory leak? (or was the old code causing a double free (if EnterTokenStream does take ownership of this argument)in addition to use-after-free?) On Tue, Jan 26, 2016 at 2:45 AM, Dmitry Polukhin via cfe-commits < cfe-commits@l

r258817 - [OpenMP] Parsing + sema for defaultmap clause.

Author: arpith Date: Tue Jan 26 10:37:23 2016 New Revision: 258817 URL: http://llvm.org/viewvc/llvm-project?rev=258817&view=rev Log: [OpenMP] Parsing + sema for defaultmap clause. Summary: This patch adds parsing + sema for the defaultmap clause associated with the target directive (among others

  1   2   >